On Mon, 27 Aug 2012 14:38:35 Mark Brown wrote:
> On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote:
>
> > - platform_set_drvdata(ams_delta_audio_platform_device,
> > - &ams_delta_audio_card);
> > -
>
On Tue, 28 Aug 2012 11:13:39 Mark Brown wrote:
> On Tue, Aug 28, 2012 at 05:13:05PM +0200, Janusz Krzysztofik wrote:
> > On Mon, 27 Aug 2012 14:38:35 Mark Brown wrote:
> > > On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote:
>
> > >
Dnia piątek, 31 sierpnia 2012 14:31:04 Mark Brown pisze:
> On Wed, Aug 29, 2012 at 07:04:48AM +0200, Janusz Krzysztofik wrote:
> > On Tue, 28 Aug 2012 11:13:39 Mark Brown wrote:
>
> > > The above looks like you already have a platform driver?
Mark,
I should have rather answ
setup,
is registered. Fix this by moving the codec registration bits up, before
the card is probed for.
Created and tested against linux-3.6-rc3
Signed-off-by: Janusz Krzysztofik
---
sound/soc/omap/ams-delta.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/soun
mplayer -ao alsa: for direct ALSA access
> - mplayer -ao pulse: via PulseAudio to test NO_PERIOD_WAKEUP feature
>
> The patches has been generated against:
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.7
>
> Janusz: Can you retest this series on OMAP1
from other users accessing the port pins by requesting an array of its
GPIO descriptors.
Signed-off-by: Janusz Krzysztofik
---
drivers/mtd/nand/raw/ams-delta.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/mtd/nand/raw/ams-delta.c b/drivers/mtd/nand/raw/ams-delta.c
index
from
the board init file.
Signed-off-by: Janusz Krzysztofik
---
Changelog:
v2: rebased on v4.18-rc1, no conflicts
arch/arm/mach-omap1/board-ams-delta.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c
b/arch/arm/mach-omap1/board-ams-d
Introduce a driver private structure and allocate it on device probe.
For now, use it instead of a static variable for storing a pointer to
serio structure. Subsequent patches will populate it with more members
as needed.
Signed-off-by: Janusz Krzysztofik
---
Changelog:
v2: rebased on v4.18-rc1
Convert the driver to an "ams-delta-serio" platform driver. For it to
be used with Amstrad Delta, register an "ams-delta-serio" platform
device from the board init file.
Signed-off-by: Janusz Krzysztofik
---
Changelog:
v2: rebased on v4.18-rc1, no conflicts
arch/arm/
-off-by: Janusz Krzysztofik
---
Changelog:
v2: rebased on v4.18-rc1, no conflicts
MAINTAINERS| 1 +
arch/arm/mach-omap1/ams-delta-fiq-handler.S| 5 +--
arch/arm/mach-omap1/ams-delta-fiq.c| 7 ++--
arch/arm/mach-omap1/ams-delta-fiq.h
nefit, the driver no longer needs to include
.
Signed-off-by: Janusz Krzysztofik
---
Changelog:
v2: - obsolete assignment of handle_simple_irq() removed from the driver
and replaced with a comment in the FIQ init file,
- rebased on v4.18-rc1, no conflicts.
arch/arm/mach-omap1/ams-d
them and releases while identifying GPIO
IRQs.
Signed-off-by: Janusz Krzysztofik
---
Changelog:
v2: rebased on v4.18-rc1, no conflicts
arch/arm/mach-omap1/ams-delta-fiq.c | 42 ++-
drivers/input/serio/ams_delta_serio.c | 30 ++---
2 files cha
Instead of exporting the FIQ buffer symbol to be used in
ams-delta-serio driver, pass it to the driver as platform_data.
Signed-off-by: Janusz Krzysztofik
---
Changelog:
v2: rebased on v4.18-rc1, no conflicts
arch/arm/mach-omap1/ams-delta-fiq.c | 6 +++---
arch/arm/mach-omap1/board
ntroduce a GPIO hog table and take over control of the
"keybrd_dataout" GPIO pin from the ams-delta-serio driver.
Signed-off-by: Janusz Krzysztofik
---
Changelog:
v2: rebased on v4.18-rc1, no conflicts
arch/arm/mach-omap1/board-ams-delta.c | 8
drivers/input/serio/ams_delta_
ork faster.
Signed-off-by: Janusz Krzysztofik
Acked-by: Linus Walleij
---
Changelog:
v2: rebased on v4.18-rc1, no conflicts
arch/arm/mach-omap1/ams-delta-fiq.c | 48 +---
arch/arm/mach-omap1/board-ams-delta.c| 41 +++-
arch/arm/mach-oma
vice
and register it from the board file. Both assign an absulute GPIO
number to the soon depreciated .gpio member of the regulator config
structure, and also build and register a GPIO lookup table so it is
ready for use by the regulator driver as soon as its upcoming update
is applied.
Signed-off-b
igned-off-by: Janusz Krzysztofik
---
Created and tested on linux-4.18-rc1
sound/soc/codecs/cx20442.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/cx20442.c b/sound/soc/codecs/cx20442.c
index 07dd33b09596..ab174b5114dc 100644
--- a/
Implement the idea suggested by Artem Bityutskiy and Tony Lindgren,
described in commit b027274d2e3a ("mtd: ams-delta: fix
request_mem_region() failure"). Use pure GPIO API as suggested by
Boris Brezillon.
Janusz Krzysztofik (7):
mtd: rawnand: ams-delta: show parent devic
of the driver to GPIO API for data I/O will be
implemented.
Signed-off-by: Janusz Krzysztofik
---
drivers/mtd/nand/raw/ams-delta.c | 59
1 file changed, 47 insertions(+), 12 deletions(-)
diff --git a/drivers/mtd/nand/raw/ams-delta.c b/drivers/mtd/nand/raw
Fix a bug where parent device symlinks aren't shown in sysfs.
While at it, make use of the default owner set by mtdcore.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
---
drivers/mtd/nand/raw/ams-delta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Simplify data read/write sub-functions by making them accept private
structure pointer instead of resolving it again from mtd_info.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
---
drivers/mtd/nand/raw/ams-delta.c | 30 +++---
1 file changed, 15
-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
Reviewed-by: Linus Walleij
---
arch/arm/mach-omap1/board-ams-delta.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c
b/arch/arm/mach-omap1/board-ams-delta.c
index
from other users accessing the port pins by requesting an array of its
GPIO descriptors.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
Reviewed-by: Linus Walleij
---
drivers/mtd/nand/raw/ams-delta.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/mtd/nand
work with any 8+-bit bidirectional GPIO port, not
only OMAP.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Linus Walleij
---
Exceprts fro timestamped boot logs showing performance degrade.
Before the change:
[5.469426] Creating 6 MTD partitions on "ams-delta-nand":
[
structure with more members as needed.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
---
drivers/mtd/nand/raw/ams-delta.c | 126 +--
1 file changed, 69 insertions(+), 57 deletions(-)
diff --git a/drivers/mtd/nand/raw/ams-delta.c b/drivers/mtd
Implement the idea suggested by Artem Bityutskiy and Tony Lindgren
described in commit b027274d2e3a ("mtd: ams-delta: fix
request_mem_region() failure").
arch/arm/mach-omap1/board-ams-delta.c | 22 -
drivers/gpio/gpio-omap.c | 88 ++
drivers/mtd/nand/raw/ams-delta.c |
structure with more members as needed.
While at it, fix missing mtd->dev.parent and drop useless mtd->owner.
Signed-off-by: Janusz Krzysztofik
---
drivers/mtd/nand/raw/ams-delta.c | 126 +--
1 file changed, 69 insertions(+), 57 deletions(-)
diff --git a/d
obtain exclusive access to the port by requesting an array of its GPIO
descriptors. For that to work on Amstrad Delta, respective GPIO lookup
table entries are added to the board init file.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-delta.c | 11 ++-
drivers/mtd
t the above described sanity checks before replacing the
readw()/writew() operations witn GPIO callbacks. If a check fails,
return -EINVAL to indicate the board provided GPIO setup is invalid.
Signed-off-by: Janusz Krzysztofik
---
drivers/mtd/nand/raw/ams-delta.c
In its current shape, the driver sets data port direction before each
byte read/write operation, even during multi-byte transfers. Optimize
that by setting the port direction only on first byte of each transfer.
Signed-off-by: Janusz Krzysztofik
---
drivers/mtd/nand/raw/ams-delta.c | 42
This should make applications utilizing whole banks work faster.
Signed-off-by: Janusz Krzysztofik
---
drivers/gpio/gpio-omap.c | 88 ++--
1 file changed, 86 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio
Initialize NWP GPIO pin low to protect the device from hazard during
probe. Release write protection as soon as the device is under
control.
Signed-off-by: Janusz Krzysztofik
---
drivers/mtd/nand/raw/ams-delta.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a
+-bit bidirectional GPIO port,
not only OMAP.
Signed-off-by: Janusz Krzysztofik
# Conflicts:
# drivers/mtd/nand/raw/ams-delta.c
---
arch/arm/mach-omap1/board-ams-delta.c | 11
drivers/mtd/nand/raw/ams-delta.c | 119 +++---
2 files changed, 52 insertions(+
Further optimize processing speed of read/write callback functions by
resolving private structure pointer only once per callback and passing
it to all subfunctions instead of mtd_info.
Signed-off-by: Janusz Krzysztofik
---
drivers/mtd/nand/raw/ams-delta.c | 44
ces to another
device.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-generic.c | 2 ++
arch/arm/mach-omap1/board-innovator.c | 7 ++-
arch/arm/mach-omap1/board-palmte.c| 2 ++
arch/arm/mach-omap1/board-palmtt.c| 2 ++
arch/arm/mach-omap1/board-palmz71.c | 2 ++
a
Hi Boris,
On Thursday, July 19, 2018 8:15:08 AM CEST Boris Brezillon wrote:
> Hi Janusz,
>
> On Thu, 19 Jul 2018 01:57:02 +0200
> Janusz Krzysztofik wrote:
>
> > Implement the idea suggested by Artem Bityutskiy and Tony Lindgren
> > described in commit b027274
On Thursday, July 19, 2018 8:17:28 AM CEST Boris Brezillon wrote:
> On Thu, 19 Jul 2018 01:57:03 +0200
> Janusz Krzysztofik wrote:
>
> > Introduce a driver private structure and allocate it on device probe.
> > Use it for storing nand_chip structure, GPIO descriptors pre
On Thursday, July 19, 2018 8:22:00 AM CEST Boris Brezillon wrote:
> On Thu, 19 Jul 2018 01:57:04 +0200
> Janusz Krzysztofik wrote:
>
> > Initialize NWP GPIO pin low to protect the device from hazard during
> > probe. Release write protection as soon as the device
On Thursday, July 19, 2018 8:23:18 AM CEST Boris Brezillon wrote:
> On Thu, 19 Jul 2018 01:57:05 +0200
> Janusz Krzysztofik wrote:
>
> > In its current shape, the driver sets data port direction before each
> > byte read/write operation, even during multi-byte transfers.
On Thursday, July 19, 2018 8:25:38 AM CEST Boris Brezillon wrote:
> On Thu, 19 Jul 2018 01:57:06 +0200
> Janusz Krzysztofik wrote:
>
> > Further optimize processing speed of read/write callback functions by
> > resolving private structure pointer only once per callback and
On Thursday, July 19, 2018 8:47:49 AM CEST Boris Brezillon wrote:
> On Thu, 19 Jul 2018 01:57:10 +0200
> Janusz Krzysztofik wrote:
>
> > Don't readw()/writew() data directly from/to GPIO port which is under
> > control of gpio-omap driver, use GPIO chip callbacks i
Hi Linus,
On Friday, July 13, 2018 9:35:06 AM CEST Linus Walleij wrote:
> On Tue, Jul 10, 2018 at 7:56 PM Janusz Krzysztofik
wrote:
> > > - .gpio = AMS_DELTA_GPIO_PIN_MODEM_NRESET,
> >
> > This is OK but not enough for clean build of board-ams-delt
a new control.
For now, rename the pin to "audio_mute" to reflect its function and,
as a quick fix, hogg it as output low so on-board audio can produce
audible sound again.
Fixes: 1137ceee76ba ("ARM: OMAP1: ams-delta: Don't request unused GPIOs")
Signed-off-by: J
Amstrad Delta NAND driver now uses GPIO API for data I/O so there is no
need to assign memory I/O resource to the device any longer. Drop it.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-delta.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/arch/arm
Don't readw()/writew() data directly from/to GPIO port which is under
control of gpio-omap driver, use GPIO consumer API instead.
The driver should now work with any 8-bit bidirectional GPIO port, not
only OMAP.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Linus Walleij
---
drivers/mtd
accessing
the port pins by requesting an array of its GPIO descriptors.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
Reviewed-by: Linus Walleij
---
drivers/mtd/nand/raw/ams-delta.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/raw
Finalize implementation of the idea suggested by Artem Bityutskiy and
Tony Lindgren, described in commit b027274d2e3a ("mtd: ams-delta: fix
request_mem_region() failure"). Use pure GPIO consumer API, as reqested
by Boris Brezillon.
Janusz Krzysztofik (4):
ARM: OMAP1: ams-delt
-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
Reviewed-by: Linus Walleij
---
arch/arm/mach-omap1/board-ams-delta.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c
b/arch/arm/mach-omap1/board-ams-delta.c
index
st depending on how the platform is configured: if the line
> is active low, it deals with that, if the line is open drain,
> it deals with that too.
>
> Cc: Janusz Krzysztofik # OMAP1
Tested-by: Janusz Krzysztofik #OMAP1 Amstrad Delta
Thanks,
Janusz
mmit 5322c19b117a ("ARM: OMAP1: ams-delta: Hog
"keybrd_dataout" GPIO pin"). In turn, the issue of missing regulator
has been fixed by commit 50c678772a0b ("ASoC: cx20442: Don't ignore
regulator_get() errors.").
Simplify the board init code by moving registrat
equivalents.
Pin naming used by the driver should be followed while respective GPIO
lookup table is initialized by a board init code.
Signed-off-by: Janusz Krzysztofik
---
Changlog:
v1: Fix handling of devm_gpiod_get_optional() return values - thanks to
Andy Shevchenko.
v2: Remove problematic error
d into current linux-next
where late_gpio_tables[] has been removed from board-ams-delta.c and its
content integrated into ams_delta_gpio_tables[].
> &ams_delta_lcd_gpio_table,
> &ams_delta_nand_gpio_table,
> };
If that makes your life easier, I can prepare a fix for board-ams-delta.c on
top of your patch. In that case you can add my:
Reviewed-by: Janusz Krzysztofik
Thanks,
Janusz
On Wednesday, May 23, 2018 8:52:44 PM CEST Tony Lindgren wrote:
> * Mark Brown [180521 10:07]:
> > On Fri, May 18, 2018 at 11:09:51PM +0200, Janusz Krzysztofik wrote:
> > > Now as the Amstrad Delta board provides GPIO lookup tables, switch from
> > > GPIO numbers to G
: add GPIO lookup tables" (already applied to
omap-for-v4.18/soc tree).
Changes since v1:
- fix handling of devm_gpiod_get_optional() return values - thanks to
Andy Shevchenko.
Signed-off-by: Janusz Krzysztofik
---
drivers/mtd/nand/raw/ams-delta.c | 120 +---
On Friday, May 18, 2018 11:09:52 PM CEST Janusz Krzysztofik wrote:
> Now as the Amstrad Delta board provides GPIO lookup tables, switch from
> GPIO numbers to GPIO descriptors and use the table to locate required
> GPIO pins.
>
> Declare static variables for storing GPIO descript
ff-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-delta.c | 116 --
1 file changed, 98 insertions(+), 18 deletions(-)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c
b/arch/arm/mach-omap1/board-ams-delta.c
index cdba8decc532..d4b26352ddde 100644
--- a/arc
there is
no need for yet another applicability check.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-delta.c | 55 +++
1 file changed, 43 insertions(+), 12 deletions(-)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c
b/arch/arm/mach-omap1
On Wednesday, May 30, 2018 11:05:00 AM CEST Boris Brezillon wrote:
> Hi Janusz,
Hi Boris,
> On Sat, 26 May 2018 00:20:45 +0200
> Janusz Krzysztofik wrote:
> > ...
> > Changes since v1:
> > - fix handling of devm_gpiod_get_optional() return values - thanks to
> >
On Wednesday, May 30, 2018 7:52:20 PM CEST Boris Brezillon wrote:
> On Wed, 30 May 2018 19:43:09 +0200
>
> Janusz Krzysztofik wrote:
> > On Wednesday, May 30, 2018 11:05:00 AM CEST Boris Brezillon wrote:
> > > Hi Janusz,
> >
> > Hi Boris,
> >
On Wednesday, May 30, 2018 7:07:11 AM CEST Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the regulator tree got a conflict in:
>
> arch/arm/mach-omap1/board-ams-delta.c
>
> between commit:
>
> 0486738928bf ("ARM: OMAP1: ams-delta: add GPIO lookup tables")
>
> from the a
On Wednesday, May 30, 2018 9:29:24 AM CEST Linus Walleij wrote:
> On Wed, May 30, 2018 at 7:07 AM, Stephen Rothwell
wrote:
> > Hi all,
> >
> > Today's linux-next merge of the regulator tree got a conflict in:
> > arch/arm/mach-omap1/board-ams-delta.c
> >
> > between commit:
> > 0486738928bf
dma_caps.residue_granularity =
DMA_RESIDUE_GRANULARITY_DESCRIPTOR from drivers/dma/omap-dma.c.
Let's do the latter.
Created and tested against next-20180531 tag from linux-next tree.
Signed-off-by: Janusz Krzysztofik
---
drivers/dma/omap-dma.c | 6 +-
1 file changed, 5 insertions(+), 1 dele
On Saturday, June 2, 2018 4:22:04 PM CEST Janusz Krzysztofik wrote:
> - by passing dma_caps.residue_granularity =
> DMA_RESIDUE_GRANULARITY_DESCRIPTOR from drivers/dma/omap-dma.c.
>
> Let's do the latter.
>
> Created and tested against next-20180531 tag from linux-n
dma_caps.residue_granularity =
DMA_RESIDUE_GRANULARITY_DESCRIPTOR from DMA engine.
Let's do the latter.
Created and tested against next-20180531 tag from linux-next tree.
Signed-off-by: Janusz Krzysztofik
---
Changelog:
v2: apply the patch against omap-dma.c moved to drivers/dma/ti/
driver
Avoid replication of error code conversion in non-DT GPIO consumers'
code by returning -EPROBE_DEFER from gpiod_find() in case a chip
identified by its label in a registered lookup table is not ready.
See https://lkml.org/lkml/2018/5/30/176 for example case.
Signed-off-by: Janusz Krzysz
igned-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
---
Changelog
v2: fix typo (latar -> later) - thanks Boris and Andy for catching this
I'm not sure if adding both Suggested-by: and Reviewed-by: heades both
with the same person name is in line with good practices, please remo
On Tuesday, July 3, 2018 7:31:41 PM CEST Boris Brezillon wrote:
> Hi Janusz,
>
> On Tue, 3 Jul 2018 19:26:35 +0200
>
> Janusz Krzysztofik wrote:
> > Avoid replication of error code conversion in non-DT GPIO consumers'
> > code by returning -EPROBE_DEFER
On Thursday, July 5, 2018 7:50:37 AM CEST Lee Jones wrote:
> On Wed, 04 Jul 2018, Janusz Krzysztofik wrote:
> > On Tuesday, July 3, 2018 7:31:41 PM CEST Boris Brezillon wrote:
> > > Hi Janusz,
> > >
> > > On Tue, 3 Jul 2018 19:26:35 +0200
> > >
&
> >> On Wed, 04 Jul 2018, Janusz Krzysztofik wrote:
> >>> On Tuesday, July 3, 2018 7:31:41 PM CEST Boris Brezillon wrote:
> >>>> On Tue, 3 Jul 2018 19:26:35 +0200 Janusz Krzysztofik wrote:
> >>>>> chip = find_chip_by_
On Wednesday, June 13, 2018 12:17:24 AM CEST Dmitry Torokhov wrote:
> On Sat, Jun 09, 2018 at 04:02:18PM +0200, Janusz Krzysztofik wrote:
> > ...
> > + priv->vcc = devm_regulator_get(&pdev->dev, "vcc");
> > + if (IS_ERR(priv->vcc
On Wednesday, June 13, 2018 12:21:04 AM CEST Dmitry Torokhov wrote:
> On Sat, Jun 09, 2018 at 04:02:23PM +0200, Janusz Krzysztofik wrote:
> > ...
> > @@ -141,14 +141,11 @@ static int ams_delta_serio_init(struct
> > platform_device *pdev)>
> > * at FIQ level, s
On Wednesday, June 13, 2018 12:23:56 AM CEST Dmitry Torokhov wrote:
> Hi Janusz,
>
> On Sat, Jun 09, 2018 at 04:02:15PM +0200, Janusz Krzysztofik wrote:
> > GPIO lookup table for ams-delta-serio device was introduced by commit
> > 0486738928bf ("ARM: OMAP1: ams-del
vice
and register it from the board file. Both assign an absulute GPIO
number to the soon depreciated .gpio member of the regulator config
structure, and also build and register a GPIO lookup table so it is
ready for use by the regulator driver as soon as its upcoming update
is applied.
Signed-off-b
- removal of hard-coded GPIO numbers from drivers,
- removal of board mach includes from drivers,
- switching to dynamically assigned GPIO numbers.
Created and compile tested agains linux-4.17-rc3
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-del
Now as the AMS Delta board header file is no longer included by
drivers, move it to the root directory of mach-omap1.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/ams-delta-fiq-handler.S | 2 +-
arch/arm/mach-omap1/ams-delta-fiq.c | 3 +--
arch/arm
linux-4.17-rc3, on top of patch 1/6 "ARM:
OMAP1: ams-delta: add GPIO lookup tables"
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-delta.c | 5 -
sound/soc/omap/ams-delta.c| 38 +++
2 files changed, 21 insertions(+
should be followed while respective GPIO
lookup table is initialized by a board init code.
Created and tested against linux-4.17-rc3, on top of patch 1/6 "ARM:
OMAP1: ams-delta: add GPIO lookup tables"
Signed-off-by: Janusz Krzysztofik
---
drivers/input/serio/ams_delta_se
: add GPIO lookup tables"
Signed-off-by: Janusz Krzysztofik
---
drivers/mtd/nand/raw/ams-delta.c | 110 +--
1 file changed, 58 insertions(+), 52 deletions(-)
diff --git a/drivers/mtd/nand/raw/ams-delta.c b/drivers/mtd/nand/raw/ams-delta.c
index 37
"ARM:
OMAP1: ams-delta: add GPIO lookup tables"
Signed-off-by: Janusz Krzysztofik
---
drivers/video/fbdev/omap/lcd_ams_delta.c | 59 ++--
1 file changed, 26 insertions(+), 33 deletions(-)
diff --git a/drivers/video/fbdev/omap/lcd_ams_delta.c
b/drivers/v
On Friday, May 18, 2018 11:21:14 PM CEST Andy Shevchenko wrote:
> On Sat, May 19, 2018 at 12:09 AM, Janusz Krzysztofik
>
> wrote:
> > + gpiod_rdy = devm_gpiod_get_optional(&pdev->dev, "rdy", GPIOD_IN);
> > + if (!IS_ERR_OR_NULL(gpiod_rdy)) {
>
s moved to machine_init by preceding
patch.
Move registration of the MODEM device to arch_initcall_sync, not to
arch_initcall, so it is never exposed to potential conflictinh
registration order hazard against OMAP serial ports.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-de
MODEM_CODEC.
Once done, remove the no longer needed GPIO based implementation of
ams_delta_latch_write() and its frontend macro.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-delta.c | 52 +++
arch/arm/mach-omap1/board-ams-delta.h | 7
descriptors.
Janusz Krzysztofik (3):
ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor
ARM: OMAP1: ams-delta: initialize latch2 pins to safe values
ARM: OMAP1: ams-delta: register MODEM device earlier
diffstat:
board-ams-delta.c | 120
aving been
already assigned.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-delta.c | 46 ++-
1 file changed, 35 insertions(+), 11 deletions(-)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c
b/arch/arm/mach-omap1/board-ams-delta.c
Fix a bug where parent device symlinks aren't shown in sysfs.
While at it, make use of the default owner set by mtdcore.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
---
drivers/mtd/nand/raw/ams-delta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
This series consist of possibly ready to apply patches extracted from
a former one titled "mtd: rawnand: ams-delta: Use GPIO API for data I/O".
Remaining patches implementing conversion of data I/O to GPIO have been
postponed until gpiolib is optimized to ensure sufficient performance
of the driver to GPIO API for data I/O will be
implemented.
Signed-off-by: Janusz Krzysztofik
---
drivers/mtd/nand/raw/ams-delta.c | 68 ++--
1 file changed, 45 insertions(+), 23 deletions(-)
diff --git a/drivers/mtd/nand/raw/ams-delta.c b/drivers/mtd/nand/raw
structure with more members as needed.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
---
drivers/mtd/nand/raw/ams-delta.c | 126 +--
1 file changed, 69 insertions(+), 57 deletions(-)
diff --git a/drivers/mtd/nand/raw/ams-delta.c b/drivers/mtd
Each controller driver having access to NAND R/B pin over GPIO would
have to reimplement the polling loop otherwise.
Suggested-by: Boris Brezillon
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
---
Changelog:
v3:
- don't surround added code with #ifdef CONFIG_GP
Replace legacy callbacks with ->select_chip() and ->exec_op().
Suggested-by: Boris Brezillon
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
---
Changelog:
v3:
- former PATCH 2/2 from which PATCH v3 2/3 has been split out,
- added missing return on check_only - reques
Replace use of legacy .IOADDR_R/W with runtime calculations based on
priv->io_base.
Suggested-by: Boris Brezillon
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Boris Brezillon
---
Changelog:
v3:
New patch, split out from former PATCH 2/2 on Boris request - thanks
drivers/mtd/nand/raw/
Now as the board header file is no longer included by drivers, move it
to the root directory of mach-omap1.
Signed-off-by: Janusz Krzysztofik
---
Changelog:
v4:
- rebased on top of v4.20-rc1
- resubmitted as a standalone patch, other patches of the series it
depended on have been already
Global GPIO numbers no longer have to be passed to leds-gpio driver,
replace their assignment with a lookup table.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-delta.c | 95 ++-
1 file changed, 26 insertions(+), 69 deletions(-)
diff --git
As all users of the board specific GPIO pins have been converted from
legacy integer-based to descriptor-based interface, there is no longer
a need to maintain statically assigned GPIO pin numbers. Drop support
for that.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams
Janusz Krzysztofik (3):
ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers
ARM: OMAP1: ams-delta: Drop unused symbols from the board header
ARM: OMAP1: ams-delta: Move AMS_DELTA_LATCH2_NGPIO to the board file
board-ams-delta.c |9 -
board-ams-delta.h
That symbol is not used outside the board file, there is no need to
keep it in the board header.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-delta.c | 6 --
arch/arm/mach-omap1/board-ams-delta.h | 2 --
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a
Those bitmap symbols defining pins of latch2 register, used with
read()/write() calls before the latch was converted to a GPIO device,
have been obsoleted by integer symbols defined inside the board file.
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-delta.h | 4
1
n NULL pointer
dereference. Fix it by checking for uninitialized pointer before using
it in modem_pm().
Fixes: aabf31737a6a ("ARM: OMAP1: ams-delta: update the modem to use regulator
API")
Signed-off-by: Janusz Krzysztofik
---
arch/arm/mach-omap1/board-ams-delta.c | 3 +++
1 file chang
ng assumption is taken about the 'values' bitmap size not
exceding the number of bits of the 'value' argument type.
Fix it.
Signed-off-by: Janusz Krzysztofik
---
Hi,
I think that patch has been missed while we were resolving issues
related to GPIO fast bitmap processing. Since
Replace legacy callbacks with ->select_chip() and ->exec_op().
In order to remove any references to legacy structure members, use of
.IO_ADDR_R/W has been replaced wit runtime calculations based on
priv->io_base.
Suggested-by: Boris Brezillon
Signed-off-by: Janusz Krzysztofik
---
1 - 100 of 239 matches
Mail list logo
