Re: [PATCH v2] arm64: Reduce verbosity on SMP CPU stop

2016-04-18 Thread Jan Glauber
On Mon, Apr 18, 2016 at 01:19:31PM +0100, Will Deacon wrote: > On Mon, Apr 18, 2016 at 09:43:33AM +0200, Jan Glauber wrote: > > On Fri, Apr 15, 2016 at 12:37:06PM +0100, Will Deacon wrote: > > > You can remove stop_lock altogether now, right? I also wonder whether > > >

Re: [PATCH v2 0/5] Cavium ThunderX uncore PMU support

2016-04-19 Thread Jan Glauber
Mark, are these patches still queued or should I repost them? --Jan On Mon, Apr 04, 2016 at 01:03:13PM +0200, Jan Glauber wrote: > Hi Mark, > > can you have a look at these patches? > > Thanks, > Jan > > 2016-03-09 17:21 GMT+01:00 Jan Glauber : > > This p

Re: [PATCH v2 0/5] Cavium ThunderX uncore PMU support

2016-04-25 Thread Jan Glauber
Hi Will, On Mon, Apr 25, 2016 at 12:22:07PM +0100, Will Deacon wrote: > Hi Jan, > > On Mon, Apr 04, 2016 at 02:19:54PM +0200, Jan Glauber wrote: > > Hi Mark, > > > > can you have a look at these patches? > > Looks like Mark reviewed this last week -- are you p

[PATCH v7 06/15] dt-bindings: i2c: Add Octeon cn78xx TWSI

2016-04-25 Thread Jan Glauber
Add compatible string for Cavium Octeon cn78XX SOCs TWSI. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Jan Glauber Acked-by: David Daney --- Documentation/devicetree/bindings/i2c/i2c-octeon.txt | 6 ++ 1 file changed, 6 insertions

[PATCH v7 12/15] i2c: octeon: Split the driver into two parts

2016-04-25 Thread Jan Glauber
Move common functionality into a separate file in preparation of the re-use from the ThunderX i2c driver. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Makefile | 3 +- drivers/i2c/busses/i2c-cavium.c | 799 + drivers/i2c/busses/i2c-cavium.h

[PATCH v7 11/15] i2c: octeon: Rename driver to prepare for split

2016-04-25 Thread Jan Glauber
This is an intermediate commit in preparation of the driver split. The module rename in this commit will be reverted in the next patch, this is just done to make the series bisectible. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Makefile| 2 +- drivers/i2c

[PATCH v7 15/15] i2c: thunderx: Add smbus alert support

2016-04-25 Thread Jan Glauber
Add smbus alert interrupt support. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-cavium.h| 6 ++ drivers/i2c/busses/i2c-thunderx-core.c | 35 ++ 2 files changed, 41 insertions(+) diff --git a/drivers/i2c/busses/i2c-cavium.h b/drivers/i2c

[PATCH v7 13/15] i2c: thunderx: Add i2c driver for ThunderX SOC

2016-04-25 Thread Jan Glauber
The ThunderX SOC uses the same i2c block as the Octeon SOC. The main difference is that on ThunderX the device is a PCI device so device probing is done via PCI, interrupts are MSIX and the clock is taken from device tree. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Kconfig

[PATCH v7 08/15] i2c: octeon: Improve performance if interrupt is early

2016-04-25 Thread Jan Glauber
on 100kHz i2c now measure ~5.2kB/s, about 1/2 what's achievable, and much better than the worst-case 100 bytes/sec before. While at it remove the debug print from the low-level wait function. Signed-off-by: Peter Swain Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c

[PATCH v7 14/15] i2c: octeon,thunderx: Move register offsets to struct

2016-04-25 Thread Jan Glauber
The register offsets are different between Octeon and ThunderX so move them into the algorithm struct and get rid of the define. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-cavium.c| 28 +-- drivers/i2c/busses/i2c-cavium.h| 35

[PATCH v7 10/15] i2c: octeon: Move read function before write

2016-04-25 Thread Jan Glauber
Just sorting the functions to be consistent with the other read/write variants. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 78 - 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon.c b

[PATCH v7 09/15] i2c: octeon: Add workaround for broken irqs on CN3860

2016-04-25 Thread Jan Glauber
From: David Daney CN3860 does not interrupt the CPU when the i2c status changes. If we get a timeout, and see the status has in fact changed, we know we have this problem, and drop back to polling. Signed-off-by: David Daney Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 53

[PATCH v7 07/15] i2c: octeon: Add support for cn78xx chips

2016-04-25 Thread Jan Glauber
From: David Daney cn78xx has a different interrupt architecture, so we have to manage the interrupts differently. Signed-off-by: David Daney Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 131 1 file changed, 120 insertions(+), 11

[PATCH v7 03/15] i2c: octeon: Remove I2C_FUNC_SMBUS_QUICK support

2016-04-25 Thread Jan Glauber
SMBUS QUICK never worked for the read case, because EINVAL was returned for a zero length message. The hardware does not support SMBUS QUICK messages so disable the support and remove the zero length check. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 5 + 1 file changed

[PATCH v7 00/15] i2c-octeon and i2c-thunderx drivers

2016-04-25 Thread Jan Glauber
2c: octeon: Add workaround for broken irqs on CN3860 Jan Glauber (10): i2c: octeon: Improve error status checking i2c: octeon: Use i2c recovery framework i2c: octeon: Remove I2C_FUNC_SMBUS_QUICK support dt-bindings: i2c: Add Octeon cn78xx TWSI i2c: octeon: Move read function before w

[PATCH v7 01/15] i2c: octeon: Improve error status checking

2016-04-25 Thread Jan Glauber
er receive mode until the last byte is requested. The state check needs to consider if this bit was set. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 129 +--- 1 file changed, 106 insertions(+), 23 deletions(-) diff --git a/drivers/i2c/

[PATCH v7 02/15] i2c: octeon: Use i2c recovery framework

2016-04-25 Thread Jan Glauber
xfer debug message (i2c core already provides a debug message for this). Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 160 1 file changed, 97 insertions(+), 63 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c

[PATCH v7 04/15] i2c: octeon: Add flush writeq helper function

2016-04-25 Thread Jan Glauber
From: Peter Swain Add helper function that reads back a value after writing to make sure the write is finished and use it in octeon_i2c_write_int(). Signed-off-by: Peter Swain Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH v7 05/15] i2c: octeon: Enable High-Level Controller

2016-04-25 Thread Jan Glauber
plus one interrupt per transferred byte. Since the interrupts are costly using the HLC improves the performance. Also, the HLC provides improved error handling. Signed-off-by: David Daney Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 345

Re: [PATCH v7 05/15] i2c: octeon: Enable High-Level Controller

2016-04-25 Thread Jan Glauber
On Mon, Apr 25, 2016 at 11:44:29PM +0200, Wolfram Sang wrote: > On Mon, Apr 25, 2016 at 04:33:34PM +0200, Jan Glauber wrote: > > From: David Daney > > > > Use High-Level Controller (HLC) when possible. The HLC can read/write > > up to 8 bytes and is completely o

Re: [PATCH v7 03/15] i2c: octeon: Remove I2C_FUNC_SMBUS_QUICK support

2016-04-25 Thread Jan Glauber
On Tue, Apr 26, 2016 at 12:16:22AM +0200, Wolfram Sang wrote: > On Mon, Apr 25, 2016 at 04:33:32PM +0200, Jan Glauber wrote: > > SMBUS QUICK never worked for the read case, because EINVAL was returned > > for a zero length message. The hardware does not support SMBUS QUICK > >

Re: [PATCH v7 03/15] i2c: octeon: Remove I2C_FUNC_SMBUS_QUICK support

2016-04-25 Thread Jan Glauber
On Tue, Apr 26, 2016 at 07:58:45AM +0200, Jan Glauber wrote: > On Tue, Apr 26, 2016 at 12:16:22AM +0200, Wolfram Sang wrote: > > On Mon, Apr 25, 2016 at 04:33:32PM +0200, Jan Glauber wrote: > > > SMBUS QUICK never worked for the read case, because EINVAL was returned >

Re: [PATCH v2 0/5] Cavium ThunderX uncore PMU support

2016-04-26 Thread Jan Glauber
On Mon, Apr 25, 2016 at 02:19:07PM +0100, Will Deacon wrote: > On Mon, Apr 25, 2016 at 02:02:22PM +0200, Jan Glauber wrote: > > On Mon, Apr 25, 2016 at 12:22:07PM +0100, Will Deacon wrote: > > > On Mon, Apr 04, 2016 at 02:19:54PM +0200, Jan Glauber wrote: > > > >

Re: [PATCH v7 03/15] i2c: octeon: Remove I2C_FUNC_SMBUS_QUICK support

2016-04-26 Thread Jan Glauber
On Tue, Apr 26, 2016 at 09:36:20AM +0200, Wolfram Sang wrote: > > > > Yes, I thought briefly about splitting SMBUS_QUICK into read-write > > > variants too. To me the question is if this feature is still used on > > > modern > > > devices or if this is more a relict of the past. I don't know enou

[PATCH] i2c: octeon: Remove zero-length message support

2016-04-26 Thread Jan Glauber
y. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c index 9f11e19..e8a65f5 100644 --- a/drivers/i2c/busses/i2c-octeon.c +++ b/drivers/i2c/

Re: [PATCH v4 03/14] i2c-octeon: Change adapter timeout and retry default values

2016-03-31 Thread Jan Glauber
On Wed, Mar 23, 2016 at 08:55:18PM +0100, Wolfram Sang wrote: > On Fri, Mar 18, 2016 at 09:46:28AM +0100, Jan Glauber wrote: > > Convert the adapter timeout to 2 ms instead of a fixed number of > > jiffies and set retries to 10. > > You describe what you change, but not why t

Re: [PATCH v4 05/14] i2c-octeon: Enable high-level controller and improve on bus contention

2016-03-31 Thread Jan Glauber
On Wed, Mar 23, 2016 at 09:32:15PM +0100, Wolfram Sang wrote: > On Fri, Mar 18, 2016 at 09:46:30AM +0100, Jan Glauber wrote: > > From: David Daney > > > > Use High Level Controller when possible. > > Can you give me a one line description what this Controller is? I&

[PATCH v5 13/14] i2c: thunderx: Add i2c driver for ThunderX SOC

2016-03-31 Thread Jan Glauber
The ThunderX SOC uses the same i2c block as the Octeon SOC. The main difference is that on ThunderX the device is a PCI device so device probing is done via PCI, interrupts are MSIX and the clock is taken from device tree. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Kconfig

[PATCH v5 11/14] i2c: octeon: Rename driver to prepare for split

2016-03-31 Thread Jan Glauber
This is just an intermediate commit in preparation of the driver split. The module rename in this commit will be reverted in the next patch, this is just done to make the series bisectible. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Makefile| 2 +- drivers/i2c

[PATCH v5 04/14] i2c: octeon: Enable High-Level Controller

2016-03-31 Thread Jan Glauber
plus one interrupt per transferred byte. Since the interrupts are costly using the HLC improves the performance. Also, the HLC provides improved error handling. Signed-off-by: David Daney Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 397

[PATCH v5 08/14] i2c: octeon: Faster operation when IFLG signals late

2016-03-31 Thread Jan Glauber
what's achievable, and much better than the worst-case 100 bytes/sec before. Signed-off-by: Peter Swain Signed-off-by: Jan Glauber Acked-by: David Daney --- drivers/i2c/busses/i2c-octeon.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH v5 14/14] i2c: thunderx: Add smbus alert support

2016-03-31 Thread Jan Glauber
Add smbus alert interrupt support. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-cavium.h| 6 ++ drivers/i2c/busses/i2c-thunderx-core.c | 35 ++ 2 files changed, 41 insertions(+) diff --git a/drivers/i2c/busses/i2c-cavium.h b/drivers/i2c

[PATCH v5 12/14] i2c: octeon: Split the driver into two parts

2016-03-31 Thread Jan Glauber
Move common functionality into a separate file in preparation of the re-use from the ThunderX i2c driver. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Makefile | 3 +- drivers/i2c/busses/i2c-cavium.c | 822 + drivers/i2c/busses/i2c-cavium.h

[PATCH v5 10/14] i2c: octeon: Move read function before write

2016-03-31 Thread Jan Glauber
Just sorting the functions to be consistent with the other read/write variants. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 94 - 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon.c b

[PATCH v5 09/14] i2c: octeon: Add workaround for broken irqs on CN3860

2016-03-31 Thread Jan Glauber
From: David Daney CN3860 does not interrupt the CPU when the i2c status changes. If we get a timeout, and see the status has in fact changed, we know we have this problem, and drop back to polling. Signed-off-by: David Daney Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 55

[PATCH v5 05/14] dt-bindings: i2c: Add Octeon cn78xx TWSI

2016-03-31 Thread Jan Glauber
Add compatible string for Cavium Octeon cn78XX SOCs TWSI. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Jan Glauber Acked-by: David Daney --- Documentation/devicetree/bindings/i2c/i2c-octeon.txt | 6 ++ 1 file changed, 6 insertions

[PATCH v5 06/14] i2c: octeon: Add support for cn78xx chips

2016-03-31 Thread Jan Glauber
From: David Daney cn78xx has a different interrupt architecture, so we have to manage the interrupts differently. Signed-off-by: David Daney Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 131 1 file changed, 120 insertions(+), 11

[PATCH v5 07/14] i2c: octeon: Flush TWSI writes with readback

2016-03-31 Thread Jan Glauber
From: Peter Swain Signed-off-by: Peter Swain Signed-off-by: Jan Glauber Acked-by: David Daney --- drivers/i2c/busses/i2c-octeon.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c index

[PATCH v5 01/14] i2c: octeon: Increase retry default and use fixed timeout value

2016-03-31 Thread Jan Glauber
Convert the adapter timeout to 2 ms independently of depending on CONFIG_HZ. CONFIG_HZ is 100 for MIPS Cavium-Octeon so the timeout value is not changed. Also set retries to 5 to improve robustness. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 3 ++- 1 file changed, 2

[PATCH v5 02/14] i2c: octeon: Move set-clock and init-lowlevel upward

2016-03-31 Thread Jan Glauber
No functional change, just moving the functions upward in preparation of improving the recovery. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 126 1 file changed, 63 insertions(+), 63 deletions(-) diff --git a/drivers/i2c/busses/i2c

[PATCH v5 03/14] i2c: octeon: Improve error handling

2016-03-31 Thread Jan Glauber
From: Peter Swain Consider more status codes and improve error handling. Distinguish handling for first and last part of a message. TODO: Convert to use the i2c recovery framework. Signed-off-by: Peter Swain Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 244

[PATCH v5 00/14] i2c-octeon and i2c-thunderx drivers

2016-03-31 Thread Jan Glauber
: octeon: Add support for cn78xx chips i2c: octeon: Add workaround for broken irqs on CN3860 Jan Glauber (8): i2c: octeon: Increase retry default and use fixed timeout value i2c: octeon: Move set-clock and init-lowlevel upward dt-bindings: i2c: Add Octeon cn78xx TWSI i2c: octeon: Move read

Re: [PATCH v2 0/5] Cavium ThunderX uncore PMU support

2016-04-04 Thread Jan Glauber
Hi Mark, can you have a look at these patches? Thanks, Jan On Wed, Mar 09, 2016 at 05:21:02PM +0100, Jan Glauber wrote: > This patch series provides access to various counters on the ThunderX SOC. > > For details of the uncore implementation see patch #1. > > Patches #2-5

[PATCH v6 19/19] i2c: thunderx: Add smbus alert support

2016-04-11 Thread Jan Glauber
Add smbus alert interrupt support. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-cavium.h| 6 ++ drivers/i2c/busses/i2c-thunderx-core.c | 35 ++ 2 files changed, 41 insertions(+) diff --git a/drivers/i2c/busses/i2c-cavium.h b/drivers/i2c

[PATCH v6 06/19] i2c: octeon: Improve error status checking

2016-04-11 Thread Jan Glauber
ceive mode until the last byte is requested. The state check needs to consider if this bit was set. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 125 +--- 1 file changed, 103 insertions(+), 22 deletions(-) diff --git a/drivers/i2c/busses/i2

[PATCH v6 18/19] i2c: octeon,thunderx: Move register offsets to struct

2016-04-11 Thread Jan Glauber
The register offsets are different between Octeon and ThunderX so move them into the algorithm struct and get rid of the define. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-cavium.c| 28 +-- drivers/i2c/busses/i2c-cavium.h| 35

[PATCH v6 01/19] i2c: octeon: Increase retry default and use fixed timeout value

2016-04-11 Thread Jan Glauber
Convert the adapter timeout to 2 ms independently of depending on CONFIG_HZ. CONFIG_HZ is 100 for MIPS Cavium-Octeon so the timeout value is not changed. Also set retries to 5 to improve robustness. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 3 ++- 1 file changed, 2

[PATCH v6 14/19] i2c: octeon: Move read function before write

2016-04-11 Thread Jan Glauber
Just sorting the functions to be consistent with the other read/write variants. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 78 - 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon.c b

[PATCH v6 12/19] i2c: octeon: Faster operation when IFLG signals late

2016-04-11 Thread Jan Glauber
what's achievable, and much better than the worst-case 100 bytes/sec before. Signed-off-by: Peter Swain Signed-off-by: Jan Glauber Acked-by: David Daney --- drivers/i2c/busses/i2c-octeon.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH v6 10/19] i2c: octeon: Add support for cn78xx chips

2016-04-11 Thread Jan Glauber
From: David Daney cn78xx has a different interrupt architecture, so we have to manage the interrupts differently. Signed-off-by: David Daney Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 131 1 file changed, 120 insertions(+), 11

[PATCH v6 17/19] i2c: thunderx: Add i2c driver for ThunderX SOC

2016-04-11 Thread Jan Glauber
The ThunderX SOC uses the same i2c block as the Octeon SOC. The main difference is that on ThunderX the device is a PCI device so device probing is done via PCI, interrupts are MSIX and the clock is taken from device tree. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Kconfig

[PATCH v6 15/19] i2c: octeon: Rename driver to prepare for split

2016-04-11 Thread Jan Glauber
This is an intermediate commit in preparation of the driver split. The module rename in this commit will be reverted in the next patch, this is just done to make the series bisectible. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Makefile| 2 +- drivers/i2c

[PATCH v6 11/19] i2c: octeon: Flush TWSI writes with readback

2016-04-11 Thread Jan Glauber
From: Peter Swain Signed-off-by: Peter Swain Signed-off-by: Jan Glauber Acked-by: David Daney --- drivers/i2c/busses/i2c-octeon.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c index

[PATCH v6 07/19] i2c: octeon: Use i2c recovery framework

2016-04-11 Thread Jan Glauber
xfer debug message (i2c core already provides debugging) - removed length is zero check Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 178 +--- 1 file changed, 111 insertions(+), 67 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon.c

[PATCH v6 08/19] i2c: octeon: Enable High-Level Controller

2016-04-11 Thread Jan Glauber
plus one interrupt per transferred byte. Since the interrupts are costly using the HLC improves the performance. Also, the HLC provides improved error handling. Signed-off-by: David Daney Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 355

[PATCH v6 09/19] dt-bindings: i2c: Add Octeon cn78xx TWSI

2016-04-11 Thread Jan Glauber
Add compatible string for Cavium Octeon cn78XX SOCs TWSI. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Jan Glauber Acked-by: David Daney --- Documentation/devicetree/bindings/i2c/i2c-octeon.txt | 6 ++ 1 file changed, 6 insertions

[PATCH v6 16/19] i2c: octeon: Split the driver into two parts

2016-04-11 Thread Jan Glauber
Move common functionality into a separate file in preparation of the re-use from the ThunderX i2c driver. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Makefile | 3 +- drivers/i2c/busses/i2c-cavium.c | 805 + drivers/i2c/busses/i2c-cavium.h

[PATCH v6 13/19] i2c: octeon: Add workaround for broken irqs on CN3860

2016-04-11 Thread Jan Glauber
From: David Daney CN3860 does not interrupt the CPU when the i2c status changes. If we get a timeout, and see the status has in fact changed, we know we have this problem, and drop back to polling. Signed-off-by: David Daney Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 55

[PATCH v6 03/19] i2c: octeon: Rename [read|write]_sw to reg_[read|write]

2016-04-11 Thread Jan Glauber
octeon_i2c_read_sw -> octeon_i2c_reg_read octeon_i2c_write_sw -> octeon_i2c_reg_write Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/i2c/busses/i2c-octe

[PATCH v6 02/19] i2c: octeon: Move set-clock and init-lowlevel upward

2016-04-11 Thread Jan Glauber
No functional change, just moving the functions upward in preparation of improving the recovery. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 126 1 file changed, 63 insertions(+), 63 deletions(-) diff --git a/drivers/i2c/busses/i2c

[PATCH v6 04/19] i2c: octeon: Introduce helper functions for register access

2016-04-11 Thread Jan Glauber
Add helper functions for control, data and status register access. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 56 +++-- 1 file changed, 31 insertions(+), 25 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses

[PATCH v6 05/19] i2c: octeon: Remove superfluous check in octeon_i2c_test_iflg

2016-04-11 Thread Jan Glauber
Remove superfluous check and stray newline. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c index b25c491..4275007 100644 --- a/drivers/i2c

[PATCH v6 00/19] i2c-octeon and i2c-thunderx drivers

2016-04-11 Thread Jan Glauber
tions Jan - David Daney (3): i2c: octeon: Enable High-Level Controller i2c: octeon: Add support for cn78xx chips i2c: octeon: Add workaround for broken irqs on CN3860 Jan Glauber (14): i2c: octeon: Increase retry default and use fixed timeout value i2c: oc

Re: [PATCH 2/4] arm64: pmu: add fallback probe table

2016-04-12 Thread Jan Glauber
On Fri, Apr 08, 2016 at 04:57:05PM -0500, Jeremy Linton wrote: > From: Mark Salter > > In preparation for ACPI support, add a pmu_probe_info table to > the arm_pmu_device_probe() call. This table gets used when > probing in the absence of a devicetree node for PMU. > > Signed-off-by: Mark Salter

[RFC 1/1] edac: Add a counter parameter for edac_device_handle_ue/ce()

2019-07-17 Thread Jan Glauber
On Mon, Jul 15, 2019 at 01:53:07PM +0300, Hanna Hawa wrote: > Add a counter parameter in order to avoid losing errors count for edac > device, the error count reports the number of errors reported by an edac > device similar to the way MC_EDAC do. > > Signed-off-by: Hanna Hawa > --- > drivers/ed

Re: [PATCH 4/7] crypto: cavium: zip: no need to check return value of debugfs_create functions

2019-01-23 Thread Jan Glauber
> Cc: "David S. Miller" > Cc: Robert Richter > Cc: Jan Glauber > Cc: linux-cry...@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > --- > drivers/crypto/cavium/zip/zip_main.c | 52 ++-- > 1 file changed, 11 insertions(+), 41 deletions(-) Reviewed-by: Jan Glauber thanks, Jan

[RFC] Disable lockref on arm64

2019-04-29 Thread Jan Glauber
Hi Catalin & Will, I've been looking into performance issues that were reported for several test-cases, for instance an nginx benchmark. It turned out the issue we have on ThunderX2 is the file open-close sequence with small read sizes. If the used files are opened read-only the lockref code (ena

Re: dcache_readdir NULL inode oops

2019-04-30 Thread Jan Glauber
Hi Al, On Fri, Nov 30, 2018 at 04:32:28PM +, Will Deacon wrote: > On Fri, Nov 30, 2018 at 04:08:52PM +, Al Viro wrote: > > On Fri, Nov 30, 2018 at 09:16:49AM -0600, Eric W. Biederman wrote: > > > >> > + inode_lock(parent->d_inode); > > > >> > dentry->d_fsdata = NULL; > > > >>

Re: [RFC] Disable lockref on arm64

2019-05-02 Thread Jan Glauber
On Wed, May 01, 2019 at 09:41:08AM -0700, Linus Torvalds wrote: > On Mon, Apr 29, 2019 at 7:52 AM Jan Glauber wrote: > > > > It turned out the issue we have on ThunderX2 is the file open-close sequence > > with small read sizes. If the used files are opened read-only the >

Re: [RFC] Disable lockref on arm64

2019-05-02 Thread Jan Glauber
On Wed, May 01, 2019 at 05:01:40PM +0100, Will Deacon wrote: > Hi Jan, > > [+Peter and Linus, since they enjoy this stuff] > > On Mon, Apr 29, 2019 at 02:52:11PM +0000, Jan Glauber wrote: > > I've been looking into performance issues that were reported for several >

Re: [PATCH v2 0/5] Add NUMA-awareness to qspinlock

2019-07-03 Thread Jan Glauber
numa-qspinlocks - 56149.41 73.90 224 576.95 290.31 Also frontend-stalls are reduced to 50% and interconnect traffic is greatly reduced. Tested-by: Jan Glauber --Jan Am Fr., 29. März 2019 um 16:23 Uhr schrieb Alex Kogan : >

Re: [PATCH] lockref: Limit number of cmpxchg loop retries

2019-06-06 Thread Jan Glauber
On Thu, Jun 06, 2019 at 10:41:54AM +0100, Will Deacon wrote: > On Thu, Jun 06, 2019 at 08:03:27AM +0000, Jan Glauber wrote: > > On Wed, Jun 05, 2019 at 01:16:46PM -0700, Linus Torvalds wrote: > > > On Wed, Jun 5, 2019 at 6:49 AM Jan Glauber wrote: > > > > > > &

Re: [PATCH] lockref: Limit number of cmpxchg loop retries

2019-06-07 Thread Jan Glauber
On Thu, Jun 06, 2019 at 10:28:12AM +, Jan Glauber wrote: > On Thu, Jun 06, 2019 at 10:41:54AM +0100, Will Deacon wrote: > > On Thu, Jun 06, 2019 at 08:03:27AM +0000, Jan Glauber wrote: > > > On Wed, Jun 05, 2019 at 01:16:46PM -0700, Linus Torvalds wrote: > > > >

[PATCH 2/2] arm64: defconfig: Raise NR_CPUS to 256

2018-03-02 Thread Jan Glauber
ThunderX1 dual socket has 96 CPUs and ThunderX2 has 224 CPUs. Therefore raise the default number of CPUs from 64 to 256 by adding an arm64 specific option to override the generic default. Signed-off-by: Jan Glauber --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 1/2] arm64: defconfig: enable THUNDER_NIC_VF

2018-03-02 Thread Jan Glauber
Without this option the NIC on ThunderX1 is not coming up so enable it to get a working network interface. Signed-off-by: Jan Glauber --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

Re: [PATCH v2] i2c: xlp9xx: Add support for SMBAlert

2018-03-19 Thread Jan Glauber
is the i2c controller main interrupt. > > > > Signed-off-by: Kamlakant Patel > > Signed-off-by: George Cherian > > Are the previous reviewers happy now? Reviewed-by: Jan Glauber > > --- > > drivers/i2c/busses/i2c-xlp9xx.c | 24 &g

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-14 Thread Jan Glauber
On Wed, Mar 14, 2018 at 07:29:37PM +, Ard Biesheuvel wrote: > This reverts commit 864b75f9d6b0100bb24fdd9a20d156e7cda9b5ae. FWIW, the revert fixes the boot hang I'm seeing on ThunderX1. --Jan > Commit 864b75f9d6b0 ("mm/page_alloc: fix memmap_init_zone pageblock > alignment") modified the log

Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-19 Thread Jan Glauber
On Thu, Apr 19, 2018 at 11:42:11AM +0800, Herbert Xu wrote: > On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > > > > @@ -1362,7 +1373,17 @@ static int test_comp(struct crypto_comp *tfm, > > goto out; > > } > > > &

Re: [PATCH v10 0/8] Cavium MMC driver

2017-01-19 Thread Jan Glauber
On Tue, Dec 20, 2016 at 01:10:56PM +0100, Ulf Hansson wrote: > Hi Jan, > > On 19 December 2016 at 13:15, Jan Glauber wrote: > > While this patch series seems to be somehow overdue, in the meantime the > > same MMC unit was re-used on Cavium's ThunderX SOC so our inter

Re: [PATCH] mmc: core: Pass node pointer to mmc_of_parse

2017-01-25 Thread Jan Glauber
On Tue, Jan 24, 2017 at 09:56:55AM +0100, Ulf Hansson wrote: > On 21 January 2017 at 11:59, Jan Glauber wrote: > > Extend mmc_of_parse to get the device node pointer as an > > additional argument instead of using the device node of the > > mmc device. > > > >

Re: [PATCH v10 8/8] dt-bindings: mmc: Add Cavium SOCs MMC bindings

2017-01-09 Thread Jan Glauber
On Thu, Dec 22, 2016 at 02:32:42PM -0600, Rob Herring wrote: > On Mon, Dec 19, 2016 at 01:15:52PM +0100, Jan Glauber wrote: > > Add description of Cavium Octeon and ThunderX SOC device tree bindings. > > > > CC: Ulf Hansson > > CC: Rob Herring > >

Re: [PATCH v10 0/8] Cavium MMC driver

2017-01-20 Thread Jan Glauber
On Thu, Jan 19, 2017 at 09:47:33AM -0800, David Daney wrote: > On 01/19/2017 06:50 AM, Jan Glauber wrote: > [...] > > > >>4) GPIO powers should be modelled as GPIO regulators. I believe we > >>have discussed this earlier as well (I don't really recall in detail &

[PATCH] mmc: core: Pass node pointer to mmc_of_parse

2017-01-21 Thread Jan Glauber
child node of the slot. Signed-off-by: Jan Glauber --- drivers/mmc/core/host.c| 8 +++- drivers/mmc/host/davinci_mmc.c | 2 +- drivers/mmc/host/dw_mmc.c | 2 +- drivers/mmc/host/meson-gx-mmc.c| 2 +- drivers/mmc/host/mmci.c| 2 +- drivers/mmc/host

Re: [PATCH 2/3] i2c: octeon: Add retry logic after receiving STAT_RXADDR_NAK

2016-06-14 Thread Jan Glauber
On Thu, Jun 09, 2016 at 10:11:51PM +0200, Wolfram Sang wrote: > On Wed, Jun 08, 2016 at 08:51:18AM +0200, Jan Glauber wrote: > > The controller specification states that when receiving STAT_RXADDR_NAK > > the START should be sent again. Retry several times before finally > >

[PATCH v10 5/8] i2c: octeon,thunderx: Move register offsets to struct

2016-06-15 Thread Jan Glauber
The register offsets are different between Octeon and ThunderX so move them into the algorithm struct and get rid of the define. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-cavium.c| 28 +-- drivers/i2c/busses/i2c-cavium.h| 35

[PATCH v10 1/8] i2c: octeon: Rename driver to prepare for split

2016-06-15 Thread Jan Glauber
This is an intermediate commit in preparation of the driver split. The module rename in this commit will be reverted in the next patch, this is just done to make the series bisectible. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Makefile| 2 +- drivers/i2c

[PATCH v10 6/8] i2c: octeon: Sort include files alphabetically

2016-06-15 Thread Jan Glauber
Sort include files alphabetically to reduce probability of merge conflicts. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon-core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon-core.c b/drivers/i2c/busses/i2c-octeon

[PATCH v10 7/8] i2c: cavium: Use booleon values for booleon variables

2016-06-15 Thread Jan Glauber
Initialize booleon values with true instead of 1. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-cavium.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-cavium.c b/drivers/i2c/busses/i2c-cavium.c index 56b23c2..3a581c9 100644 --- a/drivers

[PATCH v10 2/8] i2c: octeon: Split the driver into two parts

2016-06-15 Thread Jan Glauber
Move common functionality into a separate file in preparation of the re-use from the ThunderX i2c driver. Functions are slightly re-ordered but no other changes are included. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Makefile | 3 +- drivers/i2c/busses/i2c-cavium.c

[PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC

2016-06-15 Thread Jan Glauber
The ThunderX SOC uses the same i2c block as the Octeon SOC. The main difference is that on ThunderX the device is a PCI device so device probing is done via PCI, interrupts are MSI-X. The clock rates can be set via device tree or ACPI. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Kconfig

[PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support

2016-06-15 Thread Jan Glauber
Add SMBUS alert interrupt support. For now only device tree is supported for specifying the alert. In case of ACPI an error is returned. Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-cavium.h| 6 drivers/i2c/busses/i2c-thunderx-core.c | 51

[PATCH v10 0/8] i2c-octeon and i2c-thunderx driver

2016-06-15 Thread Jan Glauber
id of of_find_node_by_name - Simplify adap.name by using device name - SMBUS ACPI handling - Re-phrase SMBUS error/not-specified message Thanks, Jan ----- Jan Glauber (8): i2c: octeon: Rename driver to prepare for split i2c: octeon: Split the driver into two

[PATCH v10 8/8] i2c: octeon: thunderx: Add MAINTAINERS entry

2016-06-15 Thread Jan Glauber
The i2c Octeon and ThunderX drivers are maintained by Cavium. While at it fix the whitespace errors of the next entry. Signed-off-by: Jan Glauber Acked-by: David Daney --- MAINTAINERS | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/MAINTAINERS b

Re: [PATCH 5/6] spi: octeon: Split driver into Octeon specific and common parts

2016-07-25 Thread Jan Glauber
On Sun, Jul 24, 2016 at 02:38:11PM -0400, Paul Gortmaker wrote: > On Sat, Jul 23, 2016 at 6:42 AM, Jan Glauber wrote: > > Separate driver probing from SPI transfer functions. > > > > Signed-off-by: Jan Glauber > > Tested-by: Steven J. Hill > &

Re: [PATCH 5/6] spi: octeon: Split driver into Octeon specific and common parts

2016-07-25 Thread Jan Glauber
On Sun, Jul 24, 2016 at 09:54:16PM +0100, Mark Brown wrote: > On Sat, Jul 23, 2016 at 12:42:54PM +0200, Jan Glauber wrote: > > > + dev_info(&pdev->dev, "OCTEON SPI bus driver\n"); > > This is just noise, remove it. I'll remove these in both drivers. Thanks, Jan

Re: [PATCH 6/6] spi: octeon: Add thunderx driver

2016-07-25 Thread Jan Glauber
On Sun, Jul 24, 2016 at 10:04:52PM +0100, Mark Brown wrote: > On Sat, Jul 23, 2016 at 12:42:55PM +0200, Jan Glauber wrote: > > > +config SPI_THUNDERX > > + tristate "Cavium ThunderX SPI controller" > > + depends on 64BIT && PCI && !CAVIUM

[PATCH v2] spi: octeon: Split driver into Octeon specific and common parts

2016-07-25 Thread Jan Glauber
Separate driver probing from SPI transfer functions. Signed-off-by: Jan Glauber --- drivers/spi/Makefile | 1 + drivers/spi/spi-cavium-octeon.c| 102 drivers/spi/{spi-octeon.c => spi-cavium.c} |

[PATCH v2] spi: octeon: Add thunderx driver

2016-07-25 Thread Jan Glauber
Add ThunderX SPI driver using the shared part from the Octeon driver. The main difference of the ThunderX driver is that it is a PCI device so probing is different. The system clock settings can be specified in device tree. Signed-off-by: Jan Glauber --- drivers/spi/Kconfig | 7

Re: [PATCH v3 0/5] Cavium ThunderX uncore PMU support

2016-10-28 Thread Jan Glauber
On Fri, Oct 28, 2016 at 04:17:49PM +0100, Will Deacon wrote: > On Thu, Oct 20, 2016 at 01:23:51PM +0200, Jan Glauber wrote: > > On Thu, Oct 20, 2016 at 12:37:07PM +0200, Peter Zijlstra wrote: > > > On Thu, Oct 20, 2016 at 11:30:36AM +0200, Jan Glauber wrote: > > >

[PATCH v4 0/5] Cavium ThunderX uncore PMU support

2016-10-29 Thread Jan Glauber
Switched to new cpuhp stuff. I still don't care about the CPU location used to access an uncore device, it may cross the CCPI and we'll pay a performance penalty. We might optimize this later, for now I feel it is not worth the time optimizing it. ---------- Jan

<    1   2   3   4   5   6   >