Hi Dexuan,
On 05/02/2021 19:36, Dexuan Cui wrote:
>> From: Rafael J. Wysocki
>> Sent: Friday, February 5, 2021 5:06 AM
>> To: Dexuan Cui
>> Cc: linux-a...@vger.kernel.org; linux-kernel@vger.kernel.org;
>> linux-hyp...@vger.kernel.org; Michael Kelley
>> Subject: Re: How can a userspace program t
Hi Xiongfeng,
On 05/05/2020 03:08, Xiongfeng Wang wrote:
> On 2020/5/5 1:14, James Morse wrote:
>> Hi Christoph,
>>
>> (CC: +Xiongfeng)
>>
>> Thanks for the reminder - I was just searching for who was using this.
>
> Thanks for CC me. We do have a driver
Hi Shiju,
On 22/07/2020 13:50, Andy Shevchenko wrote:
> On Wed, Jul 22, 2020 at 12:34:23PM +, Shiju Jose wrote:
>>>> Co-developed-by: James Morse
>>>
>>> Co-developed-by: is going _in conjunction with_ SoB tag which is missing
>>> here.
>> T
Hi Tan,
On 30/07/2020 08:32, Xiaofei Tan wrote:
> After the following commit applied, user-mode SEA is preferentially
> processed by APEI. Do memory failure to recover.
>
> But there are some problems:
> 1) The function apei_claim_sea() has processed an CPER, does not
> mean that memory failure h
Hi Reinette,
On 31/03/2021 22:35, Reinette Chatre wrote:
> On 3/12/2021 9:58 AM, James Morse wrote:
>> resctrl is the defacto Linux ABI for SoC resource partitioning features.
>> To support it on another architecture, it needs to be abstracted from
>> the features provided
Hi Babu,
On 30/03/2021 21:36, Babu Moger wrote:
> On 3/12/21 11:58 AM, James Morse wrote:
>> This series re-folds the resctrl code so the CDP resources (L3CODE et al)
>> behaviour is all contained in the filesystem parts, with a minimum amount
>> of arch specific code.
&g
Hi Reinette, Fenghua,
On 03/12/2020 23:25, Reinette Chatre wrote:
> From: Fenghua Yu
>
> The code of setting the CPU on which a task is running in a CPU mask is
> moved into a couple of helpers. The new helper task_on_cpu() will be
> reused shortly.
> diff --git a/arch/x86/kernel/cpu/resctrl/rd
This is the same way used to update the register when tasks are moved as
> part of resource group removal.
(as t->on_cpu is already used...)
Reviewed-by: James Morse
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> in
Hi,
(sorry for the late response)
On 06/11/2020 18:46, Nicolas Saenz Julienne wrote:
> On Thu, 2020-11-05 at 16:11 +0000, James Morse wrote:>> We also depend on
> this when skipping the checksum code in purgatory, which can be
>> exceedingly slow.
>
> This one I don
Hi Henry,
On 16/11/2020 21:11, Henry Willard wrote:
> On 11/11/20 10:11 AM, James Morse wrote:
>> On 06/11/2020 23:25, Henry Willard wrote:
>>> machine_shutdown() is called by kernel_kexec() to shutdown
>>> the non-boot CPUs prior to starting the new kernel
to on another CPU. It might get torn values, or multiple-reads get
different values.
The READ_ONCE/WRITE_ONCEry would have been easier to read as a separate patch
as you touch
all sites, and move/change some of them.
Regardless:
Reviewed-by: James Morse
I don't 'get' memory-orderi
27;s needed to do the kfree())
> Check the validity of the move before getting anywhere near task_work
> callbacks.
This saves the kzalloc()/task_work_add() if it wasn't going to be necessary.
Reviewed-by: James Morse
Thanks,
James
Hi Steven, Catalin,
On 18/11/2020 16:01, Steven Price wrote:
> On 17/11/2020 16:07, Catalin Marinas wrote:
>> On Mon, Oct 26, 2020 at 03:57:27PM +, Steven Price wrote:
>>> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
>>> index 19aacc7d64de..38fe25310ca1 100644
>>> --- a/arch/arm64/
Hi Reinette,
On 17/11/2020 19:20, Reinette Chatre wrote:
> On 10/30/2020 9:10 AM, James Morse wrote:
>> Splitting rdt_domain up in a similar way happens in the next patch.
>> No change in behaviour, this patch just moves types around.
>
> Please remove the "this pat
Hi Reinette,
On 17/11/2020 19:57, Reinette Chatre wrote:
> On 10/30/2020 9:10 AM, James Morse wrote:
>> resctrl chooses whether to enable CDP, once it does, half the number
>> of closid are available. MPAM doesn't behave like this, an in-kernel user
>> of MPAM could be
Hi Reinette
On 17/11/2020 21:29, Reinette Chatre wrote:
> On 10/30/2020 9:11 AM, James Morse wrote:
>> To support multiple architectures, the resctrl code needs to be split
>> into a 'fs' specific part in core code, and an arch-specific backend.
>>
>> It shou
uld it be changed to "info dir"?
Sure,
> On 10/30/2020 9:11 AM, James Morse wrote:
>> Moving properties that resctrl exposes to user-space into the core
>> 'fs' code, (e.g. the name of the schema), means some of the functions
>> that back the filesystem
Hi Reinette,
On 17/11/2020 22:04, Reinette Chatre wrote:
> On 10/30/2020 9:11 AM, James Morse wrote:
>> resctrl_schema holds properties that vary with the style of configuration
>> that resctrl applies to a resource.
>>
>> Once the arch code has a single resource per c
Hi Reinette,
On 17/11/2020 22:30, Reinette Chatre wrote:
> On 10/30/2020 9:11 AM, James Morse wrote:
>> Before the name for the schema can be generated, the type of the
>> configuration being applied to the resource needs to be known. Label
>> all the entries in rdt_resources
Hi Reinette,
On 17/11/2020 22:52, Reinette Chatre wrote:
> On 10/30/2020 9:11 AM, James Morse wrote:
>> Now that resctrl has its own list of resources it is using, walk that
>> list instead of the architectures list. This means resctrl has somewhere
>> to keep schema propert
Hi Reinette,
On 17/11/2020 23:11, Reinette Chatre wrote:
> On 10/30/2020 9:11 AM, James Morse wrote:
>> Move the names used for the schemata file out of the resource and
>> into struct resctrl_schema. This allows one resource to have two
>> different names, based on the ot
Hi Reinette,
On 17/11/2020 23:28, Reinette Chatre wrote:
> On 10/30/2020 9:11 AM, James Morse wrote:
>> Arm's MPAM may have surprisingly large bitmaps for its cache
>> portions as the architecture allows up to 4K portions. The size
>> exposed via resctrl may not be
Hi Reinette,
On 17/11/2020 23:46, Reinette Chatre wrote:
> On 10/30/2020 9:11 AM, James Morse wrote:
>> Once the L2/L2CODE/L2DATA resources are merged, there may be two
>> configurations staged for one resource when CDP is enabled. The
>> closid should always be pa
947.39194-1-james.mo...@arm.com/
Thanks,
James Morse (24):
x86/resctrl: Split struct rdt_resource
x86/resctrl: Split struct rdt_domain
x86/resctrl: Add a separate schema list for resctrl
x86/resctrl: Pass the schema in info dir's private pointer
x86/resctrl: Label the resources wit
cture only moves types around, and should not lead
to any change in behaviour.
Splitting rdt_domain up in a similar way happens in the next patch.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* Tabs space and other whitespace
* Restored for_each_rdt_resource() calls in
to
struct resctrl_schema.
Copying the value ensures there is no mismatch, but allows the filesystem
parts of resctrl to be modified to use the schema. Once the resources are
merged, the filesystem code can assign this value based on the schema
being created.
Reviewed-by: Jamie Iles
Signed-off-by: J
oo.
This difference means the type of the private pointers varies
between control and monitor info dirs.
If the flags are RF_MON_INFO, its a struct rdt_resource. If the
flags are RF_CTRL_INFO, its a struct resctrl_schema. Nothing in
res_common_files[] has both flags.
Reviewed-by: Jamie Iles
Signed
into a new header file. resctrl code paths touching a 'hw'
struct indicates where an abstraction is needed.
Splitting this structure only moves types around, and should not lead
to any change in behaviour.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* Tabs
d
the name and type of configuration values for resctrl.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* Renamed resctrl_all_schema list
* Used schemata_list as a prefix to make these easier to search for
* Added kerneldoc string
* Removed 'pending configuratio
e are changed to use the schema value instead.
schemata_list_create() sets this value, and reaches into the architecture
specific structure to get the value. This will eventually be replaced with
a helper.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* Added missing :
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* Rewrote commit message
* Whitespace fixes
* num_closid becomes u32 in all occurences to reduce surprises
---
arch/x86/kernel/cpu/resctrl/core.c | 5 +
arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
arch/x86/kernel/cp
thing' helper.
After the filesystem code is moved, rdtgroup_pseudo_locked_in_hierarchy()
remains part of the x86 specific hooks to support psuedo lock. This code
walks each domain, and still does this after the separate resources are
merged.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
-
es
Signed-off-by: James Morse
---
arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 4 ++--
arch/x86/kernel/cpu/resctrl/internal.h| 6 +++---
arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 8
arch/x86/kernel/cpu/resctrl/rdtgroup.c| 4 ++--
4 files changed, 11 insertions(+), 11 deletion
-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* split from a larger patch
---
arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 23 +--
arch/x86/kernel/cpu/resctrl/internal.h| 6 +++---
arch/x86/kernel/cpu/resctrl/rdtgroup.c| 19
will generate two names
for one resource.
The filesystem code should calculate max_name_width for padding the
schemata file, move this to live with the code that will generate
the names.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1;
* Don't hardcode max_name_
staged_configuration array must be
used for each schema. Use the conf_type enum directly as an index.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* Renamed max enum value CDP_NUM_TYPES
* Whitespace and parenthesis
* Missing word in the commit message
---
arch/x86
update_domains() merges the staged configuration changes into the
arch codes configuration array. Rename to make it clear its part of the
arch code interface to resctrl.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* The closid is no longer staged as from resctrl
this is that the caches are reset twice, once
for CODE once for DATA.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
arch/x86/kernel/cpu/resctrl/core.c | 10 +-
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 9 +
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git a
index in the configuration array.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 5 ++--
arch/x86/kernel/cpu/resctrl/monitor.c | 2 +-
arch/x86/kernel/cpu/resctrl/rdtgroup.c| 35 +++
include/linux/resctrl.h
r one resource means it is enable
for all resources, as all resources would need to configure both
interpretations of the closid value.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* Added prototype for resctrl_arch_set_cdp_enabled()
* s/Currently/Previ
changes it has made
to the ctrl_val array as this allows the hardware to be updated once for
a set of changes.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* Removing the patch that moved the closid to the staged config means the
min/max and return from
;t take the user-space
control format at all.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 16 ++---
arch/x86/kernel/cpu/resctrl/monitor.c | 6 +++-
arch/x86/kernel/cpu/resctrl/rdtgroup.c| 43 ++-
include/linux/re
n the struct need to be
specified per type configuration, and there can be one configuration of
each type staged.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* Expanded commit message
* Removed explicit clearing of have_new_ctrl,
* Moved ARRAY_SIZE() trickery to a la
rdt_domain_reconfigure_cdp() infers whether CDP is enabled by
checking the alloc_capable and alloc_enabled flags of the data
resources.
Now that we have an explicit cdp_enabled, use that.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 8
omplicates
allocating and freeing the ctrl_val arrays. Add a helper to allocate
the ctrl_val array, that returns the value on the L2 or L3 resource
if it already exists. This gets removed once the resources are merged,
and there really is only one ctrl_val array.
Reviewed-by: Jamie Iles
Signed-off
on the staged configuration type. This makes the
static mult and offset parameters redundant.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
---
arch/x86/kernel/cpu/resctrl/core.c| 12
arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 17 +++--
include/linux
configuration type
if cdp is enabled.
Reviewed-by: Jamie Iles
Signed-off-by: James Morse
Changes since v1:
* Expanded commit mesasge.
---
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 99 --
1 file changed, 14 insertions(+), 85 deletions(-)
diff --git a/arch/x86/kernel/cpu/resctrl
iewed-by: Jamie Iles
Signed-off-by: James Morse
---
Changes since v1:
* rdt_get_cdp_config() is kept for its comment.
---
arch/x86/kernel/cpu/resctrl/core.c | 174 ++---
arch/x86/kernel/cpu/resctrl/internal.h | 4 -
arch/x86/kernel/cpu/resctrl/rdtgroup.c
Hi David,
On 27/04/16 19:52, David Long wrote:
> From: "David A. Long"
>
> This patchset is heavily based on Sandeepa Prabhu's ARM v8 kprobes patches,
> first seen in October 2013. This version attempts to address concerns raised
> by
> reviewers and also fixes problems discovered during testin
Hi David, Pratyush
On 27/04/16 19:53, David Long wrote:
> From: Pratyush Anand
>
> Entry symbols are not kprobe safe. So blacklist them for kprobing.
>
> Signed-off-by: Pratyush Anand
> diff --git a/arch/arm64/kernel/kprobes.c b/arch/arm64/kernel/kprobes.c
> index dfa1b1f..6a1292b 100644
> --
Hi David, Sandeepa,
On 27/04/16 19:53, David Long wrote:
> From: Sandeepa Prabhu
> diff --git a/arch/arm64/kernel/kprobes.c b/arch/arm64/kernel/kprobes.c
> new file mode 100644
> index 000..dfa1b1f
> --- /dev/null
> +++ b/arch/arm64/kernel/kprobes.c
> @@ -0,0 +1,520 @@
> +/*
> + * arch/arm64
Hi Andrew,
On 16/12/15 03:01, Andrew Pinski wrote:
> On Tue, Dec 9, 2015 at 17:26:56, Catalin Marinas
> wrote:
>>
>> Currently the BUG_ON() checks do not give enough information about the PTEs
>> being set. This patch changes BUG_ON to WARN_ONCE and dumps the values of
>> the old and new PTEs.
On 14/12/15 16:38, Catalin Marinas wrote:
> On Mon, Dec 14, 2015 at 04:26:48PM +, Julien Grall wrote:
>> On 14/12/15 16:22, Catalin Marinas wrote:
>>> On Mon, Dec 14, 2015 at 04:07:24PM +, Julien Grall wrote:
Linux 4.4-rc5 doesn't build for arm64 with CONFIG_XEN=y enabled:
In
On 14/12/15 17:07, Catalin Marinas wrote:
> If they take the mmdebug.h patch, it's even better. Please let us know
> how that goes.
Andrew Morton's Robot wrote:
> The patch titled
> Subject: include/linux/mmdebug.h: should include linux/bug.h
> has been added to the -mm tree. Its filename i
On 10/02/16 10:29, Will Deacon wrote:
> On Tue, Feb 09, 2016 at 01:26:22PM -0800, Yang Shi wrote:
>> dump_backtrace may be called in kthread context, which is not bound to a
>> single
>> cpu, i.e. khungtaskd, then calling smp_processor_id may trigger the below bug
>> report:
>
> If we're preempti
Hi David,
On 09/03/16 05:32, David Long wrote:
> From: "David A. Long"
> diff --git a/arch/arm64/lib/copy_from_user.S b/arch/arm64/lib/copy_from_user.S
> index 4699cd7..0ac2131 100644
> --- a/arch/arm64/lib/copy_from_user.S
> +++ b/arch/arm64/lib/copy_from_user.S
> @@ -66,6 +66,7 @@
> .endm
Hi Pratyush,
On 16/03/16 05:43, Pratyush Anand wrote:
> On 15/03/2016:06:47:52 PM, James Morse wrote:
>> If I understand this correctly - you can't kprobe these ldr/str instructions
>> as the fault handler wouldn't find kprobe's out-of line version of the
>>
Hi Pratyush,
On 18/03/16 14:43, Pratyush Anand wrote:
> On 18/03/2016:02:02:49 PM, James Morse wrote:
>> In kernel/entry.S when entered from EL0 we test for TIF_SINGLESTEP in the
>> thread_info flags, and use disable_step_tsk/enable_step_tsk to save/restore
>> the
Hi Kees,
On 06/04/16 20:44, Kees Cook wrote:
> When building with both CONFIG_HIBERNATION and CONFIG_RANDOMIZE_BASE,
> one or the other must be chosen at boot-time. Until now, hibernation
> was selected when no choice was made on the command line.
>
> To make the security benefits of kASLR more w
Hi Suzuki,
On 06/04/16 12:24, Suzuki K Poulose wrote:
> maxcpu=n sets the number of CPUs activated at boot time to a max of n,
> but allowing the remaining CPUs to be brought up later if the user
> decides to do so. However, on arm64 due to various reasons, we disallowed
> hotplugging CPUs beyond
On 11/04/16 19:03, Kees Cook wrote:
> On Mon, Apr 11, 2016 at 1:00 AM, James Morse wrote:
>> On 06/04/16 20:44, Kees Cook wrote:
>>> When building with both CONFIG_HIBERNATION and CONFIG_RANDOMIZE_BASE,
>>> one or the other must be chosen at boot-time. Until now, hibern
Hi Alex,
On 12/04/16 12:17, Alexander Potapenko wrote:
> I also wonder if we can, say, land the change to arch/arm64/Kconfig
> separately from makefile changes that improve the precision or fix
> certain build configurations.
(I'm not sure what you mean by precision)
It depends which build confi
() so that ftrace
won't try to patch this code.
Signed-off-by: James Morse
---
This patch lets arm64 with KCOV and STACK_TRACER boot.
kernel/kcov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kcov.c b/kernel/kcov.c
index 3efbee0834a8..78bed7125515 100644
---
Hi Jungseok,
On 07/10/15 16:28, Jungseok Lee wrote:
> Currently, a call trace drops a process stack walk when a separate IRQ
> stack is used. It makes a call trace information much less useful when
> a system gets paniked in interrupt context.
panicked
> This patch addresses the issue with the f
Hi Jungseok,
On 03/11/15 13:49, Jungseok Lee wrote:
> Additionally, I've been thinking of do_softirq_own_stack() which is your
> another comment [3]. Recently, I've realized there is possibility that
> I misunderstood your intention. Did you mean that irq_handler hook is not
> enough? Should do_so
Hi Pavel,
On 21/08/2019 19:31, Pavel Tatashin wrote:
> Now, that we abstracted the required functions move them to a new home.
> Later, we will generalize these function in order to be useful outside
> of hibernation.
> diff --git a/arch/arm64/mm/trans_pgd.c b/arch/arm64/mm/trans_pgd.c
> new file
Hi Rob,
On 30/08/2019 22:50, Rob Herring wrote:
> So KVM provides a semi-CortexA57? Code that runs on real h/w won't as a guest.
KVM provides the architectural bits of Cortex-A57's EL1, when running on A57.
Code that depends on EL2, won't run as a guest. Code that depends on some
non-architectur
Hi guys,
On 27/08/2019 14:49, Rob Herring wrote:
> On Mon, Aug 26, 2019 at 9:49 AM Hawa, Hanna wrote:
>> On 8/21/2019 10:17 PM, Rob Herring wrote:
>>> Why is this even in DT? AFAICT, this is all just CortexA57 core features
>>> (i.e. nothing Amazon specific). The core type and the ECC capabilitie
Hi,
On 12/08/2019 11:11, Shiju Jose wrote:
> Presently kernel does not support reporting the vendor specific HW errors,
> in the non-standard format, to the vendor drivers for the recovery.
'non standard' here is probably a little jarring to the casual reader. You're
referring to
the UEFI spec's
Hi,
On 12/08/2019 11:11, Shiju Jose wrote:
> This patch adds ghes_handle_memory_failure to the new error
> notification method.
The commit message doesn't answer the question: why?
The existing code works. This just looks like additional churn.
Given a user, I think the vendor specific example i
Hi,
On 12/08/2019 11:11, Shiju Jose wrote:
> Presently the vendor specific HW errors, in the non-standard format,
> are not reported to the vendor drivers for the recovery.
>
> This patch adds support to notify the vendor specific HW errors to the
> registered kernel drivers.
> diff --git a/driv
Hi Shiju,
On 22/08/2019 17:56, Shiju Jose wrote:
> James Morse wrote:
>> On 12/08/2019 11:11, Shiju Jose wrote:
>>> Presently kernel does not support reporting the vendor specific HW
>>> errors, in the non-standard format, to the vendor drivers for the recovery.
&
Hi Talel,
On 15/09/2019 07:43, Talel Shenhar wrote:
> The Amazon's Annapurna Labs Memory Controller EDAC supports ECC capability
> for error detection and correction (Single bit error correction, Double
> detection). This driver introduces EDAC driver for that capability.
Is there any documentati
Hi guys,
On 12/09/2019 10:19, Shenhar, Talel wrote:
> On 9/12/2019 11:50 AM, Marc Zyngier wrote:
>> On Thu, 12 Sep 2019 07:50:03 +0100,
>> "Shenhar, Talel" wrote:
>>> On 9/11/2019 5:15 PM, Marc Zyngier wrote:
On Tue, 10 Sep 2019 20:05:09 +0100,
Talel Shenhar wrote:
> + if (!FIEL
Hi Tyler,
On 11/07/2019 05:14, Tyler Baicar OS wrote:
> On Tue, Jul 9, 2019 at 8:52 PM Tyler Baicar OS
> wrote:
>> On Mon, Jul 8, 2019 at 10:10 AM James Morse wrote:
>>> On 02/07/2019 17:51, Tyler Baicar OS wrote:
>>>> @@ -632,6 +633,8 @@ static int do_sea
Hi Christoph,
(CC: +Xiongfeng)
Thanks for the reminder - I was just searching for who was using this.
On 04/05/2020 17:42, Christoph Hellwig wrote:
> The export symbols to register/unregister and enable/disable events
> aren't ever used outside of arm_sdei.c, so mark them static.
Xiongfeng, you
1], I've picked up all the review feedback and collected the
tags.
Nothing in this series should change any behaviour.
This series is based on v5.7-rc3.
Thanks,
James
[v1] https://lore.kernel.org/lkml/20200214182401.39008-1-james.mo...@arm.com/
James Morse (10):
x86/resctrl: Nothing u
perty arch_has_sparse_bitmaps. Test this
around the 'non-consecutive' test in cbm_validate().
Merging the validate calls causes AMD top gain the min_cbm_bits test
needed for Haswell, but as it always sets this value to 1, it will
never match.
CC: Babu Moger
Signed-off-by: James Morse
Reviewed-by:
Nothing reads struct mbm_states's chunks_bw value, its a copy of
chunks. Remove it.
Signed-off-by: James Morse
Reviewed-by: Reinette Chatre
---
arch/x86/kernel/cpu/resctrl/internal.h | 2 --
arch/x86/kernel/cpu/resctrl/monitor.c | 3 +--
2 files changed, 1 insertion(+), 4 deletions(-)
Removing this duplication means user-space visible behaviour and
error messages are not validated or generated in different places.
CC: Babu Moger
Signed-off-by: James Morse
---
arch/x86/kernel/cpu/resctrl/core.c| 3 +-
arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 57 +--
We are about to disturb the header soup. This header uses struct pid
and struct pid_namespace. Include their header.
Signed-off-by: James Morse
Reviewed-by: Reinette Chatre
---
include/linux/resctrl.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/resctrl.h b/include/linux
intel_cacheinfo.c,
name it get_cpu_cacheinfo_id() to show its relation with
get_cpu_cacheinfo().
Now this is visible on other architectures, check the id attribute
has actually been set.
Signed-off-by: James Morse
---
arch/x86/kernel/cpu/resctrl/core.c | 17 ++---
include/linux
is harmless
as rdtgroup_mkdir() tests these capable flags before allowing the config
directories to be created.
Signed-off-by: James Morse
Reviewed-by: Reinette Chatre
---
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 30 --
1 file changed, 14 insertions(+), 16 deletions
mbm_handle_overflow() and cqm_handle_limbo() are both provided with
the domain's work_struct when called, but use get_domain_from_cpu()
to find the domain, along with the appropriate error handling.
container_of() saves some list walking and bitmap testing, use that
instead.
Signed-off-by:
The comment in rdtgroup_init() refers to the non existent function
rdt_mount(), which has now been renamed rdt_get_tree(). Fix the
comment.
Signed-off-by: James Morse
Reviewed-by: Reinette Chatre
---
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
max_delay is used by x86's __get_mem_config_intel() as a local variable.
Remove it, replacing it with a local variable.
Signed-off-by: James Morse
Reviewed-by: Reinette Chatre
---
arch/x86/kernel/cpu/resctrl/core.c | 8
arch/x86/kernel/cpu/resctrl/internal.h | 3 ---
2
mains"
error message for affected platforms.
CC: Babu Moger
Signed-off-by: James Morse
Reviewed-by: Reinette Chatre
---
An alternative to this is for Intel non-linear MBA resources to
clear alloc_capable as they can't be configured anyway.
---
arch/x86/kernel/cpu/resctrl/core.c
Hi Lei,
On 21/10/2019 18:36, Lei Wang wrote:
>> It looks like your patches didn't make it to the mailing list:
>> https://lore.kernel.org/r/by5pr04mb6599eaa659a53b2331cb812586...@by5pr04mb6599.namprd04.prod.outlook.com
>>
>> You can search on https://lore.kernel.org/linux-edac/, I can only see the
Hi guys,
On 11/10/2019 11:05, Sudeep Holla wrote:
> On Fri, Oct 11, 2019 at 11:26:04AM +0200, Marek Szyprowski wrote:
>> Recently I've got access to ARM Juno R1 board and did some tests with
>> current mainline kernel on it. I'm a bit surprised that enabling
>> CONFIG_PROVE_LOCKING causes a boot f
Hi Pavel,
On 04/10/2019 19:52, Pavel Tatashin wrote:
> Currently, kernel relocation function is configured in machine_kexec()
> at the time of kexec reboot by using control_code_page.
>
> This operation, however, is more logical to be done during kexec_load,
> and thus remove from reboot time. Mo
Hi Pavel,
On 26/03/2020 03:24, Pavel Tatashin wrote:
> kexec is going to use a different allocator, so make
> trans_pgd_map_page to accept allocator as an argument, and also
> kexec is going to use a different map protection, so also pass
> it via argument.
This trans_pgd_map_page() used to be c
not used, it is NULL.
> Change the dtb_mem to phys_addr_t, as it is a physical address.
Regardless,
Reviewed-by: James Morse
Thanks,
James
Hi Pavel,
On 26/03/2020 03:24, Pavel Tatashin wrote:
> Now, that we abstracted the required functions move them to a new home.
> Later, we will generalize these function in order to be useful outside
> of hibernation.
Reviewed-by: James Morse
Thanks,
James
_populate() helpers don't use the mm parameter, so it doesn't make
any
difference. This was originally done so that if we ever needed anything from
the mm, we
didn't get a NULL dereference or EL0 behaviour due to a future '!= &init_mm'.
If you think it matters,
Acked-by: James Morse
Thanks,
James
Hi Pavel,
On 26/03/2020 03:24, Pavel Tatashin wrote:
> From: James Morse
>
> To resume from hibernate, the contents of memory are restored from
> the swap image. This may overwrite any page, including the running
> kernel and its page tables.
>
> Hibernate copies the c
Hi Pavel,
On 26/03/2020 03:24, Pavel Tatashin wrote:
> Make trans_pgd_create_copy and its subroutines to use allocator that is
> passed as an argument
Reviewed-by: James Morse
Thanks,
James
Hi Pavel,
On 26/03/2020 03:24, Pavel Tatashin wrote:
> Change argument types from unsigned long to a more descriptive
> phys_addr_t.
For 'entry', which is a physical addresses, sure...
> diff --git a/arch/arm64/kernel/cpu-reset.h b/arch/arm64/kernel/cpu-reset.h
> index ed50e9587ad8..38cbd4068019
Keeping it next
to the modification makes it clearer why it is required.
In this case we can use flush_icache_range() instead of its __variant because
this now
happens much earlier.
> + return 0;
> +}
Regardless,
Reviewed-by: James Morse
Thanks,
James
ith copy of arm64_relocate_new_kernel is known.
Sure, keep the earlier version that is more likely to be seen.
Acked-by: James Morse
Thanks,
James
Holla wrote:
>>>>> On Fri, Oct 11, 2019 at 03:02:42PM +0200, Marek Szyprowski wrote:
>>>>>> On 11.10.2019 12:38, James Morse wrote:
>>>>>>> On 11/10/2019 11:05, Sudeep Holla wrote:
>>>>>>>> On Fri, Oct 11, 2019 at 11:26:04
201 - 300 of 707 matches
Mail list logo
