Re: ppp_mppe+pptp for 2.6.14?

2005-08-29 Thread James Cameron
On Mon, Aug 29, 2005 at 05:10:34PM -0500, Matt Domsch wrote: > I've asked James Cameron, pptp project lead, to try a test to force > the server side to issue a CCP DOWN, to make sure the client-side > kernel ppp_generic module does the right thing and drops packets. I'm st

Re: ppp_mppe+pptp for 2.6.14?

2005-08-29 Thread James Cameron
My problems with ENOPROTOOPT were due to lack of coffee. They were caused by ICMP protocol unreachable responses from the test server because I'd taken away it's pppd. My mistake. On Mon, Aug 29, 2005 at 05:10:34PM -0500, Matt Domsch wrote: > I've asked James Cameron, pptp pr

Re: [PATCH] bcma: Use bcma_debug and not pr_cont in MIPS driver

2017-10-18 Thread James Cameron
; > +for (i = 0; i < ARRAY_SIZE(irq_name); i++) > +ints += sprintf(ints, " %s%c", > + irq_name[i], i == irq ? '*' : ' '); But not on this line. > + > +bcma_debug(dev->bus, "core 0x%04x, irq:%s\n", dev->id.id, > interrupts); > } > > static void bcma_core_mips_dump_irq(struct bcma_bus *bus) > -- > 2.10.0.rc2.1.g053435c > -- James Cameron http://quozl.netrek.org/

Re: [PATCH 06/15] Platform: OLPC: Add XO-1.75 EC driver

2018-11-13 Thread James Cameron
_ec *priv = platform_get_drvdata(pdev); > > > + unsigned char x = 0; > > > > u8 > > > > > + priv->suspended = false; > > > > Isn't it redundant since noirq callback above? > > > > > + /* > > > +* The resume hint is only needed if no other commands are > > > +* being sent during resume. all it does is tell the EC > > > +* the SoC is definitely awake. > > > +*/ > > > + olpc_ec_cmd(CMD_SUSPEND_HINT, &x, 1, NULL, 0); > > > + > > > + /* Enable all EC events while we're awake */ > > > + olpc_xo175_ec_set_event_mask(0x); > > > > #define EC_ALL_EVENTS GENMASK(15, 0) > > > > > +} > > > +#endif > > > +static struct platform_device *olpc_ec; > > > > I would rather see this at the top of file. > > > > > +static int olpc_xo175_ec_probe(struct spi_device *spi) > > > +{ > > > + if (olpc_ec) { > > > + dev_err(&spi->dev, "OLPC EC already > > > registered.\n"); > > > + return -EBUSY; > > > + } > > > > It's racy against parallel probe called. I don't think it would be a > > real issue, just let you know. > > > > > > > + /* Set up power button input device */ > > > + priv->pwrbtn = devm_input_allocate_device(&spi->dev); > > > + if (!priv->pwrbtn) > > > + return -ENOMEM; > > > + priv->pwrbtn->name = "Power Button"; > > > + priv->pwrbtn->dev.parent = &spi->dev; > > > + input_set_capability(priv->pwrbtn, EV_KEY, KEY_POWER); > > > + ret = input_register_device(priv->pwrbtn); > > > + if (ret) { > > > + dev_err(&spi->dev, "error registering input device: > > > %d\n", ret); > > > + return ret; > > > + } > > > > I would split out power button driver, but it's up to you. > > > > > > > + /* Enable all EC events while we're awake */ > > > + olpc_xo175_ec_set_event_mask(0x); > > > > See above about this magic. > > > > > +} > > > +#ifdef CONFIG_PM > > > + .suspend= olpc_xo175_ec_suspend, > > > + .resume_noirq = olpc_xo175_ec_resume_noirq, > > > + .resume = olpc_xo175_ec_resume, > > > +#endif > > > > SET_SYSTEM_SLEEP_PM_OPS() ? > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() ? > > > > > +static const struct of_device_id olpc_xo175_ec_of_match[] = { > > > + { .compatible = "olpc,xo1.75-ec" }, > > > + { }, > > > > No comma for terminators. > > > > > +}; > > Thanks, > Lubo > -- James Cameron http://quozl.netrek.org/

Re: [PATCH v4 0/20] MMP platform fixes

2018-12-02 Thread James Cameron
e the narrow side edge to hit with. Users have tried the large flat surface behind the display, but the display tends to fail after five to ten hits. It will depend on the tiger. -- James Cameron http://quozl.netrek.org/

Re: [PATCH 05/11] DT: marvell,mmp2: Add SSP1 and SSP3

2018-10-28 Thread James Cameron
lay. Love your work! From my notes, SSP2 is 0xd4036000, and SSP4 is 0xd4039000. Can be probed by hand in OpenFirmware or CForth once clocks are on. -- James Cameron http://quozl.netrek.org/

Re: [PATCH v2 0/8] OLPC 1.75 Keyboard/Touchpad fixes

2018-10-30 Thread James Cameron
ernel messages. > > Any ideas? > > Could I get prepared binary zImage for testing? > > Thanks, > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) > http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- James Cameron http://quozl.netrek.org/

Re: [PATCH v2 0/8] OLPC 1.75 Keyboard/Touchpad fixes

2018-10-30 Thread James Cameron
loper, but so much else to do now. > If this won't boot for you, we may need fixes for older FW. Let me know what you need there; with a patch, and if it isn't too extensive I could spin a new build. We're not producing these models, so I don't _have_ to keep the factory test code working. https://github.com/quozl/openfirmware -- James Cameron http://quozl.netrek.org/

Re: [RFC PATCH V2] ARM: compressed: Move ramdisk forward to reserve more memory for kernel image

2014-01-08 Thread James Cameron
esult, the maximum size > + of the decompressed kernel image is limited by the size of the > + reserved memory space (the difference of the two contiguous memory > + addresses). Same here. > + > + If want more functions or some debug options, the decompressed ker

Re: [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e

2014-04-24 Thread James Cameron
ule/rules" and "s/following/followed". On the other hand, no other driver mentions this implementation detail of IW_IS_SET in declaration of iw_priv_args, so perhaps the whole comment block should be removed. Either way; Reviewed-by: James Cameron p.s. nice to see you ag

Re: [PATCH] libertas: fix return value when processing invalid packet

2014-05-22 Thread James Cameron
_packet() is called) that the debugging > enter/leave functions are balanced. > > Signed-off-by: Dan Williams Reviewed-by: James Cameron -- James Cameron http://quozl.linux.org.au/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-05 Thread James Cameron
ssages appear. I have tried changing command line to console=ttyS0,115200. 1. http://dev.laptop.org/~quozl/y/1VojGn.txt (diff relative to olpc-kernel/arm-3.5) 2. http://dev.laptop.org/~quozl/z/1VojLz.txt (dmesg) -- James Cameron http://quozl.linux.org.au/ -- To unsubscribe from this list: send

Re: [PATCH] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-05 Thread James Cameron
UART_DLL); > - WARN_ON(dll != (quot & 0xff)); If this is no longer needed, serial_pxa_dl_write can be removed because it is same as default_serial_dl_write. I did not check the other errata work arounds. -- James Cameron http://quozl.linux.org.au/ -- To unsubscribe from this list: sen

Re: [PATCH] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-05 Thread James Cameron
On Fri, Dec 06, 2013 at 11:38:51AM +1100, James Cameron wrote: > On Fri, Dec 06, 2013 at 03:28:37AM +0400, Sergei Ianovich wrote: > > pxa2xx-uart was a separate uart platform driver. It was declaring > > the same device names and numbers as 8250 driver. As a result, > > it

Re: [PATCH v2] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-06 Thread James Cameron
2xx-uart turned out to be a clone of > 8250_core driver. > > Workaround for Erratum #19 according to Marvel(R) PXA270M Processor > Specification Update (April 19, 2010) is dropped. 8250_core reads > from FIFO immediately after checking DR bit in LSR. Reviewed-by: James Cameron Tha

Re: [PATCH] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-06 Thread James Cameron
tch removes CONFIG_SERIAL_PXA_CONSOLE option. I've updated all > in-kernel users. However, out-of-kernel configs will no longer provide > serial console, unless manually reconfigured. Is this the case we should > worry about? OLPC holds an out-of-kernel config (xo_4_defconfig); but no,

Re: [PATCH] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-06 Thread James Cameron
On Fri, Dec 06, 2013 at 02:34:17PM +0400, Sergei Ianovich wrote: > On Fri, 2013-12-06 at 20:53 +1100, James Cameron wrote: > > I don't understand why /dev/ttyS2 (4,66) changed to /dev/ttyS0 (4,64) > > after the patch was applied to olpc-kernel/arm-3.5 but, as you say it > &g

Re: [PATCH] net: mark DECnet as broken

2016-04-07 Thread James Cameron
https://lkml.org/lkml/2015/12/17/666 > Cc: Eric Dumazet > Cc: Sasha Levin > Cc: David Miller Reviewed-by: James Cameron (An old DECnet application programmer from way back, ah what fun!) > --- > net/decnet/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > dif

Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions (aliased with Winbond)

2016-03-31 Thread James Cameron
was unable to use SFDP; some devices didn't have them, some didn't seem to be good data. > > Anyway if we cannot completely rely on the SFDP tables we could still use > DT properties but we should no longer expect to guess all hardware parameters > from the JEDEC ID alone. We solved this problem by not using our SPI Flash from the kernel, but that's not the best outcome. ;-) > > Best regards, > > Cyrille -- James Cameron http://quozl.netrek.org/

Re: [ldv-project] [net] libertas: potential race condition

2016-06-14 Thread James Cameron
On Tue, Jun 14, 2016 at 05:16:11PM +0400, Pavel Andrianov wrote: > 08.06.2016 02:51, James Cameron пишет: > >On Tue, Jun 07, 2016 at 09:39:55AM -0500, Dan Williams wrote: > >>On Tue, 2016-06-07 at 13:30 +0400, Pavel Andrianov wrote: > >>>Hi! > >>> &

Re: [ldv-project] [net] libertas: potential race condition

2016-06-07 Thread James Cameron
eal race or I have missed something? > > Yeah, it looks like it should be grabbing priv->driver_lock before > clearing priv->currenttxskb in lbs_mac_event_disconnected().  Care to > submit a patch after testing?  Do you have any of that hardware? I've hardware, with serial console. Can test any patch, on USB (8388) or SDIO (8686). -- James Cameron http://quozl.netrek.org/

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-28 Thread James Cameron
teresting, we're back to this symptom again. Nice to see this fix. Heavy memory pressure on 3.5 caused dev_alloc_skb failure in this driver. Tracked at OLPC as #12694. -- James Cameron http://quozl.netrek.org/

Re: [patch V2 33/36] net: libertas: Use netif_rx_any_context()

2020-09-29 Thread James Cameron
follow. > > As a stop gap use netif_rx_any_context() which invokes the correct code > path depending on context and confines the in_interrupt() usage to core > code. > > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Acked-by: Kalle Valo