[GIT PULL] Final round of SCSI updates for the 3.9+ merge window

2013-05-10 Thread James Bottomley
fnic: FIP VLAN Discovery Feature Support James Bottomley (3): sas: unify the pointlessly separated enums sas_dev_type and sas_device_type lpfc: fix up Kconfig dependencies sd: fix array cache flushing bug causing performance problems James Smart (22): lpfc 8.3.39: Upd

Re: [PATCH 1/2] Kernel/time: Introduce a new timestamp function local_time_seconds()

2013-05-15 Thread James Bottomley
On Wed, 2013-05-15 at 11:32 +0800, Gu Zheng wrote: > On 05/14/2013 11:57 PM, John Stultz wrote: > > > On 05/14/2013 12:45 AM, Gu Zheng wrote: > >> From 18072c1c3506a7e37ee485307a2c343efe5af4d0 Mon Sep 17 00:00:00 2001 > >> From: Gu Zheng > >> Date: Mon, 13 May 2013 15:45:24 +0900 > >> Subject: [

Re: [PATCH V7 0/5] virtio-scsi multiqueue

2013-04-06 Thread James Bottomley
On Fri, 2013-04-05 at 16:55 +0800, Wanlong Gao wrote: > On 03/28/2013 10:22 AM, Wanlong Gao wrote: > > On 03/23/2013 07:28 PM, Wanlong Gao wrote: > >> This series implements virtio-scsi queue steering, which gives > >> performance improvements of up to 50% (measured both with QEMU and > >> tcm_vhos

Re: [PATCH 2/3] PCI: Handle device quirks when accessing sysfs resource entries

2013-04-06 Thread James Bottomley
On Thu, 2013-04-04 at 12:06 -0600, Bjorn Helgaas wrote: > On Thu, Mar 21, 2013 at 6:51 PM, Robert Hancock wrote: > > On 03/20/2013 10:35 PM, Myron Stowe wrote: > >> > >> Sysfs includes entries to memory regions that back a PCI device's BARs. > >> The pci-sysfs entries backing I/O Port BARs can be

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread James Bottomley
On Sat, 2013-04-06 at 15:22 +1030, Rusty Russell wrote: > > The problem is our assumption that section names be unique. This > > assumption is wrong. The ELF spec says (version 1.1 page 1-15): "An > > object file may have more than one section with the same name." We need > > to fix the kernel n

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread James Bottomley
John David Anglin wrote: >On 6-Apr-13, at 6:52 AM, James Bottomley wrote: > >> On Sat, 2013-04-06 at 15:22 +1030, Rusty Russell wrote: >>>> The problem is our assumption that section names be unique. This >>>> assumption is wrong. The ELF spec says (vers

Re: [PATCH] scsi: fix null pointer dereference in sd_revalidate_disk

2013-04-08 Thread James Bottomley
On Mon, 2013-04-08 at 13:42 +0200, Oskar Andero wrote: > On 14:36 Thu 07 Mar , oskar.and...@sonymobile.com wrote: > > From: "syunsuke.x.itou" > > > > By repeatadly connecting/disconnecting a USB masstorage device > > a null pointer dereference can be provoked. This is caused by > > sd_revalid

checkpatch: kill the bogus camelcase check

2013-04-09 Thread James Bottomley
en by Microsoft people). In order to encourage people to use checkpatch, it has to be *useful* it can't stray too far into dogmatic things like this that are essentially unfixable by most people who submit patches. Signed-off-by: James Bottomley --- diff --git a/scripts/checkpatch.pl b/s

Re: checkpatch: kill the bogus camelcase check

2013-04-10 Thread James Bottomley
On Wed, 2013-04-10 at 16:52 +0200, Borislav Petkov wrote: > On Wed, Apr 10, 2013 at 07:35:58AM -0700, Joe Perches wrote: > > or maybe exclude drivers/scsi and include/scsi/ > > and arch/x86/kvm/emulate.c Actually, we get this all over drivers. Some of the problems are to do with the fact that th

[GIT PULL] First round of SCSI updates for the 3.9+ merge window

2013-04-30 Thread James Bottomley
This is the first round, consisting mostly of drivers and patches submitted 3 weeks ago. Since I've been travelling quite a bit, there will be a second round just before the merge window closes for all the patches three weeks or newer, or which got flagged for my attention after 10 April. The pat

Re: [PATCH] checkpatch: Make camelcase test --strict and less noisy

2013-05-01 Thread James Bottomley
On Wed, 2013-05-01 at 14:34 +0200, Borislav Petkov wrote: > On Thu, Apr 11, 2013 at 07:45:03AM -0700, Joe Perches wrote: > > CamelCase tests are a bit noisy against certain > > types of code acceptable to some kernel developers. > > > > Make the test applicable only with --strict. > > > > Do not

Re: [PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants

2013-05-01 Thread James Bottomley
On Mon, 2013-04-29 at 15:21 +0200, Arnd Bergmann wrote: > On Friday 26 April 2013, Masanori Goto wrote: > > 2013/4/25 Arnd Bergmann > > > > > > ARM cannot handle udelay for more than 2 miliseconds, so we > > > should use mdelay instead for those. > > > > > > > Singed-off-by: GOTO Masanori > >

Re: [PATCH 1/1] cciss: bug fix to prevent cciss from loading in kdump crash kernel

2013-05-03 Thread James Bottomley
iately call cciss_hard_reset_controller. This will result in a kernel panic and the core file cannot be created. This patch prevents cciss from trying to load in this scenario. Signed-off-by: Mike Miller Cc: Signed-off-by: James Bottomley diff --git a/drivers/block/cciss.c b/drivers/block

Re: libata maintainership change

2013-05-03 Thread James Bottomley
On Fri, 2013-05-03 at 16:01 -0400, Jeff Garzik wrote: > Time for new open source pastures outside the kernel, for me. SATA is > slowly getting unexciting to the world. Which, really, just means the > brand new technology has reached a usable plateau. :) And maybe in a > few years, with direc

Re: linux-next: Tree for May 6 (lpfc)

2013-05-06 Thread James Bottomley
On Mon, 2013-05-06 at 09:14 -0700, Randy Dunlap wrote: > On 05/05/13 21:42, Stephen Rothwell wrote: > > Hi all, > > > > Please do not add any v3.11 destined work to your linux-next included > > branches until after v3.10-rc1 is released. > > > > I am receiving a (un)reasonable number of conflicts

Re: [PATCH] parisc: avoid WARNING: at kernel/cpu/idle.c:96

2013-05-08 Thread James Bottomley
On Wed, 2013-05-08 at 22:42 +0200, Helge Deller wrote: > We need to enable local irqs to avoid this runtime warning. > > Signed-off-by: Helge Deller > > diff --git a/arch/parisc/kernel/process.c b/arch/parisc/kernel/process.c > index 55f92b6..2840d43 100644 > --- a/arch/parisc/kernel/process.c >

Re: [PATCH] block: fix max discard sectors limit

2013-04-24 Thread James Bottomley
On Wed, 2013-04-24 at 22:55 +0900, Namjae Jeon wrote: > From: James Bottomley > > linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with > commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9 > (block: add plug for blkdev_issue_discard ) > > For example, > 1

Re: [PATCH] block: fix max discard sectors limit

2013-04-24 Thread James Bottomley
On Wed, 2013-04-24 at 08:23 -0600, Jens Axboe wrote: > On Wed, Apr 24 2013, Namjae Jeon wrote: > > From: James Bottomley > > > > linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with > > commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296

Re: [PATCH RESEND^2] sd: fix infinite kernel/udev loop on non-removable Medium Not Present

2013-04-26 Thread James Bottomley
On Fri, 2013-04-26 at 11:39 -0500, Steven J. Magnani wrote: > Commit eface65c336eff420d70beb0fb6787a732e05ffb (2.6.38) altered > set_media_not_present() in a way that prevents the sd driver from > remembering that a non-removable device has reported "Medium Not Present". > This condition can occur

Re: license of string_helpers module

2013-04-11 Thread James Bottomley
On Thu, 2013-04-11 at 16:43 +, Shevchenko, Andriy wrote: > Hello, James. > > Could you please share what is the License applied to the > lib/string_helpers.c module which you wrote on 2008? Um, it's in the kernel, so it follows the licence of the COPYING file, so GPLv2 only. > Shall we updat

[GIT PULL] SCSI fixes for 3.9-rc6

2013-04-12 Thread James Bottomley
This is a set of ten bug fixes (and two consisting of copyright year update and version number change) pretty much all of which involve either a crash or a hang except the removal of the random sleep from the qla2xxx driver (which is a coding error so bad, we want it gone before anyone has a chance

Re: [PATCH] sd: fix infinite kernel/udev loop on non-removable Medium Not Present

2013-04-12 Thread James Bottomley
Could you resend this, cc'ing the linux-s...@vger.kernel.org mailing list? Thanks, James On Fri, 2013-04-12 at 15:44 -0500, Steve Magnani wrote: > Commit eface65c336eff420d70beb0fb6787a732e05ffb (2.6.38) altered > set_media_not_present() in a way that prevents the sd driver from > remembering t

Re: [PATCH] scsi: pcmcia: nsp_cs: remove module init/exit function prototypes

2013-04-15 Thread James Bottomley
On Mon, 2013-04-15 at 09:42 -0700, H Hartley Sweeten wrote: > This driver now uses the module_pcmcia_driver() macro to supply the > init/exit code. The nsp_cs_{init,exit} prototypes should be removed. This reasoning is bogus. Why the driver actually has all these static prototypes in its header f

Re: [PATCH] parisc: avoid WARNING: at kernel/cpu/idle.c:96

2013-05-16 Thread James Bottomley
On Wed, 2013-05-08 at 14:05 -0700, James Bottomley wrote: > On Wed, 2013-05-08 at 22:42 +0200, Helge Deller wrote: > > We need to enable local irqs to avoid this runtime warning. > > > > Signed-off-by: Helge Deller > > > > diff --git a/arch/parisc/kernel/process

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread James Bottomley
On Wed, 2013-05-22 at 12:23 +0200, Paolo Bonzini wrote: > Il 22/05/2013 12:02, Tejun Heo ha scritto: > > On Wed, May 22, 2013 at 11:53:30AM +0200, Paolo Bonzini wrote: > >> Il 22/05/2013 11:32, Tejun Heo ha scritto: > >>> On Wed, May 22, 2013 at 08:35:54AM +0200, Paolo Bonzini wrote: > I'm not

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread James Bottomley
On Thu, 2013-05-23 at 15:58 +0200, Paolo Bonzini wrote: > Adjust the blk_verify_command function to let it look at per-queue > data. This will be done in the next patch. This is not a bug fix. This is an enabler for your complex and to my mind dubious rework of the SG_IO command filter. I'm run

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread James Bottomley
On Fri, 2013-05-24 at 09:43 +0200, Paolo Bonzini wrote: > Il 24/05/2013 09:36, James Bottomley ha scritto: > > On Thu, 2013-05-23 at 15:58 +0200, Paolo Bonzini wrote: > >> Adjust the blk_verify_command function to let it look at per-queue > >> data. This wil

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread James Bottomley
On Fri, 2013-05-24 at 09:53 +0200, Paolo Bonzini wrote: > Il 24/05/2013 09:50, James Bottomley ha scritto: > > On Fri, 2013-05-24 at 09:43 +0200, Paolo Bonzini wrote: > >> Il 24/05/2013 09:36, James Bottomley ha scritto: > >>> On Thu, 2013-05-23 at 15:58 +0200, Paol

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread James Bottomley
On Fri, 2013-05-24 at 10:32 +0200, Paolo Bonzini wrote: > Il 24/05/2013 10:03, James Bottomley ha scritto: > >>>>> > >>> Does anyone in the real world actually care about this bug? > >>>> > >> > >>>> > >> Yes, or

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-24 Thread James Bottomley
On Fri, 2013-05-24 at 17:02 +0900, Tejun Heo wrote: > On Fri, May 24, 2013 at 4:13 PM, Paolo Bonzini wrote: > >> The same filtering table being applied to different classes of > >> hardware is a software bug, but my point is that the practive > >> essentially entrusts non-insignificant part of sec

Re: [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver

2013-05-26 Thread James Bottomley
On Mon, 2013-05-27 at 10:28 +0800, Libo Chen wrote: > use module_pci_driver instead of init/exit, make code clean. For the ancient drivers, like this, the principal is that we really don't touch except for tested bug fixes. For the current ones (like mvumi) it's up to the maintainer. James --

Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-08 Thread James Bottomley
On Fri, 2013-03-08 at 12:57 -0500, Douglas Gilbert wrote: > On 13-03-08 07:02 AM, Dan Carpenter wrote: > > Static checkers complain that this allocation isn't checked. We > > should return zero if the allocation fails. > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/scsi/scsi_tr

Re: [PATCH -mmotm] scsi: fix the wrong position of the comment

2013-03-10 Thread James Bottomley
[missing SCSI cc added] On Sun, 2013-03-10 at 17:09 +0900, Akinobu Mita wrote: > This fixes the wrong position of the comment introduced by > scsi-rename-random32-to-prandom_u32.patch in the -mm tree. > > Signed-off-by: Akinobu Mita > Cc: "James E.J. Bottomley" > Cc: Andrew Vasquez > --- > dri

Re: [PATCH -mmotm] scsi: fix the wrong position of the comment

2013-03-10 Thread James Bottomley
On Sun, 2013-03-10 at 00:57 -0800, Andrew Morton wrote: > On Sun, 10 Mar 2013 08:22:47 +0000 James Bottomley > wrote: > > > [missing SCSI cc added] > > On Sun, 2013-03-10 at 17:09 +0900, Akinobu Mita wrote: > > > This fixes the wrong position of the comment i

Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-11 Thread James Bottomley
On Mon, 2013-03-11 at 10:48 -0400, Douglas Gilbert wrote: > On 13-03-11 09:10 AM, Dan Carpenter wrote: > > On Fri, Mar 08, 2013 at 10:50:19PM +0000, James Bottomley wrote: > >> On Fri, 2013-03-08 at 12:57 -0500, Douglas Gilbert wrote: > >>> On 13-03-08 07:02 AM, Dan

Re: [PATCH 12/13] scsi/tracing: include correct header file

2013-03-11 Thread James Bottomley
On Mon, 2013-03-11 at 10:21 -0400, Steven Rostedt wrote: > As you didn't include James in the header patch [0/13], he didn't see > you say: > > "Two patches changed compilation on scsi subsystem, it should go through > to > SCSI tree." > > In the future, send them as a separate patch series. Ther

Re: [PATCH] aic7xxx: fix coccicheck warnings

2013-03-12 Thread James Bottomley
On Tue, 2013-03-12 at 08:48 +0200, Silviu Popescu wrote: > On Sun, Mar 10, 2013 at 10:04 PM, Silviu-Mihai Popescu > wrote: > > This replaces a call to kmalloc() followed by memset() with just one > > call to kzalloc(). > > > > Signed-off-by: Silviu-Mihai Popescu > > --- > > drivers/scsi/aic7xxx/

Re: [PATCH 12/18] driver: scsi: remove cast for kmalloc/kzalloc return value

2013-03-12 Thread James Bottomley
On Tue, 2013-03-12 at 13:25 +0800, Zhang Yanfei wrote: > remove cast for kmalloc/kzalloc return value. I've got to ask why? Just because void * can be assigned to any pointer doesn't mean we should religiously eliminate all casts of void *. If the driver writer believes there's value making sure

Re: [PATCH v2] parisc: fix personality flag check in copy_thread()

2012-08-02 Thread James Bottomley
On Thu, 2012-08-02 at 09:12 +0200, Jiri Kosina wrote: > Directly comparing task_struct->personality against PER_* is not fully > correct, as it doesn't take flags potentially stored in top three bytes > into account. > > Analogically, directly forcefully setting personality to PER_LINUX32 or > PER

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-02 Thread James Bottomley
On Thu, 2012-08-02 at 17:41 +0900, Chanho Min wrote: > This patch is to fix a oops from a torn down device. When > scsi_run_queue process starved queues, scsi_request_fn can race with > scsi_remove_device. In this case, rarely, scsi_request_fn release the > last reference and set sdev->request_queu

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-02 Thread James Bottomley
On Thu, 2012-08-02 at 18:28 +0900, Chanho Min wrote: > On Thu, Aug 2, 2012 at 5:57 PM, James Bottomley > wrote: > > On Thu, 2012-08-02 at 17:41 +0900, Chanho Min wrote: > >> This patch is to fix a oops from a torn down device. When > >> scsi_run_queue process starv

Re: [PATCH v2] parisc: fix personality flag check in copy_thread()

2012-08-02 Thread James Bottomley
On Thu, 2012-08-02 at 13:45 +0200, Jiri Kosina wrote: > On Thu, 2 Aug 2012, James Bottomley wrote: > > > > Directly comparing task_struct->personality against PER_* is not fully > > > correct, as it doesn't take flags potentially stored in to

[Tech-board-discuss] Linux Foundation Technical Advisory Board Elections and Nomination process

2012-08-24 Thread James Bottomley
(Kernel Summit, LinuxCon and Plumbers). Anyone is eligible to stand for election, simply send your nomination to: tech-board-disc...@lists.linux-foundation.org We currently have six nominees for five places (so we will be holding an election): Chris Mason Hugh Blemings James Bottomley John W

Re: [RFC] cgroup TODOs

2012-09-16 Thread James Bottomley
On Fri, 2012-09-14 at 14:36 -0400, Aristeu Rozanski wrote: > also, heard about the desire of having a device namespace instead with > support for translation ("sda" -> "sdf"). If anyone see immediate use for > this please let me know. That sounds like a really bad idea to me. We've spent ages tra

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-17 Thread James Bottomley
On Sun, 2008-02-17 at 16:25 +1100, Stephen Rothwell wrote: > Hi James, > > On Sat, 16 Feb 2008 09:14:32 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > > > Do you have the tree and build logs available anywhere? I'd like to > > turn off the merge tree

Re: [PATCH] ieee1394: sbp2: fix rescan-scsi-bus

2008-02-17 Thread James Bottomley
On Sun, 2008-02-17 at 14:57 +0100, Stefan Richter wrote: > rescan-scsi-bus used to add SBP-2 targets which weren't there. > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > --- > drivers/ieee1394/sbp2.c |3 +++ > 1 file changed, 3 insertions(+) > > Index: linux/drivers/ieee1394/sbp2.c

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread James Bottomley
On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > This patch removes dead code spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > > drivers/scsi/qla4xxx/ql4_isr.c | 18 +- > 1 file changed, 1 insertion(+), 17 deletions(-) > > -

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread James Bottomley
On Tue, 2008-02-19 at 18:35 -0800, Andrew Vasquez wrote: > On Tue, 19 Feb 2008, James Bottomley wrote: > > > On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > > > This patch removes dead code spotted by the Coverity checker. > > > > > > Signe

Re: linux-next: Tree for Feb 20

2008-02-20 Thread James Bottomley
On Wed, 2008-02-20 at 16:34 +1100, Stephen Rothwell wrote: > Hi all, > > I have created today's linux-next tree at > git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git. > > You can see which trees have been included by looking in the Next/Trees > file in the source. There are also

Re: linux-next: Tree for Feb 20

2008-02-20 Thread James Bottomley
On Thu, 2008-02-21 at 02:20 +1100, Stephen Rothwell wrote: > Hi James, > > On Wed, 20 Feb 2008 08:59:20 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > > > Is the merge log available anywhere yet? > > Are you looking for more that what is in Next/merge

[PATCH] pci: remove parisc consumer of the pci global_list

2008-02-20 Thread James Bottomley
The patch pci-remove-global-list-of-pci-devices.patch misses the parisc dino use of this. However, it's a simple removal job. Signed-off-by: James Bottomley <[EMAIL PROTECTED]> --- diff --git a/drivers/parisc/dino.c b/drivers/parisc/dino.c index 03c763c..d9c6322 100644 --- a/dri

Re: New 2.6.24.2 SG_IO SCSI problems

2008-02-21 Thread James Bottomley
On Thu, 2008-02-21 at 10:15 -0500, Mark Hounschell wrote: > I seem to have run into some sort of regression in the SG_IO interface of > 2.6.24.2. > I have an application that up until 2.6.24 worked fine. The 2.6.23.16 kernel > works fine. > > During reads I get these kernel messages. Writes and

Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-14 Thread James Bottomley
On Tue, 2012-08-14 at 18:48 +0900, Chanho Min wrote: > We don't need to unlock the queue before put_device in scsi_request_fn() > If we trigger the ->remove() function, It occur a oops from the caller. > So sdev reference count should not be dropped to zero here. > Also It was added before scsi_dev

Re: [PATCH v2 04/11] kmem accounting basic infrastructure

2012-08-15 Thread James Bottomley
On Wed, 2012-08-15 at 13:33 +0400, Glauber Costa wrote: > > This can > > be quite confusing. I am still not sure whether we should mix the two > > things together. If somebody wants to limit the kernel memory he has to > > touch the other limit anyway. Do you have a strong reason to mix the > > u

Re: [PATCH v2 04/11] kmem accounting basic infrastructure

2012-08-15 Thread James Bottomley
On Wed, 2012-08-15 at 14:55 +0200, Michal Hocko wrote: > On Wed 15-08-12 12:12:23, James Bottomley wrote: > > On Wed, 2012-08-15 at 13:33 +0400, Glauber Costa wrote: > > > > This can > > > > be quite confusing. I am still not sure whether we should mix the two >

Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-16 Thread James Bottomley
On Thu, 2012-08-16 at 10:35 +0900, Chanho Min wrote: > > functions will occur in line. I also don't see why the sdev reference > > couldn't drop to zero here. > scsi_request_fn is called under the lock of request_queue->queue_lock. > If we drop the sdev reference to zero here, > scsi_device_dev_re

Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-16 Thread James Bottomley
On Thu, 2012-08-16 at 07:52 +, Bart Van Assche wrote: > On 08/16/12 01:35, Chanho Min wrote: > >> functions will occur in line. I also don't see why the sdev reference > >> couldn't drop to zero here. > > scsi_request_fn is called under the lock of request_queue->queue_lock. > > If we drop the

Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper

2012-08-16 Thread James Bottomley
On Thu, 2012-08-16 at 17:54 +0400, Cyrill Gorcunov wrote: > On Thu, Aug 16, 2012 at 02:50:19PM +0100, Al Viro wrote: > > On Thu, Aug 16, 2012 at 05:47:06PM +0400, Pavel Emelyanov wrote: > > > On 08/16/2012 05:43 PM, Al Viro wrote: > > > > On Thu, Aug 16, 2012 at 04:38:14PM +0400, Cyrill Gorcunov wr

Re: aic7xxx build failure

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 21:06 +0100, Sam Ravnborg wrote: > On Tue, Feb 05, 2008 at 07:47:35PM +0100, Sam Ravnborg wrote: > > On Tue, Feb 05, 2008 at 07:40:24PM +0200, Adrian Bunk wrote: > > > Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx > > > compilation: > > > > > > <-- snip -->

Re: [PATCH] enclosure: add support for enclosure services

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 11:33 -0800, Luben Tuikov wrote: > > Wrong ... we don't export non-SCSI devices as SCSI > > (with the single and > > rather annoying exception of ATA via SAT). > > I didn't say you should do that. I had already > mentioned that vendors export such controls > as either enclos

Re: [PATCH] enclosure: add support for enclosure services

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 16:12 -0800, Andrew Morton wrote: > On Sun, 03 Feb 2008 18:16:51 -0600 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > From: James Bottomley <[EMAIL PROTECTED]> > > Date: Sun, 3 Feb 2008 15:40:56 -0600 > > Subject: [SCSI]

Re: [PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE'

2008-02-06 Thread James Bottomley
On Mon, 2008-02-04 at 23:36 +0100, Roel Kluin wrote: > It should be like this I guess? this patch was not yet tested, please > confirm. > -- > Note the duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE' > > from Documentation/DMA-API.txt: > DMA_TO_DEVICE = PCI_DMA_TODEVICE

Re: [PATCH] sr: update to follow tray status correctly

2008-02-06 Thread James Bottomley
On Wed, 2008-02-06 at 17:09 +, Daniel Drake wrote: > Hi James, > > James Bottomley wrote: > > It's been a while with no status on this one, so I corrected the patch > > based on my original input. The attached is what I think is the best > > way of doing th

[GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-07 Thread James Bottomley
qla2xxx: Cleanup any outstanding SRB resources during shutdown. qla2xxx: Add MODULE_FIRMWARE hint for ISP25XX firmware. qla2xxx: Correct resource_size_t usages. Boaz Harrosh (1): arm: convert to accessors and !use_sg cleanup James Bottomley (10): ses: add new Enclosure

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-07 Thread James Bottomley
On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote: > On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote: > > Quite a bit of this is fixing things broken previously (the advansys fix > > is still pending resolution, but I'll send it as an -rc fix when we have &

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-07 Thread James Bottomley
On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote: > Quite a bit of this is fixing things broken previously (the advansys fix > is still pending resolution, but I'll send it as an -rc fix when we have > it). There's the final elimination of all drivers that are esp ba

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-07 Thread James Bottomley
On Thu, 2008-02-07 at 18:46 -0800, Andrew Morton wrote: > On Thu, 07 Feb 2008 18:56:46 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > > Quite a bit of this is fixing things broken previously (the advansys fix > > is still pending resolution, but I'll send

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 10:03 +0100, Geert Uytterhoeven wrote: > On Thu, 7 Feb 2008, James Bottomley wrote: > > On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote: > > > On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote: > > > > Quite a bit of this is f

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 15:32 +, Alan Cox wrote: > The word "illegal" has a precise dictionary meaning of "prohibited by > law". The error messages are therefore incorrect as so far nobody has > made SCSI violations a criminal offence. Um, I'm really reluctant to do this without an incredibly g

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 15:59 +, Alan Cox wrote: > > http://www.t10.org/ftp/t10/drafts/spc3/spc3r23.pdf > > > > By a simple text search. > > > > I don't think the pedantry is worth the confusion ... > > Ok so we should file a formal change request with T10 instead perhaps ? As long as that "w

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote: > +/* > + * Physical location of iSCSI Boot Format Table. This is now the Virtual address, isn't it? So just drop the Physical. > + */ > +unsigned long ibft_addr; > +EXPORT_SYMBOL(ibft_addr); And since it is the virtual address, there's

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote: > + ibft_device = kmalloc(len, GFP_KERNEL); > + if (!ibft_device) > + return -ENOMEM; > + > + memcpy(ibft_device, hdr, len); This piece looks a bit odd. you're making ibft_device an exact duplicate of ibft_

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote: > + if (hdr->id == id_nic) { > + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> 8, > + (nic->pci_bdf & 0xff)); > + if (pci_dev) { > +

Re: [PATCH] scsi: ses fix for len and mem leaking when fail to add intf

2008-02-09 Thread James Bottomley
On Sat, 2008-02-09 at 04:13 -0800, Yinghai Lu wrote: > [PATCH] scsi: ses fix for len and mem leaking when fail to add intf > > change to u32 before left shifting char This one is a bit unnecessary; C promotion rules guarantee that everything is promoted to int (or above) before doing arithmetic.

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread James Bottomley
th a tested-by tag? Thanks, James --- From: Boaz Harrosh <[EMAIL PROTECTED]> Date: Mon, 10 Sep 2007 22:39:11 +0300 Subject: [SCSI] fas216: Use scsi_eh API for REQUEST_SENSE invocation - Use new scsi_eh_prep/restor_cmnd() for synchronous REQUEST_SENSE invocation. Signed-off-by: Boaz H

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread James Bottomley
On Sun, 2008-02-10 at 22:02 +, Russell King wrote: > On Sun, Feb 10, 2008 at 08:20:24AM -0600, James Bottomley wrote: > > > > On Sun, 2008-02-10 at 13:58 +, Russell King wrote: > > > On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote:

efitools rpm up on opensuse build service: contains useful tools for taking control of UEFI secure boot platforms

2012-07-21 Thread James Bottomley
All the tools are in the git repository http://git.kernel.org/?p=linux/kernel/git/jejb/efitools.git;a=summary But for ease of consumption, this is now packaged and build by the opensuse build server as installable rpm files. http://download.opensuse.org/repositories/home:/jejb1:/UEFI/openSUSE_12

Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant

2012-07-23 Thread James Bottomley
[Parisc list cc added] On Mon, 2012-07-23 at 12:16 +0100, Mel Gorman wrote: > On Mon, Jul 23, 2012 at 12:30:58AM +0800, Fengguang Wu wrote: > > Hi Mel, > > > > To be frank, I don't quite understand this build failure.. > > > > tree: next/akpm akpm > > head: 37e2ad4953983527f7bdb6831bf478eedcc

[GIT PULL] First round of SCSI updates for the 3.5+ merge window

2012-07-23 Thread James Bottomley
fix eh wakeup (scsi_schedule_eh vs scsi_restart_operations) libata, libsas: introduce sched_eh and end_eh port ops fix hot unplug vs async scan race Eric Dumazet (1): bnx2fc: use kthread_create_on_node HighPoint Linux Team (1): hptiop: fix RR312x in hosts with >12GB James B

Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant

2012-07-24 Thread James Bottomley
nitialize the field enabled. A compound literal is not a constant expression. The location of the above statement isn't fully clear, but if a compound literal occurs outside the body of a function, the initializer list must consist of constant expressions. Reported-by: Fengguang Wu Signed-

Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-25 Thread James Bottomley
On Wed, 2012-07-25 at 09:45 +0200, Ingo Molnar wrote: > * Tony Luck wrote: > > > The stack_not_used() function in assumes that stacks > > grow downwards. This is not true on IA64 or PARISC, so this function > > would walk off in the wrong direction and into the weeds. > > > > Found on IA64 beca

Re: mptscsi: BUG: unable to handle kernel NULL pointer, in scsi_send_eh_cmnd

2012-07-10 Thread James Bottomley
On Tue, 2012-07-10 at 11:44 +0300, Meelis Roos wrote: > Resending with correct linux-scsi address - please rteply to this one if > you see duplicate messages. > > I am using Linux 3.4.0 with a 53c1030 and a tape library that sometimes > barfs for yet unknown reasons. When it happens, I get a BUG

Re: mptscsi: BUG: unable to handle kernel NULL pointer, in scsi_send_eh_cmnd

2012-07-10 Thread James Bottomley
On Tue, 2012-07-10 at 14:54 +0300, Meelis Roos wrote: > > > I am using Linux 3.4.0 with a 53c1030 and a tape library that sometimes > > > barfs for yet unknown reasons. When it happens, I get a BUG with > > > backtrace and this scsi channel is dead until I reboot. Seems to be > > > something wit

[GIT PULL] SCSI fixes for 3.5-rc6

2012-07-11 Thread James Bottomley
This is a set of three fixes for data corruption (libsas task file), oops causing (NULL in scsi_cmd_to_driver) and driver failure (bnx2i). The oops caused by the NULL in scsi_cmd_to_driver() manifests in scsi_eh_send_cmd() and has been seen by several people now. The patch is available here: git:

Organising Mini Summits within the Kernel Summit

2012-07-11 Thread James Bottomley
Hi All, We have set aside the second day of the kernel summit (Tuesday 28 August) as mini-summit day. So far we have only the PCI mini summit on this day, so if you can think of other topics, please send them to the kernel summit discuss list: ksummit-2012-disc...@lists.linux-foundation.org Loo

Re: [PATCH v4] virtio-scsi: hotplug support for virtio-scsi

2012-07-11 Thread James Bottomley
On Thu, 2012-07-05 at 11:19 +0200, Paolo Bonzini wrote: > Il 05/07/2012 11:06, Cong Meng ha scritto: > > This patch implements the hotplug support for virtio-scsi. > > When there is a device attached/detached, the virtio-scsi driver will be > > signaled via event virtual queue and it will add/remov

Re: [PATCH] mm: hugetlb: flush dcache before returning zeroed huge page to userspace

2012-07-12 Thread James Bottomley
On Thu, 2012-07-12 at 13:16 +0200, Michal Hocko wrote: > On Wed 11-07-12 18:48:02, Will Deacon wrote: > > On Tue, Jul 10, 2012 at 11:42:34AM +0100, Will Deacon wrote: > > > On Tue, Jul 10, 2012 at 10:45:13AM +0100, Will Deacon wrote: > > > > On Tue, Jul 10, 2012 at 12:57:14AM +0100, Hugh Dickins wr

Re: [PATCH 1/5] aio: Export symbols and struct kiocb_batch for in kernel aio usage

2012-07-12 Thread James Bottomley
On Thu, 2012-07-12 at 23:35 +0800, Asias He wrote: > This is useful for people who want to use aio in kernel, e.g. vhost-blk. > > Signed-off-by: Asias He > --- > fs/aio.c| 37 ++--- > include/linux/aio.h | 21 + > 2 files change

Re: [Linux-c6x-dev] [PATCH 3/9] c6x: Provide dma_mmap_coherent() and dma_get_sgtable()

2013-01-21 Thread James Bottomley
On Mon, 2013-01-21 at 21:00 +0100, Geert Uytterhoeven wrote: > On Tue, Jan 15, 2013 at 5:56 PM, James Bottomley > wrote: > > On Tue, 2013-01-15 at 15:07 +0100, Marek Szyprowski wrote: > >> On 1/15/2013 10:13 AM, Geert Uytterhoeven wrote: > >> > Marek? > >>

Re: [Linux-c6x-dev] [PATCH 3/9] c6x: Provide dma_mmap_coherent() and dma_get_sgtable()

2013-01-22 Thread James Bottomley
On Mon, 2013-01-21 at 22:59 +, James Bottomley wrote: > On Mon, 2013-01-21 at 21:00 +0100, Geert Uytterhoeven wrote: > > On Tue, Jan 15, 2013 at 5:56 PM, James Bottomley > > wrote: > > > On Tue, 2013-01-15 at 15:07 +0100, Marek Szyprowski wrote: > > &

Re: [Linux-c6x-dev] [PATCH 3/9] c6x: Provide dma_mmap_coherent() and dma_get_sgtable()

2013-01-22 Thread James Bottomley
[adding Mauro and v4l since they're the only non-arm consumers] On Tue, 2013-01-22 at 10:13 +0000, James Bottomley wrote: > On Mon, 2013-01-21 at 22:59 +0000, James Bottomley wrote: > > On Mon, 2013-01-21 at 21:00 +0100, Geert Uytterhoeven wrote: > > > On Tue, Jan 15,

Re: [Linux-c6x-dev] [PATCH 3/9] c6x: Provide dma_mmap_coherent() and dma_get_sgtable()

2013-01-22 Thread James Bottomley
On Tue, 2013-01-22 at 11:15 +0100, Marek Szyprowski wrote: > Hello, > > On 1/15/2013 5:56 PM, James Bottomley wrote: > > On Tue, 2013-01-15 at 15:07 +0100, Marek Szyprowski wrote: > > > Hello, > > > > > > On 1/15/2013 10:13 AM, Geert Uytterhoeven wrote:

Re: [Linux-c6x-dev] [PATCH 3/9] c6x: Provide dma_mmap_coherent() and dma_get_sgtable()

2013-01-22 Thread James Bottomley
On Tue, 2013-01-22 at 10:16 +, James Bottomley wrote: > [adding Mauro and v4l since they're the only non-arm consumers] > On Tue, 2013-01-22 at 10:13 +0000, James Bottomley wrote: > > On Mon, 2013-01-21 at 22:59 +, James Bottomley wrote: > > > On Mon, 2013-0

Re: [Linux-c6x-dev] [PATCH 3/9] c6x: Provide dma_mmap_coherent() and dma_get_sgtable()

2013-01-22 Thread James Bottomley
On Tue, 2013-01-22 at 11:33 +0100, Marek Szyprowski wrote: > Hello, > > On 1/22/2013 11:13 AM, James Bottomley wrote: > > On Mon, 2013-01-21 at 22:59 +, James Bottomley wrote: > > > On Mon, 2013-01-21 at 21:00 +0100, Geert Uytterhoeven wrote: > > > > On

Re: [Linux-c6x-dev] [PATCH 3/9] c6x: Provide dma_mmap_coherent() and dma_get_sgtable()

2013-01-23 Thread James Bottomley
On Wed, 2013-01-23 at 12:53 +0530, Vineet Gupta wrote: > On Tuesday 22 January 2013 03:52 PM, James Bottomley wrote: > > On Tue, 2013-01-22 at 11:15 +0100, Marek Szyprowski wrote: > >> Hello, > >> > >> On 1/15/2013 5:56 PM, James Bottomley wrote: > >&

Re: [Linux-c6x-dev] [PATCH 3/9] c6x: Provide dma_mmap_coherent() and dma_get_sgtable()

2013-01-23 Thread James Bottomley
On Wed, 2013-01-23 at 10:47 +0100, Marek Szyprowski wrote: > On 1/22/2013 11:13 AM, James Bottomley wrote: > > There might be a simple solution: just replace void *cpu_addr with void > > **cpu_addr in the API. This is a bit nasty since compilers think that > > void ** to

[GIT PULL] parisc fixes for 3.8-rc7

2013-02-12 Thread James Bottomley
This is a couple of patches, one to fix a broken build with HPUX compatibility and the other to solve a coherency problem we've been seeing in our TLB where setting a page read only occasionally fails to trigger a COW because of a stale writeable TLB entry. The patches are here: git://git.kernel.

Re: [RESEND PATCH] scsi: make struct scsi_varlen_cdb_hdr packed

2012-10-11 Thread James Bottomley
On Thu, 2012-10-11 at 10:15 +0100, James Hogan wrote: > The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when > used in struct osd_cdb_head, but it isn't marked as packed. Some > architectures will round the struct size up which triggers BUILD_BUG_ON > compile errors in osd_initiat

Re: [RESEND PATCH] scsi: make struct scsi_varlen_cdb_hdr packed

2012-10-11 Thread James Bottomley
On Thu, 2012-10-11 at 12:32 +0100, James Hogan wrote: > On 11/10/12 11:24, James Bottomley wrote: > > On Thu, 2012-10-11 at 10:15 +0100, James Hogan wrote: > >> The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when > >> used in struct osd_cdb_head, bu

[GIT PULL] Final round of SCSI updates for the 3.6+ merge window

2012-10-12 Thread James Bottomley
This is an assorted set of stragglers into the merge window with driver updates for megaraid_sas, lpfc, bfi and mvumi. It also includes some fairly major fixes for virtio-scsi (scatterlist init), scsi_debug (off by one error), storvsc (use after free) and qla2xxx (potential deadlock). The patch is

<    1   2   3   4   5   6   7   8   9   10   >