Re: [PATCH] scsi: prevent stack buffer overflow in host_reset

2012-11-30 Thread James Bottomley
On Thu, 2012-11-15 at 15:51 -0500, Sasha Levin wrote: > diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c > index ce5224c..77ba946 100644 > --- a/drivers/scsi/scsi_sysfs.c > +++ b/drivers/scsi/scsi_sysfs.c > @@ -249,9 +249,9 @@ static DEVICE_ATTR(active_mode, S_IRUGO | S_IWUSR, >

Re: [PATCH 5/5] arcmsr: Modify ARC-1214 IO Behavior

2012-11-30 Thread James Bottomley
On Fri, 2012-11-16 at 19:56 +0800, NickCheng wrote: > From: Nick Cheng > > Modify ARC-1214 IO behavior to make up for HW seldom malfunction. > Signed-off-by: Nick Cheng This still isn't right. I said you could ignore most of the warnings (like lines over 80 characters), but you have a lot of t

[PATCH] x86/efi: pull NV+BS variables out before we exit boot services

2013-03-18 Thread James Bottomley
From: James Bottomley The object here is to make the NV+BS variables accessible (at least read only) at runtime so we can get a full picture of the state of the EFI variables for debugging and secure boot purposes. The way this is done is to get the efi stub to pull all the NV+BS (i.e

Re: [PATCH] [SCSI]: print the msgbytes and statusbyte from scsi result

2013-03-18 Thread James Bottomley
On Sun, 2013-03-17 at 17:29 +0900, Namjae Jeon wrote: > From: Namjae Jeon > > Introduce msgbyte and statusbyte in the prints as part of the > result which is returned by the lower layer driver in response to > SCSI command issued, in case of any error conditions. > > Purpose of adding these prin

Re: [PATCH] x86/efi: pull NV+BS variables out before we exit boot services

2013-03-19 Thread James Bottomley
On Tue, 2013-03-19 at 01:48 +, Matthew Garrett wrote: > On Mon, Mar 18, 2013 at 08:40:14AM +0000, James Bottomley wrote: > > > The object here is to make the NV+BS variables accessible (at least read > > only) > > at runtime so we can get a full picture of the st

Re: [PATCH V5 1/5] virtio-scsi: redo allocation of target data

2013-03-19 Thread James Bottomley
On Tue, 2013-03-19 at 17:57 +0800, Wanlong Gao wrote: > From: Paolo Bonzini > > virtio_scsi_target_state is now empty. We will find new uses for it in > the next few patches, so this patch does not drop it completely. > However, having dropped the sglist flexible array member, we can turn > the

Re: [PATCH V5 1/5] virtio-scsi: redo allocation of target data

2013-03-19 Thread James Bottomley
On Tue, 2013-03-19 at 12:45 +0100, Paolo Bonzini wrote: > Il 19/03/2013 12:32, James Bottomley ha scritto: > > On Tue, 2013-03-19 at 17:57 +0800, Wanlong Gao wrote: > >> From: Paolo Bonzini > >> > >> virtio_scsi_target_state is now empty. We will find new uses

Re: [PATCH] x86/efi: pull NV+BS variables out before we exit boot services

2013-03-19 Thread James Bottomley
On Tue, 2013-03-19 at 16:35 +, Matthew Garrett wrote: > On Tue, Mar 19, 2013 at 08:14:45AM +0000, James Bottomley wrote: > > > Any security assumptions that rely on inability to read certain > > information aren't really going to be that secure. Inability to modify,

Re: [PATCH] x86/efi: pull NV+BS variables out before we exit boot services

2013-03-19 Thread James Bottomley
On Tue, 2013-03-19 at 17:25 +, Matthew Garrett wrote: > On Tue, Mar 19, 2013 at 05:17:27PM +0000, James Bottomley wrote: > > On Tue, 2013-03-19 at 16:35 +, Matthew Garrett wrote: > > > On Tue, Mar 19, 2013 at 08:14:45AM +0000, James Bottomley wrote: > > > >

Re: [PATCH] x86/efi: pull NV+BS variables out before we exit boot services

2013-03-19 Thread James Bottomley
On Tue, 2013-03-19 at 18:28 +, Matthew Garrett wrote: > On Tue, Mar 19, 2013 at 06:23:31PM +0000, James Bottomley wrote: > > > The scheme we discussed, unless something radically changed, was to > > convey a temporary key pair via a mechanism to later verify the > &g

Re: [PATCH] x86/efi: pull NV+BS variables out before we exit boot services

2013-03-19 Thread James Bottomley
On Tue, 2013-03-19 at 18:50 +, Matthew Garrett wrote: > On Tue, Mar 19, 2013 at 06:40:56PM +0000, James Bottomley wrote: > > On Tue, 2013-03-19 at 18:28 +, Matthew Garrett wrote: > > > It requires the key to survive the system being entirely powered down, > > >

Re: [PATCH] x86/efi: pull NV+BS variables out before we exit boot services

2013-03-20 Thread James Bottomley
On Tue, 2013-03-19 at 23:17 +, Matthew Garrett wrote: > On Tue, Mar 19, 2013 at 11:00:31PM +0000, James Bottomley wrote: > > On Tue, 2013-03-19 at 18:50 +, Matthew Garrett wrote: > > > Well, that somewhat complicates implementation - we'd be encrypting the > >

Re: [PATCH RESEND 1/1] arch Kconfig: remove references to IRQ_PER_CPU

2013-02-04 Thread James Bottomley
On Mon, 2013-02-04 at 10:09 +, James Hogan wrote: > The IRQ_PER_CPU Kconfig symbol was removed in the following commit: > > Commit 6a58fb3bad099076f36f0f30f44507bc3275cdb6 ("genirq: Remove > CONFIG_IRQ_PER_CPU") merged in v2.6.39-rc1. > > But IRQ_PER_CPU wasn't removed from any of the archite

Re: scanning for LUNs

2013-04-04 Thread James Bottomley
On Thu, 2013-04-04 at 08:12 -0700, K. Y. Srinivasan wrote: > Here is the code snippet for scanning LUNS (drivers/scsi/scsi_scan.c in > function > __scsi_scan_target()): > > /* > * Scan LUN 0, if there is some response, scan further. Ideally, we > * would not configure L

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread James Bottomley
On Fri, 2013-04-05 at 14:30 +1030, Rusty Russell wrote: > Sebastian Wankerl writes: > > On 04/04/13 03:00, Rusty Russell wrote: > >> Sebastian Wankerl writes: > >>> Add non-zero module sections to sysfs on architectures unequal to PARISC. > >>> KGDB needs all module sections for proper module deb

Re: [PATCH] parisc: unbreak automounter support on 64-bit kernel with 32-bit userspace

2013-01-31 Thread James Bottomley
[adding autofs list and maintainer for their perusal and ack, although this is an obvious fix to me James] On Thu, 2013-01-31 at 21:01 +0100, Helge Deller wrote: > Similiar to other 64 bit Linux targets autofs_wqt_t needs to be of type int > which has a size of 32 bits on 32- and 64-bit parisc ker

Re: [PATCH] parisc: unbreak automounter support on 64-bit kernel with 32-bit userspace

2013-01-31 Thread James Bottomley
On Thu, 2013-01-31 at 13:29 -0800, H. Peter Anvin wrote: > On 01/31/2013 12:26 PM, James Bottomley wrote: > > [adding autofs list and maintainer for their perusal and ack, although > > this is an obvious fix to me > > > > James] > > The #if list probably shou

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-01-31 Thread James Bottomley
On Thu, 2013-01-31 at 14:02 -0800, dbasehore . wrote: > (Resending message as plain text so it's tracked through vger lists) Just FYI ... I don't get messages sent to me personally and the list, so if it wasn't on vger, I haven't seen it. > I didn't notice the other call to async_synchronize_full

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-01-31 Thread James Bottomley
On Thu, 2013-01-31 at 14:00 -0800, dbasehore . wrote: > (Resending as plain text so the message is tracked on vger) > > Hi, thanks for reading through my patch. > > With regards to SCSI_SENSE_BUFFERSIZE, I'm following the precedent of > scsi_execute_req found in drivers/scsi/scsi_lib.c I have no

Re: [PATCH 1/8] mm: use vm_unmapped_area() on parisc architecture

2013-01-24 Thread James Bottomley
On Wed, 2013-01-23 at 17:29 -0800, Michel Lespinasse wrote: > Update the parisc arch_get_unmapped_area function to make use of > vm_unmapped_area() instead of implementing a brute force search. > > Signed-off-by: Michel Lespinasse > Acked-by: Rik van Riel > > --- > arch/parisc/kernel/sys_paris

Re: [Linux-c6x-dev] [PATCH 3/9] c6x: Provide dma_mmap_coherent() and dma_get_sgtable()

2013-01-24 Thread James Bottomley
On Wed, 2013-01-23 at 18:44 +0100, Marek Szyprowski wrote: > On 1/23/2013 11:29 AM, James Bottomley wrote: > > On Wed, 2013-01-23 at 10:47 +0100, Marek Szyprowski wrote: > > > On 1/22/2013 11:13 AM, James Bottomley wrote: > > > > There might be a simple solution: ju

Re: [git pull] signal.git

2013-02-24 Thread James Bottomley
On Sat, 2013-02-23 at 18:56 -0800, Linus Torvalds wrote: > Ok, in the meantime I had merged the parisc and powerpc trees, which > had their own fixes in this area: powerpc added the transactional > memory support for power8 (which impacted signal save/restore), and > parisc had some fixes to the ro

Re: [PATCH] [SCSI] aacraid: silence two GCC warnings

2013-02-20 Thread James Bottomley
On Sat, 2013-02-09 at 21:09 +0100, Paul Bolle wrote: > Compiling src.o for a 32 bit system triggers two GCC warnings: > drivers/scsi/aacraid/src.c: In function ‘aac_src_deliver_message’: > drivers/scsi/aacraid/src.c:410:3: warning: right shift count >= width of > type [enabled by default]

[GIT PULL] First round of SCSI updates for the 3.8+ merge window

2013-02-22 Thread James Bottomley
This is the first round, consisting mostly of drivers and patches submitted 3 weeks ago. Since I've been travelling quite a bit, there will be a second round just before the merge window closes for all the patches three weeks or newer (that includes the FCoE tree). The patch set is mostly driver

Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

2013-03-15 Thread James Bottomley
On Fri, 2013-03-15 at 05:13 +, Al Viro wrote: > On Fri, Mar 15, 2013 at 02:09:14PM +0900, J. R. Okajima wrote: > > > If so, it has a big disadvantage for the layer-fs (or branch-fs) to have > > to implement a new method for whiteout. > > > > Overlayfs implements whiteout as symlink+xattr whic

Results of the Linux Foundation TAB election

2012-08-30 Thread James Bottomley
As a result of the election at Bali Hai, The five new members of the TAB elected to two year terms are: Chris Mason James Bottomley John W. Linville Ric Wheeler Jesse Barnes James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[GIT PULL] parisc fixes for 3.4-rc1

2012-08-31 Thread James Bottomley
This is a set of two bug fixes. One is the ATOMIC problem which is now causing a compile failure in certain situations. The other is mishandling of PER_LINUX32 which may also cause user visible effects. The patches are here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/parisc-2.6.git pari

[GIT PULL] parisc fixes for 3.6-rc3

2012-08-31 Thread James Bottomley
This is a set of two bug fixes. One is the ATOMIC problem which is now causing a compile failure in certain situations. The other is mishandling of PER_LINUX32 which may also cause user visible effects. The patches are here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/parisc-2.6.git pari

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-12 Thread James Bottomley
On Tue, 2012-09-11 at 19:56 +0200, Paolo Bonzini wrote: > The set of use cases is so variable that no single filter can accomodate > all of them: high availability people want persistent reservations, NAS > people want trim/discard, but these are just two groups. Someone is > using a Windows VM to

Re: [2.6 patch] scsi/qlogicpti.c section fixes

2008-01-30 Thread James Bottomley
On Wed, 2008-01-30 at 22:03 +0200, Adrian Bunk wrote: > This patch fixes the following section mismatches: > > <-- snip --> > > ... > WARNING: drivers/scsi/qlogicpti.o(.devexit.text+0x8): Section mismatch in > reference from the function qpti_sbus_remove() to the function > .init.text:qpti_c

Re: [2.6 patch] scsi/qlogicpti.c section fixes

2008-01-30 Thread James Bottomley
On Wed, 2008-01-30 at 22:20 +0100, Sam Ravnborg wrote: > On Wed, Jan 30, 2008 at 03:00:16PM -0600, James Bottomley wrote: > > > > On Wed, 2008-01-30 at 22:03 +0200, Adrian Bunk wrote: > > > This patch fixes the following section mismatches

[GIT PATCH] intermediate SCSI update for 2.6.24

2008-01-30 Thread James Bottomley
ic79xx: fix sense_buffer access bug hptiop: fix sense_buffer access bug James Bottomley (3): Revert "[SCSI] aacraid: fib context lock for management ioctls" bsg: copy the cmd_type field to the subordinate request for bidi remove use_sg_chaining Kiyoshi Ueda (1):

Re: Value of __*{init,exit} anotations?

2008-01-30 Thread James Bottomley
On Thu, 2008-01-31 at 00:32 +0200, Adrian Bunk wrote: > On Wed, Jan 30, 2008 at 03:41:35PM -0600, James Bottomley wrote: > > On Wed, 2008-01-30 at 22:20 +0100, Sam Ravnborg wrote: > > > On Wed, Jan 30, 2008 at 03:00:16PM -0600, James Bottomley wrote: > >... > > >

[PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread James Bottomley
No-one seems to see much value in these, and they cause about 90% of our problems with __init/__exit markers, so simply eliminate them. Rather than run over the whole tree removing them, this patch #defines them to be nops. Signed-off-by: James Bottomley <[EMAIL PROTECTED]> --- I'

Re: Are Section mismatches out of control?

2008-02-01 Thread James Bottomley
On Fri, 2008-02-01 at 03:03 -0800, Andrew Morton wrote: > On Fri, 1 Feb 2008 11:47:18 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > James said in a related posting that the Section mismatch > > warnings were getting out of control. > > eh. They're easy - the build system tells you about th

Re: Are Section mismatches out of control?

2008-02-01 Thread James Bottomley
On Fri, 2008-02-01 at 11:47 +0100, Sam Ravnborg wrote: > James said in a related posting that the Section mismatch > warnings were getting out of control. What I actually said was that the churn in the source base caused by these sectional mismatches was getting out of hand. What I questioned was

Re: Are Section mismatches out of control?

2008-02-01 Thread James Bottomley
On Fri, 2008-02-01 at 22:47 +0100, Jan Engelhardt wrote: > On Feb 1 2008 03:21, Harvey Harrison wrote: > >> > >> Question is: why do people keep adding new ones when they are so easy to > >> detect and fix? > >> > >> Asnwer: because neither they nor their patch integrators are doing adequate > >

Re: [PATCH] Add iSCSI iBFT support (v0.4.6)

2008-02-01 Thread James Bottomley
On Wed, 2008-01-30 at 17:37 -0400, Konrad Rzeszutek wrote: > This patch (v0.4.6) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] > directories along with text properties which export the the iSCSI > Boot Firmware Table (iBFT) structure. > > What is iSCSI Boot Firmware Table? It is a mechan

Re: [patch] pci: pci_enable_device_bars() fix

2008-02-02 Thread James Bottomley
On Sat, 2008-02-02 at 10:51 -0500, Jeff Garzik wrote: > Ingo Molnar wrote: > > === > > --- linux.orig/drivers/scsi/lpfc/lpfc_init.c > > +++ linux/drivers/scsi/lpfc/lpfc_init.c > > @@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_de

Re: [patch] pci: pci_enable_device_bars() fix

2008-02-02 Thread James Bottomley
On Sat, 2008-02-02 at 18:08 +0100, Ingo Molnar wrote: > * Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > Ingo Molnar wrote: > >> === > >> --- linux.orig/drivers/scsi/lpfc/lpfc_init.c > >> +++ linux/drivers/scsi/lpfc/lpfc_init.c > >> @@

Re: [patch] scsi: fix spurious build failures in aic7xxx

2008-02-03 Thread James Bottomley
On Sun, 2008-02-03 at 02:41 -0500, Sam Ravnborg wrote: > Thanks for testing Ingo. > > James - I plan to submit this via kbuild.git in about 10 > hours. > Let me know if you would like it to go in via scsi and I > will drop you an updated patch (need

Re: [patch] scsi: fix spurious build failures in aic7xxx

2008-02-03 Thread James Bottomley
On Sun, 2008-02-03 at 21:05 +0100, Sam Ravnborg wrote: > On Sun, Feb 03, 2008 at 01:23:42PM -0600, James Bottomley wrote: > > On Sun, 2008-02-03 at 02:41 -0500, Sam Ravnborg wrote: > > > Thanks for testing Ingo. > > > > > > James - I p

Re: [patch] scsi: fix spurious build failures in aic7xxx

2008-02-03 Thread James Bottomley
On Sun, 2008-02-03 at 21:38 +0100, Sam Ravnborg wrote: > > > > > drivers/base/attribute_container.c: * Copyright (c) 2005 - James > > > Bottomley <[EMAIL PROTECTED]> > > > drivers/base/transport_class.c: * Copyright (c) 2005 - James Bottomley >

[PATCH] enclosure: add support for enclosure services

2008-02-03 Thread James Bottomley
The enclosure misc device is really just a library providing sysfs support for physical enclosure devices and their components. Signed-off-by: James Bottomley <[EMAIL PROTECTED]> --- See the additional ses patch for SCSI enclosure services users of this. --- drivers/misc/Kconfig

[PATCH] ses: add new Enclosure ULD

2008-02-03 Thread James Bottomley
t libata where the SAT resides. Signed-off-by: James Bottomley <[EMAIL PROTECTED]> --- drivers/scsi/Kconfig | 10 +- drivers/scsi/Makefile |1 + drivers/scsi/ses.c| 684 + 3 files changed, 694 insertions(+), 1 deletions(-) create mode 1

Re: [PATCH] enclosure: add support for enclosure services

2008-02-03 Thread James Bottomley
losure_component * > > +enclosure_component_register(struct enclosure_device *edev, > > +unsigned int number, > > + enum enclosure_component_type type, > > +const char *name) > > +{ > Missing kernel-doc for this and the

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 15:27 +0300, Vladislav Bolkhovitin wrote: > Vladislav Bolkhovitin wrote: > So, James, what is your opinion on the above? Or the overall SCSI target > project simplicity doesn't matter much for you and you think it's fine > to duplicate Linux page cache in the user space to k

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 21:38 +0300, Vladislav Bolkhovitin wrote: > James Bottomley wrote: > > On Mon, 2008-02-04 at 20:56 +0300, Vladislav Bolkhovitin wrote: > > > >>James Bottomley wrote: > >> > >>>On Mon, 2008-02-04 at 20:16 +0300, Vladislav Bolkhov

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 20:16 +0300, Vladislav Bolkhovitin wrote: > James Bottomley wrote: > >>>>So, James, what is your opinion on the above? Or the overall SCSI target > >>>>project simplicity doesn't matter much for you and you think it's fine >

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 20:56 +0300, Vladislav Bolkhovitin wrote: > James Bottomley wrote: > > On Mon, 2008-02-04 at 20:16 +0300, Vladislav Bolkhovitin wrote: > > > >>James Bottomley wrote: > >> > >>>>>>So, James, what is your opi

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 19:25 +0300, Vladislav Bolkhovitin wrote: > James Bottomley wrote: > >>Vladislav Bolkhovitin wrote: > >>So, James, what is your opinion on the above? Or the overall SCSI target > >>project simplicity doesn't matter much for you and yo

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 10:29 -0800, Linus Torvalds wrote: > > On Mon, 4 Feb 2008, James Bottomley wrote: > > > > The way a user space solution should work is to schedule mmapped I/O > > from the backing store and then send this mmapped region off for target > > I/

Re: [rfc] direct IO submission and completion scalability issues

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 05:33 -0500, Jens Axboe wrote: > As Andi mentions, we can look into making that lockless. For the initial > implementation I didn't really care, just wanted something to play with > that would nicely allow me to control both the submit and complete side > of the affinity issue

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 22:43 +, Alan Cox wrote: > > better. So for example, I personally suspect that ATA-over-ethernet is way > > better than some crazy SCSI-over-TCP crap, but I'm biased for simple and > > low-level, and against those crazy SCSI people to begin with. > > Current ATAoE isn'

Re: [PATCH] enclosure: add support for enclosure services

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 16:32 -0800, Luben Tuikov wrote: > --- On Sun, 2/3/08, James Bottomley <[EMAIL PROTECTED]> wrote: > > > The enclosure misc device is really just a library providing > > sysfs > > support for physical enclosure devices and their > > compone

Re: [PATCH] enclosure: add support for enclosure services

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 18:01 -0800, Luben Tuikov wrote: > --- On Mon, 2/4/08, James Bottomley <[EMAIL PROTECTED]> wrote: > > > > The enclosure misc device is really just a > > library providing > > > > sysfs > > > > support for phys

Re: [PATCH] enclosure: add support for enclosure services

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 19:28 -0800, Luben Tuikov wrote: > --- On Mon, 2/4/08, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Mon, 2008-02-04 at 18:01 -0800, Luben Tuikov wrote: > > > --- On Mon, 2/4/08, James Bottomley > > <[EMAIL PROTECTED]> wrote: >

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Tue, 2008-02-05 at 05:43 +0100, Matteo Tescione wrote: > Hi all, > And sorry for intrusion, i am not a developer but i work everyday with iscsi > and i found it fantastic. > Altough Aoe, Fcoe and so on could be better, we have to look in real world > implementations what is needed *now*, and if

Re: [PATCH] enclosure: add support for enclosure services

2008-02-05 Thread James Bottomley
On Mon, 2008-02-04 at 21:35 -0800, Luben Tuikov wrote: > > > I guess the same could be said for STGT and SCST, > > right? > > > > You mean both of their kernel pieces are modular? > > That's correct. > > No, you know very well what I mean. > > By the same logic you're preaching to include your

Re: aic7xxx build failure

2008-02-05 Thread James Bottomley
.h files so make knows all dependencies and finsih the build of the .h files before it starts building the .o files. Ingo tested this fix and reported: good news: hundreds of successful kernel builds and no failures overnight. Signed-off-by: Sam Ravnborg <[EMAIL PR

Re: aic7xxx build failure

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 19:40 +0200, Adrian Bunk wrote: > Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx > compilation: > > <-- snip --> > > $ make O=../out/x86-full > ... > SHIPPED drivers/scsi/aic7xxx/aic79xx_seq.h > SHIPPED drivers/scsi/aic7xxx/aic79xx_reg.h > CC dr

Re: aic7xxx build failure

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 20:24 +0200, Adrian Bunk wrote: > On Tue, Feb 05, 2008 at 12:18:04PM -0600, James Bottomley wrote: > > > > On Tue, 2008-02-05 at 19:40 +0200, Adrian Bunk wrote: > > > Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx > > > co

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread James Bottomley
Cc: Andrew Morton <[EMAIL PROTECTED]>, Alan Cox <[EMAIL PROTECTED]>, Bart Van Assche <[EMAIL PROTECTED]>, FUJITA Tomonori <[EMAIL PROTECTED]>, James Bottomley <[EMAIL PROTECTED]>, ... Subject: Re: Int

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 21:59 +0300, Vladislav Bolkhovitin wrote: > >>Hmm, how can one write to an mmaped page and don't touch it? > > > > I meant from user space ... the writes are done inside the kernel. > > Sure, the mmap() approach agreed to be unpractical, but could you > elaborate more on th

[GIT PULL] First round of SCSI updates for the 3.6+ merge window

2012-10-02 Thread James Bottomley
This is a large set of updates, mostly for drivers (qla2xxx [including support for new 83xx based card], qla4xxx, mpt2sas, bfa, zfcp, hpsa, be2iscsi, isci, lpfc, ipr, ibmvfc, ibmvscsi, megaraid_sas). There's also a rework for tape adding virtually unlimited numbers of tape drives plus a set of dif

Re: [PATCH 0/2] virtio-scsi fixes for 3.6

2012-10-02 Thread James Bottomley
On Mon, 2012-10-01 at 15:11 +0200, Paolo Bonzini wrote: > Il 26/07/2012 15:28, Paolo Bonzini ha scritto: > > James, > > > > patch 1 fixes scanning of LUNs whose number is greater than 255. QEMU > > passes a max_lun of 16383 (because it uses SAM numbering) but in Linux > > it must become 32768 (be

Re: [PATCH 1/5] SCSI: Re-name the HBA Type

2012-10-03 Thread James Bottomley
On Wed, 2012-10-03 at 20:14 +0800, NickCheng wrote: > From: Nick Cheng > > Replace the nameing, hba, hbb and hbc, with hbaA, hbaB abd hbaC respectively > Signed-off-by: Nick Cheng< nick.ch...@areca.com.tw > Please send these to the SCSI mailing list: linux-s...@vger.kernel.org With a proper sub

Re: [Bug 48241] New: oops when setting up LVM

2012-10-03 Thread James Bottomley
On Wed, 2012-10-03 at 15:04 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=48241 > >Summary: oops when setting up LVM >Product: IO/Storage >Version: 2.5 > Kernel Version: 3.6.0-next-20121003 > Platfo

Re: [GIT PULL] Disintegrate UAPI for parisc

2012-10-05 Thread James Bottomley
On Thu, 2012-10-04 at 20:51 +0100, David Howells wrote: > Can you merge the following branch into the parisc tree please. Just to confirm: this is for testing purposes only ... you'll be sending the pull requests to Linus? Because otherwise I'll need a signed pull request from you. I should be a

Re: Drivers: scsi

2012-10-24 Thread James Bottomley
On Wed, 2012-10-24 at 09:25 -0700, K. Y. Srinivasan wrote: > When the low level driver returns SCSI_MLQUEUE_DEVICE_BUSY, > how is the command retried; I suspect the retry is done after some delay. Delay depends mainly on I/O pressure and the unplug timer in the block layer. > Is this delay progra

Re: [SCSI] ses: fix memory leaks

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 10:23 -0600, James Bottomley wrote: > On Sun, 2008-02-10 at 23:25 -0800, Yinghai Lu wrote: > > please check it... > > This one looks perfect, thanks! Well, nearly perfect. I corrected this typo: + if (!buf) + goto

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 09:42 -0700, Matthew Wilcox wrote: > On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote: > > duplicate pa11_dma_alloc_consistent; more appropriate appears > > pa11_dma_alloc_noncoherent here. > > > > Not tested, please confirm that this fix is correct > > I don't t

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote: > duplicate pa11_dma_alloc_consistent; more appropriate appears > pa11_dma_alloc_noncoherent here. > > Not tested, please confirm that this fix is correct No, it looks completely incorrect to me. What makes you think a pcxl box has a problem

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 13:13 -0800, Harvey Harrison wrote: > On Fri, 2008-02-08 at 10:37 -0600, James Bottomley wrote: > > On Fri, 2008-02-08 at 10:03 +0100, Geert Uytterhoeven wrote: > > > On Thu, 7 Feb 2008, James Bottomley wrote: > > > > On Thu, 2008-02-07 at 17:0

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-11 Thread James Bottomley
On Tue, 2008-02-12 at 12:02 +1100, Stephen Rothwell wrote: > Hi all, > > Andrew was looking for someone to run a linux-next tree that just > contained the subsystem git and quilt trees for 2.6.x+1 and I (in a > moment of madness) volunteered. So, this is to announce the creating of > such a tree

Re: [SCSI] ses: fix memory leaks

2008-02-11 Thread James Bottomley
On Sun, 2008-02-10 at 23:25 -0800, Yinghai Lu wrote: > please check it... This one looks perfect, thanks! James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH] scsi: ses fix mem leaking when fail to add intf

2008-02-10 Thread James Bottomley
PROTECTED]> Signed-off-by: James Bottomley <[EMAIL PROTECTED]> --- drivers/scsi/ses.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c index 2a6e4f4..8abc4a9 100644 --- a/drivers/scsi/ses.c +++ b/dr

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-11 Thread James Bottomley
On Tue, 2008-02-12 at 13:23 +1100, Stephen Rothwell wrote: > Hi James, > > On Mon, 11 Feb 2008 19:36:49 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > > > On Tue, 2008-02-12 at 12:02 +1100, Stephen Rothwell wrote: > > > > > > Andrew was look

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 10:00 -0800, Linus Torvalds wrote: > > On Tue, 12 Feb 2008, James Bottomley wrote: > > > > On Tue, 2008-02-12 at 09:09 -0800, Linus Torvalds wrote: > > > (a) create a base tree with _just_ that fundamental infrastructure > > > change

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 10:48 -0800, Linus Torvalds wrote: > But you're all ignoring my fundamental objection: you're talking as if > cross-tree fundamental API changes should be the "norm", and that we > should try to solve the workflow issues that stem from that. And I'm > saying that I think we

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote: > reposting an updated version of it. Please check if it's ok. Looks fine, thanks! You added an extra space at the end of while ((pdev = pci_get_device(vendor, device, pdev)) Which I fixed. Unfortunately checkpatch isn't very helpful for

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 18:35 -0800, Linus Torvalds wrote: > > On Tue, 12 Feb 2008, James Bottomley wrote: > > > > Yes, this is exactly the feature I'm looking for. It would allow the > > downstream users of a rebased tree to rebase themselves correctly. > >

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 19:31 -0800, Linus Torvalds wrote: > > On Tue, 12 Feb 2008, James Bottomley wrote: > > > > Right at the moment, I maintain a and a -base and > > simply cherry pick the commits between the two to do the right thing > > when I know my volatile

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote: > I understand what you are trying to do - I guess I just doubt the value > you've added by doing this. I think that there's going to be so much > customization that system vendors will want to add, that they are going > to wind up

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 10:22 -0800, Kristen Carlson Accardi wrote: > I apologize for taking so long to review this patch. I obviously agree > wholeheartedly with Luben. The problem I ran into while trying to > design an enclosure management interface for the SATA devices is that > there is all thi

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 17:20 -0800, David Miller wrote: > What would be really cool is if you could do the rebase thing, push > that to a remote tree you were already pushing into and others could > pull from that and all the right things happen. > > A rebase is just a series of events, and those c

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 09:09 -0800, Linus Torvalds wrote: > (a) create a base tree with _just_ that fundamental infrastructure change, > and make sure that base branch is so obviously good that there is no > question about merging it. The problem is how do we use a? Usually we need to

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 11:36 -0500, Jeff Garzik wrote: > David Miller wrote: > > This is why, with the networking, we've just tossed all of the network > > driver stuff in there too. I can rebase freely, remove changesets, > > rework them, etc. and this causes a very low amount of pain for Jeff > >

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 17:32 +0200, Benny Halevy wrote: > On Feb. 12, 2008, 17:07 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Mon, 2008-02-11 at 21:53 -0800, Greg KH wrote: > >>> this is why you need specific trees for just the API change, and these > &

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 11:31 -0300, Sergio Luis wrote: > Fix compilation warning in drivers/scsi/gdth.c, using deprecated > pci_find_device. > Change it into using pci_get_device instead: > drivers/scsi/gdth.c:645: warning: 'pci_find_device' is deprecated (declared > at include/linux/pci.h:495) >

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread James Bottomley
On Mon, 2008-02-11 at 21:53 -0800, Greg KH wrote: > > this is why you need specific trees for just the API change, and these > > need to EXPLICITLY go first before EVERYTHING ELSE. Yes this needs a > > bit of coordination, but it's the only way. > > Even then, it will not work. > > Again, Roland

Re: Open bugs

2008-02-12 Thread James Bottomley
Added linux-scsi for the SCSI ones On Tue, 2008-02-12 at 00:18 -0800, Natalie Protasevich wrote: > Hello, > > The bugs listed are over a month old, and haven't been addressed yet. > It would be appreciated if corresponding maintainers identify whether > the bugs have been fixed, or need to be wor

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 21:18 +0100, Jiri Kosina wrote: > On Tue, 12 Feb 2008, James Bottomley wrote: > > > > Rebases *do*not*work* (and fundamentally cannot work) in a > > > distributed environment. > > Hm ... I think net is a counter example to this. Rebases cer

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread James Bottomley
On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote: > - gdth_flush(ha); > - This piece doesn't look right. gdth_flush() forces the internal cache to disk backing. If you remove it, you're taking the chance that the machine will be powered off without a writeback which can cause data corru

Re: [PATCH] enclosure: add support for enclosure services

2008-02-13 Thread James Bottomley
On Wed, 2008-02-13 at 09:08 -0500, James Smart wrote: > The keep-it-in-user-space arguments seem fairly compelling to me. > Especially as we've pushed whole i/o subsystems out to user space > (iscsi, stgt, talked about fcoe, a lot of dm control, etc). And to me too. > The functionality seems to a

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread James Bottomley
On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote: > On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley <[EMAIL PROTECTED]> > > wrote: > >> On Tue, 2008-02-1

Re: [PATCH] enclosure: add support for enclosure services

2008-02-13 Thread James Bottomley
On Wed, 2008-02-13 at 11:22 -0500, James Smart wrote: > James Bottomley wrote: > > I don't disagree with that, but the fact is that there isn't such a > > tool. It's also a fact that the enterprise is reasonably unhappy with > > the lack of an enclosure m

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread James Bottomley
On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote: > On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote: > >> On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh <[EMAIL PROTECTED]&g

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread James Bottomley
On Wed, 2008-02-13 at 19:18 +0200, Boaz Harrosh wrote: > On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > > It needs to register a reboot notifier, which gdth does. > > > > However, the notifier is only called on reboot, so it also need

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread James Bottomley
On Wed, 2008-02-13 at 19:12 +0200, Boaz Harrosh wrote: > On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote: > >> On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]

  1   2   3   4   5   6   7   8   9   10   >