I'll apply this.
Thanks,
2012-10-05 (금), 12:56 -0700, Randy Dunlap:
> On 10/05/2012 04:56 AM, 김재극 wrote:
>
> > This adds a document describing the mount options, proc entries, usage, and
> > design of Flash-Friendly File System, namely F2FS.
> >
&
2012-10-06 (토), 09:19 +0200, Stefan Hajnoczi:
> > This adds a document describing the mount options, proc entries, usage, and
> > design of Flash-Friendly File System, namely F2FS.
> >
> > Signed-off-by: Jaegeuk Kim samsung.com>
> > ---
> > Do
s/.
> > The patch #2 adds a header file of on-disk layout to include/linux/.
> > The patches #3-#15 adds f2fs source files to fs/f2fs/.
> > The Last patch, patch #16, updates Makefile and Kconfig.
> >
> > mkfs.f2fs
> > =====
> >
> > The file sys
> -Original Message-
> From: Marco Stornelli [mailto:marco.storne...@gmail.com]
> Sent: Sunday, October 07, 2012 4:10 PM
> To: Jaegeuk Kim
> Cc: Vyacheslav Dubeyko; jaegeuk@samsung.com; Al Viro; ty...@mit.edu;
> gre...@linuxfoundation.org;
> linux-kernel@
> -Original Message-
> From: Vyacheslav Dubeyko [mailto:sl...@dubeyko.com]
> Sent: Sunday, October 07, 2012 9:09 PM
> To: Jaegeuk Kim
> Cc: 'Marco Stornelli'; 'Jaegeuk Kim'; 'Al Viro'; ty...@mit.edu;
> gre...@linuxfoundation.org; linux
> -Original Message-
> From: Namjae Jeon [mailto:linkinj...@gmail.com]
> Sent: Monday, October 08, 2012 7:00 PM
> To: Jaegeuk Kim
> Cc: Vyacheslav Dubeyko; Marco Stornelli; Jaegeuk Kim; Al Viro; ty...@mit.edu;
> gre...@linuxfoundation.org; linux-kernel@vger.k
> -Original Message-
> From: Namjae Jeon [mailto:linkinj...@gmail.com]
> Sent: Monday, October 08, 2012 8:22 PM
> To: Jaegeuk Kim
> Cc: Vyacheslav Dubeyko; Marco Stornelli; Jaegeuk Kim; Al Viro; ty...@mit.edu;
> gre...@linuxfoundation.org; linux-kernel@vger.k
> -Original Message-
> From: Vyacheslav Dubeyko [mailto:sl...@dubeyko.com]
> Sent: Tuesday, October 09, 2012 4:23 AM
> To: Jaegeuk Kim
> Cc: 'Marco Stornelli'; 'Jaegeuk Kim'; 'Al Viro'; ty...@mit.edu;
> gre...@linuxfoundation.org; linux
---
Jaegeuk Kim
Samsung
> -Original Message-
> From: Namjae Jeon [mailto:linkinj...@gmail.com]
> Sent: Tuesday, October 09, 2012 12:52 PM
> To: Jaegeuk Kim
> Cc: Vyacheslav Dubeyko; Marco Stornelli; Jaegeuk Kim; Al Viro; ty...@mit.edu;
> gre...@linuxfoundation
> -Original Message-
> From: linux-fsdevel-ow...@vger.kernel.org
> [mailto:linux-fsdevel-ow...@vger.kernel.org] On Behalf Of
> Luka? Czerner
> Sent: Tuesday, October 09, 2012 5:32 PM
> To: Jaegeuk Kim
> Cc: 'Namjae Jeon'; 'Vyacheslav Dubeyko';
> -Original Message-
> From: Lukáš Czerner [mailto:lczer...@redhat.com]
> Sent: Tuesday, October 09, 2012 8:01 PM
> To: Jaegeuk Kim
> Cc: 'Lukáš Czerner'; 'Namjae Jeon'; 'Vyacheslav Dubeyko'; 'Marco Stornelli';
> 'Jaegeuk Kim&
2012-10-09 (화), 14:39 +0200, Lukáš Czerner:
> On Tue, 9 Oct 2012, Jaegeuk Kim wrote:
>
> > > > > > > >
> > > > > > > > As you can see the f2fs kernel document patch, I think one of
> > > > > > > > the most
&
> -Original Message-
> From: linux-fsdevel-ow...@vger.kernel.org
> [mailto:linux-fsdevel-ow...@vger.kernel.org] On Behalf Of
> Dave Chinner
> Sent: Wednesday, October 10, 2012 6:20 AM
> To: Jaegeuk Kim
> Cc: 'Lukáš Czerner'; 'Namjae Jeon'
[snip]
> > +/*
> > + * For superblock
> > + */
> > +struct f2fs_super_block {
> > + __le32 magic; /* Magic Number */
> > + __le16 major_ver; /* Major Version */
> > + __le16 minor_ver; /* Minor Version */
> > + __le32 log_sectorsize; /* log2 (Sector size in bytes) */
[snip]
> > How about the following scenario?
> > 1. data "a" is newly written.
> > 2. checkpoint "A" is done.
> > 3. data "a" is truncated.
> > 4. checkpoint "B" is done.
> >
> > If fs supports multiple snapshots like "A" and "B" to users, it cannot
> > reuse the space allocated by
> > data "a" af
s/node.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 25d3036..1987036 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -266,6 +266,7 @@ void get_node_info(struct f2fs_sb_info *sbi, nid_t nid,
> struct node_in
F2FS_DIRTY_DENTS);
> inode_dec_dirty_dents(dir);
> - page_offset = page->index << PAGE_CACHE_SHIFT;
> f2fs_put_page(page, 1);
> } else {
> f2fs_put_page(page, 1);
>
>
--
Jaegeuk Kim
Samsung
signature.asc
Description: This is a digitally signed message part
> On Tuesday 16 October 2012, Jaegeuk Kim wrote:
> > >
> > > > > An xattr on the root inode that holds a list like this is something
> > > > > that could be set at mkfs time, but then also updated easily by new
> > > > > software
> [snip]
> > >
> > > And Would you share ppt or document of f2fs if Korea Linux Forum is
> > > finished ?
> > >
> >
> > Here I attached the slides, and LF will also share the slides.
> > Thanks,
> >
>
> I had hope that slides will have more detailed description. Maybe it is
> good for Linux Forum
, "mkfs.f2fs", is available from the following
download page: http://sourceforge.net/projects/f2fs-tools/
Usage
=
If you'd like to experience f2fs, simply:
# mkfs.f2fs /dev/sdb1
# mount -t f2fs /dev/sdb1 /mnt/f2fs
Short log
=========
Jaegeuk Kim (16):
f2fs: add
This adds a document describing the mount options, proc entries, usage, and
design of Flash-Friendly File System, namely F2FS.
Signed-off-by: Jaegeuk Kim
---
Documentation/filesystems/00-INDEX |2 +
Documentation/filesystems/f2fs.txt | 404
2 files
This adds a header file describing the on-disk layout of f2fs.
Signed-off-by: Changman Lee
Signed-off-by: Chul Lee
Signed-off-by: Jaegeuk Kim
---
include/linux/f2fs_fs.h | 362 +++
1 file changed, 362 insertions(+)
create mode 100644 include/linux
This adds the implementation of superblock operations for f2fs, which includes
- init_f2fs_fs/exit_f2fs_fs
- f2fs_mount
- super_operations of f2fs
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/super.c | 590 +++
1 file changed, 590 insertions
order to provide an address space for meta pages, f2fs_sb_info has a special
inode, namely meta_inode. This patch also adds the address space operations for
meta_inode.
Signed-off-by: Chul Lee
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/checkpoint.c | 795
management such as getting, allocating, and
truncating node blocks to index data.
- In order to cache node blocks in memory, F2FS has a node_inode with an address
space for node pages. This patch also adds the address space operations for
node_inode.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/node.c
functions to write data, node, and meta pages. Since LFS
basically produces a series of sequential writes, F2FS merges sequential bios
with a single one as much as possible to reduce the IO scheduling overhead.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/segment.c | 1795
This adds memory operations and file/file_inode operations.
- F2FS supports fallocate(), mmap(), fsync(), and basic ioctl().
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/file.c | 640
1 file changed, 640 insertions(+)
create mode 100644 fs
This adds address space operations for data.
- F2FS supports readpages(), writepages(), and direct_IO().
- Because of out-of-place writes, f2fs_direct_IO() does not write data in place.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c | 701
This adds core functions to get, read, write, and evict an inode.
Signed-off-by: Changman Lee
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/inode.c | 262 +++
1 file changed, 262 insertions(+)
create mode 100644 fs/f2fs/inode.c
diff --git a/fs
This adds inode operations for directory, symlink, and special inodes.
Signed-off-by: Changman Lee
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/namei.c | 494 +++
1 file changed, 494 insertions(+)
create mode 100644 fs/f2fs/namei.c
diff --git a
This adds core functions to find, add, delete, and link dentries.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/dir.c | 657
fs/f2fs/hash.c | 98 +
2 files changed, 755 insertions(+)
create mode 100644 fs/f2fs/dir.c
create mode
This implements xattr and acl functionalities.
- F2FS uses a node page to contain use extended attributes.
Signed-off-by: Changman Lee
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/acl.c | 465 +++
fs/f2fs/acl.h | 57 +++
fs/f2fs/xattr.c
of on-demand cleaning, F2FS should
move the data right away.
- In order to identify valid blocks in a victim segment, F2FS scans the bitmap
of the segment managed as an SIT entry.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/gc.c | 1139 ++
fs
on of next node block in each direct node block for reconstructing
the chain of node blocks during the recovery.
- In order to enhance the performance, F2FS keeps a "dentry" mark also in direct
node blocks. If this is set during the recovery, F2FS replays adding a dentry.
Signed
This adds Makefile and Kconfig for f2fs, and updates Makefile and Kconfig files
in the fs directory.
Signed-off-by: Jaegeuk Kim
---
fs/Kconfig |1 +
fs/Makefile |1 +
fs/f2fs/Kconfig | 55 ++
fs/f2fs/Makefile |6
tency repeatedly,
while running a reliability test.
So, please pull the f2fs filesystem.
If I'm missing any issues or made mistakes, please let me know.
Thanks,
Jaegeuk Kim
The following changes since commit
29594404d7fe73cd80eaa4ee8c43dcc53970c60e:
Linux 3.7 (2012-12-10 19:30:57 -0800)
are
dotdot dentries should have zero-value hash code */
+ if (!memcmp(name, ".", 1) || !memcmp(name, "..", 2))
+ return 0;
+
/* Initialize the default seed for the hash checksum functions */
buf[0] = 0x67452301;
buf[1] = 0xefcdab89;
--
1.8.0.1.250.gb7973fb
--
Jaegeuk Kim
Samsung
signature.asc
Description: This is a digitally signed message part
ts version. I suggest to output version of f2fs utilities.
Agreed.
But, I'd like to note that f2fs is not merged yet.
IMHO, it'd better give an initial version after f2fs is merged.
Thanks,
>
> With the best regards,
> Vyacheslav Dubeyko.
>
--
Jaegeuk Kim
Samsung
--
To uns
node for node space */
> sbi->node_inode = f2fs_iget(sb, F2FS_NODE_INO(sbi));
> if (IS_ERR(sbi->node_inode)) {
> + pr_err("Failed to read node inode\n");
> err = PTR_ERR(sbi->node_inode);
> goto free_nm;
> }
> @@ -534,6 +559,7 @@ static int f2fs_fill_super(struct super_block *sb, void
> *data, int silent)
> /* read root inode and dentry */
> root = f2fs_iget(sb, F2FS_ROOT_INO(sbi));
> if (IS_ERR(root)) {
> + pr_err("Failed to read root inode\n");
> err = PTR_ERR(root);
> goto free_node_inode;
> }
--
Jaegeuk Kim
Samsung
signature.asc
Description: This is a digitally signed message part
GROUP assigning e_id is
> unnecessary. Remove the assignment so f2fs will build with user
> namespaces enabled.
>
> Cc: Jaegeuk Kim
> Cc: Namjae Jeon
> Cc: Amit Sahrawat
> Signed-off-by: "Eric W. Biederman"
Acked-by: Jaegeuk Kim
--
Jaegeuk Kim
Samsung
signature.asc
Description: This is a digitally signed message part
: [PATCH] f2fs: add missing pretech.h include
>
> That should have been "prefetch.h", obviously...
> At least the patch is correct.
Hi,
This was fixed by Geert Uytterhoeven before.
I'm supposed to push other bug fixes with this to linus today.
Anyway, thank you very much. :)
Hi Linus,
Please pull the following patches for bug fixes on the f2fs file system.
Thank you very much.
--
Jaegeuk Kim
Samsung
The following changes since commit
637704cbc95c02d18741b4a6e7a5d2397f8b28ce:
Merge branch 'i2c-embedded/for-next' of
git://git.pengutronix.de/git/wsa/linu
2012-12-28 (금), 03:00 +0100, Sedat Dilek:
> Looks like you didn't S-o-b-ed all patches in your tree (see Leon's or
> Geert's patch).
I've fixed all the patches.
Thank you. :)
>
> - Sedat -
>
> On Fri, Dec 28, 2012 at 2:54 AM, Jaegeuk Kim wrote:
> >
Hi Linus,
Sorry for the noise.
I've resolved the S-O-B issue in v1 tree.
Here is the pull request v2.
Thanks,
--
Jaegeuk Kim
Samsung
The following changes since commit
637704cbc95c02d18741b4a6e7a5d2397f8b28ce:
Merge branch 'i2c-embedded/for-next' of
git://git.pengutronix.d
t_lock);
> if (__lookup_free_nid_list(nid, &nm_i->free_nid_list)) {
> - spin_unlock(&nm_i->free_nid_list_lock);
> kmem_cache_free(free_nid_slab, i);
> + spin_unlock(&nm_i->free_nid_list_lock);
> return 0;
> }
>
Merged.
Thank you very much.
--
Jaegeuk Kim
Samsung
2012-12-19 (수), 22:19 +0100, Geert Uytterhoeven:
> m68k allmodconfig:
>
> fs/f2fs/data.c: In function ‘read_end_io’:
> fs/f2fs/data.c:311: error: implicit declaration of function ‘prefetchw’
>
> fs/f2fs/segm
This patch adds myself to MAINTAINERS entry for the f2fs file system.
Signed-off-by: Jaegeuk Kim
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9386a63..f15d168 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3204,6 +3204,16 @@ F
>= META_FLUSH)
> rw = WRITE_FLUSH_FUA;
>
> + if (type == META)
Should be if (btype == META).
Thanks,
> + rw |= REQ_META;
> +
> if (sbi->bio[btype]) {
> struct bio_private *p = sbi->bio[btype]->bi_private;
>
em for tracing the filesystem
> operations for information/debugging purpose if needed. All the
> tracepoints are clubbed with respect to functionalities.
>
> Change Log:
> v4: Modified the tracepoints as per the review comments of
> Jaegeuk Kim. Follo
gned-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: Steven Rostedt
[Jaegeuk: combine and modify the tracepoint structures]
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/file.c | 7 +-
fs/f2fs/inode.c | 13 ++-
fs/f2fs/namei.c | 3 +
fs/f2fs/sup
geuk: combine and modify the tracepoint structures]
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/file.c | 9 +++
fs/f2fs/node.c | 20 -
include/trace/events/f2fs.h | 176
3 files changed, 203 insertions(+), 2 deletions(-)
diff --g
Add tracepoints for page i/o operations and block allocation
tracing during page read operation.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: Steven Rostedt
[Jaegeuk: combine and modify the tracepoint structures]
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c
tracepoints for tracing the garbage collector
threads in f2fs with status of collection & type.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: Steven Rostedt
[Jaegeuk: modify slightly to show information]
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/gc.c
...@lists.sourceforge.net
Add tracepoints to debug the block allocation & fallocate.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: Steven Rostedt
[Jaegeuk: enhance information]
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c | 2 ++
fs/f2fs/file.c | 1 +
inc
...@lists.sourceforge.net
Add tracepoints to debug the various page write operation
like data pages, meta pages.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: Steven Rostedt
[Jaegeuk: remove unnecessary tracepoints]
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/segment.c | 5
include
...@lists.sourceforge.net
Add tracepoints to debug checkpoint request.
Signed-off-by: Namjae Jeon
Signed-off-by: Pankaj Kumar
Acked-by: Steven Rostedt
[Jaegeuk: change expressions]
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/checkpoint.c| 7 +++
include/trace/events/f2fs.h | 24
2
fsync performance significatly.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/dir.c | 2 +-
fs/f2fs/f2fs.h| 2 +-
fs/f2fs/file.c| 31 ++-
fs/f2fs/namei.c | 2 +-
fs/f2fs/node.h| 15 +++
fs/f2fs/segment.c | 2 +-
6 files changed, 45 insertions
creation performance test.
> > 3. file look-up performance test.
> > 4. other performance tools 's result.
> >
> > Thanks.
> >
> > 2013/6/4 Jaegeuk Kim :
> > > Hi,
> > >
> > > This feature is one of my todo items. ;)
done only when set_page_dirty() is called.
So let's add this newly got inode into the list explicitly, and put it at the
end of the recovery routine.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/checkpoint.c | 55 +---
fs/f2fs/f2fs.h | 1 +
fs/f2f
This patch adds the support of security labels for f2fs, which will be used
by SElinux.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/Kconfig | 9 +
fs/f2fs/dir.c | 5 +
fs/f2fs/xattr.c | 59 +++--
fs/f2fs/xattr.h | 12 +++-
4
ver, previously f2fs_file_inode_operations only has this, so this patch adds
it to all the types of inode_operations.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/f2fs.h | 1 +
fs/f2fs/file.c | 2 +-
fs/f2fs/namei.c | 3 +++
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b
Change log from v1:
o fix a bug
From 901aea226653e26aa3556edd88ca1e48fa89eb5f Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim
Date: Mon, 3 Jun 2013 19:46:19 +0900
Subject: [PATCH 2/2] f2fs: support xattr security labels
Cc: linux-fsde...@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-de
> 9 files changed, 402 insertions(+), 4 deletions(-)
> create mode 100644 fs/f2fs/inline.c
>
--
Jaegeuk Kim
Samsung
signature.asc
Description: This is a digitally signed message part
pes)
fs/f2fs/recovery.c:238:33:expected unsigned int [unsigned] ofs_in_node
fs/f2fs/recovery.c:238:33:got restricted __le16 [assigned] [usertype]
ofs_in_node
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/recovery.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
G
3. untar:7.8G794M6.6G
So, after untar the kernel source, you're able to discover that the
available sizes are not much different between F2FS and EXT4.
Thanks,
>
> Pavel
--
Jaegeuk Kim
Samsung
--
To u
namically instead
> > of the user decision?
> Yes, I thought such idea before. It might be useful if gc thread can
> dynamically control own gc times with different partition size and
> available size.
> But I think there is a limitation that f2fs don't predict when user access
2013-06-07 (금), 19:50 +0900, Namjae Jeon:
> 2013/6/7, Jaegeuk Kim :
> > Change log from v1:
> > o fix a bug
> >
> > From 901aea226653e26aa3556edd88ca1e48fa89eb5f Mon Sep 17 00:00:00 2001
> > From: Jaegeuk Kim
> > Date: Mon, 3 Jun 2013 19:46:19 +0900
>
Hi,
Thank you for the review.
I agreed all, and will submit v3.
Thanks,
2013-06-07 (금), 15:13 -0700, Casey Schaufler:
> On 6/6/2013 10:55 PM, Jaegeuk Kim wrote:
> > This patch adds the support of security labels for f2fs, which will be used
> > by SElinux.
>
> Please b
Change log from v2:
o fix description and simplify a code line (commented by Casey
Schaufler)
Change log from v1:
o fix a bug
From 9f889afcd74a58d9a538fa02f4af31d11eb17c54 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim
Date: Mon, 3 Jun 2013 19:46:19 +0900
Subject: [PATCH] f2fs: support xattr
Hi,
2013-06-08 (토), 15:25 +0800, Huajun Li:
>
> Hi Jaegeuk,
> Thanks for your suggestion.
> On Wed, Jun 5, 2013 at 3:13 PM, Jaegeuk Kim
> wrote:
> Hi Haicheng,
> 2013-06-04 (화), 14:01 +0800, Haicheng Li:
> > Hi Jaegeuk & Namjae,
>
)
- f2fs_write_data_page
- skip to write the last dentry block due to index < i_size
In the above flow, new_i_size is not updated to its inode block so that the
last dentry block will be lost accordingly.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c | 2 ++
fs/f2fs/dir.c | 9 -
fs/f
: Jaegeuk Kim
Date: Mon, 3 Jun 2013 19:46:19 +0900
Subject: [PATCH] f2fs: support xattr security labels
Cc: linux-fsde...@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-de...@lists.sourceforge.net
This patch adds the support of security labels for f2fs, which will be
used
by Linus Security
If update_inode is called, we don't need to do write_inode.
So, let's use a *dirty* flag for each inode.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/f2fs.h | 1 +
fs/f2fs/file.c | 1 +
fs/f2fs/inode.c | 4
fs/f2fs/super.c | 12
4 files changed, 18 insertions(+)
di
Change log from v1:
o declare *static* to f2fs_dirty_inode (reported by kbuild-test-robot)
From 6b523242fa7b301653e83496fb065d5c0cbe7968 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim
Date: Mon, 10 Jun 2013 09:17:01 +0900
Subject: [PATCH] f2fs: avoid freqeunt write_inode calls
Cc: linux-fsde
t; from __add_sum_entry()
f2fs: make locate_dirty_segment() as static
f2fs: optimize do_write_data_page()
Jaegeuk Kim (35):
f2fs: fix inconsistency of block count during recovery
f2fs: fix the inconsistent state of data pages
f2fs: remove redundant assignment
f2fs:
t; from __add_sum_entry()
f2fs: make locate_dirty_segment() as static
f2fs: optimize do_write_data_page()
Jaegeuk Kim (35):
f2fs: fix inconsistency of block count during recovery
f2fs: fix the inconsistent state of data pages
f2fs: remove redundant assignment
f2fs:
tence
of any fsync mark'ed node blocks.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/file.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index d2d2b7d..157a635 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -147,9 +147
a size = 4, name length = 6, total files = 4096, nproc=1
4097 files created
This bug is due to the misupdate of directory position in ctx.
So, this patch fixes this.
CC: Al Viro
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/dir.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Chang log from v1:
o fix another scenario
>From 2ee3c8144187ab230d0f47f9b95e5406af87ada8 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim
Date: Fri, 5 Jul 2013 14:06:04 +0900
Subject: [PATCH] f2fs: fix readdir incorrectness
Cc: linux-fsde...@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f
You can monitor valid block counts of whole segments in:
/proc/fs/f2fs/sdb1/segment_info.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/f2fs.h | 1 +
fs/f2fs/super.c | 46 ++
2 files changed, 47 insertions(+)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
newly updated data index
excluding inode metadata updates.
So, this patch introduces write_end in which updates inode block too when the
i_size is changed.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/fs
segments such as y or y+1, we lost the old node blocks
so that f2fs even cannot start roll-forward recovery.
Therefore, I suggest that we should remove reusing prefree segments.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/segment.c | 56 +--
1 file ch
Hi,
2013-06-26 (수), 14:10 +0900, Namjae Jeon:
> 2013/6/25, Jaegeuk Kim :
> >> > - any priority scheme for cleaning?
> >> Could you plz tell me a little more detail ?
> >
> > I meant, as well as the GC times, user also gives a kind of status like:
> >
x27;s remove this condition check and hope that user triggers in right
manner.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c | 3 ---
fs/f2fs/f2fs.h | 1 -
fs/f2fs/file.c | 10 --
fs/f2fs/inode.c | 1 -
4 files changed, 15 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
x27;t need to drop the nat cache entry at this
moment.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/node.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index f7b03ba..0177f94 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1621,11 +16
nly normal files can be recovered by roll-forward.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/f2fs.h | 2 +-
fs/f2fs/file.c | 22 ++
fs/f2fs/namei.c | 14 ++
fs/f2fs/node.h | 15 +++
4 files changed, 28 insertions(+), 25 deletions(-)
diff --git a/fs/f
We should handle errors during the recovery flow correctly.
For example, if we get -ENOMEM, we should report a mount failure instead of
conducting the remained mount procedure.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/f2fs.h | 2 +-
fs/f2fs/recovery.c | 46
2013-03-25 (월), 15:30 +0900, Namjae Jeon:
> 2013/3/25, Jaegeuk Kim :
> > We should handle errors during the recovery flow correctly.
> > For example, if we get -ENOMEM, we should report a mount failure instead of
> > conducting the remained mount procedure.
> >
>
The error is reproducible by:
After this, when we retrieve the inode->i_name of test2 by dump.f2fs, we get
test1 instead of test2.
This is because f2fs didn't update the file name during the f2fs_rename.
So, this patch fixes that.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/dir.
break;
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 9b74ae2..bcd19db 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -639,7 +639,7 @@ static void do_submit_bio(struct f2fs_sb_info *sbi,
>
> trace_f2fs_do_submit_bio(sbi->sb, btype, sync, sbi->bio[btype]
2013-07-31 (수), 09:59 +0800, Gu Zheng:
> Hi Kim,
>
> On 07/30/2013 08:29 PM, Jaegeuk Kim wrote:
>
> > Hi Gu,
> >
> > The original read flow was to avoid redandunt lock/unlock_page() calls.
>
> Right, this can gain better read performance. But is the wa
ure of
add_orphan_inode().
So, let's increment sbi->n_orphans virtually prior to the actual orphan inode
stuffs. After that, let's release sbi->n_orphans by calling release_orphan_inode
or remove_orphan_inode.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/checkpoint.c | 13 ++---
fs/f2fs/di
In the case of lazy umount, "umount -l", some processes are able to use the
file system even if its mountpoint was disconnected.
At this moment, we should not allow mkfs.f2fs.
This patch adds this condition check.
Signed-off-by: Jaegeuk Kim
---
fsck/main.c| 2 +-
include
s not uptodated.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index ea3cb29..6b328de 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -259,8 +259,17 @@ repeat:
if (PageUpt
blocked when
attempt
to write data pages for the same inode. At the same time, f2fs_gc thread
does not notice the situation and could not help. Even the sync syscall
gets blocked.
To fix it, we could submit the cached bio first before waiting on a
inode page
that is being written back.
Signed-off-b
const char *fmt,
> ...)
> {
> struct va_format vaf;
> @@ -243,6 +352,8 @@ static void f2fs_put_super(struct super_block *sb)
> destroy_segment_manager(sbi);
>
> kfree(sbi->ckpt);
> + kobject_del(&sbi->s_kobj);
> + wait_for_completio
fsync calls can also consume all the fs_lock too.
Thanks,
--
Jaegeuk Kim
Samsung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
o start to design it from the scatch.
Thanks,
2013-06-08, 15:25 +0800, Huajun Li:
>
> Hi Jaegeuk,
> Thanks for your suggestion.
>
>
> On Wed, Jun 5, 2013 at 3:13 PM, Jaegeuk Kim
> wrote:
> Hi Haicheng,
>
> 2013-06-04 (화), 14:01 +0800, Haic
sing the kobject header file in dir.c.
So, this patch move the header file to the right location, f2fs.h.
CC: Namjae Jeon
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/f2fs.h | 1 +
fs/f2fs/super.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 1
This patch introduces a new inline function, cur_cp_version, to reduce redundant
codes.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/checkpoint.c | 6 +++---
fs/f2fs/f2fs.h | 7 ++-
fs/f2fs/file.c | 3 +--
fs/f2fs/recovery.c | 4 ++--
fs/f2fs/xattr.c | 2 +-
5 files changed, 13
101 - 200 of 2588 matches
Mail list logo
