On Wed, Jul 09, 2014 at 07:12:09PM -0400, Trond Myklebust wrote:
> Oops. Sorry, the correct sub-sub-sub-sub-paragraph is this one:
>
> Permission to execute a file.
>
> Servers SHOULD allow a user the ability to read the data of the
> file when only the ACE4_EXECUTE
On Sat, Jul 05, 2014 at 01:10:58AM +1000, Stephen Rothwell wrote:
> Hi Sachin,
>
> On Fri, 4 Jul 2014 14:12:11 +0530 Sachin Kamat wrote:
> >
> > Was bisecting a kernel crash on Arndale octa board (Exynos5420). It
> > points to a merge
> > commit:
> > 40556a4c485d12d324f1ea196cc30f590e564237 is th
On Wed, Jul 23, 2014 at 08:12:31PM +0530, Himangi Saraogi wrote:
> Replace a comma between expression statements by a semicolon. This changes
> the semantics of the code, but given the current indentation appears to be
> what is intended.
>
> A simplified version of the Coccinelle semantic patch t
Please pull one more 3.16 bugfix from
git://linux-nfs.org/~bfields/linux.git for-3.16
Another regression from the xdr encoding rewrite.
--b.
Kinglong Mee (1):
NFSD: Fix crash encoding lock reply on 32-bit
fs/nfsd/nfs4xdr
On Sat, Jun 07, 2014 at 07:48:21PM -0700, Philippe Troin wrote:
> Hi Trond & Christoph,
>
> It's still broken, but in a different way.
> The phantom attrs are gone, but the attr/acl interaction is still
> uncertain.
>
> I have tested vanilla 3.14.5 + this patch on x86_64.
> Mount options are the
nfsd: remove
nfsd: clean up fh_auth usage
nfsd: remove nfsd4_free_slab
nfsd: getattr for FATTR4_WORD0_FILES_AVAIL needs the statfs buffer
nfsd: remove unused function nfsd_read_file
Chuck Lever (1):
NFSD: Ignore client's source port on RDMA transports
J. B
Applying, sorry for the delay.--b.
On Wed, Feb 26, 2014 at 04:50:01PM +0300, Stanislav Kinsbursky wrote:
> There could be a case, when NFSd file system is mounted in network, different
> to socket's one, like below:
>
> "ip netns exec" creates new network and mount namespace, which duplicates NFS
On Thu, May 22, 2014 at 04:32:30PM +0200, Benoit Taine wrote:
> Assignments should not happen inside an if conditional, but in the line
> before. This issue was reported by checkpatch.
OK, applying for 3.16.
--b.
>
> The semantic patch that makes this change is as follows
> (http://coccinelle.l
On Thu, May 22, 2014 at 12:50:34PM +0200, Richard Weinberger wrote:
> On Wed, May 21, 2014 at 11:33 PM, Richard Weinberger
> wrote:
> > Hi!
> >
> > My backup server runs CentOS6 with kernel 2.6.32-431.17.1.el6.x86_64.
> > Many servers copy theirs backups to it. This setups works perfectly
> > fine
On Thu, May 22, 2014 at 12:50:34PM +0200, Richard Weinberger wrote:
> On Wed, May 21, 2014 at 11:33 PM, Richard Weinberger
> wrote:
> > Hi!
> >
> > My backup server runs CentOS6 with kernel 2.6.32-431.17.1.el6.x86_64.
> > Many servers copy theirs backups to it. This setups works perfectly
> > fine
On Fri, May 23, 2014 at 02:36:16PM +0200, Richard Weinberger wrote:
> Am 23.05.2014 13:56, schrieb J. Bruce Fields:
> > It's not a known issue, and finding out where the problem was introduced
> > could indeed by helpful.
> >
> > I'm not sure how to interpr
Please pull nfsd bugfixes for 3.15:
git://linux-nfs.org/~bfields/linux.git for-3.15
Just two bugfixes, one for a merge-window-introduced ACL regression, the
other for a longer-standing v4 state bug.
--b.
J. Bruce Fields (3):
nfsd4: fix corruption on setting an ACL.
nfsd4: remove
On Mon, May 26, 2014 at 11:18:15AM +1000, Stephen Rothwell wrote:
> Hi Bruce,
>
> After merging the nfsd tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/nfsd/nfs4proc.c: In function 'warn_on_nonidempotent_op':
> fs/nfsd/nfs4proc.c:1861:3: error: implicit declar
On Wed, May 28, 2014 at 12:07:28PM +1000, Stephen Rothwell wrote:
> Hi Bruce,
>
> After merging the nfsd tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
>
> fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_security_label':
> fs/nfsd/nfs4xdr.c:1945:15: error: 'pp' undeclare
Looks fine to me, ACK.--b.
On Mon, Apr 28, 2014 at 01:50:13PM -0400, Jeff Layton wrote:
> Currently, the fl_owner isn't set for flock locks. Some filesystems use
> byte-range locks to simulate flock locks and there is a common idiom in
> those that does:
>
> fl->fl_owner = (fl_owner_t)filp;
>
ittle ad-hoc, but I don't have another proposal, so, ACK.
The forced-unlock/downgrade case in time_out_leases might be another
good spot for a tracepoint.
--b.
>
> Cc: "J. Bruce Fields"
> Signed-off-by: Jeff Layton
> ---
> fs/locks.c | 10 +++
be found at:
> https://github.com/kvaneesh/linux/commits/richacl-for-upstream
>
> Since we are trying to get the changes merged upstream after a long time, I am
> posting this as V1 again. I Also dropped the Acked-by tag from
> David Howells and J. Bruce Fields .
> Please let m
On Wed, Apr 23, 2014 at 12:40:58PM +1000, NeilBrown wrote:
> PF_LESS_THROTTLE has a very specific use case: to avoid deadlocks
> and live-locks while writing to the page cache in a loop-back
> NFS mount situation.
>
> It therefore makes sense to *only* set PF_LESS_THROTTLE in this
> situation.
> W
The scripts I use for my kernel testing rely on the targz-pkg make
target. After updating to 3.16-rc1 my scripts started failing. In
scripts/package/buildtar:
tmpdir="${objtree}/tar-install"
tarball="${objtree}/linux-${KERNELRELEASE}-${ARCH}.tar"
..
#
# Create the tarball
#
(
che: simplify code by using hex_pack_byte()
Christoph Hellwig (1):
nfsd: start documenting some XDR handling functions
J. Bruce Fields (12):
nfsd4: update 4.1 nfsd status documentation
nfsd4: break only delegations when appropriate
nfsd4: better VERIFY comment
minor
On Thu, Jan 30, 2014 at 10:23:06AM -0800, Linus Torvalds wrote:
> On Wed, Jan 29, 2014 at 10:54 AM, J. Bruce Fields
> wrote:
> >
> > Stephen Rothwell noted a merge conflict:
> >
> > http://marc.info/?i=<20140129124238.6e1667abab08be8be2daf...@canb.auug.org.
On Fri, Jan 31, 2014 at 06:42:58PM +, Al Viro wrote:
> On Thu, Jan 23, 2014 at 04:27:00PM -0500, J. Bruce Fields wrote:
> > From: "J. Bruce Fields"
> >
> > d_splice_alias can create duplicate directory aliases (in the !new
> > case), or (in the new cas
On Mon, Dec 09, 2013 at 11:46:53AM -0500, Jeff Layton wrote:
> On Wed, 20 Nov 2013 14:50:32 -0500
> "J. Bruce Fields" wrote:
>
> > On Wed, Nov 20, 2013 at 11:45:04AM -0500, Jeff Layton wrote:
> > > Due to some unfortunate history, POSIX locks have very strange
On Tue, Dec 10, 2013 at 02:17:30PM -0500, Jeff Layton wrote:
> Currently, there's a lot of copy and paste between the two. Add some
> functions to do the initialization of the file_lock from values
> passed in, and turn the flock/flock64 variants of those functions into
> wrappers around them.
>
On Tue, Dec 10, 2013 at 04:22:53PM -0500, bfields wrote:
> On Tue, Dec 10, 2013 at 02:17:30PM -0500, Jeff Layton wrote:
> > Currently, there's a lot of copy and paste between the two. Add some
> > functions to do the initialization of the file_lock from values
> > passed in, and turn the flock/flo
On Wed, Dec 11, 2013 at 06:18:56AM -0500, Jeff Layton wrote:
> On Tue, 10 Dec 2013 18:22:04 -0500
> "J. Bruce Fields" wrote:
>
> > On Tue, Dec 10, 2013 at 04:22:53PM -0500, bfields wrote:
> > > On Tue, Dec 10, 2013 at 02:17:30PM -0500, Jeff Layton wrote:
> &
On Wed, Dec 11, 2013 at 09:37:24AM -0500, J. Bruce Fields wrote:
> Well, it'd be weird if I didn't screw up something somewhere.
Yes, a classic: I forgot the breaks after each switch case.
Here's a version that at least doesn't return -EINVAL on every lock
On Wed, Dec 11, 2013 at 11:54:33AM -0500, Jeff Layton wrote:
> On Wed, 11 Dec 2013 10:19:31 -0500
> "J. Bruce Fields" wrote:
>
> > On Wed, Dec 11, 2013 at 09:37:24AM -0500, J. Bruce Fields wrote:
> > > Well, it'd be weird if I didn't screw up som
On Wed, Dec 11, 2013 at 02:07:41PM -0500, Jeff Layton wrote:
> On Wed, 11 Dec 2013 10:19:31 -0500
> "J. Bruce Fields" wrote:
...
> > + if (l->l_len > 0)
> > + fl->fl_end = fl->fl_start + l->l_len - 1;
> > + else if (l->l_len <
On Wed, Dec 11, 2013 at 05:56:16PM -0500, J. Bruce Fields wrote:
> On Wed, Dec 11, 2013 at 02:07:41PM -0500, Jeff Layton wrote:
> > On Wed, 11 Dec 2013 10:19:31 -0500
> > "J. Bruce Fields" wrote:
> ...
> > > + if (l->l_len > 0)
> > >
On Fri, Oct 25, 2013 at 07:33:12PM -0700, Daniel Walker wrote:
> Signed-off-by: Daniel Walker
> ---
> fs/nfsd/fault_inject.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c
> index d620e7f..41165f0 100644
> ---
On Mon, Nov 11, 2013 at 04:30:34PM +, Al Viro wrote:
> All kinds of stuff this time around; some more notable parts:
> * RCU'd vfsmounts handling
> * new primitives for coredump handling
> * files_lock is gone
> * Bruce's delegations handling series
> * exportfs fi
On Fri, Nov 08, 2013 at 03:23:12PM +0800, Weng Meiling wrote:
>
> From: Weng Meiling
Huh. Looks like that was introduced with "[PATCH] knfsd: make sure
svc_process call the correct pg_authenticate for multi-service port" in
2005. OK! Applied.
--b.
>
> Signed-off-by: Weng Meiling
> ---
>
On Fri, Nov 08, 2013 at 03:23:28PM +0800, Weng Meiling wrote:
>
> From: Weng Meiling
I agree completely that a \n at the end would make more sense.
Have you tested that this nfs-utils is OK with this change?
I suspect that the only code that reads this file anywhere is
nfs-utils/utils
On Thu, Nov 14, 2013 at 08:38:55PM +0800, Weng Meiling wrote:
> On 2013/11/14 0:09, J. Bruce Fields wrote:
> > On Fri, Nov 08, 2013 at 03:23:28PM +0800, Weng Meiling wrote:
> >>
> >> From: Weng Meiling
> >
> > I agree completely that a \n at the end w
. Bruce Fields (12):
svcrpc: fix gss-proxy NULL dereference in some error cases
svcrpc: fix error-handling on badd gssproxy downcall
svcrpc: handle some gssproxy encoding errors
gss_krb5: document that we ignore sequence number
nfsd: fh_update should error out in unexpected
On Fri, Jan 31, 2014 at 02:47:58PM -0500, J. Bruce Fields wrote:
> (Then one remaining thing I don't understand is how to make that fixing
> up reliable. Or is there some reason nobody hits the _EBUSY case of
> __d_unalias?)
In fact, a reproducer found thanks to Hideshi Yamao
On Fri, Feb 07, 2014 at 05:48:59PM +0100, Miklos Szeredi wrote:
> From: Miklos Szeredi
>
> Add d_is_dir(dentry) helper which is analogous to S_ISDIR().
While trying to get up to speed I notice that these flags were
introduced by b18825a7c8e37a7cf6abb97a12a6ad71af160de7 "VFS: Put a small
type fie
On Fri, Feb 07, 2014 at 05:49:05PM +0100, Miklos Szeredi wrote:
> From: Miklos Szeredi
>
> lock_two_nondirectories warned if either of its args was a directory.
> Instead just ignore the directory args. This is needed for locking in
> cross rename.
>
> Signed-off-by: Miklos Szeredi
> ---
> fs
On Fri, Feb 07, 2014 at 05:49:06PM +0100, Miklos Szeredi wrote:
> From: Miklos Szeredi
>
> If flags contain RENAME_EXCHANGE then exchange source and destination files.
> There's no restriction on the type of the files; e.g. a directory can be
> exchanged with a symlink.
>
> Signed-off-by: Miklos
cross-rename"?
Yep, done. I'll also try running this through my nfs tests, for what
it's worth. (Not today as there's some unrelated regression to sort
out first.)
Feel free to add a
Reviewed-by: J. Bruce Fields
for any but the ext4 patches, which I skipped.
--b
I'm getting warnings about corruption of the kmalloc-32 slab on an nfs
server while running some regression tests.
A bisect lands on 9fe55eea7e4b444bafc42facc2d1d2847275 "Fix race
when checking i_size on direct i/o read". Is there any known problem
here?
It doesn't reproduce immediately and
On Sat, Feb 08, 2014 at 03:45:22PM -0500, bfields wrote:
> I'm getting warnings about corruption of the kmalloc-32 slab on an nfs
> server while running some regression tests.
>
> A bisect lands on 9fe55eea7e4b444bafc42facc2d1d2847275 "Fix race
> when checking i_size on direct i/o read". Is t
On Mon, Dec 30, 2013 at 05:23:59PM +0300, Stanislav Kinsbursky wrote:
> There could be a case, when NFSd file system is mounted in network, different
> to socket's one, like below:
>
> "ip netns exec" creates new network and mount namespace, which duplicates NFSd
> mount point, created in init_net
Ugh, I screwed up one more when rewriting flock{64}_to_posix_lock, an
off-by-one error caused by not noticing that the "end" offset of a lock
is at start + len - 1, not start + len.
(So for example, a 1-byte lock starting at offset 5 is recorded as
(fl_start, fl_end) == (5, 5), not (5,6))
Th
From: "J. Bruce Fields"
In the 32-bit case fcntl assigns the 64-bit f_pos and i_size to a 32-bit
off_t.
The existing range checks also seem to depend on signed arithmetic
wrapping when it overflows. In practice maybe that works, but we can be
more careful. That also allows us to m
Please pull a couple minor nfsd bugfixes from:
git://linux-nfs.org/~bfields/linux.git for-3.17
--b.
J. Bruce Fields (2):
nfsd4: fix rd_dircount enforcement
lockd: fix rpcbind crash on lockd startup failure
fs/lockd
On Tue, Sep 02, 2014 at 11:07:14PM +0400, Pavel Emelyanov wrote:
> > Would it make sense to return the lock type held instead, so you could
> > do one flock(fd, LOCK_TEST) instead of flock(fd, LOCK_TEST|LOCK_SH) and
> > flock(fd, LOCK_TEST|LOCK_EX) ?
>
> Well, in our case we parse /proc/locks anyw
On Wed, Sep 10, 2014 at 10:28:41AM -0400, Jeff Layton wrote:
> Signed-off-by: Jeff Layton
ACK to going ahead and applying this now if you want.
Took me a moment to understand why the i_flock test got moved--OK, so
the locks_remove_*'s are doing that themselves instead, got it.
--b.
> ---
> fs
On Wed, Sep 03, 2014 at 06:38:24PM +0400, Pavel Emelyanov wrote:
> On 09/02/2014 11:53 PM, Jeff Layton wrote:
> > On Tue, 2 Sep 2014 15:43:00 -0400
> > "J. Bruce Fields" wrote:
> >
> >> On Tue, Sep 02, 2014 at 11:07:14PM +0400, Pavel Emelyanov wrote:
>
check fi_deleg_file
> instead. We always set that at the same time so it will have the same
> semantics.
>
> Cc: J. Bruce Fields
> Signed-off-by: Jeff Layton
> Reviewed-by: Christoph Hellwig
> ---
> fs/nfsd/nfs4state.c | 10 --
> fs/nfsd/state.h | 1 -
&
On Mon, Jul 07, 2014 at 03:27:21PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jun 20, 2014 at 03:14:03PM +0400, Nikita Yushchenko wrote:
> > With current 3.10.y, if kernel is booted with init=/bin/sh and then nfs
> > mount
> > is attempted (without portmap or rpcbind running) using busybox mount,
On Tue, Sep 02, 2014 at 09:17:34PM +0400, Pavel Emelyanov wrote:
> Hi,
>
> There's a problem with getting information about who has a flock on
> a specific file. The thing is that the "owner" field, that is shown in
> /proc/locks is the pid of the task who created the flock, not the one
> who _may
On Tue, Sep 02, 2014 at 11:07:14PM +0400, Pavel Emelyanov wrote:
> On 09/02/2014 10:44 PM, J. Bruce Fields wrote:
> > On Tue, Sep 02, 2014 at 09:17:34PM +0400, Pavel Emelyanov wrote:
> >> Hi,
> >>
> >> There's a problem with getting information about who
comma to semicolon
J. Bruce Fields (11):
nfsd: fix rare symlink decoding bug
nfsd: make NFSv2 null terminate symlink data
nfsd: let nfsd_symlink assume null-terminated data
nfsd4: rename cr_linkname->cr_data
nfsd4: remove unused defer_free argument
nf
On Tue, Aug 12, 2014 at 01:43:13PM -0400, Jeff Layton wrote:
> On Tue, 12 Aug 2014 10:48:08 -0400
> Jeff Layton wrote:
>
> > In the days of yore, the file locking code was primarily protected by
> > the BKL. That changed in commit 72f98e72551fa (locks: turn lock_flocks
> > into a spinlock), at wh
On Wed, Aug 13, 2014 at 08:28:27AM +1000, Stephen Rothwell wrote:
> This s reinforced by the lack of Acked-by, Reviewed-by and Tested-by
> tags ... (the addition of which would presumably require the rebase
> (or rewrite) of a published git tree.)
By the way, I reshuffled my branches recently so t
ACK, and passes my usual tests too for what it's worth.
--b.
On Thu, Aug 14, 2014 at 09:52:40AM -0400, Jeff Layton wrote:
> From: Joe Perches
>
> This argument is always NULL so don't pass it around.
>
> Signed-off-by: Joe Perches
> Signed-off-by: Jeff Layton
> ---
> fs/dlm/plock.c | 8
Please pull nfsd bugfixes from:
git://linux-nfs.org/~bfields/linux.git for-3.18
One regression from the 3.16 xdr rewrite, one an older bug exposed by a
separate bug in the client's new SEEK code.
--b.
----
J. Bruce Fiel
: split nfsd4_callback initialization and use
nfsd: introduce nfsd4_callback_ops
Chuck Lever (1):
sunrpc: fix byte-swapping of displayed XID
J. Bruce Fields (6):
nfsd4: remove obsolete comment
nfsd4: reserve adequate space for LOCK op
SUNRPC: Fix compile on non-x86
On Mon, Oct 06, 2014 at 04:42:52PM -0700, Zach Brown wrote:
> The vfs_fsync_range() call during write processing got the end of the
> range off by one. The range is inclusive, not exclusive. The error has
> nfsd sync more data than requested -- it's correct but unnecessary
> overhead.
>
> The ca
b.
commit 15b23ef5d348
Author: J. Bruce Fields
Date: Wed Sep 24 16:32:34 2014 -0400
nfsd4: fix corruption of NFSv4 read data
The calculation of page_ptr here is wrong in the case the read doesn't
start at an offset that is a multiple of a page.
The
On Wed, Jul 22, 2015 at 05:56:40PM +1000, Dave Chinner wrote:
> On Tue, Jul 21, 2015 at 01:37:21PM -0400, J. Bruce Fields wrote:
> > On Fri, Jul 17, 2015 at 12:47:35PM +1000, Dave Chinner wrote:
> > > On Thu, Jul 16, 2015 at 07:42:03PM -0500, Eric W. Biederman wrote:
> >
On Wed, Jul 22, 2015 at 12:52:58PM -0400, Austin S Hemmelgarn wrote:
> On 2015-07-22 10:09, J. Bruce Fields wrote:
> >On Wed, Jul 22, 2015 at 05:56:40PM +1000, Dave Chinner wrote:
> >>On Tue, Jul 21, 2015 at 01:37:21PM -0400, J. Bruce Fields wrote:
> >>>On Fri, Ju
On Thu, Jul 23, 2015 at 11:51:35AM +1000, Dave Chinner wrote:
> On Wed, Jul 22, 2015 at 01:41:00PM -0400, J. Bruce Fields wrote:
> > On Wed, Jul 22, 2015 at 12:52:58PM -0400, Austin S Hemmelgarn wrote:
> > > On 2015-07-22 10:09, J. Bruce Fields wrote:
> > > >On W
Please pull a few nfsd bugfixes for 4.2 from:
git://linux-nfs.org/~bfields/linux.git for-4.2
--b.
Jeff Layton (1):
nfsd: do nfs4_check_fh in nfs4_check_file instead of nfs4_check_olstateid
Kinglong Mee (2):
nfsd: Dro
On Wed, Aug 05, 2015 at 11:01:53AM +0200, Linus Torvalds wrote:
> On Tue, Aug 4, 2015 at 11:09 PM, J. Bruce Fields wrote:
> > Please pull a few nfsd bugfixes for 4.2 from:
>
> Pulled. However, I wonder if you could start making signed tag pull
> requests. I don't kn
On Wed, Jul 08, 2015 at 02:42:38AM +0100, Al Viro wrote:
> Normally opening a file, unlinking it and then closing will have
> the inode freed upon close() (provided that it's not otherwise busy and
> has no remaining links, of course). However, there's one case where that
> does *not* happen
On Mon, Jul 06, 2015 at 11:30:26AM -0400, Chuck Lever wrote:
> Hi Valentin-
>
>
> On Jul 6, 2015, at 3:36 AM, Valentin Rothberg
> wrote:
>
> > On Mon, Jun 22, 2015 at 9:08 AM, Valentin Rothberg
> > wrote:
> >> Hi Chuck,
> >>
> >> your commit ffe1f0df5862 ("rpcrdma: Merge svcrdma and xprtrdma
d backtrace, so people aren't needlessly alarmed.
> >
> > Also, lets drop the split printk line, since they are grep unfriendly.
> >
> > Cc: "J. Bruce Fields"
> > Cc: linux-...@vger.kernel.org
> > Signed-off-by: Paul Gortmaker
> >
> &
gt; and the associated backtrace, so people aren't needlessly alarmed.
>
> Also, lets drop the split printk line, since they are grep unfriendly.
OK, applying.--b.
>
> Cc: "J. Bruce Fields"
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Paul Gortmaker
>
> diff
Thanks, applying, with:
Cc: sta...@vger.kernel.org
Fixes: 83a712e0afef "sunrpc: add some tracepoints around ..."
(let me know if that's not right.)
--b.
On Thu, Aug 27, 2015 at 10:01:33AM +0530, Pratyush Anand wrote:
> `perf stat -e sunrpc:svc_xprt_do_enqueue true` results in
>
On Wed, Jul 29, 2015 at 09:35:11PM -0400, Trond Myklebust wrote:
> Hi Stephen,
>
> On Wed, Jul 29, 2015 at 9:23 PM, Stephen Rothwell
> wrote:
> > Hi all,
> >
> > Today's linux-next merge of the nfsd tree got a conflict in:
> >
> > fs/nfs/nfs42proc.c
> >
> > between commit:
> >
> > bdcc2cd14e
On Thu, May 05, 2016 at 03:48:16PM -0400, Jeff Layton wrote:
> On Thu, 2016-05-05 at 10:09 +1000, NeilBrown wrote:
> > On Thu, May 05 2016, Dave Chinner wrote:
> >
> > >
> > > On Fri, Apr 29, 2016 at 01:57:43PM +0100, David Howells wrote:
> > > >
> > > > (4) File creation time (st_btime*), data
On Thu, May 05, 2016 at 08:56:02AM +1000, Dave Chinner wrote:
> IMO, exposing the inode generation number to anyone is a potential
> security problem because they are used in file handles.
>
> Most file handles provided by filesystems are simply an encoding of
> the inode number + generation numbe
On Mon, May 09, 2016 at 11:45:43AM +1000, Dave Chinner wrote:
> [ OT, but I'll reply anyway :P ]
>
> On Fri, May 06, 2016 at 02:29:23PM -0400, J. Bruce Fields wrote:
> > On Thu, May 05, 2016 at 08:56:02AM +1000, Dave Chinner wrote:
> > > In the latest XFS filesy
svcrdma: Drain QP before freeing svcrdma_xprt
svcrdma: Eliminate code duplication in svc_rdma_recvfrom()
svcrdma: Generalize svc_rdma_xdr_decode_req()
J. Bruce Fields (2):
Remove unnecessary allocation
svcrpc: autoload rdma module
Jeff Layton (1):
nfsd: handle seqid
open / open upgrade stateids
Andrey Ryabinin (2):
lockd: create NSM handles per net namespace
lockd: get rid of reference-counted NSM RPC clients
Arnd Bergmann (1):
sunrpc: avoid warning in gss_key_timeout
J. Bruce Fields (3):
nfsd: fix clid_inuse on mount with security c
On Tue, Nov 17, 2015 at 07:30:12PM +, Al Viro wrote:
> On Tue, Nov 17, 2015 at 02:02:09PM -0500, Austin S Hemmelgarn wrote:
>
> > >_Static_ attacks, or change-image-under-mounted-fs attacks?
> > To properly protect against attacks on mounted filesystems, we'd
> > need some new concept of a use
cess to a file itelf.
>
> The MAY_DELETE_SELF permission overrides the sticky directory check.
>
Reviewed-by: J. Bruce Fields
> Signed-off-by: Andreas Gruenbacher
> ---
> fs/namei.c | 21 -
> include/linux/fs.h | 2 ++
> 2 files changed,
permissions to the file masks which go
> beyond what the file permission bits can grant (like the
> RICHACE_WRITE_ACL permission). The POSIX.1 standard calls this an
> alternate file access control mechanism. A subsequent chmod() would
> ensure that those permissions are disabled again.
&
includes the requested permissions.
>
> Signed-off-by: Andreas Gruenbacher
> Acked-by: "J. Bruce Fields"
> ---
> fs/Makefile | 2 +-
> fs/richacl_inode.c | 147
>
> include/linux/richacl.h |
On Fri, Sep 11, 2015 at 06:20:30AM -0400, Jeff Layton wrote:
> With NFSv3 nfsd will always attempt to send along WCC data to the
> client. This generally involves saving off the in-core inode information
> prior to doing the operation on the given filehandle, and then issuing a
> vfs_getattr to it
On Fri, Nov 20, 2015 at 04:28:35PM +, David Howells wrote:
> Martin Steigerwald wrote:
>
> > Any plans to add limitations of filesystem to the call like maximum file
> > size? I know its mostly relevant for just for FAT32, but on any account
> > rather than trying to write 4 GiB and then fil
On Mon, Oct 26, 2015 at 03:35:54PM +0900, Neil Brown wrote:
> From c38784b876a181eda9a5687e618749157dc96a0e Mon Sep 17 00:00:00 2001
> From: NeilBrown
> Date: Sat, 25 Jul 2015 10:24:41 +1000
> Subject: [PATCH] Documentation: add new description of path-name lookup.
>
> This document is based on t
On Fri, Jul 17, 2015 at 12:47:35PM +1000, Dave Chinner wrote:
> On Thu, Jul 16, 2015 at 07:42:03PM -0500, Eric W. Biederman wrote:
> > Dave Chinner writes:
> >
> > > On Wed, Jul 15, 2015 at 11:47:08PM -0500, Eric W. Biederman wrote:
> > >> Casey Schaufler writes:
> > >> > On 7/15/2015 6:08 PM, A
On Sun, Jan 03, 2016 at 09:53:20PM -0500, Doug Ledford wrote:
> On 01/03/2016 08:44 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > On Thu, 31 Dec 2015 13:30:22 +1100 Stephen Rothwell
> > wrote:
> >>
> >> Hi Doug,
> >>
> >> Today's linux-next merge of the rdma tree got conflicts in a quite a
> >
On Fri, Jan 01, 2016 at 10:06:29PM +0800, Geliang Tang wrote:
> Use to_delayed_work() instead of open-coding it.
Thanks, applying 2/3 and 3/3 for 4.5.--b.
>
> Signed-off-by: Geliang Tang
> ---
> fs/lockd/svc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/lockd
On Wed, Dec 23, 2015 at 10:25:13PM +0100, Julia Lawall wrote:
> The nlmsvc_binding structure is never modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
>
> ---
>
> This assumes that whoever takes advantage of the EXPORT_SYMBOL will also
> n
to copy it
> from an old machine every time, because it will just be there with the
> kernel source tree (and without a kernel source tree it's not needed).
>
> Linus
>
> On Wed, Jul 10, 2013 at 1:54 PM, J. Bruce Fields wrote:
> >
> > I run this by h
On Tue, Feb 23, 2016 at 10:55:30AM +0800, Ian Kent wrote:
> You know, wrt. the mechanism Oleg suggested, I've been wondering if it's
> even necessary to capture process template information for execution.
>
> Isn't the main issue the execution of unknown arbitrary objects getting
> access to a pri
Please pull an nfsd bugfix for 4.5 from
git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.5-1
One fix for a bug that could cause a NULL write past the end of a buffer
in case of unusually long writes to some system interfaces used by
mountd and other nfs support utilities.
--b.
Stefan Hajnoc
On Wed, Nov 19, 2014 at 08:04:11AM +1100, Stephen Rothwell wrote:
> Hi,
>
> I just noticed that the top commit of the nfsd tree (be603bbb7bc1
> "OOPS") has no Signed-off-by tags (or a real commit message at all) ...
Yes, sorry, I needed it as a temporary fix for a client-side bug (since
gone upst
Please pull the following nfsd bugfixes for 3.18:
git://linux-nfs.org/~bfields/linux.git for-3.18
These fix one mishandling of the case when security labels are
configured out, and two races in the 4.1 backchannel code.
--b.
Chr
On Wed, Nov 26, 2014 at 09:00:11AM -0600, Eric W. Biederman wrote:
> David Howells writes:
>
> > Eric W. Biederman wrote:
> >
> >> Ian if we were to merge this I believe you would win the award for
> >> easiest path to a root shell.
> >
> > Is there any particular reason the upcalled program has
On Fri, Apr 24, 2015 at 01:04:11PM +0200, Andreas Gruenbacher wrote:
> A richacl grants a requested access if the NFSv4 acl in the richacl
> grants the requested permissions (according to the NFSv4 permission
> check algorithm) and the file mask that applies to the process
> includes the requested
On Fri, Apr 24, 2015 at 01:04:26PM +0200, Andreas Gruenbacher wrote:
> Put all the pieces of the acl transformation puzzle together for
> computing a richacl which has the file masks "applied" so that the
> standard nfsv4 access check algorithm can be used on the richacl.
>
> Signed-off-by: Andrea
Looks fine to me.
>From a quick check of
git://github.com/andreas-gruenbacher/richacl.git
it looks like the userspace is all done too?
Do we have wireshark patches?
On Fri, Apr 24, 2015 at 01:04:17PM +0200, Andreas Gruenbacher wrote:
> Automatic Inheritance (AI) allows changes to the a
On Fri, Apr 24, 2015 at 01:04:16PM +0200, Andreas Gruenbacher wrote:
> So far, richacl_equiv_mode() is relatively limited in the types of acl it
> considers equivalent to a file mode: it only accepts masked acls with a single
> everyone@:rwpxd::allow entry.
>
> Change this to consider all acls equ
On Thu, May 14, 2015 at 03:28:06PM -0400, bfields wrote:
> On Fri, Apr 24, 2015 at 01:04:16PM +0200, Andreas Gruenbacher wrote:
> > So far, richacl_equiv_mode() is relatively limited in the types of acl it
> > considers equivalent to a file mode: it only accepts masked acls with a
> > single
> > e
901 - 1000 of 1455 matches
Mail list logo
