Re: [PATCH 01/13] vfs: add i_op->open()

2012-08-15 Thread J. Bruce Fields
On Wed, Aug 15, 2012 at 05:48:08PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > Add a new inode operation i_op->open(). This is for stacked Shouldn't that "->open()" be "->dentry_open()" ? --b. > filesystems that want to return a struct file from a different > filesystem. > > Sign

Re: [PATCH 07/13] overlay: overlay filesystem documentation

2012-08-15 Thread J. Bruce Fields
Sorry, just trivial typos: On Wed, Aug 15, 2012 at 05:48:14PM +0200, Miklos Szeredi wrote: > +Directories > +--- > + > +Overlaying mainly involved directories. If a given name appears in both s/involved/involves/. > +Non-standard behavior > +- > + > +The copy_up oper

Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper

2012-08-15 Thread J. Bruce Fields
On Wed, Aug 15, 2012 at 01:21:20PM +0400, Cyrill Gorcunov wrote: > To provide fsnotify object inodes being watched without > binding to alphabetical path we need to encode them with > exportfs help. This patch adds a helper which operates > with plain inodes directly. I don't get it--this seems li

Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper

2012-08-15 Thread J. Bruce Fields
On Thu, Aug 16, 2012 at 01:02:37AM +0400, Cyrill Gorcunov wrote: > On Wed, Aug 15, 2012 at 04:45:46PM -0400, J. Bruce Fields wrote: > > On Wed, Aug 15, 2012 at 01:21:20PM +0400, Cyrill Gorcunov wrote: > > > To provide fsnotify object inodes being watched without > > > b

Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper

2012-08-16 Thread J. Bruce Fields
On Thu, Aug 16, 2012 at 04:38:14PM +0400, Cyrill Gorcunov wrote: > On Thu, Aug 16, 2012 at 10:24:48AM +0400, Cyrill Gorcunov wrote: > > > > > On the other hand, if you want a real filehandle then wouldn't you > > > > > want > > > > > to e.g. call the filesystem's ->encode_fh() if necessary, as > >

Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced

2012-08-16 Thread J. Bruce Fields
On Wed, Aug 15, 2012 at 08:03:24PM -0700, Eric W. Biederman wrote: > Stanislav Kinsbursky writes: > > > This patch set introduces new socket operation and new system call: > > sys_fbind(), which allows to bind socket to opened file. > > File to bind to can be created by sys_mknod(S_IFSOCK) and op

Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper

2012-08-16 Thread J. Bruce Fields
On Thu, Aug 16, 2012 at 06:48:35PM +0400, Cyrill Gorcunov wrote: > On Thu, Aug 16, 2012 at 03:41:52PM +0100, Al Viro wrote: > > On Thu, Aug 16, 2012 at 06:15:53PM +0400, Cyrill Gorcunov wrote: > > > On Thu, Aug 16, 2012 at 02:03:00PM +, James Bottomley wrote: > > > > > > What's wrong with sayin

Re: [PATCH] knfsd: Remove NLM_HOST_MAX and associated logic.

2008-02-07 Thread J. Bruce Fields
On Fri, Feb 08, 2008 at 01:03:37PM +1100, NeilBrown wrote: > > Lockd caches information about hosts that have recently held locks it > expedite the taking of further locks. Applied, thanks!--b. > > It periodically discards this information for hosts that have not been > used for a few minutes.

Re: [PATCH] SUNPRC: Fix printk format warning

2008-02-10 Thread J. Bruce Fields
On Fri, Feb 08, 2008 at 04:02:04PM -0800, Roland Dreier wrote: > net/sunrpc/xprtrdma/svc_rdma_sendto.c:160: warning: format '%llx' expects > type 'long long unsigned int', but argument 3 has type 'u64' OK, thanks. Applied (with the long line split). --b. > > Signed-off-by: Roland Dreier <[EMA

nfsd fixes for 2.6.25

2008-02-10 Thread J. Bruce Fields
. Bruce Fields (1): nfsd: clean up svc_reserve_auth() Jeff Layton (4): NLM: set RPC_CLNT_CREATE_NOPING for NLM RPC clients NLM: have server-side RPC clients default to soft RPC tasks NLM: don't reattempt GRANT_MSG when there is already an RPC in flight NLM: don'

[PATCH] Documentation: prune redundant SubmitChecklist items

2008-02-10 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> Kernel style is mentioned twice, and the git apply trick is a bit redundant given the checkpatch.pl recommendation (which also checks for bad whitespace). Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> --- Documentation/SubmitChec

Re: Remove easily user-triggerable BUG from generic_setlease

2012-07-23 Thread J. Bruce Fields
fixes the bug for >=3.2, but before the addition of this BUG() we could get memory corruption in this case. And that problem existed since the original introduction of the lease code, as far as I can tell. So we need something like the following, backported to 2.6.anything. --b. commit 76fca5

Re: Remove easily user-triggerable BUG from generic_setlease

2012-07-23 Thread J. Bruce Fields
On Mon, Jul 23, 2012 at 11:34:56AM -0700, Linus Torvalds wrote: > On Mon, Jul 23, 2012 at 8:20 AM, J. Bruce Fields wrote: > > > > So we need something like the following, backported to 2.6.anything. > > Please add a note about the 3.2+ version of this patch (well, totally &g

[PATCH] locks: fix checking of fcntl_setlease argument

2012-07-23 Thread J. Bruce Fields
nes's 8d657eb3b43861064d36241e88d9d61c709f33f0 "Remove easily user-triggerable BUG from generic_setlease", but we should fix this anyway. And this patch will be necessary to fix real bugs on earlier kernels.) Cc: sta...@vger.kernel.org Signed-off-by: J. Bruce Fields --- fs/locks.c |6 +++--- 1 file changed

Re: [PATCH] nfs-util: Add cache_flush in mountd UMNT procedure.

2012-07-24 Thread J. Bruce Fields
On Thu, Jul 12, 2012 at 07:43:49AM +0900, Namjae Jeon wrote: > 2012/7/12, Namjae Jeon : > > 2012/7/11, J. Bruce Fields : > >> On Wed, Jul 11, 2012 at 01:10:53PM +0900, Namjae Jeon wrote: > >>> 2012/7/10, J. Bruce Fields : > >>> > On Sat, Jul 07

Re: [PATCH] nfsd4: fix cr_principal comparison check in same_creds

2012-07-24 Thread J. Bruce Fields
On Tue, Jul 24, 2012 at 09:18:20PM +0530, Vivek Trivedi wrote: > This fixes a wrong check for same cr_principal in same_creds Thanks for the fix. Looks like I introduced that with 8fbba96e5b327665265ad02b7f331b68536828bf "nfsd4: stricter cred comparison for setclientid/exchange_id". Queuing for

Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-07-24 Thread J. Bruce Fields
On Tue, Jul 03, 2012 at 04:58:57PM +0400, Stanislav Kinsbursky wrote: > v3: > 1) rebased on 3.5-rc3 kernel. > > v2: destruction of currently processing transport added: > 1) Added marking of currently processing transports with XPT_CLOSE on per-net > shutdown. These transports will be destroyed in

Re: [PATCH v3 03/11] NFS: move per-net callback thread initialization to nfs_callback_up_net()

2012-07-24 Thread J. Bruce Fields
On Tue, Jul 03, 2012 at 08:19:46PM +0400, Stanislav Kinsbursky wrote: > This new function in now called before nfs_minorversion_callback_svc_setup()). > > Also few small changes: > 1) current network namespace in nfs_callback_up() was replaced by transport > net. > 2) svc_shutdown_net() was moved

Re: [PATCH v3 00/11] Series short description

2012-07-24 Thread J. Bruce Fields
On Tue, Jul 03, 2012 at 08:19:23PM +0400, Stanislav Kinsbursky wrote: > v3: Rebased on Bruce's tree, "for-3.6" branch > > v2: Rebased on Bruce's tree, "for-3.5" branch Aside from the one question, this looks OK to me. I seem to recall this needed to go through my tree for some reason, but does T

Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-08-16 Thread J. Bruce Fields
On Tue, Jul 24, 2012 at 03:40:37PM -0400, J. Bruce Fields wrote: > On Tue, Jul 03, 2012 at 04:58:57PM +0400, Stanislav Kinsbursky wrote: > > v3: > > 1) rebased on 3.5-rc3 kernel. > > > > v2: destruction of currently processing transport added: > > 1) Adde

Re: v3.5 nfsd4 regression; utime sometimes takes 40+ seconds to return

2012-08-16 Thread J. Bruce Fields
On Thu, Aug 16, 2012 at 08:18:38PM +, Jamie Heilman wrote: > J. Bruce Fields wrote: > > On Wed, Aug 15, 2012 at 01:58:54PM +, Jamie Heilman wrote: > > > Jamie Heilman wrote: > > > > I'll try to get full rcpdebug traces on client and server as the delay &g

Re: v3.5 nfsd4 regression; utime sometimes takes 40+ seconds to return

2012-08-16 Thread J. Bruce Fields
On Thu, Aug 16, 2012 at 04:42:08PM -0400, J. Bruce Fields wrote: > Hm, weird. In the good case the cb_recall's done with auth_unix, in the > bad case with auth_null. OK, that should be enough to go on > > Thanks for digging into this! This should fix it--could you confi

Re: v3.5 nfsd4 regression; utime sometimes takes 40+ seconds to return

2012-08-17 Thread J. Bruce Fields
On Thu, Aug 16, 2012 at 09:34:24PM +, Jamie Heilman wrote: > J. Bruce Fields wrote: > > On Thu, Aug 16, 2012 at 04:42:08PM -0400, J. Bruce Fields wrote: > > > Hm, weird. In the good case the cb_recall's done with auth_unix, in the > > > bad case with auth_nul

Re: 3.0+ NFS issues (bisected)

2012-08-17 Thread J. Bruce Fields
On Fri, Aug 17, 2012 at 05:56:56AM +0400, Michael Tokarev wrote: > On 12.07.2012 16:53, J. Bruce Fields wrote: > > On Tue, Jul 10, 2012 at 04:52:03PM +0400, Michael Tokarev wrote: > >> I tried to debug this again, maybe to reproduce in a virtual machine, > >> and foun

Re: 3.0+ NFS issues (bisected)

2012-08-17 Thread J. Bruce Fields
On Fri, Aug 17, 2012 at 10:56:16AM -0400, J. Bruce Fields wrote: > On Fri, Aug 17, 2012 at 05:56:56AM +0400, Michael Tokarev wrote: > > On 12.07.2012 16:53, J. Bruce Fields wrote: > > > On Tue, Jul 10, 2012 at 04:52:03PM +0400, Michael Tokarev wrote: > > >> I tried

Re: 3.0+ NFS issues (bisected)

2012-08-17 Thread J. Bruce Fields
On Fri, Aug 17, 2012 at 09:12:38PM +0400, Michael Tokarev wrote: > On 17.08.2012 20:00, J. Bruce Fields wrote: > []> Uh, if I grepped my way through this right: it looks like it's the > > "memory" column of the "TCP" row of /proc/net/protocols; might be &g

Re: 3.0+ NFS issues (bisected)

2012-08-17 Thread J. Bruce Fields
On Fri, Aug 17, 2012 at 09:29:40PM +0400, Michael Tokarev wrote: > On 17.08.2012 21:26, Michael Tokarev wrote: > > On 17.08.2012 21:18, J. Bruce Fields wrote: > >> On Fri, Aug 17, 2012 at 09:12:38PM +0400, Michael Tokarev wrote: > > [] > >>> So we're

Re: 3.0+ NFS issues (bisected)

2012-08-17 Thread J. Bruce Fields
On Fri, Aug 17, 2012 at 03:18:00PM -0400, J. Bruce Fields wrote: > On Fri, Aug 17, 2012 at 09:29:40PM +0400, Michael Tokarev wrote: > > On 17.08.2012 21:26, Michael Tokarev wrote: > > > On 17.08.2012 21:18, J. Bruce Fields wrote: > > >> On Fri, Aug 17, 2012 at 09:

Re: 3.0+ NFS issues (bisected)

2012-08-17 Thread J. Bruce Fields
On Fri, Aug 17, 2012 at 04:08:07PM -0400, J. Bruce Fields wrote: > Wait a minute, that assumption's a problem because that calculation > depends in part on xpt_reserved, which is changed here > > In particular, svc_xprt_release() calls svc_reserve(rqstp, 0), which

Re: 3.0+ NFS issues (bisected)

2012-08-18 Thread J. Bruce Fields
On Sat, Aug 18, 2012 at 10:49:31AM +0400, Michael Tokarev wrote: > On 18.08.2012 02:32, J. Bruce Fields wrote: > > On Fri, Aug 17, 2012 at 04:08:07PM -0400, J. Bruce Fields wrote: > >> Wait a minute, that assumption's a problem because that calculation > >> depend

Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-08-20 Thread J. Bruce Fields
On Mon, Aug 20, 2012 at 03:05:49PM +0400, Stanislav Kinsbursky wrote: > 16.08.2012 23:29, J. Bruce Fields пишет: > >Looking back at this: > > > > - adding the sv_lock looks like the right thing to do anyway > > independent of containers, because svc_age_temp_x

Re: [ 00/46] 3.5.3-stable review

2012-08-20 Thread J. Bruce Fields
On Mon, Aug 20, 2012 at 07:46:13AM -0700, Greg KH wrote: > On Mon, Aug 20, 2012 at 10:26:25AM +0200, Holger Hoffstaette wrote: > > (CC: J. Bruce Fields) > > > > Greg, > > > > it looks like a fix for a regression in NFS is not mentioned in this > > patc

Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-08-20 Thread J. Bruce Fields
On Mon, Aug 20, 2012 at 07:11:00PM +0400, Stanislav Kinsbursky wrote: > 20.08.2012 18:56, J. Bruce Fields пишет: > >On Mon, Aug 20, 2012 at 03:05:49PM +0400, Stanislav Kinsbursky wrote: > >>16.08.2012 23:29, J. Bruce Fields пишет: > >>>Looking back at this: > >&

Re: [PATCH 3/3] writeback: add dirty_ratio_time per bdi variable (NFS write performance)

2012-08-20 Thread J. Bruce Fields
On Mon, Aug 20, 2012 at 12:00:04PM +1000, Dave Chinner wrote: > On Sun, Aug 19, 2012 at 10:57:24AM +0800, Fengguang Wu wrote: > > On Sat, Aug 18, 2012 at 05:50:02AM -0400, Namjae Jeon wrote: > > > From: Namjae Jeon > > > > > > This patch is based on suggestion by Wu Fengguang: > > > https://lkml.

Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper

2012-08-20 Thread J. Bruce Fields
On Mon, Aug 20, 2012 at 08:33:38PM +0400, Cyrill Gorcunov wrote: > On Mon, Aug 20, 2012 at 07:49:23PM +0530, Aneesh Kumar K.V wrote: > > Cyrill Gorcunov writes: > > > > > To provide fsnotify object inodes being watched without > > > binding to alphabetical path we need to encode them with > > > e

Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper

2012-08-20 Thread J. Bruce Fields
On Mon, Aug 20, 2012 at 11:06:06PM +0400, Cyrill Gorcunov wrote: > On Mon, Aug 20, 2012 at 02:32:25PM -0400, J. Bruce Fields wrote: > > On Mon, Aug 20, 2012 at 08:33:38PM +0400, Cyrill Gorcunov wrote: > > > On Mon, Aug 20, 2012 at 07:49:23PM +0530, Aneesh Kumar K.V wrote: >

Re: [PATCH 0/4] fat: fix ESTALE errors

2012-08-20 Thread J. Bruce Fields
On Mon, Aug 20, 2012 at 01:19:51PM +0900, Namjae Jeon wrote: > 2012/8/18, OGAWA Hirofumi : > > Al Viro writes: > > > >> On Sat, Aug 18, 2012 at 05:41:39AM -0400, Namjae Jeon wrote: > >>> From: Namjae Jeon > >>> > >>> This patch-set eliminates the client side ESTALE errors when > >>> a FAT partiti

Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper

2012-08-21 Thread J. Bruce Fields
On Tue, Aug 21, 2012 at 02:49:47PM +0400, Pavel Emelyanov wrote: > On 08/21/2012 02:42 PM, Aneesh Kumar K.V wrote: > > Pavel Emelyanov writes: > > > >> On 08/20/2012 11:32 PM, J. Bruce Fields wrote: > >>> On Mon, Aug 20, 2012 at 11:06:06PM +0400, Cyrill G

Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper

2012-08-21 Thread J. Bruce Fields
On Tue, Aug 21, 2012 at 03:09:05PM +0400, Pavel Emelyanov wrote: > On 08/21/2012 02:54 PM, Cyrill Gorcunov wrote: > > On Tue, Aug 21, 2012 at 02:49:47PM +0400, Pavel Emelyanov wrote: > > However, if you have some better ideas on what information about inode > should be exported > >>

Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-08-21 Thread J. Bruce Fields
On Tue, Aug 21, 2012 at 01:28:00PM +0400, Stanislav Kinsbursky wrote: > 20.08.2012 20:58, J. Bruce Fields пишет: > >On Mon, Aug 20, 2012 at 07:11:00PM +0400, Stanislav Kinsbursky wrote: > >>Currently, when you call kthread_create(), you add new job to > >>kthreadd queue.

Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper

2012-08-21 Thread J. Bruce Fields
On Tue, Aug 21, 2012 at 04:22:31PM +0400, Pavel Emelyanov wrote: > On 08/21/2012 04:11 PM, J. Bruce Fields wrote: > > On Tue, Aug 21, 2012 at 03:09:05PM +0400, Pavel Emelyanov wrote: > >> On 08/21/2012 02:54 PM, Cyrill Gorcunov wrote: > >>> On Tue, Aug 21, 2012 at 02:

Re: [PATCH] nfs-util: Add cache_flush in mountd UMNT procedure.

2012-07-10 Thread J. Bruce Fields
On Sat, Jul 07, 2012 at 11:17:39PM -0400, Namjae Jeon wrote: > For removing storage device - user needs to safely un-mount the device > and then eject. But if 'EBUSY' occurs in umount then it will create > confusion for the user as it will mean some I/O is in progress - and > won't allow user to sa

Re: [PATCH] [RFC] nfsd: fix possible dereference of static NULL nfsd_serv pointer

2012-07-10 Thread J. Bruce Fields
On Sat, Jul 07, 2012 at 09:27:30AM +0400, Stanislav Kinsbursky wrote: > 06.07.2012 21:26, J. Bruce Fields пишет: > >On Fri, Jul 06, 2012 at 05:45:56PM +0400, Stanislav Kinsbursky wrote: > >>This is a bug fix for 3.5 kernel. > >>In case on NFSd service start failure s

Re: [PATCH 2/2,resend] sunrpc/cache.h: replace simple_strtoul

2012-07-10 Thread J. Bruce Fields
variable rv, since kstrtoint() will not write to > anint unless it's successful. > > Cc: Joe Perches > Signed-off-by: Eldad Zack > --- > Resent to include improvements from Joe Perches and proper changelog as > J. Bruce Fields kindly pointed out. > include/linux/sunrpc/

Re: [PATCH] nfs-util: Add cache_flush in mountd UMNT procedure.

2012-07-11 Thread J. Bruce Fields
On Wed, Jul 11, 2012 at 01:10:53PM +0900, Namjae Jeon wrote: > 2012/7/10, J. Bruce Fields : > > On Sat, Jul 07, 2012 at 11:17:39PM -0400, Namjae Jeon wrote: > >> For removing storage device - user needs to safely un-mount the device > >> and then eject. But if 'EBUS

Re: 3.0+ NFS issues

2012-07-12 Thread J. Bruce Fields
On Tue, Jul 10, 2012 at 04:52:03PM +0400, Michael Tokarev wrote: > I tried to debug this again, maybe to reproduce in a virtual machine, > and found out that it is only 32bit server code shows this issue: > after updating the kernel on the server to 64bit (the same version) > I can't reproduce this

Re: [PATCH v2] NFSd: fix locking in nfsd_forget_delegations()

2012-07-12 Thread J. Bruce Fields
On Fri, May 25, 2012 at 06:38:50PM +0400, Stanislav Kinsbursky wrote: > v2: dl_recall_lru list is used for delegations collect because it's modified > both in unhash_delegation() and nfsd_break_one_deleg(). > > This patch adds recall_lock hold to nfsd_forget_delegations() to protect > nfsd_process

Re: [PATCH 1/2] kstrto*: add documentation

2012-07-12 Thread J. Bruce Fields
On Thu, Jul 12, 2012 at 10:53:13PM +0200, Eldad Zack wrote: > As J. Bruce Fields pointed out, kstrto* is > currently lacking kerneldoc comments. > This patch adds kerneldoc comments to common variants of kstrto*: > kstrto(u)l, kstrto(u)ll and kstrto(u)int. > > Cc: J. Bruce Fi

Re: [PATCH 1/2] kstrto*: add documentation

2012-07-12 Thread J. Bruce Fields
On Fri, Jul 13, 2012 at 12:09:37AM +0200, Eldad Zack wrote: > > On Thu, 12 Jul 2012, J. Bruce Fields wrote: > > On Thu, Jul 12, 2012 at 10:53:13PM +0200, Eldad Zack wrote: > > > +/** > > > + * kstrtoul - convert a string to an unsigned long > > > > Also,

Re: [PATCH review 48/85] sunrpc: Update gss uid to security context mapping.

2013-02-13 Thread J. Bruce Fields
On Wed, Feb 13, 2013 at 09:51:37AM -0800, Eric W. Biederman wrote: > From: "Eric W. Biederman" > > - Use from_kuid when generating the on the wire uid values. > - Use make_kuid when reading on the wire values. > > In gss_encode_v0_msg, since the uid in gss_upcall_msg is now a kuid_t > generate t

Re: [PATCH review 52/85] sunrpc: Properly encode kuids and kgids in auth.unix.gid rpc pipe upcalls.

2013-02-13 Thread J. Bruce Fields
ective. All of these caches are already per-network-namespace. Ideally wouldn't we also like to associate a user namespace with each cache somehow? --b. > > Cc: "J. Bruce Fields" > Cc: Trond Myklebust > Signed-off-by: "Eric W. Biederman" > --- > net/s

Re: [PATCH review 48/85] sunrpc: Update gss uid to security context mapping.

2013-02-13 Thread J. Bruce Fields
On Wed, Feb 13, 2013 at 01:17:37PM -0800, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > On Wed, Feb 13, 2013 at 09:51:37AM -0800, Eric W. Biederman wrote: > >> From: "Eric W. Biederman" > >> > >> - Use from_kuid when gener

Re: [PATCH review 52/85] sunrpc: Properly encode kuids and kgids in auth.unix.gid rpc pipe upcalls.

2013-02-13 Thread J. Bruce Fields
On Wed, Feb 13, 2013 at 01:29:35PM -0800, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > On Wed, Feb 13, 2013 at 09:51:41AM -0800, Eric W. Biederman wrote: > >> From: "Eric W. Biederman" > >> > >> When a new rpc connectio

Re: [PATCH review 52/85] sunrpc: Properly encode kuids and kgids in auth.unix.gid rpc pipe upcalls.

2013-02-13 Thread J. Bruce Fields
On Wed, Feb 13, 2013 at 02:32:29PM -0800, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > On Wed, Feb 13, 2013 at 01:29:35PM -0800, Eric W. Biederman wrote: > >> "J. Bruce Fields" writes: > >> > >> > On Wed, Feb 13, 2

Re: [PATCH v2 0/4] nfsd: make is works in a container

2013-02-15 Thread J. Bruce Fields
On Fri, Feb 01, 2013 at 03:56:05PM +0300, Stanislav Kinsbursky wrote: > This patch set finally enables NFSd in container. > I've tested it in container with it's own root, and also pid, net and mount > namespaces. Thanks, these look fine to me; applying. They should show up in my for-3.9 branch s

Re: [PATCH linux-next v2] lockd: nlmclnt_reclaim(): avoid stack overflow

2013-02-15 Thread J. Bruce Fields
; > 928 bytes on stack > > > > Also remove redundant assignment of 0 after memset. > > > > Cc: Trond Myklebust > > Cc: "J. Bruce Fields" > > Cc: linux-...@vger.kernel.org > > Signed-off-by: Tim Gardner > > --- > > > >

Re: [PATCH review 52/85] sunrpc: Properly encode kuids and kgids in auth.unix.gid rpc pipe upcalls.

2013-02-15 Thread J. Bruce Fields
On Wed, Feb 13, 2013 at 03:22:32PM -0800, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > On Wed, Feb 13, 2013 at 02:32:29PM -0800, Eric W. Biederman wrote: > >> Now looking at the nfs server, seems to be hard coded to only start > >> in the

Re: BUG at net/sunrpc/svc_xprt.c:921 (another one)

2013-02-15 Thread J. Bruce Fields
On Wed, Feb 13, 2013 at 10:00:58AM -0500, Mark Lord wrote: > On 13-02-12 03:52 PM, J. Bruce Fields wrote: > > On Sun, Jan 20, 2013 at 05:51:12PM -0500, Mark Lord wrote: > >> Got it again, this time on a different system > >> running mostly the same software. > > &

[PATCH 1/2] svcrpc: make svc_age_temp_xprts enqueue under sv_lock

2013-02-15 Thread J. Bruce Fields
take sp_lock, but the sv_lock and sp_lock are not otherwise nested anywhere (and documentation at the top of this file claims it's correct to nest these with sp_lock inside.) Cc: sta...@kernel.org Tested-by: Jason Tibbitts Signed-off-by: J. Bruce Fields --- net/sunrpc/svc_xprt.c |

[PATCH 2/2] svcrpc: fix rpc server shutdown races

2013-02-15 Thread J. Bruce Fields
-off-by: J. Bruce Fields --- net/sunrpc/svc.c |9 net/sunrpc/svc_xprt.c | 57 +++-- 2 files changed, 32 insertions(+), 34 deletions(-) diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index b9ba2a8..89a588b 100644 --- a/net/sunrpc/svc.c

Re: BUG at net/sunrpc/svc_xprt.c:921 (another one)

2013-02-15 Thread J. Bruce Fields
On Fri, Feb 15, 2013 at 02:42:08PM -0500, Tom Horsley wrote: > On Fri, 15 Feb 2013 14:22:29 -0500 > J. Bruce Fields wrote: > > > Any more reports positive or negative welcome. > > Well, I don't have the time or energy to try patches on my > system at work, but th

Re: BUG at net/sunrpc/svc_xprt.c:921 (another one)

2013-02-17 Thread J. Bruce Fields
On Fri, Feb 15, 2013 at 08:33:14PM +0100, Paweł Sikora wrote: > On Tuesday 12 of February 2013 15:52:17 J. Bruce Fields wrote: > > On Sun, Jan 20, 2013 at 05:51:12PM -0500, Mark Lord wrote: > > > Got it again, this time on a different system > > > running mostly the s

please pull nfsd changes for 3.7

2012-10-12 Thread J. Bruce Fields
king progress). --b. Bryan Schumaker (1): NFSD: Swap the struct nfs4_operation getter and setter David Howells (2): UAPI: (Scripted) Disintegrate include/linux/nfsd UAPI: (Scripted) Disintegrate include/linux/sunrpc J. Bruce Fields (38): nfsd4: nfsaclsvc_encode_voidres static

Re: CONFIG_INTEL_IDLE causing crashes?

2012-10-16 Thread J. Bruce Fields
On Fri, Oct 05, 2012 at 06:23:57PM -0400, bfields wrote: > I find that I can reliably crash 3.6 by booting to a kernel with > CONFIG_INTEL_IDLE set and running > > dd if=/dev/zero of=BIG For any archives: see further discussion at https://bugzilla.redhat.com/show_bug.cgi?id=715485

Re: [RFC PATCH v2 00/15] NFSd state containerization

2012-11-21 Thread J. Bruce Fields
On Thu, Nov 15, 2012 at 01:34:08PM -0500, Jeff Layton wrote: > On Wed, 14 Nov 2012 17:00:36 -0500 > "J. Bruce Fields" wrote: > > > On Wed, Nov 14, 2012 at 06:20:59PM +0300, Stanislav Kinsbursky wrote: > > > This patch set is my first attempt to containerize

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2013-01-11 Thread J. Bruce Fields
On Fri, Jan 11, 2013 at 06:56:58PM +0400, Stanislav Kinsbursky wrote: > 11.12.2012 19:35, J. Bruce Fields пишет: > >On Tue, Dec 11, 2012 at 10:20:36AM -0500, J. Bruce Fields wrote: > >>On Tue, Dec 11, 2012 at 07:07:00PM +0400, Stanislav Kinsbursky wrote: > >>>

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2013-01-11 Thread J. Bruce Fields
On Fri, Jan 11, 2013 at 12:03:12PM -0500, J. Bruce Fields wrote: > On Fri, Jan 11, 2013 at 06:56:58PM +0400, Stanislav Kinsbursky wrote: > > 11.12.2012 19:35, J. Bruce Fields пишет: > > >On Tue, Dec 11, 2012 at 10:20:36AM -0500, J. Bruce Fields wrote: > > >>On Tue, De

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-14 Thread J. Bruce Fields
Thanks for the report. On Mon, Jan 14, 2013 at 11:17:09AM -0500, Mark Lord wrote: > Since upgrading to 3.7, and now 3.7.2, my AMD-450E based server It's acting as an NFS client, right? What did you upgrade from? > is getting these BUG complaints. The .config file is gzip'd/attached. Is this e

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-15 Thread J. Bruce Fields
On Mon, Jan 14, 2013 at 11:16:00PM -0500, Mark Lord wrote: > On 13-01-14 03:37 PM, J. Bruce Fields wrote: > > Thanks for the report. > > > > On Mon, Jan 14, 2013 at 11:17:09AM -0500, Mark Lord wrote: > >> Since upgrading to 3.7, and now 3.7.2, my AMD-450E based ser

Re: [PATCH 0/3] Add O_DENY* flags to fcntl and cifs

2012-12-17 Thread J. Bruce Fields
On Fri, Dec 14, 2012 at 01:19:18PM -0600, Steve French wrote: > On Fri, Dec 14, 2012 at 9:30 AM, Alan Cox wrote: > >> We can make this feature (passing O_DENY* flags received from clients > >> to filesystem) can be turned on/off on Samba/NFS server to let this > >> particular use case work. In gen

Re: [REGRESSION] nfsd crashing with 3.6.0-rc7 on PowerPC

2012-09-28 Thread J. Bruce Fields
On Fri, Sep 28, 2012 at 04:19:55AM +0200, Alexander Graf wrote: > > On 28.09.2012, at 04:04, Linus Torvalds wrote: > > > On Thu, Sep 27, 2012 at 6:55 PM, Alexander Graf wrote: > >> > >> Below are OOPS excerpts from different rc's I tried. All of them crashed - > >> all the way up to current Li

Re: [REGRESSION] nfsd crashing with 3.6.0-rc7 on PowerPC

2012-10-01 Thread J. Bruce Fields
On Mon, Oct 01, 2012 at 04:03:06PM +0200, Alexander Graf wrote: > > On 28.09.2012, at 17:10, J. Bruce Fields wrote: > > > On Fri, Sep 28, 2012 at 04:19:55AM +0200, Alexander Graf wrote: > >> > >> On 28.09.2012, at 04:04, Linus Torvalds wrote: > >&

Re: [PATCH 2/2] nfsd: fix compile warning about unused variable 'nn'

2013-01-16 Thread J. Bruce Fields
On Tue, Jan 15, 2013 at 09:43:07AM +0200, Mika Westerberg wrote: > Commit c9a4962881 (nfsd: make client_lock per net) added > lockdep_assert_held() call to function free_client(). However, if lockdep > is disabled we get following compiler warning: > > fs/nfsd/nfs4state.c: In function ‘free_client

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-17 Thread J. Bruce Fields
On Thu, Jan 17, 2013 at 09:05:51AM +0400, Stanislav Kinsbursky wrote: > 17.01.2013 02:51, Mark Lord пишет: > >On 13-01-16 12:20 AM, Stanislav Kinsbursky wrote: > >> > >>Mark, could you provide any call traces? > > > >Call traces from where/what? > >There's this one, posted earlier in the BUG report

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-17 Thread J. Bruce Fields
On Thu, Jan 17, 2013 at 08:11:52AM -0500, Mark Lord wrote: > On 13-01-14 11:17 AM, Mark Lord wrote: > > > > Here's the code with the BUG() at net/sunrpc/svc_xprt.c line 921: > > > > /* > > * Remove a dead transport > > */ > > static void svc_delete_xprt(struct svc_xprt *xprt) > > { > > s

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-18 Thread J. Bruce Fields
On Fri, Jan 18, 2013 at 10:48:02AM -0500, Mark Lord wrote: > On 13-01-18 12:37 AM, Stanislav Kinsbursky wrote: > > > > You have more than one NFS mount in different network namespaces, haven't > > you? > > > > No, I don't (knowingly) use (multiple) namespaces at all. Right, I don't think that's

Re: [PATCH v3] NFSd: set nfsd_serv to NULL after service destruction

2012-07-06 Thread J. Bruce Fields
On Fri, Jul 06, 2012 at 01:09:01PM +0400, Stanislav Kinsbursky wrote: > 06.07.2012 01:21, J. Bruce Fields пишет: > >On Tue, Jul 03, 2012 at 04:46:41PM +0400, Stanislav Kinsbursky wrote: > >>v3: > >>1) Rebased for 3.6 kernel. > >> > >>v2: > >

Re: [PATCH] [RFC] nfsd: fix possible dereference of static NULL nfsd_serv pointer

2012-07-06 Thread J. Bruce Fields
On Fri, Jul 06, 2012 at 05:45:56PM +0400, Stanislav Kinsbursky wrote: > This is a bug fix for 3.5 kernel. > In case on NFSd service start failure svc_shutdown_net() will call svc_destroy > callback and zeroize global nfsd_serv pointer, this in turn will lead to Oops > in svc_destroy(). > > This pa

Re: [PATCH v2 1/1] locks: prevent side-effects of locks_release_private before file_lock is initialized

2012-07-07 Thread J. Bruce Fields
On Thu, Jul 05, 2012 at 06:42:51PM -0400, J. Bruce Fields wrote: > On Tue, Jun 26, 2012 at 09:50:48PM -0400, Filipe Brandenburger wrote: > > When calling fcntl(F_SETLEASE) for a second time on the same file > > descriptor, > > do_fcntl_add_lease will allocate and initiali

Re: "Hangcheck timer elapsed... GPU hung" in 3.8.0-rc2

2013-01-08 Thread J. Bruce Fields
On Sun, Jan 06, 2013 at 07:06:52PM +0100, Daniel Vetter wrote: > On Thu, Jan 03, 2013 at 06:11:23PM -0500, J. Bruce Fields wrote: > > On Thu, Jan 03, 2013 at 04:16:24PM -0500, Josh Boyer wrote: > > > On Thu, Jan 3, 2013 at 3:46 PM, J. Bruce Fields > > > wrote: > &

Re: [PATCH] sunrpc: verbs: Avoid 1kb stack

2013-01-08 Thread J. Bruce Fields
On Mon, Jan 07, 2013 at 11:41:36AM -0800, Joe Perches wrote: > 16 * 64 is a bit much. > Use kmalloc_array instead. I thought there was some reason we didn't do this. Grepping up through the callers It looks like the result is xprt_rdma_send_request returns -EIO, and as far as I can tell that

Re: [PATCH] nfsd: Remove write permission from file content

2013-01-08 Thread J. Bruce Fields
On Sat, Jan 05, 2013 at 12:29:05PM +0800, Yanchuan Nian wrote: > 2013/1/5 J. Bruce Fields > > > On Fri, Jan 04, 2013 at 07:45:35PM +0800, ycn...@gmail.com wrote: > > > From: Yanchuan Nian > > > > > > The write function doesn't be implemented in fil

Re: Commit 7032a3dd9 (svcrpc: demote some printks to a dprintk) adds warnings

2013-01-08 Thread J. Bruce Fields
p. I guess I'll commit the following for 3.9. --b. commit 31e815406973ef86e2e42a36086d65afb8f4e396 Author: J. Bruce Fields Date: Tue Jan 8 16:22:15 2013 -0500 svcrpc: silence "unused variable" warning in !RPC_DEBUG case Signed-off-by: J. Bruce Fields diff --git a/net/sunrpc/sv

Re: [PATCH 1/1] sunrpc: Fix lockd sleeping until timeout

2013-01-08 Thread J. Bruce Fields
spin_unlock_bh(&pool->sp_lock); > + return ERR_PTR(-EAGAIN); > + } > /* No data pending. Go to sleep */ > svc_thread_enqueue(pool, rqstp); > > -- > 1.7.1 > > > On 4 January 2013 02:53, J. Bruce Fie

Re: "Hangcheck timer elapsed... GPU hung" in 3.8.0-rc2

2013-01-09 Thread J. Bruce Fields
On Wed, Jan 09, 2013 at 12:27:22PM +0100, Daniel Vetter wrote: > On Tue, Jan 8, 2013 at 3:37 PM, J. Bruce Fields wrote: > >> please grab the i915_error_state file from debugfs > > > > As I said in the original mail, I've already done that: > > > >

Re: [PATCH] nfsd: fix unused "nn" variable warning in free_client()

2013-01-09 Thread J. Bruce Fields
On Wed, Jan 09, 2013 at 01:39:04PM +0400, Stanislav Kinsbursky wrote: > Bruce, sorry, forgot to add: > > Reported-by: Toralf Förster Thanks, added that, and committing for 3.9.--b. > > 09.01.2013 13:38, Stanislav Kinsbursky пишет: > >If CONFIG_LOCKDEP is disabled, then there would be a warning

Re: fcntl(F GETLEASE) semantics??

2005-08-11 Thread J. Bruce Fields
On Thu, Aug 11, 2005 at 10:06:31AM -0400, Trond Myklebust wrote: > The NFSv4 spec explicitly states that > > When a client has a read open delegation, it may not make any changes > to the contents or attributes of the file but it is assured that no > other client may do so. I don't understa

Re: [PATCH] crypto_free_tfm callers do not need to check for NULL

2005-08-30 Thread J. Bruce Fields
On Tue, Aug 30, 2005 at 10:45:54PM +0200, Jesper Juhl wrote: > Since the patch to add a NULL short-circuit to crypto_free_tfm() went in, > there's no longer any need for callers of that function to check for NULL. ... > Feedback, ACK, NACK, etc welcome. I've no problem with the auth_gss or nfsv4

Re: nfs4 client bug

2005-09-04 Thread J. Bruce Fields
On Sun, Sep 04, 2005 at 01:51:08PM -0700, Bret Towe wrote: > On 9/4/05, Bret Towe <[EMAIL PROTECTED]> wrote: > > On 9/4/05, Francois Romieu <[EMAIL PROTECTED]> wrote: > > > Bret Towe <[EMAIL PROTECTED]> : > > > [...] > > > > after moving some files on the server to a new location then trying to > >

Re: nfs4 client bug

2005-09-04 Thread J. Bruce Fields
On Sun, Sep 04, 2005 at 08:08:22PM -0700, Bret Towe wrote: > On 9/4/05, J. Bruce Fields <[EMAIL PROTECTED]> wrote: > > Do you get anything from alt-sysrq-T? > > no i havent used that im usally in x when its freezing > x wont even switch to console would it still give me a

Re: nfs4 client bug

2005-09-06 Thread J. Bruce Fields
On Mon, Sep 05, 2005 at 08:40:53PM -0700, Bret Towe wrote: > Pid: 14169, comm: xmms Tainted: G M 2.6.13 Hm, can someone explain what that means? A proprietary module was loaded then unloaded, maybe? You may also want to retest with http://www.citi.umich.edu/projects/nfsv4/linux/kernel-patche

Re: nfs4 client bug

2005-09-06 Thread J. Bruce Fields
On Tue, Sep 06, 2005 at 11:21:09AM -0700, Randy.Dunlap wrote: > On Tue, 6 Sep 2005, J. Bruce Fields wrote: > > > On Mon, Sep 05, 2005 at 08:40:53PM -0700, Bret Towe wrote: > > > Pid: 14169, comm: xmms Tainted: G M 2.6.13 > > > > Hm, can someone explain what

Re: 2.6.24-rc6-mm1

2008-01-03 Thread J. Bruce Fields
On Thu, Jan 03, 2008 at 04:37:46PM +0100, Torsten Kaiser wrote: > On Jan 2, 2008 10:57 PM, J. Bruce Fields <[EMAIL PROTECTED]> wrote: > > On Thu, Jan 03, 2008 at 08:51:54AM +1100, Herbert Xu wrote: > > > The two specific trees of interest would be git-nfsd and git-net. &

Re: [PATCH x86] [5/16] Replace hard coded reservations in x86-64 early boot code with dynamic table II

2008-01-04 Thread J. Bruce Fields
On Fri, Jan 04, 2008 at 11:13:14PM +0100, Andi Kleen wrote: > On Friday 04 January 2008 19:47:33 Joe Perches wrote: > > On Fri, 2008-01-04 at 19:06 +0100, Andi Kleen wrote: > > > But the problem with your "rule" is that every of the hundreds > > > of Linux kernel contributors will need to do the sa

Re: [PATCH 0/7] Intro: convert lockd to kthread and fix use-after-free (try #3)

2008-01-05 Thread J. Bruce Fields
On Wed, Dec 19, 2007 at 08:15:43PM +0100, Tomasz Kłoczko wrote: > On Tue, 18 Dec 2007, Jeff Layton wrote: > >> This is the third patchset to fix the use-after-free problem in lockd, >> and to convert lockd to use the kthread API instead of kernel_thread. >> The main change from the last patchset is

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-07 Thread J. Bruce Fields
On Sat, Jan 05, 2008 at 09:39:35PM +, Al Viro wrote: > On Sat, Jan 05, 2008 at 01:06:17PM -0800, Arjan van de Ven wrote: > > The http://www.kerneloops.org website collects kernel oops and > > warning reports from various mailing lists and bugzillas as well as > > with a client users can install

Re: [NFS] NFSv2/3 broken exporting/mounting (permission denied) in 2.6.24-rc4

2007-12-06 Thread J. Bruce Fields
On Thu, Dec 06, 2007 at 09:20:41PM -0500, Erez Zadok wrote: > I get a "permission denied" when trying to mount a localhost nfsv2/3 > exported volume, on v2.6.24-rc4-124-gf194d13. It works w/ nfsv4 mounting. > It worked fine in 2.6.24-rc3. Here's a sequence of ops I tried: > > # mount -t ext2 /de

Re: NFSv2/3 broken exporting/mounting (permission denied) in 2.6.24-rc4

2007-12-07 Thread J. Bruce Fields
On Fri, Dec 07, 2007 at 11:54:38AM +0100, Mikael Pettersson wrote: > On Thu, 6 Dec 2007 21:20:41 -0500, Erez Zadok wrote: > > I get a "permission denied" when trying to mount a localhost nfsv2/3 > > exported volume, on v2.6.24-rc4-124-gf194d13. It works w/ nfsv4 mounting. > > It worked fine in 2.6

Re: [NFS] NFSv2/3 broken exporting/mounting (permission denied) in 2.6.24-rc4

2007-12-07 Thread J. Bruce Fields
On Fri, Dec 07, 2007 at 03:00:13PM -0500, Erez Zadok wrote: > In message <[EMAIL PROTECTED]>, "J. Bruce Fields" writes: > > On Thu, Dec 06, 2007 at 09:20:41PM -0500, Erez Zadok wrote: > > > I get a "permission denied" when trying to mount a localhost n

Re: 2.6.24-rc3-git4 NFS crossmnt regression

2007-12-09 Thread J. Bruce Fields
On Sun, Dec 09, 2007 at 02:20:44AM +0200, Maxim Levitsky wrote: > Due to the fact that I was bitten by this bug (I thought it is a feature), > and a bit of lack > of understanding of NFS4 I want to ask few questions about NFS: > > 1) I want to export whole file-system with submounts to a range o

<    1   2   3   4   5   6   7   8   9   10   >