Re: [PATCH] nfsd: fix bad offset use

2013-03-22 Thread J. Bruce Fields
On Fri, Mar 22, 2013 at 04:53:53PM -0400, J. Bruce Fields wrote: > On Fri, Mar 22, 2013 at 11:18:24AM -0700, Kent Overstreet wrote: > > vfs_writev() updates the offset argument - but the code then passes the > > offset to vfs_fsync_range(). Since offset now points to the offset aft

nfsd bugfixes for 3.9

2013-03-25 Thread J. Bruce Fields
Please pull bugfixes for 3.9 from the for-3.9 branch at: git://linux-nfs.org/~bfields/linux.git for-3.9 Fixes for a couple mistakes in the new DRC code. And thanks to Kent Overstreet for noticing we've been sync'ing the wrong range on stable writes since 3.8. --b. ---

Re: kernel 3.8.4 : kernel BUG at fs/locks.c:2093! part #2

2013-03-25 Thread J. Bruce Fields
On Sun, Mar 24, 2013 at 06:02:39PM +0100, Toralf Förster wrote: > The following bug was triggered twice under a stable 3.8.4 kernel if I export > a NFS (v4) directory > and mount it within a user mode linux (running at the same system) and run > within that UML trinity > (16 UML trinity processes

Re: kernel 3.8.4 : kernel BUG at fs/locks.c:2093! part #2

2013-03-26 Thread J. Bruce Fields
calls synchronous so that we see in the backtrace who called them. (But assuming it does turn out to be one of these callers, we may then need some more printk's in the nfsd code...). --b. commit 27a3395a72e1d9be121f5493e7a330d60b3d1de3 Author: J. Bruce Fields Date: Tue Mar 26 09:37:07

Re: [PATCHSET] idr: implement idr_alloc() and convert existing users

2013-03-26 Thread J. Bruce Fields
On Tue, Mar 26, 2013 at 08:26:53AM -0700, Tejun Heo wrote: > Hello, Jeff. > > On Tue, Mar 26, 2013 at 11:19:36AM -0400, Jeff Layton wrote: > > +/** > > + * idr_alloc_cyclic - allocate new idr entry in a cyclical fashion > > + * @idr: the (initialized) idr > > + * @ptr: pointer to be associated wit

Re: kernel 3.8.4 : kernel BUG at fs/locks.c:2093! part #2

2013-03-26 Thread J. Bruce Fields
On Tue, Mar 26, 2013 at 06:46:31PM +0100, Toralf Förster wrote: > On 03/26/2013 03:46 PM, J. Bruce Fields wrote: > > Can you run with test patches? > > > > This just makes nfsd's fput calls synchronous so that we see in the > > backtrace who called them. > >

Re: page fault scalability (ext3, ext4, xfs)

2013-08-16 Thread J. Bruce Fields
On Fri, Aug 16, 2013 at 07:37:25AM +1000, Dave Chinner wrote: > On Thu, Aug 15, 2013 at 08:17:18AM -0700, Andy Lutomirski wrote: > > On Thu, Aug 15, 2013 at 12:11 AM, Dave Chinner wrote: > > > On Wed, Aug 14, 2013 at 11:14:37PM -0700, Andy Lutomirski wrote: > > >> On Wed, Aug 14, 2013 at 11:01 PM,

Re: page fault scalability (ext3, ext4, xfs)

2013-08-18 Thread J. Bruce Fields
On Fri, Aug 16, 2013 at 04:18:33PM -0700, Andy Lutomirski wrote: > On Fri, Aug 16, 2013 at 3:02 PM, J. Bruce Fields wrote: > > On Fri, Aug 16, 2013 at 07:37:25AM +1000, Dave Chinner wrote: > >> On Thu, Aug 15, 2013 at 08:17:18AM -0700, Andy Lutomirski wrote: > >> >

Re: page fault scalability (ext3, ext4, xfs)

2013-08-19 Thread J. Bruce Fields
On Thu, Aug 15, 2013 at 04:01:49PM +1000, Dave Chinner wrote: > On Wed, Aug 14, 2013 at 09:32:13PM -0700, Andy Lutomirski wrote: > > On Wed, Aug 14, 2013 at 7:10 PM, Dave Chinner wrote: > > > On Wed, Aug 14, 2013 at 09:11:01PM -0400, Theodore Ts'o wrote: > > >> On Wed, Aug 14, 2013 at 04:38:12PM -

Re: [ 00/19] 3.10.1-stable review

2013-07-15 Thread J. Bruce Fields
On Mon, Jul 15, 2013 at 11:17:06AM -0700, Linus Torvalds wrote: > On Mon, Jul 15, 2013 at 11:04 AM, Sarah Sharp > wrote: > > > > However, I am serious about this. Linus, you're one of the worst > > offenders when it comes to verbally abusing people and publicly tearing > > their emotions apart. >

nfsd bugfixes for 3.11

2013-07-17 Thread J. Bruce Fields
: protect nlm_blocked access in nlmsvc_retry_blocked J. Bruce Fields (1): nfsd4: fix minorversion support interface fs/lockd/svclock.c |4 fs/nfsd/nfs4proc.c |2 +- fs/nfsd/nfsd.h |1 - fs/nfsd/nfssvc.c

nfsd bugfixes for 3.11

2013-08-02 Thread J. Bruce Fields
. J. Bruce Fields (4): svcrpc: fix gss_rpc_upcall create error svcrpc: fix gss-proxy xdr decoding oops svcrpc: fix kfree oops in gss-proxy code svcrpc: set cr_gss_mech from gss-proxy as well as legacy upcall NeilBrown (1

Re: [ 00/19] 3.10.1-stable review

2013-07-18 Thread J. Bruce Fields
On Thu, Jul 18, 2013 at 12:39:07PM +0200, Ingo Molnar wrote: > > * Linus Torvalds wrote: ... > > Because if you want me to "act professional", I can tell you that I'm > > not interested. I'm sitting in my home office wearign a bathrobe. The > > same way I'm not going to start wearing ties, I'm

nfsd fixes for 3.11

2013-07-25 Thread J. Bruce Fields
Please pull one more nfsd bugfix for 3.11: git://linux-nfs.org/~bfields/linux.git for-3.11 --b. Harshula Jayasuriya (1): nfsd: nfsd_open: when dentry_open returns an error do not propagate as struct file fs/nfsd/vfs.c |

nfsd fixes for 3.11

2013-08-09 Thread J. Bruce Fields
Some fixes for a 4.1 feature that in retrospect probably should have waited for 3.12 But it appears to be working now. Please pull: git://linux-nfs.org/~bfields/linux.git for-3.11 --b. J. Bruce Fields (1): nfsd4: Fix

Re: Issues with a rather unusual configured NFS server

2013-08-13 Thread J. Bruce Fields
gt; > device > > - and the NFS server is forced to umount the NFS share > > - and the server forced to restart the NSF service afterwards > > - and trinity is used > > > > I could find a scenario for an automated bisect. 2 times it brought this >

Re: linux-next: build failure after merge of the nfsd tree

2013-03-01 Thread J. Bruce Fields
On Fri, Mar 01, 2013 at 01:19:42AM +, Myklebust, Trond wrote: > On Fri, 2013-03-01 at 12:04 +1100, Stephen Rothwell wrote: > > Hi all, > > > > After merging the nfsd tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: > > > > net/sunrpc/xprtsock.c:1923:30: error: 's

Re: nfsd changes for 3.9

2013-03-02 Thread J. Bruce Fields
; Andriy Skulysh (1): > sunrpc: Fix lockd sleeping until timeout > > Fengguang Wu (1): > nfsd4: free_stid can be static > > J. Bruce Fields (7): > nfsd4: simplify nfsd4_encode_fattr interface slightly > svcrpc: silence "unused variable" war

Re: [PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-03-04 Thread J. Bruce Fields
On Wed, Feb 13, 2013 at 09:51:38AM -0800, Eric W. Biederman wrote: > From: "Eric W. Biederman" > > For each received uid call make_kuid and validate the result. > For each received gid call make_kgid and validate the result. > > Cc: "J. Bruce Fields"

Re: [PATCH] nfsd: try nfsdcld client tracker in containers

2013-03-04 Thread J. Bruce Fields
On Mon, Mar 04, 2013 at 03:04:22PM -0500, Jeff Layton wrote: > On Mon, 4 Mar 2013 21:56:19 +0400 > Stanislav Kinsbursky wrote: > > > 04.03.2013 18:47, Jeff Layton пишет: > > > On Mon, 4 Mar 2013 10:38:45 +0400 > > > Stanislav Kinsbursky wrote: > > >> 3) UMH lookup and execute binary from current

Re: [PATCH v3 0/7] Add O_DENY* support for VFS and CIFS/NFS

2013-03-04 Thread J. Bruce Fields
On Thu, Feb 28, 2013 at 01:53:25PM -0800, Andy Lutomirski wrote: > [possible resend -- sorry] > > On 02/28/2013 07:25 AM, Pavel Shilovsky wrote: > > This patchset adds support of O_DENY* flags for Linux fs layer. These flags > > can be used by any application that needs share reservations to orga

Re: [PATCH v3 0/7] Add O_DENY* support for VFS and CIFS/NFS

2013-03-05 Thread J. Bruce Fields
On Mon, Mar 04, 2013 at 05:49:46PM -0500, Simo wrote: > On 03/04/2013 04:19 PM, J. Bruce Fields wrote: > >On Thu, Feb 28, 2013 at 01:53:25PM -0800, Andy Lutomirski wrote: > >>[possible resend -- sorry] > >> > >>On 02/28/2013 07:25 AM, Pavel Shilovsky wrote

Re: [PATCH 1/7] nfsd: remove unused get_new_stid()

2013-03-05 Thread J. Bruce Fields
On Tue, Mar 05, 2013 at 12:02:46PM -0800, Tejun Heo wrote: > get_new_stid() is no longer used since 3abdb607125 ("nfsd4: simplify > idr allocation"). Remove it. Whoops, thanks for catching that. Acked-by: J. Bruce Fields > > Signed-off-by: Tejun Heo > Cc: "

Re: [PATCH] nfsd: check client tracker initialization result

2013-03-05 Thread J. Bruce Fields
On Thu, Feb 28, 2013 at 03:09:59PM +0300, Stanislav Kinsbursky wrote: > Function nfsd4_client_tracking_init() can return error. Before, I think that we the nfsd4_client_* functions just became no-ops in this case. With the result that no client records get written, and so clients are unable to re

Re: [PATCH 2/7] nfsd: convert to idr_alloc()

2013-03-05 Thread J. Bruce Fields
On Tue, Mar 05, 2013 at 12:02:47PM -0800, Tejun Heo wrote: > idr_get_new*() and friends are about to be deprecated. Convert to the > new idr_alloc() interface. > > Only compile-tested. Runs fine too--thanks. Acked-by: J. Bruce Fields --b. > > Signed-off-by: Tejun He

Re: [PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-03-05 Thread J. Bruce Fields
On Mon, Mar 04, 2013 at 09:11:16AM -0800, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > > krb5 mounts started failing for me as of this patch (upstream as > > 683428fae8c73d7d7da0fa2e0b6beb4d8df4e808), > > Ouch! > > > and I believe

Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held!

2013-03-05 Thread J. Bruce Fields
On Tue, Mar 05, 2013 at 09:49:54AM -0800, Tejun Heo wrote: > On Tue, Mar 05, 2013 at 09:46:48AM -0800, Tejun Heo wrote: > > So, I think this is why implementing freezer as a separate blocking > > mechanism isn't such a good idea. We're effectively introducing a > > completely new waiting state to

Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held!

2013-03-05 Thread J. Bruce Fields
On Tue, Mar 05, 2013 at 04:59:00PM -0800, Mandeep Singh Baines wrote: > On Tue, Mar 5, 2013 at 3:11 PM, J. Bruce Fields wrote: > > On Tue, Mar 05, 2013 at 09:49:54AM -0800, Tejun Heo wrote: > >> On Tue, Mar 05, 2013 at 09:46:48AM -0800, Tejun Heo wrote: > >> > So, I

Re: [Devel] [PATCH] nfsd: check client tracker initialization result

2013-03-06 Thread J. Bruce Fields
On Wed, Mar 06, 2013 at 10:18:38AM +0400, Stanislav Kinsbursky wrote: > 06.03.2013 09:06, Stanislav Kinsbursky пишет: > >06.03.2013 01:20, J. Bruce Fields пишет: > >>On Thu, Feb 28, 2013 at 03:09:59PM +0300, Stanislav Kinsbursky wrote: > >>>Function nfsd4_client_tr

Re: [RFC v0 4/4] nfs, nfsd: rough sys_copy_range and COPY support

2013-05-15 Thread J. Bruce Fields
On Tue, May 14, 2013 at 02:15:26PM -0700, Zach Brown wrote: > This crude patch illustrates the simplest plumbing involved in > supporting sys_call_range with the NFS COPY operation that's pending in > the 4.2 draft spec. > > The patch is based on a previous prototype that used the COPY op to > imp

Re: [RFC v0 4/4] nfs, nfsd: rough sys_copy_range and COPY support

2013-05-15 Thread J. Bruce Fields
On Wed, May 15, 2013 at 08:21:54PM +, Myklebust, Trond wrote: > On Wed, 2013-05-15 at 16:19 -0400, J. Bruce Fields wrote: > > On Tue, May 14, 2013 at 02:15:26PM -0700, Zach Brown wrote: > > > This crude patch illustrates the simplest plumbing involved in > > > sup

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-04-08 Thread J. Bruce Fields
On Mon, Apr 08, 2013 at 09:54:18PM +0800, Yanchuan Nian wrote: > On Fri, Apr 05, 2013 at 10:20:42AM -0400, J. Bruce Fields wrote: > > Actually, I find encode_seqid_op_tail completely confusing, and I don't > > see why it's necessary--it would seem more straightforward to

Re: linux-next: build failure after merge of the vfs tree

2013-05-01 Thread J. Bruce Fields
On Wed, May 01, 2013 at 12:22:27PM +1000, Stephen Rothwell wrote: > Hi Al, > > After merging the vfs tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > net/sunrpc/auth_gss/svcauth_gss.c: In function 'write_gssp': > net/sunrpc/auth_gss/svcauth_gss.c:1329:9: error: imp

nfsd changes for 3.10

2013-05-03 Thread J. Bruce Fields
(2): NFSD: Simplify GSS flavor encoding in nfsd4_do_encode_secinfo() NFSD: SECINFO doesn't handle unsupported pseudoflavors correctly Fengguang Wu (2): nfsd4: put_client_renew_locked can be static SUNRPC: gssp_procedures[] can be static J. Bruce Fields (38): nfsd4: remo

Re: [PATCH] SUNRPC: Refactor gssx_dec_option_array() to kill uninitialized warning

2013-05-06 Thread J. Bruce Fields
On Mon, May 06, 2013 at 09:21:03AM +0200, Geert Uytterhoeven wrote: > net/sunrpc/auth_gss/gss_rpc_xdr.c: In function ‘gssx_dec_option_array’: > net/sunrpc/auth_gss/gss_rpc_xdr.c:258: warning: ‘creds’ may be used > uninitialized in this function > > Return early if count is zero, to make it cleare

Re: [PATCH] nfsd: get rid of the unused functions in vfs

2013-05-07 Thread J. Bruce Fields
Thanks, applying for 3.11. --b. On Fri, May 03, 2013 at 06:08:24PM +0800, Zhao Hongjiang wrote: > The fh_lock_parent(), nfsd_truncate(), nfsd_notify_change() and > nfsd_sync_dir() > fuctions were never implement and used, just remove them. > > Signed-off-by: Zhao Hongjiang > --- > fs/nfsd/vfs

Re: [PATCH] nfsd: enable UMH client tracker in container

2013-04-23 Thread J. Bruce Fields
On Fri, Apr 19, 2013 at 07:01:50AM -0700, Jeff Layton wrote: > On Tue, 16 Apr 2013 15:17:44 +0400 > Stanislav Kinsbursky wrote: > > > This patch adds support for UserModeHelper tracker in a container. > > The reason for this is that the only containerised tracker ("nfsdcld") is > > going to be re

Re: NFS4 sec=krb5 broken in 3.9-rc8

2013-04-23 Thread J. Bruce Fields
On Tue, Apr 23, 2013 at 09:55:01PM +0200, Malte Schröder wrote: > Hi, > when I update my server from kernel 3.8.5 to 3.9-rc8 I cannot mount its > NFS exports from clients using nfs4 and sec=krb5. Using sec=sys works, > using 3.8.5 also works good with both modes. Could you get a network trace show

Re: NFS4 sec=krb5 broken in 3.9-rc8

2013-04-24 Thread J. Bruce Fields
On Wed, Apr 24, 2013 at 07:58:44AM +0200, Malte Schröder wrote: > On 23.04.2013 23:58, J. Bruce Fields wrote: > > On Tue, Apr 23, 2013 at 09:55:01PM +0200, Malte Schröder wrote: > >> Hi, > >> when I update my server from kernel 3.8.5 to 3.9-rc8 I cannot mount its &g

Re: NFS4 sec=krb5 broken in 3.9-rc8

2013-04-24 Thread J. Bruce Fields
On Wed, Apr 24, 2013 at 07:07:59PM +0200, Malte Schröder wrote: > On 24.04.2013 16:01, J. Bruce Fields wrote: > > On Wed, Apr 24, 2013 at 07:58:44AM +0200, Malte Schröder wrote: > >> On 23.04.2013 23:58, J. Bruce Fields wrote: > >>> On Tue, Apr 23, 2013 at 09:55:01

Re: [PATCH] NFSv4: Use exponential backoff delay for NFS4_ERRDELAY

2013-04-24 Thread J. Bruce Fields
On Wed, Apr 24, 2013 at 03:55:49PM -0500, Dave Chiluk wrote: > Changing the retry to start at NFS4_POLL_RETRY_MIN and exponentially grow > to NFS4_POLL_RETRY_MAX allow for faster handling of these error conditions. > > Additionally this alleviates an interoperability problem with the AIX NFSv4 > S

Re: NFS4 sec=krb5 broken in 3.9-rc8

2013-04-26 Thread J. Bruce Fields
On Fri, Apr 26, 2013 at 11:20:39AM +0200, Malte Schröder wrote: > On 24.04.2013 21:23, J. Bruce Fields wrote: > > On Wed, Apr 24, 2013 at 07:07:59PM +0200, Malte Schröder wrote: > > Probably some of those "svc_process dropit"s are coming from attempts to > > loo

Re: NFS4 sec=krb5 broken in 3.9-rc8

2013-04-26 Thread J. Bruce Fields
On Fri, Apr 26, 2013 at 06:56:19PM +0200, Malte Schröder wrote: > On 26.04.2013 17:23, J. Bruce Fields wrote: > > On Fri, Apr 26, 2013 at 11:20:39AM +0200, Malte Schröder wrote: > >> On 24.04.2013 21:23, J. Bruce Fields wrote: > >>> On Wed, Apr 24, 2013 at 07:07:59

Re: linux-next: build failure after merge of the nfsd tree

2013-04-29 Thread J. Bruce Fields
On Mon, Apr 29, 2013 at 10:53:37AM -0400, Chuck Lever wrote: > > On Apr 28, 2013, at 9:24 PM, Stephen Rothwell wrote: > > > Hi J., > > > > After merging the nfsd tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: > > > > net/sunrpc/auth_gss/svcauth_gss.c: In functio

Re: linux-next: build failure after merge of the nfsd tree

2013-04-29 Thread J. Bruce Fields
On Mon, Apr 29, 2013 at 01:04:01PM -0400, Chuck Lever wrote: > > On Apr 29, 2013, at 12:21 PM, Trond Myklebust > wrote: > > > On Mon, 2013-04-29 at 12:05 -0400, Chuck Lever wrote: > >> On Apr 29, 2013, at 11:45 AM, "J. Bruce Fields" > >> wrote:

Re: linux-next: build failure after merge of the nfsd tree

2013-04-29 Thread J. Bruce Fields
On Mon, Apr 29, 2013 at 01:47:16PM -0400, Chuck Lever wrote: > > On Apr 29, 2013, at 1:38 PM, "J. Bruce Fields" wrote: > > > On Mon, Apr 29, 2013 at 01:04:01PM -0400, Chuck Lever wrote: > >> > >> On Apr 29, 2013, at 12:21 PM, Trond Myklebust > >

Re: linux-next: build failure after merge of the nfsd tree

2013-04-29 Thread J. Bruce Fields
On Mon, Apr 29, 2013 at 02:30:33PM -0400, Chuck Lever wrote: > > On Apr 29, 2013, at 1:59 PM, "J. Bruce Fields" > wrote: > > > On Mon, Apr 29, 2013 at 01:47:16PM -0400, Chuck Lever wrote: > >> > >> On Apr 29, 2013, at 1:38 PM, "J. Bruce Field

Re: [PATCH] nfsd4: Fix NULL dereference in legacy_recdir_name_error()

2013-04-15 Thread J. Bruce Fields
On Mon, Apr 15, 2013 at 02:31:55PM +0200, Takashi Iwai wrote: > At Wed, 3 Apr 2013 14:24:10 -0400, > J. Bruce Fields wrote: > > > > On Wed, Apr 03, 2013 at 06:27:26PM +0200, Takashi Iwai wrote: > > > The recent rewrite of NFSv4 recovery client tracking options per

Re: [RFC PATCH] kmod: add ability to swap root in usermode helper

2013-05-20 Thread J. Bruce Fields
On Mon, May 20, 2013 at 05:10:01PM +0200, Oleg Nesterov wrote: > On 05/20, Stanislav Kinsbursky wrote: > > > > Moreover, set_fs_root() is not exported. > > Then it should be exported, I think ;) Maybe--there are objections, see below. > Or you can export the new helper. > > > And adding an abil

Re: [RFC PATCH] kmod: add ability to swap root in usermode helper

2013-05-21 Thread J. Bruce Fields
On Tue, May 21, 2013 at 05:28:36PM +0200, Oleg Nesterov wrote: > You know, I am puzzled. Everything looks so clear that I can't > understand what I could miss. > > On 05/20, J. Bruce Fields wrote: > > > > On Mon, May 20, 2013 at 05:10:01PM +0200, Oleg Nesterov wro

Re: [RFC PATCH] fs: call_usermodehelper_root helper introduced

2013-05-22 Thread J. Bruce Fields
On Wed, May 22, 2013 at 11:35:56AM -0700, Eric W. Biederman wrote: > ebied...@xmission.com (Eric W. Biederman) writes: > > > I am missing a lot of context here and capturing the context of a > > process at time time we mount the filesystem and reconstituing it in > > call user mode helper seems li

Re: [RFC PATCH] fs: call_usermodehelper_root helper introduced

2013-05-23 Thread J. Bruce Fields
On Wed, May 22, 2013 at 08:37:23PM -0700, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > On Wed, May 22, 2013 at 11:35:56AM -0700, Eric W. Biederman wrote: > >> ebied...@xmission.com (Eric W. Biederman) writes: > >> > >> > I am mis

Re: [RFC PATCH] fs: call_usermodehelper_root helper introduced

2013-05-23 Thread J. Bruce Fields
On Thu, May 23, 2013 at 09:05:26AM -0400, Jeff Layton wrote: > On Thu, 23 May 2013 15:25:20 +0300 > > I'm not familiar with nfsdcltrack but I would imagine it receives it's > > information from > > Kernel as a command line parameters. > > > > Would it not be the simplest approach to add a --chroo

Re: [RFC PATCH] fs: call_usermodehelper_root helper introduced

2013-05-23 Thread J. Bruce Fields
On Thu, May 23, 2013 at 03:55:47PM -0400, J. Bruce Fields wrote: > On Thu, May 23, 2013 at 09:05:26AM -0400, Jeff Layton wrote: > > What might help most here is to lay out a particular scenario for how > > you envision setting up knfsd in a container so we can ensure that it&

Re: kernel 3.8.4 : kernel BUG at fs/locks.c:2093! part #2

2013-03-27 Thread J. Bruce Fields
On Wed, Mar 27, 2013 at 06:20:42PM +0100, Toralf Förster wrote: > On 03/26/2013 07:17 PM, J. Bruce Fields wrote: > > > > Bah, too bad. That patch was definitely not a fix, so there may be some > > race here. > > > >> What I get at the host is now : > &g

Re: kernel 3.8.4 : kernel BUG at fs/locks.c:2093! part #2

2013-03-27 Thread J. Bruce Fields
On Wed, Mar 27, 2013 at 10:35:12PM +0100, Toralf Förster wrote: > On 03/26/2013 03:46 PM, J. Bruce Fields wrote: > > Can you run with test patches? > > applied - today I got a warning instead a bug at the host kernel (3.8.4): Excellent! Thanks, I think I see the bug now

Re: kernel 3.8.4 : kernel BUG at fs/locks.c:2093! part #2

2013-03-29 Thread J. Bruce Fields
On Wed, Mar 27, 2013 at 05:57:27PM -0400, J. Bruce Fields wrote: > On Wed, Mar 27, 2013 at 10:35:12PM +0100, Toralf Förster wrote: > > On 03/26/2013 03:46 PM, J. Bruce Fields wrote: > > > Can you run with test patches? > > > > applied - today I got a warning in

Re: New copyfile system call - discuss before LSF?

2013-04-01 Thread J. Bruce Fields
On Sun, Mar 31, 2013 at 04:36:59AM +, Myklebust, Trond wrote: > On Sat, 2013-03-30 at 21:18 -0700, Andy Lutomirski wrote: > > On Sat, Mar 30, 2013 at 8:52 PM, Myklebust, Trond > > wrote: > > > On Sat, 2013-03-30 at 19:53 -0700, Andreas Dilger wrote: > > >> On 2013-03-30, at 16:21, Ric Wheeler

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-04-01 Thread J. Bruce Fields
On Wed, Mar 13, 2013 at 11:04:54PM +0800, Yanchuan Nian wrote: > 2013/3/11 J. Bruce Fields > > > On Mon, Mar 11, 2013 at 08:46:14AM +0800, ycn...@gmail.com wrote: > > > NFS4_OO_PURGE_CLOSE is not handled properly. To avoid memory leak, nfs4 > > > stateid which is

Re: sunrpc ODEBUG assertion.

2013-03-09 Thread J. Bruce Fields
like Trond to either take this or ACK (or NAK) this. --b. commit dc329cfb5c68c62db56b78b67ee45c3ef24df7d6 Author: J. Bruce Fields Date: Fri Mar 8 13:13:08 2013 -0500 sunrpc: don't attempt to cancel unitialized work As of dc107402ae06286a9ed33c32daf3f35514a7cb8d "SUNRPC:

Re: [PATCH] sunrpc: drop "select NETVM"

2013-03-09 Thread J. Bruce Fields
ACK. On Sat, Mar 09, 2013 at 05:02:31PM +0100, Paul Bolle wrote: > The Kconfig entry for SUNRPC_SWAP selects NETVM. That select statement > was added in commit a564b8f0398636ba30b07c0eaebdef7ff7837249 ("nfs: > enable swap on NFS"). Cc'ing Mel Gorman just in case there was something else going on

Re: [PATCH linux-next] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-10 Thread J. Bruce Fields
4 bytes [-Wframe-larger-than=] > > gcc version 4.6.3 > > Cc: Trond Myklebust > Cc: "J. Bruce Fields" > Cc: "David S. Miller" > Cc: Tom Tucker > Cc: Haggai Eran > Cc: Or Gerlitz > Cc: Shani Michaeli > Cc: linux-...@vger.kernel.org &g

Re: [PATCH v2] nfsd: rmmove unused macro in nfsv4

2013-03-11 Thread J. Bruce Fields
On Mon, Mar 11, 2013 at 10:43:26AM +0800, ycn...@gmail.com wrote: > From: Yanchuan Nian > > lk_rflags is never used anywhere, and rflags is not defined in struct > nfsd4_lock. Very sorry for my negligence in last version. Maybe I am tired. Applying for 3.10, thanks.--b. > > Signed-off-by: Yanc

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-03-11 Thread J. Bruce Fields
On Mon, Mar 11, 2013 at 08:46:14AM +0800, ycn...@gmail.com wrote: > NFS4_OO_PURGE_CLOSE is not handled properly. To avoid memory leak, nfs4 > stateid which is pointed by oo_last_closed_stid is freed in nfsd4_close(), > but NFS4_OO_PURGE_CLOSE isn't cleared meanwhile. So the stateid released in >

Re: [PATCH linux-next v2] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-11 Thread J. Bruce Fields
rpc/xprtrdma/verbs.c:1774:1: warning: the frame size of 1056 bytes is > larger than 1024 bytes [-Wframe-larger-than=] > > gcc version 4.6.3 > > Cc: Trond Myklebust > Cc: "J. Bruce Fields" > Cc: "David S. Miller" > Cc: Tom Tucker > Cc: Haggai

Re: 3v9.0-rc2 oops on NFS mount

2013-03-11 Thread J. Bruce Fields
On Mon, Mar 11, 2013 at 12:19:34PM +, Mark Jackson wrote: > I'm getting a repeatable oops when mounting my rootfs over nfs:- Known, and being worked on (but you can probably ignore it). --b. > > [4.639415] = > [4.644361] [ BUG: swapper/1 still has

Re: [PATCH v3 0/7] Add O_DENY* support for VFS and CIFS/NFS

2013-03-11 Thread J. Bruce Fields
On Mon, Mar 11, 2013 at 11:18:15AM -0700, Andy Lutomirski wrote: > On Tue, Mar 5, 2013 at 11:07 AM, Simo wrote: > > On 03/05/2013 01:13 PM, J. Bruce Fields wrote: > >> > >> On Mon, Mar 04, 2013 at 05:49:46PM -0500, Simo wrote: > >>> > >>

Re: [PATCH linux-next v2] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-11 Thread J. Bruce Fields
On Mon, Mar 11, 2013 at 12:51:44PM -0600, Tim Gardner wrote: > On 03/11/2013 12:14 PM, J. Bruce Fields wrote: > > >> > >> v2 - Move the array of 'struct ib_phys_buf' objects into struct rpcrdma_req > >> and pass this request d

Re: [PATCH v3 7/7] NFSD: Pass share reservations flags to VFS

2013-03-11 Thread J. Bruce Fields
On Mon, Mar 11, 2013 at 03:05:40PM -0400, Jeff Layton wrote: > knfsd has some code already to handle share reservations internally. > Nothing outside of knfsd is aware of these reservations, of course so > moving to a vfs-level object for it would be a marked improvement. > > It doesn't look like

3.9 nfsd bugfixes

2013-03-11 Thread J. Bruce Fields
. J. Bruce Fields (2): nfsd: fix krb5 handling of anonymous principals sunrpc: don't attempt to cancel unitialized work net/sunrpc/auth_gss/svcauth_gss.c | 12 net/sunrpc/xprtsock.c | 15 ++- 2 files changed, 18 insertions(+), 9 dele

Re: [PATCH linux-next v2] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-11 Thread J. Bruce Fields
On Mon, Mar 11, 2013 at 07:48:51PM +, Myklebust, Trond wrote: > On Mon, 2013-03-11 at 15:15 -0400, J. Bruce Fields wrote: > > On Mon, Mar 11, 2013 at 12:51:44PM -0600, Tim Gardner wrote: > > > On 03/11/2013 12:14 PM, J. Bruce Fields wrote: > > > > > >

Re: [PATCH v3 7/7] NFSD: Pass share reservations flags to VFS

2013-03-11 Thread J. Bruce Fields
On Mon, Mar 11, 2013 at 04:08:44PM -0400, Jeff Layton wrote: > On Mon, 11 Mar 2013 15:36:38 -0400 > "J. Bruce Fields" wrote: > > > On Mon, Mar 11, 2013 at 03:05:40PM -0400, Jeff Layton wrote: > > > knfsd has some code already to handle share reservations in

Re: [PATCH v3 7/7] NFSD: Pass share reservations flags to VFS

2013-03-11 Thread J. Bruce Fields
On Mon, Mar 11, 2013 at 01:25:20PM -0700, Frank S Filz wrote: > > "J. Bruce Fields" wrote > > On Mon, Mar 11, 2013 at 04:08:44PM -0400, Jeff Layton wrote: > > > On Mon, 11 Mar 2013 15:36:38 -0400 > > > "J. Bruce Fields" wrote: > > >

Re: [PATCH linux-next v3] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-11 Thread J. Bruce Fields
no danger of multiple accessors to the array of struct ib_phys_buf objects. > > net/sunrpc/xprtrdma/verbs.c: In function 'rpcrdma_register_default_external': > net/sunrpc/xprtrdma/verbs.c:1774:1: warning: the frame size of 1056 bytes is > larger than 1024 bytes [-Wframe-larger-th

[PATCH] locks: remove unused lm_release_private

2012-08-01 Thread J. Bruce Fields
From: "J. Bruce Fields" 3b6e2723f32de42028617f2c99b244ccd72cd959 "locks: prevent side-effects of locks_release_private before file_lock is initialized" removed the last user of lm_release_private without removing the field itself. Signed-off-by: J. Bruce Fields --- Docum

Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-08-21 Thread J. Bruce Fields
On Thu, Aug 16, 2012 at 03:29:03PM -0400, J. Bruce Fields wrote: > Looking back at this: > > - adding the sv_lock looks like the right thing to do anyway > independent of containers, because svc_age_temp_xprts may > still be running. This is what I've be

[PATCH] strings: helper for maximum decimal encoding of an unsigned integer

2012-08-21 Thread J. Bruce Fields
From: "J. Bruce Fields" I've seen a couple examples recently where we've gotten this wrong. Maybe something like this would help? Is there some better way? (Approximation due to Jim Rees). Signed-off-by: J. Bruce Fields --- include/linux/string.h |6 ++ net/sunrp

Re: [PATCH] strings: helper for maximum decimal encoding of an unsigned integer

2012-08-21 Thread J. Bruce Fields
On Tue, Aug 21, 2012 at 11:06:13PM +0100, Al Viro wrote: > On Tue, Aug 21, 2012 at 05:22:27PM -0400, Jim Rees wrote: > > J. Bruce Fields wrote: > > > > From: "J. Bruce Fields" > > > > I've seen a couple examples recently where we've got

Re: [PATCH v3 13/17] lockd: use new hashtable implementation

2012-08-22 Thread J. Bruce Fields
On Wed, Aug 22, 2012 at 04:27:08AM +0200, Sasha Levin wrote: > +static int __init nlm_init(void) > +{ > + hash_init(nlm_files); > + return 0; > +} > + > +module_init(nlm_init); That's giving me: fs/lockd/svcsubs.o: In function `nlm_init': /home/bfields/linux-2.6/fs/lockd/svcsubs.c:454: mu

Re: [PATCH v3 13/17] lockd: use new hashtable implementation

2012-08-22 Thread J. Bruce Fields
On Wed, Aug 22, 2012 at 02:13:54PM +0200, Sasha Levin wrote: > On 08/22/2012 01:47 PM, J. Bruce Fields wrote: > > On Wed, Aug 22, 2012 at 04:27:08AM +0200, Sasha Levin wrote: > >> +static int __init nlm_init(void) > >> +{ > >> + ha

Re: [patch 4/9] fs, exportfs: Fix nil dereference if no s_export_op present

2012-08-23 Thread J. Bruce Fields
C: Andrew Morton > CC: James Bottomley > CC: "Aneesh Kumar K.V" > CC: Alexey Dobriyan > CC: Matthew Helsley > CC: "J. Bruce Fields" > CC: "Aneesh Kumar K.V" > --- > fs/exportfs/expfs.c |

Re: [patch 0/9] extended fdinfo via procfs series, v7

2012-08-23 Thread J. Bruce Fields
On Thu, Aug 23, 2012 at 02:43:23PM +0400, Cyrill Gorcunov wrote: > Hi guys, > > here is updated version of the fdinfo via procfs series, > the changes from previous one are the following > > - fhandle is carried inside inotify mark but this feature >is CONFIG dependent to not bloat the kerne

Re: [patch 0/9] extended fdinfo via procfs series, v7

2012-08-23 Thread J. Bruce Fields
On Thu, Aug 23, 2012 at 04:44:27PM +0400, Cyrill Gorcunov wrote: > On Thu, Aug 23, 2012 at 08:23:18AM -0400, J. Bruce Fields wrote: > > On Thu, Aug 23, 2012 at 02:43:23PM +0400, Cyrill Gorcunov wrote: > > > Hi guys, > > > > > > here is updated version of the

Re: [patch 4/9] fs, exportfs: Fix nil dereference if no s_export_op present

2012-08-23 Thread J. Bruce Fields
On Thu, Aug 23, 2012 at 04:34:22PM +0400, Cyrill Gorcunov wrote: > On Thu, Aug 23, 2012 at 08:12:30AM -0400, J. Bruce Fields wrote: > > On Thu, Aug 23, 2012 at 02:43:27PM +0400, Cyrill Gorcunov wrote: > > > If there is no s_export_op present in a target superblock >

Re: [patch 0/9] extended fdinfo via procfs series, v7

2012-08-23 Thread J. Bruce Fields
On Thu, Aug 23, 2012 at 05:56:06PM +0400, Cyrill Gorcunov wrote: > On Thu, Aug 23, 2012 at 09:52:34AM -0400, J. Bruce Fields wrote: > > > > I don't have any opinion on whether there should be a configuration > > option. Just want to make sure the cost when it'

Re: [patch 0/9] extended fdinfo via procfs series, v7

2012-08-23 Thread J. Bruce Fields
On Thu, Aug 23, 2012 at 09:02:39PM +0400, Cyrill Gorcunov wrote: > On Thu, Aug 23, 2012 at 11:25:45AM -0400, J. Bruce Fields wrote: > > On Thu, Aug 23, 2012 at 05:56:06PM +0400, Cyrill Gorcunov wrote: > > > On Thu, Aug 23, 2012 at 09:52:34AM -0400, J. Bruce Fields wrote: > &

nfsd bugfixes for 3.6

2012-08-23 Thread J. Bruce Fields
Please pull the following nfsd bugfixes from: git://linux-nfs.org/~bfields/linux.git for-3.6 Particular thanks to Michael Tokarev, Malahal Naineni, and Jamie Heilman for their testing and debugging help. --b. J. Bruce Fields (4

Re: [PATCH v3 5/5] Documentation: update nfs option in filesystem/vfat.txt

2012-09-17 Thread J. Bruce Fields
On Sun, Sep 16, 2012 at 08:23:20AM -0400, Namjae Jeon wrote: > From: Namjae Jeon > > update nfs option in filesystem/vfat.txt > > Signed-off-by: Namjae Jeon > Signed-off-by: Ravishankar N > Signed-off-by: Amit Sahrawat > --- > Documentation/filesystems/vfat.txt | 19 ++- >

[PATCH] trivial select_parent documentation fix

2012-09-18 Thread J. Bruce Fields
"Search list for X" sounds like you're trying to find X on a list. Signed-off-by: J. Bruce Fields --- On Mon, Sep 17, 2012 at 10:23:30PM +0200, Miklos Szeredi wrote: > IBM reported a deadlock in select_parent(). (And I went to look at select_parent() and got tripped up fo

Re: IMA policy search speedup

2012-09-19 Thread J. Bruce Fields
On Wed, Sep 19, 2012 at 01:25:26PM +0300, Kasatkin, Dmitry wrote: > On Wed, Sep 19, 2012 at 7:21 AM, James Morris wrote: > > On Tue, 18 Sep 2012, Kasatkin, Dmitry wrote: > > > >> I looked to and found that there is a possibility to to > >> add additional flag for sb->s_flags. > >> For example > >

Re: [RFC PATCH 1/2] unix sockets: add ability for search for peer from passed root

2012-08-10 Thread J. Bruce Fields
On Fri, Aug 10, 2012 at 04:57:30PM +0400, Stanislav Kinsbursky wrote: > This helper is used stream sockets yet. > All is simple: if non-NULL struct path was passed to unix_find_other(), then > vfs_path_lookup() is called instead of kern_path(). I'm having some trouble parsing the changelog. Maybe

Re: [RFC PATCH 0/2] net: connect to UNIX sockets from specified root

2012-08-10 Thread J. Bruce Fields
On Fri, Aug 10, 2012 at 07:26:28PM +0100, Alan Cox wrote: > > On that whole subject... > > > > Do we need a Unix domain socket equivalent to openat()? > > I don't think so. The name is just a file system indexing trick, it's not > really the socket proper. It's little more than "ascii string with

Re: [git patches] net driver fixes

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 01:15:30PM -0800, David Miller wrote: > From: Jeff Garzik <[EMAIL PROTECTED]> > Date: Wed, 20 Feb 2008 11:55:57 -0500 > > > > > Note: this is based off of Linus's latest commit > > (5d9c4a7de64d398604a978d267a6987f1f4025b7), since all my previous > > submissions are now u

Re: [git patches] net driver fixes

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 01:42:57PM -0800, David Miller wrote: > From: "J. Bruce Fields" <[EMAIL PROTECTED]> > Date: Wed, 20 Feb 2008 16:23:02 -0500 > > > On Wed, Feb 20, 2008 at 01:15:30PM -0800, David Miller wrote: > > > From: Jeff Garzik <[EMAIL PROTEC

Re: [PATCH 1/2] nfsd: fix sparse warnings

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 12:49:00PM -0800, Harvey Harrison wrote: > Add extern to nfsd/nfsd.h > fs/nfsd/nfssvc.c:146:5: warning: symbol 'nfsd_nrthreads' was not declared. > Should it be static? > fs/nfsd/nfssvc.c:261:5: warning: symbol 'nfsd_nrpools' was not declared. > Should it be static? > fs/n

Re: [PATCH 2/2] nfsd: fix sparse warning in vfs.c

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 12:49:02PM -0800, Harvey Harrison wrote: > fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> > --- > fs/nfsd/vfs.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Also applied, thanks.--

Re: [RFC PATCH 0/2] net: connect to UNIX sockets from specified root

2012-08-13 Thread J. Bruce Fields
On Sat, Aug 11, 2012 at 03:15:24PM +0400, Stanislav Kinsbursky wrote: > 11.08.2012 10:23, Pavel Emelyanov пишет: > >On 08/11/2012 03:09 AM, H. Peter Anvin wrote: > >>On 08/10/2012 12:28 PM, Alan Cox wrote: > >>>Explicitly for Linux yes - this is not generally true of the AF_UNIX > >>>socket domain

Re: [RFC PATCH 0/2] net: connect to UNIX sockets from specified root

2012-08-13 Thread J. Bruce Fields
On Mon, Aug 13, 2012 at 09:39:53PM +0400, Stanislav Kinsbursky wrote: > 13.08.2012 20:47, J. Bruce Fields пишет: > >On Sat, Aug 11, 2012 at 03:15:24PM +0400, Stanislav Kinsbursky wrote: > >>11.08.2012 10:23, Pavel Emelyanov пишет: > >>>On 08/11/2012 03:09 AM, H. Pet

Re: [PATCH 00/16] generic hashtable implementation

2012-08-14 Thread J. Bruce Fields
On Tue, Aug 14, 2012 at 06:24:34PM +0200, Sasha Levin wrote: > SUNRPC/cache: use new hashtable implementation .. > lockd: use new hashtable implementation FWIW, these look fine (and I ran them through some nfs tests and didn't see any problems). --b. -- To unsubscribe from this list: send the

Re: v3.5 nfsd4 regression; utime sometimes takes 40+ seconds to return

2012-08-15 Thread J. Bruce Fields
On Wed, Aug 15, 2012 at 01:58:54PM +, Jamie Heilman wrote: > Jamie Heilman wrote: > > I'll try to get full rcpdebug traces on client and server as the delay > > is occuring in the hopes that helps pin things down, and post them > > separately. > > OK, here are the logs from client and server,

<    1   2   3   4   5   6   7   8   9   10   >