[PATCH] perf tools: Initialize perf_data_file fd field

2018-08-29 Thread Jérémie Galarneau
distributions and gcc versions. Signed-off-by: Jérémie Galarneau Cc: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Alexander Shishkin --- tools/perf/util/data-convert-bt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util

Re: [PATCH] perf tools: Initialize perf_data_file fd field

2018-09-18 Thread Jérémie Galarneau
Hi Arnaldo, Anything I can do to help you with this patch? Thanks, Jérémie On 5 September 2018 at 12:09, Jiri Olsa wrote: > On Wed, Aug 29, 2018 at 04:16:48PM -0400, Jérémie Galarneau wrote: >> Building the perf CTF converter fails with gcc 4.8.4 >> on Ubuntu 14.04 with the

Re: [PATCH RFC 2/2] perf: convert: fix duplicate field names and avoid reserved keywords.

2015-01-23 Thread Jérémie Galarneau
} >>> +} >>> + >>> +ret = bt_ctf_event_class_add_field(event_class, type, name); >>> + >>> +/* if failed, we may hit a keywork. try again with a '_' prefix */ >>> +if (ret) { >>> +name = change_na

Re: [PATCHv3 0/8] perf tools: Add perf data CTF conversion

2015-01-16 Thread Jérémie Galarneau
erf.txt |7 +- >>> tools/perf/Makefile.perf |9 +- >>> tools/perf/builtin-data.c | 119 ++ >>> tools/perf/builtin.h |1 + >>> too

Re: [PATCHv3 0/8] perf tools: Add perf data CTF conversion

2015-01-28 Thread Jérémie Galarneau
On Sun, Jan 25, 2015 at 8:43 AM, Jiri Olsa wrote: > On Fri, Jan 16, 2015 at 11:46:36AM -0500, Jérémie Galarneau wrote: >> On Fri, Jan 16, 2015 at 10:26 AM, Alexandre Montplaisir >> wrote: >> > On 2015-01-15 03:57 PM, Alexandre Montplaisir wrote: >> >> >&

Re: [PATCH 1/2] perf data: Show error message when ctf setup failed

2015-04-14 Thread Jérémie Galarneau
am class: in bt_ctf_stream_class_add_event_class() Signed-off-by: Philippe Proulx Signed-off-by: Jérémie Galarneau Jérémie On Mon, Apr 13, 2015 at 4:30 PM, Jérémie Galarneau wrote: > On Fri, Apr 10, 2015 at 8:37 AM, Jiri Olsa wrote: >> On Fri, Apr 10, 2015 at 02:0

Re: [PATCH 6/7] perf data: Fix duplicate field names and avoid reserved keywords

2015-04-18 Thread Jérémie Galarneau
d->name, ret); > return -1; > } > } > @@ -646,7 +724,7 @@ static int add_generic_types(struct ctf_writer *cw, > struct perf_evsel *evsel, > do {\ > pr2(" field '%s'\n", n); \ > if (bt_ctf_event_class_add_field(cl, t, n)) { \ > - pr_err("Failed to add field '%s;\n", n);\ > + pr_err("Failed to add field '%s';\n", n); \ > return -1; \ > } \ > } while (0) > -- > 1.9.3 > -- Jérémie Galarneau EfficiOS Inc. http://www.efficios.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] perf data: Fix ctf_writer setupenv failure

2015-04-09 Thread Jérémie Galarneau
Hi He, This commit should fix the problem: commit a0d129162d2fdd1a99553a6cfbdf4e77ad3f7334 Author: Jérémie Galarneau Date: Thu Apr 9 14:57:44 2015 -0400 Fix: Allow the addition of environment fields to a frozen trace Commit 7f800dc7 introduced a behavior change which made it

Re: [PATCH 1/2] perf data: Show error message when ctf setup failed

2015-04-13 Thread Jérémie Galarneau
el_priv *priv; > const char *name = perf_evsel__name(evsel); > int ret; > @@ -833,6 +834,14 @@ static int add_event(struct ctf_writer *cw, struct > perf_evsel *evsel) > if (!priv) > goto err; > > + event = bt_ctf_event_c

Re: [lttng-dev] [RFC] perf to ctf converter

2014-08-05 Thread Jérémie Galarneau
d take some time. However I > wanted first to make sure it make sense to continue that approach. > FYI, I have made the changes and they are now upstream in Babeltrace as of commit 12c8a1a3121ed7125e8758065c44658d8eda1333 Author: Jérémie Galarneau Date: Tue Jul 29 16:51:51 2014 -040

Re: Support for Perf CTF traces now in master (was Re: FW: [RFC 0/5] perf tools: Add perf data CTF conversion)

2014-12-01 Thread Jérémie Galarneau
@@ -862,6 +912,9 @@ int bt_convert__perf2ctf(const char *input, const char > *path) > if (!session) > goto free_writer; > > + ordered_events__set_alloc_size(&session->ordered_events, > + 100*1024*1024); > + > /* CTF writer env/clock setu

[PATCH] btrfs: fix tracepoint namespacing

2014-10-17 Thread Jérémie Galarneau
Some btrfs tracepoints are not properly namespaced. The tracepoint names should be prefixed with the subsystem's name as suggested in tracepoint.h Cc: Chris Mason Cc: Steven Rostedt Signed-off-by: Jérémie Galarneau --- fs/btrfs/delayed-ref.c | 6 +++--- fs/btrfs/extent-t

Re: [PATCH] perf build: Fix libbabeltrace detection

2015-03-10 Thread Jérémie Galarneau
gt;> - feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) >> CFLAGS="$(EXTRA_CFLAGS) $(FEATURE_CHECK_CFLAGS-$(1))" LDFLAGS="$(LDFLAGS) >> $(FEATURE_CHECK_LDFLAGS-$(1))" -C config/feature-checks test-$1.bin >> >/dev/null 2>/dev/null && e

Re: [PATCH 06/11] perf data: Switch to multiple cpu stream files

2015-03-12 Thread Jérémie Galarneau
rf2ctf (input=, > path=0x7fffe59d "./ctf-data/") at util/data-convert-bt.c:992 > #13 0x004479cf in cmd_data_convert (argc=, > argv=, prefix=) at builtin-data.c:77 > #14 0x0046f365 in run_builtin (p=p@entry=0x8345a0 , > argc=argc@entry=3, argv=argv@ent

Re: [PATCH 06/11] perf data: Switch to multiple cpu stream files

2015-03-13 Thread Jérémie Galarneau
fffe2d0) at perf.c:370 > #15 0x0041def0 in handle_internal_command (argv=0x7fffe2d0, > argc=3) at perf.c:429 > #16 run_argv (argv=0x7fffe050, argcp=0x7fffe05c) at perf.c:473 > #17 main (argc=3, argv=0x7fffe2d0) at perf.c:588 > (gdb) > I was able to repro

Re: [PATCH 1/2] perf: convert: fix duplicate field names and avoid reserved keywords.

2015-01-21 Thread Jérémie Galarneau
- ret = bt_ctf_event_class_add_field(event_class, type, >> - field->name); >> + /* Check name duplication */ >> + name = field->name; > > could you please put this in separated function like 'get_field_name(..

Re: [PATCH 1/2] perf: convert: fix duplicate field names and avoid reserved keywords.

2015-01-21 Thread Jérémie Galarneau
On Wed, Jan 21, 2015 at 8:38 PM, Wang Nan wrote: > On 2015/1/21 23:56, Jérémie Galarneau wrote: >> On Wed, Jan 21, 2015 at 9:11 AM, Jiri Olsa wrote: >>> On Wed, Jan 21, 2015 at 11:23:54AM +0800, Wang Nan wrote: >>>> Some parameters of syscall tracepoints named as

Unmerged patches adding audit when protected_regular/fifos sysctl causes EACCES

2019-09-25 Thread Jérémie Galarneau
/scm/linux/kernel/git/kees/linux.git/log/?h=kspp/userspace/protected-creat [2] https://lkml.org/lkml/2018/4/10/840 [3] https://lore.kernel.org/lkml/20180416175918.GA13494@beast/ [4] https://github.com/lttng/lttng-tools/commit/cf86ff2c4ababd01fea7ab2c9c289cb7c0a1bcd5 -- Jérémie Galarneau EfficiOS

[PATCH] Fix: perf data convert: leak of bt_ctf_field_type

2016-10-22 Thread Jérémie Galarneau
kml.iu.edu/hypermail/linux/kernel/1602.1/03800.html CC-ing the people who were CC-ed on the original patch. Signed-off-by: Jérémie Galarneau Cc: Wang Nan Cc: Philippe Proulx Cc: David S. Miller Cc: Alexei Starovoitov Cc: Brendan Gregg Cc: David S. Miller Cc: Jiri Olsa Cc: Masami Hiramatsu

[tip:perf/core] perf tools: Initialize perf_data_file fd field

2018-09-25 Thread tip-bot for Jérémie Galarneau
Commit-ID: c04c859f439fb4de9039246370d60a07b9b5bcb5 Gitweb: https://git.kernel.org/tip/c04c859f439fb4de9039246370d60a07b9b5bcb5 Author: Jérémie Galarneau AuthorDate: Wed, 29 Aug 2018 16:16:48 -0400 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 19 Sep 2018 10:25:13 -0300 perf