Re: [RFT PATCH v2 2/3] drm/exynos: Constify exynos_drm_crtc_ops

2015-05-11 Thread Inki Dae
rm_crtc.h:24: + const struct exynos_drm_crtc_ops *ops, I modified and merged all patches. Thanks, Inki Dae > > Signed-off-by: Krzysztof Kozlowski > > --- > Changes since v1: > New patch. > --- > drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- > drivers/gpu/drm/exyno

Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 Thread Inki Dae
struct exynos_drm_crtc *crtc, bool enable); > +#else > +static inline void fimd_dp_clock_enable(struct exynos_drm_crtc *crtc, bool > enable) {}; > +#endif So above codes are unnecessary. It's really not good to add #ifdef ~ #endif. Thanks, Inki Dae > > #endif /* _EXY

Re: [PATCH] drm/exynos: mixer: Constify platform_device_id

2015-05-04 Thread Inki Dae
On 2015년 05월 02일 00:56, Krzysztof Kozlowski wrote: > The platform_device_id is not modified by the driver and core uses it as > const. Applied. Thanks, Inki Dae > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 2 +- > 1 file chang

Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 Thread Inki Dae
2015-05-04 20:34 GMT+09:00 Daniel Stone : > Hi, > > On 4 May 2015 at 08:43, Inki Dae wrote: >> On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: >>> Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build >>> error: >> >> No, eDP has

Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 Thread Inki Dae
2015-05-04 21:43 GMT+09:00 Krzysztof Kozlowski : > 2015-05-04 20:34 GMT+09:00 Daniel Stone : >> Hi, >> >> On 4 May 2015 at 08:43, Inki Dae wrote: >>> On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: >>>> Selecting CONFIG_FB_S3C disables CONFIG_D

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-09 Thread Inki Dae
On 2015년 03월 07일 00:07, Javier Martinez Canillas wrote: > Hello Inki, > > On 03/06/2015 02:32 PM, Inki Dae wrote: >>> >>> Another interesting data point is that the error in next-20150303 for >>> these 2 boards was the NULL pointer dereference in exynos_plane

Re: [PATCH] drm/exynos: Check for NULL dereference of crtc

2015-03-06 Thread Inki Dae
;s strange. plane->funcs->destroy() is called prior to crtc->funcs->destroy() so it should be exynos_crtc is not NULL. However, it seems there is any corner case we didn't catch up. Applied. Thanks, Inki Dae > Arndale: > > [1.673479] Unable to handle kernel NULL

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-06 Thread Inki Dae
ynos5250-arndale failed to boot with next-20150304 [13] > while exynos5422-odroidxu3 booted successfully and there were no changes > for the exynos drm driver between next-20150303 and next-20150304. > > Another interesting data point is that the error in next-20150303 for > these 2 bo

Re: [PATCH] drm/exynos: Check for NULL dereference of crtc

2015-03-07 Thread Inki Dae
On 2015년 03월 06일 23:04, Charles Keepax wrote: > On Fri, Mar 06, 2015 at 10:13:42PM +0900, Inki Dae wrote: >> On 2015년 02월 18일 02:14, Charles Keepax wrote: >>> The commit "drm/exynos: remove exynos_plane_dpms" (d9ea6256) removed the >>> use of the enabled flag,

Re: drm/exynos: DRM_EXYNOS7DECON?

2015-02-17 Thread Inki Dae
. It's my mistake. That is just typo so it should be DRM_EXYNOS7_DECON instead of DRM_EXYNOS7DECON. It would be fixed at RC1. Thanks for report, Inki Dae > > > Paul Bolle > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
2016년 03월 29일 22:23에 Rob Clark 이(가) 쓴 글: > On Mon, Mar 28, 2016 at 10:18 PM, Inki Dae wrote: >> >> In addition, I wonder how explicit and implicit fences could coexist >> together. >> Rob said, >> "Implicit sync ofc remains the default, but userspace cou

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
Hi Daniel, 2016년 03월 31일 18:35에 Daniel Stone 이(가) 쓴 글: > Hi Inki, > > On 31 March 2016 at 08:45, Inki Dae wrote: >> 2016년 03월 29일 22:23에 Rob Clark 이(가) 쓴 글: >>> On Mon, Mar 28, 2016 at 10:18 PM, Inki Dae wrote: >>>> In addition, I wonder how explic

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
Hi Daniel, 2016-03-31 19:56 GMT+09:00 Daniel Stone : > Hi Inki, > > On 31 March 2016 at 11:05, Inki Dae wrote: >> 2016년 03월 31일 18:35에 Daniel Stone 이(가) 쓴 글: >>> On 31 March 2016 at 08:45, Inki Dae wrote: >>>> As of now, it seems that this wouldn't be

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
is should only be used for shared buffers, e.g. > explicit syncing in an android client running on top of implicitly synced > ozone/kms. Good idea. I hope fence things of mainline would be more discussed so could be considered for many cases. Thanks, Inki Dae > -Daniel > -- >

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-04-03 Thread Inki Dae
2016년 03월 31일 23:10에 Rob Clark 이(가) 쓴 글: > On Thu, Mar 31, 2016 at 7:26 AM, Inki Dae wrote: >> Hi Daniel, >> >> 2016-03-31 19:56 GMT+09:00 Daniel Stone : >>> Hi Inki, >>> >>> On 31 March 2016 at 11:05, Inki Dae wrote: >>>> 2016년 03월 31

Re: [PATCH 1/6] include/drm: color_mgmt: Add enum labels

2019-01-17 Thread Inki Dae
see why above two types are needed. Is there any case that the range checking behavior should be different according to the color space? And even if there is that case, I think you have to put DRM_COLOR_RANG_MAX under DRM_COLOR_FULL_RANGE. Thanks, Inki Dae > }; > > int drm_plane_create_color_properties(struct drm_plane *plane, >

Re: ERROR: "vmf_insert_mixed" [drivers/gpu/drm/exynos/exynosdrm.ko] undefined!

2019-08-02 Thread Inki Dae
bot > > All errors (new ones prefixed by >>): > >>> ERROR: "vmf_insert_mixed" [drivers/gpu/drm/exynos/exynosdrm.ko] undefined! With below patch I think the build error reported already will be fixed, https://patchwork.kernel.org/patch/11035147/ Thanks, Inki Dae &g

Re: [PATCH 1/3] drm/exynos: rotator: Add support for s5pv210

2019-01-08 Thread Inki Dae
Applied. Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 23 + > 1 file changed, 23 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c > b/drivers/gpu/drm/exynos/exynos_drm_rotator.c > index a820a68429b9..

Re: [PATCH v5 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-04 Thread Inki Dae
2017년 01월 05일 15:55에 Andrzej Hajda 이(가) 쓴 글: > On 04.01.2017 15:44, Rob Herring wrote: >> On Wed, Jan 04, 2017 at 05:15:10PM +0900, Hoegeun Kwon wrote: >>> This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel >>> driver. This panel has 1440x2560 resolution in 5.7-inch physical >>> panel

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-05 Thread Inki Dae
es valid for both > the boards? We don't need to consider tm2e board with two reasones, 1. there is no tm2e board support in mainline 2. the panel on tm2 would be a little bit different from one on tm2e Thanks, Inki Dae > > Andi > >

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-06 Thread Inki Dae
2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: > Hi Inki, > > Thanks for the reply, but... > +static const struct drm_display_mode default_mode = { + .clock = 222372, + .hdisplay = 1440, + .hsync_start = 1440 + 1, + .hsync_end = 1440 + 1 + 1, + .htotal = 1440 + 1 +

Re: [PATCH 0/3] Fix DECON_UPDATE for TV

2017-01-17 Thread Inki Dae
Hi Andrzej, 2017년 01월 17일 23:15에 Andrzej Hajda 이(가) 쓴 글: > Hi Inki, > > This is my final fight with DECON_UPDATE issues (I hope). My two previous > patches > fixed problems on panel path, this patchset fixes also TV path. > The root cause of all evil was in incorrect DECON_CMU programming. > >

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-30 Thread Inki Dae
2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: > Dear Thierry, > > Could you please review this patch? Thierry, I think this patch has been reviewed enough but no comment from you. Seems you are busy. I will pick up this. Thanks. > > Best Regards, > Hoegeun Kwon > > On 01/11/2017 03:33 PM, Ho

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 Thread Inki Dae
2017년 01월 31일 17:54에 Thierry Reding 이(가) 쓴 글: > On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote: >> >> >> 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: >>> Dear Thierry, >>> >>> Could you please review this patch? >> >> Thierry

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 Thread Inki Dae
2017년 01월 31일 18:22에 Krzysztof Kozlowski 이(가) 쓴 글: > On Tue, Jan 31, 2017 at 2:01 AM, Inki Dae wrote: >> >> >> 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: >>> Dear Thierry, >>> >>> Could you please review this patch? >> >> Thierry, I t

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 Thread Inki Dae
2017-01-31 19:01 GMT+09:00 Krzysztof Kozlowski : > On Tue, Jan 31, 2017 at 11:34 AM, Inki Dae wrote: >> >> >> 2017년 01월 31일 18:22에 Krzysztof Kozlowski 이(가) 쓴 글: >>> On Tue, Jan 31, 2017 at 2:01 AM, Inki Dae wrote: >>>> >>>> >>>&

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 Thread Inki Dae
2017-01-31 20:30 GMT+09:00 Krzysztof Kozlowski : > On Tue, Jan 31, 2017 at 12:37 PM, Inki Dae wrote: >> 2017-01-31 19:01 GMT+09:00 Krzysztof Kozlowski : >>> On Tue, Jan 31, 2017 at 11:34 AM, Inki Dae wrote: >>>> >>>> >>>> 2017년 01월 31일 18:

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 Thread Inki Dae
31, 2017 at 09:54:49AM +0100, Thierry Reding wrote: >>>>> On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote: >>>>>> >>>>>> >>>>>> 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: >>>>>>> Dear Thierry

Re: [PATCH 4/7] drm/exynos/hdmi: add bridge support

2017-01-31 Thread Inki Dae
2017년 01월 20일 15:52에 Andrzej Hajda 이(가) 쓴 글: > In some platforms there is attached another device to the end of HDMI. > The patch adds support for it. Andrzej, can you clarify what bridge device can be attached and actually is now attached to the end of HDMI? And I wonder if we have the device

Re: [PATCH 4/7] drm/exynos/hdmi: add bridge support

2017-01-31 Thread Inki Dae
2017년 02월 01일 16:34에 Andrzej Hajda 이(가) 쓴 글: > On 01.02.2017 08:31, Inki Dae wrote: >> >> 2017년 01월 20일 15:52에 Andrzej Hajda 이(가) 쓴 글: >>> In some platforms there is attached another device to the end of HDMI. >>> The patch adds support for it. >> Andrzej,

Re: [PATCH 4/7] drm/exynos/hdmi: add bridge support

2017-02-01 Thread Inki Dae
2017년 02월 01일 17:12에 Andrzej Hajda 이(가) 쓴 글: > On 01.02.2017 08:44, Inki Dae wrote: >> >> 2017년 02월 01일 16:34에 Andrzej Hajda 이(가) 쓴 글: >>> On 01.02.2017 08:31, Inki Dae wrote: >>>> 2017년 01월 20일 15:52에 Andrzej Hajda 이(가) 쓴 글: >>>>> In some platf

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-09 Thread Inki Dae
2017년 01월 09일 16:37에 Andrzej Hajda 이(가) 쓴 글: > On 06.01.2017 09:36, Inki Dae wrote: >> >> 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >>> Hi Inki, >>> >>> Thanks for the reply, but... >>> >>>>>> +static const str

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-09 Thread Inki Dae
2017년 01월 09일 18:53에 Andrzej Hajda 이(가) 쓴 글: > On 09.01.2017 10:19, Inki Dae wrote: >> >> 2017년 01월 09일 16:37에 Andrzej Hajda 이(가) 쓴 글: >>> On 06.01.2017 09:36, Inki Dae wrote: >>>> 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >>>>

Re: [PATCH 1/3] drm/exynos/decon5433: do not disable video after reset

2017-01-19 Thread Inki Dae
Applied including other two patches. Thanks. 2017년 01월 17일 23:15에 Andrzej Hajda 이(가) 쓴 글: > decon_commit is called just after reset so video is disabled anyway. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- > 1 file changed, 2 deletions(-) > >

Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-08 Thread Inki Dae
_shift = 11, > - .trg_type = I80_HW_TRG, > .has_shadowcon = 1, > .has_vidoutcon = 1, > .has_vtsel = 1, > .has_mic_bypass = 1, > .has_dp_clk = 1, > - .has_hw_trigger = 1, > - .has_trigger_per_te = 1, We don't need to remove above two lines.

Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-09 Thread Inki Dae
Hi Javier, 2016년 06월 09일 09:17에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > Thanks for your feedback. > > On 06/08/2016 07:09 PM, Inki Dae wrote: >> Hi Javier, >> >> 2016년 06월 02일 23:20에 Javier Martinez Canillas 이(가) 쓴 글: >>> Commit a6f75

Re: [PATCH v4 1/3] drm/exynos: mic: Add mode_set callback function

2017-01-03 Thread Inki Dae
2017년 01월 04일 15:58에 Hoegeun Kwon 이(가) 쓴 글: > Before applying the patch, used the of_get_videomode function to > parse the display-timings in the panel which is the child driver > of dsi in the devicetree. this is wrong. So removed the > of_get_videomode and fixed to get videomode struct through

Re: [PATCH v2] dma-buf: Wait on the reservation object when sync'ing before CPU access

2016-12-18 Thread Inki Dae
2016년 08월 16일 01:02에 Daniel Vetter 이(가) 쓴 글: > On Mon, Aug 15, 2016 at 04:42:18PM +0100, Chris Wilson wrote: >> Rendering operations to the dma-buf are tracked implicitly via the >> reservation_object (dmabuf->resv). This is used to allow poll() to >> wait upon outstanding rendering (or just quer

Re: [PATCH] drm/exynos: Print kernel pointers in a restricted form

2017-03-14 Thread Inki Dae
Merged. Thanks, Inki Dae 2017년 03월 15일 03:38에 Krzysztof Kozlowski 이(가) 쓴 글: > Printing raw kernel pointers might reveal information which sometimes we > try to hide (e.g. with Kernel Address Space Layout Randomization). Use > the "%pK" format so these pointers will be hidd

Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681: suspicious mask ?

2017-03-08 Thread Inki Dae
Hello David, Thanks for report. 2017년 03월 06일 19:05에 David Binderman 이(가) 쓴 글: > Hello there, > > linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) > Result of operator '|' is always true if one operand is non-zero. Did you > intend to use '&'? > Right. this is kno

Re: [RESEND] drm/exynos: Remove support for Exynos4415 (SoC not supported anymore)

2017-03-13 Thread Inki Dae
Merged. Thanks. 2017년 03월 12일 03:04에 Krzysztof Kozlowski 이(가) 쓴 글: > Support for Exynos4415 is going away because there are no internal nor > external users. > > Since commit 46dcf0ff0de3 ("ARM: dts: exynos: Remove exynos4415.dtsi"), > the platform cannot be instantiated so remove also the drive

Re: [PATCH v7 1/4] drm/exynos: mic: Add mode_set callback function

2017-01-10 Thread Inki Dae
Applied. Thanks. 2017년 01월 05일 19:20에 Hoegeun Kwon 이(가) 쓴 글: > Before applying the patch, used the of_get_videomode function to > parse the display-timings in the panel which is the child driver > of dsi in the devicetree. this is wrong. So removed the > of_get_videomode and fixed to get videomod

Re: [PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function

2017-01-10 Thread Inki Dae
Applied. Thanks. 2017년 01월 05일 19:20에 Hoegeun Kwon 이(가) 쓴 글: > The OF graph is not necessary because the panel is a child of > dsi. therefore, the parse_dt function of dsi does not need to > check the remote_node connected to the panel. and the whole > parse_dt function should be refactored later

Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

2017-01-11 Thread Inki Dae
2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: > On 11.01.2017 07:33, Hoegeun Kwon wrote: >> From: Hyungwon Hwang >> >> This patch add the panel device tree node for S6E3HA2 display >> controller to TM2 dts. >> >> Signed-off-by: Hyungwon Hwang >> Signed-off-by: Andrzej Hajda >> Signed-off-by: Ch

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-02-02 Thread Inki Dae
Dear Thierry, 2017년 02월 01일 23:44에 Thierry Reding 이(가) 쓴 글: > On Wed, Feb 01, 2017 at 08:48:30AM +0900, Inki Dae wrote: >> >> >> 2017년 02월 01일 06:31에 Thierry Reding 이(가) 쓴 글: >>> On Tue, Jan 31, 2017 at 10:15:10AM -0800, Eric Anholt wrote: >>>> Th

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-02-02 Thread Inki Dae
Jan 31, 2017 at 10:15:10AM -0800, Eric Anholt wrote: >>>>> Thierry Reding writes: >>>>> >>>>>> [ Unknown signature status ] >>>>>> On Tue, Jan 31, 2017 at 09:38:53AM -0500, Sean Paul wrote: >>>>>

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-02-02 Thread Inki Dae
; On Tue, Jan 31, 2017 at 09:38:53AM -0500, Sean Paul wrote: >>>>>>>> On Tue, Jan 31, 2017 at 09:54:49AM +0100, Thierry Reding wrote: >>>>>>>>> On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote: >>>>>>>>>> >>&g

Re: [PATCH v3 4/7] drm/exynos/hdmi: add bridge support

2017-02-02 Thread Inki Dae
f (hdata->bridge) { > + encoder->bridge = hdata->bridge; > + hdata->bridge->encoder = encoder; > + ret = drm_bridge_attach(encoder->dev, hdata->bridge); arguments of drm_bridge_attach function has been changed so fixed it - trivial

Re: [PATCH v3 4/7] drm/exynos/hdmi: add bridge support

2017-02-02 Thread Inki Dae
2017년 02월 03일 15:38에 Inki Dae 이(가) 쓴 글: > > > 2017년 02월 01일 17:29에 Andrzej Hajda 이(가) 쓴 글: >> On TM2/TM2e platforms HDMI output is connected to MHL bridge >> SiI8620. To allow configure UltraHD modes on the bridge >> and to eliminate unsupported modes this brid

Re: [PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-10 Thread Inki Dae
other DMA devices. Even though IOMMU support is disabled, other framework based DMA drivers can use IOMMU - i.e., GPU driver - and they can use non-contiguous GEM buffer through UMM. (DMABUF) So GEM allocation type is not dependent on IOMMU. Thanks, Inki Dae > allocate non-contiguous memory

Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-12 Thread Inki Dae
2016년 06월 10일 09:24에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > On Thu, Jun 9, 2016 at 6:35 PM, Inki Dae wrote: > > [snip] > >>> I know that removing .trg_type is enough but I also removed those lines >>> because the fields are not used if

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-24 Thread Inki Dae
Hi Guestavo, 2016년 03월 24일 23:39에 Gustavo Padovan 이(가) 쓴 글: > Hi Inki, > > 2016-03-24 Inki Dae : > >> Hi, >> >> 2016년 03월 24일 03:47에 Gustavo Padovan 이(가) 쓴 글: >>> From: Gustavo Padovan >>> >>> Hi, >>> >>> This is a firs

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-24 Thread Inki Dae
2016년 03월 25일 00:40에 Rob Clark 이(가) 쓴 글: > On Thu, Mar 24, 2016 at 4:18 AM, Inki Dae wrote: >> Hi, >> >> 2016년 03월 24일 03:47에 Gustavo Padovan 이(가) 쓴 글: >>> From: Gustavo Padovan >>> >>> Hi, >>> >>> This is a first proposal to d

Re: [patch 2/2] drm/exynos: mic: remove some dead code

2016-03-25 Thread Inki Dae
val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX); > > regmap_write(mic->sysreg, DSD_CFG_MUX, val); > - if (ret) > - DRM_ERROR("mic: Failed to read system register\n"); I think we missed to keep return value from regmap_write function, ret = regm

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-27 Thread Inki Dae
Hi Rob and Daniel, 2016년 03월 25일 21:10에 Daniel Stone 이(가) 쓴 글: > Hi all, > > On 25 March 2016 at 11:58, Rob Clark wrote: >> On Thu, Mar 24, 2016 at 7:49 PM, Inki Dae wrote: >>> It's definitely different case. This tries to add new user-space interfaces >>&

Re: [PATCH 0/3] drm/exynos: Kconfig dependency fixes

2016-03-28 Thread Inki Dae
Hi Javier, Thanks for your patch set. Will merge them if there is no issue. Thanks, Inki Dae 2016년 03월 29일 10:28에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > This patch series contains some fixes for the Kconfig symbol dependencies > of the Exynos DRM driver. They make s

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-28 Thread Inki Dae
Hi Daniel, 2016년 03월 28일 22:26에 Daniel Stone 이(가) 쓴 글: > Hi Inki, > > On 28 March 2016 at 02:26, Inki Dae wrote: >> 2016년 03월 25일 21:10에 Daniel Stone 이(가) 쓴 글: >>> Second, really. Vulkan avoids implicit sync entirely, and exposes >>> fence-like primitives throug

Re: [PATCH v8 01/17] drm: exynos: dp: convert to drm bridge mode

2016-03-22 Thread Inki Dae
y: Javier Martinez Canillas > Signed-off-by: Yakir Yang Acked-by: Inki Dae Thanks, Inki Dae > --- > Changes in v8: None > Changes in v7: None > Changes in v6: > - Fix the wrong code in previous series, and test on Samsung snow Chromebook > successfully, here are the detail

Re: Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-22 Thread Inki Dae
, How about adding you as a drm bridge maintainer? DRM SoC driver maintainers would need a person who can manage the drm bridge relevant pathes. Thanks, Inki Dae > > Thanks > Heiko > >

Re: Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-22 Thread Inki Dae
2016년 03월 23일 07:52에 Heiko Stübner 이(가) 쓴 글: > Am Mittwoch, 23. März 2016, 07:44:59 schrieb Inki Dae: >> + Ajay kumar with Samsung email >> >> Hi, >> >> 2016년 03월 23일 07:12에 Heiko Stübner 이(가) 쓴 글: >>> Hi, >>> >>> Am Dienstag, 22. März

Re: Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-22 Thread Inki Dae
2016년 03월 23일 08:39에 Russell King - ARM Linux 이(가) 쓴 글: > On Wed, Mar 23, 2016 at 08:09:33AM +0900, Inki Dae wrote: >> In this case, someone else may send an email again like you "who is going to >> merge?" >> That would be why we need a maintainer. >> &g

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-24 Thread Inki Dae
n explan why Android specific thing is tried to spread into Linux DRM? Was there any consensus to use Android sync driver - which uses explicit sync interfaces - as Linux standard? Thanks, Inki Dae > > /** > * struct fence_collection - aggregate fences together > * @num_

Re: [PATCH] drm/exynos: fix building without CONFIG_PM_SLEEP

2016-01-25 Thread Inki Dae
ght thing in all cases and >> also looks nicer. >> >> Signed-off-by: Arnd Bergmann >> Fixes: ("drm/exynos: add pm_runtime to Mixer") > > Dear Inki, > > Ping? On 4.5-rc1 this is still broken. Can you apply this for fixes > for current rc-cycle?

Re: [PATCH] drm/exynos: fix building without CONFIG_PM_SLEEP

2016-01-25 Thread Inki Dae
M since original auther, Gustavo Padovan, posted runtime pm support. However, it seems missing this one. Thanks, Inki Dae > -static int exynos_mixer_suspend(struct device *dev) > +static int __maybe_unused exynos_mixer_suspend(struct device *dev) > { > struct mixer_conte

Re: [PATCH] drm/exynos: fix ref count leak in mic_pre_enable

2020-06-14 Thread Inki Dae
oto turn_off; How about just calling pm_runtime_put_noidle()? if (ret < 0) { pm_runtime_put_noidle(mic->dev); goto unlock; } Thanks, Inki Dae > > mic_set_path(mic, 1); > >

Re: [PATCH v7 08/36] drm: exynos: fix common struct sg_table related issues

2020-07-13 Thread Inki Dae
ways, hides references to the > nents and orig_nents entries, making the code robust, easier to follow > and copy/paste safe. > > Signed-off-by: Marek Szyprowski Acked-by : Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 +- > 1 file

Re: [PATCH v7 07/36] drm: exynos: use common helper for a scatterlist contiguity check

2020-07-13 Thread Inki Dae
20. 6. 19. 오후 7:36에 Marek Szyprowski 이(가) 쓴 글: > Use common helper for checking the contiguity of the imported dma-buf. > > Signed-off-by: Marek Szyprowski Acked-by : Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_gem.c | 23 +++ &g

Re: [PATCH 14/18] drm/exynos: Consolidate IOMMU mapping code

2020-09-20 Thread Inki Dae
> --- > This is a cheeky revert of 07dc3678bacc ("drm/exynos: Fix cleanup of > IOMMU related objects"), plus removal of the remaining arm_iommu_* > references on top. Thanks for cleanup. Acked-by: Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos5433

Re: [PATCH] drm/exynos: dsi: Remove bridge node reference in error handling path in probe function

2020-05-12 Thread Inki Dae
call to the end of the probe function to handle the error simply. dsi->in_bridge_node is accessed in bind function and the probe function is called before the bind call. Could you rework and post it again? Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 28 +++

Re: [PATCH v2] drm/exynos: fix ref count leak in mic_pre_enable

2020-06-15 Thread Inki Dae
Navid Emamdoost > --- > Changes in v2: > - reuse the unlock label and call pm_runtime_put_noidle Picked it up. Thanks, Inki Dae > --- > --- > drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/dr

Re: [PATCH v2] drm/exynos: dsi: Remove bridge node reference in error handling path in probe function

2020-05-17 Thread Inki Dae
20. 5. 16. 오후 7:57에 Christophe JAILLET 이(가) 쓴 글: > 'exynos_dsi_parse_dt()' takes a reference to 'dsi->in_bridge_node'. > This must be released in the error handling path. Picked it up. Thanks, Inki Dae > > In order to do that, add an error handling path

Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function

2017-03-28 Thread Inki Dae
Merged. Thanks, Inki Dae 2017년 03월 22일 10:36에 Hoegeun Kwon 이(가) 쓴 글: > Hi inki, > > Could you check the this patch? > For reference, patch 1/5 and 2/5 have already been applied to Krzysztof tree. > > Best regards, > Hoegeun > > > On 03/08/2017 01:54 PM, Hoegeun

Re: [PATCH v2 2/3] drm/panel: s6e3ha2: Add support for s6e3hf2 panel on TM2e board

2017-04-18 Thread Inki Dae
display mode that matches the type. So add the check code for s6e3ha2 >> compatibility and s6e3hf2 type and select the drm_display_mode of >> default and edge type. >> >> Signed-off-by: Hoegeun Kwon > Reviewed-by: Andrzej Hajda Reviewed-by: Inki Dae Thanks, Inki Dae

Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function

2017-04-05 Thread Inki Dae
2017년 04월 05일 00:38에 Krzysztof Kozlowski 이(가) 쓴 글: > On Tue, Mar 28, 2017 at 11:38 AM, Krzysztof Kozlowski wrote: >> On Tue, Mar 28, 2017 at 11:26 AM, Inki Dae wrote: >>> Merged. >> >> Hi, >> >> I do not see the tag (with DT patches) merged by you wh

Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function

2017-04-05 Thread Inki Dae
2017년 04월 05일 00:38에 Krzysztof Kozlowski 이(가) 쓴 글: > On Tue, Mar 28, 2017 at 11:38 AM, Krzysztof Kozlowski wrote: >> On Tue, Mar 28, 2017 at 11:26 AM, Inki Dae wrote: >>> Merged. >> >> Hi, >> >> I do not see the tag (with DT patches) merged by you wh

Re: [PATCH] arm64: dts: exynos: Remove the te-gpios property in the TM2 boards

2017-04-25 Thread Inki Dae
-60,7 +60,6 @@ > vci-supply = <&ldo28_reg>; > reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; > enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; > - te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; Reviewed-by: Inki Dae Thanks, Inki Dae > }; > }; > >

Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

2017-06-27 Thread Inki Dae
l call > of_drm_find_bridge on dsi->bridge_node which was put earlier (point 2.). > Right. This is a problem. How about moving of_drm_find_bridge function call to probe and keeping drm_bridge_attach call in bind for cleanup? Seems it doesn't need to call of_drm_find_bridge fun

Re: [PATCH] [v2] drm/exynos: g2d: use monotonic timestamps

2018-02-05 Thread Inki Dae
format. Even if > there is something looking at them, it will work just fine with > monotonic times as long as the application only looks at the > relative values between two events. > > Link: https://patchwork.kernel.org/patch/10038593/ > Cc: Tobias Jakobi > Signed-off-by: A

Re: [PATCH 2/4] drm/exynos: fix comparison to bitshift when dealing with a mask

2018-02-05 Thread Inki Dae
CIIMGEFF_PAT_CBCR_MASK((0xff < 13) | (0xff < > 0)) > +#define EXYNOS_CIIMGEFF_PAT_CBCR_MASK((0xff << 13) | (0xff > << 0)) > Oops. Picked it up. Thanks, Inki Dae > /* Real input DMA size register */ > #define EXYNOS_CIREAL_ISIZE_AUTOLOAD_ENABLE (1 << 31) >

Re: [PATCH] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

2017-06-13 Thread Inki Dae
case of Exynos SoC, a bridge device such as mDNIe and MIC could be placed between Display Controller and MIPI DSI device but the bridge device is required optionally. Thanks, Inki Dae > > Signed-off-by: Hoegeun Kwon > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 -- >

Re: [PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-10-19 Thread Inki Dae
Hi Shuah, 2016-10-13 8:11 GMT+09:00 Shuah Khan : > Hi Inki, > > On 08/15/2016 10:40 PM, Inki Dae wrote: > >>> >>> okay the very first commit that added IOMMU support >>> introduced the code that rejects non-contig gem memory

Re: [PATCH V2] gpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap

2016-10-19 Thread Inki Dae
Will pick it up soon. Thanks, Inki Dae 2016-10-19 19:04 GMT+09:00 Arvind Yadav : > Free memory mapping, if hdmi_probe is not successful. > > Signed-off-by: Arvind Yadav > --- > drivers/gpu/drm/exynos/exynos_hdmi.c |5 + > 1 file changed, 5 insertions(+) > > diff

Re: [PATCH] exynos-drm: Fix error messages to print flags and size

2016-10-19 Thread Inki Dae
2016-10-06 22:09 GMT+09:00 Tobias Jakobi : > Hello, > > I think this patch was never picked up. So just a short 'ping' from my side. > Oops. one I missed. Will pick it up soon. Thanks, Inki Dae > With best wishes, > Tobias > > > Shuah Khan wrote: >> Fi

Re: [PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-15 Thread Inki Dae
Hi Shuah, 2016년 08월 13일 02:52에 Shuah Khan 이(가) 쓴 글: > On 08/12/2016 11:28 AM, Shuah Khan wrote: >> On 08/10/2016 05:05 PM, Shuah Khan wrote: >>> On 08/10/2016 04:59 PM, Inki Dae wrote: >>>> Hi Shuah, >>>> >>>> 2016년 08월 11일 02:30에 Shua

<    1   2