RE: [PATCH] Input: wdt87xx_i2c - support new body WDT8752

2016-09-08 Thread Hn Chen
Hi Dmitry, >> Considering to be compatible with i2c-hid, WDT8752 has the same way in >> enumerating device. >If it is a HID device then I think you should write a HID driver for it >(unless existing driver, such as hid-multitouch can already handle it, >possibly >with some changes). I'm addng B

RE: [PATCH v5] Fix the resolution issue in ChromeOS

2015-06-13 Thread Hn Chen
Hi, Frans, It can only be delay for the firmware implementation now. Hn.chen -Original Message- From: Frans Klaver [mailto:franskla...@gmail.com] Sent: Friday, June 12, 2015 6:02 PM To: Hn Chen Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org; Dmitry Torokhov Subject: Re

RE: [PATCH v5] Fix the resolution issue in ChromeOS

2015-06-10 Thread Hn Chen
Hi, Dmitry, Thanks for your suggestion ! > Thank you for making changes, I have some more comments. By the way, have you > tried running scripts/checkpatch.pl over your patch? > It often picks up some common issues. I did the check before I submit the patch every time. Below is the way what I

RE: [PATCH v5] Fix the resolution issue in ChromeOS

2015-06-10 Thread Hn Chen
0 ms per 1024 bytes. But in some situation, the controller will change it's running frequency(like do noise immunity), 10ms could be too margin. Hn.chen -Original Message- From: Frans Klaver [mailto:franskla...@gmail.com] Sent: Tuesday, June 02, 2015 2:18 AM To: Hn Chen Cc: linu

RE: [PATCH v3] Fix endian issues and remove the board specific codes

2015-05-21 Thread Hn Chen
Hi, Dmitry, Thanks for your comments. Here are my replies for some comments. > + fw_id = ((fw_chunk_info.chunk_info.version_number >> 12) & 0xF); > + chip_id = (((dev_wdt87xx->sys_param.fw_id) >> 12) & 0xF); > + > + if (fw_id != chip_id) { > + wdt87xx_get_sysparam(client,

RE: [PATCH v3] Fix endian issues and remove the board specific codes

2015-05-25 Thread Hn Chen
- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Saturday, May 23, 2015 7:37 AM To: Hn Chen Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] Fix endian issues and remove the board specific codes Hi Hn, On Thu, May 21, 2015 at 03:43:08PM

RE: [PATCH v2] Fix the license mismatch and add the resolution setting

2015-05-10 Thread Hn Chen
-- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Thursday, May 07, 2015 1:36 PM To: Hn Chen Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Fix the license mismatch and add the resolution setting Hi Hn, On Tue, Apr 28, 2015 at 06:35:58PM +0

RE: [PATCH] Input: wdt87xx_i2c - Add a scaling factor for TOUCH_MAJOR event

2015-07-01 Thread Hn Chen
Hi, Dmitry, Ok, Thanks I really appreciate your help ! BR, Hn.chen -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Thursday, July 02, 2015 2:35 AM To: Hn Chen Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input

RE: [PATCH] Input: wdt87xx_i2c - Add a prodcut_id attribute in sysfs

2015-07-10 Thread Hn Chen
From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Friday, July 10, 2015 2:06 AM To: Hn Chen Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org; charliemoo...@google.com Subject: Re: [PATCH] Input: wdt87xx_i2c - Add a prodcut_id attribute in sysfs Hi Hn, On Thu, Jul 09,

RE: [PATCH] Input: wdt87xx_i2c - Add a prodcut_id attribute in sysfs

2015-07-10 Thread Hn Chen
Hi, Dmitry, Thanks for your suggestion ! I will just follow your suggestion and resubmit a patch! BR, Hn.chen -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Friday, July 10, 2015 5:00 AM To: Hn Chen Cc: linux-in...@vger.kernel.org; linux-kernel

RE: [PATCH] Input: wdt87xx_i2c - Add a prodcut_id attribute in sysfs

2015-07-10 Thread Hn Chen
@@ } /* Wait the device to be ready */ - msleep(200); + msleep(WDT_FW_RESET_TIME); return 0; } Hn.chen -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Friday, July 10, 2015 10:34 PM To: Hn Chen Cc: linux-in...@vger.kernel.org

RE: [PATCH] Input: wdt87xx_i2c - Change the sleep time to 2500ms after the sw reset

2015-07-13 Thread Hn Chen
Hi, Dmitry, Thanks ! BR, Hn.chen. -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Sunday, July 12, 2015 2:29 PM To: Hn Chen Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org; charliemoo...@google.com Subject: Re: [PATCH] Input: wdt87xx_i2c

RE: [PATCH] Input: wdt87xx_i2c - support new body WDT8752

2016-09-05 Thread Hn Chen
Hi Dmitry, >> Considering to be compatible with i2c-hid, WDT8752 has the same way in >> enumerating device. >If it is a HID device then I think you should write a HID driver for it >(unless existing driver, such as hid-multitouch can already handle it, >possibly >with some changes). I'm addng B

RE: [PATCH] Input: wdt87xx_i2c - support new body WDT8752

2016-09-06 Thread Hn Chen
16 9:56 PM To: Hn Chen Cc: Dmitry Torokhov; linux-in...@vger.kernel.org; lkml Subject: Re: [PATCH] Input: wdt87xx_i2c - support new body WDT8752 Hi HN, On Sep 05 2016 or thereabouts, Hn Chen wrote: > Hi Dmitry, > > >> Considering to be compatible with i2c-hid, WDT8752 has the same