Re: [PATCH RFC/RFT v2 3/8] s390: move cacheinfo sysfs to generic cacheinfo infrastructure

2014-02-10 Thread Heiko Carstens
On Mon, Feb 10, 2014 at 11:34:55AM +, Sudeep Holla wrote: > On 10/02/14 09:50, Heiko Carstens wrote: > > On Fri, Feb 07, 2014 at 04:49:18PM +, Sudeep Holla wrote: > >> - show_cacheinfo(m); > >>} > >>get_online_cpus(); > >>i

Re: [RFC PATCH v3 13/19] smp, s390: prepare for killing generic_smp_call_function_single_interrupt()

2013-12-06 Thread Heiko Carstens
On Thu, Dec 05, 2013 at 12:13:04AM +0800, Jiang Liu wrote: > Signed-off-by: Jiang Liu > --- > arch/s390/kernel/smp.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) I assume you will take care and make sure it gets merged? Besides that: Acked-by: Heiko Cars

Re: [PATCH] s390/locking: Reenable optimistic spinning

2014-08-06 Thread Heiko Carstens
On Tue, Aug 05, 2014 at 09:57:51AM +0200, Christian Borntraeger wrote: > commit 4badad352a6bb202ec68afa7a574c0bb961e5ebc (locking/mutex: Disable > optimistic spinning on some architectures) fenced spinning for > architectures without proper cmpxchg. > There is no need to disable mutex spinning on s

Re: [PATCH] s390: add support for DYNAMIC_FTRACE_WITH_REGS

2014-08-15 Thread Heiko Carstens
On Tue, Jul 08, 2014 at 10:07:40AM +0200, Heiko Carstens wrote: > On Thu, Jul 03, 2014 at 02:00:46PM +0200, Vojtech Pavlik wrote: > > Add support for DYNAMIC_FTRACE_WITH_REGS to 64-bit and 31-bit s390 > > architectures. This is required for kGraft and kpatch to work on s390. > &

[PATCH 1/5] s390: pass march flag to assembly files as well

2014-08-15 Thread Heiko Carstens
march flag when compiling assembler files as well. Signed-off-by: Heiko Carstens --- arch/s390/Makefile | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/arch/s390/Makefile b/arch/s390/Makefile index 874e6d6e9c5f..878e67973151 100644 --- a/arch/s390/Makefile

[PATCH 2/5] s390/ftrace: optimize patched mcount calling code

2014-08-15 Thread Heiko Carstens
We can skip executing the first "stg" instruction of the patched and disabled mcount code in function tracer enabled kernels. This saves one instruction per function. Signed-off-by: Heiko Carstens --- arch/s390/include/asm/ftrace.h | 2 +- arch/s390/kernel/ftrace.c

[PATCH 4/5] s390/ftrace: add HAVE_DYNAMIC_FTRACE_WITH_REGS support

2014-08-15 Thread Heiko Carstens
e explicitly do not use the psw_t member of struct pt_regs to pass (and modify) r14, since that would result in a fake psw where the mask member is invalid. In addition r14 and the psw_t member have different semantics anyway. Cc: Vojtech Pavlik Cc: Jiri Kosina Cc: Jiri Slaby Cc: Steven Rosted

[PATCH 3/5] s390/ftrace: optimize function graph caller code

2014-08-15 Thread Heiko Carstens
When the function graph tracer is disabled we can skip three additional instructions. So let's just do just this. So if function tracing is enabled but function graph tracing is runtime disabled, we get away with a single unconditional branch. Signed-off-by: Heiko Carstens --- arch

[PATCH 5/5] s390/ftrace: enforce DYNAMIC_FTRACE if FUNCTION_TRACER is selected

2014-08-15 Thread Heiko Carstens
that functionality got moved to architecture independent code in the meantime. Signed-off-by: Heiko Carstens --- arch/s390/Kconfig | 1 + arch/s390/kernel/Makefile | 4 +--- arch/s390/kernel/ftrace.c | 6 -- arch/s390/kernel/mcount.S | 2 -- arch/s390/kernel/mcount64.S | 2 -- 5

Re: [PATCH] netlink: Re-add locking to netlink_lookup() and seq walker

2014-10-21 Thread Heiko Carstens
destruction has been RCUfied. > > Signed-off-by: Thomas Graf > --- > net/netlink/af_netlink.c | 37 + > 1 file changed, 25 insertions(+), 12 deletions(-) Thanks a lot! Your patch fixes the issue for me. Reported-and-tested-by: Heiko Carstens -- To

[PATCH v3 0/2] s390 vs. kprobes on ftrace

2014-10-21 Thread Heiko Carstens
make this work a small common code change is necessary which removes a check if kprobe is being placed on an ftrace location (see first patch). If possible, I'd like to have an ACK from at least one of the kprobes maintainers for the first patch and bring it upstream via the s390 tree

[PATCH v3 2/2] s390/ftrace,kprobes: allow to patch first instruction

2014-10-21 Thread Heiko Carstens
r which executes the function trace caller instruction won't be executed concurrently to any stop_machine() execution. This allows to keep full fault based kprobes handling which generates correct correct pt_regs contents automatically. Signed-off-by: Heiko Carstens --- arch/s390/include/as

[PATCH v3 1/2] kprobes: introduce weak arch_check_ftrace_location() helper function

2014-10-21 Thread Heiko Carstens
Introduce weak arch_check_ftrace_location() helper function which architectures can override in order to implement handling of kprobes on function tracer call sites on their own, without depending on common code or implementing the KPROBES_ON_FTRACE feature. Signed-off-by: Heiko Carstens

Re: [PATCH 1/2] ftracetest: add kprobes on ftrace testcase

2014-10-21 Thread Heiko Carstens
On Tue, Oct 21, 2014 at 06:21:05PM +0900, Masami Hiramatsu wrote: > (2014/10/20 19:52), Heiko Carstens wrote: > > Add a kprobes on ftrace testcase. The testcase verifies that > > - enabling and disabling function tracing works on a function which > > already cont

Re: [PATCH v3 1/2] kprobes: introduce weak arch_check_ftrace_location() helper function

2014-10-21 Thread Heiko Carstens
On Tue, Oct 21, 2014 at 06:30:56PM +0900, Masami Hiramatsu wrote: > (2014/10/21 17:30), Heiko Carstens wrote: > > Introduce weak arch_check_ftrace_location() helper function which > > architectures can override in order to implement handling of kprobes > > on function trace

Re: [PATCH v3 0/2] s390 vs. kprobes on ftrace

2014-10-22 Thread Heiko Carstens
On Tue, Oct 21, 2014 at 09:58:31PM +0200, Vojtech Pavlik wrote: > Hello Heiko, > > I can confirm that kGraft works well on top of current mainline with > this patch added. > > Another reason for a performance impact when kGraft is enabled is that > kGraft still adds two instructions to the syscal

[PATCH 2/2] s390/ftrace,kprobes: allow to patch first instruction

2014-10-15 Thread Heiko Carstens
r which executes the function trace caller instruction won't be executed concurrently to any stop_machine() execution. This allows to keep full fault based kprobes handling which generates correct correct pt_regs contents automatically. Signed-off-by: Heiko Carstens --- arch/s390/Kconfig

[PATCH 0/2] s390 vs. kprobes on ftrace

2014-10-15 Thread Heiko Carstens
of the kprobes maintainers for the first patch and bring it upstream via the s390 tree. Thanks, Heiko Heiko Carstens (2): kprobes: introduce ARCH_HANDLES_KPROBES_ON_FTRACE s390/ftrace,kprobes: allow to patch first instruction arch/Kconfig| 8 +++ arch/s390/Kconfig

[PATCH 1/2] kprobes: introduce ARCH_HANDLES_KPROBES_ON_FTRACE

2014-10-15 Thread Heiko Carstens
the architecture. Signed-off-by: Heiko Carstens --- arch/Kconfig | 8 kernel/kprobes.c | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/Kconfig b/arch/Kconfig index 05d7a8a458d5..e1a8e0edf03f 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -85,6 +85,14

Re: [PATCH 1/2] s390: Remove unneeded semicolon

2015-08-05 Thread Heiko Carstens
On Tue, Aug 04, 2015 at 05:11:15PM +0200, Peter Senna Tschudin wrote: > Remove unneeded semicolon. > > The semantic patch that detects this change is available > at scripts/coccinelle/misc/semicolon.cocci. > > Signed-off-by: Peter Senna Tschudin > --- > Tested by cross compilation only. > > dr

Re: [PATCH 2/2] s390: Remove unneeded variables

2015-08-05 Thread Heiko Carstens
On Tue, Aug 04, 2015 at 05:11:47PM +0200, Peter Senna Tschudin wrote: > This patch remove unneeded variables used to store return values. > > These issues were detected with the Coccinelle script: > scripts/coccinelle/misc/returnvar.cocci > > Signed-off-by: Peter Senna Tschudin > --- > static s

Re: [PATCH -next] s390: lib: Export __delay

2015-08-05 Thread Heiko Carstens
On Tue, Aug 04, 2015 at 11:38:23PM -0700, Guenter Roeck wrote: > __delay is exported by most architectures, and may be used in modules. > Since it is not exported for s390, s390:allmodconfig currently fails > to build with > > ERROR: "__delay" [drivers/net/phy/mdio-octeon.ko] undefined! > > Fixes

Re: [PATCH V3 2/5] mm: mlock: Add new mlock, munlock, and munlockall system calls

2015-07-07 Thread Heiko Carstens
On Tue, Jul 07, 2015 at 01:03:40PM -0400, Eric B Munson wrote: > With the refactored mlock code, introduce new system calls for mlock, > munlock, and munlockall. The new calls will allow the user to specify > what lock states are being added or cleared. mlock2 and munlock2 are > trivial at the mo

Re: [PATCH -v2 6/8] jump_label: Add a new static_key interface

2015-07-28 Thread Heiko Carstens
| 143 > ++++-- > kernel/jump_label.c | 35 ++-- > 9 files changed, 294 insertions(+), 39 deletions(-) for the s390 part: Acked-by: Heiko Carstens -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

Re: [PATCH -v2 0/8] jump_label: Another (better) static_key interface

2015-07-28 Thread Heiko Carstens
ou may include the s390 patch below, so the conversion to the new interface happens when your code gets merged: >From 3c9b5a2b9a90d6bb2b41f381f5f89b3657fe4ea5 Mon Sep 17 00:00:00 2001 From: Heiko Carstens Date: Wed, 29 Jul 2015 08:31:24 +0200 Subject: [PATCH] s390/uaccess: employ static_branch_

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 11:52:25AM +0200, Peter Zijlstra wrote: > > +static __always_inline bool arch_static_branch_jump(struct static_key > > *key, bool branch) > > +{ > > + asm_volatile_goto("0: j %l[l_yes]\n" > > Looking at the s390 version of jump_label_make_branch(), this should > have b

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 12:45:10PM +0200, Peter Zijlstra wrote: > --- a/arch/s390/include/asm/jump_label.h > +++ b/arch/s390/include/asm/jump_label.h > +static __always_inline bool arch_static_branch_jump(struct static_key *key, > bool branch) > +{ > + asm_volatile_goto("0: brcl 15, %l[l_yes

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 12:50:36PM +0200, Peter Zijlstra wrote: > On Mon, Jul 27, 2015 at 12:47:55PM +0200, Peter Zijlstra wrote: > > On Mon, Jul 27, 2015 at 12:20:46PM +0200, Heiko Carstens wrote: > > > On Mon, Jul 27, 2015 at 11:52:25AM +0200, Peter Zijlstra wrote:

Re: [RFC][PATCH 5/7] jump_label: Rework update logic

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 06:30:05PM +0200, Peter Zijlstra wrote: > On Mon, Jul 27, 2015 at 12:47:14PM +0200, Peter Zijlstra wrote: > > @@ -68,13 +63,8 @@ void static_key_slow_inc(struct static_k > > return; > > > > jump_label_lock(); > > + if (atomic_inc_and_test(&key->enabled))

Re: [PATCH v2] s390/cpum_cf: Remove superfluous SMP function call

2016-05-02 Thread Heiko Carstens
this SMP > function calls are no longer required. > > Replace smp_call_function_single() with a direct call of > setup_pmc_cpu(). To keep the calling convention, interrupts are > explicitly disabled around the call. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: li

Re: [PATCH v2] s390/cpum_sf: Remove superfluous SMP function call

2016-05-02 Thread Heiko Carstens
this SMP > function calls are no longer required. > > Replace smp_call_function_single() with a direct call of > setup_pmc_cpu(). To keep the calling convention, interrupts are > explicitly disabled around the call. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: li

Re: [PATCH] ks390/keyboard: use memdup_user().

2016-05-20 Thread Heiko Carstens
On Fri, May 20, 2016 at 05:52:16PM +0530, Muhammad Falak R Wani wrote: > Use memdup_user to duplicate a memory region from user-space to > kernel-space, instead of open coding using kmalloc & copy_from_user. > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/s390/char/keyboard.c | 10 +++--

Re: [PATCH v2] ks390/keyboard: use memdup_user_nul().

2016-05-20 Thread Heiko Carstens
On Fri, May 20, 2016 at 06:51:20PM +0530, Muhammad Falak R Wani wrote: > Use memdup_user_nul to duplicate a memory region from user-space > to kernel-space and terminate with a NULL, instead of open coding > using kmalloc + copy_from_user and explicitly NULL terminating. > > Signed-off-by: Muhamma

Re: [PATCH 01/23] all: syscall wrappers: add documentation

2016-05-26 Thread Heiko Carstens
On Wed, May 25, 2016 at 12:30:17PM -0700, David Miller wrote: > From: Yury Norov > Date: Tue, 24 May 2016 03:04:30 +0300 > > > +To clear that top halves, automatic wrappers are introduced. They clear all > > +required registers before passing control to regular syscall handler. > > Why have one

Re: [PATCH 01/23] all: syscall wrappers: add documentation

2016-05-26 Thread Heiko Carstens
> > > The cost is pretty trivial though. See kernel/compat_wrapper.o: > > > COMPAT_SYSCALL_WRAP2(creat, const char __user *, pathname, umode_t, mode); > > > 0: a9bf7bfdstp x29, x30, [sp,#-16]! > > > 4: 910003fdmov x29, sp > > > 8: 2a0003e0mov w0, w0 > > > c

Re: [PATCH] qeth: don't rely on signedness of char

2015-12-07 Thread Heiko Carstens
On Mon, Dec 07, 2015 at 01:02:35PM +0100, Ursula Braun wrote: > Rasmus, > > I do not see a need for your first patch proposal. Our code works fine > in our environment. > > But I will pickup your second part to remove the explicit setting of the > 0-termination. Thanks! > > Regards, Ursula Hi U

Re: [PATCH] qeth: don't rely on signedness of char

2015-12-07 Thread Heiko Carstens
On Mon, Dec 07, 2015 at 02:47:44PM +0100, Heiko Carstens wrote: > On Mon, Dec 07, 2015 at 01:02:35PM +0100, Ursula Braun wrote: > > Rasmus, > > > > I do not see a need for your first patch proposal. Our code works fine > > in our environment. > > > > But I

Re: [PATCH 1/2] kbuild: add AFLAGS_REMOVE_(basename).o option

2015-11-30 Thread Heiko Carstens
On Sat, Nov 21, 2015 at 11:59:58AM +0100, Heiko Carstens wrote: > It is already possible to remove CFLAGS with the CFLAGS_REMOVE option > that was introduced with commit 656ee82cc855 ("kbuild: create new > CFLAGS_REMOVE_(basename).o option"). However it is not possible to

Re: [PATCH] ARM64: fix building without CONFIG_UID16

2015-11-30 Thread Heiko Carstens
On Fri, Nov 20, 2015 at 12:12:21PM +0100, Arnd Bergmann wrote: > As reported by Michal Simek, building an ARM64 kernel with CONFIG_UID16 > disabled currently fails because the system call table still needs to > reference the individual function entry points that are provided by > kernel/sys_ni.c in

Re: [PATCH 1/2] kbuild: add AFLAGS_REMOVE_(basename).o option

2015-11-30 Thread Heiko Carstens
On Mon, Nov 30, 2015 at 09:36:29AM +0100, Michal Marek wrote: > >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > >> index 79e86613712f..26a48d76eb9d 100644 > >> --- a/scripts/Makefile.lib > >> +++ b/scripts/Makefile.lib > >> @@ -104,8 +104,9 @@ modname_flags = $(if $(filter 1,$(words

Re: [PATCH v2 1/4] init: create cmdline param to disable readonly

2015-11-30 Thread Heiko Carstens
On Mon, Nov 30, 2015 at 01:52:10PM -0800, Kees Cook wrote: > On Wed, Nov 25, 2015 at 11:51 PM, Ingo Molnar wrote: > > * Kees Cook wrote: > >> +#ifdef CONFIG_DEBUG_RODATA > > > > Btw., could you please remove the Kconfig option altogether in an > > additional patch > > and make read-only sections

Re: [PATCH] x86: Wire up 32-bit direct socket calls

2015-09-11 Thread Heiko Carstens
On Mon, Sep 07, 2015 at 02:53:12PM +0200, Arnd Bergmann wrote: > On Wednesday 02 September 2015 13:16:19 H. Peter Anvin wrote: > > On 09/02/2015 02:48 AM, Geert Uytterhoeven wrote: > > > > > > Should all other architectures follow suit? > > > Or should we follow the s390 approach: > > > > > > >

Re: [GIT PULL] x86 fixes

2015-07-20 Thread Heiko Carstens
On Sat, Jul 18, 2015 at 05:18:10AM +0200, Ingo Molnar wrote: > Linus, > > Please pull the latest x86-urgent-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > x86-urgent-for-linus > ># HEAD: 5aaeb5c01c5b6c0be7b7aadbf3ace9f3a4458c3d x86/fpu, sched: In

Re: [RFC PATCH] sched, s390: Fix the fallout of increasing the offset of 'thread_struct' within 'task_struct'

2015-07-20 Thread Heiko Carstens
On Mon, Jul 20, 2015 at 07:41:55AM -0700, Guenter Roeck wrote: > Commit 0c8c0f03e3a2 ("x86/fpu, sched: Dynamically allocate 'struct fpu'") > moved the thread_struct to the bottom of task_struct. As a result, the > offset is now too large to be used in an immediate stfpc operation on s390, > resulti

[PATCH] lib/bug: make panic_on_warn available for all architectures

2016-01-22 Thread Heiko Carstens
de like it was added to warn_slowpath_common() in panic.c. This enables panic_on_warn also for arm64, parisc, powerpc, s390 and sh. Cc: Prarit Bhargava Reported-by: Christian Borntraeger Signed-off-by: Heiko Carstens --- lib/bug.c | 11 +++ 1 file changed, 11 insertions(+) diff --g

Re: [PATCH] s390: fix normalization bug in exception table sorting

2016-01-04 Thread Heiko Carstens
On Fri, Jan 01, 2016 at 01:39:22PM +0100, Ard Biesheuvel wrote: > The normalization pass in the sorting routine of the relative exception > table serves two purposes: > - it ensures that the address fields of the exception table entries are > fully ordered, so that no ambiguities arise between en

Re: [PATCH 0/6] generic relative extable support

2016-01-04 Thread Heiko Carstens
c search and sort routines > x86/extable: use generic search and sort routines > ia64/extable: use generic search and sort routines > arm64: switch to relative exception tables For the s390 bits: Acked-by: Heiko Carstens -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online()

2016-01-04 Thread Heiko Carstens
On Sun, Jan 03, 2016 at 11:02:00AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 10:48:05 +0100 > > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. > > Signed-off-by: Markus Elfring > --- > drivers/

Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online()

2016-01-04 Thread Heiko Carstens
On Sun, Jan 03, 2016 at 11:02:56AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 10:50:11 +0100 > > Reduce the scope for the local variable "def_discipline" to one branch > of an if statement. > > Signed-off-by: Markus Elfring > --- > drivers/s390/net/qeth_core

Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online()

2016-01-04 Thread Heiko Carstens
On Mon, Jan 04, 2016 at 02:10:34PM +0100, SF Markus Elfring wrote: > >> +++ b/drivers/s390/net/qeth_core_main.c > >> @@ -5638,9 +5638,10 @@ static int qeth_core_set_online(struct > >> ccwgroup_device *gdev) > >> { > >>struct qeth_card *card = dev_get_drvdata(&gdev->dev); > >>int rc; > >>

Re: 390/qeth: Refactoring for qeth_core_set_online()

2016-01-04 Thread Heiko Carstens
On Mon, Jan 04, 2016 at 03:10:41PM +0100, SF Markus Elfring wrote: > > In this case the function body is very small > > so I don't see any benefit at all. > > Do you care for fine-tuning of variable placement occasionally? No. -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH 1/5] all: s390: move wrapper infrastructure to generic headers

2016-02-17 Thread Heiko Carstens
On Tue, Feb 02, 2016 at 11:41:56PM +0300, Yury Norov wrote: > > However I'll try to write an addon patch to your patch series. Maybe we can > > still get rid of compat_wrapper.c in a way which makes both of us happy. > > Also.. the idea with the alias names for compat wrappers does seem to have > >

Re: [RFC v2 4/7] asm/sections: add a generic push_section_tbl()

2016-02-26 Thread Heiko Carstens
On Sun, Feb 21, 2016 at 06:55:05PM -0800, H. Peter Anvin wrote: > On 02/19/16 13:06, Luis R. Rodriguez wrote: > >> > >> I think the \n\t is unnecessary. > > > > Super! I wonder if we we can just use this on s390 as well without it > > pooping? > > I ask as this would set a precedent. > > > > As

Re: [PATCH] lib/bug.c: use common WARN helper

2016-02-23 Thread Heiko Carstens
| 27 +++ > 3 files changed, 35 insertions(+), 43 deletions(-) Nice! Just tested this on s390. Acked-by: Heiko Carstens

Re: [PATCH 2/5] all: introduce COMPAT_WRAPPER option and enable it for s390

2016-02-25 Thread Heiko Carstens
On Wed, Feb 24, 2016 at 09:34:11PM +0300, Yury Norov wrote: > Signed-off-by: Yury Norov > --- > arch/Kconfig | 4 > arch/s390/Kconfig | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/arch/Kconfig b/arch/Kconfig > index f6b649d..6393093 100644 > --- a/arch/Kconfig > +++ b/arch

Re: [PATCH 3/5] all: s390: move wrapper infrastructure to generic headers

2016-02-25 Thread Heiko Carstens
On Wed, Feb 24, 2016 at 09:34:12PM +0300, Yury Norov wrote: > diff --git a/include/linux/syscalls_structs.h > b/include/linux/syscalls_structs.h > new file mode 100644 > index 000..a920cbc > --- /dev/null > +++ b/include/linux/syscalls_structs.h > @@ -0,0 +1,60 @@ > +#ifndef _LINUX_SYSCALL_STR

Re: [PATCH 4/5] all: s390: move compat_wrappers.c from arch/s390/kernel to kernel/

2016-02-25 Thread Heiko Carstens
On Wed, Feb 24, 2016 at 09:34:13PM +0300, Yury Norov wrote: > Some syscalls are declared conditionally, so corresponding wrappers > are conditional accordingly. > > Signed-off-by: Yury Norov > --- > arch/s390/kernel/Makefile | 2 +- > arch/s390/kernel/compat_wrapper.c | 129 ---

Re: [PATCH v2 0/5] all: s390: make compat wrappers the generic solution

2016-02-25 Thread Heiko Carstens
ou may consider the possible changes I sent as reply to some of your patches. However from an s390 point of view: Acked-by: Heiko Carstens

Re: [PATCH 2/5] all: introduce COMPAT_WRAPPER option and enable it for s390

2016-02-25 Thread Heiko Carstens
On Thu, Feb 25, 2016 at 11:19:26PM +0300, Yury Norov wrote: > On Thu, Feb 25, 2016 at 09:49:43AM +0100, Heiko Carstens wrote: > > On Wed, Feb 24, 2016 at 09:34:11PM +0300, Yury Norov wrote: > > > Signed-off-by: Yury Norov > > > --- > > > arch/Kconfig |

Re: [PATCH 3/5] all: s390: move wrapper infrastructure to generic headers

2016-02-25 Thread Heiko Carstens
On Thu, Feb 25, 2016 at 11:23:50PM +0300, Yury Norov wrote: > On Thu, Feb 25, 2016 at 09:51:40AM +0100, Heiko Carstens wrote: > > On Wed, Feb 24, 2016 at 09:34:12PM +0300, Yury Norov wrote: > > > diff --git a/include/linux/syscalls_structs.h > > > b/include/linux/syscal

rcu warning caused by [sched: Fix race between task_group and sched_task_group]

2014-11-19 Thread Heiko Carstens
Hi Kirill, the problem below has already been reported here: https://lkml.org/lkml/2014/11/11/505 but seems there is still no fix available upstream? Would be good to have it soon, since this basically renders lockdep unusable. [0.173906] === [0.173907] [ INFO

Re: [RFC PATCH 06/30] s390: Introduce cputime64_to_nsecs()

2014-12-01 Thread Heiko Carstens
On Fri, Nov 28, 2014 at 07:23:36PM +0100, Frederic Weisbecker wrote: > This will be needed for the conversion of kernel stat to nsecs. > > Cc: Benjamin Herrenschmidt > Cc: Heiko Carstens > Cc: Ingo Molnar > Cc: Martin Schwidefsky > Cc: Oleg Nesterov > Cc: Paul Mackerr

Re: [RFC PATCH 04/30] s390: Convert open coded idle time seqcount

2014-12-01 Thread Heiko Carstens
On Fri, Nov 28, 2014 at 07:23:34PM +0100, Frederic Weisbecker wrote: > s390 uses open coded seqcount to synchronize idle time accounting. > Lets consolidate it with the standard API. > > Cc: Benjamin Herrenschmidt > Cc: Heiko Carstens > Cc: Ingo Molnar > Cc: Martin Sc

Re: [RFC PATCH 05/30] s390: Translate cputime magic constants to macros

2014-12-01 Thread Heiko Carstens
On Fri, Nov 28, 2014 at 07:23:35PM +0100, Frederic Weisbecker wrote: > Make the code more self-explanatory by naming magic constants. > > Cc: Benjamin Herrenschmidt > Cc: Heiko Carstens > Cc: Ingo Molnar > Cc: Martin Schwidefsky > Cc: Oleg Nesterov > Cc: Paul Mackerr

[PATCH] softirq/preempt: add missing current->preempt_disable_ip update

2014-11-24 Thread Heiko Carstens
he missing update of current->preempt_disable_ip to __local_bh_disable_ip() as well. Signed-off-by: Heiko Carstens --- kernel/softirq.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 501baa9ac1be..edd51027e3ab 100644 --- a/kernel/s

Re: [RFC 0/2] Reenable might_sleep() checks for might_fault() when atomic

2014-11-26 Thread Heiko Carstens
On Wed, Nov 26, 2014 at 07:04:47PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 26, 2014 at 05:51:08PM +0100, Christian Borntraeger wrote: > > > But this one was > giving users in field false positives. > > > > So lets try to fix those, ok? If we cant, then tough luck. > > Sure. > I think the s

Re: [RFC 0/2] Reenable might_sleep() checks for might_fault() when atomic

2014-11-27 Thread Heiko Carstens
On Thu, Nov 27, 2014 at 09:03:01AM +0100, David Hildenbrand wrote: > > Code like > > spin_lock(&lock); > > if (copy_to_user(...)) > > rc = ... > > spin_unlock(&lock); > > really *should* generate warnings like it did before. > > > > And *only* code like > > spin_lock(&l

Re: [PATCH 0/2] s390 vs. kprobes on ftrace

2014-10-16 Thread Heiko Carstens
Hi Masami, thank you for your comments! On Thu, Oct 16, 2014 at 02:49:56PM +0900, Masami Hiramatsu wrote: > (2014/10/16 0:46), Heiko Carstens wrote: > > we would like to implement an architecture specific variant of "kprobes > > on ftrace" without using the curre

Re: [PATCH 0/2] s390 vs. kprobes on ftrace

2014-10-17 Thread Heiko Carstens
On Thu, Oct 16, 2014 at 02:49:56PM +0900, Masami Hiramatsu wrote: > Hi Heiko, > > (2014/10/16 0:46), Heiko Carstens wrote: > > Hi all, > > > > we would like to implement an architecture specific variant of "kprobes > > on ftrace" without using the cu

Re: [PATCH 0/2] s390 vs. kprobes on ftrace

2014-10-17 Thread Heiko Carstens
e4c4ccb435bf360987a Mon Sep 17 00:00:00 2001 From: Heiko Carstens Date: Fri, 17 Oct 2014 10:08:35 +0200 Subject: [PATCH] ftracetest: sort testcases Make sure the order of the executed testcases is always the same. Signed-off-by: Heiko Carstens --- tools/testing/selftests/ftrace/ftracetest |

Re: [PATCH 0/2] s390 vs. kprobes on ftrace

2014-10-17 Thread Heiko Carstens
On Fri, Oct 17, 2014 at 10:19:21AM +0200, Heiko Carstens wrote: > +# kprobe on / ftrace on > +echo 1 > events/kprobes/testprobe/enable > +echo function > current_tracer > +echo > trace > +( echo "forked") > +echo > trace ^^^ --- this line shouldn't

Re: [PATCH 0/2] s390 vs. kprobes on ftrace

2014-10-19 Thread Heiko Carstens
Hi Masami, On Mon, Oct 20, 2014 at 11:02:49AM +0900, Masami Hiramatsu wrote: > (2014/10/17 17:19), Heiko Carstens wrote: > > On Thu, Oct 16, 2014 at 02:49:56PM +0900, Masami Hiramatsu wrote: > >> Hi Heiko, > >> > >> (2014/10/16 0:46), Heiko Carstens wrote: >

Re: [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies

2014-10-20 Thread Heiko Carstens
On Sat, Oct 11, 2014 at 11:25:14PM +0100, Thomas Graf wrote: > On 10/11/14 at 12:32pm, Eric Dumazet wrote: > > On Sat, 2014-10-11 at 10:36 +0200, Heiko Carstens wrote: > > > Hi all, > > > > > > it just came to my attention that commit e341694e3eb5 > > &

[PATCH 2/2] ftracetest: sort testcases

2014-10-20 Thread Heiko Carstens
Make sure the order of the executed testcases is always the same. Acked-by: Masami Hiramatsu Signed-off-by: Heiko Carstens --- tools/testing/selftests/ftrace/ftracetest | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools

[PATCH 0/2] ftracetest improvement and new testcase

2014-10-20 Thread Heiko Carstens
. Heiko Carstens (2): ftracetest: add kprobes on ftrace testcase ftracetest: sort testcases tools/testing/selftests/ftrace/ftracetest | 2 +- .../ftrace/test.d/kprobe/kprobe_ftrace.tc | 55 ++ 2 files changed, 56 insertions(+), 1 deletion(-) create mode

[PATCH 1/2] ftracetest: add kprobes on ftrace testcase

2014-10-20 Thread Heiko Carstens
Add a kprobes on ftrace testcase. The testcase verifies that - enabling and disabling function tracing works on a function which already contains a dynamic kprobe - adding and removing a dynamic kprobe works on a function which is already enabled for function tracing Signed-off-by: Heiko

[PATCH v2 0/2] s390 vs. kprobes on ftrace

2014-10-20 Thread Heiko Carstens
m via the s390 tree. Thanks, Heiko Heiko Carstens (2): kprobes: introduce ARCH_HANDLES_KPROBES_ON_FTRACE s390/ftrace,kprobes: allow to patch first instruction arch/Kconfig| 8 +++ arch/s390/Kconfig | 1 + arch/s390/include/asm/ftrace.h | 52 ++

[PATCH v2 1/2] kprobes: introduce ARCH_HANDLES_KPROBES_ON_FTRACE

2014-10-20 Thread Heiko Carstens
atter at all. Signed-off-by: Heiko Carstens --- arch/Kconfig | 8 kernel/kprobes.c | 36 +--- 2 files changed, 29 insertions(+), 15 deletions(-) diff --git a/arch/Kconfig b/arch/Kconfig index 05d7a8a458d5..e1a8e0edf03f 100644 --- a/arch/Kconfig +++ b

[PATCH v2 2/2] s390/ftrace,kprobes: allow to patch first instruction

2014-10-20 Thread Heiko Carstens
r which executes the function trace caller instruction won't be executed concurrently to any stop_machine() execution. This allows to keep full fault based kprobes handling which generates correct correct pt_regs contents automatically. Signed-off-by: Heiko Carstens --- arch/s390/Kconfig

[bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies

2014-10-11 Thread Heiko Carstens
Hi all, it just came to my attention that commit e341694e3eb5 "netlink: Convert netlink_lookup() to use RCU protected hash table" causes network latencies for me on s390. The testcase is quite simple and 100% reproducible on s390: Simply login via ssh to a remote system which has the above menti

Re: [PATCH trivial] s390/mm: s/specifiation/specification/, s/an specification/a specification/

2015-05-21 Thread Heiko Carstens
On Thu, May 21, 2015 at 02:00:47PM +0200, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > arch/s390/include/asm/pgtable.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h > index f

Re: [PATCH] force inlining of spinlock ops

2015-05-15 Thread Heiko Carstens
On Wed, May 13, 2015 at 04:09:18PM +0200, Denys Vlasenko wrote: > On 05/13/2015 12:43 PM, Ingo Molnar wrote: > > We only know that the net effect is +70 bytes. Does that come out of: > > > > - large fluctuations such as -1000-1000+1000+1070, which happens to > >net out into a small net numbe

[PATCH] KVM: remove pointless cpu hotplug messages

2015-05-05 Thread Heiko Carstens
x27;s remove this superfluous message. Signed-off-by: Heiko Carstens --- virt/kvm/kvm_main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 90977418aeb6..5fb52af5b975 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -2882,18 +28

Re: [PATCH 08/12] s390/sclp: Use DECLARE_BITMAP

2015-05-20 Thread Heiko Carstens
On Tue, May 19, 2015 at 06:37:56PM -0700, Joe Perches wrote: > Use the generic mechanism to declare a bitmap instead of unsigned long. > > Signed-off-by: Joe Perches > --- > drivers/s390/char/sclp_cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- To unsubscribe

Re: [PATCH 3.10 00/65] 3.10.77-stable review

2015-05-04 Thread Heiko Carstens
On Sun, May 03, 2015 at 09:40:11PM -0700, Guenter Roeck wrote: > On 05/03/2015 12:49 PM, Guenter Roeck wrote: > >On 05/02/2015 12:03 PM, Greg Kroah-Hartman wrote: > >>This is the start of the stable review cycle for the 3.10.77 release. > >>There are 65 patches in this series, all will be posted as

Re: [PATCH 3.10 00/65] 3.10.77-stable review

2015-05-04 Thread Heiko Carstens
On Mon, May 04, 2015 at 11:54:52AM +0200, Jiri Slaby wrote: > On 05/04/2015, 10:09 AM, Heiko Carstens wrote: > > sections.h > > 7f8998c7aef3ac9c5f3f2943e083dfa6302e90d0 > > "nosave: consolidate __nosave_{begin,end} in " > > I have added this to 3.1

Re: [PATCH] s390: cio: idset.c: Remove some unused functions

2014-12-22 Thread Heiko Carstens
On Sat, Dec 20, 2014 at 01:27:49PM +0100, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > idset_clear() idset_sch_get_first() > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist > --- >

Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-25 Thread Heiko Carstens
On Tue, Feb 24, 2015 at 06:41:50PM +0200, Ameen Ali wrote: > avoid out-of-bounds-read by checking count before indexing. > > Signed-off-by : Ameen Ali > --- > drivers/s390/block/dcssblk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/block/dcssblk.c b/dri

Re: [PATCH 1/1] livepatch: add support on s390

2015-03-27 Thread Heiko Carstens
On Thu, Mar 26, 2015 at 07:24:58PM +0100, Jiri Kosina wrote: > On Thu, 26 Mar 2015, Jiri Slaby wrote: > > > This is a trivial port from kGraft. Module relocations are not > > supported. > > > > Signed-off-by: Jiri Slaby > > --- > > [v2] return ENOSYS > > [v3] proper return value from klp_check_c

Re: [PATCH 1/1] livepatch: add support on s390

2015-03-27 Thread Heiko Carstens
On Fri, Mar 27, 2015 at 10:29:28AM +0100, Jiri Kosina wrote: > On Fri, 27 Mar 2015, Heiko Carstens wrote: > > > On Thu, Mar 26, 2015 at 07:24:58PM +0100, Jiri Kosina wrote: > > > On Thu, 26 Mar 2015, Jiri Slaby wrote: > > > > > > > This is a trivial po

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-29 Thread Heiko Carstens
On Wed, Jan 28, 2015 at 06:57:54AM -0500, Steven Rostedt wrote: > On Wed, 28 Jan 2015 06:36:45 +0100 > Heiko Carstens wrote: > > > On Tue, Jan 27, 2015 at 09:42:28AM -0500, Steven Rostedt wrote: > > > On Tue, 27 Jan 2015 07:19:42 +0100 > > > Dominik Vogt wrote:

Re: [PATCH] s390: char: Free memory on error path.

2015-01-20 Thread Heiko Carstens
et Signed-off-by: Heiko Carstens --- drivers/s390/char/hmcdrv_ftp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/s390/char/hmcdrv_ftp.c b/drivers/s390/char/hmcdrv_ftp.c index 4bd63322fc29..d4b61d9088fb 100644 --- a/drivers/s390/char/hmcdrv_ftp.c +++ b/

Re: s390: references to MARCH_G5

2015-02-20 Thread Heiko Carstens
On Fri, Feb 20, 2015 at 09:54:48AM +0100, Paul Bolle wrote: > Your commit c5f43f0a70fc ("s390: remove 31 bit support") is included in > today's linux-next (ie, next-20150220). I noticed because a script I use > to check linux-next spotted a problem with it. > > That commit removed the Kconfig symb

Re: [PATCH] cpu/hotplug: fix rollback during error-out in __cpu_disable()

2016-04-07 Thread Heiko Carstens
On Thu, Apr 07, 2016 at 05:14:00PM +0200, Sebastian Andrzej Siewior wrote: > On 04/06/2016 09:51 PM, Heiko Carstens wrote: > > This fixes the issue that a second cpu_down() will take forever, if > > __cpu_disable() fails. > > Yes. But even without the second take down your

Re: [PATCH 13/19] s390: get rid of superfluous __GFP_REPEAT

2016-04-11 Thread Heiko Carstens
> > Cc: linux-a...@vger.kernel.org > > Signed-off-by: Michal Hocko > > --- > > arch/s390/kernel/process.c | 2 +- > > arch/s390/mm/pgalloc.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) Acked-by: Heiko Carstens

Re: [PATCH] s390/cpum_sf: Remove superfluous SMP function call

2016-04-05 Thread Heiko Carstens
function calls are no longer required. > > Replace smp_call_function_single() with a direct call of > setup_pmc_cpu(). To keep the calling convention, interrupts are > explicitely disabled around the call. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux-s.

Re: [PATCH] s390/cpum_cf: Remove superfluous SMP function call

2016-04-05 Thread Heiko Carstens
function calls are no longer required. > > Replace smp_call_function_single() with a direct call of > setup_pmc_cpu(). To keep the calling convention, interrupts are > explicitely disabled around the call. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux-s.

Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call

2016-04-05 Thread Heiko Carstens
On Tue, Apr 05, 2016 at 01:13:06PM +0200, Sebastian Andrzej Siewior wrote: > On 04/05/2016 12:49 PM, Heiko Carstens wrote: > >> --- a/arch/s390/kernel/perf_cpum_sf.c > >> +++ b/arch/s390/kernel/perf_cpum_sf.c > >> @@ -1510,7 +1510,6 @@ static void cpumf_measureme

Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call

2016-04-05 Thread Heiko Carstens
On Tue, Apr 05, 2016 at 01:23:36PM +0200, Heiko Carstens wrote: > On Tue, Apr 05, 2016 at 01:13:06PM +0200, Sebastian Andrzej Siewior wrote: > > On 04/05/2016 12:49 PM, Heiko Carstens wrote: > > >> --- a/arch/s390/kernel/perf_cpum_sf.c > > >> +++ b/arch/s390/kernel

Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call

2016-04-05 Thread Heiko Carstens
On Tue, Apr 05, 2016 at 01:51:29PM +0200, rcoch...@linutronix.de wrote: > On Tue, Apr 05, 2016 at 01:36:38PM +0200, Heiko Carstens wrote: > > On Tue, Apr 05, 2016 at 01:23:36PM +0200, Heiko Carstens wrote: > > > Subsequently, in this case, the setup_pmc_cpu() call will be exe

<    2   3   4   5   6   7   8   9   10   11   >