Re: [PATCH v3 30/34] s390/traps: Unpoison the kernel_stack_overflow()'s pt_regs

2024-01-02 Thread Heiko Carstens
| 6 ++ > 1 file changed, 6 insertions(+) Acked-by: Heiko Carstens

Re: [PATCH v3 32/34] s390/unwind: Disable KMSAN checks

2024-01-02 Thread Heiko Carstens
penko > Signed-off-by: Ilya Leoshkevich > --- > arch/s390/kernel/unwind_bc.c | 4 > 1 file changed, 4 insertions(+) Acked-by: Heiko Carstens

Re: [PATCH v3 29/34] s390/string: Add KMSAN support

2024-01-02 Thread Heiko Carstens
wed-by: Alexander Potapenko > Signed-off-by: Ilya Leoshkevich > --- > arch/s390/boot/string.c| 16 > arch/s390/include/asm/string.h | 20 +++----- > 2 files changed, 31 insertions(+), 5 deletions(-) Acked-by: Heiko Carstens

Re: [PATCH v3 33/34] s390: Implement the architecture-specific kmsan functions

2024-01-02 Thread Heiko Carstens
: Ilya Leoshkevich > --- > arch/s390/include/asm/kmsan.h | 43 +++ > 1 file changed, 43 insertions(+) Acked-by: Heiko Carstens

Re: [PATCH v3 34/34] kmsan: Enable on s390

2024-01-02 Thread Heiko Carstens
On Thu, Dec 14, 2023 at 12:24:54AM +0100, Ilya Leoshkevich wrote: > Now that everything else is in place, enable KMSAN in Kconfig. > > Signed-off-by: Ilya Leoshkevich > --- > arch/s390/Kconfig | 1 + > 1 file changed, 1 insertion(+) Acked-by: Heiko Carstens

Re: [PATCH v3 28/34] s390/mm: Define KMSAN metadata for vmalloc and modules

2024-01-04 Thread Heiko Carstens
On Thu, Jan 04, 2024 at 11:03:42AM +0100, Alexander Gordeev wrote: > On Tue, Jan 02, 2024 at 04:05:31PM +0100, Heiko Carstens wrote: > Hi Heiko, > ... > > > @@ -253,9 +253,17 @@ static unsigned long setup_kernel_memory_layout(void) > > > MODULES_END = round_down(_

Re: [PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-11-17 Thread Heiko Carstens
Hi Steven, On Wed, Oct 04, 2023 at 04:50:07PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Instead of having a descriptor for every file represented in the eventfs > directory, only have the directory itself represented. Change the API to > send in a list of entries that re

Re: [PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-11-17 Thread Heiko Carstens
On Fri, Nov 17, 2023 at 03:23:35PM +0100, Heiko Carstens wrote: > I think this patch causes from time to time crashes when running ftrace > selftests. In particular I guess there is a bug wrt error handling in this > function (see below for call trace): > > > +st

Re: [PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-11-23 Thread Heiko Carstens
On Fri, Nov 17, 2023 at 03:38:29PM +0100, Heiko Carstens wrote: > On Fri, Nov 17, 2023 at 03:23:35PM +0100, Heiko Carstens wrote: > > I think this patch causes from time to time crashes when running ftrace > > selftests. In particular I guess there is a bug wrt error handling in th

Re: [PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-11-23 Thread Heiko Carstens
On Thu, Nov 23, 2023 at 10:23:49AM -0500, Steven Rostedt wrote: > On Thu, 23 Nov 2023 12:25:48 +0100 > Heiko Carstens wrote: > > > So, if it helps (this still happens with Linus' master branch): > > > > create_dir_dentry() is called with a "struct eve

[PATCH 0/2] selftests: vDSO: s390 fixes

2024-09-11 Thread Heiko Carstens
Two s390 fixes to make vdso selftests running on s390. Jason, given that you carry already a lot of changes for vdso selftests I guess these should be routed via the random tree. Patches apply on top of current random.git master branch. Thanks, Heiko Heiko Carstens (1): selftests: vDSO: fix

[PATCH 2/2] selftests: vDSO: fix vdso_config for s390

2024-09-11 Thread Heiko Carstens
he correct check must make sure that only __s390__ is defined. Therefore add the missing !defined(__s390x__). Also use common __s390x__ define instead of __s390X__. Signed-off-by: Heiko Carstens --- tools/testing/selftests/vDSO/vdso_config.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[PATCH 1/2] selftests: vDSO: fix ELF hash table entry size for s390x

2024-09-11 Thread Heiko Carstens
/elfclass.h). Fixes: 40723419f407 ("kselftest: Enable vDSO test on non x86 platforms") Reported-by: Heiko Carstens Tested-by: Heiko Carstens Signed-off-by: Jens Remus Signed-off-by: Heiko Carstens --- tools/testing/selftests/vDSO/parse_vdso.c | 14 ++ 1 file changed, 10

[GIT PULL] s390 updates for 5.12-rc7

2021-04-08 Thread Heiko Carstens
clobbering due to KASAN code instrumentation. Alexander Gordeev (1): s390/cpcmd: fix inline assembly register clobbering Heiko Carstens (2): s390/irq: fix reading of ext_params2 field from lowcore s390/setup: use

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Heiko Carstens
On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: > The "tty: termios locking functions break with new termios type" patch > (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. > [...] > I'm guessing other architectures are broken too? FWIW, the above quoted patch

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Heiko Carstens
On Wed, Sep 12, 2007 at 12:34:09PM +0100, Christoph Hellwig wrote: > On Wed, Sep 12, 2007 at 04:01:09AM -0700, Andrew Morton wrote: > > On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > > > > On Wed, Sep 12, 2007 at 12:04:39P

Re: try_module_get code understanding

2007-09-26 Thread Heiko Carstens
> I was going through try_module_get function in include/linux/module.h file > (2.6.22 stock kernel) - which is like: > > - > static inline int try_module_get(struct module *module){ > int ret = 1; <--- error case when !module > if (module) { > unsigned int cpu = get_cpu(); >

Re: try_module_get code understanding

2007-09-27 Thread Heiko Carstens
> Then what is return value if my module tries to 'get' a module which does not > exist (and is a module, not in-built)? . Is it '1' ? > Or am I imagining a hypothetical scenario which would not exist? That is not supposed to happen. After a module got unloaded there shouldn't be any objects aroun

Re: [PATCH 01/12] lockdep: syscall exit check

2007-09-28 Thread Heiko Carstens
On Fri, Sep 28, 2007 at 02:14:11PM +0200, Peter Zijlstra wrote: > On Fri, 2007-09-28 at 14:03 +0200, Heiko Carstens wrote: > > > +void lockdep_sys_exit(void) > > > +{ > > > + struct task_struct *curr = current; > > > + > > > + if (unl

Re: [PATCH 00/12] various lockdep patches

2007-09-28 Thread Heiko Carstens
p-x86_64-sys_exit.patch > > Could the various arch maintainers that have support for lockdep help out > with placing this hook? Subject: [PATCH] lockdep: s390: connect the sysexit hook From: Heiko Carstens <[EMAIL PROTECTED]> Run the lockdep_sys_exit hook before returning to user space. R

Re: [PATCH 01/12] lockdep: syscall exit check

2007-09-28 Thread Heiko Carstens
> +void lockdep_sys_exit(void) > +{ > + struct task_struct *curr = current; > + > + if (unlikely(curr->lockdep_depth)) { > + if (!debug_locks_off()) > + return; > + printk("\n\n"); > + printk( "

Re: [PATCH] Generic compat_sys_fallocate

2007-09-28 Thread Heiko Carstens
On Fri, Sep 28, 2007 at 02:11:11PM -0400, Kyle McMartin wrote: > Basically everyone is using the same sys32_fallocate. Delete a whole bunch of > archdep code and move the compat wrapper to fs/compat.c > > Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> > --- a/arch/sparc64/kernel/sys_sparc32.c >

Re: [COMPAT] Add compat_merge64 helper

2007-09-29 Thread Heiko Carstens
On Fri, Sep 28, 2007 at 06:33:51PM -0400, Kyle McMartin wrote: > To be used when endianness matters for argument ordering when reassembling > a 64-bit value out of two register halves. > > Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> > > +static inline u64 compat_merge64(u32 left, u32 right) >

Re: [PATCH] s390: Include kvm_host.h header only if KVM is enabled

2014-12-08 Thread Heiko Carstens
On Mon, Dec 08, 2014 at 09:29:08PM -0500, Pranith Kumar wrote: > On Mon, Dec 8, 2014 at 6:59 PM, Paul E. McKenney > wrote: > > On Mon, Dec 08, 2014 at 03:24:35PM -0500, Pranith Kumar wrote: > >> KVM uses srcu structures because of which CONFIG_KVM selects CONFIG_SRCU. > >> In > >> asm-offsets.c,

Re: [PATCH] softirq/preempt: add missing current->preempt_disable_ip update

2014-12-08 Thread Heiko Carstens
On Mon, Nov 24, 2014 at 03:16:19PM +0100, Heiko Carstens wrote: > While debugging some "sleeping function called from invalid context" bug I > realized that the debug message "Preemption disabled at:" pointed to an > incorrect function. > In particular if t

Re: [PATCH v2] CPU hotplug: active_writer not woken up in some cases - deadlock

2014-12-09 Thread Heiko Carstens
On Tue, Dec 09, 2014 at 08:59:30AM +0100, David Hildenbrand wrote: > > The compiler is within its rights to optimize the active_writer local > > variable out of existence, thus re-introducing the possible race with > > the writer that can pass a NULL pointer to wake_up_process(). So you > > really

Re: [PATCH v2] CPU hotplug: active_writer not woken up in some cases - deadlock

2014-12-09 Thread Heiko Carstens
On Tue, Dec 09, 2014 at 11:11:01AM +0100, David Hildenbrand wrote: > > > Therefore we have to move the condition check inside the > > > __set_current_state(TASK_UNINTERRUPTIBLE) -> schedule(); > > > section to not miss any wake ups when the condition is satisfied. > > > > > > So wake_up_process

Re: [PATCH] s390: include: timex: Use macro CLOCK_STORE_SIZE instead of hard code number

2015-01-02 Thread Heiko Carstens
this doesn't seem to be the case. Also slightly changed the patch a bit. - renamed CLOCK_STORE_SIZE to STORE_CLOCK_SIZE - changed get_tod_clock_ext() to receive a char pointer parameter Signed-off-by: Chen Gang Signed-off-by: Heiko Carstens --- arch/s390/hypfs/hypfs_vm.c| 2 +- a

Re: [PATCH] s390: boot: compressed: misc: Express the return value of _sclp_print_early()

2015-01-05 Thread Heiko Carstens
On Sat, Jan 03, 2015 at 05:29:07PM +0800, Chen Gang wrote: > _sclp_print_early() has return value: at present, return 0 for OK, 1 for > failure. It returns '%r2', so use 'long' as return value (upper caller > can check '%r2' directly). The related warning: > > CC arch/s390/boot/compressed

Re: [PATCH] s390: Remove unnecessary KERN_CONT

2015-01-05 Thread Heiko Carstens
On Mon, Jan 05, 2015 at 04:29:18AM -0800, Joe Perches wrote: > This has no effect as KERN_CONT is an empty string, > > It's probably just a missing conversion artifact as the > other pr_cont uses in the same file don't have this prefix. > > Signed-off-by: Joe Perches > --- > arch/s390/mm/fault.

Re: [PATCH v1 3/5] mm, uaccess: trigger might_sleep() in might_fault() when pagefaults are disabled

2014-12-05 Thread Heiko Carstens
On Fri, Dec 05, 2014 at 12:18:07PM +0100, David Hildenbrand wrote: > -void might_fault(void) > +void __might_fault(const char *file, int line) > { > /* >* Some code (nfs/sunrpc) uses socket ops on kernel memory while > @@ -3710,21 +3710,16 @@ void might_fault(void) >*/ >

Re: [Resend Patch v4 14/16] smp, s390: Kill SMP single function call interrupt

2015-01-22 Thread Heiko Carstens
upt > is needed for architecture specific code to support generic SMP function > call interfaces, so kill the redundant single function call interrupt. > > Signed-off-by: Jiang Liu > Acked-by: Heiko Carstens Is this really the patch I acked, whenever that was? Because the patch description

Re: [Resend Patch v4 14/16] smp, s390: Kill SMP single function call interrupt

2015-01-23 Thread Heiko Carstens
On Fri, Jan 23, 2015 at 05:21:42PM +0800, Jiang Liu wrote: > On 2015/1/23 14:54, Heiko Carstens wrote: > > On Fri, Jan 23, 2015 at 01:36:53PM +0800, Jiang Liu wrote: > >> Commit 9a46ad6d6df3b54 "smp: make smp_call_function_many() use logic > >> similar to smp_cal

Re: [PATCH 07/32] s390: use %*pb[l] to print bitmaps including cpumasks and nodemasks

2015-01-26 Thread Heiko Carstens
itmap printing through '%*pb[l]' > cpumask, nodemask: implement cpumask/nodemask_pr_args() > > Please wait till the forementioned patches are merged to mainline > before applying to subsystem trees. > > Signed-off-by: Tejun Heo > Cc: Andrew Morton > Cc: Ma

[PATCH/RFC 1/3] ftrace: allow architectures to specify ftrace compile options

2015-01-26 Thread Heiko Carstens
different option should be used for code generation. Signed-off-by: Heiko Carstens --- Makefile| 6 +- kernel/Makefile | 4 ++-- kernel/events/Makefile | 2 +- kernel/locking/Makefile | 8 kernel/sched/Makefile | 2 +- kernel/trace/Makefile | 4 ++-- li

[PATCH/RFC 0/3] ftrace: allow arch specific compile options

2015-01-26 Thread Heiko Carstens
y the number of halfwords before/after the beginning of a function is not yet upstream, but should be soon. Heiko Carstens (3): ftrace: allow architectures to specify ftrace compile options ftrace: introduce nohotpatch function attribute s390/ftrace: hotpatch support for fu

[PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
introduce a nohotpatch define, depending on CC_USING_HOTPATCH, and add it to the existing notrace define. Signed-off-by: Heiko Carstens --- include/linux/compiler.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/compiler.h b/include/linux/compil

[PATCH/RFC 3/3] s390/ftrace: hotpatch support for function tracing

2015-01-26 Thread Heiko Carstens
ntime overhead for supporting function tracing is close to zero, while the original code did show a significant performance impact. Signed-off-by: Heiko Carstens --- arch/s390/Kconfig | 1 - arch/s390/Makefile | 10 ++ arch/s390/include/asm/ftrace.h

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
On Mon, Jan 26, 2015 at 09:37:01AM -0500, Steven Rostedt wrote: > On Mon, 26 Jan 2015 13:54:53 +0100 > Heiko Carstens wrote: > > > gcc supports an s390 specific function attribute called "hotpatch". > > It can be used to specify the number of halfwords that shall

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
On Mon, Jan 26, 2015 at 10:22:26AM -0500, Steven Rostedt wrote: > On Mon, 26 Jan 2015 16:03:19 +0100 > Heiko Carstens wrote: > > > Actually they should be mutually exclusive. I just merged them "just in > > case". > > > > So something like this &g

Re: [PATCH] s390: crypto: aes_s390: Remove 'const' to avoid compiler warnings

2015-01-07 Thread Heiko Carstens
On Thu, Jan 01, 2015 at 10:56:02PM +0800, Chen Gang wrote: > In aes_encrypt() and aes_decrypt(), need let 'sctx->key' be modified, > so remove 'const' for it. The related warnings: ... > > Signed-off-by: Chen Gang > --- > arch/s390/crypto/aes_s390.c |4 ++-- > 1 file changed, 2 insertions(+)

Re: [PATCH v2 38/40] s390: macro whitespace fixes

2015-01-07 Thread Heiko Carstens
On Tue, Jan 06, 2015 at 05:45:38PM +0200, Michael S. Tsirkin wrote: > While working on arch/s390/include/asm/uaccess.h, I noticed > that a couple of macros within this header are made harder to read > because they violate a coding style rule: space is missing after comma. > > Fix it up. > > Signe

[PATCH/resend] softirq/preempt: add missing current->preempt_disable_ip update

2015-01-07 Thread Heiko Carstens
he missing update of current->preempt_disable_ip to __local_bh_disable_ip() as well. Signed-off-by: Heiko Carstens --- kernel/softirq.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 501baa9ac1be..edd51027e3ab 100644 ---

Re: [PATCH RFT] s390: move cacheinfo sysfs to generic cacheinfo infrastructure

2015-01-08 Thread Heiko Carstens
to userspace via sysfs") > > Signed-off-by: Sudeep Holla > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux...@de.ibm.com > Cc: linux-s...@vger.kernel.org > --- > arch/s390/kernel/cache.c | 388 > +++ > 1 file

Re: [PATCH 1/1] scripts/recordmcount.pl: There is no -m32 option on Super-H

2015-01-18 Thread Heiko Carstens
On Sun, Jan 18, 2015 at 12:36:15AM +0100, Michael Karcher wrote: > Signed-Off-By: Michael Karcher > --- > scripts/recordmcount.pl | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl > index 56ea99a..537c38c 100755 > --- a/scripts/recordmcount

Re: [PATCH] [linux-next] s390: Dump check for CONFIG_ZFCPDUMP

2015-01-19 Thread Heiko Carstens
On Fri, Jan 16, 2015 at 10:35:05AM +0100, Paul Bolle wrote: > Commit 725908110a1f ("s390: add SMT support") added a check for > CONFIG_ZFCPDUMP. But the Kconfig symbol ZFCPDUMP was removed in v3.16 > through commit bf28a5970de3 ("s390/dump: Remove CONFIG_ZFCPDUMP"). So > this check will always eval

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-27 Thread Heiko Carstens
On Tue, Jan 27, 2015 at 09:42:28AM -0500, Steven Rostedt wrote: > On Tue, 27 Jan 2015 07:19:42 +0100 > Dominik Vogt wrote: > > > While the kernel may use only profiling or hotpatch at the same > > time, Gcc is able to generate both for the same function. > > Understood, but would that be useful

Re: [PATCH] context_tracking: remove local_irq_save from __acct_update_integrals

2015-04-24 Thread Heiko Carstens
On Thu, Apr 23, 2015 at 09:57:13PM -0400, Rik van Riel wrote: > diff --git a/kernel/tsacct.c b/kernel/tsacct.c > index 975cb49e32bf..0b967f116a6b 100644 > --- a/kernel/tsacct.c > +++ b/kernel/tsacct.c > @@ -126,23 +126,29 @@ static void __acct_update_integrals(struct task_struct > *tsk, > if

Re: [PATCH 07/25] s390: Use bool function return values of true/false not 1/0

2015-03-31 Thread Heiko Carstens
On Mon, Mar 30, 2015 at 04:46:05PM -0700, Joe Perches wrote: > Use the normal return values for bool functions > > Signed-off-by: Joe Perches > --- > arch/s390/include/asm/dma-mapping.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/include/asm/dma-mapping.h

Re: [PATCH v2] context_tracking: remove local_irq_save from __acct_update_integrals

2015-04-25 Thread Heiko Carstens
On Fri, Apr 24, 2015 at 11:16:53AM -0400, Rik van Riel wrote: > V2: introduce signed_cputime_t to deal with 64 bit cputime_t on > 32 bit architectures, and use READ_ONCE to ensure the value > is always read atomically (Heiko Karstens) Erm, that's not what I said ;) READ_ONCE() only fixes t

Re: [PATCH v2] context_tracking: remove local_irq_save from __acct_update_integrals

2015-04-27 Thread Heiko Carstens
On Sat, Apr 25, 2015 at 08:50:49AM -0400, Rik van Riel wrote: > On 04/25/2015 05:43 AM, Heiko Carstens wrote: > > ...the READ_ONCE() doesn't give you any guarantees about reading > > tsk->acct_timexpd in an atomic way. > > Well, actually you don't need atomic sem

Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value

2015-05-29 Thread Heiko Carstens
On Wed, May 27, 2015 at 07:04:43PM +0200, Nicholas Mc Guire wrote: > schedule_timeout takes a timeout in jiffies but the code currently is > passing in a constant SDIAS_SLEEP_TICKS which sounds like it should be > in jiffies but it is actually not and thus makes this timeout HZ > dependent, to fix

Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value

2015-05-29 Thread Heiko Carstens
On Fri, May 29, 2015 at 11:51:54AM +0200, Nicholas Mc Guire wrote: > On Fri, 29 May 2015, Heiko Carstens wrote: > > Yes, the orginal code seems to be broken. Since I've no idea what the > > intended > > timeout value should be, let's simply ask Michael, who wrot

Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value

2015-05-29 Thread Heiko Carstens
On Fri, May 29, 2015 at 04:16:46PM +0200, Nicholas Mc Guire wrote: > On Fri, 29 May 2015, Michael Holzheu wrote: > > > On Fri, 29 May 2015 13:49:36 +0200 > > Nicholas Mc Guire wrote: > > > > > On Fri, 29 May 2015, Heiko Carstens wrote: > > > > &

Re: [PATCH V2] s390/sclp: pass timeout as HZ independent value

2015-05-30 Thread Heiko Carstens
t; Link: http://lkml.org/lkml/2015/5/29/235 > Signed-off-by: Nicholas Mc Guire > --- > > V2: timeout clarified by Heiko Carstens and > set to 500ms (HZ/2). And thanks for the test-config hints. > > drivers/s390/char/sclp_sdias.c |3 +-- > 1 file changed, 1 inser

Re: [PATCH] s390/jump_label: Correct asm contraint

2019-02-05 Thread Heiko Carstens
On Tue, Jan 29, 2019 at 08:25:58AM +0100, Laura Abbott wrote: > On 1/23/19 5:24 AM, Heiko Carstens wrote: > >On Wed, Jan 23, 2019 at 01:55:13PM +0100, Laura Abbott wrote: > >>There's a build failure with gcc9: > >> > >> ./arch/s390/include/asm/jump_label

Re: [PATCH] s390/mm: Silence compiler warning when compiling without CONFIG_PGSTE

2019-04-08 Thread Heiko Carstens
On Mon, Apr 08, 2019 at 12:36:32PM +0200, Thomas Huth wrote: > On 08/04/2019 09.09, David Hildenbrand wrote: > > On 07.04.19 14:55, Thomas Huth wrote: > >> If CONFIG_PGSTE is not set (e.g. when compiling without KVM), GCC > >> complains: > >> > >> CC arch/s390/mm/pgtable.o > >> arch/s390/mm

Re: [PATCH v3] ubsan: Avoid unnecessary 128-bit shifts

2019-04-09 Thread Heiko Carstens
On Fri, Apr 05, 2019 at 01:58:53AM +, George Spelvin wrote: > If CONFIG_ARCH_SUPPORTS_INT128, s_max is 128 bits, and variable > sign-extending shifts of such a double-word data type are a non-trivial > amount of code and complexity. Do a single-word sign-extension *before* > the cast to (s_max

Re: [PATCH 1/2] s390: only build for new CPUs with clang

2019-04-10 Thread Heiko Carstens
On Wed, Apr 10, 2019 at 10:12:40PM +0200, Arnd Bergmann wrote: > llvm does does not understand -march=z9-109 and older target > specifiers, so disable the respective Kconfig settings and > the logic to make the boot code work on old systems when > building with clang. > > Signed-off-by: Arnd Bergm

Re: linux-next: Tree for Feb 11

2021-02-11 Thread Heiko Carstens
On Thu, Feb 11, 2021 at 10:26:04PM +1100, Stephen Rothwell wrote: > Hi all, > > Changes since 20210210: > > The powerpc tree still had its build failure in the allyesconfig for > which I applied a supplied patch. > > The v4l-dvb tree lost its build failure. > > The drm-misc tree lost its build

Re: linux-next: Tree for Feb 11

2021-02-12 Thread Heiko Carstens
Hi Vlad, > > Build fails on s390 using defconfig with: > > > > In file included from drivers/net/ethernet/mellanox/mlx5/core/en_tc.h:40, > > from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:45: > > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.h:24:29: error: field > >

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-23 Thread Heiko Carstens
On Mon, Feb 22, 2021 at 08:03:31AM -0800, Guenter Roeck wrote: > > Maybe, we can add something like CONFIG_SUPPRESS_NOISY_TESTS, > > which is set to y by all{yes,mod}config. > > > > This is self-documenting, so we do not need the '# too noisy' comment. > > > > > > > > config SUPPRESS_NOISY_TEST

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-23 Thread Heiko Carstens
On Tue, Feb 23, 2021 at 09:41:40AM -0800, Guenter Roeck wrote: > > I tried to explain why we don't want to set COMPILE_TEST for s390 > > anymore. It overrides architecture dependencies in Kconfig, and lots > > of drivers do not set dependencies for HAS_IOMEM, HAS_DMA, and friends > > correctly. > >

Re: [PATCH] s390/test_unwind: fix possible memleak in test_unwind()

2020-07-31 Thread Heiko Carstens
On Thu, Jul 30, 2020 at 09:35:15AM +0200, Ilya Leoshkevich wrote: > On Thu, 2020-07-30 at 14:36 +0800, Wang Hai wrote: > > test_unwind() misses to call kfree(bt) in an error path. > > Add the missed function call to fix it. > > > > Fixes: 0610154650f1 ("s390/test_unwind: print verbose unwinding >

[GIT PULL] s390 updates for 5.9 merge window

2020-08-03 Thread Heiko Carstens
nd struct field renames s390/zcrypt: split ioctl function into smaller code units s390/ap: rename and clarify ap state machine related stuff s390/zcrypt: provide cex4 cca sysfs attributes for cex3 s390/ap: rework crypto config info and default domain code Heiko Carstens (11):

Re: linux-next: build failure after merge of the net-next tree

2020-08-05 Thread Heiko Carstens
On Wed, Aug 05, 2020 at 03:06:27PM +0200, Stefano Brivio wrote: > On Wed, 5 Aug 2020 22:31:21 +1000 > Stephen Rothwell wrote: > > > Hi all, > > > > After merging the net-next tree, today's linux-next build (s390 defconfig) > > failed like this: > > > > net/ipv4/ip_tunnel_core.c:335:2: error: im

Re: [PATCH] s390/Kconfig: add missing ZCRYPT dependency to VFIO_AP

2020-08-06 Thread Heiko Carstens
On Wed, Aug 05, 2020 at 05:50:53PM +0200, Krzysztof Kozlowski wrote: > The VFIO_AP uses ap_driver_register() (and deregister) functions > implemented in ap_bus.c (compiled into ap.o). However the ap.o will be > built only if CONFIG_ZCRYPT is selected. > > This was not visible before commit e93a16

Re: [patch 12/30] s390/irq: Use irq_desc_kstat_cpu() in show_msi_interrupt()

2020-12-10 Thread Heiko Carstens
On Thu, Dec 10, 2020 at 08:25:48PM +0100, Thomas Gleixner wrote: > The irq descriptor is already there, no need to look it up again. > > Signed-off-by: Thomas Gleixner > Cc: Christian Borntraeger > Cc: Heiko Carstens > Cc: linux-s...@vger.kernel.org > --- > arch/

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-08 Thread Heiko Carstens
ith a new > address range check to preserve the existing functionality. It also adds a > VM_BUG_ON() check that would ensure that memhp_range_allowed() has already > been called on the hotplug path. > > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: David Hildenbrand > Cc: linux

Re: [PATCH 12/18] arch: s390: Remove CONFIG_OPROFILE support

2021-01-15 Thread Heiko Carstens
gt; arch/s390/configs/defconfig | 1 - > arch/s390/oprofile/Makefile | 10 - > arch/s390/oprofile/init.c | 37 --- > 6 files changed, 53 deletions(-) > delete mode 100644 arch/s390/oprofile/Makefile > delete mode 100644 arch/s390/oprofile/init.c Acked-by: Heiko Carstens

Re: [PATCH 0/3] s390 vdso fixes

2021-03-25 Thread Heiko Carstens
On Thu, Mar 25, 2021 at 04:56:18PM +0800, Li Wang wrote: > Hi Heiko, > > On Wed, Mar 24, 2021 at 5:58 AM Heiko Carstens wrote: > > > Li Wang reported that clock_gettime(CLOCK_MONOTONIC_RAW, ...) does not > > work correctly on s390 via vdso. Debugging this also revea

Re: s390: kernel/entry.o: in function `sys_call_table_emu': (.rodata+0x1bc0): undefined reference to `__s390_'

2021-03-18 Thread Heiko Carstens
On Thu, Mar 18, 2021 at 10:05:01AM -0700, Nick Desaulniers wrote: > (Replying to > https://lore.kernel.org/linux-s390/ca+g9fytbw0hav5ooayck2rz_m2sj73krxpj0idzt+o8qtc1...@mail.gmail.com/) > > Yeah, our CI is failing today, too with the same error on linux-next: > https://github.com/ClangBuiltLinux

Re: linux-next: Tree for Mar 19

2021-03-19 Thread Heiko Carstens
On Fri, Mar 19, 2021 at 05:59:50PM +1100, Stephen Rothwell wrote: > Hi all, > > Warning: Some of the branches in linux-next may still based on v5.12-rc1, > so please be careful if you are trying to bisect a bug. > > News: if your -next included tree is based on Linus' tree tag > v5.12-rc1{,-dontu

[GIT PULL] s390 updates for 5.12-rc4

2021-03-19 Thread Heiko Carstens
Hi Linus, please pull three s390 specific bug fixes for 5.12-rc4. Thanks, Heiko The following changes since commit 1e28eed17697bcf343c6743f0028cc3b5dd88bf0: Linux 5.12-rc3 (2021-03-14 14:41:02 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/s39

Re: [s390x vDSO Bug?] clock_gettime(CLOCK_MONOTONIC_RAW, ...) gets abnormal ts value

2021-03-23 Thread Heiko Carstens
On Tue, Mar 23, 2021 at 02:21:52PM +0800, Li Wang wrote: > Hi linux-s390 experts, > > We observed that LTP/clock_gettime04 always FAIL on s390x with > kernel-v5.12-rc3. > To simply show the problem, I rewrite the LTP reproducer as a simple C > below. > Maybe it's a new bug introduced from the kern

Re: [s390x vDSO Bug?] clock_gettime(CLOCK_MONOTONIC_RAW, ...) gets abnormal ts value

2021-03-23 Thread Heiko Carstens
On Tue, Mar 23, 2021 at 08:11:41AM +0100, Heiko Carstens wrote: > On Tue, Mar 23, 2021 at 02:21:52PM +0800, Li Wang wrote: > > Hi linux-s390 experts, > > > > We observed that LTP/clock_gettime04 always FAIL on s390x with > > kernel-v5.12-rc3. > > To simply sh

[PATCH 0/3] s390 vdso fixes

2021-03-23 Thread Heiko Carstens
the first element of the _vdso_data array and not at all within the _timens_data array. Instead of working around this simply provide an s390 specific vdso data page which contains the tod clock steering parameters. This allows also to remove ARCH_HAS_VDSO_DATA again. Heiko Carstens (3): s390

[PATCH 3/3] lib/vdso: remove struct arch_vdso_data from vdso data struct

2021-03-23 Thread Heiko Carstens
Since commit d60d7de3e16d ("lib/vdso: Allow to add architecture-specific vdso data") it is possible to provide arch specific VDSO data. This was only added for s390, which doesn't make use this anymore. Therefore remove it again. Signed-off-by: Heiko Carstens --- arch/Kconfig

[PATCH 1/3] s390/vdso: fix tod clock steering

2021-03-23 Thread Heiko Carstens
two. Fix this by simply providing the missing value to user space. Fixes: 4bff8cb54502 ("s390: convert to GENERIC_VDSO") Cc: # 5.10 Signed-off-by: Heiko Carstens --- arch/s390/kernel/time.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/s390/kernel/time.c b/arch/s390/ker

[PATCH 2/3] s390/vdso: fix arch_data access for __arch_get_hw_counter()

2021-03-23 Thread Heiko Carstens
plify __arch_get_hw_counter()") Fixes: eeab78b05d20 ("s390/vdso: implement generic vdso time namespace support") Link: https://lore.kernel.org/linux-s390/YFnxr1ZlMIOIqjfq@osiris Signed-off-by: Heiko Carstens --- arch/s390/Kconfig | 1 - arch/s390/include/asm/vdso.h

Re: [PATCH 2/3] s390/vdso: fix arch_data access for __arch_get_hw_counter()

2021-03-23 Thread Heiko Carstens
On Tue, Mar 23, 2021 at 10:58:18PM +0100, Heiko Carstens wrote: > Li Wang reported that clock_gettime(CLOCK_MONOTONIC_RAW, ...) returns > incorrect values when time is provided via vdso instead of system call: > > vdso_ts_nsec = 4484351380985507, vdso_ts.tv_sec = 4484351, vds

Re: [PATCH 1/3] s390/vdso: fix tod clock steering

2021-03-24 Thread Heiko Carstens
On Tue, Mar 23, 2021 at 10:58:17PM +0100, Heiko Carstens wrote: > The s390 specific vdso function __arch_get_hw_counter() is supposed to > consider tod clock steering. > > If a tod clock steering event happens and the tod clock is set to a > new value __arch_get_hw_counter() will

[GIT PULL] s390 updates for 5.12-rc6

2021-03-30 Thread Heiko Carstens
and update of vdso data pages, which results in incorrect tod clock steering, and that clock_gettime(CLOCK_MONOTONIC_RAW, ...) returns incorrect values. - update MAINTAINERS for s390 vfio drivers Heiko Carstens (3): s390/vdso

Re: [PATCH] s390/kernel: Fix a typo

2021-03-21 Thread Heiko Carstens
On Mon, Mar 22, 2021 at 11:55:00AM +0530, Bhaskar Chowdhury wrote: > > s/struture/structure/ > > Signed-off-by: Bhaskar Chowdhury > --- > arch/s390/kernel/os_info.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kernel/os_info.c b/arch/s390/kernel/os_info.c

Re: [PATCH v1 1/2] s390/kvm: split kvm_s390_real_to_abs

2021-03-22 Thread Heiko Carstens
On Mon, Mar 22, 2021 at 10:53:46AM +0100, David Hildenbrand wrote: > > > diff --git a/arch/s390/kvm/gaccess.h b/arch/s390/kvm/gaccess.h > > > index daba10f76936..7c72a5e3449f 100644 > > > --- a/arch/s390/kvm/gaccess.h > > > +++ b/arch/s390/kvm/gaccess.h > > > @@ -18,17 +18,14 @@ > > >/** > > >

Re: [PATCH] s390/crc32-vx: Couple of typo fixes

2021-03-22 Thread Heiko Carstens
On Mon, Mar 22, 2021 at 06:35:33PM +0530, Bhaskar Chowdhury wrote: > > s/defintions/definitions/ > s/intermedate/intermediate/ > > Signed-off-by: Bhaskar Chowdhury > --- > arch/s390/crypto/crc32be-vx.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks.

Re: [PATCH 3/5] s390: Get rid of oprofile leftovers

2021-04-15 Thread Heiko Carstens
On Wed, Apr 14, 2021 at 02:44:07PM +0100, Marc Zyngier wrote: > perf_pmu_name() and perf_num_counters() are unused. Drop them. > > Signed-off-by: Marc Zyngier > --- > arch/s390/kernel/perf_event.c | 21 - > 1 file changed, 21 deletions(-) Acked-by: Heiko C

Re: [PATCH 3/5] s390: Get rid of oprofile leftovers

2021-04-15 Thread Heiko Carstens
On Thu, Apr 15, 2021 at 11:47:26AM +0100, Marc Zyngier wrote: > On Thu, 15 Apr 2021 11:38:52 +0100, > Heiko Carstens wrote: > > > > On Wed, Apr 14, 2021 at 02:44:07PM +0100, Marc Zyngier wrote: > > > perf_pmu_name() and perf_num_counters() are unused. Drop them. >

Re: consolidate the flock uapi definitions

2021-04-15 Thread Heiko Carstens
-- > 11 files changed, 54 insertions(+), 192 deletions(-) for the s390 bits: Acked-by: Heiko Carstens

[GIT PULL] s390 updates for 5.12-rc8 / 5.12

2021-04-14 Thread Heiko Carstens
Hi Linux, please pull two small s390 patches. This is also supposed to be the last s390 pull request for 5.12. There are no known bugs left. Thanks, Heiko The following changes since commit ad31a8c05196a3dc5283b193e9c74a72022d3c65: s390/setup: use memblock_free_late() to free old stack (2021-

Re: [PATCH 17/20] kbuild: s390: use common install script

2021-04-07 Thread Heiko Carstens
On Wed, Apr 07, 2021 at 07:34:16AM +0200, Greg Kroah-Hartman wrote: > The common scripts/install.sh script will now work for s390, no changes > needed. So call that instead and delete the s390-only install script. > > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian

Re: linux-next: Tree for Mar 17

2021-03-17 Thread Heiko Carstens
On Wed, Mar 17, 2021 at 07:42:41PM +1100, Stephen Rothwell wrote: > Hi all, > > News: there will be no linux-next release on Friday this week. > > Warning: Some of the branches in linux-next are still based on v5.12-rc1, > so please be careful if you are trying to bisect a bug. > > News: if your

Re: [PATCH] memcg: set page->private before calling swap_readpage

2021-03-18 Thread Heiko Carstens
> with the swap entry before calling swap_readpage(). > > Signed-off-by: Shakeel Butt > Reported-by: Heiko Carstens > --- > > Andrew, please squash this into "memcg: charge before adding to > swapcache on swapin" patch. > > mm/memory.c | 4 > 1 fil

Re: [PATCH] KVM: s390: use ARRAY_SIZE instead of division operation

2021-02-21 Thread Heiko Carstens
On Sat, Feb 20, 2021 at 04:22:37PM +0800, Yang Li wrote: > This eliminates the following coccicheck warning: > ./arch/s390/tools/gen_facilities.c:154:37-38: WARNING: Use ARRAY_SIZE > ./arch/s390/tools/gen_opcode_table.c:141:39-40: WARNING: Use ARRAY_SIZE > > Reported-by: Abaci Robot > Signed-off-

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-22 Thread Heiko Carstens
C_PLUGIN_CYC_COMPLEXITY is primarily used for testing, disable it > when building s390 images. > > Cc: Arnd Bergmann > Cc: Heiko Carstens > Fixes: 334ef6ed06fa ("init/Kconfig: make COMPILE_TEST depend on !S390") > Signed-off-by: Guenter Roeck > --- > scripts/gcc-

[GIT PULL] s390 updates for 5.10-rc5

2020-11-17 Thread Heiko Carstens
space with any TIF/CIF/PIF set - fix file permission for cpum_sfb_size parameter - another small defconfig update Heiko Carstens (2): s390: fix system call exit path s390: update defconfigs Thomas Richter (1

Re: irq-loongson-pch-pic.c:undefined reference to `of_iomap'

2020-11-17 Thread Heiko Carstens
On Mon, Nov 16, 2020 at 10:21:26AM +0100, Arnd Bergmann wrote: > > Don't we need the dependencies on HAS_IOMEM for the CONFIG_UML=y > > case, too? > > I would have expected that as well, but I don't see the problem when building > an arch/um kernel, all I get is > > ERROR: modpost: "devm_platform

Re: irq-loongson-pch-pic.c:undefined reference to `of_iomap'

2020-11-17 Thread Heiko Carstens
On Tue, Nov 17, 2020 at 07:34:55PM +0100, Krzysztof Kozlowski wrote: > > Looking a bit further, I now find that we ended up disabling > > CONFIG_COMPILE_TEST > > entirely for arch/um, which is clearly an option that would also work for > > s390. > > Yes, that was the easier solution than to spre

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-09 Thread Heiko Carstens
On Wed, Dec 09, 2020 at 08:07:04AM +0530, Anshuman Khandual wrote: > >> + if (seg->end + 1 > VMEM_MAX_PHYS || seg->end + 1 < seg->start_addr) { > >> + rc = -ERANGE; > >> + goto out_resource; > >> + } > >> + ... > >> +struct range arch_get_mappable_range(void) > >> +{ > >> + str

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-09 Thread Heiko Carstens
i.e vmem_get_max_addr() to update in case the maximum address changes > from VMEM_MAX_PHYS to something else later. Still not. That's way too much code churn for what you want to achieve. If the s390 specific patch would look like below you can add Acked-by: Heiko Carstens But please make sure

<    1   2   3   4   5   6   7   8   9   10   >