[patch 0/8] s390 patches for 2.6.22

2007-03-26 Thread Heiko Carstens
Couple of patches that haven't been posted before and which should be merged in the 2.6.22 merge window. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

[patch 1/8] Processor degredation support.

2007-03-26 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Emit a warning if cpu capability changes e.g. because the cpus are overheating. The new cpu capability can be read via /proc/sysinfo. Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]

[patch 4/8] cio: Clean up online_store.

2007-03-26 Thread Heiko Carstens
From: Cornelia Huck <[EMAIL PROTECTED]> Detangle the online_store code and make it more readable. Cc: Martin Schwidefsky <[EMAIL PROTECTED]> Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- drivers/

[patch 3/8] Improved kernel stack overflow checking.

2007-03-26 Thread Heiko Carstens
always want to use the new stack checker. Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- arch/s390/Makefile |2 ++ 1 files changed, 2 insertions(+) Index: linux-2.6/

[patch 7/8] dasd: Add ipldev parameter.

2007-03-26 Thread Heiko Carstens
From: Peter Oberparleiter <[EMAIL PROTECTED]> Specifying 'ipldev' in the dasd= kernel parameter will automatically activate the boot device for use by the dasd driver. Cc: Martin Schwidefsky <[EMAIL PROTECTED]> Signed-off-by: Peter Oberparleiter <[EMAIL PROTECTED]> S

[patch 8/8] zfcpdump support.

2007-03-26 Thread Heiko Carstens
f-by: Martin Schwidefsky <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- Documentation/s390/zfcpdump.txt | 87 + arch/s390/Kconfig |8 arch/s390/Makefile |3 arch/s390/defconfig |1 arch/s390/kern

[patch 2/8] Get rid of console setup functions.

2007-03-26 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> We get this: Section mismatch: reference to .init.text:con3270_consetup from .data between 'con3270' (at offset 0x45c8) and 'con3270_fn' Section mismatch: reference to .init.text:con3215_consetup from .data

[patch 6/8] dasd: Add sysfs attribute status and generate uevents.

2007-03-26 Thread Heiko Carstens
tions (e.g. udev) to do related processing. Cc: Martin Schwidefsky <[EMAIL PROTECTED]> Signed-off-by: Horst Hummel <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- drivers/s390/block/dasd.c|3 ++ drivers/s390/block/dasd_devmap.c | 41

[patch 5/8] cio: Channel-path configure function.

2007-03-26 Thread Heiko Carstens
Peter Oberparleiter <[EMAIL PROTECTED]> Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- drivers/s390/char/Makefile|2 drivers/s390/char/sclp_chp.c | 196 + drivers/s390

Re: [patch 1/8] Processor degredation support.

2007-03-27 Thread Heiko Carstens
> > +++ linux-2.6/drivers/s390/char/sclp_confmgm.c > > Can we get less cyptic name? Would you like to see sclp_configuration_management.c? > > +static void sclp_conf_receiver_fn(struct evbuf_header *evbuf) > > +{ > > + struct conf_mgm_data *cdata; > > + > > + cdata = (struct conf_mgm_data *)

Re: [QUESTION] check for mem in slab

2007-03-29 Thread Heiko Carstens
> in file mm/slab.c and routine kmem_cache_init() I found there > is no checking for allocated memory on line: > > /* 4) Replace the bootstrap head arrays */ > { > struct array_cache *ptr; > > ptr = kmalloc(sizeof(struct arraycache_init), GFP_KERNEL); > >

Re: Interface for the new fallocate() system call

2007-03-29 Thread Heiko Carstens
On Thu, Mar 29, 2007 at 07:01:54PM +0200, Jan Engelhardt wrote: > Hi, > > On Mar 29 2007 17:21, Amit K. Arora wrote: > > > >We need to come up with the best possible layout of arguments for the > >fallocate() system call. Various architectures have different > >requirements for how the arguments s

Re: Interface for the new fallocate() system call

2007-03-29 Thread Heiko Carstens
f loff_t => high u32 + low u32 > > -- > > Matthew and Russell have suggested another option of breaking each > > "loff_t" into two "u32"s. This will result in 6 arguments in total. > > > > Following think that this is a good alternative: > > Matthew

Re: Interface for the new fallocate() system call

2007-03-30 Thread Heiko Carstens
On Fri, Mar 30, 2007 at 02:14:17AM -0500, Jakub Jelinek wrote: > On Thu, Mar 29, 2007 at 10:10:10AM -0700, Andrew Morton wrote: > > > Platform: s390 > > > -- > > > s390 prefers following layout: > > > > > >int fallocate(int fd, loff_t offset, loff_t len, int mode) > > > > > > For

Re: Interface for the new fallocate() system call

2007-03-30 Thread Heiko Carstens
On Fri, Mar 30, 2007 at 12:44:49PM +0200, Jörn Engel wrote: > On Fri, 30 March 2007 19:15:58 +1000, Paul Mackerras wrote: > > It does mean extra unnecessary work for 64-bit platforms, though... > > Wouldn't that work be confined to fallocate()? If I understand Heiko > correctly, the alternative w

Re: [PATCH 8/9] clocksource: s390 initialize list value

2007-03-30 Thread Heiko Carstens
On Fri, Mar 30, 2007 at 11:45:49AM -0700, Daniel Walker wrote: > Update arch/s390 with list initialization. > > Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> > > --- > arch/s390/kernel/time.c |1 + > 1 file changed, 1 insertion(+) > > Index: linux-2.6.20/arch/s390/kernel/time.c > ===

Re: [PATCH 8/9] clocksource: s390 initialize list value

2007-03-30 Thread Heiko Carstens
On Fri, Mar 30, 2007 at 12:19:18PM -0700, Daniel Walker wrote: > On Fri, 2007-03-30 at 21:09 +0200, Heiko Carstens wrote: > > On Fri, Mar 30, 2007 at 11:45:49AM -0700, Daniel Walker wrote: > > > Update arch/s390 with list initialization. > > > > > > Signed-Off

Re: [patch 1/8] Processor degredation support.

2007-04-02 Thread Heiko Carstens
On Wed, Mar 28, 2007 at 08:41:45AM +, Pavel Machek wrote: > On Wed 2007-03-28 08:54:43, Heiko Carstens wrote: > > > > +++ linux-2.6/drivers/s390/char/sclp_confmgm.c > > > > > > Can we get less cyptic name? > > > > Would you like to see sclp_c

Re: [1/3] dynamically allocate IRQ stacks

2007-05-01 Thread Heiko Carstens
> +static void * __init __alloc_irqstack(int cpu) > +{ > + if (!cpu) > + return __alloc_bootmem(THREAD_SIZE, THREAD_SIZE, > + __pa(MAX_DMA_ADDRESS)); > + > + return (void *)__get_free_pages(GFP_KERNEL, > +

Re: /sys/devices/system/cpu/*: Present cpus or Possible cpus

2007-05-03 Thread Heiko Carstens
On Thu, May 03, 2007 at 12:22:35AM +0530, Gautham R Shenoy wrote: > On Wed, May 02, 2007 at 11:37:57AM -0500, Nathan Lynch wrote: > > Hi Gautham- > > > > I believe that the powerpc behavior was established before > > cpu_present_map was introduced. > > Ok. I guess the same is the reason with a fe

Re: [PATCH 00/13] Virtually mapped stacks with guard pages (x86, core)

2016-06-19 Thread Heiko Carstens
On Fri, Jun 17, 2016 at 10:38:24AM -0700, Andy Lutomirski wrote: > > A disassembly looks like this (r15 is the stackpointer): > > > > 0670 : > > 670: eb 6f f0 48 00 24 stmg%r6,%r15,72(%r15) > > 676: c0 d0 00 00 00 00 larl%r13,676 > > 67c:

Re: [PATCH 00/13] Virtually mapped stacks with guard pages (x86, core)

2016-06-20 Thread Heiko Carstens
On Sun, Jun 19, 2016 at 11:01:48PM -0700, Andy Lutomirski wrote: > > The tmll instruction tests if any of the higher bits within the 16k > > stackframe address are set. In this specific case that would be bits 7-15 > > (mask 0x3f80). If no bit would be set we know that only up to 128 bytes > > woul

[PATCH] scripts/bloat-o-meter: fix percent change output

2016-06-21 Thread Heiko Carstens
64 +6 Total: Before=24794284, After=24794308, chg 0.97% Cc: Vineet Gupta Signed-off-by: Heiko Carstens --- scripts/bloat-o-meter | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter index 0254f3ba0dba..5a5d383004f5 100755 --- a/sc

Re: [PATCH] scripts/bloat-o-meter: fix percent change output

2016-06-21 Thread Heiko Carstens
On Tue, Jun 21, 2016 at 08:00:05AM +, Vineet Gupta wrote: > Hi Heiko, > > On Tuesday 21 June 2016 01:10 PM, Heiko Carstens wrote: > > commit b21e91c305bc "scripts/bloat-o-meter: print percent change" > > introduced an additional line to the output of the bloat

Re: [BUG -next] "random: make /dev/urandom scalable for silly userspace programs" causes crash

2016-07-27 Thread Heiko Carstens
On Wed, Jul 27, 2016 at 11:46:01PM -0400, Theodore Ts'o wrote: > On Wed, Jul 27, 2016 at 09:14:00AM +0200, Heiko Carstens wrote: > > it looks like your patch "random: make /dev/urandom scalable for silly > > userspace programs" within linux-next seems to be a bit b

Re: [BUG -next] "random: make /dev/urandom scalable for silly userspace programs" causes crash

2016-07-28 Thread Heiko Carstens
On Thu, Jul 28, 2016 at 07:55:48AM +0200, Heiko Carstens wrote: > On Wed, Jul 27, 2016 at 11:46:01PM -0400, Theodore Ts'o wrote: > > On Wed, Jul 27, 2016 at 09:14:00AM +0200, Heiko Carstens wrote: > > > it looks like your patch "random: make /dev/urandom scalable for si

Re: [bisected] "sched: Allow per-cpu kernel threads to run on online && !active" causes warning

2016-07-30 Thread Heiko Carstens
On Wed, Jul 27, 2016 at 05:23:05PM +0200, Thomas Gleixner wrote: > On Wed, 27 Jul 2016, Heiko Carstens wrote: > > [3.162961] ([<00176c30>] select_task_rq+0xc0/0x1a8) > > [3.162963] ([<00177d64>] try_to_wake_up+0x2e4/0x478) > > [

Re: [PATCH 1/2] ubsan: allow to disable the null sanitizer

2016-09-12 Thread Heiko Carstens
On Mon, Sep 12, 2016 at 02:37:19PM +0200, Christian Borntraeger wrote: > Some architectures use a hardware defined struct at address zero. > Checking for a null pointer will result in many ubsan reports. > Let users disable the null sanitizer. > > Signed-off-by: Christian Borntraeger > --- > lib

Re: [PATCH] s390: cleanup with list_first_entry_or_null()

2016-09-12 Thread Heiko Carstens
On Tue, Sep 13, 2016 at 03:10:39AM +0900, Masahiro Yamada wrote: > The combo of list_empty() check and return list_first_entry() > can be replaced with list_first_entry_or_null(). > > Signed-off-by: Masahiro Yamada > --- > > arch/s390/kernel/crash_dump.c | 5 ++--- > 1 file changed, 2 insertion

Re: [PATCH] s390/hypfs: Use kmalloc_array() in diag0c_store()

2016-09-01 Thread Heiko Carstens
On Thu, Sep 01, 2016 at 11:38:15AM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 1 Sep 2016 11:30:58 +0200 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding functi

Re: BUG: using __this_cpu_read() in preemptible [00000000] code: mm_percpu_wq/7

2017-08-16 Thread Heiko Carstens
Tejun, can you make any sense of the below? It _looks_ like a bug in the workqueue code. Andre's testcase is also doing cpu hotplug until we finally see a workqueue.c warning. On Wed, Jul 12, 2017 at 10:44:54AM -0500, Christopher Lameter wrote: > On Wed, 7 Jun 2017, Andre Wild wrote: > > > I'm c

Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX

2017-05-26 Thread Heiko Carstens
On Fri, May 26, 2017 at 09:03:13AM +0200, Thomas Gleixner wrote: > > It seems like it really should. That would put it in a single place > > and avoid this mistake again in the future. Does module_memfree() have > > access to the allocation size, or does that need to get plumbed? > > No, it doesn'

Re: [-next] memory hotplug regression

2017-05-26 Thread Heiko Carstens
On Wed, May 24, 2017 at 10:39:57AM +0200, Michal Hocko wrote: > On Wed 24-05-17 10:20:22, Heiko Carstens wrote: > > Having the ZONE_MOVABLE default was actually the only point why s390's > > arch_add_memory() was rather complex compared to other architectures. > > > &

Re: [PATCH] s390: provide default ioremap and iounmap declaration

2017-05-26 Thread Heiko Carstens
G_PCI set, but it is needed to compile. Thus, > if the function is ever hit it returns NULL. > > Signed-off-by: Logan Gunthorpe > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Al Viro > --- > > Thanks to Al Viro for pointing out this corner case in s390. > &

Re: [-next] memory hotplug regression

2017-05-29 Thread Heiko Carstens
On Mon, May 29, 2017 at 10:52:31AM +0200, Michal Hocko wrote: > > Why is it a problem to change the default for 'online'? As far as I can see > > that doesn't have too much to do with the order of zones, no? > > `online' (aka MMOP_ONLINE_KEEP) should always inherit its current zone. > The previous

Re: [PATCH v2 2/7] x86: use long long for 64-bit atomic ops

2017-05-29 Thread Heiko Carstens
On Fri, May 26, 2017 at 09:09:04PM +0200, Dmitry Vyukov wrote: > Some 64-bit atomic operations use 'long long' as operand/return type > (e.g. asm-generic/atomic64.h, arch/x86/include/asm/atomic64_32.h); > while others use 'long' (e.g. arch/x86/include/asm/atomic64_64.h). > This makes it impossible

Re: [-next] memory hotplug regression

2017-05-30 Thread Heiko Carstens
On Tue, May 30, 2017 at 02:18:06PM +0200, Michal Hocko wrote: > > So ZONE_DMA ends within ZONE_NORMAL. This shouldn't be possible, unless > > this restriction is gone? > > The patch below should help. It does fix this specific problem, but introduces a new one: # echo online_movable > /sys/devic

Re: [-next] memory hotplug regression

2017-05-30 Thread Heiko Carstens
On Tue, May 30, 2017 at 04:32:47PM +0200, Michal Hocko wrote: > On Tue 30-05-17 14:37:24, Heiko Carstens wrote: > > On Tue, May 30, 2017 at 02:18:06PM +0200, Michal Hocko wrote: > > > > So ZONE_DMA ends within ZONE_NORMAL. This shouldn't be possible, unless > &

[GIT PULL] s390 updates for v4.15

2017-11-12 Thread Heiko Carstens
s390/zcrypt: Enable special header file flag for AU CPRP s390/zcrypt: Introduce QACT support for AP bus devices. s390/archrandom: Reconsider s390 arch random implementation s390/zcrypt: Rework struct ap_qact_ap_info. Heiko Carstens (31): s390: convert release_thread()

Re: [GIT PULL] locking changes for v4.15

2017-11-13 Thread Heiko Carstens
On Mon, Nov 13, 2017 at 12:42:44PM -0800, Linus Torvalds wrote: > On Sun, Nov 12, 2017 at 11:31 PM, Ingo Molnar wrote: > > > > Please pull the latest locking-core-for-linus git tree from: > > Ok, this clashed pretty badly with the s390 update which had big > locking changes to use the generic cod

Re: [PATCH 5/9] s390: net: add SPDX identifiers to the remaining files

2017-11-14 Thread Heiko Carstens
iedmann > Cc: Ursula Braun > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman > --- > diff --git a/drivers/s390/net/fsm.c b/drivers/s390/net/fsm.c > index 8c14c6c3a

[PATCH] s390/mm: fix pud table accounting

2017-11-03 Thread Heiko Carstens
there is no "mm->nr_pmds" anymore. Cc: Kirill A. Shutemov Cc: Michal Hocko Cc: Gerald Schaefer Cc: Martin Schwidefsky Signed-off-by: Heiko Carstens --- arch/s390/include/asm/mmu_context.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/s390/include/asm/

Re: [tip:x86/fpu] bitops: Add clear/set_bit32() to linux/bitops.h

2017-11-05 Thread Heiko Carstens
On Tue, Oct 17, 2017 at 09:21:46AM -0700, tip-bot for Andi Kleen wrote: > Commit-ID: cbe96375025e14fc76f9ed42ee5225120d7210f8 > Gitweb: > https://git.kernel.org/tip/cbe96375025e14fc76f9ed42ee5225120d7210f8 > Author: Andi Kleen > AuthorDate: Fri, 13 Oct 2017 14:56:41 -0700 > Committer: I

Re: [PATCH] [s390]: Use .rept directive to store/load fpu registers

2015-09-07 Thread Heiko Carstens
On Tue, Sep 01, 2015 at 09:51:32AM +0200, Christian Borntraeger wrote: > Am 28.08.2015 um 15:49 schrieb Alexander Kuleshov: > > arch/s390/kernel/swsusp.S | 49 > > --- > > 1 file changed, 17 insertions(+), 32 deletions(-) > > > > diff --git a/arch/s390

futex timeout not working? (bisected)

2015-10-15 Thread Heiko Carstens
Hi Thomas, I received a bug report from Stefan Liebler that certain futex timeouts do not work anymore at least on s390 (see test case below). I did a quick bisect which ended at this commit: 868a3e915f7f5eba8f8cb4f7da2276760807c51c is the first bad commit commit 868a3e915f7f5eba8f8cb4f7da227676

Re: [RFC][PATCH] sched: Start stopper early

2015-10-16 Thread Heiko Carstens
On Wed, Oct 07, 2015 at 10:41:10AM +0200, Peter Zijlstra wrote: > Hi, > > So Heiko reported some 'interesting' fail where stop_two_cpus() got > stuck in multi_cpu_stop() with one cpu waiting for another that never > happens. > > It _looks_ like the 'other' cpu isn't running and the current best >

Re: futex timeout not working? (bisected)

2015-10-16 Thread Heiko Carstens
On Fri, Oct 16, 2015 at 12:21:51PM +0200, Thomas Gleixner wrote: > Heiko, > > On Thu, 15 Oct 2015, Heiko Carstens wrote: > > /* We wait for half a second. */ > > ts.tv_nsec += 5; > > if (ts.tv_nsec >= 10) > > { > > ++ts.

Re: futex timeout not working? (bisected)

2015-10-16 Thread Heiko Carstens
On Fri, Oct 16, 2015 at 12:33:51PM +0200, Thomas Gleixner wrote: > On Fri, 16 Oct 2015, Heiko Carstens wrote: > > So you are saying this works on x86 and it must be some s390 specific bug? > > time ./f > futex-syscall returned with an error:: Connection timed out > ret = -

Re: futex timeout not working? (bisected)

2015-10-16 Thread Heiko Carstens
On Fri, Oct 16, 2015 at 12:35:23PM +0200, Thomas Gleixner wrote: > On Fri, 16 Oct 2015, Heiko Carstens wrote: > > On Fri, Oct 16, 2015 at 12:21:51PM +0200, Thomas Gleixner wrote: > > > Heiko, > > > > > > On Thu, 15 Oct 2015, Heiko Carstens wrote: &g

Re: futex timeout not working? (bisected)

2015-10-16 Thread Heiko Carstens
On Fri, Oct 16, 2015 at 12:54:51PM +0200, Heiko Carstens wrote: > > > So you are saying this works on x86 and it must be some s390 specific bug? > > > > Looks like. I have no idea why that would break on s390. Did you try > > to revert the commit on top of tree? >

Re: [RFC][PATCH] sched: Start stopper early

2015-10-16 Thread Heiko Carstens
On Fri, Oct 16, 2015 at 11:57:06AM +0200, Peter Zijlstra wrote: > On Fri, Oct 16, 2015 at 10:22:12AM +0200, Heiko Carstens wrote: > > So, actually this doesn't fix the bug and it _seems_ to be reproducible. > > > > [ FWIW, I will be offline for the next two weeks ] &g

Re: futex timeout not working? (bisected)

2015-10-16 Thread Heiko Carstens
On Fri, Oct 16, 2015 at 02:45:37PM +0200, Thomas Gleixner wrote: > The only point I found which does not update the sequence count is > timekeeping_init(). > > Does the patch below fix your issue? > Yes, it does. Thanks for looking into this and fixing it! > 8< > > diff --

Re: [PATCH 4/4] s390/ftrace: add -mfentry and -mnop-mcount support

2018-08-06 Thread Heiko Carstens
me this change makes quite some difference. Reviewed-by: Heiko Carstens

Re: [PATCH v8 04/22] s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.

2018-08-09 Thread Heiko Carstens
On Thu, Aug 09, 2018 at 11:18:05AM -0400, Tony Krowiak wrote: > On 08/09/2018 05:06 AM, Cornelia Huck wrote: > >On Wed, 8 Aug 2018 10:44:14 -0400 > >Tony Krowiak wrote: > > > >>From: Harald Freudenberger > >> > >>Move all the inline functions from the ap bus header > >>file ap_asm.h into the in-

[GIT PULL] s390 updates for 4.19

2018-08-13 Thread Heiko Carstens
include/asm/ap.h. s390/zcrypt: add copy_from_user length plausibility checks Heiko Carstens (1): s390/sysinfo: add missing #ifdef CONFIG_PROC_FS Hendrik Brueckner (1): s390/cpum_sf: save TOD clock base in SDBs for time conversion Janosch Frank (11): s390/mm: Make gmap_

Re: [PATCH 8/8] kprobes/s390: Fix %p uses in error messages

2018-01-27 Thread Heiko Carstens
On Thu, Jan 25, 2018 at 02:30:32PM +0900, Masami Hiramatsu wrote: > Remove %p because the kprobe will be dumped in > dump_kprobe(). > > Signed-off-by: Masami Hiramatsu > --- > arch/s390/kernel/kprobes.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kernel

Re: [PATCH 4/6] s390: add system call to run tasks with modified branch prediction

2018-01-17 Thread Heiko Carstens
On Wed, Jan 17, 2018 at 12:55:06PM +0100, Martin Schwidefsky wrote: > On Wed, 17 Jan 2018 12:14:52 +0100 > Christian Borntraeger wrote: > > > On 01/17/2018 11:03 AM, Florian Weimer wrote: > > > On 01/17/2018 10:48 AM, Martin Schwidefsky wrote: > > >> rc = syscall(__NR_s390_modify_bp);

Re: [PATCH] s390: fix setgid16/setuid16 handling of -1

2018-01-15 Thread Heiko Carstens
On Mon, Jan 15, 2018 at 12:52:42PM +0100, Eugene Syromiatnikov wrote: > For some reason, the implementation of these two 16-bit ID system calls > used cast instead of low2highgid/low2highuid macros for converting [GU]IDs, > which leads to incorrect handling of value of -1 (which ought to be > consi

Re: [PATCH v2] s390: fix handling of -1 in set{,fs}[gu]id16 syscalls

2018-01-15 Thread Heiko Carstens
On Mon, Jan 15, 2018 at 08:38:17PM +0100, Eugene Syromiatnikov wrote: > For some reason, the implementation of some 16-bit ID system calls > (namely, setuid16/setgid16 and setfsuid16/setfsgid16) used type cast > instead of low2highgid/low2highuid macros for converting [GU]IDs, which > led to incorr

Re: [PATCH] s390: Remove obsolete bust_spinlock() implementation

2018-11-22 Thread Heiko Carstens
On Fri, Nov 23, 2018 at 11:17:48AM +0900, Sergey Senozhatsky wrote: > On (11/22/18 15:15), Petr Mladek wrote: > > The commit cefc8be82403cf ("Consolidate bust_spinlocks()") kept > > the s390-specific implementation because of the absence of CONFIG_VT. > > In fact, the only difference was calling co

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-26 Thread Heiko Carstens
On Wed, Oct 31, 2018 at 01:36:23PM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: > > On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > > > Thanks for testing. Unfortunately Heiko reported another issue ye

WARN_ON_ONCE(!new_owner) within wake_futex_pi() triggered

2018-11-27 Thread Heiko Carstens
Hello, with the glibc self-tests I was able to trigger the "this should not happen" warning ;) below on s390 (with panic_on_warn=1 set). It looks like it is hardly reproducible. This one happened with commit d146194f31c9 for compiling the kernel. Config can be re-created with "make ARCH=s390 perf

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Heiko Carstens
On Tue, Nov 27, 2018 at 11:05:15AM +0300, Kirill A. Shutemov wrote: > > E.g. something like the below. If there aren't any objections, I will > > provide a proper patch with changelog, etc. > > > > diff --git a/kernel/fork.c b/kernel/fork.c > > index 07cddff89c7b..d7aeec03c57f 100644 > > --- a/ker

[PATCH] mm: warn only once if page table misaccounting is detected

2018-11-27 Thread Heiko Carstens
. Cc: Kirill A. Shutemov Cc: Martin Schwidefsky Signed-off-by: Heiko Carstens --- kernel/fork.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/fork.c b/kernel/fork.c index 07cddff89c7b..c887e9eba89f 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -647,8 +647,8

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Heiko Carstens
On Tue, Nov 27, 2018 at 03:47:13AM -0800, Guenter Roeck wrote: > >E.g. something like the below. If there aren't any objections, I will > >provide a proper patch with changelog, etc. > > > >diff --git a/kernel/fork.c b/kernel/fork.c > >index 07cddff89c7b..d7aeec03c57f 100644 > >--- a/kernel/fork.c

Re: [PATCH] mm: warn only once if page table misaccounting is detected

2018-11-27 Thread Heiko Carstens
On Tue, Nov 27, 2018 at 02:19:16PM +0100, Michal Hocko wrote: > On Tue 27-11-18 09:36:03, Heiko Carstens wrote: > > Use pr_alert_once() instead of pr_alert() if page table misaccounting > > has been detected. > > > > If this happens once it is very likely that there

Re: WARN_ON_ONCE(!new_owner) within wake_futex_pi() triggered

2018-11-29 Thread Heiko Carstens
On Wed, Nov 28, 2018 at 03:32:45PM +0100, Thomas Gleixner wrote: > Heiko, > > On Tue, 27 Nov 2018, Heiko Carstens wrote: > > > with the glibc self-tests I was able to trigger the "this should not > > happen" warning ;) below on s390 (with panic_on_warn=1 se

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-03 Thread Heiko Carstens
On Tue, Jul 03, 2018 at 10:14:49AM +0200, Peter Zijlstra wrote: > On Mon, Jul 02, 2018 at 10:30:09PM -0400, Mathieu Desnoyers wrote: > > > Use "get_user()". It works for 64-bit objects too, and it will be > > > atomic in the 32-bit sub-parts on a 32-bit architecture. > > > > Is it really ? Last ti

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-03 Thread Heiko Carstens
> > > We're piece-wise enabling rseq across architectures anyway, and when the > > > relevant maintains do this, they can have a look at their > > > {get,put}_user() implementations and fix them. > > > > > > If you rely on get_user(u64) working, that means microblaze is already > > > broken, but I

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-03 Thread Heiko Carstens
On Tue, Jul 03, 2018 at 10:55:46AM +0200, Heiko Carstens wrote: > > > > We're piece-wise enabling rseq across architectures anyway, and when the > > > > relevant maintains do this, they can have a look at their > > > > {get,put}_user() implementations and

Re: [PATCH v2 10/10] vfio: ccw: Let user wait when busy on IO

2018-05-25 Thread Heiko Carstens
On Fri, May 25, 2018 at 12:21:18PM +0200, Pierre Morel wrote: > In the current implementation, we do not want to start a new SSCH > command before the last one ends. > > Currently the user needs to poll on the -EBUSY error to > wait before sending a new request. > > Let's be friendly with global

[bisected] 051f3ca02e46 "Introduce NUMA identity node sched domain" breaks fake NUMA on s390

2018-05-12 Thread Heiko Carstens
Hello, Andre Wild reported that fake NUMA doesn't work on s390 anymore. Doesn't work means it crashed for Andre, or it is in an endless loop within init_sched_groups_capacity() for me (sg != sd->groups is always true). I could reproduce this with a very simple setup with only two nodes, where eac

Re: [bisected] 051f3ca02e46 "Introduce NUMA identity node sched domain" breaks fake NUMA on s390

2018-05-14 Thread Heiko Carstens
On Mon, May 14, 2018 at 11:39:09AM +0200, Peter Zijlstra wrote: > On Sat, May 12, 2018 at 12:02:33PM +0200, Heiko Carstens wrote: > > Hello, > > > > Andre Wild reported that fake NUMA doesn't work on s390 anymore. Doesn't > > work means it crashed for Andr

Re: [PATCH v2 0/8] add support for relative references in jump tables

2018-07-04 Thread Heiko Carstens
So this is required for s390 as well. >From 77d87236f3d5474f33c25534d8ba2c7c54c88c55 Mon Sep 17 00:00:00 2001 From: Heiko Carstens Date: Wed, 4 Jul 2018 09:13:37 +0200 Subject: [PATCH] s390/jump_label: switch to relative references Signed-off-by: Heiko Carstens --- arch/s390/Kconfig

Re: Restartable Sequences system call merged into Linux

2018-06-13 Thread Heiko Carstens
On Mon, Jun 11, 2018 at 03:49:18PM -0400, Mathieu Desnoyers wrote: > Hi! > > Good news! The restartable sequences (rseq) system call is now merged into > the master > branch of the Linux kernel within the 4.18 merge window: > > https://github.com/torvalds/linux/commit/d82991a8688ad128b46db1b42d5

Re: [-next] lots of messages due to "mm, memory_hotplug: be more verbose for memory offline failures"

2018-12-17 Thread Heiko Carstens
On Mon, Dec 17, 2018 at 05:39:49PM +0100, Michal Hocko wrote: > On Mon 17-12-18 17:03:50, Michal Hocko wrote: > > On Mon 17-12-18 16:59:22, Heiko Carstens wrote: > > > Hi Michal, > > > > > > with linux-next as of today on s390 I see tons of messages like >

Re: [-next] strace tests fail because of "y2038: socket: Add compat_sys_recvmmsg_time64"

2018-12-17 Thread Heiko Carstens
On Mon, Dec 17, 2018 at 11:05:06PM +0100, Arnd Bergmann wrote: > On Mon, Dec 17, 2018 at 10:40 PM Arnd Bergmann wrote: > > > > On Mon, Dec 17, 2018 at 2:06 PM Heiko Carstens > > wrote: > > > > > > Hi Arnd, > > > > > > in linux-ne

Re: [PATCH] seccomp, s390: fix build for syscall type change

2018-12-17 Thread Heiko Carstens
On Thu, Dec 13, 2018 at 04:50:06PM -0800, Kees Cook wrote: > On Thu, Dec 13, 2018 at 12:10 PM Tycho Andersen wrote: > > > > A recent patch landed in the security tree [1] that changed the type of the > > seccomp syscall. Unfortunately, I didn't quite get every instance of the > > forward declarati

[-next] strace tests fail because of "y2038: socket: Add compat_sys_recvmmsg_time64"

2018-12-17 Thread Heiko Carstens
Hi Arnd, in linux-next as of today 16 strace self tests fail on s390. I could bisect this to b136972b063b ("y2038: socket: Add compat_sys_recvmmsg_time64"). The following tests fail: mmsg.gen.test clock.gen.test regex.gen.test sched.gen.test trace_fstatfs.gen.test trace_personality_regex_64.gen.

[-next] lots of messages due to "mm, memory_hotplug: be more verbose for memory offline failures"

2018-12-17 Thread Heiko Carstens
Hi Michal, with linux-next as of today on s390 I see tons of messages like [ 20.536664] page dumped because: has_unmovable_pages [ 20.536792] page:03d081ff4080 count:1 mapcount:0 mapping:8ff88600 index:0x0 compound_mapcount: 0 [ 20.536794] flags: 0x3fffe010200(slab|head) [

Re: [GIT PULL] timer fix

2018-12-23 Thread Heiko Carstens
On Fri, Dec 21, 2018 at 01:34:53PM +0100, Ingo Molnar wrote: > Linus, > > Please pull the latest timers-urgent-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > timers-urgent-for-linus > ># HEAD: 0e334db6bb4b1fd1e2d72c1f3d8f004313cd9f94 posix-timers

Re: [PATCH v5 13/15] KVM: s390: add function process_gib_alert_list()

2019-01-07 Thread Heiko Carstens
On Mon, Jan 07, 2019 at 08:19:26PM +0100, Michael Mueller wrote: > > On 03.01.19 15:43, Pierre Morel wrote: > >On 19/12/2018 20:17, Michael Mueller wrote: > >>This function processes the Gib Alert List (GAL). It is required > >>to run when either a gib alert interruption has been received or > >>a

Re: [PATCH v3 1/8] arch: Use asm-generic/socket.h when possible

2019-01-08 Thread Heiko Carstens
Deepa Dinamani > --- > arch/s390/include/uapi/asm/Kbuild | 1 + > arch/s390/include/uapi/asm/socket.h | 117 For the s390 bits: Acked-by: Heiko Carstens

Re: [PATCH] kbuild: use assignment instead of define ... endef for filechk_* rules

2019-01-02 Thread Heiko Carstens
ile | 7 ++- > scripts/Kbuild.include | 8 > scripts/kconfig/Makefile | 4 +--- > 6 files changed, 12 insertions(+), 26 deletions(-) For the s390 bits: Acked-by: Heiko Carstens

"bpf: Improve the info.func_info and info.func_info_rec_size behavior" breaks strace self tests

2019-01-03 Thread Heiko Carstens
Hello, the kernel commit 7337224fc150 ("bpf: Improve the info.func_info and info.func_info_rec_size behavior") breaks one of strace's self tests: FAIL: bpf-obj_get_info_by_fd-prog-v.gen Looking into the kernel commit, it seems that the user space visible uapi change is intentional; even though i

Re: "bpf: Improve the info.func_info and info.func_info_rec_size behavior" breaks strace self tests

2019-01-03 Thread Heiko Carstens
On Thu, Jan 03, 2019 at 07:12:05PM +, Martin Lau wrote: > On Thu, Jan 03, 2019 at 12:46:13PM +0100, Heiko Carstens wrote: > > Hello, > > > > the kernel commit 7337224fc150 ("bpf: Improve the info.func_info and > > info.func_info_rec_size behavior&quo

Re: "bpf: Improve the info.func_info and info.func_info_rec_size behavior" breaks strace self tests

2019-01-04 Thread Heiko Carstens
On Thu, Jan 03, 2019 at 11:52:51PM +, Martin Lau wrote: > On Thu, Jan 03, 2019 at 11:41:18PM +0100, Heiko Carstens wrote: > > On Thu, Jan 03, 2019 at 07:12:05PM +, Martin Lau wrote: > > > On Thu, Jan 03, 2019 at 12:46:13PM +0100, Heiko Carstens wrote: > > > &g

[BUG -next 20181008] list corruption with "mm/slub: remove useless condition in deactivate_slab"

2018-10-08 Thread Heiko Carstens
Hello, with linux-next for 20181008 I can reliably crash my system with lot's of debugging options enabled on s390. List debugging triggers the list corruption below, which I could bisect down to this commit: fde06e07750477f049f12d7d471ffa505338a3e7 is the first bad commit commit fde06e07750477f0

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Heiko Carstens
On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > Thanks for testing. Unfortunately Heiko reported another issue yesterday > with the patch applied. This time the other way around: > > BUG: non-zero pgtables_bytes on freeing mm: -16384 > > I am trying to understand how this ca

Re: [BUG -next 20181008] list corruption with "mm/slub: remove useless condition in deactivate_slab"

2018-10-16 Thread Heiko Carstens
On Tue, Oct 16, 2018 at 02:29:28PM +0800, Pingfan Liu wrote: > > I think it is caused by the uinon page->lru and page->next. It can be fixed > > by: > > diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h > > index 3a1a1db..4aa0fb5 100644 > > --- a/include/linux/slub_def.h > > +++ b/i

Re: [PATCH] s390/qeth: fix a missing-check bug

2018-10-07 Thread Heiko Carstens
On Sat, Oct 06, 2018 at 11:08:23AM -0500, Wenwen Wang wrote: > In qeth_snmp_command(), the length of the user request is firstly copied > from the user-space buffer 'udata' to the kernel variable 'req_len' and > checked to see whether it is too large. If the check fails, an error code > EINVAL is r

Re: [PATCH] s390: numa: Export __node_distance

2018-11-04 Thread Heiko Carstens
On Sun, Nov 04, 2018 at 01:28:06PM -0800, Guenter Roeck wrote: > __node_distance is used by nvme, resulting in: > > ERROR: "__node_distance" [drivers/nvme/host/nvme-core.ko] undefined! > > when trying to build nvme as module. > > Fixes: f333444708f8 ("nvme: take node locality into account when s

Re: [PATCH] s390/fault: use wake_up_klogd() in bust_spinlocks()

2018-10-24 Thread Heiko Carstens
On Wed, Oct 24, 2018 at 01:34:25PM +0900, Sergey Senozhatsky wrote: > On (10/24/18 13:30), Sergey Senozhatsky wrote: > From: Sergey Senozhatsky > Subject: [PATCH] s390/fault: use wake_up_klogd() in bust_spinlocks() ... > From the comment it seems that s390 wants to just poke klogd. > There is wa

Re: [PATCH] s390/fault: use wake_up_klogd() in bust_spinlocks()

2018-10-25 Thread Heiko Carstens
On Thu, Oct 25, 2018 at 04:05:43PM +0900, Sergey Senozhatsky wrote: > On (10/25/18 08:28), Heiko Carstens wrote: > > > > With your patch this looks nearly like the common code variant. I did > > some code archaeology and this function is unchanged since ~17 years. > >

Re: [PATCH v3 23/34] s390/cpacf: Unpoison the results of cpacf_trng()

2024-01-02 Thread Heiko Carstens
; arch/s390/include/asm/cpacf.h | 3 +++ > 1 file changed, 3 insertions(+) Acked-by: Heiko Carstens

Re: [PATCH v3 24/34] s390/cpumf: Unpoison STCCTM output buffer

2024-01-02 Thread Heiko Carstens
whole dest manually with kmsan_unpoison_memory(). > > Reported-by: Alexander Gordeev > Signed-off-by: Ilya Leoshkevich > --- > arch/s390/include/asm/cpu_mf.h | 6 ++ > 1 file changed, 6 insertions(+) Acked-by: Heiko Carstens

Re: [PATCH v3 26/34] s390/ftrace: Unpoison ftrace_regs in kprobe_ftrace_handler()

2024-01-02 Thread Heiko Carstens
ings when running the ftrace testsuite. > > Fix by trusting the assembly code and always unpoisoning ftrace_regs in > kprobe_ftrace_handler(). > > Reviewed-by: Alexander Potapenko > Signed-off-by: Ilya Leoshkevich > --- > arch/s390/kernel/ftrace.c | 2 ++ > 1 fi

Re: [PATCH v3 25/34] s390/diag: Unpoison diag224() output buffer

2024-01-02 Thread Heiko Carstens
On Thu, Dec 14, 2023 at 12:24:45AM +0100, Ilya Leoshkevich wrote: > Diagnose 224 stores 4k bytes, which cannot be deduced from the inline > assembly constraints. This leads to KMSAN false positives. > > Unpoison the output buffer manually with kmsan_unpoison_memory(). > > Signed-off-by: Ilya Leos

Re: [PATCH v3 27/34] s390/irqflags: Do not instrument arch_local_irq_*() with KMSAN

2024-01-02 Thread Heiko Carstens
On Thu, Dec 14, 2023 at 12:24:47AM +0100, Ilya Leoshkevich wrote: > KMSAN generates the following false positives on s390x: > > [6.063666] DEBUG_LOCKS_WARN_ON(lockdep_hardirqs_enabled()) > [ ...] > [6.577050] Call Trace: > [6.619637] [<0690d2de>] check_flags+0x1fe/0x21

Re: [PATCH v3 28/34] s390/mm: Define KMSAN metadata for vmalloc and modules

2024-01-02 Thread Heiko Carstens
+ \ > + KMSAN_VMALLOC_SIZE) > +#define KMSAN_MODULES_SHADOW_START (KMSAN_VMALLOC_ORIGIN_START + \ > + KMSAN_VMALLOC_SIZE) Long single lines for these, please :) With that, and Alexander Gordeev's comments addressed: Acked-by: Heiko Carstens

<    1   2   3   4   5   6   7   8   9   10   >