[PATCH] s390/ftrace: fix mcount adjustment

2013-05-13 Thread Heiko Carstens
ix: >From 6a07176c14b6318667f1ebd8c09c7bb4c30d78a0 Mon Sep 17 00:00:00 2001 From: Heiko Carstens Date: Mon, 13 May 2013 14:48:52 +0200 Subject: [PATCH] s390/ftrace: fix mcount adjustment Tony Jones reported that the ftrace self tests on s390 do not work: <6>Testing dynamic ftrace ops #1: (0 0 0 0 0)

[v3.9-rc8]: kernel BUG at mm/memcontrol.c:3994! (was: Re: [BUG][s390x] mm: system crashed)

2013-04-24 Thread Heiko Carstens
On Thu, Apr 18, 2013 at 09:13:03AM +0200, Heiko Carstens wrote: > Ok, thanks for verifying! I'll look into it; hopefully I can reproduce it > here as well. That seems to be a common code bug. I can easily trigger the VM_BUG_ON() below (when I force the system to swap): [

Re: [RFC PATCH net-next 0/6] seccomp filter JIT

2013-04-26 Thread Heiko Carstens
On Fri, Apr 26, 2013 at 03:51:40AM -0400, Xi Wang wrote: > This patchset brings JIT support to seccomp filters for x86_64 and ARM. > It is against the net-next tree. > > The current BPF JIT interface only accepts sk_filter, not seccomp_filter. > Patch 1/6 refactors the interface to make it more ge

Re: [RFC PATCH net-next 0/6] seccomp filter JIT

2013-04-26 Thread Heiko Carstens
On Fri, Apr 26, 2013 at 01:25:39PM +0200, Heiko Carstens wrote: > On Fri, Apr 26, 2013 at 03:51:40AM -0400, Xi Wang wrote: > > This patchset brings JIT support to seccomp filters for x86_64 and ARM. > > It is against the net-next tree. > > > > The current BPF JIT inter

Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-14 Thread Heiko Carstens
On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: > Hello Heiko. > > Commit ea81531d ("s390/uaccess: fix page table walk") > added this code. It looks like it should have break; > for each case. Hi Joe, no, the fallthrough is on purpose for each case statement. > static unsigned lon

Re: [BUG][s390x] mm: system crashed

2013-04-14 Thread Heiko Carstens
On Sun, Apr 14, 2013 at 11:28:40PM -0400, Zhouping Liu wrote: > Hi All, > > I hit the below crashed when doing memory related tests[1] on s390x: > > --- snip - > � 15929.351639¨ � <0021c0a6>¨ shrink_inactive_list+0x1c6/0x56c > � 15929.351647¨ � <

Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

2013-04-14 Thread Heiko Carstens
On Sun, Apr 14, 2013 at 10:53:27PM -0700, Joe Perches wrote: > On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote: > > On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: > > > Commit ea81531d ("s390/uaccess: fix page table walk") > > > added thi

Re: [BUG][s390x] mm: system crashed

2013-04-16 Thread Heiko Carstens
On Mon, Apr 15, 2013 at 02:16:55PM +0800, Zhouping Liu wrote: > On 04/15/2013 01:56 PM, Heiko Carstens wrote: > >On Sun, Apr 14, 2013 at 11:28:40PM -0400, Zhouping Liu wrote: > >>� 16109.346170¨ Call Trace: > >>� 16109.346179¨ (� <00100920>¨ show_trac

Re: [BUG][s390x] mm: system crashed

2013-04-16 Thread Heiko Carstens
On Tue, Apr 16, 2013 at 03:56:59PM +0800, Simon Jeons wrote: > Hi Heiko, > >If you have some time, could you please repeat your test with the kernel > >command line option " user_mode=home "? > > What's the meaning of this command line? I can't find it in > Documentation/kernel-parameters.txt/ It

Lost IPIs during CPU Hotplug

2013-05-20 Thread Heiko Carstens
I just got a dump from a system running a 3.0.something kernel, however I think the problem exists with current kernels as well. Testcase was some I/O intense workload together with cpu hotplug stress. When trying to bring a cpu online we got an endless loop on the cpu that issued the cpu_up and

Re: Lost IPIs during CPU Hotplug

2013-05-21 Thread Heiko Carstens
On Mon, May 20, 2013 at 02:37:43PM +0200, Heiko Carstens wrote: > I just got a dump from a system running a 3.0.something kernel, however I > think the problem exists with current kernels as well. > > Testcase was some I/O intense workload together with cpu hotplug stress. > &

Re: [PATCH 3/5] dump_stack: consolidate dump_stack() implementations and unify their behaviors

2013-03-30 Thread Heiko Carstens
On Fri, Mar 29, 2013 at 07:27:06PM -0700, Tejun Heo wrote: > Both dump_stack() and show_stack() are currently implemented by each > architecture. show_stack(NULL, NULL) dumps the backtrace for the > current task as does dump_stack(). On some archs, dump_stack() prints > extra information - pid, u

Re: [PATCH] s390: replace kmalloc + memset with kzalloc

2013-03-11 Thread Heiko Carstens
On Sun, Mar 10, 2013 at 04:14:00PM +0200, Pekka Enberg wrote: > On Sun, Mar 10, 2013 at 3:13 PM, Stelian Nirlu wrote: > > Signed-off-by: Stelian Nirlu > > --- > > arch/s390/net/bpf_jit_comp.c |3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/arch/s390/net/bpf_ji

Re: [PATCH v2] s390: use kcalloc instead of kmalloc and memset

2013-03-12 Thread Heiko Carstens
On Mon, Mar 11, 2013 at 06:22:10PM +0200, Stelian Nirlu wrote: > Signed-off-by: Stelian Nirlu > --- > arch/s390/net/bpf_jit_comp.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c > index 0972e91..82f165f 10

Re: [PATCH 10/18] driver: s390: block: remove cast for kzalloc return value

2013-03-12 Thread Heiko Carstens
On Tue, Mar 12, 2013 at 01:18:47PM +0800, Zhang Yanfei wrote: > remove cast for kzalloc return value. [...] > diff --git a/drivers/s390/block/dasd_devmap.c > b/drivers/s390/block/dasd_devmap.c > index c196827..a71bb8a 100644 > --- a/drivers/s390/block/dasd_devmap.c > +++ b/drivers/s390/block/dasd

Re: [PATCH 11/18] driver: s390: net: remove cast for kzalloc return value

2013-03-12 Thread Heiko Carstens
On Tue, Mar 12, 2013 at 01:22:40PM +0800, Zhang Yanfei wrote: > remove cast for kzalloc return value. > > Signed-off-by: Zhang Yanfei > drivers/s390/net/qeth_core_main.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/s390/net/qeth_core_main.c > b/drivers

Re: [PATCH v2] [S390] do not clobber personality flags in sys_32_personality()

2012-08-02 Thread Heiko Carstens
On Thu, Aug 02, 2012 at 09:11:23AM +0200, Jiri Kosina wrote: > There are multiple errors in how sys_32_personality() handles personality > flags stored in top three bytes. > > - directly comparing current->personality against PER_LINUX32 doesn't work > in cases when any of the personality flags

Re: [RFC patch 7/7] thp, s390: architecture backend for thp on System z

2012-08-24 Thread Heiko Carstens
On Thu, Aug 23, 2012 at 07:17:40PM +0200, Gerald Schaefer wrote: > +#define __HAVE_ARCH_PMDP_TEST_AND_CLEAR_YOUNG > +static inline int pmdp_test_and_clear_young(struct vm_area_struct *vma, > + unsigned long address, > +

Re: [PATCH 5/5] s390:block:fix up ENOIOCTLCMD error handling

2012-08-27 Thread Heiko Carstens
NOTTY; > } else > rc = -EINVAL; > } Thanks, but you missed the else path. I'm going to commit the patch below unless Stefan has any objections: >From dac16bd8b314dc6f3f4e6815feab199fdfc8cddd Mon Sep 17 00:00:00 2001 From: Heiko Carstens Date:

Re: [BUG] 2.6.25-rc2-mm1 - kernel oops while bootup on s390x

2008-02-17 Thread Heiko Carstens
On Sun, Feb 17, 2008 at 09:10:46AM +0530, Kamalesh Babulal wrote: > To conform the patches causing the panic, I tested the 2.6.24.2 kernel with > the futex-fix-init-order.patch and > futex-runtime-enable-pi-and-robust-functionality.patch applied and they seem > to cause the kernel > panic. > > U

Re: [PATCH 3/3] drivers/s390/block/dcssblk.c: Fix Unlikely(x) != y

2008-02-17 Thread Heiko Carstens
On Sat, Feb 16, 2008 at 05:16:26PM +0100, Roel Kluin wrote: > The patch below was not yet tested. If it's correct as it is, please comment. > --- > Fix Unlikely(x) != y > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- > diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.

Re: + futex-runtime-enable-pi-and-robust-functionality.patch added to -mm tree

2008-02-18 Thread Heiko Carstens
On Mon, Feb 18, 2008 at 05:00:30AM -0800, Andrew Morton wrote: > On Sat, 16 Feb 2008 13:42:48 +0100 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > > From: Heiko Carstens <[EMAIL PROTECTED]> > > To: linux-kernel@vger.kernel.org > > Cc: [EMAIL PROTECTED], [EMAIL P

Re: + futex-runtime-enable-pi-and-robust-functionality.patch added to -mm tree

2008-02-18 Thread Heiko Carstens
On Mon, Feb 18, 2008 at 05:00:30AM -0800, Andrew Morton wrote: > On Sat, 16 Feb 2008 13:42:48 +0100 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > > From: Heiko Carstens <[EMAIL PROTECTED]> > > To: linux-kernel@vger.kernel.org > > Cc: [EMAIL PROTECTED], [EMAIL P

[PATCH] dm raid1: bitops bug.

2008-02-19 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Commit 8f0205b798f926e2745de5fdebf0a8605c621de6 "dm raid1: handle recovery failures" introduces a test_bit on an integer. test_bit is only defined to do something useful on arrays of long. Remove the test_bit code and use hand coded test

Re: [patch 07/13] Initialize per cpu lowcores on cpu hotplug.

2008-02-19 Thread Heiko Carstens
On Tue, Feb 19, 2008 at 04:13:55PM +0100, Bastian Blank wrote: > On Tue, Feb 19, 2008 at 03:40:54PM +0100, Martin Schwidefsky wrote: > > + /* > > +* Only need to copy the first 512 bytes from address 0. But since > > +* the compiler emits a warning if src == NULL for memcpy use copy_page

Re: [patch 07/13] Initialize per cpu lowcores on cpu hotplug.

2008-02-19 Thread Heiko Carstens
On Tue, Feb 19, 2008 at 04:38:56PM +0100, Heiko Carstens wrote: > On Tue, Feb 19, 2008 at 04:13:55PM +0100, Bastian Blank wrote: > > On Tue, Feb 19, 2008 at 03:40:54PM +0100, Martin Schwidefsky wrote: > > > + /* > > > + * Only need to copy the first 512 byte

Re: [patch 07/13] Initialize per cpu lowcores on cpu hotplug.

2008-02-20 Thread Heiko Carstens
Boah, workaround alert. Why do you not fix the compiler? >>> >>> We need to copy from address 0 (that's where the lowcore resides). But >>> gcc >>> insists to complain if memcpy is used with src == NULL.. Now what? >> >> Erm sorry, misread your question. Usually it's a bug to use memcpy with

Re: [patch 07/13] Initialize per cpu lowcores on cpu hotplug.

2008-02-20 Thread Heiko Carstens
On Wed, Feb 20, 2008 at 11:09:33AM +0100, Bastian Blank wrote: > On Wed, Feb 20, 2008 at 10:45:52AM +0100, Heiko Carstens wrote: > > - copy_page(lowcore, &S390_lowcore); > > + memcpy(lowcore, &S390_lowcore, 512); > > Okay > > > memset((void *)lo

Re: [PATCH 2/2] s390: Always use "long" for ssize_t to match size_t

2012-08-15 Thread Heiko Carstens
On Sun, Aug 12, 2012 at 12:01:34PM +0200, Geert Uytterhoeven wrote: > On s390x-linux-gcc, __SIZE_TYPE__ expands to "long unsigned int" for both > 32-bit s390 and 64-bit s390x, as > gcc-4.6.3-nolibc/s390x-linux/lib/gcc/s390x-linux/4.6.3/plugin/include/config/s390/linux.h > has > > #define SIZE_

preempt rcu bug on s390

2008-02-09 Thread Heiko Carstens
Using CONFIG_PREEMPT_RCU and CONFIG_NO_IDLE_HZ on s390 my system always gets stuck when running with more than one cpu. When booting with four cpus I get all four cpus caught withing cpu_idle and not advancing anymore. However there is the init process which is waitung for synchronize_rcu() to comp

Re: preempt rcu bug on s390

2008-02-09 Thread Heiko Carstens
On Sat, Feb 09, 2008 at 06:07:11AM -0800, Paul E. McKenney wrote: > On Sat, Feb 09, 2008 at 12:34:35PM +0100, Heiko Carstens wrote: > > Using CONFIG_PREEMPT_RCU and CONFIG_NO_IDLE_HZ on s390 my system always > > gets stuck when running with more than one cpu. > > When booting

Re: preempt rcu bug on s390

2008-02-10 Thread Heiko Carstens
> > > > Using CONFIG_PREEMPT_RCU and CONFIG_NO_IDLE_HZ on s390 my system always > > > > gets stuck when running with more than one cpu. > > > > When booting with four cpus I get all four cpus caught withing cpu_idle > > > > and not advancing anymore. However there is the init process which is > > >

Re: [-next]: s390 *_irq() link errors

2012-09-27 Thread Heiko Carstens
provide e.g. request_irq() > and free_irq(). All of this started because I2C lost its HAS_IOMEM dependency. Can't we simply add an !S390 dependency instead and all is well? :) Something like below? >From 24c68e72b6198b8412a8605fac7d9c90796502ac Mon Sep 17 00:00:00 2001 From: Heiko Car

Re: [PATCH] sched: revert load_balance_monitor()

2008-02-25 Thread Heiko Carstens
On Mon, Feb 25, 2008 at 04:28:02PM +0100, Peter Zijlstra wrote: > On Mon, 2008-02-25 at 20:05 +0530, Dhaval Giani wrote: > Subject: sched: fully revert load_balance_monitor() > > The following commit causes a number of serious regressions: > > commit 6b2d7700266b9402e12824e11e0099ae6a4a6a79 >

[PATCH] asm-generic/io.h: convert readX defines to functions

2013-01-07 Thread Heiko Carstens
>From 75cde984766e7a76d194a11e513a039b5d0a6204 Mon Sep 17 00:00:00 2001 From: Heiko Carstens Date: Mon, 7 Jan 2013 14:17:23 +0100 Subject: [PATCH] asm-generic/io.h: convert readX defines to functions E.g. readl is defined like this #define readl(addr) __le32_to_cpu(__raw_readl(addr)) If th

Re: [PATCH] asm-generic/io.h: convert readX defines to functions

2013-01-07 Thread Heiko Carstens
On Mon, Jan 07, 2013 at 03:42:38PM +, Arnd Bergmann wrote: > On Monday 07 January 2013 16:34:59 Heiko Carstens wrote: > > Acked-by: Arnd Bergmann > > if you fix this: > > > +#define readl readl > > +static inline u32 __raw_readl(const volatile void __iomem *a

No Subject

2000-12-11 Thread Heiko . Carstens
Recently I had some thoughts on how to realise CPU attachment and detachment in a running Linux system (based on the 2.4 kernel). CPU attachment and detachment would make sense on an S/390 when there are several Linuxes running, each in its own logical partition. This way a CPU could be taken

CPU attachent and detachment in a running Linux system

2000-12-11 Thread Heiko . Carstens
Recently I had some thoughts on how to realise CPU attachment and detachment in a running Linux system (based on the 2.4 kernel). CPU attachment and detachment would make sense on an S/390 when there are several Linuxes running, each in its own logical partition. This way a CPU could be taken

Re: CPU attachent and detachment in a running Linux system

2000-12-11 Thread Heiko . Carstens
>> sigp. To synchronize n CPUs one can create n kernel threads and give >> them a high priority to make sure they will be executed soon (e.g. by >> setting p->policy to SCHED_RR and p->rt_priority to a very high >> value). As soon as all CPUs are in synchronized state (with >> interrupts disab

Re: CPU attachent and detachment in a running Linux system

2000-12-17 Thread Heiko . Carstens
Hi, >> I still wonder what you and other people think about the idea of an >> interface where the parts of the kernel with per-cpu dependencies should >> register two functions... >Why not compile kernel with structeres big enough for 32 processors, >and then just add CPUs up to the limit wit

Re: CPU attachent and detachment in a running Linux system

2000-12-21 Thread Heiko . Carstens
Hi, >> That's a good point and it would probably work for attachment of cpus, but >> it won't work for detachment because there are some data structures that >> need to be updated if a cpu gets detached. For example it would be nice >> [...] >> So at least for detaching it would make sense to

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Heiko Carstens
On Thu, Jan 03, 2008 at 10:27:28PM +0100, Arjan van de Ven wrote: > > Another issue is that, unlike oopses, WARN_ON() doesn't currently printk > the helpful "cut here" line, nor the "end of trace" marker. > Now that WARN_ON() is out of line, the size increase due to this is > minimal and it's worth

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Heiko Carstens
On Fri, Jan 04, 2008 at 06:50:42AM -0800, Arjan van de Ven wrote: > Heiko Carstens wrote: >> On Thu, Jan 03, 2008 at 10:27:28PM +0100, Arjan van de Ven wrote: >>> Another issue is that, unlike oopses, WARN_ON() doesn't currently printk >>> the helpful "cut here

Re: [PATCHv3] kprobes: Introduce kprobe_handle_fault()

2008-01-08 Thread Heiko Carstens
> +/* > + * If it is a kprobe pagefault we can not be premptible so return before Missing 'e' in preemptible. However, the old code you removed had a lot of preempt_disable/enable calls that you removed. Hope you checked that preemption was always disabled already and the calls were not necessary

Re: [PATCHv4] kprobes: Introduce kprobe_handle_fault()

2008-01-09 Thread Heiko Carstens
> arch/avr32/mm/fault.c | 21 + > arch/ia64/mm/fault.c| 24 +--- > arch/powerpc/mm/fault.c | 25 + > arch/s390/mm/fault.c| 25 + > arch/sparc64/mm/fault.c | 23 +-- > arc

Re: [PATCH 09/20] drivers/s390/: use LIST_HEAD instead of LIST_HEAD_INIT

2007-12-07 Thread Heiko Carstens
On Thu, Dec 06, 2007 at 11:19:41PM +0800, Denis Cheng wrote: > single list_head variable initialized with LIST_HEAD_INIT could almost > always can be replaced with LIST_HEAD declaration, this shrinks the code > and looks better. > > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> > --- > drivers/s

Re: [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Heiko Carstens
On Tue, Dec 11, 2007 at 11:47:39AM +0200, Avi Kivity wrote: > KVM is due to receive support for multiple architectures (ppc, ia64, and > s390, in addition to the existing x86), hopefully in time for the 2.6.25 > merge window. It is awkward to place the new arch support in drivers/kvm/, > so I'd

Re: [RFC/PATCH -v2] Add sysfs control to modify a user's cpu share

2007-10-04 Thread Heiko Carstens
> > Changelog since v1: > > 1. Added a mutex to serialize directory creation/destruction for a user in > >sysfs > > 2. Added a spinlock in the task_group structure to serialize writes to > >tg->shares. > > 3. Removed /proc/root_user_cpu_shares. > > 4. Added Documentation about the group sch

Re: [PATCH] Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch

2007-11-30 Thread Heiko Carstens
On Fri, Nov 30, 2007 at 04:33:19PM +0530, Jaswinder Singh wrote: > This patch fixes s390 dependency for x86 > > Signed-off-by: Jaswinder Singh <[EMAIL PROTECTED]> Deleting random parts of the kernel tree is actually not supported. > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > index 133

Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch

2007-11-30 Thread Heiko Carstens
On Fri, Nov 30, 2007 at 01:44:56PM +0530, Jaswinder Singh wrote: > 2.6.24-rc3 git kernel's x86 make depends on s390 arch: > > 1. HOSTLD scripts/kconfig/conf > scripts/kconfig/conf -s arch/x86/Kconfig > drivers/crypto/Kconfig:51: can't open file "arch/s390/crypto/Kconfig" > make[2]: *** [silento

Re: [PATCH] Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch

2007-11-30 Thread Heiko Carstens
> > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > > > index 1330061..b699ed5 100644 > > > --- a/arch/s390/Kconfig > > > +++ b/arch/s390/Kconfig > > > @@ -537,4 +537,6 @@ source "security/Kconfig" > > > > > > source "crypto/Kconfig" > > > > > > +source "arch/s390/crypto/Kconfig" > > > + >

Re: [PATCH] Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch

2007-11-30 Thread Heiko Carstens
On Fri, Nov 30, 2007 at 06:30:45PM +0530, Jaswinder Singh wrote: > We have two options: > > 1. Either move arch/s390/crypto/Kconfig to drivers/crypto/Kconfig > > OR > > 2. In arch/s390/crypto/Kconfig , replace "depends on S390" to "depends > on CRYPRO_HW" > > I think 2nd option is better for ev

Re: [PATCH] x86_64: some whitespace cleanups in paging code

2007-12-05 Thread Heiko Carstens
On Wed, Dec 05, 2007 at 03:40:12PM +0100, Joerg Roedel wrote: > This patch does some whitespace cleanups in the paging code to fix some > checkpatch.pl warnings of my formerly merged cleanup patches. >... > - set_pmd(pmd + i,__pmd(addr | __PAGE_KERNEL_LARGE_EXEC)); > +

Re: [patch 00/11] Text Edit Lock for 2.6.24-rc4-git3

2007-12-06 Thread Heiko Carstens
On Wed, Dec 05, 2007 at 09:02:46PM -0500, Mathieu Desnoyers wrote: > Hi, > > Here is a repost of the text edit lock for 2.6.24-rc4-mm3. It is useful to > coordinate modification of live kernel code patching. > > It includes a modification to kprobes (its first user) and is useful for the > Immedi

Re: [PATCH 39/59] drivers/s390: Add missing "space"

2007-11-20 Thread Heiko Carstens
On Mon, Nov 19, 2007 at 05:48:31PM -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > --- > drivers/s390/char/monwriter.c |2 +- > drivers/s390/char/vmlogrdr.c |2 +- > drivers/s390/cio/chsc.c |2 +- > drivers/s390/net/claw.c |2 +- > drive

Re: [PATCH 05/59] arch/s390: Add missing "space"

2007-11-20 Thread Heiko Carstens
On Mon, Nov 19, 2007 at 05:47:57PM -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > --- > arch/s390/crypto/aes_s390.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/s390/crypto/aes_s390.c b/arch/s390/crypto/aes_s390.c > index 512

Re: [PATCHv4 2/6] x86&x86-64 support for sys_indirect

2007-11-20 Thread Heiko Carstens
> +#define INDIRECT_SYSCALL(regs) (regs)->rax > +#define INDIRECT_SYSCALL32(regs) (regs)->eax > + > +#define CALL_INDIRECT(regs) \ > + ({ extern long (*sys_call_table[]) (__u64, __u64, __u64, __u64, __u64, > __u64); \ > + sys_call_table[INDIRECT_SYSCALL(regs)] ((regs)->rdi, (regs)->rsi, \ > +

Re: [PATCH 1/3] tty: Add the new termios2 ioctls to the compatible list.

2007-11-20 Thread Heiko Carstens
On Mon, Nov 19, 2007 at 11:02:49PM -0800, Andrew Morton wrote: > On Mon, 19 Nov 2007 13:52:06 +0100 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > Index: linux-2.6/fs/compat_ioctl.c > > === > > --- linux

Re: [PATCH 085/196] kset: convert s390 ipl.c to use kset_create

2008-01-25 Thread Heiko Carstens
On Thu, Jan 24, 2008 at 11:31:54PM -0800, Greg Kroah-Hartman wrote: > Dynamically create the kset instead of declaring it statically. > This makes the kobject attributes now work properly that I broke in the > previous patch. Could you please merge this and the previous patch before it goes upstre

Re: [PATCH 085/196] kset: convert s390 ipl.c to use kset_create

2008-01-25 Thread Heiko Carstens
On Fri, Jan 25, 2008 at 09:48:58AM -0800, Greg KH wrote: > On Fri, Jan 25, 2008 at 01:20:53PM +0100, Heiko Carstens wrote: > > On Thu, Jan 24, 2008 at 11:31:54PM -0800, Greg Kroah-Hartman wrote: > > > Dynamically create the kset instead of declaring it statically. > >

[PATCH] Update panic() comment

2005-02-10 Thread Heiko Carstens
[PATCH] Update panic() comment panic() doesn't flush the filesystem cache anymore. The comment above the function still claims it does. Thanks, Heiko diff -urN a/kernel/panic.c b/kernel/panic.c --- a/kernel/panic.cFri Feb 11 07:41:57 2005 +++ b/kernel/panic.cFri Feb 11 07:42:08 2005 @@ -

[TRIVIAL 2.6] Update panic() comment.

2005-02-02 Thread Heiko Carstens
[TRIVIAL 2.6] Update panic() comment. panic() doesn't flush the filesystem cache anymore. The comment above the function still claims it does. Thanks, Heiko = panic.c 1.22 vs edited = --- 1.22/kernel/panic.c 2004-11-08 03:16:06 +01:00 +++ edited/panic.c 2005-02-02 12:25:21 +01:00 @@

Re: [patch 3/6] sclp: call sclp_init() from start_kernel().

2007-11-16 Thread Heiko Carstens
On Fri, Nov 16, 2007 at 04:09:42PM +0100, Bastian Blank wrote: > On Fri, Nov 16, 2007 at 03:29:45PM +0100, Martin Schwidefsky wrote: > > #else > > static inline void acpi_early_init(void) { } > > #endif > > +#ifdef CONFIG_S390 > > +extern int sclp_init(void); > > +#else > > +static inline int sc

[PATCH 1/3] tty: Add the new termios2 ioctls to the compatible list.

2007-11-19 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Make them depend on TCGETS2. If that one is implemented the rest should be there as well. Cc: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- fs/compat_ioctl.c |6 ++ 1 file changed, 6 in

[PATCH 2/3] tty: Let architectures override the user/kernel macros.

2007-11-19 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Give architectures that support the new termios2 the possibilty to overide the user_termios_to_kernel_termios and kernel_termios_to_user_termios macros. As soon as all architectures that use the generic variant have been converted the ifdefs can g

[PATCH 3/3] tty: s390 support for termios2.

2007-11-19 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Backend for s390. Cc: Alan Cox <[EMAIL PROTECTED]> Cc: Martin Schwidefsky <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- include/asm-s390/ioctls.h |4 include/asm-s390/termbits.h |5

Re: [PATCH 3/8] m68k: use .text.head

2007-07-20 Thread Heiko Carstens
On Fri, Jul 20, 2007 at 04:33:08AM +0100, Al Viro wrote: > > i.e. tell modpost that entry point code (that has to be outside > of .init.text for external reasons) is OK to refer to .init.* > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > --- > diff --git a/arch/m68k/kernel/sun3-head.S b/arch/m68k

Re: [PATCH][RFC] getting rid of stupid loop in BUG()

2007-07-24 Thread Heiko Carstens
On Tue, Jul 24, 2007 at 11:29:14PM -0700, David Miller wrote: > From: Jeremy Fitzhardinge <[EMAIL PROTECTED]> > Date: Tue, 24 Jul 2007 23:24:55 -0700 > > > H. Peter Anvin wrote: > > > How far back was __builtin_trap() supported? > > > > I think its relatively recent, but it might be within our su

Re: [Patch] panic.c

2007-08-05 Thread Heiko Carstens
> >The idea behind this is to keep the power usage on panic’d machines > >(without auto-reboot) low. Another point is in an Virtual Machine > >environment the process of the VM is using 100% of the host-cpu. This > >would stuck other programs or VMs. This patch brings the VM to stop and > >keeps th

[patch] ipvs: force read of atomic_t in while loop

2007-08-08 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> For architectures that don't have a volatile atomic_ts constructs like while (atomic_read(&something)); might result in endless loops since a barrier() is missing which forces the compiler to generate code that actually reads memory conten

Re: [patch] ipvs: force read of atomic_t in while loop

2007-08-08 Thread Heiko Carstens
On Wed, Aug 08, 2007 at 03:21:31AM -0700, David Miller wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > Date: Wed, 8 Aug 2007 11:33:00 +0200 > > > Just saw this while grepping for atomic_reads in a while loops. > > Maybe we should re-add the volatile to atomi

Re: [patch] ipvs: force read of atomic_t in while loop

2007-08-08 Thread Heiko Carstens
On Wed, Aug 08, 2007 at 02:31:15PM -0700, Andrew Morton wrote: > On Wed, 08 Aug 2007 17:08:44 -0400 > Chris Snook <[EMAIL PROTECTED]> wrote: > > > Heiko Carstens wrote: > > > On Wed, Aug 08, 2007 at 03:21:31AM -0700, David Miller wrote: > > >> From: Heik

Re: [PATCH] make atomic_t volatile on all architectures

2007-08-09 Thread Heiko Carstens
On Thu, Aug 09, 2007 at 03:31:10AM -0400, Chris Snook wrote: > Linus Torvalds wrote: > > I'd be *much* happier with "atomic_read()" doing the "volatile" instead. > > The fact is, volatile on data structures is a bug. It's a wart in the C > > language. It shouldn't be used. Volatile accesses in *c

Re: [PATCH] MIPS: add smp_call_function_single()

2007-07-28 Thread Heiko Carstens
On Fri, Jul 27, 2007 at 06:53:23AM -0700, Stephane Eranian wrote: > Ralf, > > Here is take 2. > > [MIPS] add smp_call_function_single (take 2) > > signed-off-by: Stephane Eranian <[EMAIL PROTECTED]> > signed-off-by: Phil Mucci <[EMAIL PROTECTED]> > > diff --git a/arch/mips/kernel/smp.c b/arch/m

[PATCH] prevent SSB compilation on s390 part 2

2007-08-01 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should prevent SSB from being selected. But appearantly it looks like this doesn't matter at all if it gets selected from somewhere else. So add an explicit depends on HAS_IOMEM to t

[PATCH] fix slown down printk on boot compile error

2007-08-01 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> The slow-down-printk-during-boot patch depends on preset_lpj being available. That's not the case for architectures that have it's own calibrate_delay() function. kernel/sched.c:3840: undefined reference to `preset_lpj' Cc: Randy Dun

Re: [PATCH] prevent SSB compilation on s390 part 2

2007-08-01 Thread Heiko Carstens
On Wed, Aug 01, 2007 at 11:34:04AM +0200, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should > prevent SSB from being selected. But appearantly it looks like this > doesn't matter at al

[PATCH] Fix WARN_ON() on bitfield ops for all other archs

2007-08-01 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Fixes WARN_ON() on bitfiels ops for all architectures that have been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f. Cc: Alexey Dobriyan <[EMAIL PROTECTED]> Cc: Herbert Xu <[EMAIL PROTECTED]> Cc: Paul Mundt <[EMAIL PROTECTED]>

Re: More documentation: system call how-to

2007-08-01 Thread Heiko Carstens
On Wed, Aug 01, 2007 at 02:06:57PM -0400, Ulrich Drepper wrote: > I've added a few rules I could think of right now. What should be > added as well is a rule for 64-bit parameters on 32-bit platforms. I > leave this to the s390 people who have the biggest restrictions when > it comes to this. D

Re: [patch 17/23] Add cmpxchg_local to s390

2007-08-13 Thread Heiko Carstens
On Sun, Aug 12, 2007 at 10:54:51AM -0400, Mathieu Desnoyers wrote: > Use the standard __cmpxchg for every type that can be updated atomically. > Use the new generic cmpxchg_local (disables interrupt) for other types. > > Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECTED]> > CC: [EMAIL PROTECTED]

Re: [kvm-devel] [PATCH 0/2][KVM] guest time accounting

2007-08-13 Thread Heiko Carstens
> The only thing remotely relevant in the list config is that 'Filter out > duplicate messages to list members (if possible)' is set as a default for > new members. Maybe this means that if a cc is also part of the list, that > cc is stripped (which seems a wierd implementation; I'd have ex

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-15 Thread Heiko Carstens
On Wed, Aug 15, 2007 at 02:49:03PM +0800, Herbert Xu wrote: > Chris Snook <[EMAIL PROTECTED]> wrote: > > > > Because atomic operations are generally used for synchronization, which > > requires > > volatile behavior. Most such codepaths currently use an inefficient > > barrier(). > > Some fo

Re: [patch] s390 kprobe fix instruction length calculation

2007-08-15 Thread Heiko Carstens
On Wed, Aug 15, 2007 at 02:31:40PM -0700, David Wilder wrote: > Placing a kprobe on "bc" instruction (s390/s390x) can cause an oops. > The instruction length is encoded into the first two bits of the s390 > instruction. Kprobe is incorrectly computing the instruction length. > The instruction len

Re: drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Heiko Carstens
On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: > On Wed, 2007-08-15 at 19:58 -0400, Dave Jones wrote: > > Signed-off-by: Dave Jones <[EMAIL PROTECTED]> > > > > diff --git a/drivers/infiniband/hw/mlx4/mad.c > > b/drivers/infiniband/hw/mlx4/mad.c > > index 3330917..0ed02b7 100644 > >

Re: [PATCH] Bug fix for the s390 dcssblk driver

2007-10-21 Thread Heiko Carstens
On Sat, Oct 20, 2007 at 01:24:34PM -0400, emist wrote: > Frans Pop wrote: > > emist wrote: > >> The following patch fixes and issue in the s390 dcssblk driver. The > >> issue is caused when an unsuccessful attempt is made in order to change > >> a segment's type through the device attribute file "s

Re: [patch 0/1] remove header_ops bug in qeth driver

2007-10-22 Thread Heiko Carstens
On Fri, Oct 19, 2007 at 11:55:38PM +0200, Ursula Braun wrote: > -- > Remove qeth driver bug introduced by this commit: > > commit 3b04ddde02cf1b6f14f2697da5c20eca5715017f > Author: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Tue Oct 9 01:40:57 2007 -0700 > > [NET]: Move hardware header o

Re: [PATCH 02/10] [SG] Update block layer to use sg helpers

2007-10-22 Thread Heiko Carstens
On Mon, Oct 22, 2007 at 08:10:56PM +0200, Jens Axboe wrote: > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > --- > block/ll_rw_blk.c |8 ++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c > index 8025d64..61c2e39 100644 > --- a/

[PATCH] fix ll_rw_blk.c build on s390

2007-10-22 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> CC block/ll_rw_blk.o block/ll_rw_blk.c: In function 'blk_rq_map_sg': block/ll_rw_blk.c:1357: error: implicit declaration of function 'sg_dma_len' block/ll_rw_blk.c:1357: error: lvalue required as left operand of assignm

[PATCH] net: fix xfrm build - missing scatterlist.h include

2007-10-22 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> net/xfrm/xfrm_algo.c: In function 'skb_icv_walk': net/xfrm/xfrm_algo.c:555: error: implicit declaration of function 'sg_set_page' make[2]: *** [net/xfrm/xfrm_algo.o] Error 1 Cc: David Miller <[EMAIL PROTECTED]> Cc: Jens

Re: [PATCH 04/10] [SG] Update drivers to use sg helpers

2007-10-22 Thread Heiko Carstens
On Mon, Oct 22, 2007 at 08:10:58PM +0200, Jens Axboe wrote: > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > --- You forgot s390's zfcp driver. But unfortunately the trivial fix below doesn't work. No more I/O possible. Swen and/or Christof could you provide a correct fix for this please? Thanks!

Re: [PATCH 04/10] [SG] Update drivers to use sg helpers

2007-10-23 Thread Heiko Carstens
On Tue, Oct 23, 2007 at 09:14:07AM +0200, Jens Axboe wrote: > On Tue, Oct 23 2007, Heiko Carstens wrote: > > On Mon, Oct 22, 2007 at 08:10:58PM +0200, Jens Axboe wrote: > > > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > > > --- > > > > You for

Re: [BUG] 2.6.23-git19 - S390x: Kernel panic while bringing up the network interface

2007-10-23 Thread Heiko Carstens
On Wed, Oct 24, 2007 at 08:59:06AM +0530, Kamalesh Babulal wrote: > Hi, > > Kernel panic's while bringing up the network interface with the 2.6.23-git19 > > Setting network parameters: Ý OK ¨ > Bringing up loopback interface: Ý OK ¨ > Bringing up interface eth0: > Ý<002e2f72>¨ inet

[PATCH] sg: add missing sg_init_table calls to zfcp

2007-10-23 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> CONFIG_DEBUG_SG reveals two missing sg_init_table calls. Add them. kernel BUG at include/linux/scatterlist.h:50! illegal operation: 0001 [#1] [...] Call Trace: ([<0026f184>] zfcp_ns_gid_pn_request+0x4c/0x2a0) [<0

Re: [PATCH] zfcp: add some internal zfcp adapter statistics

2007-11-03 Thread Heiko Carstens
> +static void zfcp_fsf_req_latency(struct zfcp_fsf_req *fsf_req) > +{ > + struct fsf_qual_latency_info *lat_inf; > + struct zfcp_unit *unit; > + > + lat_inf = &fsf_req->qtcb->prefix.prot_status_qual.latency_info; > + unit = fsf_req->unit; > + > + switch (fsf_req->qtcb->bottom.i

Re: [PATCH] zfcp: add some internal zfcp adapter statistics

2007-11-03 Thread Heiko Carstens
> > + if (!(adapter->adapter_features & FSF_FEATURE_MEASUREMENT_DATA)) { > > + ZFCP_LOG_NORMAL("error: Enhanced measurement feature not " > > + "supported"); > > + return -EOPNOTSUPP; > > + } Btw. any user can flood the console with these messages

[PATCH] s390: cmm - remove unused binary sysctls

2007-11-06 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Remove binary sysctls that never worked due to missing strategy functions. Cc: Eric W. Biederman <[EMAIL PROTECTED]> Cc: Christian Borntraeger <[EMAIL PROTECTED]> Cc: Martin Schwidefsky <[EMAIL PROTECTED]> Signed-off-by: Heiko Ca

Re: [PATCH] ehca: fix kthread_create() error check

2006-12-21 Thread Heiko Carstens
> Index: 2.6-mm/drivers/infiniband/hw/ehca/ehca_irq.c > === > --- 2.6-mm.orig/drivers/infiniband/hw/ehca/ehca_irq.c > +++ 2.6-mm/drivers/infiniband/hw/ehca/ehca_irq.c > @@ -670,11 +670,13 @@ static int comp_pool_callback(struct not >

Re: [S390] cio: fix stsch_reset.

2006-12-31 Thread Heiko Carstens
On Sun, Dec 31, 2006 at 01:31:43AM -0500, Chuck Ebbert wrote: > In-Reply-To: <[EMAIL PROTECTED]> > > On Thu, 28 Dec 2006 11:39:25 +0100, Martin Schwidefsky wrote: > > > @@ -881,10 +880,18 @@ static void cio_reset_pgm_check_handler( > > static int stsch_reset(struct subchannel_id schid, volatile

Re: [POWERPC] Mask 32-bit system call arguments to 32 bits on PPC64 in audit code

2007-02-22 Thread Heiko Carstens
sk is a compat task. It does that at at least one place in kernel/auditsc.c: case 4: /* socketcall */ return ((mask & AUDIT_PERM_WRITE) && ctx->argv[0] == SYS_BIND); So does the audit code assume that the high bits are cleared or is this a bug in the audit co

Re: [PATCH] dma-mapping-broken.h: flesh-out DMA API stubs

2007-02-22 Thread Heiko Carstens
everything that depends on DMA (via e.g. CONFIG_HAS_DMA), so we don't have to compile in all the unused code. If that is is possible... -- Heiko Carstens Linux on System z Development IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Johann Weihen Geschaeftsfuehrung : Her

<    1   2   3   4   5   6   7   8   9   10   >