[PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically

2012-11-28 Thread Heikki Krogerus
Designware UART provides optional Component Parameter Register that lists most of the capabilities of the UART, including FIFO size. This uses that register to set FIFO size for the port before registering it. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c | 57

[PATCH 0/5] serial: 8250: 8250_dw changes and dynamic capabilities

2012-11-28 Thread Heikki Krogerus
Hi, These are mainly small changes to 8250_dw.c. The interesting patch is probable the addition to 8250.c that would allow the drivers to deliver their UART's capabilities when they are registering ports. Heikki Krogerus (5): serial: 8250: Allow drivers to deliver capabilities s

[PATCH 1/5] serial: 8250: Allow drivers to deliver capabilities

2012-11-28 Thread Heikki Krogerus
Modern UARTs are able to provide information about their capabilities such as FIFO size. This allows the drivers to deliver this information to 8250.c when they are registering ports. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250.c | 22 -- 1 file changed

[PATCH 2/5] serial: 8250_dw: Don't use UPF_FIXED_TYPE

2012-11-28 Thread Heikki Krogerus
Allow 8250.c to determine the port type for us. This allows the driver take advantage of FIFO on Designware UARTs that have it. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250

[PATCH 4/5] serial: 8250_dw: Move device tree code to separate function

2012-11-28 Thread Heikki Krogerus
Trivial cleanup. This makes it easier to add different methods to enumerate the device, for example ACPI 5.0 enumeration. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c | 76 ++--- 1 file changed, 46 insertions(+), 30 deletions(-) diff

[PATCH 3/5] serial: 8250_dw: Map IO memory

2012-11-28 Thread Heikki Krogerus
This needs to be done in order to later access the Designware specific registers. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250

Re: [PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically

2012-11-28 Thread Heikki Krogerus
On Wed, Nov 28, 2012 at 01:18:26PM +, Alan Cox wrote: > > + if (!reg || (reg & 0xff) != '*') > > + return; > > + > > That looks bogus. If reg == 0 then reg & 0xFF != '*' > > So why the double test ? No reason. It is something I forgot to cleanup. I'll resend this. Thanks! -- h

[PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically

2012-11-28 Thread Heikki Krogerus
Designware UART provides optional Component Parameter Register that lists most of the capabilities of the UART, including FIFO size. This uses that register to set FIFO size for the port before registering it. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c | 57

Re: [PATCH] tty: serial: 8250: remove U6715 16550A auto-detection

2013-03-21 Thread Heikki Krogerus
Hi guys, On Wed, Mar 20, 2013 at 10:21:25AM -0700, Greg Kroah-Hartman wrote: > On Tue, Mar 19, 2013 at 08:50:09PM +0100, Philippe Langlais wrote: > > - if (up->port.type == PORT_16550A && size_fifo(up) == 64) { > > - up->port.type = PORT_U6_16550A; > > - up->capabilities |= U

Re: [PATCH] serial: 8250_dw: add support for clk api

2013-03-21 Thread Heikki Krogerus
Emilio López FWIW, Reviewed-by: Heikki Krogerus -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] tty/serial: Add support for Altera serial port

2013-03-21 Thread Heikki Krogerus
Hi, On Thu, Mar 07, 2013 at 10:28:37AM +0800, Ley Foon Tan wrote: > diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c > index 0efc815..661096d 100644 > --- a/drivers/tty/serial/8250/8250.c > +++ b/drivers/tty/serial/8250/8250.c > @@ -301,7 +301,28 @@ static const struct

[PATCH 1/2] serial: 8250: Allow probe drivers to ignore tx_loadsz

2013-03-21 Thread Heikki Krogerus
In most cases the tx_loadsz is the same as fifosize. This will store the fifosize in it if it was not separately delivered from the driver. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/8250/8250.c

[PATCH 2/2] serial: of_serial: Handle fifosize property

2013-03-21 Thread Heikki Krogerus
fifosize property is already used with a number of serial devices. This should reduce the need for extra types in 8250.c just in case the fifosize differs from the standard. Signed-off-by: Heikki Krogerus --- Documentation/devicetree/bindings/tty/serial/of-serial.txt |1 + drivers/tty

Re: [PATCH 2/2] serial: of_serial: Handle fifosize property

2013-03-21 Thread Heikki Krogerus
Hi, On Thu, Mar 21, 2013 at 07:41:39PM +0800, Ley Foon Tan wrote: > On Thu, 2013-03-21 at 12:48 +0200, Heikki Krogerus wrote: > > + /* Check for fifo size */ > > + if (of_property_read_u32(np, "fifosize", &prop) == 0) > > + port->fifosize = p

Re: Serial port initialization broken on Armada 370/XP due to "serial: 8250_dw: Don't use UPF_FIXED_TYPE"

2013-02-28 Thread Heikki Krogerus
Hi Gregory. On Wed, Feb 27, 2013 at 05:08:04PM +0100, Gregory CLEMENT wrote: > I found the root of the problem in drivers/tty/serial/8250/8250.c > > in the autoconfig() function, when the IIR register is acceded, it is > done using serial_in(), this function return an int but is used as it > have

Re: [BUG][arm-soc] kernel panic in boot on Openblocks with the latest kernel

2013-02-28 Thread Heikki Krogerus
Hi, On Thu, Feb 28, 2013 at 08:13:30PM +0900, Masami Hiramatsu wrote: > Hi, > > I tried the latest "fixes" branch of arm-soc.git on OpenBlocks > AX3 (Marvel Armada-XP) and got below kernel panic in boot sequence. > It seems that we have an exception while cpu is in idle. > > > Kernel panic

Re: Serial port initialization broken on Armada 370/XP due to "serial: 8250_dw: Don't use UPF_FIXED_TYPE"

2013-02-28 Thread Heikki Krogerus
Hi, On Thu, Feb 28, 2013 at 12:42:06PM +0100, Gregory CLEMENT wrote: > >> Would you agree with this kind of patch to fix the issue? > >> > >> diff --git a/drivers/tty/serial/8250/8250.c > >> b/drivers/tty/serial/8250/8250.c > >> index e2ac25a..0b284c6 100644 > >> --- a/drivers/tty/serial/8250/825

Re: [PATCH 1/6] serial: 8250_dw: add support for clocks property when using DeviceTree

2013-03-15 Thread Heikki Krogerus
Hi, On Thu, Mar 07, 2013 at 11:14:15PM +0100, Maxime Ripard wrote: > From: Emilio López > > This commit implements support for using the "clocks" DT property, instead > of having to use clock-frequency. > > Signed-off-by: Emilio López > --- > drivers/tty/serial/8250/8250_dw.c | 32 +

Re: [PATCH v2] serial: 8250_dw: Improve unwritable LCR workaround

2013-10-02 Thread Heikki Krogerus
- Rebased on tty-next > - Updated commit messsage to mention UART_16550_COMPATIBLE > - Removed potentially unnecessary read of LSR and MSR > - Only attempt workaround when LCR write is ignored I'm OK with this. Reviewed-by: Heikki Krogerus Br, -- heikki -- To unsubscribe

Re: [PATCH] serial: 8250_dw: Improve unwritable LCR workaround

2013-09-27 Thread Heikki Krogerus
Hi, On Wed, Sep 25, 2013 at 03:47:14PM -0700, Tim Kryger wrote: > On Wed, Sep 25, 2013 at 4:42 AM, Heikki Krogerus > wrote: > > On Tue, Sep 24, 2013 at 05:39:09PM -0700, Tim Kryger wrote: > >> static void dw8250_serial_out(struct uart_port *p, int offset, int value) >

Re: [PATCH] serial: 8250_dw: Improve unwritable LCR workaround

2013-09-25 Thread Heikki Krogerus
Hi Tim, On Tue, Sep 24, 2013 at 05:39:09PM -0700, Tim Kryger wrote: > The Designware UART has a limitation where it ignores writes into the > LCR if the UART is busy. The current workaround stashes a copy of the > last written LCR and writes it back down to the hardware if it receives > a special

Re: [PATCH 0/5] serial: 8250: 8250_dw changes and dynamic capabilities

2012-11-30 Thread Heikki Krogerus
On Wed, Nov 28, 2012 at 02:48:39PM +0200, Heikki Krogerus wrote: > Hi, > > These are mainly small changes to 8250_dw.c. The interesting patch is > probable the addition to 8250.c that would allow the drivers to > deliver their UART's capabilities when they are registering

[PATCHv2 0/5] serial: 8250: 8250_dw changes and dynamic capabilities

2012-12-03 Thread Heikki Krogerus
Changes since v1: - rebased on top of Greg's tty-next These are mainly small 8250_dw.c changes. The interesting patch is probable the first one that changes 8250.c so the drivers are able to deliver their UART's capabilities when they are registering ports. Heikki Krogerus (5): se

[PATCHv2 4/5] serial: 8250_dw: Move device tree code to separate function

2012-12-03 Thread Heikki Krogerus
Trivial cleanup. This makes it easier to add different methods to enumerate the device, for example ACPI 5.0 enumeration. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c | 76 ++--- 1 file changed, 46 insertions(+), 30 deletions(-) diff

[PATCHv2 1/5] serial: 8250: Allow drivers to deliver capabilities

2012-12-03 Thread Heikki Krogerus
Modern UARTs are able to provide information about their capabilities such as FIFO size. This allows the drivers to deliver this information to 8250.c when they are registering ports. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250.c | 22 -- 1 file changed

[PATCHv2 3/5] serial: 8250_dw: Map IO memory

2012-12-03 Thread Heikki Krogerus
This needs to be done in order to later access the Designware specific registers. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250

[PATCHv2 5/5] serial: 8250_dw: Set FIFO size dynamically

2012-12-03 Thread Heikki Krogerus
Designware UART provides optional Component Parameter Register that lists most of the capabilities of the UART, including FIFO size. This uses that register to set FIFO size for the port before registering it. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c | 57

[PATCHv2 2/5] serial: 8250_dw: Don't use UPF_FIXED_TYPE

2012-12-03 Thread Heikki Krogerus
Allow 8250.c to determine the port type for us. This allows the driver take advantage of FIFO on Designware UARTs that have it. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250

Re: [PATCHv2 3/5] serial: 8250_dw: Map IO memory

2012-12-04 Thread Heikki Krogerus
Hi Jamie, On Mon, Dec 03, 2012 at 03:40:14PM +, Jamie Iles wrote: > > + uart.port.membase = ioremap(regs->start, regs->end - regs->start); > > Doesn't this have an off-by-one error? True. > + uart.port.membase = ioremap(regs->start, resource_size(regs)); > > instead? Yes, I'll fix t

[PATCHv3 3/5] serial: 8250_dw: Map IO memory

2012-12-04 Thread Heikki Krogerus
This needs to be done in order to later access the Designware specific registers. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250

Re: [PATCH 3/5] tty/8250_dw: Add support for OCTEON UARTS.

2013-06-19 Thread Heikki Krogerus
On Tue, Jun 18, 2013 at 12:12:53PM -0700, David Daney wrote: > A few differences needed by OCTEON: > > o These are DWC UARTS, but have USR at a different offset. > > o OCTEON must have 64-bit wide register accesses, so we have OCTEON > specific register accessors. > > o No UCV register, so we

Re: [PATCH v2 2/4] tty/8250_dw: Add support for OCTEON UARTS.

2013-06-20 Thread Heikki Krogerus
TEON doesn't have a UCV register, I change where > dw8250_setup_port(), which reads the UCV, is called by pushing it in > to the OF and ACPI probe functions, and move unchanged > dw8250_setup_port() earlier in the file. > > Signed-off-by: David Daney > Acked-by: Greg Kroah-Hartman &g

Re: [PATCH 2/2] serial: of_serial: Handle fifosize property

2013-03-22 Thread Heikki Krogerus
On Fri, Mar 22, 2013 at 11:32:18AM +0800, Ley Foon Tan wrote: > On Thu, 2013-03-21 at 15:24 +0200, Heikki Krogerus wrote: > > On Thu, Mar 21, 2013 at 07:41:39PM +0800, Ley Foon Tan wrote: > > > Suggest to use "fifo-size" for the device tree property, to align wi

[PATCHv2 2/2] serial: of_serial: Handle fifo-size property

2013-03-22 Thread Heikki Krogerus
This will reduce the need for extra types in 8250.c just in case the fifo size differs from the standard. Signed-off-by: Heikki Krogerus --- Documentation/devicetree/bindings/tty/serial/of-serial.txt |1 + drivers/tty/serial/of_serial.c |4 2 files

Re: [PATCHv2 2/2] serial: of_serial: Handle fifo-size property

2013-03-22 Thread Heikki Krogerus
Hi, On Fri, Mar 22, 2013 at 04:16:48PM +0800, Ley Foon Tan wrote: > On Fri, 2013-03-22 at 10:05 +0200, Heikki Krogerus wrote: > > This will reduce the need for extra types in 8250.c just > > in case the fifo size differs from the standard. > Besides the fifo size, we need to

Re: [PATCHv2 2/2] serial: of_serial: Handle fifo-size property

2013-03-25 Thread Heikki Krogerus
Hi, On Fri, Mar 22, 2013 at 11:24:21AM +0200, Heikki Krogerus wrote: > On Fri, Mar 22, 2013 at 04:16:48PM +0800, Ley Foon Tan wrote: > > Besides the fifo size, we need to have hardware flow control setting > > from device tree as well. > > This is a bit proble

[PATCH 1/3] serial: 8250: Allow probe drivers to ignore tx_loadsz

2013-03-25 Thread Heikki Krogerus
In most cases the tx_loadsz is the same as fifosize. This will store the fifosize in it if it was not separately delivered from the driver. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/8250/8250.c

[PATCH 3/3] serial: of_serial: Handle hw-flow-control property

2013-03-25 Thread Heikki Krogerus
This will add support for hardware flow control. It is limited to be used only with 8250 driver. Signed-off-by: Heikki Krogerus --- .../devicetree/bindings/tty/serial/of-serial.txt |1 + drivers/tty/serial/of_serial.c| 13 ++--- 2 files changed

[PATCH 2/3] serial: of_serial: Handle fifo-size property

2013-03-25 Thread Heikki Krogerus
This will reduce the need for extra types in 8250.c just in case the fifo size differs from the standard. Signed-off-by: Heikki Krogerus --- Documentation/devicetree/bindings/tty/serial/of-serial.txt |1 + drivers/tty/serial/of_serial.c |4 2 files

[PATCH 0/3] serial: of_serial: new properties

2013-03-25 Thread Heikki Krogerus
These add support for fifo-size and hw-flow-control properties. The idea is to try to avoid adding new types to 8250.c for UARTs that are compatible with the standard types but that have different size fifo or support 16750 compatible auto flow control. Heikki Krogerus (3): serial: 8250

Re: [PATCH 3/3] serial: of_serial: Handle hw-flow-control property

2013-03-25 Thread Heikki Krogerus
On Mon, Mar 25, 2013 at 11:40:31AM +, Arnd Bergmann wrote: > On Monday 25 March 2013, Heikki Krogerus wrote: > > This will add support for hardware flow control. It is > > limited to be used only with 8250 driver. > > > > Signed-off-by: Heikki Krogerus > >

Re: [PATCH 3/3] serial: of_serial: Handle hw-flow-control property

2013-03-25 Thread Heikki Krogerus
On Mon, Mar 25, 2013 at 12:47:58PM +, Arnd Bergmann wrote: > On Monday 25 March 2013, Heikki Krogerus wrote: > > On Mon, Mar 25, 2013 at 11:40:31AM +, Arnd Bergmann wrote: > > > On Monday 25 March 2013, Heikki Krogerus wrote: > > > > This will add support fo

Re: [PATCH 3/3] serial: of_serial: Handle hw-flow-control property

2013-03-25 Thread Heikki Krogerus
On Mon, Mar 25, 2013 at 01:04:47PM +, Arnd Bergmann wrote: > > > I still find the text in the binding and the name of the property > > > confusing, > > > because it seems to imply that you have no hardware flow control without > > > this. > > > I think what you mean here is really "automatic

[PATCHv2 3/3] serial: of_serial: Handle auto-flow-control property

2013-03-25 Thread Heikki Krogerus
Automatic Flow Control capability is not tied to this property. This is only one way of detecting it. The property is limited to be used only with 8250 driver. Signed-off-by: Heikki Krogerus --- .../devicetree/bindings/tty/serial/of-serial.txt |3 +++ drivers/tty/serial/of_serial.c

Re: [BUG][arm-soc] kernel panic in boot on Openblocks with the latest kernel

2013-03-01 Thread Heikki Krogerus
Hi Jason, On Thu, Feb 28, 2013 at 09:29:30AM -0500, Jason Cooper wrote: > If you have a moment, could you put this into a formal patch and send to > lakml? If I could Gregory and Masami's Tested-by's on that, I'll queue > it up for -rc1/2. OK, I'll prepare the patch. I thought that Gregory was g

[PATCH 7/9] serial: 8250_dw: Let ACPI code extract the DMA client info

2013-04-10 Thread Heikki Krogerus
The new ACPI DMA helpers in dmaengine API can take care of extracting all the necessary information regarding DMA. The driver does not need to do this separately any more. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c | 75 + 1 file

[PATCH 9/9] serial: 8250_dw: Use devm_request_and_ioremap()

2013-04-10 Thread Heikki Krogerus
Use resource managed ioremap. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index b7c7d6a..bf2a6e2 100644 --- a/drivers/tty/serial

[PATCH 8/9] serial: 8250_dw: Set port capabilities based on CPR register

2013-04-10 Thread Heikki Krogerus
The Designware UART has an optional support for 16750 compatible Auto Flow Control. This will enable it based on the AFCE bit in Component Parameter Register. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c |4 1 file changed, 4 insertions(+) diff --git a/drivers

[PATCH 0/9] serial: 8250_dma to use the new dmaengine helpers

2013-04-10 Thread Heikki Krogerus
minor improvements for both 8250_dma and 8250_dw plus runtime PM support for 8250_dw. Heikki Krogerus (9): serial: 8250_dma: TX cleanup serial: 8250_dma: Fix RX handling serial: 8250_dma: Use dmaengine helpers to get the slave channels serial: 8250_dma: Provide default slave configuration

[PATCH 4/9] serial: 8250_dma: Provide default slave configuration parameters

2013-04-10 Thread Heikki Krogerus
Some slave channel parameters will be always the same. For example, direction for the Rx channel will always be DMA_DEV_TO_MEM and DMA_MEM_TO_DEV for Tx channel. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dma.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions

[PATCH 5/9] serial: 8250_dw: Enable runtime PM

2013-04-10 Thread Heikki Krogerus
This allows ACPI to put the device to D3 when it's not used. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c | 61 +++-- 1 file changed, 52 insertions(+), 9 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/s

[PATCH 6/9] serial: 8250_dw: Support clk framework also with ACPI

2013-04-10 Thread Heikki Krogerus
The Lynxpoint LPSS peripheral clocks are now handled in clk framework so the drivers do not need to take care of them manually. In dw8250_probe_acpi(), the uartclk is now taken from the driver_data only if it was not already set. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250

[PATCH 3/9] serial: 8250_dma: Use dmaengine helpers to get the slave channels

2013-04-10 Thread Heikki Krogerus
The helper functions in dmaengine API allow the drivers to request slave channels without the filter parameters. They will attempt to extract the needed DMA client information from DT or ACPI, but if such information is not available the filter parameters can still be used. Signed-off-by: Heikki

[PATCH 2/9] serial: 8250_dma: Fix RX handling

2013-04-10 Thread Heikki Krogerus
Overrun, parity and framing errors should be handled in 8250_core. This also adds check for the dma_status and exits if the channel is not idle. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dma.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions

[PATCH 1/9] serial: 8250_dma: TX cleanup

2013-04-10 Thread Heikki Krogerus
Removing one unneeded uart_write_wakeup(). There is no need to start PIO transfer unless DMA fails, so this also changes serial8250_tx_dma() to return 0 unless that is the case. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dma.c | 11 --- 1 file changed, 4

Re: [PATCH 9/9] serial: 8250_dw: Use devm_request_and_ioremap()

2013-04-11 Thread Heikki Krogerus
Hi, I need to redo this patch. On Wed, Apr 10, 2013 at 04:58:32PM +0300, Heikki Krogerus wrote: > Use resource managed ioremap. > > Signed-off-by: Heikki Krogerus > --- > drivers/tty/serial/8250/8250_dw.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[PATCH 9/9] serial: 8250_dw: Convert to devm_ioremap()

2013-04-11 Thread Heikki Krogerus
Use resource managed ioremap. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index b7c7d6a..39b7ae4 100644 --- a/drivers/tty

[PATCH 0/1] serial: 8250_dw: fix for tty-next

2013-04-12 Thread Heikki Krogerus
Heikki Krogerus (1): serial: 8250_dw: Fix the stub for dw8250_probe_acpi() drivers/tty/serial/8250/8250_dw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[PATCH 1/1] serial: 8250_dw: Fix the stub for dw8250_probe_acpi()

2013-04-12 Thread Heikki Krogerus
This fixes the stub for dw8250_probe_acpi() that is used when compiling without ACPI enabled. The argument type was wrong. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250

Re: [PATCHv2 0/5] serial: 8250: 8250_dw changes and dynamic capabilities

2013-01-09 Thread Heikki Krogerus
Hi, On Mon, Dec 03, 2012 at 01:17:54PM +0200, Heikki Krogerus wrote: > Changes since v1: > - rebased on top of Greg's tty-next > > These are mainly small 8250_dw.c changes. The interesting patch is > probable the first one that changes 8250.c so the drivers are able to &g

[PATCHv3 0/8] serial: 8250: 8250_dw changes and dmaengine support

2013-01-10 Thread Heikki Krogerus
supported on most platforms, I decided to suggest this solution. I tried to make the DMA support as simple as I could. Single transfers with single descriptors. This should be sufficient in most cases. Heikki Krogerus (8): serial: 8250: Allow drivers to deliver capabilities serial: 8250_dw: Don'

[PATCHv3 4/8] serial: 8250_dw: Move device tree code to separate function

2013-01-10 Thread Heikki Krogerus
Trivial cleanup. This makes it easier to add different methods to enumerate the device, for example ACPI 5.0 enumeration. Signed-off-by: Heikki Krogerus Reviewed-by: Jamie Iles Acked-by: Alan Cox --- drivers/tty/serial/8250/8250_dw.c | 78 ++--- 1 file

[PATCHv3 3/8] serial: 8250_dw: Map IO memory

2013-01-10 Thread Heikki Krogerus
This needs to be done in order to later access the Designware specific registers. Signed-off-by: Heikki Krogerus Reviewed-by: Jamie Iles Acked-by: Alan Cox --- drivers/tty/serial/8250/8250_dw.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial

[PATCHv3 2/8] serial: 8250_dw: Don't use UPF_FIXED_TYPE

2013-01-10 Thread Heikki Krogerus
Allow 8250.c to determine the port type for us. This allows the driver take advantage of FIFO on Designware UARTs that have it. Signed-off-by: Heikki Krogerus Reviewed-by: Jamie Iles Acked-by: Alan Cox --- drivers/tty/serial/8250/8250_dw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCHv3 8/8] serial: 8250_dw: Enable DMA support with ACPI

2013-01-10 Thread Heikki Krogerus
With ACPI 5.0 we can use the FixedDMA Resource Descriptor to extract the needed information for DMA support. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c | 65 + 1 file changed, 65 insertions(+) diff --git a/drivers/tty/serial/8250

[PATCHv3 7/8] serial: 8250: Add support for dmaengine

2013-01-10 Thread Heikki Krogerus
Add support for dmaengine API. The drivers can implement the struct uart_8250_dma member in struct uart_8250_port and 8250.c can take care of the rest. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250.c | 31 +- drivers/tty/serial/8250/8250.h | 50

[PATCHv3 6/8] serial: 8250_dw: Add ACPI 5.0 support

2013-01-10 Thread Heikki Krogerus
This adds support for ACPI 5.0 enumerated Designware UARTs. ACPI does not deliver information about uart clk, so delivering it with the driver_data. Signed-off-by: Heikki Krogerus --- drivers/tty/serial/8250/8250_dw.c | 41 + drivers/tty/serial/8250/Kconfig

[PATCHv3 5/8] serial: 8250_dw: Set FIFO size dynamically

2013-01-10 Thread Heikki Krogerus
Designware UART provides optional Component Parameter Register that lists most of the capabilities of the UART, including FIFO size. This uses that register to set FIFO size for the port before registering it. Signed-off-by: Heikki Krogerus Reviewed-by: Jamie Iles Acked-by: Alan Cox

[PATCHv3 1/8] serial: 8250: Allow drivers to deliver capabilities

2013-01-10 Thread Heikki Krogerus
Modern UARTs are able to provide information about their capabilities such as FIFO size. This allows the drivers to deliver this information to 8250.c when they are registering ports. Signed-off-by: Heikki Krogerus Reviewed-by: Jamie Iles Acked-by: Alan Cox --- drivers/tty/serial/8250/8250.c

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-06-21 Thread Heikki Krogerus
On Tue, Jun 21, 2016 at 03:08:52PM +0200, Oliver Neukum wrote: > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: > > The purpose of this class is to provide unified interface for user > > space to get the status and basic information about USB Type-C > > Connectors i

[PATCHv3 1/2] usb: USB Type-C connector class

2016-06-21 Thread Heikki Krogerus
. Signed-off-by: Heikki Krogerus --- Documentation/ABI/testing/sysfs-class-typec | 163 Documentation/usb/typec.txt | 101 +++ MAINTAINERS |9 + drivers/usb/Kconfig |2 + drivers/usb/Makefile

[PATCHv3 0/2] USB Type-C Connector class

2016-06-21 Thread Heikki Krogerus
his thing. I'm sorry about that. I'm including in this series a driver for the Broxton PMIC USB Type-C PHY. Changes since v2: - Notification on role and alternate mode changes - cleanups Changes since v1: - Completely rewrote alternate mode support - Patners, cables and cable plugs

[PATCHv3 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY

2016-06-21 Thread Heikki Krogerus
This adds driver for the USB Type-C PHY on Intel WhiskeyCove PMIC which is available on some of the Intel Broxton SoC based platforms. Signed-off-by: Heikki Krogerus --- drivers/usb/typec/Kconfig | 14 ++ drivers/usb/typec/Makefile | 1 + drivers/usb/typec/typec_wcove.c | 376

Re: [PATCHv8 1/2] usb: USB Type-C connector class

2016-09-09 Thread Heikki Krogerus
On Thu, Sep 08, 2016 at 01:04:29PM -0700, Guenter Roeck wrote: > On Thu, Sep 01, 2016 at 02:49:47PM +0300, Heikki Krogerus wrote: > > The purpose of USB Type-C connector class is to provide > > unified interface for the user space to get the status and > > basic informa

Re: [PATCH] serial: 8250_dw: Use an unified new dev variable in probe

2016-08-31 Thread Heikki Krogerus
On Wed, Aug 31, 2016 at 11:27:07AM +0800, Kefeng Wang wrote: > Use an unified new dev variable instead of &pdev->dev and p->dev > in probe function. > > Signed-off-by: Kefeng Wang Reviewed-by: Heikki Krogerus Thanks, -- heikki

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-31 Thread Heikki Krogerus
Hi guys, On Tue, Aug 30, 2016 at 06:47:41AM -0700, Guenter Roeck wrote: > On 08/30/2016 06:11 AM, Heikki Krogerus wrote: > > Hi, > > > > On Tue, Aug 30, 2016 at 02:49:50PM +0300, Heikki Krogerus wrote: > > > On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum

Re: [PATCH v4 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback

2016-08-31 Thread Heikki Krogerus
Hi, On Wed, Aug 31, 2016 at 11:29:11AM +0800, Kefeng Wang wrote: > Make dw8250_set_termios() handle all cases of dw8250_data->clk properly, > then we can safely use dw8250_set_termios() as the default set_termios > callback instead of serial8250_do_set_termios(), so do it. > > Signed-off-by: Kefe

[PATCHv8 1/2] usb: USB Type-C connector class

2016-09-01 Thread Heikki Krogerus
Alternate Modes. Signed-off-by: Heikki Krogerus --- Documentation/ABI/testing/sysfs-class-typec | 219 ++ Documentation/usb/typec.txt | 103 +++ MAINTAINERS |9 + drivers/usb/Kconfig |2 + drivers/usb/Makefile

[PATCHv8 0/2] USB Type-C Connector class

2016-09-01 Thread Heikki Krogerus
quot;. Changes since v2: - Notification on role and alternate mode changes - cleanups Changes since v1: - Completely rewrote alternate mode support - Patners, cables and cable plugs presented as devices. Heikki Krogerus (2): usb: USB Type-C connector class usb: typec: add driver fo

[PATCHv8 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY

2016-09-01 Thread Heikki Krogerus
This adds driver for the USB Type-C PHY on Intel WhiskeyCove PMIC which is available on some of the Intel Broxton SoC based platforms. Signed-off-by: Heikki Krogerus --- drivers/usb/typec/Kconfig | 14 ++ drivers/usb/typec/Makefile | 1 + drivers/usb/typec/typec_wcove.c | 368

Re: [PATCHv8 0/2] USB Type-C Connector class

2016-09-01 Thread Heikki Krogerus
On Thu, Sep 01, 2016 at 05:13:18AM -0700, Guenter Roeck wrote: > Heikki, > > On 09/01/2016 04:49 AM, Heikki Krogerus wrote: > > The USB Type-C class is meant to provide unified interface to the > > userspace to present the USB Type-C ports in a system. > > > Thank

Re: [PATCH v4 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 SoC

2016-09-02 Thread Heikki Krogerus
On Wed, Aug 31, 2016 at 11:29:12AM +0800, Kefeng Wang wrote: > Add ACPI identifier for UART on Hisilicon Hip05 SoC, be careful that > it is not 16550 compatible, and "reg-io-width" and "reg-shift" need > be set properly by _DSD method in DSDT. > > Signed-off

Re: [PATCH v4 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback

2016-09-02 Thread Heikki Krogerus
On Wed, Aug 31, 2016 at 03:07:56PM +0300, Heikki Krogerus wrote: > Hi, > > On Wed, Aug 31, 2016 at 11:29:11AM +0800, Kefeng Wang wrote: > > Make dw8250_set_termios() handle all cases of dw8250_data->clk properly, > > then we can safely use dw8250_set_termios() as

Re: [PATCH v3 03/22] usb: ulpi: Support device discovery via device properties

2016-09-02 Thread Heikki Krogerus
Hi, On Wed, Aug 31, 2016 at 05:40:17PM -0700, Stephen Boyd wrote: > @@ -174,14 +219,37 @@ static int ulpi_register(struct device *dev, struct > ulpi *ulpi) > ulpi->id.product = ulpi_read(ulpi, ULPI_PRODUCT_ID_LOW); > ulpi->id.product |= ulpi_read(ulpi, ULPI_PRODUCT_ID_HIGH) << 8; >

Re: [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties

2016-08-24 Thread Heikki Krogerus
On Tue, Aug 23, 2016 at 12:58:07PM -0700, Stephen Boyd wrote: > On Fri, Aug 5, 2016 at 2:27 PM, Stephen Boyd wrote: > > Quoting Peter Chen (2016-07-08 02:04:58) > >> On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote: > >> > @@ -39,6 +42,10 @@ static int ulpi_match(struct device *dev, st

Re: [RFC PATCH v3 0/2] Type-C Port Manager

2016-08-24 Thread Heikki Krogerus
Hi Guenter, On Tue, Aug 23, 2016 at 02:10:49PM -0700, Guenter Roeck wrote: > The following series of patches implements a USB Type-C Port Manager > using the pending USB Type-C class code as basis. The code is still WIP, > but I think it is important to get feedback from the community at this poin

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-25 Thread Heikki Krogerus
Hi, On Wed, Aug 24, 2016 at 04:08:23PM +0200, Vincent Palatin wrote: > Sorry if I'm making redundant comments with previous discussions, I > might have missed a few threads. > > > On Mon, Aug 22, 2016 at 2:05 PM, Heikki Krogerus > wrote: > > The purpose of USB

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-26 Thread Heikki Krogerus
Hi Vincent, On Fri, Aug 26, 2016 at 03:16:16PM +0200, Vincent Palatin wrote: > >> > +What: /sys/class/typec//current_vconn_role > >> > +Date: June 2016 > >> > +Contact: Heikki Krogerus > >> > +Description: > >> &

Re: Sometimes supports_usb_power_delivery reports incorrect value.

2017-08-16 Thread Heikki Krogerus
On Tue, Aug 15, 2017 at 04:26:07PM -0700, Badhri Jagan Sridharan wrote: > Submitted couple of patches for the missing pieces in TCPM. > Those patches along with "usb: typec: update partner power delivery > support with opmode" > seems to address the issue of reporting the right value for > supports

Re: [PATCH 2/2] typec: tcpm: Only request matching pdos

2017-11-02 Thread Heikki Krogerus
Hi, +Dan and Guenter I'm sorry for the late reply. These slipped under my radar. I do have a one more proposal below, and a few nits.. On Wed, Oct 18, 2017 at 01:22:48PM -0700, Badhri Jagan Sridharan wrote: > At present, TCPM code assumes that local device supports > variable/batt pdos and alway

Re: [PATCH 1/2 v3] typec: tcpm: Validate source and sink caps

2017-11-02 Thread Heikki Krogerus
+Dan and Guenter, I don't have any problems with this, but since I had those few comments for the 2/2 of this series, few nitpics below.. On Wed, Oct 18, 2017 at 01:22:47PM -0700, Badhri Jagan Sridharan wrote: > The source and sink caps should follow the following rules. > This patch validates wh

Re: [GIT PULL] USB/PHY driver changes for 4.15-rc1

2017-11-14 Thread Heikki Krogerus
rt Controller Manager, which of course is not the case any more. Would the attached patch be sufficient? Thanks, -- heikki >From 3bbd624a67df91c23db996db5f2f931fde77fcc1 Mon Sep 17 00:00:00 2001 From: Heikki Krogerus Date: Tue, 14 Nov 2017 14:45:27 +0300 Subject: [PATCH] usb: add user selectable option for the wh

Re: [GIT PULL] USB/PHY driver changes for 4.15-rc1

2017-11-14 Thread Heikki Krogerus
Hi Guenter, On Tue, Nov 14, 2017 at 06:48:21AM -0800, Guenter Roeck wrote: > On 11/14/2017 05:17 AM, Greg KH wrote: > > On Mon, Nov 13, 2017 at 09:29:36PM -0800, Linus Torvalds wrote: > > > On Mon, Nov 13, 2017 at 8:19 AM, Greg KH > > > wrote: > > > > > > > > Other major thing is the typec code

Re: [PATCH] usb: typec: tps6598x: mark expected switch fall-through

2017-10-31 Thread Heikki Krogerus
On Fri, Oct 27, 2017 at 04:01:13PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Heikki Krogerus Thanks, -- heikki

Re: [PATCH] mei, make modules.alias UUID information easier to read

2015-08-28 Thread Heikki Krogerus
: Greg Kroah-Hartman > > Cc: Joe Perches > > Cc: "David S. Miller" > > Cc: Jiri Kosina > > Cc: Sharon Dvir > > Cc: "Suthikulpanit, Suravee" > > Cc: Heikki Krogerus > > Cc: James Hogan > > Cc: Daniel Thompson > > Cc: Michael Opd

Re: [PATCH v5 4/4] platform/x86: Add ACPI i2c-multi-instantiate pseudo driver

2018-08-09 Thread Heikki Krogerus
On Thu, Aug 09, 2018 at 11:15:58AM +0200, Hans de Goede wrote: > On systems with ACPI instantiated i2c-clients, normally there is 1 fw_node > per i2c-device and that fw-node contains 1 I2cSerialBus resource for that 1 > i2c-device. > > But in some rare cases the manufacturer has decided to describ

Re: [PATCH v5 2/3] phy: Move ULPI phy header out of drivers to include path

2017-05-11 Thread Heikki Krogerus
On Thu, May 11, 2017 at 12:17:41PM +0530, Vivek Gautam wrote: > Although ULPI phy is currently being used by tusb1210, > there can be other consumers too in future. So move this > to the includes path for phy. > > Signed-off-by: Vivek Gautam > Cc: Stephen Boyd > Cc:

Re: [PATCH v4 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2018-01-30 Thread Heikki Krogerus
per line in several places in this series, and I many cases it does not look like splitting the line would make the code any less readable. But I don't think that is critical, so if there are no other comments: Acked-by: Heikki Krogerus > --- > inclu

Re: [PATCH v4 2/7] typec: tcpm: Add ADO header for Alert message handling

2018-01-30 Thread Heikki Krogerus
On Tue, Jan 02, 2018 at 03:50:50PM +, Adam Thomson wrote: > This commit adds a header providing definitions for handling Alert > messages. Currently the header only focuses on handling incoming > alerts. > > Signed-off-by: Adam Thomson Acked-by: Heikki Krogerus Thanks, -- heikki

Re: [PATCH v4 3/7] typec: tcpm: Add SDB header for Status message handling

2018-01-30 Thread Heikki Krogerus
On Tue, Jan 02, 2018 at 03:50:51PM +, Adam Thomson wrote: > This commit adds a header providing definitions for handling > Status messages. Currently the header only focuses on handling > incoming Status messages. > > Signed-off-by: Adam Thomson Acked-by: Heikki Kro

  1   2   3   4   5   6   7   8   9   10   >