[PATCH trivial] Remove CONFIG_FORCED_INLINING

Other than the defconfigs, remove the entry in compiler-gcc4.h, Kconfig.debug and feature-removal-schedule.txt. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Documentation/feature-removal-schedule.txt |9 - arch/arm/configs/at91cap9adk_defconfig |1 - ar

[PATCH] x86: fix small sparse warning

arch/x86/kernel/ds.c:226:9: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/ds.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/ds.c b/arch/x86/kernel/ds.c index 1c5ca4d..dcd918c

[PATCH] x86: fix sparse warning in kernel/scx200_32.c

arch/x86/kernel/scx200_32.c:68:72: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/scx200_32.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/scx200_32.c b/arch/x86/kernel/scx20

[PATCH] slub: fix shadowed variable sparse warnings

are new x: mm/slub.c:3513:9: warning: symbol 'x' shadows an earlier one mm/slub.c:3492:6: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- mm/slub.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/mm/slub.c b/mm/

[PATCHv2] slub: fix shadowed variable sparse warnings

d here No need to declare new x: mm/slub.c:3513:9: warning: symbol 'x' shadows an earlier one mm/slub.c:3492:6: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- mm/slub.c | 39 ++- 1 files changed, 18 insertions

Re: about relocs.c on x86

On Thu, 2008-01-31 at 11:11 +0100, Ingo Molnar wrote: > * Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > > during the big first phase of unification we generally kept file > > > names untouched if they were only present in one of the previous > > > arch

Re: about relocs.c on x86

On Thu, 2008-01-31 at 10:52 +0100, Ingo Molnar wrote: > * Yinghai Lu <[EMAIL PROTECTED]> wrote: > > > why not rename relocs.c to relocs_32.c? > > > > it is only used for 32 bit, even it is host app. > > during the big first phase of unification we generally kept file names > untouched if they w

[PATCH] x86: fix sparse warnings in intel_cacheinfo.c

* arch/x86/kernel/cpu/intel_cacheinfo.c:367:48: warning: incorrect type in argument 5 (different signedness) arch/x86/kernel/cpu/intel_cacheinfo.c:367:48:expected unsigned int *edx arch/x86/kernel/cpu/intel_cacheinfo.c:367:48:got int * Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]&g

Re: about relocs.c on x86

On Thu, 2008-01-31 at 11:38 +0100, Sam Ravnborg wrote: > > > > no strong opinion from me - but i think it should be obvious to the > > developer when they are looking at a .c file that it's 32-bit only (or > > 64-bit only). I.e. the default is that whatever .c file we look at is > > unified - a

Feature Removals for 2.6.25

The following are entries in feature-removal-schedule.txt that have come due. Please change the subject when replying to specific items. Where I've gotten responses from the named person in the file, I've included their comment. --- What: MXSER When: December 2007 Wh

Re: Feature Removals for 2.6.25

; this is an ongoing work; symbols get marked unused and then garbage collected > when they're due; for example akpm has several of that kind in his pile right > now How do they get marked? As this is an ongoing effort, should this be moved to the top of the file, and the actual symb

[PATCH] feature-removal: Document suspend/hibernate deprecations

Let this appear as deprecated in 2.6.25, remove after three releases (2.6.28). Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Something like this should be included if you are deprecating userspace functionality. I tried to come up with a useful reason from your changelogs, b

[PATCH] x86: sparse errors from string_32.h

( becomes ) include/asm/string_32.h:223:30: warning: cast truncates bits from constant value ( becomes cc) Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Ingo, this shows up over and over again during the build, this doesn't change anything as they are known c

Re: Feature Removals for 2.6.25

On Thu, 2008-01-31 at 22:33 -0800, Arjan van de Ven wrote: > Harvey Harrison wrote: > > Something like the following (grep found me two example symbols) > > to be honest, nobody reads this file with such detail; the actual UNUSED > marking > is a lot more louder and peop

[PATCH] x86: sparse warnings in pageattr.c

/pageattr.c:99:38:got unsigned int * arch/x86/mm/pageattr.c:215:33: warning: incorrect type in argument 2 (different signedness) arch/x86/mm/pageattr.c:215:33:expected int *level arch/x86/mm/pageattr.c:215:33:got unsigned int * Signed-off-by: Harvey Harrison <[EMAIL PROTEC

[PATCH] x86: make early_console static in early_printk.c

Not necessary to expose it, also fixes sparse warning. arch/x86/kernel/early_printk.c:196:16: warning: symbol 'early_console' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/early_printk.c |2 +- 1 files chang

[PATCH] x86: fix sparse warnings in cpu/common.c

:362:30: warning: incorrect type in argument 3 (different signedness) arch/x86/kernel/cpu/common.c:362:30:expected unsigned int *ebx arch/x86/kernel/cpu/common.c:362:30:got int * Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/common.c

[PATCH] x86: Remove long dead cyrix mtrr code

cyrix_arr_init was #if 0 all the way back to at least v2.6.12. This was the only place where arr3_protected was set to anything but zero. Eliminate this variable. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/mtrr/cyrix.c

Re: [PATCH] x86: sparse errors from string_32.h

On Fri, 2008-02-01 at 11:56 +0100, Ingo Molnar wrote: > * Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > case 1: > > - *(unsigned char *)s = pattern; > > + *(unsigned char *)s = pattern & 0xff; > > i

[PATCH] x86: fixes for lookup_address args

Signedness mismatches in level argument. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Ingo, my other patch changing lookup_address was truncated and missed the other call sites, here's the rest. You can either fold this into that patch or apply separately. arch/x86/kern

Re: Are Section mismatches out of control?

On Fri, 2008-02-01 at 03:03 -0800, Andrew Morton wrote: > On Fri, 1 Feb 2008 11:47:18 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > James said in a related posting that the Section mismatch > > warnings were getting out of control. > > eh. They're easy - the build system tells you about th

Re: [PATCH] x86: sparse errors from string_32.h

On Fri, 2008-02-01 at 10:06 -0800, H. Peter Anvin wrote: > Ingo Molnar wrote: > > * Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > >>case 1: > >> - *(unsigned char *)s = pattern; > >> + *(unsigned

[PATCH 1/2] x86: add cpu init function defintions to cpu.h

eclared. Should it be static? arch/x86/kernel/cpu/umc.c:22:12: warning: symbol 'umc_init_cpu' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/common.c | 10 -- arch/x86/kernel/cpu/cpu.h|9

[PATCH 2/2] x86: add cpu mtrr init function definitions to mtrr.h

x.c:268:12: warning: symbol 'cyrix_init_mtrr' was not declared. Should it be static? arch/x86/kernel/cpu/mtrr/centaur.c:218:12: warning: symbol 'centaur_init_mtrr' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kern

[PATCH 2/3] x86: add function prototype to vm86.h

Global functions should include their prototypes. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- include/asm-x86/vm86.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/asm-x86/vm86.h b/include/asm-x86/vm86.h index a5edf51..b72b9a6 100644 --- a/inclu

[PATCH 1/3] x86: add include to cpu/intel.c

Fixes sparse warning: arch/x86/kernel/cpu/intel.c:48:15: warning: symbol 'ppro_with_ram_bug' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/intel.c |1 + include/asm-x86/bugs.h |2 +- 2 files chang

[PATCH 3/3] x86: small sparse fix in process_32.c

arch/x86/kernel/process_32.c:254:43: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/process_32.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/process_32.c b/arch/x86/

[PATCH] x86: remove final FASTCALL() uses

A few snuck back in to x86. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- include/asm-x86/highmem.h |4 ++-- include/asm-x86/hw_irq_32.h |2 +- include/asm-x86/system.h|4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/asm-x86/highm

Re: [PATCH 2/3] x86: add function prototype to vm86.h

On Sat, 2008-02-02 at 16:14 +0800, Li Zefan wrote: > Harvey Harrison 写道: > > Global functions should include their prototypes. > > > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> > > --- > > include/asm-x86/vm86.h |1 + > >

Re: [PATCH 1 of 7] x86: convert pgalloc_64.h from macros to inlines

On Sat, 2008-02-02 at 01:05 -0800, Jeremy Fitzhardinge wrote: > > -#define __pte_free_tlb(tlb,pte) tlb_remove_page((tlb),(pte)) > - > -#define __pmd_free_tlb(tlb,x) tlb_remove_page((tlb),virt_to_page(x)) > -#define __pud_free_tlb(tlb,x) tlb_remove_page((tlb),virt_to_page(x)) > +extern void __

Re: [PATCH] AMD Thermal Interrupt Support

On Sat, 2008-02-02 at 16:10 -0800, Andrew Morton wrote: > On Thu, 17 Jan 2008 17:06:33 -0800 "Russell Leidich" <[EMAIL PROTECTED]> > wrote: > > > > Here's the hopefully-final version of the patch, which I have just > > > tested on Intel and AMD. > > Curious. This just broke. > > i386 allmodcon

[PATCH] x86: Remove pt_regs arg from smp_thermal_interrupt

The pt_regs arg is never used, make it agree with the other definitions of smp_thermal_interrupt. It doesn't look like smp_thermal_interrupt is even called on 32-bit... Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Andrew, this is a fairly dumb patch, but works-for-me(tm)

Re: [PATCH] x86: Remove pt_regs arg from smp_thermal_interrupt

The pt_regs arg is never used, make it agree with the other definitions of smp_thermal_interrupt. It doesn't look like smp_thermal_interrupt is even called on 32-bit... Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- How about I actually send the patch that worked this time?

[PATCH 1/2] kprobes: Introduce kprobe_handle_fault()

uncovered a possible bug in the s390 version as that purely copied the x86 version unconditionally passing 14 as the trapnr rather than the error_code parameter. s390 is changed to pass error_code in this patch. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Andrew, 1/2 is low risk, 2/2 ha

[PATCH 2/2] kprobe: remove preempt_enable/disable from kprobe_handle_fault()

out before hitting kprobe_running(). Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- include/linux/kprobes.h | 19 --- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h index e5ecb1e..e099426 100644

[PATCH] jbd/jbd2: sparse warnings in revoke.c, journal.c

as NULL pointer fs/jbd2/journal.c:2012:17: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/jbd/journal.c |4 ++-- fs/jbd/revoke.c |4 ++-- fs/jbd2/journal.c | 12 ++-- fs/jbd2/revoke.c |4 ++-- 4 files chang

[PATCH] cpuset: sparse warnings in cpuset.c

ned-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- kernel/cpuset.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/cpuset.c b/kernel/cpuset.c index cfaf641..fdbac43 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c @@ -821,7 +821,7 @@ static int update_cpuma

Re: [PATCH] cpuset: sparse warnings in cpuset.c

Don't redeclare p, use a new variable q. kernel/cpuset.c:824:23: warning: symbol 'p' shadows an earlier one kernel/cpuset.c:746:21: originally declared here kernel/cpuset.c:1272:52: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]

[PATCH] x86: sparse warnings in pageattr.c

Adjust the definition of lookup_address to take an unsigned long level argument. Adjust callers in xen/mmu.c that pass in a dummy variable. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Ingo, sorry for missing this hunk in my previous signedness fixes for lookup_address. arch/

[PATCH] x86: sparse fixes for kvm/x86.c

2:24: warning: symbol 'emulate_ops' was not declared. Should it be static? Drop the return statements: arch/x86/kvm/x86.c:2764:2: warning: returning void-valued expression arch/x86/kvm/x86.c:2830:2: warning: returning void-valued expression Signed-off-by: Harvey Harris

[PATCH] x86: trivial sparse/checkpatch in quirks.c

/quirks.c:393:3: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- The remaining checkpatch errors are false positives. arch/x86/kernel/quirks.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/ar

[PATCH 1/2] kvm: move address_mask define to static function

Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kvm/x86_emulate.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index 7958600..649e14d 100644 --- a/arch/x86/kvm/x86_emu

[PATCH 2/2] kvm: replace more defines with functions

register_address register_address_increment jmp_rel Have a struct decode_cache parameter added instead of having 'c' in the macro. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kvm/x86_emulate.c | 92 ++-- 1 f

[PATCH] x86: dubious one-bit signed bitfield in cpuidle.h

-bit signed bitfield CHECK arch/x86/kernel/cpu/cpufreq/longhaul.c include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield CHECK arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison

[PATCH] x86: fix sparse error in traps_32.c

arch/x86/kernel/traps_32.c:1193:31: error: dubious one-bit signed bitfield This was being used to ensure the proper alignment of the FXSAVE/FXRSTOR data. This would create a sparse error in the _correct_ cases, hiding further warnings. Use BUILD_BUG_ON instead. Signed-off-by: Harvey Harrison

[PATCH] x86: fix sparse warnings in powernow-k8.c

5: warning: symbol 'lo' shadows an earlier one arch/x86/kernel/cpu/cpufreq/powernow-k8.c:824:14: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/cpufreq/powernow-k8.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) di

Re: Announce: Linux-next (Or Andrew's dream :-))

On Mon, 2008-02-11 at 22:11 -0800, David Miller wrote: > From: Arjan van de Ven <[EMAIL PROTECTED]> > Date: Mon, 11 Feb 2008 21:17:51 -0800 > > > this is why you need specific trees for just the API change > > API trees don't work, just like other changes they will have > interdependencies on thi

[PATCH 3/3] Final removal of FASTCALL()/fastcall

All users are gone, remove definitions and comments referring to them. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/drm/i830_dma.c |2 +- include/asm-mn10300/highmem.h |4 ++-- include/asm-mn10300/linkage.h |2 -- include/linux/irq.h

[PATCH 4/3] Documentation: Remove references to FASTCALL/fastcall

An example function prototype and description of options that modify how arguments are passed had references to fastcall. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Andrew, I don't have the knowledge to deal with the rcupdate.c wrapper function, hopefully Paul will be abl

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

On Fri, 2008-02-08 at 10:37 -0600, James Bottomley wrote: > On Fri, 2008-02-08 at 10:03 +0100, Geert Uytterhoeven wrote: > > On Thu, 7 Feb 2008, James Bottomley wrote: > > > On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote: > > > > I'm going to gues

Re: [PATCH] Remove CONFIG_FORCE_INLINING from defconfigs

On Mon, 2008-02-11 at 22:53 +0200, Adrian Bunk wrote: > On Mon, Feb 11, 2008 at 12:29:06PM -0800, Harvey Harrison wrote: > > Option has been removed as of: > > 185c045c245f46485ad8bbd8cc1100e986ff3f13 x86, core: remove > > CONFIG_FORCED_INLINING > >... > > I&#x

[PATCH 1/3] include/linux: Remove all users of FASTCALL() macro

FASTCALL() is always expanded to empty, remove it. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Andrew, FASTCALL is never defined to anything but empty, remove it. include/linux/aio.h| 20 ++-- include/linux/buffer_head.h|6 +++--- include

[PATCH] x86: include prototype for no_broadcast in mach-default/setup.c

Fixes sparse warning: arch/x86/mach-default/setup.c:19:5: warning: symbol 'no_broadcast' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/mach-default/setup.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

[PATCH] x86: pit_clockevent can be static

arch/x86/kernel/i8253.c:98:27: warning: symbol 'pit_clockevent' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/i8253.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/i8

Re: [PATCH] x86: include prototype for no_broadcast in mach-default/setup.c

On Wed, 2008-02-13 at 11:42 +0100, Ingo Molnar wrote: > * Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > Fixes sparse warning: > > arch/x86/mach-default/setup.c:19:5: warning: symbol 'no_broadcast' was not > > declared. Should it be static? > >

Re: [PATCH] fix sparse warning from include/linux/mmzone.h

Maybe I'm beating a dead horse, but here's what I came up with: include/linux/mmzone.h:640:22: warning: potentially expensive pointer subtraction Using arch/x86/mm/highmem_32.o as an example, line 82, PageHighMem expands to is_highmem. if (!PageHighMem(page)) return page

[PATCH] remove sparse warning for mmzone.h

:0x0,%eax Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- include/linux/mmzone.h |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 8d8d197..3109a65 100644 --- a/include/linux/mmzone.h +++ b/include

[PATCH] lguest: include function prototypes

t in linux/lguest.h Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Rusty, just a suggestion. If you'd like Ingo to take it in the x86 tree, please let him know. arch/x86/lguest/boot.c | 10 +- include/asm-x86/lguest.h | 11 +++ 2 files changed, 12 inser

[PATCH 1/2] x86: sparse warning in efi.c

arch/x86/kernel/efi.c:57:12: warning: symbol 'efi_phys' was not declared. Should it be static? Yes, it should. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/efi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/

[PATCH 2/2] x86: sparse error in efi_32.c

? arch/x86/kernel/efi_32.c:84:6: warning: symbol 'efi_call_phys_epilog' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/efi_32.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/

[RFC PATCH] feature-removal: add documentation for exported symbols going away

Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Documentation/feature-removal-schedule.txt | 10 -- Documentation/feature-removal/exported-symbols.txt | 34 arch/x86/kernel/io_delay.c |2 +- net/ipv4/inet_hashta

Re: [2.6 patch] x86: make dump_pagetable() static

On Wed, 2008-02-13 at 23:31 +0200, Adrian Bunk wrote: > dump_pagetable() can now become static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > I believe Andi Kleen wanted this kept global to make it easy to use when adding debugging code elsewhere. Cheers, Harvey -- To unsubscribe from

Re: [RFC PATCH] feature-removal: add documentation for exported symbols going away

On Thu, 2008-02-14 at 00:34 +0200, Adrian Bunk wrote: > On Wed, Feb 13, 2008 at 02:22:06PM -0800, Harvey Harrison wrote: > > + > > +What: __inet_hash_connect > > +Where: net/ipv4/inet_hashtables.c > > +When: 2.6.28 >

[PATCH] kprobes: remove sparse warnings from x86

approach taken from the arm kprobes implementation. kretprobe_trampoline_holder uses inline assemly to define the global symbol kretprobe_trampoline, but nothing ever calls the holder explicitly. trampoline handler is only called from inline assembly in the same file, mark it used and static. S

[PATCH-resend] jbd/jbd2: sparse warnings in revoke.c, journal.c

as NULL pointer fs/jbd2/journal.c:2012:17: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Originally sent Feb 02, 2008 fs/jbd/journal.c |4 ++-- fs/jbd/revoke.c |4 ++-- fs/jbd2/journal.c | 12 ++-- fs/jbd2/revoke.c

[PATCH] dlm: match signedness between dlm_config_info and cluster_set

signedness) fs/dlm/config.c:149:1:expected unsigned int *info_field fs/dlm/config.c:149:1:got int extern [toplevel] * Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/dlm/config.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/dlm/config.c b/fs/dlm/co

Re: [PATCH-resend] jbd/jbd2: sparse warnings in revoke.c, journal.c

On Wed, 2008-02-13 at 16:50 -0800, Andrew Morton wrote: > On Wed, 13 Feb 2008 16:33:37 -0800 > Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > Subject: [PATCH-resend] jbd/jbd2: sparse warnings in revoke.c, journal.c > > ext3/jbd and ext4/jbd2 patches usually find th

[PATCH] debugfs: fix sparse warnings

static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/debugfs/inode.c |4 include/linux/debugfs.h |5 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index d26e282..e9602d8 100644 --- a/fs/debugf

[PATCH] inotify: make variables static in inotify_user.c

inotify_max_user_instances, inotify_max_user_watches, inotify_max_queued_events can all be made static. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/inotify_user.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/inotify_user.c b/fs/inotify_

[PATCH] adfs: trivial sparse fix

fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/adfs/dir_f.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c index b9b2b27..ea7df21 100644

Re: [PATCH] adfs: trivial sparse fix

On Wed, 2008-02-13 at 19:39 -0800, Andrew Morton wrote: > On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound > > statement > > > > Signed-off-b

[PATCH 02/11] ata: fix sparse warning in sata_promise.c

drivers/ata/sata_promise.c:546:15: warning: symbol 'len' shadows an earlier one drivers/ata/sata_promise.c:538:6: originally declared here len is set again immediately after the loop, so this is safe. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/ata/sata_promis

[PATCH 01/11] ata: fix sparse warning in ata_piix.c

drivers/ata/ata_piix.c:1655:8: warning: symbol 'rc' shadows an earlier one drivers/ata/ata_piix.c:1616:6: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/ata/ata_piix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --g

[PATCH 03/11] ata: fix sparse warning in sata_via.c

drivers/ata/sata_via.c:336:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/ata/sata_via.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c index 30caa03..0

[PATCH 04/11] ata: fix sparse warnings in sata_mv.c

lier one drivers/ata/sata_mv.c:1501:22: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/ata/sata_mv.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index 04b5717..2ecd44d 100644 --- a/d

[PATCH 05/11] ata: replace macro with static inline in libata.h

Avoid a metric ton of sparse warnings like: drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one drivers/ata/pata_ali.c:176:14: originally declared here Due to nesting min_t macro inside max_t macro which both use a __x identifier internally. Signed-off-by: Harve

[PATCH 06/11] ata: sparse fixes for pata_amd.c

/pata_amd.c:509:3: warning: Initializer entry defined twice drivers/ata/pata_amd.c:521:3: also defined here drivers/ata/pata_amd.c:544:3: warning: Initializer entry defined twice drivers/ata/pata_amd.c:556:3: also defined here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drive

[PATCH 07/11] ata: fix sparse warning in pata_cs5536.c

Everybody passes in a u32...why fight it. drivers/ata/pata_cs5536.c:124:26: warning: incorrect type in argument 3 (different signedness) drivers/ata/pata_cs5536.c:124:26:expected int *val drivers/ata/pata_cs5536.c:124:26:got unsigned int * Signed-off-by: Harvey Harrison <[EM

[PATCH 08/11] ata: fix sparse warning in pata_jmicron.c

drivers/ata/pata_jmicron.c:118:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/ata/pata_jmicron.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/ata/pata_jmicron.c b/drivers/ata/pata_jmicron.c

[PATCH 09/11] ata: fix sparse warning in pata_marvell.c

drivers/ata/pata_marvell.c:88:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/ata/pata_marvell.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c

[PATCH 10/11] ata: fix sparse warning in pata_acpi.c

drivers/ata/pata_acpi.c:80:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/ata/pata_acpi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c index 2

[PATCH 11/11] ata: fix sparse warnings in pata_legacy.c

dows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an earlier one drivers/ata/pata_legacy.c:129:12: originally declared here Signed-off-by: Harvey Harrison &l

[PATCH 11/11v2] ata: fix sparse warnings in pata_legacy.c

c:882:21: warning: symbol 'qdi' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an earlier one drivers/ata/pata_legacy.c:129:12: originally declared here Signed-off-by: Harvey Harr

Re: [PATCH 05/11] ata: replace macro with static inline in libata.h

On Thu, 2008-02-14 at 12:01 +, Alan Cox wrote: > On Wed, 13 Feb 2008 21:14:18 -0800 > Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > Avoid a metric ton of sparse warnings like: > > drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier

Re: [PATCH] kprobes: remove sparse warnings from x86

On Thu, 2008-02-14 at 10:08 -0500, Masami Hiramatsu wrote: > Harvey Harrison : > > arch/x86/kernel/kprobes.c:584:16: warning: symbol > > 'kretprobe_trampoline_holder' was not declared. Should it be static? > > arch/x86/kernel/kprobes.c:676:6: warning: symbol &#

[PATCH 05/11v2] ata: replace macro with static inline in libata.h

in_t macro inside max_t macro which both use a __x identifier internally. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Alan, is this more to your liking? include/linux/libata.h |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/include/linux/libata.h

[PATCH] kernel-doc: remove fastcall

fastcall is gone from the tree, no need to adjust the function prototypes anymore for this. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- scripts/kernel-doc |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 6

[PATCH] checkpatch: remove fastcall

fastcall no longer exists in tree, remove it from checkpatch. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- scripts/checkpatch.pl |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2086a85..6f9b391 100755

[PATCH] ubi: fix sparse errors in ubi.h

-bit signed bitfield drivers/mtd/ubi/ubi.h:222:18: error: dubious one-bit signed bitfield drivers/mtd/ubi/ubi.h:223:16: error: dubious one-bit signed bitfield drivers/mtd/ubi/ubi.h:224:20: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Sorry, no

[PATCH 3/3] sched: fix signedness warnings in sched.c

: warning: incorrect type in assignment (different signedness) kernel/sched.c:3921:16:expected long *switch_count kernel/sched.c:3921:16:got unsigned long * Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- kernel/sched.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 2/3] sched: trivial sparse warning in sched.c

kernel/sched.c:3680:3: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- kernel/sched.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/sched.c b/kernel/sched.c index f28f19e..824d5a9 100644 --- a/kernel/s

[PATCH 1/3] sched: add declaration of sched_tail to sched.h

Avoids sparse warnings: kernel/sched.c:2170:17: warning: symbol 'schedule_tail' was not declared. Should it be static? Avoids the need for an external declaration in arch/um/process.c Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/um/kernel/process.c |2 -

[PATCH] coda: add static to functions in dir.c

coda_unlink, coda_rmdir, coda_readdir can all be static, the forward declarations already were. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/coda/dir.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/coda/dir.c b/fs/coda/dir.c index f89ff08..3

[PATCH 2/3] ncpfs: fix sparse warnings in ioctl.c

: symbol 'inode' shadows an earlier one fs/ncpfs/ioctl.c:264:28: originally declared here In this case, we are about to return anyway, just reuse result. fs/ncpfs/ioctl.c:521:8: warning: symbol 'result' shadows an earlier one fs/ncpfs/ioctl.c:268:6: originally declared here Sig

[PATCH 1/3] ncpfs: add prototypes to ncp_fs.h

pfs/symlink.c:101:39: warning: symbol 'ncp_symlink_aops' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/ncpfs/inode.c |6 -- include/linux/ncp_fs.h |7 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff

Re: [PATCH] befs: fix sparse warning in linuxvfs.c

On Fri, 2008-02-15 at 13:19 -0800, Andrew Morton wrote: > On Fri, 15 Feb 2008 10:46:04 -0800 > Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > Use link as the variable name to avoid shadowing the arg. > > > > fs/befs/linuxvfs.c:492:8: warning: symbol '

[RFC-PATCH] fuse: shadowed variable warning

fs/fuse/dir.c:909:7: warning: symbol 'err' shadows an earlier one fs/fuse/dir.c:893:6: originally declared here This means that an error between lines 909 and 923 will not be returned. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Miklos, could you confirm whether or

Re: [patch] fuse: fix permission checking

On Fri, 2008-02-15 at 11:23 +0100, Miklos Szeredi wrote: > This is for 2.6.25 and 2.6.24.y, but NOT for 2.6.23.y. > > Thanks, > Miklos > > > From: Miklos Szeredi <[EMAIL PROTECTED]> > > I added a nasty local variable shadowing bug to fuse in 2.6.24, with > the result, that the 'default_perm

[PATCH] befs: fix sparse warning in linuxvfs.c

Use link as the variable name to avoid shadowing the arg. fs/befs/linuxvfs.c:492:8: warning: symbol 'p' shadows an earlier one fs/befs/linuxvfs.c:488:77: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- This should be checked in case there is a

Re: [RFC-PATCH] fuse: shadowed variable warning

On Fri, 2008-02-15 at 20:13 +0100, Miklos Szeredi wrote: > > > > fs/fuse/dir.c:909:7: warning: symbol 'err' shadows an earlier one > > fs/fuse/dir.c:893:6: originally declared here > > > > This means that an error between lines 909 and 923 will not be > > returned. > > Right. Just submitted the

  1   2   3   4   5   >