k for me.
Tested-by: Heinrich Siebmanns
> Regards
> jonathan
>
>> ---
>> I do not have a Fujitsu laptop with a radio LED for testing, so I was
>> only able to check that this patch still does not cause a radio LED to
>> be detected on a Lifebook S7020.
>>
take a look at the I LED...
>
> I could not find anything in the DSDT dump from your laptop that would
> suggest this LED can be controlled using ACPI.
>
Greetings
Harvey
--
I am root. If you see me laughing, you'd better have a backup!
signature.asc
Description: OpenPGP digital signature
83648)
893:Okt 31 11:46:29 gruenix kernel: leds fujitsu::radio_led: Setting an
LED's brightness failed (-2147483648)
But, yes. This is only a cosmetic issue. There don't seem to be too many
people reportig this as well.
Greetings
Harvey
--
I am root. If you see me laughing, you'd b
lease tell me if I can provide more Information.
Greetings
Harvey
--
I am root. If you see me laughing, you'd better have a backup!
dsdt.bin
Description: Binary data
signature.asc
Description: OpenPGP digital signature
ts as I do not have an E751
> myself.)
Don't forget to take a look at the I LED... And concerning time. it is
ready when it's ready ;)
I will be happy to help and test anything that is required. Just send me
a note what needs to be done.
Greetings
Harvey
--
I am root. If you see
Michał, Jonathan,
just a short note: I am currently on vacation in Spain. I have my laptop
with me and will report back as soon as I find the time. I will try to
help in any way that I can. I want my laptop to be as functional as
possible with linux.
Greetings
Harvey
Am 20.07.2017 um 08:42
is what is needed for further
> analysis.
See attachded file
> [1] http://www.lpmanual.com/manuals/fujitsu/Fujitsu_LIFEBOOK_E751.pdf
>
Conclusion: Only the LED I(nformation) and E(mpowering) LEDs are not
working at all.
Glad to help further on. Don't hesitate to contact me. As said before I
am in Spain right now but will frequently check my mail though.
Greetings
Harvey
--
I am root. If you see me laughing, you'd better have a backup!
dsdt.bin
Description: Binary data
signature.asc
Description: OpenPGP digital signature
Other than the defconfigs, remove the entry in compiler-gcc4.h,
Kconfig.debug and feature-removal-schedule.txt.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Documentation/feature-removal-schedule.txt |9 -
arch/arm/configs/at91cap9adk_defconfig |1 -
ar
arch/x86/kernel/ds.c:226:9: warning: Using plain integer as NULL pointer
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/ds.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/ds.c b/arch/x86/kernel/ds.c
index 1c5ca4d..dcd918c
arch/x86/kernel/scx200_32.c:68:72: warning: Using plain integer as NULL pointer
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/scx200_32.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/scx200_32.c b/arch/x86/kernel/scx20
are new x:
mm/slub.c:3513:9: warning: symbol 'x' shadows an earlier one
mm/slub.c:3492:6: originally declared here
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
mm/slub.c | 15 ++-
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/mm/slub.c b/mm/
d here
No need to declare new x:
mm/slub.c:3513:9: warning: symbol 'x' shadows an earlier one
mm/slub.c:3492:6: originally declared here
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
mm/slub.c | 39 ++-
1 files changed, 18 insertions
On Thu, 2008-01-31 at 11:11 +0100, Ingo Molnar wrote:
> * Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > > during the big first phase of unification we generally kept file
> > > names untouched if they were only present in one of the previous
> > > arch
tural list of what is 32 bit-only and what
is 64 bit-only, and additional suffixes wouldn't add much to that.
Just another voice,
Harvey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
*
arch/x86/kernel/cpu/intel_cacheinfo.c:367:48: warning: incorrect type in
argument 5 (different signedness)
arch/x86/kernel/cpu/intel_cacheinfo.c:367:48:expected unsigned int *edx
arch/x86/kernel/cpu/intel_cacheinfo.c:367:48:got int *
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]&g
the time to unify them.
> Each of the remaining Makefile should be unifyable in less
> than 10 steps each. It is just work that are waitng to be done.
The continued unification will probably make this obvious over time
anyway.
Cheers,
Harvey
--
To unsubscribe from this list: sen
The following are entries in feature-removal-schedule.txt that have
come due. Please change the subject when replying to specific items.
Where I've gotten responses from the named person in the file, I've
included their comment.
---
What: MXSER
When: December 2007
Wh
; this is an ongoing work; symbols get marked unused and then garbage collected
> when they're due; for example akpm has several of that kind in his pile right
> now
How do they get marked? As this is an ongoing effort, should this be
moved to the top of the file, and the actual symb
Let this appear as deprecated in 2.6.25, remove after three
releases (2.6.28).
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Something like this should be included if you are deprecating
userspace functionality. I tried to come up with a useful
reason from your changelogs, b
( becomes )
include/asm/string_32.h:223:30: warning: cast truncates bits from constant
value ( becomes cc)
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, this shows up over and over again during the build, this
doesn't change anything as they are known c
On Thu, 2008-01-31 at 22:33 -0800, Arjan van de Ven wrote:
> Harvey Harrison wrote:
> > Something like the following (grep found me two example symbols)
>
> to be honest, nobody reads this file with such detail; the actual UNUSED
> marking
> is a lot more louder and peop
/pageattr.c:99:38:got unsigned int *
arch/x86/mm/pageattr.c:215:33: warning: incorrect type in argument 2 (different
signedness)
arch/x86/mm/pageattr.c:215:33:expected int *level
arch/x86/mm/pageattr.c:215:33:got unsigned int *
Signed-off-by: Harvey Harrison <[EMAIL PROTEC
Not necessary to expose it, also fixes sparse warning.
arch/x86/kernel/early_printk.c:196:16: warning: symbol 'early_console' was not
declared. Should it be static?
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/early_printk.c |2 +-
1 files chang
:362:30: warning: incorrect type in argument 3
(different signedness)
arch/x86/kernel/cpu/common.c:362:30:expected unsigned int *ebx
arch/x86/kernel/cpu/common.c:362:30:got int *
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/common.c
cyrix_arr_init was #if 0 all the way back to at least v2.6.12.
This was the only place where arr3_protected was set to anything
but zero. Eliminate this variable.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/mtrr/cyrix.c
On Fri, 2008-02-01 at 11:56 +0100, Ingo Molnar wrote:
> * Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > case 1:
> > - *(unsigned char *)s = pattern;
> > + *(unsigned char *)s = pattern & 0xff;
>
> i
Signedness mismatches in level argument.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, my other patch changing lookup_address was truncated and
missed the other call sites, here's the rest. You can either
fold this into that patch or apply separately.
arch/x86/kern
s plenty already, I can't be bothered to look"
Subject to someone _making_ it an issue, can't see it changing.
Harvey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, 2008-02-01 at 10:06 -0800, H. Peter Anvin wrote:
> Ingo Molnar wrote:
> > * Harvey Harrison <[EMAIL PROTECTED]> wrote:
> >
> >>case 1:
> >> - *(unsigned char *)s = pattern;
> >> + *(unsigned
eclared. Should it be static?
arch/x86/kernel/cpu/umc.c:22:12: warning: symbol 'umc_init_cpu' was not
declared. Should it be static?
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/common.c | 10 --
arch/x86/kernel/cpu/cpu.h|9
x.c:268:12: warning: symbol 'cyrix_init_mtrr' was
not declared. Should it be static?
arch/x86/kernel/cpu/mtrr/centaur.c:218:12: warning: symbol 'centaur_init_mtrr'
was not declared. Should it be static?
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kern
Global functions should include their prototypes.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/asm-x86/vm86.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/asm-x86/vm86.h b/include/asm-x86/vm86.h
index a5edf51..b72b9a6 100644
--- a/inclu
Fixes sparse warning:
arch/x86/kernel/cpu/intel.c:48:15: warning: symbol 'ppro_with_ram_bug' was not
declared. Should it be static?
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/intel.c |1 +
include/asm-x86/bugs.h |2 +-
2 files chang
arch/x86/kernel/process_32.c:254:43: warning: Using plain integer as NULL
pointer
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/process_32.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/process_32.c b/arch/x86/
A few snuck back in to x86.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/asm-x86/highmem.h |4 ++--
include/asm-x86/hw_irq_32.h |2 +-
include/asm-x86/system.h|4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/asm-x86/highm
On Sat, 2008-02-02 at 16:14 +0800, Li Zefan wrote:
> Harvey Harrison 写道:
> > Global functions should include their prototypes.
> >
> > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
> > ---
> > include/asm-x86/vm86.h |1 +
> >
> +extern void __pte_free_tlb(struct mmu_gather *tlb, struct page *pte);
> +extern void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd);
> +extern void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud);
Small question: the extern isn't necessary in headers, is it preferred
in
d
smp_thermal_interrupt(void)
./arch/x86/kernel/cpu/mcheck/p4.c:void smp_thermal_interrupt(struct pt_regs
*regs)
./arch/x86/kernel/entry_64.S: apicinterrupt
THERMAL_APIC_VECTOR,smp_thermal_interrupt
./arch/x86/kernel/traps_64.c:asmlinkage void __attribute__((weak))
smp_thermal_interrupt(void)
Notice the one
The pt_regs arg is never used, make it agree with the other
definitions of smp_thermal_interrupt.
It doesn't look like smp_thermal_interrupt is even called on
32-bit...
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Andrew, this is a fairly dumb patch, but works-for-me(tm)
The pt_regs arg is never used, make it agree with the other
definitions of smp_thermal_interrupt.
It doesn't look like smp_thermal_interrupt is even called on
32-bit...
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
How about I actually send the patch that worked this time?
uncovered a possible bug in the s390 version as that purely
copied the x86 version unconditionally passing 14 as the trapnr
rather than the error_code parameter. s390 is changed to pass
error_code in this patch.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Andrew, 1/2 is low risk, 2/2 ha
out before hitting kprobe_running().
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/linux/kprobes.h | 19 ---
1 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h
index e5ecb1e..e099426 100644
as NULL pointer
fs/jbd2/journal.c:2012:17: warning: Using plain integer as NULL pointer
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
fs/jbd/journal.c |4 ++--
fs/jbd/revoke.c |4 ++--
fs/jbd2/journal.c | 12 ++--
fs/jbd2/revoke.c |4 ++--
4 files chang
ned-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
kernel/cpuset.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index cfaf641..fdbac43 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -821,7 +821,7 @@ static int update_cpuma
Don't redeclare p, use a new variable q.
kernel/cpuset.c:824:23: warning: symbol 'p' shadows an earlier one
kernel/cpuset.c:746:21: originally declared here
kernel/cpuset.c:1272:52: warning: Using plain integer as NULL pointer
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]
Adjust the definition of lookup_address to take an unsigned long
level argument. Adjust callers in xen/mmu.c that pass in a
dummy variable.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, sorry for missing this hunk in my previous signedness fixes for
lookup_address.
arch/
2:24: warning: symbol 'emulate_ops' was not declared.
Should it be static?
Drop the return statements:
arch/x86/kvm/x86.c:2764:2: warning: returning void-valued expression
arch/x86/kvm/x86.c:2830:2: warning: returning void-valued expression
Signed-off-by: Harvey Harris
/quirks.c:393:3: warning: returning void-valued expression
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
The remaining checkpatch errors are false positives.
arch/x86/kernel/quirks.c | 26 +-
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/ar
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kvm/x86_emulate.c | 22 --
1 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index 7958600..649e14d 100644
--- a/arch/x86/kvm/x86_emu
register_address
register_address_increment
jmp_rel
Have a struct decode_cache parameter added instead of having 'c' in
the macro.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kvm/x86_emulate.c | 92 ++--
1 f
-bit signed bitfield
CHECK arch/x86/kernel/cpu/cpufreq/longhaul.c
include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield
CHECK arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield
Signed-off-by: Harvey Harrison
arch/x86/kernel/traps_32.c:1193:31: error: dubious one-bit signed bitfield
This was being used to ensure the proper alignment of the FXSAVE/FXRSTOR data.
This would create a sparse error in the _correct_ cases, hiding further
warnings. Use BUILD_BUG_ON instead.
Signed-off-by: Harvey Harrison
5: warning: symbol 'lo' shadows
an earlier one
arch/x86/kernel/cpu/cpufreq/powernow-k8.c:824:14: originally declared here
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/cpufreq/powernow-k8.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
di
y as people rebase their
trees the conflicts would hopefully get less painful.
But, let's see how things go.
Harvey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
All users are gone, remove definitions and comments referring
to them.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
drivers/char/drm/i830_dma.c |2 +-
include/asm-mn10300/highmem.h |4 ++--
include/asm-mn10300/linkage.h |2 --
include/linux/irq.h
An example function prototype and description of options that
modify how arguments are passed had references to fastcall.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Andrew, I don't have the knowledge to deal with the rcupdate.c
wrapper function, hopefully Paul will be abl
On Fri, 2008-02-08 at 10:37 -0600, James Bottomley wrote:
> On Fri, 2008-02-08 at 10:03 +0100, Geert Uytterhoeven wrote:
> > On Thu, 7 Feb 2008, James Bottomley wrote:
> > > On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote:
> > > > I'm going to gues
On Mon, 2008-02-11 at 22:53 +0200, Adrian Bunk wrote:
> On Mon, Feb 11, 2008 at 12:29:06PM -0800, Harvey Harrison wrote:
> > Option has been removed as of:
> > 185c045c245f46485ad8bbd8cc1100e986ff3f13 x86, core: remove
> > CONFIG_FORCED_INLINING
> >...
>
> I&#x
FASTCALL() is always expanded to empty, remove it.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Andrew, FASTCALL is never defined to anything but empty,
remove it.
include/linux/aio.h| 20 ++--
include/linux/buffer_head.h|6 +++---
include
Fixes sparse warning:
arch/x86/mach-default/setup.c:19:5: warning: symbol 'no_broadcast' was not
declared. Should it be static?
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/mach-default/setup.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff
arch/x86/kernel/i8253.c:98:27: warning: symbol 'pit_clockevent' was not
declared. Should it be static?
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/i8253.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/i8
On Wed, 2008-02-13 at 11:42 +0100, Ingo Molnar wrote:
> * Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > Fixes sparse warning:
> > arch/x86/mach-default/setup.c:19:5: warning: symbol 'no_broadcast' was not
> > declared. Should it be static?
>
>
0f 85 82 00 00 00 jne2ae
22c: 64 a1 00 00 00 00 mov%fs:0x0,%eax
Cheers,
Harvey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
:0x0,%eax
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/linux/mmzone.h |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 8d8d197..3109a65 100644
--- a/include/linux/mmzone.h
+++ b/include
t in linux/lguest.h
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Rusty, just a suggestion. If you'd like Ingo to take it in the x86
tree, please let him know.
arch/x86/lguest/boot.c | 10 +-
include/asm-x86/lguest.h | 11 +++
2 files changed, 12 inser
arch/x86/kernel/efi.c:57:12: warning: symbol 'efi_phys' was not declared.
Should it be static?
Yes, it should.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/efi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/
?
arch/x86/kernel/efi_32.c:84:6: warning: symbol 'efi_call_phys_epilog' was not
declared. Should it be static?
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/efi_32.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Documentation/feature-removal-schedule.txt | 10 --
Documentation/feature-removal/exported-symbols.txt | 34
arch/x86/kernel/io_delay.c |2 +-
net/ipv4/inet_hashta
On Wed, 2008-02-13 at 23:31 +0200, Adrian Bunk wrote:
> dump_pagetable() can now become static.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
I believe Andi Kleen wanted this kept global to make it easy to use when
adding debugging code elsewhere.
Cheers,
Harvey
--
T
On Thu, 2008-02-14 at 00:34 +0200, Adrian Bunk wrote:
> On Wed, Feb 13, 2008 at 02:22:06PM -0800, Harvey Harrison wrote:
> > +
> > +What: __inet_hash_connect
> > +Where: net/ipv4/inet_hashtables.c
> > +When: 2.6.28
>
approach taken from the
arm kprobes implementation.
kretprobe_trampoline_holder uses inline assemly to define the global
symbol kretprobe_trampoline, but nothing ever calls the holder explicitly.
trampoline handler is only called from inline assembly in the same file,
mark it used and static.
S
as NULL pointer
fs/jbd2/journal.c:2012:17: warning: Using plain integer as NULL pointer
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Originally sent Feb 02, 2008
fs/jbd/journal.c |4 ++--
fs/jbd/revoke.c |4 ++--
fs/jbd2/journal.c | 12 ++--
fs/jbd2/revoke.c
signedness)
fs/dlm/config.c:149:1:expected unsigned int *info_field
fs/dlm/config.c:149:1:got int extern [toplevel] *
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
fs/dlm/config.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/dlm/config.c b/fs/dlm/co
On Wed, 2008-02-13 at 16:50 -0800, Andrew Morton wrote:
> On Wed, 13 Feb 2008 16:33:37 -0800
> Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > Subject: [PATCH-resend] jbd/jbd2: sparse warnings in revoke.c, journal.c
>
> ext3/jbd and ext4/jbd2 patches usually find th
static?
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
fs/debugfs/inode.c |4
include/linux/debugfs.h |5 +
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index d26e282..e9602d8 100644
--- a/fs/debugf
inotify_max_user_instances, inotify_max_user_watches, inotify_max_queued_events
can all be made static.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
fs/inotify_user.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/inotify_user.c b/fs/inotify_
fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
fs/adfs/dir_f.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
index b9b2b27..ea7df21 100644
On Wed, 2008-02-13 at 19:39 -0800, Andrew Morton wrote:
> On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound
> > statement
> >
> > Signed-off-b
drivers/ata/sata_promise.c:546:15: warning: symbol 'len' shadows an earlier one
drivers/ata/sata_promise.c:538:6: originally declared here
len is set again immediately after the loop, so this is safe.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
drivers/ata/sata_promis
drivers/ata/ata_piix.c:1655:8: warning: symbol 'rc' shadows an earlier one
drivers/ata/ata_piix.c:1616:6: originally declared here
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
drivers/ata/ata_piix.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --g
drivers/ata/sata_via.c:336:2: warning: returning void-valued expression
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
drivers/ata/sata_via.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
index 30caa03..0
lier one
drivers/ata/sata_mv.c:1501:22: originally declared here
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
drivers/ata/sata_mv.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 04b5717..2ecd44d 100644
--- a/d
Avoid a metric ton of sparse warnings like:
drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one
drivers/ata/pata_ali.c:176:14: originally declared here
Due to nesting min_t macro inside max_t macro which both use a __x
identifier internally.
Signed-off-by: Harve
/pata_amd.c:509:3: warning: Initializer entry defined twice
drivers/ata/pata_amd.c:521:3: also defined here
drivers/ata/pata_amd.c:544:3: warning: Initializer entry defined twice
drivers/ata/pata_amd.c:556:3: also defined here
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
drive
Everybody passes in a u32...why fight it.
drivers/ata/pata_cs5536.c:124:26: warning: incorrect type in argument 3
(different signedness)
drivers/ata/pata_cs5536.c:124:26:expected int *val
drivers/ata/pata_cs5536.c:124:26:got unsigned int *
Signed-off-by: Harvey Harrison <[EM
drivers/ata/pata_jmicron.c:118:2: warning: returning void-valued expression
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
drivers/ata/pata_jmicron.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/pata_jmicron.c b/drivers/ata/pata_jmicron.c
drivers/ata/pata_marvell.c:88:2: warning: returning void-valued expression
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
drivers/ata/pata_marvell.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c
drivers/ata/pata_acpi.c:80:2: warning: returning void-valued expression
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
drivers/ata/pata_acpi.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
index 2
dows an earlier one
drivers/ata/pata_legacy.c:128:12: originally declared here
drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an earlier
one
drivers/ata/pata_legacy.c:129:12: originally declared here
Signed-off-by: Harvey Harrison &l
c:882:21: warning: symbol 'qdi' shadows an earlier one
drivers/ata/pata_legacy.c:128:12: originally declared here
drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an earlier
one
drivers/ata/pata_legacy.c:129:12: originally declared here
Signed-off-by: Harvey Harr
On Thu, 2008-02-14 at 12:01 +, Alan Cox wrote:
> On Wed, 13 Feb 2008 21:14:18 -0800
> Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > Avoid a metric ton of sparse warnings like:
> > drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier
On Thu, 2008-02-14 at 10:08 -0500, Masami Hiramatsu wrote:
> Harvey Harrison :
> > arch/x86/kernel/kprobes.c:584:16: warning: symbol
> > 'kretprobe_trampoline_holder' was not declared. Should it be static?
> > arch/x86/kernel/kprobes.c:676:6: warning: symbol &#
in_t macro inside max_t macro which both use a __x
identifier internally.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Alan, is this more to your liking?
include/linux/libata.h |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/include/linux/libata.h
fastcall is gone from the tree, no need to adjust the function
prototypes anymore for this.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
scripts/kernel-doc |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/scripts/kernel-doc b/scripts/kernel-doc
index 6
fastcall no longer exists in tree, remove it from checkpatch.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
scripts/checkpatch.pl |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2086a85..6f9b391 100755
-bit signed bitfield
drivers/mtd/ubi/ubi.h:222:18: error: dubious one-bit signed bitfield
drivers/mtd/ubi/ubi.h:223:16: error: dubious one-bit signed bitfield
drivers/mtd/ubi/ubi.h:224:20: error: dubious one-bit signed bitfield
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Sorry, no
: warning: incorrect type in assignment (different
signedness)
kernel/sched.c:3921:16:expected long *switch_count
kernel/sched.c:3921:16:got unsigned long *
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
kernel/sched.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
kernel/sched.c:3680:3: warning: returning void-valued expression
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
kernel/sched.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index f28f19e..824d5a9 100644
--- a/kernel/s
Avoids sparse warnings:
kernel/sched.c:2170:17: warning: symbol 'schedule_tail' was not declared.
Should it be static?
Avoids the need for an external declaration in arch/um/process.c
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/um/kernel/process.c |2 -
coda_unlink, coda_rmdir, coda_readdir can all be static, the forward
declarations already were.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
fs/coda/dir.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/coda/dir.c b/fs/coda/dir.c
index f89ff08..3
1 - 100 of 874 matches
Mail list logo
