[RFC PATCH 1/2] net: macb: Correct CAPS mask

2016-08-01 Thread Harini Katakam
USRIO and JUMBO CAPS have the same mask. Fix the same. Signed-off-by: Harini Katakam --- drivers/net/ethernet/cadence/macb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h index 36893d8..b6fcf10

[RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-08-01 Thread Harini Katakam
H for MSB of BD pointers. -> Change extraction and updation of buffer addresses to use 64 bit address. -> In gem_rx extract address in one place insted of two and use a separate flag for RXUSED. Signed-off-by: Harini Katakam --- drivers/net/ethernet/c

Re: [RFC PATCH 1/2] macb: Add 1588 support in Cadence GEM.

2016-09-07 Thread Harini Katakam
Hi, On Tue, Sep 6, 2016 at 9:18 PM, Richard Cochran wrote: > >> +#define GEM_TISUBN 0x01bc /* 1588 Timer Increment Sub-ns */ > > This regsiter does not exist. Looking at > >Zynq-7000 AP SoC Technical Reference Manual >UG585 (v1.10) February 23, 2015 > > starting on page 1273 w

Re: [RFC PATCH 1/2] net: macb: Correct CAPS mask

2016-08-04 Thread Harini Katakam
On Thu, Aug 4, 2016 at 7:37 PM, Nicolas Ferre wrote: > Le 01/08/2016 à 09:20, Harini Katakam a écrit : >> USRIO and JUMBO CAPS have the same mask. >> Fix the same. >> >> Signed-off-by: Harini Katakam > > Hi, > Indeed there's a bug... > > >

[PATCH] net: macb: Correct CAPS mask

2016-08-04 Thread Harini Katakam
USRIO and JUMBO CAPS have the same mask. Fix the same. Fixes: ce721a702197 ("net: ethernet: cadence-macb: Add disabled usrio caps") Cc: sta...@vger.kernel.org # v4.5+ Signed-off-by: Harini Katakam Acked-by: Nicolas Ferre --- drivers/net/ethernet/cadence/macb.h | 2 +- 1 file

[PATCH v2] net: macb: Handle HRESP error

2018-01-26 Thread Harini Katakam
From: Harini Katakam Handle HRESP error by doing a SW reset of RX and TX and re-initializing the descriptors, RX and TX queue pointers. Signed-off-by: Harini Katakam Signed-off-by: Michal Simek --- v2: Rebased on top of latest net-next and reinitialized all rx queues. drivers/net/ethernet

Re: [PATCH v2] net: macb: Handle HRESP error

2018-01-26 Thread Harini Katakam
Hi David, On Fri, Jan 26, 2018 at 9:25 PM, David Miller wrote: > From: Harini Katakam > Date: Fri, 26 Jan 2018 16:12:11 +0530 > >> From: Harini Katakam >> >> Handle HRESP error by doing a SW reset of RX and TX and >> re-initializing the descriptors, RX and TX

Re: [PATCH v3] net: macb: Handle HRESP error

2018-01-26 Thread Harini Katakam
Hi David, On Sat, Jan 27, 2018 at 12:09 PM, wrote: > From: Harini Katakam > > Handle HRESP error by doing a SW reset of RX and TX and > re-initializing the descriptors, RX and TX queue pointers. > > Signed-off-by: Harini Katakam > Signed-off-by: Michal Simek >

[RFC PATCH] net: macb: Apply RXUBR workaround only to versions with errata

2018-11-23 Thread Harini Katakam
to enable this workaround. Signed-off-by: Harini Katakam --- Note: Enabled the errata in zynq and at91 configs only. Please advise if any other versions are affected by this errata. drivers/net/ethernet/cadence/macb.h | 6 ++ drivers/net/ethernet/cadence/macb_main.c | 9 +++-- 2

[PATCH v2 4/4] net: macb: Add support for suspend/resume with full power down

2018-11-25 Thread Harini Katakam
: Kedareswara rao Appana Signed-off-by: Harini Katakam --- v2 changes: Fixed parameter passed to phy calls. drivers/net/ethernet/cadence/macb_main.c | 38 ++-- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b

[PATCH v4 0/2] Cadence I2C driver fixes

2014-12-10 Thread Harini Katakam
cause if we proceed, completion interrupt is never obtained and a SW timeout will occur. Harini Katakam (2): i2c: cadence: Handle > 252 byte transfers i2c: cadence: Check for errata condition involving master receive drivers/i2c/busses/i2c-cadence.c | 187 +++---

[PATCH v4 2/2] i2c: cadence: Check for errata condition involving master receive

2014-12-10 Thread Harini Katakam
messages to be transferred with repeated start includes any transfer following a read transfer, completion is never indicated and timeout occurs. Hence a check is implemented to return -EOPNOTSUPP for such sequences. Signed-off-by: Harini Katakam Signed-off-by: Vishnu Motghare --- v4: Use single

[PATCH v4 1/2] i2c: cadence: Handle > 252 byte transfers

2014-12-10 Thread Harini Katakam
is cleared at the beginning of the isr instead of the end, to avoid missing any interrupts. Signed-off-by: Harini Katakam --- v4: No changes v3: Add comments v2: No changes --- drivers/i2c/busses/i2c-cadence.c | 173 ++ 1 file changed, 100 insertions(+),

Re: [PATCH v4 2/2] i2c: cadence: Check for errata condition involving master receive

2014-12-10 Thread Harini Katakam
Hi Soren, On Wed, Dec 10, 2014 at 11:15 PM, Sören Brinkmann wrote: > On Wed, 2014-12-10 at 05:14PM +0530, Harini Katakam wrote: >> Cadence I2C controller has the following bugs: >> - completion indication is not given to the driver at the end of >> a read/receive trans

Re: [PATCH v2 3/3] i2c: cadence: Check for errata condition involving master receive

2014-12-04 Thread Harini Katakam
Hi, On Fri, Dec 5, 2014 at 12:04 AM, Wolfram Sang wrote: > >> + /* >> + * This controller does not give completion interrupt after a >> + * master receive transfer if HOLD bit is set (repeated start), >> + * resulting in SW timeout. Hence, if a r

Re: [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers

2014-12-04 Thread Harini Katakam
Hi, On Fri, Dec 5, 2014 at 12:02 AM, Wolfram Sang wrote: > >> + /* >> + * If the device is sending data If there is further >> + * data to be sent. Calculate the available space >> + * in FIFO and fill the FIFO with that many bytes. >> +

Re: [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers

2014-12-04 Thread Harini Katakam
Hi, On Fri, Dec 5, 2014 at 11:11 AM, rajeev kumar wrote: > On Wed, Dec 3, 2014 at 6:05 PM, Harini Katakam wrote: >> The I2C controller sends a NACK to the slave when transfer size register >> reaches zero, irrespective of the hold bit. So, in order to handle transfers >> g

[PATCH v3 0/2] Cadence I2C driver fixes

2014-12-05 Thread Harini Katakam
cause if we proceed, completion interrupt is never obtained and a SW timeout will occur. Harini Katakam (2): i2c: cadence: Handle > 252 byte transfers i2c: cadence: Check for errata condition involving master receive drivers/i2c/busses/i2c-cadence.c | 188 +++---

[PATCH v3 2/2] i2c: cadence: Check for errata condition involving master receive

2014-12-05 Thread Harini Katakam
messages to be transferred with repeated start includes any transfer following a read transfer, completion is never indicated and timeout occurs. Hence a check is implemented to return -EOPNOTSUPP for such sequences. Signed-off-by: Harini Katakam Signed-off-by: Vishnu Motghare --- v3: Add

[PATCH v3 1/2] i2c: cadence: Handle > 252 byte transfers

2014-12-05 Thread Harini Katakam
is cleared at the beginning of the isr instead of the end, to avoid missing any interrupts. Signed-off-by: Harini Katakam --- v3: Add comments v2: No changes --- drivers/i2c/busses/i2c-cadence.c | 173 ++ 1 file changed, 100 insertions(+), 73 deletions(-) d

Re: [PATCH v5 2/2] i2c: cadence: Check for errata condition involving master receive

2015-01-13 Thread Harini Katakam
Hi, On Tue, Jan 13, 2015 at 5:05 PM, Wolfram Sang wrote: >> @@ -541,6 +541,18 @@ static int cdns_i2c_master_xfer(struct i2c_adapter >> *adap, struct i2c_msg *msgs, >>* processed with a repeated start. >>*/ >> if (num > 1) { >> + /* >> + * This contr

Re: [PATCH v5 1/2] i2c: cadence: Handle > 252 byte transfers

2015-01-13 Thread Harini Katakam
Hi, On Tue, Jan 13, 2015 at 4:58 PM, Wolfram Sang wrote: > On Fri, Dec 12, 2014 at 09:48:26AM +0530, Harini Katakam wrote: >> The I2C controller sends a NACK to the slave when transfer size register >> reaches zero, irrespective of the hold bit. So, in order to handle transfers

[PATCH v6] i2c: cadence: Check for errata condition involving master receive

2015-01-13 Thread Harini Katakam
messages to be transferred with repeated start includes any message following a read message, completion is never indicated and timeout occurs. Hence a check is implemented to return -EOPNOTSUPP for such sequences. Signed-off-by: Harini Katakam Signed-off-by: Vishnu Motghare --- v6: - Correct if

Re: [PATCH v5 0/2] Cadence I2C driver fixes

2015-01-12 Thread Harini Katakam
Hi, Any further comments on this? Regards, Harini On Fri, Dec 12, 2014 at 9:48 AM, Harini Katakam wrote: > This series implements workarounds for some bugs in Cadence I2C controller. > > - The I2C controller when configured in Master Mode generates invalid read > transactions. >

Re: [PATCH] i2c: cadence: Handling Slave monitor mode

2015-04-02 Thread Harini Katakam
slave device responds with an ACK. >> >> Added this feature for zero length transfers enable the controller >> for slave monitor interrupt and get the status. Disable the slave >> monitor mode feature upon successful handling. >> >> Signed-off-by: Nava kishore M

Re: [RFC PATCH 2/2] spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller

2015-05-29 Thread Harini Katakam
Hi Mark, On Thu, May 28, 2015 at 9:11 PM, Punnaiah Choudary Kalluri wrote: > Hi Mark, > >> -Original Message- >> From: Mark Brown [mailto:broo...@kernel.org] >> Sent: Thursday, May 28, 2015 8:34 PM >> To: Harini Katakam >> Cc: Ranjit Abhimanyu Wag

Re: Request for suggestion on net device re-naming/re-ordering based on DT alias

2019-02-27 Thread Harini Katakam
On Thu, Feb 28, 2019 at 12:10 AM Stephen Hemminger wrote: > > On Wed, 27 Feb 2019 17:24:03 +0530 > Harini Katakam wrote: > > > Device naming is a hard problem, and there is no perfect solution. > > Device tree should be providing hints to userspace policy for naming,

Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read

2019-02-27 Thread Harini Katakam
Hi, On Wed, Feb 27, 2019 at 2:35 PM Harini Katakam wrote: > > Hi Andrew, Paul, > > On Wed, Feb 27, 2019 at 2:15 PM Michal Simek wrote: > > > > On 21. 02. 19 12:03, Michal Simek wrote: > > > On 21. 02. 19 11:24, Paul Kocialkowski wrote: > > >> Hi, &g

[PATCH v3 4/4] net: macb: Add support for suspend/resume with full power down

2019-03-01 Thread Harini Katakam
: Kedareswara rao Appana Signed-off-by: Harini Katakam --- v3: Fix >80 char lines v2 changes: Fixed parameter passed to phy calls. drivers/net/ethernet/cadence/macb_main.c | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/net/ether

[PATCH v3 2/4] net: macb: Support clock management for tsu_clk

2019-03-01 Thread Harini Katakam
TSU clock needs to be enabled/disabled as per support in devicetree and it should also be controlled during suspend/resume (WOL has no dependency on this clock). Signed-off-by: Harini Katakam --- v3 and v2: No changes drivers/net/ethernet/cadence/macb.h | 3 ++- drivers/net/ethernet

[PATCH v3 1/4] net: macb: Check MDIO state before read/write and use timeouts

2019-03-01 Thread Harini Katakam
Replace the while loop in MDIO read/write functions with a timeout. In addition, add a check for MDIO bus busy before initiating a new operation as well to make sure there is no ongoing MDIO operation. Signed-off-by: Shubhrajyoti Datta Signed-off-by: Sai Pavan Boddu Signed-off-by: Harini

[PATCH v2 0/4] Macb power management support for ZynqMP

2019-03-01 Thread Harini Katakam
This series adds support for macb suspend/resume with system power down. In relation to the above, this series also updates mdio_read/write function for PM and adds tsu clock management. Harini Katakam (4): net: macb: Check MDIO state before read/write and use timeouts net: macb: Support

[PATCH v3 3/4] net: macb: Add pm runtime support

2019-03-01 Thread Harini Katakam
Add runtime pm functions and move clock handling there. Add runtime PM calls to mdio functions to allow for active mdio bus. Signed-off-by: Shubhrajyoti Datta Signed-off-by: Harini Katakam --- v3 changes: Fix exit path using goto v2 changes: Allow for mdio bus to be active Changes from RFC

Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read

2019-02-27 Thread Harini Katakam
Hi Andrew, Paul, On Wed, Feb 27, 2019 at 2:15 PM Michal Simek wrote: > > On 21. 02. 19 12:03, Michal Simek wrote: > > On 21. 02. 19 11:24, Paul Kocialkowski wrote: > >> Hi, > >> > >> On Wed, 2019-02-20 at 07:58 +0100, Michal Simek wrote: > >>> Hi, > >>> > >>> On 19. 02. 19 18:25, Andrew Lunn wrot

Request for suggestion on net device re-naming/re-ordering based on DT alias

2019-02-27 Thread Harini Katakam
Hi, We've had some users requesting control over net device name order when multiple ethernet devices are present on a system. I've tried a few solutions to this and looked it up on forums. But I apologize if I have missed something. I know that the current system allocates eth as per probe order

[PATCH] SPI: Add driver for Cadence SPI controller

2014-03-17 Thread Harini Katakam
Add driver for Cadence SPI controller. This is used in Xilinx Zynq. Signed-off-by: Harini Katakam --- .../devicetree/bindings/spi/spi-cadence.txt| 25 + drivers/spi/Kconfig|7 + drivers/spi/Makefile |1 + drivers

RE: [PATCH] SPI: Add driver for Cadence SPI controller

2014-03-17 Thread Harini Katakam
Hi Rob/Mark, > -Original Message- > From: Michal Simek [mailto:mon...@monstr.eu] > Sent: Monday, March 17, 2014 6:53 PM > To: Rob Herring > Cc: Harini Katakam; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; > Kumar Gala; Rob Landley; Mark Brown; Grant

RE: [PATCH] SPI: Add driver for Cadence SPI controller

2014-03-17 Thread Harini Katakam
Hi Rob, > -Original Message- > From: Rob Herring [mailto:robherri...@gmail.com] > Sent: Monday, March 17, 2014 6:17 PM > To: Harini Katakam > Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Rob > Landley; Mark Brown; Grant Likely; devicet...@vger

RE: [PATCH] SPI: Add driver for Cadence SPI controller

2014-03-17 Thread Harini Katakam
Hi Mark, > -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Monday, March 17, 2014 11:00 PM > To: Harini Katakam > Cc: robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com; > ijc+devicet...@hellion.org.uk; ga...@codeaurora.org

RE: [PATCH] SPI: Add driver for Cadence SPI controller

2014-03-17 Thread Harini Katakam
Hi Mark, > -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Monday, March 17, 2014 11:45 PM > To: Josh Cartwright > Cc: Harini Katakam; robh...@kernel.org; pawel.m...@arm.com; > mark.rutl...@arm.com; ijc+devicet...@hellion.org.uk; > ga

RE: [PATCH] SPI: Add driver for Cadence SPI controller

2014-03-18 Thread Harini Katakam
Hi Mark, > -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Tuesday, March 18, 2014 4:34 PM > To: Harini Katakam > Cc: robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com; > ijc+devicet...@hellion.org.uk; ga...@codeaurora.org

RE: [PATCH] SPI: Add driver for Cadence SPI controller

2014-03-18 Thread Harini Katakam
HI Mark, > -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Tuesday, March 18, 2014 6:04 PM > To: Harini Katakam > Cc: robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com; > ijc+devicet...@hellion.org.uk; ga...@codeaurora.org

[PATCH v2 1/2] SPI: Add driver for Cadence SPI controller

2014-04-03 Thread Harini Katakam
Add driver for Cadence SPI controller. This is used in Xilinx Zynq. Signed-off-by: Harini Katakam --- v2 changes: - Use xilinx compatible string too. - Changes read register and write register functions to static inline. - Removed unecessary dev_info and dev_dbg prints. - Return IRQ_HANDLED

[PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-03 Thread Harini Katakam
Add spi-cadence bindings documentation. Signed-off-by: Harini Katakam --- v2 changes: - Separate patch for bindings. - Add xilinx compatible string; Make compatible string first in the node. - Use property name num-cs. Make this property optional. --- .../devicetree/bindings/spi/spi

Re: [PATCH 1/2] devicetree: Add devicetree bindings documentation for Zynq Quad SPI

2014-04-03 Thread Harini Katakam
Hi Soren On Thu, Apr 3, 2014 at 11:20 PM, Sören Brinkmann wrote: > Hi Punnaiah, > > On Thu, 2014-04-03 at 10:33PM +0530, Punnaiah Choudary Kalluri wrote: >> Add bindings documentation for Zynq Quad SPI driver. >> >> Signed-off-by: Punnaiah Choudary Kalluri >> --- >> .../devicetree/bindings/spi/

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-03 Thread Harini Katakam
Hi Mark, On Fri, Apr 4, 2014 at 3:04 AM, Mark Brown wrote: > On Thu, Apr 03, 2014 at 04:40:31PM +0530, Harini Katakam wrote: > >> +Optional properties: >> +- num-cs : Number of chip selects used. > > How does this translate to the hardware? This IP can drive

Re: [PATCH 1/2] devicetree: Add devicetree bindings documentation for Zynq Quad SPI

2014-04-03 Thread Harini Katakam
Hi Mark, On Fri, Apr 4, 2014 at 2:31 AM, Mark Brown wrote: > On Thu, Apr 03, 2014 at 10:33:06PM +0530, Punnaiah Choudary Kalluri wrote: > >> +Optional properties: >> +- num-cs : Number of chip selects used. > > What does this translate into? > >> + num-cs = /bits/ 16 <1>;

Re: [PATCH 2/2] SPI: Add support for Zynq Quad SPI controller

2014-04-03 Thread Harini Katakam
Hi Mark, On Fri, Apr 4, 2014 at 2:59 AM, Mark Brown wrote: > On Thu, Apr 03, 2014 at 10:33:07PM +0530, Punnaiah Choudary Kalluri wrote: > > Overall this looks fairly good, there are a few issues that need to be > looked at but they're not too invasive. Please also check for coding > style issues

Re: [PATCH v2 1/2] SPI: Add driver for Cadence SPI controller

2014-04-03 Thread Harini Katakam
Hi Mark On Fri, Apr 4, 2014 at 3:13 AM, Mark Brown wrote: > On Thu, Apr 03, 2014 at 04:40:30PM +0530, Harini Katakam wrote: >> Add driver for Cadence SPI controller. This is used in Xilinx Zynq. > > I just reviewed a driver for "Zynq Quad SPI controller" from Punnaiah

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi Mark, On Fri, Apr 4, 2014 at 3:39 PM, Mark Brown wrote: > On Fri, Apr 04, 2014 at 08:30:38AM +0530, Harini Katakam wrote: >> On Fri, Apr 4, 2014 at 3:04 AM, Mark Brown wrote: >> > On Thu, Apr 03, 2014 at 04:40:31PM +0530, Harini Katakam wrote: > >> >> +Opt

Re: [PATCH 2/2] SPI: Add support for Zynq Quad SPI controller

2014-04-04 Thread Harini Katakam
Hi Mark, On Fri, Apr 4, 2014 at 4:38 PM, Mark Brown wrote: > On Fri, Apr 04, 2014 at 08:59:47AM +0530, Harini Katakam wrote: >> On Fri, Apr 4, 2014 at 2:59 AM, Mark Brown wrote: > >> > Why would a transfer be being set up without a transfer being provided? > >>

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi, On Fri, Apr 4, 2014 at 5:54 PM, Peter Crosthwaite wrote: > On Fri, Apr 4, 2014 at 10:14 PM, Harini Katakam > wrote: >> Hi Mark, >> >> On Fri, Apr 4, 2014 at 3:39 PM, Mark Brown wrote: >>> On Fri, Apr 04, 2014 at 08:30:38AM +0530, Harini Katakam wrote: &g

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi Mark, On Fri, Apr 4, 2014 at 6:16 PM, Mark Brown wrote: > On Fri, Apr 04, 2014 at 05:44:23PM +0530, Harini Katakam wrote: >> On Fri, Apr 4, 2014 at 3:39 PM, Mark Brown wrote: >> > On Fri, Apr 04, 2014 at 08:30:38AM +0530, Harini Katakam wrote: > >> >> This IP

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi, On Fri, Apr 4, 2014 at 7:38 PM, Harini Katakam wrote: > Hi Mark, > > On Fri, Apr 4, 2014 at 6:16 PM, Mark Brown wrote: >> On Fri, Apr 04, 2014 at 05:44:23PM +0530, Harini Katakam wrote: >>> On Fri, Apr 4, 2014 at 3:39 PM, Mark Brown wrote: >>> > On F

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi Mark, On Fri, Apr 4, 2014 at 8:12 PM, Mark Brown wrote: > On Fri, Apr 04, 2014 at 07:38:14PM +0530, Harini Katakam wrote: > >> OK. I understand. >> Can you comment on the case where a decoder is used? > >> There is support for adding a decoder where extended slaves

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi Peter, On Sat, Apr 5, 2014 at 4:44 AM, Peter Crosthwaite wrote: > On Sat, Apr 5, 2014 at 12:30 AM, Harini Katakam > wrote: >> Hi, >> >> On Fri, Apr 4, 2014 at 7:38 PM, Harini Katakam >> wrote: >>> Hi Mark, >>> >>> On Fri, Apr 4, 2014

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-07 Thread Harini Katakam
Hi Peter, On Sun, Apr 6, 2014 at 5:13 AM, Peter Crosthwaite wrote: > On Sat, Apr 5, 2014 at 4:05 PM, Harini Katakam > wrote: >> Hi Peter, >> >> On Sat, Apr 5, 2014 at 4:44 AM, Peter Crosthwaite >> wrote: >>> On Sat, Apr 5, 2014 at 12:30 AM, Harini Kataka

[PATCH v4 2/2] devicetree: Add Cadence WDT devicetree bindings documentation

2014-07-30 Thread Harini Katakam
Add cadence-wdt bindings documentation. Signed-off-by: Harini Katakam --- v4 changes: - Change name of property "reset" to "reset-on-timeout". - Use cdns compatible string in example. - Improve description of clocks and interrupts. v3 changes: - Change reset prope

[PATCH v4 1/2] watchdog: Add Cadence WDT driver

2014-07-30 Thread Harini Katakam
Add Cadence WDT driver. This is used by Xilinx Zynq. Signed-off-by: Harini Katakam --- v4 changes: - Change name of property "reset" to "reset-on-timeout". v3 changes: - Make rst a boolean and use of_property_read_boolean. - Use only cdns compatible string. If customizatio

[PATCH v3 1/2] SPI: Add driver for Cadence SPI controller

2014-04-10 Thread Harini Katakam
Add driver for Cadence SPI controller. This is used in Xilinx Zynq. Signed-off-by: Harini Katakam --- Here is the v3 series but I have one concern. The recent change in spi-core to use wait_for_completion_timeout uses a timeout value calculated as follows: ms = xfer->len * 8 * 1000/x

[PATCH v3 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-10 Thread Harini Katakam
Add spi-cadence bindings documentation. Signed-off-by: Harini Katakam --- v3 changes: - Remove /bits/ 16 from num-cs property in example. - Add is-decoded-cs optional property and add to description of num-cs. v2 changes: - Separate patch for bindings. - Add xilinx compatible string; Make

Re: [PATCH v3 1/2] SPI: Add driver for Cadence SPI controller

2014-04-10 Thread Harini Katakam
Hi Mark, On Thu, Apr 10, 2014 at 5:51 PM, Mark Brown wrote: > On Thu, Apr 10, 2014 at 05:43:49PM +0530, Harini Katakam wrote: > >> Firstly, the timeout value obtained from this is a too low. >> This timeout is typically used for an error conditions such as >> hardware han

[PATCH] spi: core: Increase timeout value

2014-04-10 Thread Harini Katakam
the core accordingly. Signed-off-by: Harini Katakam --- drivers/spi/spi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 4eb9bf0..3fdecfa 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -775,7 +775,7 @@ s

Re: [PATCH] spi: core: Increase timeout value

2014-04-10 Thread Harini Katakam
Hi Mark, On Thu, Apr 10, 2014 at 11:06 PM, Mark Brown wrote: > On Thu, Apr 10, 2014 at 06:20:29PM +0530, Harini Katakam wrote: > >> Considering acceptable latencies, this timeout can be set to a large >> value >= 1*HZ typically. > >> This patch adds a tole

Re: [PATCH v3 1/2] SPI: Add driver for Cadence SPI controller

2014-04-10 Thread Harini Katakam
Hi Mark, On Fri, Apr 11, 2014 at 4:18 AM, Mark Brown wrote: > On Thu, Apr 10, 2014 at 05:43:49PM +0530, Harini Katakam wrote: >> Add driver for Cadence SPI controller. This is used in Xilinx Zynq. > > This looks mostly good, the issues below are very small. > >> +s

[PATCH v2] spi: core: Increase timeout value

2014-04-10 Thread Harini Katakam
in the core. Signed-off-by: Harini Katakam --- v2 changes: Decrease timeout - make it double of expected time + 100ms --- drivers/spi/spi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 4eb9bf0..f01cbb4 100644 --- a/drivers/spi

[PATCH 1/2] GPIO: Add driver for Zynq GPIO controller

2014-03-27 Thread Harini Katakam
Add support for GPIO controller used by Xilinx Zynq Signed-off-by: Harini Katakam --- drivers/gpio/Kconfig |7 + drivers/gpio/Makefile|1 + drivers/gpio/gpio-zynq.c | 690 ++ 3 files changed, 698 insertions(+) create mode 100644

[PATCH 2/2] Devicetree: Add Zynq GPIO devicetree bindings documentation

2014-03-27 Thread Harini Katakam
Add gpio-zynq bindings documentation. Signed-off-by: Harini Katakam --- .../devicetree/bindings/gpio/gpio-zynq.txt | 24 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/gpio-zynq.txt diff --git a/Documentation

[PATCH v4 1/2] SPI: Add driver for Cadence SPI controller

2014-04-14 Thread Harini Katakam
Add driver for Cadence SPI controller. This is used in Xilinx Zynq. Signed-off-by: Harini Katakam --- v4 changes: - Use clk_disable_unprepare and clk_prepare_enable in suspend and resume respectively. v3 changes: - Remove setup function. Make clock CPOL/CPHA setup a separate funtion and

[PATCH v4 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-14 Thread Harini Katakam
Add spi-cadence bindings documentation. Signed-off-by: Harini Katakam --- v4 changes: No changes. v3 changes: - Remove /bits/ 16 from num-cs property in example. - Add is-decoded-cs optional property and add to description of num-cs. v2 changes: - Separate patch for bindings. - Add xilinx

Re: [PATCH v3 1/2] SPI: Add driver for Cadence SPI controller

2014-04-14 Thread Harini Katakam
Hi Mark, On Fri, Apr 11, 2014 at 9:06 AM, Harini Katakam wrote: > Hi Mark, > > On Fri, Apr 11, 2014 at 4:18 AM, Mark Brown wrote: >> On Thu, Apr 10, 2014 at 05:43:49PM +0530, Harini Katakam wrote: >>> Add driver for Cadence SPI controller. This is used in Xilinx Zynq.

Re: [PATCH V2] Add support for flag status register on Micron chips.

2014-04-14 Thread Harini Katakam
Hi, On Fri, Apr 11, 2014 at 8:33 PM, wrote: > From: Graham Moore > > Some new Micron flash chips require reading the flag > status register to determine when operations have completed. > > Furthermore, chips with multi-die stacks of the 65nm 256Mb QSPI also > require reading the status register

Re: [PATCH v4 1/2] SPI: Add driver for Cadence SPI controller

2014-04-14 Thread Harini Katakam
Hi Mark, On Tue, Apr 15, 2014 at 1:31 AM, Mark Brown wrote: > On Mon, Apr 14, 2014 at 02:36:53PM +0530, Harini Katakam wrote: >> Add driver for Cadence SPI controller. This is used in Xilinx Zynq. > > Applied both, thanks. Please use subject lines consistent with the > style

RE: linux-next: build failure after merge of the spi tree

2014-04-14 Thread Harini Katakam
Hi Stephen/Mark, > -Original Message- > From: Stephen Rothwell [mailto:s...@canb.auug.org.au] > Sent: Tuesday, April 15, 2014 7:47 AM > To: Mark Brown > Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Harini > Katakam > Subject: linux-next: build failu

[PATCH] spi: cadence: Add dependency on ARCH_ZYNQ

2014-04-14 Thread Harini Katakam
Add dependency on ARCH_ZYNQ in Kconfig. This is to fix the build error. Signed-off-by: Harini Katakam --- drivers/spi/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index b0f091b..0db219b 100644 --- a/drivers/spi/Kconfig +++ b/drivers

[PATCH v2] spi: cadence: Add dependency on ARCH_ARM

2014-04-15 Thread Harini Katakam
Add dependency on ARCH_ARM in Kconfig. This is to fix the build error related to _relaxed IO. Signed-off-by: Harini Katakam --- v2 changes: Dependency on ARCH_ARM instead of restricting to ARCH_ZYNQ. --- drivers/spi/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi

Re: [PATCH v2] spi: cadence: Add dependency on ARCH_ARM

2014-04-15 Thread Harini Katakam
Hi, On Tue, Apr 15, 2014 at 3:52 PM, Paul Bolle wrote: > On Tue, 2014-04-15 at 15:42 +0530, Harini Katakam wrote: >> Add dependency on ARCH_ARM in Kconfig. >> This is to fix the build error related to _relaxed IO. >> >> Signed-off-by: Harini Katakam >> --- &

[PATCH v2] spi: cadence: Add dependency on ARM

2014-04-15 Thread Harini Katakam
Add dependency on ARM in Kconfig. This is to fix the build error related to _relaxed IO. Remove dependency on SPI_MASTER because this is already defined under if SPI_MASTER in Kconfig. Signed-off-by: Harini Katakam --- v2 changes: Add dependency on ARM instead of ZYNQ. Remove SPI_MASTER

[PATCH v2 2/2] devicetree: Add Zynq GPIO devicetree bindings documentation

2014-06-18 Thread Harini Katakam
From: Harini Katakam Add gpio-zynq bindings documentation. Signed-off-by: Harini Katakam Signed-off-by: Soren Brinkmann --- v2 changes: Improve description. --- .../devicetree/bindings/gpio/gpio-zynq.txt | 24 1 file changed, 24 insertions(+) create mode

[PATCH v2 1/2] gpio: Add driver for Zynq GPIO controller

2014-06-18 Thread Harini Katakam
From: Harini Katakam Add support for GPIO controller used by Xilinx Zynq. Signed-off-by: Harini Katakam Signed-off-by: Soren Brinkmann --- v2 changes: - convert to pm_runtime_force_(suspend|resume) - add pm_runtime_set_active in probe() - also (un)prepare clocks when they are dis-/enabled

RE: [PATCH v2 05/11] ARM: dts: zynq: Add QSPI for Parallella

2014-07-25 Thread Harini Katakam
Hi, > -Original Message- > From: Michal Simek [mailto:michal.si...@xilinx.com] > Sent: Friday, July 25, 2014 3:08 PM > To: Andreas Färber; mon...@monstr.eu; Soren Brinkmann > Cc: Harini Katakam; Michal Simek; Andreas Olofsson; Matteo Vit; Sean > Rickerd; devicet...@vger

RE: [PATCH v2 05/11] ARM: dts: zynq: Add QSPI for Parallella

2014-07-25 Thread Harini Katakam
Hi, > -Original Message- > From: Harini Katakam > Sent: Friday, July 25, 2014 4:01 PM > To: 'Michal Simek'; Andreas Färber; mon...@monstr.eu; Soren Brinkmann > Cc: Michal Simek; Andreas Olofsson; Matteo Vit; Sean Rickerd; > devicet...@vger.kernel.org; linux-ar

RE: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller

2014-07-14 Thread Harini Katakam
Hi Mark, My mail seems to have missed the below reply. Anyway, please find my answer below: > -Original Message- > From: Punnaiah Choudary Kalluri > Sent: Monday, July 14, 2014 12:03 PM > To: Harini Katakam > Subject: FW: [RFC PATCH 1/2] spi: Add support for Zynq

Re: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller

2014-07-14 Thread Harini Katakam
Hi Mark, On Fri, Jul 11, 2014 at 7:08 PM, Mark Brown wrote: > On Thu, Jul 10, 2014 at 02:20:06PM +0530, Harini Katakam wrote: > >> This patch adds support for QSPI controller used by Zynq. > > The driver looks pretty clean but there are a couple of issues below, > including

[PATCH v3 1/2] watchdog: Add Cadence WDT driver

2014-07-14 Thread Harini Katakam
Add Cadence WDT driver. This is used by Xilinx Zynq. Signed-off-by: Harini Katakam --- v3 changes: - Make rst a boolean and use of_property_read_boolean. - Use only cdns compatible string. If customization is required in the future, xlnx compatible string can be added. v2 changes: - Update

[PATCH v3 2/2] devicetree: Add Cadence WDT devicetree bindings documentation

2014-07-14 Thread Harini Katakam
Add cadence-wdt bindings documentation. Signed-off-by: Harini Katakam --- v3 changes: - Change reset property type and improve description. - Improve description of clocks and interrupts. - Use watchdog@ in the example. - Use only cdns compatible string for now. v2: No changes

Re: [PATCH v3 2/2] devicetree: Add Cadence WDT devicetree bindings documentation

2014-07-14 Thread Harini Katakam
Hi Mark, On Mon, Jul 14, 2014 at 8:37 PM, Mark Rutland wrote: > On Mon, Jul 14, 2014 at 01:16:09PM +0100, Harini Katakam wrote: >> Add cadence-wdt bindings documentation. >> >> Signed-off-by: Harini Katakam >> --- >> >> v3 changes: >> - Chang

Re: [PATCH v3 2/2] devicetree: Add Cadence WDT devicetree bindings documentation

2014-07-15 Thread Harini Katakam
Hi Mark, On Tue, Jul 15, 2014 at 2:29 PM, Mark Rutland wrote: > On Tue, Jul 15, 2014 at 07:39:40AM +0100, Harini Katakam wrote: >> Hi Mark, >> >> On Mon, Jul 14, 2014 at 8:37 PM, Mark Rutland wrote: >> > On Mon, Jul 14, 2014 at 01:16:09PM +0100, Harini Kataka

[RFC PATCH 2/2] devicetree: Add devicetree bindings documentation for Zynq QSPI

2014-07-10 Thread Harini Katakam
Add bindings documentation for Zynq QSPI driver. Signed-off-by: Harini Katakam --- .../devicetree/bindings/spi/spi-zynq-qspi.txt | 28 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/spi-zynq-qspi.txt diff --git a

[RFC PATCH 1/2] spi: Add support for Zynq QSPI controller

2014-07-10 Thread Harini Katakam
This patch adds support for QSPI controller used by Zynq. Signed-off-by: Harini Katakam --- drivers/spi/Kconfig |6 + drivers/spi/Makefile|1 + drivers/spi/spi-zynq-qspi.c | 854 +++ 3 files changed, 861 insertions(+) create mode

[RFC PATCH 0/2] Zynq QSPI RFC

2014-07-10 Thread Harini Katakam
above. - Flash register read/writes, for example, lock/unlock, quad enable etc. are handled differently in dual stacked and parallel modes. I'm sorry for the long cover letter. Hope it helps. Harini Katakam (2): spi: Add support for Zynq QSPI controller devicetree: Add devicetree bin

Re: [PATCH v3 1/2] gpio: Add driver for Zynq GPIO controller

2014-07-10 Thread Harini Katakam
On Thu, Jul 10, 2014 at 2:42 PM, Linus Walleij wrote: > On Tue, Jul 8, 2014 at 1:02 PM, Harini Katakam wrote: > >> From: Harini Katakam >> >> Add support for GPIO controller used by Xilinx Zynq. >> >> Signed-off-by: Harini Katakam >> Signed-off-by:

Re: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller

2014-07-10 Thread Harini Katakam
Hi Geert, On Thu, Jul 10, 2014 at 2:48 PM, Geert Uytterhoeven wrote: > Hi Harini, > > On Thu, Jul 10, 2014 at 10:50 AM, Harini Katakam wrote: >> + master->flags = SPI_MASTER_QUAD_MODE; > > SPI_MASTER_QUAD_MODE is not one of the SPI_MASTER_* defines > in incl

Re: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller

2014-07-10 Thread Harini Katakam
Hi Geert, On Thu, Jul 10, 2014 at 3:12 PM, Geert Uytterhoeven wrote: > Hi Harini, > > On Thu, Jul 10, 2014 at 11:31 AM, Harini Katakam > wrote: >>>> + master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_RX_DUAL | >>>> SPI_RX_QUAD | >>>> +

Re: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller

2014-07-10 Thread Harini Katakam
Hi Geert, On Thu, Jul 10, 2014 at 4:55 PM, Geert Uytterhoeven wrote: > Hi Harini, > > On Thu, Jul 10, 2014 at 12:33 PM, Harini Katakam > wrote: >> On Thu, Jul 10, 2014 at 3:12 PM, Geert Uytterhoeven >> wrote: >>> On Thu, Jul 10, 2014 at 11

Re: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller

2014-07-10 Thread Harini Katakam
Hi Mark, On Thu, Jul 10, 2014 at 5:31 PM, Mark Brown wrote: > On Thu, Jul 10, 2014 at 04:03:19PM +0530, Harini Katakam wrote: > >> OK. Correct me if I'm wrong but announcing this support in master->flags is >> just to say the controller supports it - Like Punnaiah men

[PATCH v3 1/2] gpio: Add driver for Zynq GPIO controller

2014-07-08 Thread Harini Katakam
From: Harini Katakam Add support for GPIO controller used by Xilinx Zynq. Signed-off-by: Harini Katakam Signed-off-by: Soren Brinkmann --- v3 changes: - Use linux/gpio/driver.h instead of linux/gpio.h - Make irq a local variable in probe v2 changes: - convert to pm_runtime_force_(suspend

[PATCH v3 2/2] devicetree: Add Zynq GPIO devicetree bindings documentation

2014-07-08 Thread Harini Katakam
From: Harini Katakam Add gpio-zynq bindings documentation. Signed-off-by: Harini Katakam Signed-off-by: Soren Brinkmann --- v3 changes: Change description of #gpio-cells - use 'gpio-line' instead of 'pin' v2 changes: Improve description. --- .../devicetree/binding

[PATCH 2/2] devicetree: Add Cadence WDT devicetree bindings documentation

2014-03-28 Thread Harini Katakam
Add cadence-wdt bindings documentation. Signed-off-by: Harini Katakam --- .../devicetree/bindings/watchdog/cadence-wdt.txt | 26 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/cadence-wdt.txt diff --git a/Documentation

[PATCH 1/2] watchdog: Add Cadence WDT driver

2014-03-28 Thread Harini Katakam
Add Cadence WDT driver. This is used by Xilinx Zynq. Signed-off-by: Harini Katakam --- drivers/watchdog/Kconfig |7 + drivers/watchdog/Makefile |1 + drivers/watchdog/cadence_wdt.c | 530 3 files changed, 538 insertions(+) create

  1   2   3   >