codec driver do this. This was developed and tested on
a Lenovo Yoga Tablet 1051L with a WM5102 codec.
This was also tested by Charles Keepax, one of the Cirrus Codec folks.
Regards,
Hans
Hans de Goede (13):
mfd: arizona: Drop arizona-extcon cells
extcon: arizona: Fix some issues when HPDET
es
Signed-off-by: Hans de Goede
---
drivers/mfd/arizona-core.c | 20
1 file changed, 20 deletions(-)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 75f1bc671d59..ce6fe6de34f8 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
2 steps when arizona_hpdet_irq
runs after the jack has been unplugged.
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Acked-by: Chanwoo Choi
Signed-off-by: Hans de Goede
---
drivers/extcon/extcon-arizona.c | 17 +
1 file changed, 9 insertions(+),
: Hans de Goede
---
drivers/extcon/extcon-arizona.c | 40 +
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index f7ef247de46a..76aacbac5869 100644
--- a/drivers/extcon/extcon-arizona.c
().
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Acked-by: Chanwoo Choi
Signed-off-by: Hans de Goede
---
Changes in v3:
- This is a new patch in v3 of this patch-set
---
drivers/extcon/extcon-arizona.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
-by: Charles Keepax
Acked-by: Chanwoo Choi
Signed-off-by: Hans de Goede
---
drivers/extcon/extcon-arizona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index 76aacbac5869..72d23b15108c 100644
--- a/drivers/ext
ndy Shevchenko
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 42 ++---
sound/soc/codecs/arizona.h | 1 -
2 files changed, 18 insertions(+), 25 deletions(-)
diff --git a/sound/soc/codecs/arizona-jac
cs/arizona-jack.c .
This is a preparation patch for converting the arizona extcon-driver into
a helper library for letting the arizona codec-drivers directly report jack
state through the standard sound/soc/soc-jack.c functions.
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Acked-by: Chanwo
: Hans de Goede
---
Changes in v4:
- While at it also change (on adjescent lines) "if (ret != 0)" into "if (ret)"
- Do not unnecessary split one of the dev_err_probe() calls over multiple lines
Changes in v3:
- This is a new patch in v3 of this patch-series
---
sound/soc/c
y: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
sound/soc/codecs/wm5102.c | 12 +++-
sound/soc/codecs/wm5110.c | 12 +++-
sound/soc/codecs/wm8997.c | 14 --
sound/soc/codecs/wm8998.c | 9 +
4 files changed, 43 insertions(+), 4
.
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 97 ++---
sound/soc/codecs/arizona.h | 36
2 files changed, 65 insertions(+), 68 deletions(-)
diff
d-by: Andy Shevchenko
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 149 +---
sound/soc/codecs/arizona.h | 7 +-
2 files changed, 47 insertions(+), 109 deletions(-)
diff --git a/sound/
ested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
Changes in v3:
- Pass dev (the codec-device) to devm_regulator_get instead of
passing arizona->dev. This is necessary so that the regulator gets
properly released when the coded driver unbinds.
---
sound/soc/codecs/Makefile | 2 +-
Add jack detect support by creating a jack and calling
snd_soc_component_set_jack to register the created jack
with the codec.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
sound/soc/intel/boards/bytcr_wm5102.c | 28 ++-
1 file changed, 27 insertions
Hi,
On 3/7/21 5:13 PM, Pavel Machek wrote:
> Hi!
>
>>> --- a/drivers/leds/led-triggers.c
>>> +++ b/drivers/leds/led-triggers.c
>>> @@ -378,14 +378,15 @@ void led_trigger_event(struct led_trigger *trig,
>>> enum led_brightness brightness)
>>> {
>>> struct led_classdev *led
Hi,
On 3/7/21 9:39 AM, Neftin, Sasha wrote:
> On 3/5/2021 21:06, David E. Box wrote:
>> Due to a HW limitation, the Latency Tolerance Reporting (LTR) value
>> programmed in the Tiger Lake GBE controller is not large enough to allow
>> the platform to enter Package C10, which in turn prevents the p
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d92f85ca831d..ffcb6e14 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5169,6 +5169,12 @@ M: Torben Mathiasen
> S: Maintained
> W: http://lanana.org/docs/device-list/index.html
>
> +DEVICE RESOURCE MAN
Hi,
On 3/8/21 7:06 AM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> b5b5ff84fd93 ("platform/surface: aggregator: Make
> SSAM_DEFINE_SYNC_REQUEST_x define static functions")
>
> Fixes tag
>
> Fixes: 510c8114fc74 ("platform/surface: Add platform profile driver")
>
> has these proble
ssing requestor info to the host
for VirtualBox 6.0.x")
Reported-by: Ludovic Pouzenc
Signed-off-by: Hans de Goede
---
Changes in v2:
- Add Reported-by: Ludovic Pouzenc
---
drivers/virt/vboxguest/vboxguest_utils.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
di
Hi,
On 1/18/21 1:47 PM, Mark Brown wrote:
> On Sun, Jan 17, 2021 at 05:05:46PM +0100, Hans de Goede wrote:
>> When the jack is partially inserted and then removed again it may be
>> removed while the hpdet code is running. In this case the following
>> may happen:
>
>
Hi,
On 1/19/21 10:51 AM, Richard Fitzgerald wrote:
> On 18/01/2021 17:24, Andy Shevchenko wrote:
>> On Sun, Jan 17, 2021 at 6:06 PM Hans de Goede wrote:
>>>
>>> Convert the arizona extcon driver into a helper library for direct use
>>> from the arizona codec-d
Hi,
On 1/18/21 1:02 PM, Andy Shevchenko wrote:
> On Sun, Jan 17, 2021 at 6:06 PM Hans de Goede wrote:
>>
>> Use arizona->dev for runtime-pm as the main shared/libray code from
>> sound/soc/codecs/arizona.c does.
>
> Can you elaborate switchings from get() to g
upport for tablet mode on Dell Inspiron 7352
Geert Uytterhoeven (1):
platform/surface: SURFACE_PLATFORMS should depend on ACPI
Hans de Goede (3):
platform/x86: touchscreen_dmi: Add swap-x-y quirk for Goodix touchscreen
on Estar Beauty HD tablet
platform/x86: intel-vbtn: Drop HP S
Hi,
On 1/22/21 12:26 PM, Charles Keepax wrote:
> On Thu, Jan 21, 2021 at 05:55:00PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 1/19/21 10:51 AM, Richard Fitzgerald wrote:
>>> On 18/01/2021 17:24, Andy Shevchenko wrote:
>>>> On Sun, Ja
Hi,
On 1/22/21 2:04 PM, Charles Keepax wrote:
> On Fri, Jan 22, 2021 at 01:23:44PM +0100, Hans de Goede wrote:
>> On 1/22/21 12:26 PM, Charles Keepax wrote:
>>> On Thu, Jan 21, 2021 at 05:55:00PM +0100, Hans de Goede wrote:
>>>> On 1/19/21 10:51 AM, Richard Fitzger
Hi,
On 1/22/21 10:38 AM, Andy Shevchenko wrote:
> On Fri, Jan 22, 2021 at 2:03 AM Hans de Goede wrote:
>> On 1/18/21 1:02 PM, Andy Shevchenko wrote:
>>> On Sun, Jan 17, 2021 at 6:06 PM Hans de Goede wrote:
>
> ...
>
>>> Can you elaborate switchings fr
.
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 97 ++---
sound/soc/codecs/arizona.h | 36
2 files changed, 65 insertions(+), 68 deletions(-)
diff --git a/sound/soc/codecs
Add jack detect support by creating a jack and calling
snd_soc_component_set_jack to register the created jack
with the codec.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
sound/soc/intel/boards/bytcr_wm5102.c | 28 ++-
1 file changed, 27 insertions
Cleanup the use of dev_foo functions used for logging:
1. Many of these are unnecessarily split over multiple lines
2. Use dev_err_probe() in cases where we might get a -EPROBE_DEFERRED
return value
Suggested-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
Changes in v3:
- This is a
has already been enabled on the parent-device
by the arizona MFD driver.
This is part of a patch series converting the arizona extcon driver into
a helper library for letting the arizona codec-drivers directly report
jack state through the standard sound/soc/soc-jack.c functions.
Signed-off-by: Hans
Make all arizona codec drivers for which drivers/mfd/arizona-core.c used
to instantiate a "arizona-extcon" child-device use the new arizona-jack.c
library for jack-detection.
This has been tested on a Lenovo Yoga Tablet 2 1051L with a WM5102 codec.
Signed-off-by: Hans de Goede
---
-drivers for codecs which are converted
to use the new helper functions from arizona-jack.c are modified to
create a snd_soc_jack through snd_soc_card_jack_new() and register
this jack with the codec through snd_soc_component_set_jack().
Signed-off-by: Hans de Goede
---
Changes in v3:
- Pass dev (t
().
Signed-off-by: Hans de Goede
---
Changes in v3:
- This is a new patch in v3 of this patch-set
---
drivers/extcon/extcon-arizona.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index 72d23b15108c..56d2ce05de50
dding arizona-jack.c
as a copy and then later removing extcon-arizona.c
-Some other small tweaks, see individual patch changelogs
Regards,
Hans
Hans de Goede (13):
mfd: arizona: Drop arizona-extcon cells
extcon: arizona: Fix some issues when HPDET IRQ fires after the jack
has been unplu
cs/arizona-jack.c .
This is a preparation patch for converting the arizona extcon-driver into
a helper library for letting the arizona codec-drivers directly report jack
state through the standard sound/soc/soc-jack.c functions.
Signed-off-by: Hans de Goede
---
Changes in v3:
- Fold the 2 sep
2 steps when arizona_hpdet_irq
runs after the jack has been unplugged.
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Signed-off-by: Hans de Goede
---
drivers/extcon/extcon-arizona.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/extcon/extcon
various theoretically possible races caused
by the wrong ordering inside arizona_extcon_remove(), this fixes the
ordering fixing all possible races, including the reported oops.
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Signed-off-by: Hans de Goede
---
drivers/extcon/extcon-arizona.c
-by: Charles Keepax
Signed-off-by: Hans de Goede
---
drivers/extcon/extcon-arizona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index 76aacbac5869..72d23b15108c 100644
--- a/drivers/extcon/extcon-arizona.c
++
The arizona jack-dection handling is being reworked so that the
codec-child-device drivers directly handle jack-detect themselves,
so it is no longer necessary to instantiate "arizona-extcon"
child-devices.
Signed-off-by: Hans de Goede
---
drivers/mfd/arizona-core.c | 20 -
ned-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 149 +---
sound/soc/codecs/arizona.h | 7 +-
2 files changed, 47 insertions(+), 109 deletions(-)
diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c
index e121490eb379..26
t more verbose")
Cc: Charles Keepax
Signed-off-by: Hans de Goede
---
drivers/regulator/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index ca03d8e70bd1..75ec6f334506 100644
--- a/drivers/regulator/core.c
+++
Hi Lee,
On 3/9/21 7:12 PM, Lee Jones wrote:
> Enjoy!
>
> The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8:
>
> Linux 5.12-rc1 (2021-02-28 16:05:19 -0800)
I thought we were supposed to avoid using 5.12-rc1 as a base to avoid people
hitting the swapfile related disk-c
Hi,
On 2/7/21 4:50 AM, Colton Booth wrote:
> I can't test myself since I don't have the correct hardware, BUT this change
> seems to work for him. I'm thinking he has an early version of the X1E which
> may use slightly different trackpad revision.
Who is "him"? Do you have a bug-report link or
Hi,
On 2/7/21 11:18 AM, Hans de Goede wrote:
> Hi,
>
> On 2/7/21 4:50 AM, Colton Booth wrote:
>> I can't test myself since I don't have the correct hardware, BUT this change
>> seems to work for him. I'm thinking he has an early version of the X1E which
&g
Hi,
On 1/13/21 9:59 AM, Hans de Goede wrote:
> Hi,
>
> On 1/12/21 11:30 PM, Pavel Machek wrote:
>> Hi!
>>
>>> Booting a 5.11-rc2 kernel with lockdep enabled inside a virtualbox vm
>>> (which still
>>> emulates good old piix ATA controllers) I
Hi,
On 12/30/20 2:38 PM, Mark Brown wrote:
> On Tue, Dec 29, 2020 at 04:33:09PM +0100, Hans de Goede wrote:
>> On 12/29/20 4:08 PM, Mark Brown wrote:
>>> The whole purpose of creating sound/core/jack.c is to abstract away the
>>> userspace interfaces from the
Hi,
On 1/3/21 4:36 AM, Jiaxun Yang wrote:
> Newer ideapads (e.g.: Yoga 14s, 720S 14) come with ELAN0634 touchpad do not
> use EC to switch touchpad.
>
> Reading VPCCMD_R_TOUCHPAD will return zero thus touchpad may be blocked
> unexpectedly.
> Writing VPCCMD_W_TOUCHPAD may cause a spurious key pre
>
> Fixes: 274335f1c557 ("platform/surface: Add Driver to set up lid GPEs on MS
> Surface device")
> Signed-off-by: Randy Dunlap
> Cc: Maximilian Luz
> Cc: Hans de Goede
> Cc: platform-driver-...@vger.kernel.org
> ---
> v2: dropped Maximilian's RV
Hi,
On 12/16/20 2:37 PM, Geert Uytterhoeven wrote:
> All Microsoft Surface platform-specific device drivers depend on ACPI,
> but the gatekeeper symbol SURFACE_PLATFORMS does not. Hence when the
> user is configuring a kernel without ACPI support, he is still asked
> about Microsoft Surface drive
Hi,
On 12/21/20 8:18 AM, Srinivas Pandruvada wrote:
> One side-effect of fixing the scaling frequency limits using the
> commit eacc9c5a927e ("cpufreq: intel_pstate: Fix intel_pstate_get_hwp_max()
> for turbo disabled") causes stale HWP_CAP.GUARANTEED to be used as max.
> Without processing HWP in
Hi,
On 1/4/21 12:56 PM, Hans de Goede wrote:
> Hi,
>
> On 12/21/20 8:18 AM, Srinivas Pandruvada wrote:
>> One side-effect of fixing the scaling frequency limits using the
>> commit eacc9c5a927e ("cpufreq: intel_pstate: Fix intel_pstate_get_hwp_max()
>> f
Hi,
On 12/23/20 3:36 PM, Heikki Krogerus wrote:
> There are several reports about the tps6598x causing
> interrupt flood on boards with the INT3515 ACPI node, which
> then causes instability. There appears to be several
> problems with the interrupt. One problem is that the
> I2CSerialBus resource
Hi,
On 1/4/21 1:23 PM, Andy Shevchenko wrote:
> On Mon, Jan 04, 2021 at 12:59:39PM +0100, Hans de Goede wrote:
>> On 12/23/20 3:36 PM, Heikki Krogerus wrote:
>>> There are several reports about the tps6598x causing
>>> interrupt flood on boards with the INT3515 ACPI
Hi,
On 1/1/21 1:56 PM, Jiaxun Yang wrote:
> Add a data parameter to handler callbacks to avoid having
> global variables everywhere.
>
> Signed-off-by: Jiaxun Yang
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/acpi/platf
Hi,
On 1/1/21 1:56 PM, Jiaxun Yang wrote:
> Tested on Lenovo Yoga-14SARE Chinese Edition.
>
> Jiaxun Yang (2):
> ACPI: platform-profile: Introduce data parameter to handler
> platform/x86: ideapad-laptop: DYTC Platform profile support
>
> drivers/acpi/platform_profile.c | 4 +-
> dr
Hi,
On 12/26/20 9:53 PM, Arnold Gozum wrote:
> The Dell Inspiron 7352 is a 2-in-1 model that has chassis-type "Notebook".
> Add this model to the dmi_switches_allow_list.
>
> Signed-off-by: Arnold Gozum
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.ker
;):
>
>drivers/platform/surface/surface3-wmi.c: In function 's3_wmi_query_block':
>>> drivers/platform/surface/surface3-wmi.c:60:14: warning: variable 'status'
>>> set but not used [-Wunused-but-set-variable]
> 60 | acpi_status status;
>
eps the
2 calls, to allow drivers to call wiphy_apply_custom_regulatory more then
once if necessary.
Cc: Ilan Peer
Fixes: beee24695157 ("cfg80211: Save the regulatory domain when setting custom
regulator")
Signed-off-by: Hans de Goede
---
net/wireless/reg.c | 5 +++--
1 file changed, 3 insertions(+), 2
Hi,
On 1/4/21 9:33 PM, Rafael J. Wysocki wrote:
> On Mon, Jan 4, 2021 at 3:36 PM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 1/1/21 1:56 PM, Jiaxun Yang wrote:
>>> Tested on Lenovo Yoga-14SARE Chinese Edition.
>>>
>>> Jiaxun Yang (2):
>>>
Hi,
On 1/4/21 10:58 PM, Mark Pearson wrote:
> On 04/01/2021 15:58, Hans de Goede wrote:
>> Hi,
>>
>> On 1/4/21 9:33 PM, Rafael J. Wysocki wrote:
>>> On Mon, Jan 4, 2021 at 3:36 PM Hans de Goede
>>> wrote:
>>>>
>>>> Hi,
>>>
Hi,
On 1/5/21 2:14 PM, Jiaxun Yang wrote:
> Add a object pointer to handler callbacks to avoid having
> global variables everywhere.
>
> Signed-off-by: Jiaxun Yang
> Suggested-by: Hans de Goede
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
&
goto err_unlock;
}
acpi_device_bus_id->bus_id = bus_id;
list_add_tail(&acpi_device_bus_id->node, &acpi_bus_id_list);
}
...
So that there is only one if / 1 error-handling path for both mallocs.
I personally find this a b
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/acpi/scan.c |9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> Index: linux-pm/drivers/acpi/scan.c
> =
Hi,
Thank you for the review.
On 12/29/20 2:58 PM, Charles Keepax wrote:
> On Sun, Dec 27, 2020 at 10:12:31PM +0100, Hans de Goede wrote:
>> From: Pierre-Louis Bossart
>>
>> Add a new ASoc Machine driver for Intel Baytrail platforms with a
>> Wolfson Microelectronics
Hi,
Thank you for the review.
On 12/28/20 3:14 PM, Andy Shevchenko wrote:
> On Sun, Dec 27, 2020 at 11:16 PM Hans de Goede wrote:
>>
>> The Intel Bay Trail (x86/ACPI) based Lenovo Yoga Tablet 2 series use
>> a WM5102 codec connected over SPI.
>>
>> Add suppor
Signed-off-by: Hans de Goede
---
drivers/mfd/arizona-i2c.c | 1 +
drivers/mfd/arizona-spi.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/mfd/arizona-i2c.c b/drivers/mfd/arizona-i2c.c
index 4b58e3ad6eb6..2a4a3a164d0a 100644
--- a/drivers/mfd/arizona-i2c.c
+++ b/drivers/mfd/ari
Hi All,
Here is v2 of my series to add support for Intel Bay Trail based devices
which use a WM5102 codec for audio output/input. This was developed and
tested on a Lenovo Yoga Tablet 1051L.
The biggest difference from v1 is that, based on all the discussions about
the jack-detect stuff, I've dec
functions (this could happen on e.g. manual
driver binding through sysfs).
Suggested-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
Changes in v2:
- New patch in v2 of this patchset
---
drivers/mfd/arizona-core.c | 11 ---
drivers/mfd/arizona-i2c.c | 10 ++
drivers/mfd/arizona
. and 2. still have their IPC IRQ at index 0 rather then 5
Add a DMI quirk table to check for the few known models with this issue,
so that the right IPC IRQ index is used on these systems.
Reviewed-by: Andy Shevchenko
Acked-by: Pierre-Louis Bossart
Signed-off-by: Hans de Goede
---
sound/soc
hine driver and ACPI hooks, the BYT-CR detection
quirk which these devices need will be added in a separate patch.
BugLink: https://github.com/thesofproject/linux/issues/2485
Co-authored-by: Pierre-Louis Bossart
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Andy Shevchenko
Signed-off-by
Hartmann, combined with insights in things like the speaker GPIO
from the android-x86 android port for the Lenovo Yoga Tablet 2 1051F/L [1].
[1] https://github.com/Kitsune/Android_Yoga_Tablet_2-1051F_Kernel
Cc: Christian Hartmann
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
Hi All,
This series reworks the arizona codec jack-detect support to use
the snd_soc_jack helpers instead of direct extcon reporting.
This is done by reworking the extcon driver into an arizona-jackdet
library and then modifying the codec drivers to use that directly,
replacing the old separate e
.
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 97 ++---
sound/soc/codecs/arizona.h | 36
2 files changed, 65 insertions(+), 68 deletions(-)
diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c
index
The arizona jack-dection handling is being reworked so that the
codec-child-device drivers directly handle jack-detect themselves,
so it is no longer necessary to instantiate "arizona-extcon"
child-devices.
Signed-off-by: Hans de Goede
---
drivers/mfd/arizona-core.c | 20 -
-by: Charles Keepax
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c
index 76aacbac5869..72d23b15108c 100644
--- a/sound/soc/codecs/arizona-jack.c
++
k.c functions.
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 42 ++---
sound/soc/codecs/arizona.h | 1 -
2 files changed, 18 insertions(+), 25 deletions(-)
diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c
in
various theoretically possible races caused
by the wrong ordering inside arizona_extcon_remove(), this fixes the
ordering fixing all possible races, including the reported oops.
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c
functions.
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 1816 +++
1 file changed, 1816 insertions(+)
create mode 100644 sound/soc/codecs/arizona-jack.c
diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c
new file mode
Add jack detect support by creating a jack and calling
snd_soc_component_set_jack to register the created jack
with the codec.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
sound/soc/intel/boards/bytcr_wm5102.c | 28 ++-
1 file changed, 27 insertions
-drivers for codecs which are converted
to use the new helper functions from arizona-jack.c are modified to
create a snd_soc_jack through snd_soc_card_jack_new() and register
this jack with the codec through snd_soc_component_set_jack().
Signed-off-by: Hans de Goede
---
sound/soc/codecs/
vices for it to bind to), so it can
be dropped.
Signed-off-by: Hans de Goede
---
MAINTAINERS |1 -
drivers/extcon/Kconfig |8 -
drivers/extcon/Makefile |1 -
drivers/extcon/extcon-arizona.c | 1816 ---
4 files cha
2 steps when arizona_hpdet_irq
runs after the jack has been unplugged.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/code
ned-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 149 +---
sound/soc/codecs/arizona.h | 7 +-
2 files changed, 47 insertions(+), 109 deletions(-)
diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c
index eb46087f3ab7..51
Make all arizona codec drivers for which drivers/mfd/arizona-core.c used
to instantiate a "arizona-extcon" child-device use the new arizona-jack.c
library for jack-detection.
This has been tested on a Lenovo Yoga Tablet 2 1051L with a WM5102 codec.
Signed-off-by: Hans de Goede
---
Hi All,
Here is v3 of my series to add support for Intel Bay Trail based devices
which use a WM5102 codec for audio output/input. New in v3 is that the
compile error when CONFIG_ACPI is unset should be gone. Everything else
is the same as in v2, see the cover-letter of v2 below:
This was develope
. and 2. still have their IPC IRQ at index 0 rather then 5
Add a DMI quirk table to check for the few known models with this issue,
so that the right IPC IRQ index is used on these systems.
Reviewed-by: Andy Shevchenko
Acked-by: Pierre-Louis Bossart
Signed-off-by: Hans de Goede
---
sound/soc
Signed-off-by: Hans de Goede
---
drivers/mfd/arizona-i2c.c | 1 +
drivers/mfd/arizona-spi.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/mfd/arizona-i2c.c b/drivers/mfd/arizona-i2c.c
index 4b58e3ad6eb6..2a4a3a164d0a 100644
--- a/drivers/mfd/arizona-i2c.c
+++ b/drivers/mfd/ari
hine driver and ACPI hooks, the BYT-CR detection
quirk which these devices need will be added in a separate patch.
BugLink: https://github.com/thesofproject/linux/issues/2485
Co-authored-by: Pierre-Louis Bossart
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Andy Shevchenko
Signed-off-by
functions (this could happen on e.g. manual
driver binding through sysfs).
Suggested-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
Changes in v2:
- New patch in v2 of this patchset
---
drivers/mfd/arizona-core.c | 11 ---
drivers/mfd/arizona-i2c.c | 10 ++
drivers/mfd/arizona
Hartmann, combined with insights in things like the speaker GPIO
from the android-x86 android port for the Lenovo Yoga Tablet 2 1051F/L [1].
[1] https://github.com/Kitsune/Android_Yoga_Tablet_2-1051F_Kernel
Cc: Christian Hartmann
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
Hi,
On 1/18/21 10:55 AM, Lee Jones wrote:
> On Sun, 17 Jan 2021, Hans de Goede wrote:
>
>> Hi All,
>>
>> This series reworks the arizona codec jack-detect support to use
>> the snd_soc_jack helpers instead of direct extcon reporting.
>>
>> This is d
Hi,
On 1/22/21 9:38 PM, Andy Shevchenko wrote:
> On Fri, Jan 22, 2021 at 6:41 PM Hans de Goede wrote:
>>
>> Before this commit the extcon-arizona code was mixing pm_runtime_get()
>> and pm_runtime_get_sync() in different places.
>>
>> In all places where pm_ru
Hi,
On 1/22/21 9:40 PM, Andy Shevchenko wrote:
> On Fri, Jan 22, 2021 at 6:41 PM Hans de Goede wrote:
>>
>> The jack handling for arizona codecs is being refactored so that it is
>> done directly by the codec drivers, instead of having an extcon-driver
>> bind to
HI,
On 1/22/21 9:56 PM, Andy Shevchenko wrote:
> On Fri, Jan 22, 2021 at 6:41 PM Hans de Goede wrote:
>>
>> Cleanup the use of dev_foo functions used for logging:
>>
>> 1. Many of these are unnecessarily split over multiple lines
>> 2. Use dev_err_prob
Hi,
On 1/23/21 11:29 AM, Charles Keepax wrote:
> On Fri, Jan 22, 2021 at 07:32:50PM +0100, Hans de Goede wrote:
>> Sometimes regulator_get() gets called twice for the same supply on the
>> same device. This may happen e.g. when a framework / library is used
>> which uses t
other small tweaks, see individual patch changelogs
Regards,
Hans
Hans de Goede (13):
mfd: arizona: Drop arizona-extcon cells
extcon: arizona: Fix some issues when HPDET IRQ fires after the jack
has been unplugged
extcon: arizona: Fix various races on driver unbind
extcon: arizona: Fix
various theoretically possible races caused
by the wrong ordering inside arizona_extcon_remove(), this fixes the
ordering fixing all possible races, including the reported oops.
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Signed-off-by: Hans de Goede
---
drivers/extcon/extcon-arizona.c
2 steps when arizona_hpdet_irq
runs after the jack has been unplugged.
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Signed-off-by: Hans de Goede
---
drivers/extcon/extcon-arizona.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/extcon/extcon
The arizona jack-dection handling is being reworked so that the
codec-child-device drivers directly handle jack-detect themselves,
so it is no longer necessary to instantiate "arizona-extcon"
child-devices.
Signed-off-by: Hans de Goede
---
drivers/mfd/arizona-core.c | 20 -
-by: Charles Keepax
Signed-off-by: Hans de Goede
---
drivers/extcon/extcon-arizona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index 76aacbac5869..72d23b15108c 100644
--- a/drivers/extcon/extcon-arizona.c
++
901 - 1000 of 2701 matches
Mail list logo
