Hi,
On 3/26/21 8:20 PM, Colin King wrote:
> From: Colin Ian King
>
> The variable result is being assigned a value that is never
> read and it is being updated later with a new value. The
> assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Col
Hi,
On 3/29/21 7:49 PM, Henning Schild wrote:
> changes since v2:
>
> - remove "simatic-ipc" prefix from LED names
> - fix style issues found in v2, mainly LED driver
> - fix OEM specific dmi code, and remove magic numbers
> - more "simatic_ipc" name prefixing
> - improved pmc quirk code using ca
Hi,
On 3/31/21 12:08 AM, Srinivas Pandruvada wrote:
> In some cases when firmware is busy or updating, some mailbox commands
> still timeout on some newer CPUs. To fix this issue, change how we
> process timeout.
>
> With this change, replaced timeout from using simple count with real
> timeout i
o a function that will handle each quirk if its variable
> condition is met. This allows removing the global pmc_dev later.
>
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platfor
his directly. Since the driver now binds to an ACPI device,
> remove the global pmc_dev in favor of one that is allocated during probe.
> Modify users of the global to obtain the object by argument instead.
>
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by:
S0i3.2 0
>
> Suggested-by: David E. Box
> Signed-off-by: Gayatri Kammela
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/intel_pmc_core.c | 59 ++-
> d
this value then divide
> by two to maintain accuracy.
>
> Signed-off-by: Gayatri Kammela
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/intel_pmc_core.c | 14 --
> driver
Hi,
On 4/1/21 5:05 AM, David E. Box wrote:
> From: Gayatri Kammela
>
> Platforms that support low power modes (LPM) such as Tiger Lake maintain
> requirements for each sub-state that a readable in the PMC. However, unlike
> LPM status registers, requirement registers are not memory mapped but ar
gt; Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/intel_pmc_core.c | 86 +++
> 1 file changed, 86 insertions(+)
>
> diff --git a/drivers/platform/x86/intel_pmc_core.c
Hi,
On 4/1/21 5:05 AM, David E. Box wrote:
> By default the Low Power Mode (LPM or sub-state) status registers will
> latch condition status on every entry into Package C10. This is
> configurable in the PMC to allow latching on any achievable sub-state. Add
> a debugfs file to support this.
>
>
lease refer to the patch changelogs for details.
Thanks, the entire series looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
o adjust the number of LTR IPs for Tiger Lake to the correct amount.
>
> Signed-off-by: Gayatri Kammela
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/intel_pmc_core.c | 2 ++
> drivers
Hi,
On 4/1/21 5:05 AM, David E. Box wrote:
> Alder PCH-P is based on Tiger Lake PCH.
>
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/intel_pmc_core.c | 1 +
> 1 file changed, 1 inse
Hi,
On 4/1/21 5:05 AM, David E. Box wrote:
> - Patch 1 and 2 remove the use of the global struct pmc_dev
> - Patches 3-7 add support for reading low power mode sub-state
> requirements, latching sub-state status on different low power mode
> events, and displaying the sub-state residency in mi
Hi,
On 4/1/21 6:22 PM, Mario Limonciello wrote:
> The Dell drivers I'm involved with all have me as an author and/or
> maintainer. In the future these will be maintained as a team effort.
> Adjust the contact addresses accordingly.
>
> Mario Limonciello (3):
> MAINTAINERS: Adjust Dell drivers
Hi Perry, Barnabás,
Barnabás thank you for your review. I agree with all your remarks.
Perry, Thank you for the new version, this version is looking good.
This is almost ready for merging.
Please fix the review remarks from Barnabás. I also have a couple of small
review remarks myself below.
On
uot;ACPI: platform: Add platform profile support")
> Fixes: 8e0cbf356377 ("Documentation: Add documentation for new
> platform_profile sysfs attribute")
> Signed-off-by: Mauro Carvalho Chehab
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Rafael, I assume you wil
Hi,
On 4/1/21 5:07 PM, Mark Pearson wrote:
>
>
> On 01/04/2021 09:49, Hans de Goede wrote:
>> Hi,
>>
>> On 4/1/21 2:17 PM, Mauro Carvalho Chehab wrote:
>>> The file name: Documentation/ABI/testing/sysfs-platform_profile.rst
>>> should b
are not memory mapped but are
> available from an ACPI _DSM. Collect the requirements for Tiger Lake using
> the _DSM method and store in a buffer.
>
> Signed-off-by: Gayatri Kammela
> Co-developed-by: David E. Box
> Signed-off-by: David E. Box
> Reviewed-by: Hans de Goede
mory mapped but are
> available from an ACPI _DSM. Collect the requirements for Tiger Lake using
> the _DSM method and store in a buffer.
>
> Signed-off-by: Gayatri Kammela
> Co-developed-by: David E. Box
> Signed-off-by: David E. Box
> Reviewed-by: Hans de Goede
> ---
Hi,
On 4/17/21 5:12 AM, David E. Box wrote:
> - Patch 1 and 2 remove the use of the global struct pmc_dev
> - Patches 3-7 add support for reading low power mode sub-state
> requirements, latching sub-state status on different low power mode
> events, and displaying the sub-state residency in m
Hi Luke,
On 4/19/21 9:49 AM, Luke D. Jones wrote:
> Revert two commits to allow a patch to acpi/video_detect to correctly
> set the backlight control as native.
Thank you for following up on our previous discussion about this.
I'll merge this as soon as Rafael has accepted to matching
drivers/ac
Hi,
On 4/19/21 10:02 AM, Luke Jones wrote:
> NP Hans, sorry about the length of time this took. Other duties etc.
>
> I appreciated the wealth of insight you were able to provide to enable this.
BTW, I see that your drivers/acpi/video_detect.c patch is marked as [PATCH 1/3]
I
guess these 2 patc
Hi,
On 4/17/21 5:12 AM, David E. Box wrote:
> - Patch 1 and 2 remove the use of the global struct pmc_dev
> - Patches 3-7 add support for reading low power mode sub-state
> requirements, latching sub-state status on different low power mode
> events, and displaying the sub-state residency in m
Hi,
On 3/4/21 4:34 PM, Alexander Monakov wrote:
> Hello, Hans, Linux PM folks,
>
> I'm looking for clarification regarding this patch discussion:
>
> https://patchwork.kernel.org/project/linux-pm/patch/20180420101834.15783-2-0v3rdr...@gmail.com/
>
> Hans said,
>
>> Ah, so the AHCI code has run
Hi,
On 3/9/21 1:05 AM, Maximilian Luz wrote:
> This series provides battery and AC drivers for Microsoft Surface
> devices, where this information is provided via an embedded controller
> (the Surface System Aggregator Module, SSAM) instead of the usual ACPI
> interface.
>
> Specifically, 7th gen
Hi,
On 3/8/21 7:48 PM, Maximilian Luz wrote:
> The Microsoft Surface Book series devices consist of a so-called
> clipboard part (containing the CPU, touchscreen, and primary battery)
> and a base part (containing keyboard, secondary battery, and optional
> discrete GPU). These parts can be separa
Hi,
On 3/9/21 5:25 PM, Maximilian Luz wrote:
> The Surface Pro 7+ is essentially a refresh of the Surface Pro 7 with
> updated hardware and a new WSID identifier.
>
> Signed-off-by: Maximilian Luz
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.or
Hi,
On 3/17/21 6:47 PM, Maximilian Luz wrote:
> On 3/17/21 6:39 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 3/9/21 1:05 AM, Maximilian Luz wrote:
>>> This series provides battery and AC drivers for Microsoft Surface
>>> devices, where this information is provi
Hi,
On 3/10/21 11:53 PM, Maximilian Luz wrote:
> This series adds support for the Surface System Aggregator Module (SSAM)
> HID transport subsystem.
>
> The SSAM is an embedded controller, found on 5th- and later generation
> Microsoft Surface devices. On some of these devices (specifically
> Sur
Hi,
On 3/17/21 8:13 PM, Henning Schild wrote:
> Am Mon, 15 Mar 2021 12:31:11 +0200
> schrieb Andy Shevchenko :
>
>> On Mon, Mar 15, 2021 at 12:02 PM Henning Schild
>> wrote:
>>>
>>> This mainly implements detection of these devices and will allow
>>> secondary drivers to work on such machines.
>
Hi,
On 3/10/21 11:57 AM, Lee Jones wrote:
> Rebased onto -rc2
>
> The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15:
>
> Linux 5.12-rc2 (2021-03-05 17:33:41 -0800)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/lee/mf
Hi Lee,
On 3/7/21 4:17 PM, Hans de Goede wrote:
> Hi All,
>
> Here is v4 of my series to rework the arizona codec jack-detect support
> to use the snd_soc_jack helpers instead of direct extcon reporting.
>
> As discussed before here is a resend rebased on 5.12-rc2, maki
Hi,
On 3/18/21 12:30 PM, Enrico Weigelt, metux IT consult wrote:
> On 17.03.21 21:03, Hans de Goede wrote:
>
> Hi,
>
>>> It just identifies the box and tells subsequent drivers which one it
>>> is, which watchdog and LED path to take. Moving the knowledge of which
Hi,
On 3/12/21 9:11 AM, YingChieh Ho wrote:
> From: "Andrea.Ho"
>
> Advantech sw_button is a ACPI event trigger button.
>
> With this driver, we can report KEY_EVENT on the
> Advantech Tabletop Network Appliances products and it has been
> tested in FWA1112VC.
>
> Add the software define butto
Hi,
On 4/10/21 8:56 AM, Guenter Roeck wrote:
> On 4/8/21 11:02 PM, Thomas Weißschuh wrote:
>> On Do, 2021-04-08T08:00-0700, Guenter Roeck wrote:
>>> On 4/8/21 2:36 AM, Hans de Goede wrote:
>>>> On 4/7/21 9:43 PM, Thomas Weißschuh wrote:
>>>>> On M
Hi,
On 4/10/21 4:40 PM, Thomas Weißschuh wrote:
> Changes since v1:
> * Incorporate feedback from Barnabás Pőcze
> * Use a WMI driver instead of a platform driver
> * Let the kernel manage the driver lifecycle
> * Fix errno/ACPI error confusion
> * Fix resource cleanup
> * Document reaso
Hi,
On 4/10/21 5:15 PM, Guenter Roeck wrote:
> On 4/10/21 7:40 AM, Thomas Weißschuh wrote:
>> Changes since v1:
>> * Incorporate feedback from Barnabás Pőcze
>> * Use a WMI driver instead of a platform driver
>> * Let the kernel manage the driver lifecycle
>> * Fix errno/ACPI error confusion
Hi,
On 2/21/21 10:02 PM, Elia Devito wrote:
> rename "thermal policy" with the more appropriate term "thermal profile"
>
> Signed-off-by: Elia Devito
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
I will merge this once we are out of the merge-
Hi,
On 2/21/21 11:13 PM, Elia Devito wrote:
> Implement support for cool, balanced and performance thermal profile
>
> Signed-off-by: Elia Devito
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
I will merge this once we are out of the merge-window / once 5.12-rc1 is out.
Hi,
On 2/22/21 2:19 PM, Daniel Scally wrote:
> Hi all
>
> On 22/02/2021 13:07, Daniel Scally wrote:
>> diff --git a/drivers/platform/x86/intel-int3472/Kconfig
>> b/drivers/platform/x86/intel-int3472/Kconfig
>> new file mode 100644
>> index ..b94622245c21
>> --- /dev/null
>> +++ b/dri
Hi,
On 11/17/20 9:42 PM, Justin Ernst wrote:
> Introduce a new platform driver to gather topology information from UV systems
> and expose that information via a sysfs interface at /sys/firmware/sgi_uv/.
>
> Justin Ernst (5):
> x86/platform/uv: Remove existing /sys/firmware/sgi_uv/ interface
>
Hi All,
On 11/10/20 12:36 PM, Hans de Goede wrote:
> Hi All,
>
> Not sure if this is a XHCI driver problem at all, but I needed to start
> somewhere with reporting this so I went with:
>
> scripts/get_maintainer.pl -f drivers/usb/host/xhci-pci.c
>
> And added a Cc: linu
Hi,
On 12/8/20 5:14 PM, Alexander Duyck wrote:
> On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 12/8/20 6:08 AM, Neftin, Sasha wrote:
>>> On 12/7/2020 17:41, Limonciello, Mario wrote:
>>>>> First of all thank you for wo
Hi,
On 12/9/20 5:50 AM, Chris Chiu wrote:
> The ECS EF20EA laptop ships an AXP288 but it is actually using a
> different, separate FG chip for AC and battery monitoring. On this
> laptop we need to keep using the regular ACPI driver and disable the
> AXP288 FG to avoid reporting two batteries to u
Hi,
On 11/19/20 7:36 AM, Jerry Snitselaar wrote:
>
> Matthew Garrett @ 2020-10-15 15:39 MST:
>
>> On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar wrote:
>>>
>>> There is a misconfiguration in the bios of the gpio pin used for the
>>> interrupt in the T490s. When interrupts are enabled in the t
Hi,
On 11/28/20 6:15 PM, Christoph Hellwig wrote:
> Can you give this one-liner a spin?
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index c6622011d4938c..e889111b55c71d 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -4007,6 +40
Hi,
On 11/28/20 4:48 PM, Tom Yan wrote:
> While the change only seemed to have caused issue on uas drives, we
> probably want to avoid it in the usb-storage driver as well, until
> we are sure it is the right thing to do.
>
> Signed-off-by: Tom Yan
This seems to do a whole lot more then just dr
al gbit LAN goes back from the regressed 1 MB/s to its original
100MB/s
as it should be:
Tested-by: Hans de Goede
Regards,
Hans
> ---
> drivers/usb/storage/uas.c | 11 +++
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/storage/uas.c b/
ady moved to its
new place and another patch was added on top, so that is different.
Regards,
Hans
>
> On Mon, 30 Nov 2020 at 17:50, Hans de Goede wrote:
>>
>> Hi,
>>
>> On 11/28/20 4:48 PM, Tom Yan wrote:
>>> While the change only seemed to have caused i
ol 'uv_hubs_kset' was not
> declared. Should it be static?
>
> Signed-off-by: Zou Wei
Since this is a fix to a series merged through the x86/tip tree, this should be
merged
to the x86/tip tree too (or I can pick it up after 5.11-rc1).
Here is my ack for merging this throug
Hi,
On 11/30/20 2:30 PM, Greg KH wrote:
> On Mon, Nov 30, 2020 at 02:23:48PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/30/20 1:58 PM, Tom Yan wrote:
>>> It's merely a moving of comment moving for/and a no-behavioral-change
>>> adaptation for
Hi,
On 11/30/20 2:53 PM, Greg KH wrote:
> On Mon, Nov 30, 2020 at 02:36:38PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/30/20 2:30 PM, Greg KH wrote:
>>> On Mon, Nov 30, 2020 at 02:23:48PM +0100, Hans de Goede wrote:
>>>> Hi,
>>>>
>&g
Hi,
On 11/30/20 6:20 PM, Alan Stern wrote:
> On Mon, Nov 30, 2020 at 02:36:38PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/30/20 2:30 PM, Greg KH wrote:
>>> On Mon, Nov 30, 2020 at 02:23:48PM +0100, Hans de Goede wrote:
>>>> Hi,
>>>>
>
s that for 5.10 we really should just go with the 3 reverts
which I suggested earlier.
Regards,
Hans
>
> On Mon, 30 Nov 2020 at 17:48, Hans de Goede wrote:
>>
>> Hi,
>>
>> On 11/28/20 4:48 PM, Tom Yan wrote:
>>> Apparently the former (with the chosen dma_d
Hi,
On 11/19/20 6:05 PM, Jerry Snitselaar wrote:
>
> Hans de Goede @ 2020-11-19 07:42 MST:
>
>> Hi,
>>
>> On 11/19/20 7:36 AM, Jerry Snitselaar wrote:
>>>
>>> Matthew Garrett @ 2020-10-15 15:39 MST:
>>>
>>>> On Thu, Oct 15, 202
Hi,
On 11/12/20 2:52 PM, Andy Shevchenko wrote:
>
> +Cc: Hans.
>
> I can't speak for AMD, but I think it may be useful for Intel pin control.
> However, I didn't check what may be the side effects of this change and
> neither
> contributor answered to my comments...
AFAICT setting IRQF_EARLY_R
Hi,
On 11/11/20 3:31 PM, Mika Westerberg wrote:
> On Wed, Nov 11, 2020 at 12:27:32PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/10/20 6:25 PM, Mika Westerberg wrote:
>>> On Tue, Nov 10, 2020 at 04:02:33PM +, Limonciello, Mario wrote:
>>>>>
&
ssion?
Regards,
Hans
On 11/10/20 12:36 PM, Hans de Goede wrote:
> Hi All,
>
> Not sure if this is a XHCI driver problem at all, but I needed to start
> somewhere with reporting this so I went with:
>
> scripts/get_maintainer.pl -f drivers/usb/host/xhci-pci.c
>
lared (first use in this function)
> irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
>
> Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which
> modify the irqflags")
> Signed-off-by: Randy Dunlap
> Reported-by: kernel test robot
> Cc: Hans de Goede
> Cc: Dmi
Hi,
On 11/24/20 11:27 AM, Christoph Hellwig wrote:
> On Mon, Nov 23, 2020 at 03:49:09PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> +Cc Christoph Hellwig
>>
>> Christoph, this is still an issue, so I've been looking around a bit and
>> think this
>&g
under both arch/x86/ and drivers/platform/x86/ ,
I believe this is best merged through the x86/tip tree and I don't
expect conflicts for the drivers/platform/x86/{Kconfig,Makefile} changes.
So here is my ack for merging this series through the x86/tip tree:
Acked-by: Hans de Goede
Regards,
Hans
Hi,
On 11/15/20 8:21 PM, Maximilian Luz wrote:
> Hello,
>
> N.B.: the following text is mostly a repeat of cover letter from the
> previous RFC for the uninitiated, which can be found at
>
>
> https://lore.kernel.org/linux-serial/20200923151511.3842150-1-luzmaximil...@gmail.com/
>
> Se
>
> ---
>
> Changes in v3:
> Use only two more generic wildcards.
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
>
> Changes in v2:
> In comparison to first version [0] we use wildcards to enumerate the
> firmware configuration files. Wi
Hi,
On 11/22/20 6:49 AM, xiakaixu1...@gmail.com wrote:
> From: Kaixu Xia
>
> The commit 78429e55e4057 ("platform/x86: toshiba_acpi: Clean up
> variable declaration") cleans up variable declaration in
> video_proc_write(). Seems it does the variable assignment in the
> wrong place, this results i
Hi,
On 11/13/20 11:39 PM, Maximilian Luz wrote:
> In addition to a 13" version, there is also a 15" (business) version of
> the Surface Laptop 3 based on Intel CPUs. This version also handles
> wakeup by lid via (unmarked) GPEs, so add support for it as well.
>
> Signed-off-by: Maximilian Luz
T
Hi,
On 11/24/20 2:16 PM, Max Verevkin wrote:
> Signed-off-by: Max Verevkin
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch
Hi,
On 11/24/20 1:37 PM, Mathias Nyman wrote:
> On 23.11.2020 15.54, Hans de Goede wrote:
>> Hi,
>>
>> On 11/11/20 3:31 PM, Mika Westerberg wrote:
>>> On Wed, Nov 11, 2020 at 12:27:32PM +0100, Hans de Goede wrote:
>>>> Hi,
>>>>
>>>>
Hi,
On 12/5/20 4:29 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> The PNP0D80 ("Windows-compatible System Power Management Controller")
> device ID is used for identifying the special device object providing
> the LPI (Low-power S0 Idle) _DSM interface [1]. That device object
> doe
where as we actually want people to work upstream as much as possible.
I know this is not a reason for taking bad code, but I'm not
convinced that this is bad code.
I have not reviewed this myself yet, but once I have reviewed
this and any review remarks have been addressed I do expect to
merge this series through the platform-drivers-x86 tree.
Regards,
Hans de Goede
(drivers/platform/x86 and drivers/platform/surface subsys maintainer)
Hi,
On 12/6/20 9:56 AM, Leon Romanovsky wrote:
> On Sun, Dec 06, 2020 at 09:41:21AM +0100, Hans de Goede wrote:
>> Hi Leon,
>>
>> On 12/6/20 8:07 AM, Leon Romanovsky wrote:
>>> On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote:
>>>> Hello,
&g
Hi,
On 12/6/20 11:33 AM, Leon Romanovsky wrote:
> On Sun, Dec 06, 2020 at 11:04:06AM +0100, Hans de Goede wrote:
>> But there is a difference between being careful and just nacking
>> it because no new UAPI may be added at all (also see GKH's response).
>
> I saw, th
Hi,
On 12/6/20 11:33 AM, Maximilian Luz wrote:
> On 12/6/20 10:06 AM, Leon Romanovsky wrote:> On Sun, Dec 06, 2020 at
> 05:58:32PM +0900, Blaž Hrastnik wrote:
> More on that, the whole purpose of proposed interface is to debug and
> not intended to be used by any user space code.
>>>
Hi,
On 11/24/20 6:52 PM, Jerry Snitselaar wrote:
>
> Jarkko Sakkinen @ 2020-11-23 20:26 MST:
>
>> On Wed, Nov 18, 2020 at 11:36:20PM -0700, Jerry Snitselaar wrote:
>>>
>>> Matthew Garrett @ 2020-10-15 15:39 MST:
>>>
On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar
wrote:
>
>
Hi,
+Cc Mario
On 11/25/20 7:50 AM, Qinglang Miao wrote:
> Fix to return the error code -ENODEV when fails to init wmi and
> smm.
>
> Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-*
> modules together")
> Reported-by: Hulk Robot
> Signed-off-by: Qinglang Miao
Mario, th
| 862 ++
> 10 files changed, 1217 insertions(+), 78 deletions(-)
> create mode 100644 arch/x86/include/asm/uv/uv_geo.h
> delete mode 100644 arch/x86/platform/uv/uv_sysfs.c
> create mode 100644 drivers/platform/x86/uv_sysfs.c
My acked-by for merging the drivers/platform/x86 bits through the x86/tip
tree still stands:
Acked-by: Hans de Goede
REgards,
Hans
Hi,
On 11/25/20 6:29 PM, Mike Travis wrote:
>
> Duplicate the current UV procfs leaves to the uv_sysfs driver so they show
> up under /sys/firmware/sgi_uv. Show a 'deprecated' warning message if
> any of the old /proc/sgi_uv leaves are used.
>
> These patches depend on the prior set sent by Jus
Hi,
On 11/25/20 6:29 PM, Mike Travis wrote:
> Add "deprecated" message to any access to old /proc/sgi_uv/* leaves.
>
> Signed-off-by: Mike Travis
> Reviewed-by: Steve Wahl
> ---
> arch/x86/kernel/apic/x2apic_uv_x.c | 26 +-
> 1 file changed, 25 insertions(+), 1 deletion
Hi,
On 11/25/20 11:10 AM, Vadim Pasternak wrote:
> Remove PSU EEPROM configuration for systems MSN2700, MSN2100, MSN274x
> to support the requirement of power unit replacement by "off the shelf"
> device, matching electrical required parameters. Such device can be
> equipped with different EEPROM
Signed-off-by: Daniel Lezcano
> Reviewed-by: Lukasz Luba
I assume that you will merge this through the thermal tree,
here is my ack for doing so for the pdx86 bits:
Acked-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/acerhdf.c | 3 ++-
>
Hi,
On 12/1/20 8:21 PM, Andy Shevchenko wrote:
> On Tue, Dec 01, 2020 at 09:06:38PM +0200, Laurent Pinchart wrote:
>> On Tue, Dec 01, 2020 at 09:05:23PM +0200, Andy Shevchenko wrote:
>>> On Tue, Dec 01, 2020 at 08:55:48PM +0200, Laurent Pinchart wrote:
On Tue, Dec 01, 2020 at 08:54:17PM +0200
Hi Elia,
Thank you for your patch series.
I'm fraid that always enabling this on devices with a chassis_type of 31 is
not a good idea though.
Many 360 degree hinges (yoga) style 2-in-1s use 2 accelerometers to tell
the angle between the 2 halves; and they rely on a HingleAngleService
process und
Hi,
On 11/25/20 7:50 AM, Qinglang Miao wrote:
> Fix to return the error code -ENODEV when fails to init wmi and
> smm.
>
> Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-*
> modules together")
> Reported-by: Hulk Robot
> Signed-off-by: Qinglang Miao
Thank you for your p
Hi,
On 11/27/20 7:10 PM, t...@redhat.com wrote:
> From: Tom Rix
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.g
Hi,
On 12/2/20 7:56 AM, Divya Bharathi wrote:
> BIOS sets incorrect value (zero) when SET value passed for integer attribute
> with + sign. Added workaround to remove + sign before passing input to BIOS
>
> Co-developed-by: Mario Limonciello
> Signed-off-by: Mario Limonciello
> Co-developed-by:
Hi,
On 3/13/21 8:46 AM, Wang Qing wrote:
> platform_get_irq() has already checked and printed the return value,
> the printing here is nothing special, it is not necessary at all.
>
> Signed-off-by: Wang Qing
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Re
Hi,
On 3/15/21 11:14 AM, Henning Schild wrote:
> Am Mon, 15 Mar 2021 10:57:10 +0100
> schrieb Henning Schild :
>
>> Siemens industrial PCs unfortunately can not always be properly
>> identified the way we used to. An earlier commit introduced code that
>> allows proper identification without look
ssing requestor info to the host
for VirtualBox 6.0.x")
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_utils.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/virt/vboxguest/vboxguest_utils.c
b/drivers/virt/vboxguest/vboxgue
Hi,
On 1/18/21 2:34 PM, Mark Brown wrote:
> On Mon, Jan 18, 2021 at 02:13:50PM +0100, Hans de Goede wrote:
>
>> More in general I'm not aware of any (recent-ish) x86 GPIO controllers
>> not being able to do active low interrupts. In theory we could hit this
>> code p
s running"
> - no change
I've finally gotten around to testing this. I'm happy to
report that the power-role swapping regression seen in one
of the older versions of this patch-set is gone.
So the entire series is:
Tested-by: Hans de Goede
Regards,
Hans
>
> --
f an int and adapt its callers to that.
>
> While at it, rename acpi_get_device_data() to handle_to_device(),
> because the old name does not really reflect the functionality
> provided by that function.
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki
Hartmann, combined with insights in things like the speaker GPIO
from the android-x86 android port for the Lenovo Yoga Tablet 2 1051F/L [1].
[1] https://github.com/Kitsune/Android_Yoga_Tablet_2-1051F_Kernel
Cc: Christian Hartmann
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
hine driver and ACPI hooks, the BYT-CR detection
quirk which these devices need will be added in a separate patch.
BugLink: https://github.com/thesofproject/linux/issues/2485
Co-authored-by: Pierre-Louis Bossart
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Andy Shevchenko
Signed-off-by
. and 2. still have their IPC IRQ at index 0 rather then 5
Add a DMI quirk table to check for the few known models with this issue,
so that the right IPC IRQ index is used on these systems.
Reviewed-by: Andy Shevchenko
Acked-by: Pierre-Louis Bossart
Signed-off-by: Hans de Goede
---
sound/soc
Signed-off-by: Hans de Goede
---
drivers/mfd/arizona-i2c.c | 1 +
drivers/mfd/arizona-spi.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/mfd/arizona-i2c.c b/drivers/mfd/arizona-i2c.c
index 4b58e3ad6eb6..2a4a3a164d0a 100644
--- a/drivers/mfd/arizona-i2c.c
+++ b/drivers/mfd/ari
in v2:
- Split my WM5102 work into 2 series, one series adding basic support
for Bay Trail boards with a WM5102 codec and a second series with
the jack-detect work
- Various other minor code tweaks
Hans de Goede (4):
mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1")
mfd: arizon
functions (this could happen on e.g. manual
driver binding through sysfs).
Suggested-by: Andy Shevchenko
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Signed-off-by: Hans de Goede
---
Changes in v2:
- New patch in v2 of this patchset
---
drivers/mfd/arizona-core.c | 11 ---
drivers
Hi,
On 1/20/21 9:56 PM, Jared Baldridge wrote:
> The OneGX1 Pro has a fairly unique combination of generic strings,
> but we additionally match on the BIOS date just to be safe.
>
> Signed-off-by: Jared Baldridge
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
I will
Hi,
On 1/20/21 8:59 PM, Andy Shevchenko wrote:
> On Wed, Jan 20, 2021 at 9:18 PM Hans de Goede wrote:
>> On 1/18/21 2:34 PM, Mark Brown wrote:
>>> On Mon, Jan 18, 2021 at 02:13:50PM +0100, Hans de Goede wrote:
>>>
>>>> More in general I'm not aw
Hi,
On 3/10/21 9:55 PM, Filipe Laíns wrote:
> On Wed, 2021-03-10 at 15:24 -0500, Mark Hounschell wrote:
>>
>> That is correct, I don't have any buttons bound to keyboard events. With
>> the original patch the G4(forward) and G5(Backward) buttons work in a
>> browser. I guess G7, G8, and G9 butto
801 - 900 of 2701 matches
Mail list logo
