Re: [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 2:02 PM, Mark Brown wrote: > On Sun, Jan 17, 2021 at 10:22:50PM +0100, Hans de Goede wrote: > >> +/* >> + * Some DSDTs wrongly declare the IRQ trigger-type as >> IRQF_TRIGGER_FALLING >> + * The IRQ line will stay low when a new IRQ eve

Re: [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 2:34 PM, Mark Brown wrote: > On Mon, Jan 18, 2021 at 02:13:50PM +0100, Hans de Goede wrote: > >> More in general I'm not aware of any (recent-ish) x86 GPIO controllers >> not being able to do active low interrupts. In theory we could hit this >> code p

Re: [PATCH v1 1/2] ACPI: scan: Rearrange memory allocation in acpi_device_add()

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 4:16 PM, Rafael J. Wysocki wrote: > On Sat, Jan 16, 2021 at 1:37 PM Hans de Goede wrote: >> >> Hi, >> >> On 1/14/21 7:46 PM, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> The upfront allocation of n

Re: [PATCH v1 1/2] ACPI: scan: Rearrange memory allocation in acpi_device_add()

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 4:32 PM, Andy Shevchenko wrote: > On Mon, Jan 18, 2021 at 04:16:16PM +0100, Rafael J. Wysocki wrote: >> On Sat, Jan 16, 2021 at 1:37 PM Hans de Goede wrote: >>> On 1/14/21 7:46 PM, Rafael J. Wysocki wrote: > > ... > >>> When I have cases like

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 4:23 PM, andriy.shevche...@linux.intel.com wrote: > On Mon, Jan 18, 2021 at 02:51:30PM +, Barnabás Pőcze wrote: >> 2021. január 18., hétfő 14:51 keltezéssel, Andy Shevchenko írta: >> >>> On Mon, Jan 18, 2021 at 11:12:34AM +, Barnabás Pőcze wrote: 2021. január 18., hétfő

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 5:00 PM, Daniel Scally wrote: > > On 18/01/2021 15:48, andriy.shevche...@linux.intel.com wrote: >> On Mon, Jan 18, 2021 at 04:32:54PM +0100, Hans de Goede wrote: >>> On 1/18/21 4:23 PM, andriy.shevche...@linux.intel.com wrote: >> ... >> >>

Re: [PATCH v6 16/16] platform/surface: aggregator: fix a kernel-doc markup

2021-01-18 Thread Hans de Goede
Hi, On 1/14/21 9:04 AM, Mauro Carvalho Chehab wrote: > A function has a different name between their prototype > and its kernel-doc markup: > > ../drivers/platform/surface/aggregator/ssh_request_layer.c:1065: > warning: expecting prototype for ssh_rtl_tx_start(). Prototype was for > ssh_r

Re: [PATCH] platform/surface: aggregator: Fix kernel-doc references

2021-01-18 Thread Hans de Goede
Hi, On 1/14/21 4:08 PM, Maximilian Luz wrote: > Both, ssh_rtl_rx_start() and ssh_rtl_tx_start() functions, do not exist > and have been consolidated into ssh_rtl_start(). Nevertheless, > kernel-doc references the former functions. Replace those references > with references to ssh_rtl_start(). > >

Re: [PATCH] sony-laptop: Remove unneeded semicolon

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 2:01 AM, Yue Zou wrote: > Remove a superfluous semicolon after function definition. > > Signed-off-by: Yue Zou Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review

Re: linux-next: Fixes tag needs some work in the drivers-x86-fixes tree

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 8:39 PM, Stephen Rothwell wrote: > Hi all, > > On Tue, 19 Jan 2021 06:27:58 +1100 Stephen Rothwell > wrote: >> >> In commit >> >> 99d53ba0d0d9 ("platform/x86: hp-wmi: Don't log a warning on >> HPWMI_RET_UNKNOWN_COMMAND errors") >> >> Fixes tag >> >> Fixes: 81c93798ef3e ("pla

Re: [PATCH] cfg80211: Fix "suspicious RCU usage in wiphy_apply_custom_regulatory" warning/backtrace

2021-01-18 Thread Hans de Goede
Hi, On 1/5/21 10:24 AM, Peer, Ilan wrote: > Hi, > >> -Original Message----- >> From: Hans de Goede >> Sent: Monday, January 04, 2021 19:07 >> To: Johannes Berg ; David S . Miller >> ; Jakub Kicinski ; Rojewski, >> Cezary ; Pierre-Louis Bossart >

Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-19 Thread Hans de Goede
Hi, On 1/19/21 5:33 PM, Limonciello, Mario wrote: -Original Message- From: Yuan, Perry Sent: Tuesday, January 12, 2021 11:18 To: oder_ch...@realtek.com; pe...@perex.cz; ti...@suse.com; hdego...@redhat.com; mgr...@linux.intel.com Cc: lgirdw...@gmail.com; broo.

Re: [PATCH v6 0/3] AMS, Collision Avoidance, and Protocol Error

2021-01-15 Thread Hans de Goede
Hi All, On 1/14/21 3:50 PM, Kyle Tso wrote: > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyle...@google.com > > "usb: typec: tcpm: AMS and Collision Avoidance" > - removed the signed-off > - modified the coding style suggested from Heikki > - added FR_SWAP AMS handling > > "usb: ty

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-28 Thread Hans de Goede
Hi, On 12/28/20 1:21 PM, Mark Brown wrote: > On Sun, Dec 27, 2020 at 10:12:19PM +0100, Hans de Goede wrote: >> The Linux Arizona driver uses the MFD framework to create several >> sub-devices for the Arizona codec and then uses a driver per function. >> >> The jack-det

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-29 Thread Hans de Goede
Hi, On 12/29/20 2:06 PM, Charles Keepax wrote: > On Mon, Dec 28, 2020 at 04:28:07PM +, Mark Brown wrote: >> On Mon, Dec 28, 2020 at 02:16:04PM +0100, Hans de Goede wrote: >> >>> And more in general AFAIK extcon is sort of deprecated and it is >>> not advise

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-29 Thread Hans de Goede
Hi, On 12/29/20 4:08 PM, Mark Brown wrote: > On Tue, Dec 29, 2020 at 02:57:38PM +0100, Hans de Goede wrote: >> On 12/29/20 2:06 PM, Charles Keepax wrote: > >>> I would agree with Mark though that if extcon exists for external >>> connectors it seems odd that au

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-29 Thread Hans de Goede
Hi, On 12/29/20 4:15 PM, Mark Brown wrote: > On Tue, Dec 29, 2020 at 03:06:35PM +, Charles Keepax wrote: > >> There is maybe more argument for porting the Arizona code across >> anyways, since for a long time Android didn't properly support extcon >> either. It supported the earlier out of tr

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-30 Thread Hans de Goede
Hi, On 12/29/20 5:51 PM, Richard Fitzgerald wrote: > > > On 29/12/2020 15:40, Hans de Goede wrote: >> Hi, >> >> On 12/29/20 4:15 PM, Mark Brown wrote: >>> On Tue, Dec 29, 2020 at 03:06:35PM +, Charles Keepax wrote: >>> >>>> There i

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-30 Thread Hans de Goede
Hi, On 12/30/20 12:23 PM, Richard Fitzgerald wrote: > On 30/12/2020 11:04, Hans de Goede wrote: >> Hi, >> >> On 12/29/20 5:51 PM, Richard Fitzgerald wrote: >>> >>> >>> On 29/12/2020 15:40, Hans de Goede wrote: >>>> Hi, >>>> &

[PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-27 Thread Hans de Goede
to report jack-detect state, so that jack-detection works with standard Linux userspace. The extcon-arizona code already depends on (waits for with -EPROBE_DEFER) the snd_card being registered by the machine driver, so this does not cause any ordering issues. Signed-off-by: Hans de Goede

[PATCH 04/14] mfd: arizona: Allow building arizona MFD-core as module

2020-12-27 Thread Hans de Goede
the arizona MFD-core can be built as a module. This is especially useful on x86 platforms with a WM5102 codec, this allows the arizona MFD driver necessary for the WM5102 codec to be enabled in generic distro-kernels without growing the base kernel-image size. Signed-off-by: Hans de Goede

[PATCH 03/14] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2020-12-27 Thread Hans de Goede
Hartmann, combined with insights in things like the speaker GPIO from the android-x86 android port for the Lenovo Yoga Tablet 2 1051F/L [1]. [1] https://github.com/Kitsune/Android_Yoga_Tablet_2-1051F_Kernel Cc: Christian Hartmann Signed-off-by: Hans de Goede --- drivers/mfd/arizona-spi.c

[PATCH 05/14] extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged

2020-12-27 Thread Hans de Goede
2 steps when arizona_hpdet_irq runs after the jack has been unplugged. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index aae8

[PATCH 06/14] extcon: arizona: Fix various races on driver unbind

2020-12-27 Thread Hans de Goede
various theoretically possible races caused by the wrong ordering inside arizona_extcon_remove(), this fixes the ordering fixing all possible races, including the reported oops. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 40 + 1 file changed

[PATCH 09/14] extcon: arizona: Add arizona_set_extcon_state() helper

2020-12-27 Thread Hans de Goede
All the callers of extcon_set_state_sync() log an error on failure, without doing any further error-handling (as there is nothing they can do about the error). Factor this out into a helper to remove some duplicate code. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 47

[PATCH 14/14] ASoC: Intel: bytcr_wm5102: Add jack detect support

2020-12-27 Thread Hans de Goede
to the extcon-arizona driver through the shared arizona data struct. The extcon-arizona code already depends on (waits for with -EPROBE_DEFER) the snd_card being registered by the machine driver, so this does not cause any ordering issues. Signed-off-by: Hans de Goede --- sound/soc/intel/boards

[PATCH 12/14] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr()

2020-12-27 Thread Hans de Goede
. and 2. still have their IPC IRQ at index 0 rather then 5 Add a DMI quirk table to check for the few known models with this issue, so that the right IPC IRQ index is used on these systems. Signed-off-by: Hans de Goede --- sound/soc/intel/common/soc-intel-quirks.h | 25 +++ 1

[PATCH 02/14] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1")

2020-12-27 Thread Hans de Goede
shared probing code runs. Add a doftdep for this to both modules to ensure that this requirement is met. Note this mirrors the existing MODULE_SOFTDEP("pre: wm8994_regulator") in the wm8994 code, which has a similar init sequence. Signed-off-by: Hans de Goede --- drivers/mfd/arizona

[PATCH 08/14] extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") call

2020-12-27 Thread Hans de Goede
The initial value of the GPIO should match the info->micd_modes[0].gpio value. arizona_extcon_probe() already stores the necessary flag in a mode variable, but instead of passing mode as flags to the gpiod_get() it was using a hardcoded GPIOD_OUT_LOW. Signed-off-by: Hans de Goede --- driv

[PATCH 10/14] extcon: arizona: Also report jack state through snd_soc_jack_report()

2020-12-27 Thread Hans de Goede
the ASoC jack so that jack-detection works with standard Linux userspace. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index

[PATCH 00/14] MFD/extcon/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2020-12-27 Thread Hans de Goede
Hi All, This patch series adds support for Intel Bay Trail based device which use a WM5102 codec for audio output/input. This was developed and tested on a Lenovo Yoga Tablet 1051L. This series consists of 3 parts: 1. Arizona MFD drv patches for ACPI bindings, better jack-detect support and mi

[PATCH 07/14] extcon: arizona: Fix modalias

2020-12-27 Thread Hans de Goede
Fix the modalias so that the driver will be loaded automatically. The module's name is "extcon-arizona", following other extcon module-names. But the driver's and platform-device's name is "arizona-extcon" and the modalias must match that. Signed-off-by: Hans d

[PATCH 13/14] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102

2020-12-27 Thread Hans de Goede
hine driver and ACPI hooks, the BYT-CR detection quirk which these devices need will be added in a separate patch. Co-authored-by: Pierre-Louis Bossart Signed-off-by: Pierre-Louis Bossart Signed-off-by: Hans de Goede --- sound/soc/intel/boards/Kconfig| 12 + sound/soc/intel/

[PATCH 11/14] extcon: arizona: Use ASoC jack input-device when available

2020-12-27 Thread Hans de Goede
me headset. This relies on the machine-driver setting up the jack-input-device to report the EV_KEY key-codes configured in arizona_pdata.micd_ranges, before registering it. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 46 +++-- 1 file changed, 32

Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-24 Thread Hans de Goede
Hi, On 3/22/21 10:38 AM, Perry Yuan wrote: > From: Perry Yuan > > add support for Dell privacy driver for the Dell units equipped > hardware privacy design, which protect users privacy of audio and > camera from hardware level. Once the audio or camera privacy mode > activated, any applications

Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-24 Thread Hans de Goede
Hi, On 3/24/21 12:19 PM, Hans de Goede wrote: > Hi, > > On 3/22/21 10:38 AM, Perry Yuan wrote: >> From: Perry Yuan >> >> add support for Dell privacy driver for the Dell units equipped >> hardware privacy design, which protect users privacy of audio and >&g

[GIT PULL] platform-drivers-x86 for 5.12-2

2021-03-24 Thread Hans de Goede
: thinkpad_acpi: Allow the FnLock LED to change state Hans de Goede (9): platform/x86: thinkpad_acpi: Disable DYTC CQL mode around switching to balanced mode platform/x86: dell-wmi-sysman: Fix crash caused by calling kset_unregister twice platform/x86: dell-wmi-sysman: Fix possible NULL

Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-25 Thread Hans de Goede
Hi, On 3/25/21 8:52 AM, Yuan, Perry wrote: > Hi Hans. > >> -Original Message----- >> From: Hans de Goede >> Sent: Wednesday, March 24, 2021 3:40 AM >> To: Pierre-Louis Bossart; Yuan, Perry; po...@protonmail.com; >> oder_ch...@realtek.com; pe

Re: [PATCH v4 2/2] ASoC: rt715:add micmute led state control supports

2021-03-25 Thread Hans de Goede
Hi, On 3/25/21 3:11 PM, Yuan, Perry wrote: > Hi Hans > >> -Original Message----- >> From: Hans de Goede >> Sent: Monday, March 22, 2021 11:02 PM >> To: Jaroslav Kysela; Yuan, Perry; Mark Brown; pierre- >> louis.boss...@linux.intel.com; Limonciello, Mario

Re: [PATCH v3 2/8] MAINTAINERS: Add entry for devm helpers

2021-03-23 Thread Hans de Goede
n > S: Maintained > W: http://lanana.org/docs/device-list/index.html > > +DEVICE RESOURCE MANAGEMENT HELPERS > +M: Hans de Goede > +R: Matti Vaittinen > +S: Maintained > +F: include/linux/devm-helpers.h > + > DEVICE-MAPPER (LVM) > M: Alasdair Kergon > M: Mike Snitzer >

Re: [PATCH v3 1/8] workqueue: Add resource managed version of delayed work init

2021-03-23 Thread Hans de Goede
verision of delayed work initialization. This will also > help drivers to avoid mixing manual and devm based unwinding when other > resources are handled by devm. > > Signed-off-by: Matti Vaittinen Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans >

Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init

2021-03-23 Thread Hans de Goede
ted. > > Signed-off-by: Matti Vaittinen Thanks, patch looks good to me: Reviewed-by: Hans de Goede Note that this is not just a cleanup, it also actually fixes a couple of driver-unbind races where the work was stopped before the IRQ is free-ed, so there is a race where the wo

Re: [PATCH] Input: i8042 - fix Pegatron C15B ID entry

2021-03-23 Thread Hans de Goede
2_dmi_noselftest_table[0].matches') > > Add the missing separator between the two. > > Fixes: b5d6e7ab7fe7 ("Input: i8042 - add ASUS Zenbook Flip to noselftest > list") > Signed-off-by: Arnd Bergmann Thanks, patch looks good to me: Reviewed-by: Hans de Goede Re

Re: [PATCH v3 5/8] platform/x86: gpd pocket fan: Clean-up by using managed work init

2021-03-23 Thread Hans de Goede
All testing is appreciated. > > Signed-off-by: Matti Vaittinen Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > Changelog from RFCv2: > - RFC dropped. No functional changes. > > drivers/platform/x86/gpd-pocket-fan.c | 17 ++---

Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-23 Thread Hans de Goede
Hi, On 3/23/21 7:57 PM, Pierre-Louis Bossart wrote: > Minor comments below. > +int __init dell_privacy_acpi_init(void) > > is the __init necessary? You call this routine from another which already has > this qualifier. Yes this is necessary, all functions which are only used during module_load

Re: [PATCH] platform/x86: asus-wmi: Disable fn-lock mode by default

2021-03-23 Thread Hans de Goede
Hi, On 3/16/21 11:17 PM, Luca Stefani wrote: > * On recent ZenBooks the fn-lock is disabled > by default on boot while running Windows. > > * Follow the same paradigm also here. > > Signed-off-by: Luca Stefani This will be a behavioral change for many users where their F-keys will now all of

Re: [PATCH] platform: x86: Typo fix in the file classmate-laptop.c

2021-03-23 Thread Hans de Goede
Hi, On 3/17/21 9:43 AM, Bhaskar Chowdhury wrote: > > s/derefence/dereference/ > > Signed-off-by: Bhaskar Chowdhury Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Not

Re: [PATCH] platform: mellanox: Typo fix in the file mlxbf-bootctl.c

2021-03-23 Thread Hans de Goede
Hi, On 3/17/21 10:56 AM, Bhaskar Chowdhury wrote: > > s/progamming/programming/ > > Signed-off-by: Bhaskar Chowdhury Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans N

Re: [PATCH] asus-laptop: fix kobj_to_dev.cocci warnings

2021-03-23 Thread Hans de Goede
Hi, On 3/17/21 1:00 PM, Julia Lawall wrote: > From: kernel test robot > > Use kobj_to_dev() instead of container_of() > > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci > > CC: Denis Efremov > Reported-by: kernel test robot > Signed-off-by: kernel test robot > Signed-off-by: Julia L

Re: [V2,1/1] platform/x86: add support for Advantech software defined button

2021-03-23 Thread Hans de Goede
try to take a look at it soon. Regards, Hans > > Hans de Goede 於 2021年3月19日 週五 上午12:21寫道: >> >> Hi, >> >> On 3/12/21 9:11 AM, YingChieh Ho wrote: >>> From: "Andrea.Ho" >>> >>> Advantech sw_button is a ACPI event trigger but

Re: [PATCH 1/2] platform/x86: intel_pmt_class: Initial resource to 0

2021-03-23 Thread Hans de Goede
Hi, On 3/17/21 3:44 AM, David E. Box wrote: > Initialize the struct resource in intel_pmt_dev_register to zero to avoid a > fault should the char *name field be non-zero. > > Signed-off-by: David E. Box Thank you for your patch-series, I've applied the series to my review-hans branch: https://g

Re: [PATCH 1/2] platform/x86: intel_pmt_class: Initial resource to 0

2021-03-23 Thread Hans de Goede
Hi, On 3/23/21 6:29 PM, David E. Box wrote: > On Tue, 2021-03-16 at 19:44 -0700, David E. Box wrote: >> Initialize the struct resource in intel_pmt_dev_register to zero to >> avoid a >> fault should the char *name field be non-zero. > > Hi Hans. Can these 2 patches be pulled as fixes for 5.12? Th

Re: [PATCH v2] platform/x86: asus-wmi: Add param to turn fn-lock mode on by default

2021-03-23 Thread Hans de Goede
Hi, On 3/23/21 9:25 PM, Luca Stefani wrote: > * On recent ZenBooks the fn-lock is disabled > by default on boot while running Windows. > > * Add a module param ( fnlock_default ) that allows > changing the default at probe time > > Signed-off-by: Luca Stefani > --- > drivers/platform/x86/a

Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init

2021-03-24 Thread Hans de Goede
Hi, On 3/24/21 6:02 AM, Matti Vaittinen wrote: > Hello Chanwoo, Greg, > > Thanks for the review. > > On Wed, 2021-03-24 at 11:09 +0900, Chanwoo Choi wrote: >> Hi, >> >> Need to fix the work as following: >> s/extconn/extcon >> >> And I'd like you to use the more correct patch title like the >> f

Re: [PATCH 1/2] extcon: extcon-gpio: Log error if work-queue init fails

2021-03-24 Thread Hans de Goede
Hi, On 3/24/21 10:21 AM, Matti Vaittinen wrote: > Add error print for probe failure when resource managed work-queue > initialization fails. > > Signed-off-by: Matti Vaittinen > Suggested-by: Chanwoo Choi > --- > drivers/extcon/extcon-gpio.c | 4 +++- > 1 file changed, 3 insertions(+), 1 delet

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-04 Thread Hans de Goede
Hi, On 2/16/21 8:24 AM, Perry Yuan wrote: > Hi Hans: > > On 2021/1/13 2:37, Hans de Goede wrote: >> Hi, >> >> I know there already is a v3 out and I will try to get around to reviewing >> that soon, still 1 remark about the discussion surrounding v2: >>

Re: [PATCH v3 0/6] platform/surface: Add Surface Aggregator device registry

2021-03-04 Thread Hans de Goede
Hi, On 2/12/21 12:54 PM, Maximilian Luz wrote: > The Surface System Aggregator Module (SSAM) subsystem provides various > functionalities, which are separated by spreading them across multiple > devices and corresponding drivers. Parts of that functionality / some of > those devices, however, can

Re: [PATCH v2 4/4] platform/surface: Add platform profile driver

2021-03-04 Thread Hans de Goede
Hi, On 2/11/21 9:17 PM, Maximilian Luz wrote: > Add a driver to provide platform profile support on 5th- and later > generation Microsoft Surface devices with a Surface System Aggregator > Module. On those devices, the platform profile can be used to influence > cooling behavior and power consumpt

Re: [PATCH] platform/x86: fix typo in Kconfig

2021-03-04 Thread Hans de Goede
Hi, On 2/16/21 10:36 PM, Petr Vaněk wrote: > uses by -> used by > > Signed-off-by: Petr Vaněk Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in m

Re: [PATCH] x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

2021-03-04 Thread Hans de Goede
Hi, On 2/19/21 6:28 PM, Justin Ernst wrote: > commit c9624cb7db1c ("x86/platform/uv: Update sysfs documentation") > > misplaced the first line of a codeblock section, causing the reported > warning message: > Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected > indentation. >

Re: [PATCH] x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

2021-03-04 Thread Hans de Goede
Hi, On 3/4/21 12:59 PM, Borislav Petkov wrote: > On Thu, Mar 04, 2021 at 12:55:49PM +0100, Hans de Goede wrote: >> Since this documentation documents the interface exposed by: >> drivers/platform/x86/uv_sysfs.c >> >> I've applied this patch to the pdx86 tree

Re: [PATCH v3 2/2] platform/x86: hp-wmi: add platform profile support

2021-03-04 Thread Hans de Goede
Hi, On 2/21/21 11:13 PM, Elia Devito wrote: > Implement support for cool, balanced and performance thermal profile > > Signed-off-by: Elia Devito > --- > the "quiet" profile will be implemented with a further patch > > v2: added platform_profile_remove() missing call > v3: apply Barnabás sugges

Re: [PATCH 1/2] platform/x86: hp-wmi: rename "thermal policy" to "thermal profile"

2021-03-04 Thread Hans de Goede
Hi, On 2/21/21 10:02 PM, Elia Devito wrote: > rename "thermal policy" with the more appropriate term "thermal profile" > > Signed-off-by: Elia Devito Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drive

Re: [PATCH] platform/x86: Switch to using the new API kobj_to_dev()

2021-03-04 Thread Hans de Goede
Hi, On 2/22/21 8:00 AM, Yang Li wrote: > fixed the following coccicheck: > ./drivers/platform/x86/ideapad-laptop.c:523:60-61: WARNING opportunity > for kobj_to_dev() > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Patch does not apply, please resend it rebased on the latest pdx86/for-nex

Re: [PATCH v3 0/6] Introduce intel_skl_int3472 module

2021-03-04 Thread Hans de Goede
Hi, On 2/22/21 2:07 PM, Daniel Scally wrote: > v1 for this series was originally 14-18 of this series: > https://lore.kernel.org/linux-media/20201130133129.1024662-1-djrsca...@gmail.com/T/#m91934e12e3d033da2e768e952ea3b4a125ee3e67 > > v2 was here: > https://lore.kernel.org/platform-driver-x86/202

Re: [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1 Tablet Gen 2

2021-03-04 Thread Hans de Goede
Hi, On 2/22/21 3:15 PM, Alban Bedel wrote: > Like a few other system the Lenovo ThinkPad X1 Tablet Gen 2 miss the > HEBC method, which prevent the power button from working. Add a quirk > to enable the button array on this system family and fix the power > button. > > Signed-off-by: Alban Bedel

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-04 Thread Hans de Goede
Hi, On 3/4/21 11:11 AM, Andy Shevchenko wrote: > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > wrote: >> >> From: Henning Schild >> >> This mainly implements detection of these devices and will allow >> secondary drivers to work on such machines. >> >> The identification is DMI-based with a ve

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-04 Thread Hans de Goede
Hi, On 3/2/21 5:33 PM, Henning Schild wrote: > +static inline u32 simatic_ipc_get_station_id(u8 *data) > +{ > + u32 station_id = SIMATIC_IPC_INVALID_STATION_ID; > + int i; > + struct { > + u8 type; /* type (0xff = binary) */ > + u8 len;

Re: [PATCH v1] platform: x86: ACPI: Get rid of ACPICA message printing

2021-03-04 Thread Hans de Goede
Hi, On 2/24/21 7:41 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > A few x86 platform drivers use ACPI_DEBUG_PRINT() or ACPI_EXCEPTION() > for printing messages, but that is questionable, because those macros > belong to ACPICA and they should not be used elsewhere. In addition, > A

Re: [PATCH] WMI: asus: Reduce G14 and G15 match to min product name

2021-03-04 Thread Hans de Goede
Hi, On 2/27/21 11:20 AM, Luke D Jones wrote: > This patch reduces the product match for GA401 series laptops to > the minimum string required. > > The GA401 series of laptops has a lengthy list of product > variations in the 2020 series and the 2021 series refresh > is using the same base product

Re: [V1,1/1] platform/x86: add support for Advantech software defined button

2021-03-04 Thread Hans de Goede
Hi Andrea, On 3/2/21 7:44 AM, andrea...@advantech.com.tw wrote: > From: "Andrea.Ho" > > Advantech sw_button is a ACPI event trigger button. > > With this driver, we can report KEY_EVENT on the > Advantech Tabletop Network Appliances products and it has been > tested in FWA1112VC. > > Add the s

Re: [PATCH] platform/surface: aggregator: Make SSAM_DEFINE_SYNC_REQUEST_x define static functions

2021-03-04 Thread Hans de Goede
Hi, On 3/4/21 8:05 PM, Maximilian Luz wrote: > The SSAM_DEFINE_SYNC_REQUEST_x() macros are intended to reduce > boiler-plate code for SSAM request definitions by defining a wrapper > function for the specified request. The client device variants of those > macros, i.e. SSAM_DEFINE_SYNC_REQUEST_CL_

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Hans de Goede
Hi, On 3/5/21 4:42 PM, Andy Shevchenko wrote: > On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede wrote: >> On 3/4/21 11:11 AM, Andy Shevchenko wrote: >>> On Thu, Mar 4, 2021 at 8:36 AM Henning Schild >>> wrote: > > ... > >>>>

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Hans de Goede
Hi, On 3/5/21 5:25 PM, Andy Shevchenko wrote: > On Fri, Mar 5, 2021 at 6:14 PM Hans de Goede wrote: >> On 3/5/21 4:42 PM, Andy Shevchenko wrote: >>> On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede wrote: >>>> On 3/4/21 11:11 AM, Andy Shevchenko wrote: >>>&g

Re: [PATCH 00/10] platform/x86: toshiba_acpi: move acpi add/remove to device-managed routines

2021-03-30 Thread Hans de Goede
Hi, On 3/30/21 11:22 AM, Alexandru Ardelean wrote: > On Tue, Mar 30, 2021 at 11:21 AM Hans de Goede wrote: >> >> Hi Alexadru, Jonathan, >> >> On 3/24/21 1:55 PM, Alexandru Ardelean wrote: >>> This changeset tries to do a conversion of the toshiba_acpi d

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-30 Thread Hans de Goede
Hi, On 3/22/21 5:02 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns that intel_dp_check_mst_status() has a local array of > fourteen bytes and passes the last four bytes into a function that > expects a six-byte array: > > drivers/gpu/drm/i915/display/intel_dp.c: In function >

Re: [GIT PULL] Immutable branch between MFD and Extcon due for the v5.13 merge window

2021-03-22 Thread Hans de Goede
between MFD and Extcon due for the v5.13 merge window > > -------- > Hans de Goede (6): > mfd: arizona: Drop arizona-extcon cells > extcon: arizona: Fix some issues when HPDET IRQ fires after the jack > has been unplugged > extcon: arizona: Fix various

Re: [PATCH v4 2/2] ASoC: rt715:add micmute led state control supports

2021-03-22 Thread Hans de Goede
Hi, On 3/22/21 3:37 PM, Jaroslav Kysela wrote: > Dne 22. 03. 21 v 10:25 Yuan, Perry napsal(a): >> Hi Mark: >> >>> -Original Message- >>> From: Mark Brown >>> Sent: Tuesday, March 9, 2021 1:24 AM >>> To: Yuan, Perry >>> Cc: po...@protonmail.com; pierre-louis.boss...@linux.intel.com; >>> od

Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries

2021-03-15 Thread Hans de Goede
Hi, On 3/15/21 3:58 PM, Henning Schild wrote: > Introduce a global variable to remember the matching entry for later > printing. Also having a callback allows to stop matching after the first > hit. > > Signed-off-by: Henning Schild > --- > drivers/platform/x86/pmc_atom.c | 26 +

Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries

2021-03-15 Thread Hans de Goede
Hi, On 3/15/21 6:00 PM, Henning Schild wrote: > Am Mon, 15 Mar 2021 17:31:49 +0100 > schrieb Hans de Goede : > >> Hi, >> >> On 3/15/21 3:58 PM, Henning Schild wrote: >>> Introduce a global variable to remember the matching entry for later >>> pr

Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries

2021-03-16 Thread Hans de Goede
egards, Hans > Am Mon, 15 Mar 2021 19:01:13 +0100 > schrieb Hans de Goede : > >> Hi, >> >> On 3/15/21 6:00 PM, Henning Schild wrote: >>> Am Mon, 15 Mar 2021 17:31:49 +0100 >>> schrieb Hans de Goede : >>> >>>> Hi, >>>

Re: [PATCH] iio: accel: da280: Drop unnecessarily used braces

2021-03-29 Thread Hans de Goede
Hi, On 3/29/21 12:52 PM, Andy Shevchenko wrote: > +Cc: Hans (just for your opinion) > > On Sun, Mar 28, 2021 at 10:40 PM Andy Shevchenko > wrote: >> On Sunday, March 28, 2021, Mugilraj Dhavachelvan >> wrote: >>> >>> As per linux kernel coding style braces are not needed for single >>> statemen

Re: [PATCH 06/12] platform/x86: intel_cht_int33fe_microb: Constify the software node

2021-03-29 Thread Hans de Goede
Hi, On 3/29/21 12:50 PM, Heikki Krogerus wrote: > Additional device properties are always just a part of a > software fwnode. If the device properties are constant, the > software node can also be constant. > > Signed-off-by: Heikki Krogerus > Cc: Hans de Goede Thanks, patc

Re: [PATCH 07/12] i2c: cht-wc: Constify the software node

2021-03-29 Thread Hans de Goede
Hi, On 3/29/21 12:50 PM, Heikki Krogerus wrote: > Additional device properties are always just a part of a > software fwnode. If the device properties are constant, the > software node can also be constant. > > Signed-off-by: Heikki Krogerus > Cc: Hans de Goede Thanks, patc

Re: [PATCH 00/10] platform/x86: toshiba_acpi: move acpi add/remove to device-managed routines

2021-03-30 Thread Hans de Goede
Hi Alexadru, Jonathan, On 3/24/21 1:55 PM, Alexandru Ardelean wrote: > This changeset tries to do a conversion of the toshiba_acpi driver to use > only device-managed routines. The driver registers as a singleton, so no > more than one device can be registered at a time. > > My main intent here i

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-26 Thread Hans de Goede
Hi, On 3/26/21 10:55 AM, Henning Schild wrote: > Am Thu, 18 Mar 2021 12:45:01 +0100 > schrieb Hans de Goede : > >> Hi, >> >> On 3/18/21 12:30 PM, Enrico Weigelt, metux IT consult wrote: >>> On 17.03.21 21:03, Hans de Goede wrote: >>> >>>

Re: [PATCH] platform/x86: intel_chtdc_ti_pwrbtn: Fix missing IRQF_ONESHOT as only threaded handler

2021-04-15 Thread Hans de Goede
Hi, On 4/15/21 11:14 AM, zhuguangqin...@gmail.com wrote: > From: Guangqing Zhu > > Coccinelle noticed: > drivers/platform/x86/intel_chtdc_ti_pwrbtn.c:59:7-32: ERROR: Threaded IRQ > with no primary handler requested without IRQF_ONESHOT > > Signed-off-by: Guangqing Zhu So I was wondering why

Re: [PATCH v7 2/2] ASoC: rt715:add micmute led state control supports

2021-04-12 Thread Hans de Goede
Hi Perry, On 4/12/21 11:19 AM, Perry Yuan wrote: > From: Perry Yuan > > Some new Dell system is going to support audio internal micphone > privacy setting from hardware level with micmute led state changing > When micmute hotkey pressed by user, soft mute will need to be enabled > firstly in cas

Re: [PATCH v6] platform/x86: intel_pmc_core: export platform global reset bits via etr3 sysfs file

2021-04-13 Thread Hans de Goede
ing and the file is set to read-only mode via is_visible > handler. > > The register in MMIO space is defined for Cannon Lake and newer PCHs. > > Cc: Hans de Goede > Cc: David E Box > Reviewed-by: Andy Shevchenko > Signed-off-by: Tamar Mashiah > Signed-off-by: Tomas Winkl

Re: [PATCH v5] platform/x86: add Gigabyte WMI temperature driver

2021-04-13 Thread Hans de Goede
Hi, On 4/12/21 2:35 PM, Thomas Weißschuh wrote: > Tested with > * X570 I Aorus Pro Wifi (rev 1.0) > * B550M DS3H > * B550 Gaming X V2 (rev.1.x) > * Z390 I AORUS PRO WIFI (rev. 1.0) > > Those mainboards contain an ITE chips for management and > monitoring. > > They could also be handled by driver

Re: [PATCH v2] platform/x86: pmc_atom: Match all Beckhoff Automation baytrail boards with critclk_systems DMI table

2021-04-13 Thread Hans de Goede
Hi, On 4/12/21 3:30 PM, Steffen Dirkwinkel wrote: > From: Steffen Dirkwinkel > > pmc_plt_clk* clocks are used for ethernet controllers, so need to stay > turned on. This adds the affected board family to critclk_systems DMI > table, so the clocks are marked as CLK_CRITICAL and not turned off. >

Re: [PATCH v7 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-04-13 Thread Hans de Goede
Hi, On 4/12/21 11:19 AM, Perry Yuan wrote: > From: Perry Yuan > > add support for Dell privacy driver for the Dell units equipped > hardware privacy design, which protect users privacy of audio and > camera from hardware level. Once the audio or camera privacy mode > activated, any applications

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2021-04-14 Thread Hans de Goede
Hi, On 4/14/21 3:51 PM, Stephen Rothwell wrote: > Hi all, > > Commit > > ff57cfaa3d68 ("platform/x86: pmc_atom: Match all Beckhoff Automation > baytrail boards with critclk_systems DMI table") > > is missing a Signed-off-by from its committer. My bad I somehow forgot to pass -s to "git am",

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-06 Thread Hans de Goede
Hi, On 4/2/21 5:21 PM, Tomas Winkler wrote: > From: Tamar Mashiah > > During PCH (platform/board) manufacturing process a global reset > has to be induced in order for configuration changes take the effect > upon following platform reset. > This setting was commonly done by accessing PMC registe

Re: [PATCH 06/12] platform/x86: intel_cht_int33fe_microb: Constify the software node

2021-04-06 Thread Hans de Goede
Hi, On 4/6/21 9:40 PM, Wolfram Sang wrote: > >> What is the plan for merging this patch / this series ? > > I'll take the series via I2C. Ok, that works for me. Regards, Hans

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-07 Thread Hans de Goede
Hi, On 4/7/21 8:51 AM, Winkler, Tomas wrote: >>> >>> During PCH (platform/board) manufacturing process a global reset has >>> to be induced in order for configuration changes take the effect upon >>> following platform reset. >>> This setting was commonly done by accessing PMC registers via /dev/m

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-07 Thread Hans de Goede
Hi, On 4/7/21 11:31 AM, Winkler, Tomas wrote: > > >> Hi, >> >> On 4/7/21 8:51 AM, Winkler, Tomas wrote: > > During PCH (platform/board) manufacturing process a global reset has > to be induced in order for configuration changes take the effect > upon following platform reset. >>>

[GIT PULL] platform-drivers-x86 for 5.12-3

2021-04-07 Thread Hans de Goede
caused by recent intel-hid driver changes. The following is an automated git shortlog grouped by driver: intel-hid: - Fix spurious wakeups caused by tablet-mode events during suspend Hans de Goede (1): platform/x86: intel

Re: [PATCH v3] platform/x86: asus-wmi: Add param to turn fn-lock mode on by default

2021-04-07 Thread Hans de Goede
Hi, On 3/23/21 10:01 PM, Luca Stefani wrote: > * On recent ZenBooks the fn-lock is disabled > by default on boot while running Windows. > > * Add a module param ( fnlock_default ) that allows > changing the default at probe time > > Signed-off-by: Luca Stefani Thank you for your patch, I've

Re: [PATCH] platform/surface: clean up a variable in surface_dtx_read()

2021-04-07 Thread Hans de Goede
Hi, On 3/26/21 3:06 PM, Maximilian Luz wrote: > On 3/26/21 1:28 PM, Dan Carpenter wrote: >> The "&client->ddev->lock" and "&ddev->lock" are the same thing.  Let's >> use "&ddev->lock" consistently. >> >> Signed-off-by: Dan Carpenter > > Good catch, thanks! > > Reviewed-by: Maximilian Luz Than

<    3   4   5   6   7   8   9   10   11   12   >