Hi,
On 1/26/21 6:22 PM, Maximilian Luz wrote:
> The braces of the unlikely() macro inside the if condition only cover
> the subtraction part, not the whole statement. This causes the result of
> the subtraction to be converted to zero or one. While that still works
> in this context, it causes sta
Hi,
On 1/26/21 9:55 PM, David E. Box wrote:
> Fix error in Kconfig that exposed INTEL_PMT_CLASS as a user selectable
> option. It is already selected by INTEL_PMT_TELEMETRY and
> INTEL_PMT_CRASHLOG which are user selectable.
>
> Fixes: e2729113ce66 ("platform/x86: Intel PMT class driver")
> Signe
Hi,
On 2/3/21 12:43 PM, Artem Bityutskiy wrote:
> From: Artem Bityutskiy
>
> Sapphire Rapids uncore frequency control is the same as Skylake and Ice Lake.
> Add the Sapphire Rapids CPU model number to the match array.
>
> Signed-off-by: Artem Bityutskiy
> Reviewed-by: Tony Luck
Thank you for
Hi,
On 1/29/21 7:09 PM, Linus Torvalds wrote:
> On Fri, Jan 29, 2021 at 6:54 AM Hans de Goede wrote:
>>
>> While testing 5.11-rc5 I noticed that flicker-free boot was no longer
>> flicker free,
>> when plymouth loads and tells systemd to start logging detail
Hi Linus,
On 1/29/21 7:23 PM, Hans de Goede wrote:
> Hi,
>
> On 1/29/21 7:09 PM, Linus Torvalds wrote:
>> On Fri, Jan 29, 2021 at 6:54 AM Hans de Goede wrote:
>>>
>>> While testing 5.11-rc5 I noticed that flicker-free boot was no longer
>>> flick
Hi,
On 1/29/21 9:28 PM, Linus Torvalds wrote:
> On Fri, Jan 29, 2021 at 12:02 PM Linus Torvalds
> wrote:
>>
>> It's fairly easy to work around in this in the tty layer by just
>> avoiding that function entirely, so I'll cook up a patch to do that.
>> But I'm adding the appropriate people to the p
Hi,
On 1/30/21 4:40 PM, Charles Keepax wrote:
> On Sat, Jan 23, 2021 at 01:17:20PM +0100, Hans de Goede wrote:
>> Add jack detect support by creating a jack and calling
>> snd_soc_component_set_jack to register the created jack
>> with the codec.
>>
>> Reviewed-b
Hi,
On 1/30/21 8:14 PM, Filipe Laíns wrote:
> Hans,
>
> You added support for non unifying receivers in
> 74808f9115cee2bb53e7161432959f3e87b631e4, could you please test and make sure
> this cause any breakage with your devices?
>
> AFAIK, they could only break if they have a 0x01 report which i
Hi,
On 1/29/21 6:26 PM, Mario Limonciello wrote:
> An upcoming Dell platform is causing a NULL pointer dereference
> in dell-wmi-sysman initialization. Validate that the input from
> BIOS matches correct ACPI types and abort module initialization
> if it fails.
>
> This leads to a memory leak th
Hi,
On 1/31/21 3:04 PM, Limonciello, Mario wrote:
>
>
>> -Original Message-----
>> From: Hans de Goede
>> Sent: Saturday, January 30, 2021 15:44
>> To: Limonciello, Mario; Mark Gross
>> Cc: LKML; platform-driver-...@vger.kernel.org
>> Subject: Re:
Hi,
On 2/1/21 3:36 AM, Perry Yuan wrote:
> Hi Hans.
> Could you share your the commit link after you apply this patch to your
> for-next branch?
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=for-next&id=64b0efa18f8c3b1baac369b8d74d0fdae02bc4bc
Regar
Hi,
On 2/1/21 2:34 PM, Kyle Tso wrote:
> patch v2:
> https://lore.kernel.org/linux-devicetree/20210131151832.215931-1-kyle...@google.com/
>
> Changes since v2:
> =
> usb: typec: Determine common SVDM Versions
> - rename the variable and the functions (remove the text "common")
> -
Hi,
On 2/2/21 10:32 AM, Pavel Machek wrote:
> Hi!
>
>>> Is it a regression? AFAIK it is a bug that has been there
>>> forever... My original plan was to simply wait for 5.12, so it gets
>>> full release of testing...
>>
>> It may have been a pre-existing bug which got triggered by libata
>> chang
led by quirk to
> prevent them from keeping the driver loaded if only disabled capabilities
> are found.
>
> Fixes: 4f8217d5b0ca ("mfd: Intel Platform Monitoring Technology support")
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Hi Stephen, Andy,
On 2/4/21 6:13 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/platform/x86/intel_scu_wdt.c: In function 'register_mid_wdt':
> drivers/platform/x86/intel_scu_wdt.c:
Hi all,
On 1/20/21 10:49 PM, Hans de Goede wrote:
> Hi All,
>
> Here is v4 of my series to add support for Intel Bay Trail based devices
> which use a WM5102 codec for audio output/input.
>
> This was developed and tested on a Lenovo Yoga Tablet 1051L.
>
> The MFD an
Hi,
On 2/4/21 11:57 AM, Lee Jones wrote:
> On Thu, 04 Feb 2021, Hans de Goede wrote:
>
>> Hi all,
>>
>> On 1/20/21 10:49 PM, Hans de Goede wrote:
>>> Hi All,
>>>
>>> Here is v4 of my series to add support for Intel Bay Trail based devices
Hi,
On 2/4/21 12:05 PM, Lee Jones wrote:
> On Sat, 23 Jan 2021, Hans de Goede wrote:
>
>> Hi all,
>>
>> Here is v4 of my series to rework the arizona codec jack-detect support
>> to use the snd_soc_jack helpers instead of direct extcon reporting.
>>
>> T
various theoretically possible races caused
by the wrong ordering inside arizona_extcon_remove(), this fixes the
ordering fixing all possible races, including the reported oops.
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Hans de Goede
-by: Charles Keepax
Signed-off-by: Hans de Goede
---
drivers/extcon/extcon-arizona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index 76aacbac5869..72d23b15108c 100644
--- a/drivers/extcon/extcon-arizona.c
++
The arizona jack-dection handling is being reworked so that the
codec-child-device drivers directly handle jack-detect themselves,
so it is no longer necessary to instantiate "arizona-extcon"
child-devices.
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Han
cs/arizona-jack.c .
This is a preparation patch for converting the arizona extcon-driver into
a helper library for letting the arizona codec-drivers directly report jack
state through the standard sound/soc/soc-jack.c functions.
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Ha
ndy Shevchenko
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 42 ++---
sound/soc/codecs/arizona.h | 1 -
2 files changed, 18 insertions(+), 25 deletions(-)
diff --git a/sound/soc/codecs/arizona-jac
d-by: Andy Shevchenko
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 149 +---
sound/soc/codecs/arizona.h | 7 +-
2 files changed, 47 insertions(+), 109 deletions(-)
diff --git a/sound/
2 steps when arizona_hpdet_irq
runs after the jack has been unplugged.
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
drivers/extcon/extcon-arizona.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff
y: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
sound/soc/codecs/wm5102.c | 12 +++-
sound/soc/codecs/wm5110.c | 12 +++-
sound/soc/codecs/wm8997.c | 14 --
sound/soc/codecs/wm8998.c | 9 +
4 files changed, 43 insertions(+), 4
: Hans de Goede
---
Changes in v4:
- While at it also change (on adjescent lines) "if (ret != 0)" into "if (ret)"
- Do not unnecessary split one of the dev_err_probe() calls over multiple lines
Changes in v3:
- This is a new patch in v3 of this patch-series
---
sound/soc/c
Add jack detect support by creating a jack and calling
snd_soc_component_set_jack to register the created jack
with the codec.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
sound/soc/intel/boards/bytcr_wm5102.c | 28 ++-
1 file changed, 27 insertions
ested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
Changes in v3:
- Pass dev (the codec-device) to devm_regulator_get instead of
passing arizona->dev. This is necessary so that the regulator gets
properly released when the coded driver unbinds.
---
sound/soc/codecs/Makefile | 2 +-
.
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
sound/soc/codecs/arizona-jack.c | 97 ++---
sound/soc/codecs/arizona.h | 36
2 files changed, 65 insertions(+), 68 deletions(-)
diff
().
Reviewed-by: Andy Shevchenko
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Signed-off-by: Hans de Goede
---
Changes in v3:
- This is a new patch in v3 of this patch-set
---
drivers/extcon/extcon-arizona.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/extcon
ers may we have your ack for merging these
through the MFD tree ?
Regards,
Hans
Hans de Goede (13):
mfd: arizona: Drop arizona-extcon cells
extcon: arizona: Fix some issues when HPDET IRQ fires after the jack
has been unplugged
extcon: arizona: Fix various races on driver unbind
Hi,
On 1/4/21 4:24 PM, Maximilian Luz wrote:
> On 1/4/21 3:52 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 12/29/20 4:58 AM, kernel test robot wrote:
>>> Hi Maximilian,
>>>
>>> FYI, the error/warning still remains.
>>>
>>> tree:
Hi,
On 2/3/21 8:58 PM, Mario Limonciello wrote:
> A user without a Dell system doesn't need to pick any of these
> drivers.
>
> Users with a Dell system can enable this submenu and all drivers
> behind it will be enabled.
>
> Suggested-by: Andy Shevchenko
> Signed-off-by: Mario Limonciello
Th
Hi,
On 2/4/21 1:43 PM, Mark Brown wrote:
> On Thu, Feb 04, 2021 at 12:07:49PM +0100, Hans de Goede wrote:
>> On 2/4/21 11:57 AM, Lee Jones wrote:
>>> On Thu, 04 Feb 2021, Hans de Goede wrote:
>
>>>> series are both ready for merging. All patches have Reviewed
Hi Arnd,
On 2/4/21 4:38 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> Three of the newly added functions are accidently not marked 'static' which
> causes a warning when building with W=1
>
> drivers/platform/x86/thinkpad_acpi.c:10081:5: warning: no previous prototype
> for function 'dytc
ly.
>
> While at it, replace the direct printk() invocation with pr_info(),
> add a pr_fmt() definition to ac.c and drop the unneeded PREFIX
> symbol definition from there.
>
> Signed-off-by: Rafael J. Wysocki
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Rega
;device)) {
> - ACPI_EXCEPTION((AE_INFO, AE_ERROR, "Evaluating _STA"));
> + acpi_handle_info(battery->device->handle,
> + "_STA evaluation failed\n");
Missing ": %s", acpi_format_exception(
rom battery.c.
>
> Signed-off-by: Rafael J. Wysocki
> Reviewed-by: Hanjun Guo
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
>
> v2 -> v3: Add R-by tag.
>
> v1 -> v2: Changelog update.
>
> ---
> Docum
Hi,
On 2/4/21 7:27 PM, Hans de Goede wrote:
> Hi,
>
> On 2/3/21 7:44 PM, Rafael J. Wysocki wrote:
>> From: Rafael J. Wysocki
>>
>> Replace the ACPI_DEBUG_PRINT() and ACPI_EXCEPTION() instances
>> in battery.c with acpi_handle_debug() and acpi_handle_info() ca
l definition which is not necessary any more
> from acpi_video.c.
>
> Also make unrelated janitorial changes to fix up white space and
> use ACPI_FAILURE() instead of negating ACPI_SUCCESS().
>
> Signed-off-by: Rafael J. Wysocki
Thanks, patch looks good to me:
Reviewed-by: Hans de Goe
ilitate easier identification of the message source.
>
> Signed-off-by: Rafael J. Wysocki
> Reviewed-by: Hanjun Guo
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
>
> v2 -> v3: Add R-by tag.
>
> v1 -> v2: Changelog update.
>
end trace ceece38854223a0b ]---
Change the 'from' parameter passed to __[devm_]irq_alloc_descs() by the
[devm_]irq_alloc_desc macros from 0 to 1, so that these macros
will no longer return 0.
Cc: Bjorn Helgaas
Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid
please let me know.
The WARN can also be avoided with a simple i915 driver patch, but
this seems to be the more correct way to fix this.
Regards,
Hans
Hans de Goede (1):
genirq: Fix [devm_]irq_alloc_desc returning irq 0
include/linux/irq.h | 4 ++--
1 file changed, 2 insertions(+), 2
Hi,
On 2/5/21 3:00 AM, Chanwoo Choi wrote:
> On 2/4/21 8:24 PM, Hans de Goede wrote:
>> Hi all,
>>
>> Here is v4 of my series to rework the arizona codec jack-detect support
>> to use the snd_soc_jack helpers instead of direct extcon reporting.
>>
>> Thi
Hi,
On 2/7/21 12:21 AM, Rikard Falkeborn wrote:
> The only usage of it is to assign its address to the ops field in the
> regulator_desc struct, which is a pointer to const struct regulator_ops.
> Make it const to allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkebo
Hi,
On 2/5/21 2:26 AM, Maximilian Luz wrote:
> Some Surface Book 2 and 3 models have a discrete GPU (dGPU) that is
> hot-pluggable. On those devices, the dGPU is contained in the base,
> which can be separated from the tablet part (containing CPU and
> touchscreen) while the device is running.
>
Hi Mark, Lee,
On 2/4/21 12:24 PM, Hans de Goede wrote:
> Hi all,
>
> Here is v4 of my series to rework the arizona codec jack-detect support
> to use the snd_soc_jack helpers instead of direct extcon reporting.
>
> This is a resend with some extra *-by tags collected and with
Hi Mark,
On 2/8/21 7:38 PM, Mark Brown wrote:
> On Wed, 20 Jan 2021 22:49:52 +0100, Hans de Goede wrote:
>> Here is v4 of my series to add support for Intel Bay Trail based devices
>> which use a WM5102 codec for audio output/input.
>>
>> This was developed and tes
Hi,
On 2/8/21 8:35 PM, Maximilian Luz wrote:
> The Surface System Aggregator Module (SSAM) subsystem provides various
> functionalities, which are separated by spreading them across multiple
> devices and corresponding drivers. Parts of that functionality / some of
> those devices, however, can (a
Hi,
On 2/8/21 9:04 PM, Maximilian Luz wrote:
> On 2/8/21 8:55 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 2/8/21 8:35 PM, Maximilian Luz wrote:
>>> The Surface System Aggregator Module (SSAM) subsystem provides various
>>> functionalities, which are sepa
Hi,
On 2/8/21 8:49 PM, Maximilian Luz wrote:
> Add a driver to provide platform profile support on 5th- and later
> generation Microsoft Surface devices with a Surface System Aggregator
> Module. On those devices, the platform profile can be used to influence
> cooling behavior and power consumpti
Hi All,
On 2/9/21 2:52 AM, kernel test robot wrote:
> Hi Maximilian,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 61556703b610a104de324e4f061dc6cf7b218b46
> commit: f23027ca3d48b6f93c5994069fb25b73539
Hi,
On 2/9/21 3:14 PM, Lee Jones wrote:
> On Mon, 08 Feb 2021, Hans de Goede wrote:
>
>> Hi Mark, Lee,
>>
>> On 2/4/21 12:24 PM, Hans de Goede wrote:
>>> Hi all,
>>>
>>> Here is v4 of my series to rework the arizona codec jack-detect support
&g
Hi,
On 2/9/21 4:45 PM, Lee Jones wrote:
> On Tue, 09 Feb 2021, Hans de Goede wrote:
>
>> Hi,
>>
>> On 2/9/21 3:14 PM, Lee Jones wrote:
>>> On Mon, 08 Feb 2021, Hans de Goede wrote:
>>>
>>>> Hi Mark, Lee,
>>>>
>>>> On
ng to need a long explanation why this is necessary
over the existing sysfs API.
To be honest ATM I'm not inclined to accept this patch and
it is going to take some very strong arguments to change my
mind.
Regards,
Hans
>
> Cc: Hans de Goede
>
> Signed-off-by: Prasanth KSR
Hi,
On 5/30/20 4:56 PM, Andy Shevchenko wrote:
On Sat, May 9, 2020 at 4:07 PM Hans de Goede wrote:
Many Bay Trail and Cherry Trail devices come with a camera attached to
Intel's Image Signal Processor. Linux currently does not have a driver for
these, so they do not work as a camera.
Add minimum values for the x and y axis, correct the max value for the
x-axis and add support for the capacitive home-button these tablets have.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/touchscreen_dmi.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 +-
drivers/virt/vboxguest/vmmdev.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest/vboxguest_core.c
index 8fab04e76c14..18
Add vbg_set_host_capabilities() helper function, this is a preparation
patch for adding support for the VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 79 ++---
1 file changed, 46 insertions(+), 33 deletions
h the old wrong request defines so as
to not break the kernel ABI in case someone has been using the old
request defines.
Fixes: f6ddd094f579 ("virt: Add vboxguest driver for Virtual Box Guest
integration UAPI")
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede
---
drivers/virt/vboxgue
Rename guest_caps[_tracker] struct members to set_guest_caps[_tracker]
this is a preparation patch for adding support for the
VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 20 ++--
drivers/virt/vboxguest
=1789545
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 163 +++-
drivers/virt/vboxguest/vboxguest_core.h | 14 ++
include/uapi/linux/vboxguest.h | 24
3 files changed, 200 insertions(+), 1 deletion(-)
diff --git a/drivers/virt
Every now and then upstream adds new ioctls without notifying us,
log unknown ioctl requests as an error to catch these.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virt/vboxguest
://bugzilla.redhat.com/show_bug.cgi?id=1789545
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 ++
include/uapi/linux/vbox_vmmdev_types.h | 3 +++
2 files changed, 5 insertions(+)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest
The session lock is a mutex, not a spinlock, fix the comments to match.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest
Hi,
On 5/21/20 12:33 PM, Chris Chiu wrote:
Hi,
I have the ASUS new laptop UX325JA and most of the media keys are
not working even with the latest kernel (5.7.0-rc5+). Looking into the
dmesg log, the ASUS WMI driver fails to load because of
[7.827241] asus-nb-wmi: probe of asus-nb-wmi fa
Hi,
On 8/11/20 8:00 AM, Kai-Heng Feng wrote:
Hi Hans,
On Aug 11, 2020, at 00:13, Hans de Goede wrote:
Hi,
On 10-08-2020 16:29, Kai-Heng Feng wrote:
Goodix touchpad fails to operate in I2C mode after system suspend.
According to the vendor, Windows is more forgiving and there's a
Hi,
On 10-08-2020 16:29, Kai-Heng Feng wrote:
Goodix touchpad fails to operate in I2C mode after system suspend.
According to the vendor, Windows is more forgiving and there's a 60ms
delay after SET_POWER ON command.
So let's do the same here, to workaround for the touchpads that depend
on the
Hi,
On 12/28/20 3:19 PM, Andy Shevchenko wrote:
> On Sun, Dec 27, 2020 at 11:15 PM Hans de Goede wrote:
>>
>> Hi All,
>>
>> This patch series adds support for Intel Bay Trail based device which use
>> a WM5102 codec for audio output/input. This was developed and
Hi,
First of all thank you for the review and for all your comments
(also in the other part of the thread).
On 12/29/20 1:00 PM, Charles Keepax wrote:
> On Sun, Dec 27, 2020 at 10:12:22PM +0100, Hans de Goede wrote:
>> There is no reason why the arizona core,irq and codec model
nternal/headset microphones.
>>
>> Signed-off-by: Chris Chiu
>
> You probably need to re-send and CC: maintainers (Mark Brown, Takashi Iwai)
> and Hans de Goede who's been supporting all those quirks.
>
> I don't think the changes below are fully
Hi,
On 1/12/21 12:53 PM, Greg KH wrote:
> On Wed, Jan 06, 2021 at 12:39:24AM +0800, Kyle Tso wrote:
>> This series include previous patch "[v4] AMS and Collision Avoidance"
>> https://lore.kernel.org/r/20201217030632.903718-1-kyle...@google.com
>> and two more patches "Protocol Error handling" and
end trace ceece38854223a0b ]---
Change the 'from' parameter passed to __[devm_]irq_alloc_descs() by the
[devm_]irq_alloc_desc macros from 0 to 1, so that these macros
will no longer return 0.
Cc: Bjorn Helgaas
Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid
Hi,
On 12/6/20 4:58 PM, Maximilian Luz wrote:
> On 12/6/20 8:07 AM, Leon Romanovsky wrote:
>> On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote:
>>> Hello,
>>>
>>> Here is version two of the Surface System Aggregator Module (SAM/SSAM)
>>> driver series, adding initial support for the
Hi,
On 12/4/20 9:09 PM, Mario Limonciello wrote:
> commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME
> systems")
> disabled s0ix flows for systems that have various incarnations of the
> i219-LM ethernet controller. This was done because of some regressions
> caused by an ea
Hi,
On 12/3/20 11:30 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The only reference to the mlxplat_mlxcpld_psu[] array got removed,
> so there is now a warning from clang:
>
> drivers/platform/x86/mlx-platform.c:322:30: error: variable
> 'mlxplat_mlxcpld_psu' is not needed and will not
Hi,
On 12/2/20 2:19 PM, Divya Bharathi wrote:
> BIOS sets incorrect value (zero) when SET value passed for integer attribute
> with + sign. Added workaround to remove + sign before passing input to BIOS
>
> Co-developed-by: Mario Limonciello
> Signed-off-by: Mario Limonciello
> Co-developed-by:
Hi,
On 12/7/20 7:43 AM, Chris Chiu wrote:
> From: Daniel Drake
>
> Sending the switch state change twice within the same frame is invalid
> evdev protocol and only works if the client handles keys immediately as
> well. Processing events immediately is incorrect, it forces a fake
> order of even
Hi,
On 12/4/20 2:57 AM, Srinivas Pandruvada wrote:
> The address should be aligned to 4 byte boundary. So send an error for
> unaligned address.
>
> Signed-off-by: Srinivas Pandruvada
Thank you for your patch-series.
One thing which still seems to be missing after this series is a check for
at
rmal tree ?
I can take them through the drivers/platform/x86 (pdx86) tree,
but if you prefer to take them upstream through the thermal tree,
then that is fine too...
Here is my ack (as pdx86 maintainer) for taking them through
the thermal tree:
Acked-by: Hans de Goede
Regards,
Hans
Hi,
On 12/4/20 5:01 PM, Elia Devito wrote:
> From: Elia Devito
>
> Some convertible use the intel-hid ACPI interface to report SW_TABLET_MODE,
> implement this with DMI based allow-list to be sure to activate support
> only on models that effectively have it.
>
> Signed-off-by: Elia Devito
Th
ids[] any more.
>
> Link:
> https://lore.kernel.org/linux-acpi/52a2b98c-6bf3-760b-eca9-93cf05fb4...@redhat.com/
> Suggested-by: Hans de Goede
> Signed-off-by: Rafael J. Wysocki
Thanks, patch looks good to me. FWIW:
Acked-by: Hans de Goede
Regards,
Hans
> ---
>
> On top of
>
Hi,
On 12/7/20 7:15 PM, Srinivas Pandruvada wrote:
> v2
> Fix sparse warnings reported by LKP.
>
> Srinivas Pandruvada (3):
> platform/x86: ISST: Check for unaligned mmio address
> platform/x86: ISST: Allow configurable offset range
> platform/x86: ISST: Change PCI device macros
I've alrea
any
> external specifications.
>
> Change the language used through-out to supplier/consumer.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/acpi/scan.c | 12 ++
Hi,
On 12/8/20 6:08 AM, Neftin, Sasha wrote:
> On 12/7/2020 17:41, Limonciello, Mario wrote:
>>> First of all thank you for working on this.
>>>
>>> I must say though that I don't like the approach taken here very
>>> much.
>>>
>>> This is not so much a criticism of this series as it is a criticis
Hi,
On 12/7/20 6:47 PM, Vadim Pasternak wrote:
> Fix array names to match assignments for data items and data items
> counter for power and fan attributes.
>
> Patch #1: Provide fixes for system types MSN2700, MSN24xx.
> Patch #1: Provide fixes for system type MSN2700/ComEx.
Thank you for your p
Hi,
On 12/8/20 7:11 AM, Chris Chiu wrote:
> From: Carlo Caione
>
> The WiFi media button on the Quanta NL3 reports keycodes 0x8b and 0x9b
> to the platform driver. Add the mapping to support these codes.
>
> Signed-off-by: Carlo Caione
> Reviewed-by: Chris Chiu
Thank you for your patch, I've
Hi,
On 12/8/20 3:37 PM, Maximilian Luz wrote:
>>> +
>>> + obj = acpi_evaluate_dsm_typed(handle, &SSAM_SSH_DSM_GUID,
>>> + SSAM_SSH_DSM_REVISION, func, NULL,
>>> + ACPI_TYPE_INTEGER);
>>> + if (!obj)
>>> + return -EIO;
>>> +
>>> + val = o
Hi,
On 12/8/20 4:22 PM, Pandruvada, Srinivas wrote:
> On Tue, 2020-12-08 at 20:28 +0800, Zou Wei wrote:
>> Fix the following sparse warnings:
>>
>> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24:
>> warning: symbol 'mmio_range_devid_0' was not declared. Should it be
>> static?
>>
Hi,
On 12/8/20 1:28 PM, Zou Wei wrote:
> Fix the following sparse warnings:
>
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24: warning:
> symbol 'mmio_range_devid_0' was not declared. Should it be static?
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:28:24: warnin
Hi,
I know there already is a v3 out and I will try to get around to reviewing
that soon, still 1 remark about the discussion surrounding v2:
On 1/11/21 2:42 PM, Perry Yuan wrote:
>>> *The flow is like this:
>>> 1) User presses key. HW does stuff with this key (timeout is started)
>>> 2) Event
Hi All,
Booting a 5.11-rc2 kernel with lockdep enabled inside a virtualbox vm (which
still
emulates good old piix ATA controllers) I get the below lockdep splat early on
during boot:
This seems to be led-class related but also seems to have a (P)ATA
part to it. To the best of my knowledge this
ice tree
>
> Ondrej Jirman (1):
> input: sun4i-lradc-keys - Add wakup support
>
> Samuel Holland (2):
> dt-bindings: sun4i-a10-lradc-keys: Accept wakeup-source property
> arm64: dts: allwinner: pinephone: Support volume key wakeup
Thanks, the entire series looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
Hi,
On 1/12/21 11:30 PM, Pavel Machek wrote:
> Hi!
>
>> Booting a 5.11-rc2 kernel with lockdep enabled inside a virtualbox vm (which
>> still
>> emulates good old piix ATA controllers) I get the below lockdep splat early
>> on during boot:
>>
>> This seems to be led-class related but also seems
Hi,
On 12/16/20 10:21 AM, Hans de Goede wrote:
> Hi,
>
> On 12/16/20 1:17 AM, Linus Torvalds wrote:
>> On Mon, Dec 14, 2020 at 4:43 AM Hans de Goede wrote:
>>>
>>> - New Intel PMT telemetry and crashlog drivers
>>
>> These have _very_ annoying Kconfi
Hi,
On 1/7/21 3:44 PM, Jiaxun Yang wrote:
> Newer ideapads (e.g.: Yoga 14s, 720S 14) come with ELAN0634 touchpad do not
> use EC to switch touchpad.
>
> Reading VPCCMD_R_TOUCHPAD will return zero thus touchpad may be blocked
> unexpectedly.
> Writing VPCCMD_W_TOUCHPAD may cause a spurious key pre
Hi,
On 1/11/21 3:46 PM, Colin King wrote:
> From: Colin Ian King
>
> The left shift of int 32 bit integer constant 1 is evaluated using 32 bit
> arithmetic and then passed as a 64 bit function argument. In the case where
> func is 32 or more this can lead to an oveflow. Avoid this by shifting
>
Hi,
On 12/21/20 7:56 PM, Hans de Goede wrote:
> Since commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0
> is invalid"), having a linux-irq with number 0 will trigger a WARN
> when calling platform_get_irq*() to retrieve that linux-irq.
>
> Since [devm
Hi,
On 1/13/21 3:46 PM, Kyle Tso wrote:
> On Wed, Jan 13, 2021 at 2:11 PM Badhri Jagan Sridharan
> wrote:
>>
>> Hi Kyle,
>>
>> Do you want to handle the FAST_ROLE_SWAP case as well ?
>>
> I forgot this part
> Thanks for catching this.
> I will fix it.
That sounds like a v6 is upcoming which
601 - 700 of 2701 matches
Mail list logo
