.
While at it also remove a comment on a vbg_alloc_req call which talks
about Windows (inherited from the vbox upstream cross-platform code).
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 66 +---
drivers/virt/vboxguest
Hi,
On 29-03-18 13:55, Greg Kroah-Hartman wrote:
On Thu, Mar 29, 2018 at 01:21:14PM +0200, Hans de Goede wrote:
--- a/include/linux/vbox_utils.h
+++ b/include/linux/vbox_utils.h
@@ -33,6 +33,13 @@ __printf(1, 2) void vbg_debug(const char *fmt, ...);
*/
void *vbg_req_alloc(size_t len, enum
Hi,
On 29-03-18 13:56, Greg Kroah-Hartman wrote:
On Thu, Mar 29, 2018 at 01:21:14PM +0200, Hans de Goede wrote:
+void vbg_req_free(void *req, size_t len)
+{
+ if (!req)
+ return;
+
+ kfree(req);
+}
Wait, no, this isn't ok. Don't create wrapper function
Hi,
On 29-03-18 13:58, Greg Kroah-Hartman wrote:
On Thu, Mar 29, 2018 at 01:21:15PM +0200, Hans de Goede wrote:
It is not possible to get DMA32 zone memory through kmalloc,
Why can't we just fix that issue here instead?
AFAIK that would go against the design of the whole slab
allocato
Hi All,
Since I made the same mistake myself I've done a quick grep for
GFP_DMA32 in the kernel and drivers/scsi/aacraid/commctrl.c
came up as a result of this grep, it does:
p = kmalloc(sg_count[i], GFP_KERNEL|GFP_DMA32);
But kmalloc always returns memory from t
.
While at it also remove a comment on a vbg_alloc_req call which talks
about Windows (inherited from the vbox upstream cross-platform code).
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede
---
Changes in v2:
-Put the vbg_req_free() prototype decl. in the private vboxguest_core.h
instead of in
This was the only error path during probe without a message being logged
about what went wrong, this fixes this.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/virt/vboxguest
x86_64 guests
with more then 4G RAM.
Cc: sta...@vger.kernel.org
Reported-by: Eloy Coto Pereiro
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_linux.c | 19 ---
drivers/virt/vboxguest/vboxguest_utils.c | 5 +++--
2 files changed, 19 insertions(+), 5 deletions
Move the declarations of functions from vboxguest_utils.c which are only
meant for vboxguest internal use from include/linux/vbox_utils.h to
drivers/virt/vboxguest/vboxguest_core.h.
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.h | 8
rs/virt/vboxguest/
+VIRTUAL BOX SHARED FOLDER VFS DRIVER:
+M: Hans de Goede
+L: linux-fsde...@vger.kernel.org
+S: Maintained
+F: fs/vboxsf/*
+
VIRTUAL SERIO DEVICE DRIVER
M: Stephen Chandler Paul
S: Maintained
diff --git a/fs/Kconfig b/fs/Kconfig
index bc821a86d965..ec
-tested-by: Richard W.M. Jones
Signed-off-by: Hans de Goede
---
drivers/ata/libata-core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 6e400ff2b5db..68596bd4cf06 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
Hi,
On 26-04-18 18:51, Ard Biesheuvel wrote:
On 26 April 2018 at 14:06, Hans de Goede wrote:
Sometimes it is useful to be able to dump the efi boot-services code and
data. This commit adds these as debugfs-blobs to /sys/kernel/debug/efi,
but only if efi=debug is passed on the kernel
Hi,
On 26-04-18 23:35, Ard Biesheuvel wrote:
On 26 April 2018 at 23:02, Hans de Goede wrote:
Hi,
On 26-04-18 18:51, Ard Biesheuvel wrote:
On 26 April 2018 at 14:06, Hans de Goede wrote:
Sometimes it is useful to be able to dump the efi boot-services code and
data. This commit adds
s commit avoids the printing of these errors, by checking romsize
before doing the alloc and if it is larger then 256M silently ignore the
ROM fields instead of trying to alloc mem and fail.
Signed-off-by: Hans de Goede
---
Changes in v2:
-Add the check to both __setup_efi_pci32 and __setup_efi_p
Hi,
On 28-04-18 08:40, Ard Biesheuvel wrote:
Hi Hans,
On 27 April 2018 at 23:35, Hans de Goede wrote:
setup_efi_pci() tries to save a copy of each PCI option ROM as this may
be necessary for the device driver for the PCI device to have access too.
On some systems the efi_pci_io_protocol_64
necessary info for the new EFI embedded-firmware code
to extract these firmwares, making the touchscreen work OOTB without the
user needing to manually add the firmware.
Acked-by: Andy Shevchenko
Acked-by: Ard Biesheuvel
Signed-off-by: Hans de Goede
---
drivers/firmware/efi/embedded-firmware.c
Shevchenko
Acked-by: Ard Biesheuvel
Signed-off-by: Hans de Goede
---
MAINTAINERS | 2 +-
drivers/platform/x86/Kconfig | 16 ++---
drivers/platform/x86/Makefile | 2 +-
.../x86/{silead_dmi.c => touchscreen_dmi.c} |
: Greg Kroah-Hartman
Acked-by: Ard Biesheuvel
Signed-off-by: Hans de Goede
---
Changes in v5:
-Rename the EFI_BOOT_SERVICES flag to EFI_PRESERVE_BS_REGIONS
Changes in v4:
-Add new EFI_BOOT_SERVICES flag and use it to determine if the boot-services
memory segments are available (and thus if it makes
Hi All,
Here is v5 of my patch-set to add support for EFI embedded fw to the kernel.
Changes since v4:
-Rename the EFI_BOOT_SERVICES flag to EFI_PRESERVE_BS_REGIONS
So I think this patch-set is getting close to ready for merging, which
brings us to the question of how to merge this, I think that
Acked-by: Ard Biesheuvel
Signed-off-by: Hans de Goede
---
Changes in v5:
-Rename the EFI_BOOT_SERVICES flag to EFI_PRESERVE_BS_REGIONS
Changes in v4:
-Drop note in docs about EFI_FIRMWARE_VOLUME_PROTOCOL, it is not part of
UEFI proper, so the EFI maintainers don't want us referring people
Add touchscreen info for the Chuwi Vi8 Plus tablet. This tablet uses a
Chipone ICN8505 touchscreen controller, with the firmware used by the
touchscreen embedded in the EFI firmware.
Acked-by: Andy Shevchenko
Acked-by: Ard Biesheuvel
Signed-off-by: Hans de Goede
---
drivers/platform/x86
Hi,
On 30-04-18 14:41, Heikki Krogerus wrote:
The driver will not probe unless bq24190 is loaded, so
making it a dependency.
Hmm, the dependency is pure run-time, with this Kconfig
change if a user now decides to builtin the intel_cht_int33fe
driver, the bq24190 driver must also be builtin, I'
akes sense:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/usb/typec/tcpm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
index 1ee259bc14a5..66dc0773b9bf 100644
--- a/drivers/usb/typec/tcpm.c
+++ b/drivers/usb/typec/tcpm.c
the struct const since
we are now no longer changing it and usb_role_switch_register() accepts
it being const.
With that changed:
Reviewed-by: Hans de Goede
Regards,
Hans
Hi,
On 01-05-18 16:36, Mimi Zohar wrote:
[Cc'ing linux-security]
On Sun, 2018-04-29 at 11:35 +0200, Hans de Goede wrote:
[...]
diff --git a/drivers/base/firmware_loader/fallback_efi.c
b/drivers/base/firmware_loader/fallback_efi.c
new file mode 100644
index ..82ba82f48a79
---
Hi,
On 05/01/2018 09:29 PM, Andy Lutomirski wrote:
On Sun, Apr 29, 2018 at 2:36 AM Hans de Goede wrote:
+The EFI embedded-fw code works by scanning all EFI_BOOT_SERVICES_CODE
memory
+segments for an eight byte sequence matching prefix, if the prefix is
found it
+then does a crc32 over
Hi,
On 05/02/2018 10:46 PM, damian wrote:
Hello Greg,
it is PATCH 3 virt: vbox: Use __get_free_pages insteas of kmalloc for DMA32
memory.
Weird. I'm currently on vacation. I will look into this first thing next Monday.
Regards,
Hans
Add touchscreen info for the Jumper EZpad 6 Pro.
Cc: zy <574249...@qq.com>
Reported-and-tested-by: zy <574249...@qq.com>
Signed-off-by: Hans de Goede
---
drivers/platform/x86/silead_dmi.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/
its own entry.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/silead_dmi.c | 39 +++
1 file changed, 34 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/x86/silead_dmi.c
b/drivers/platform/x86/silead_dmi.c
index d7a67a53195f..ca49deaa2336 100644
Add touchscreen info for the Onda V891w 8.9" windows tablet.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/silead_dmi.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/platform/x86/silead_dmi.c
b/drivers/platform/x86/silead_dmi.c
Hi Chris.
On 04-06-18 14:32, Chris Chiu wrote:
Make asus-wmi notify on hotkey kbd brightness changes, listen for
brightness events and update the brightness directly in the driver.
For this purpose, bound check on brightness in kbd_led_set must be
based on the same data type to prevent illegal v
Hi,
On 04-06-18 15:51, Daniel Drake wrote:
On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
Is this really a case of the hardware itself processing the
keypress and then changing the brightness *itself* ?
From the "[PATCH 2/2] platform/x86: asus-wmi: Add keyboard backlight
t
Hi,
On 05-06-18 04:31, Darren Hart wrote:
On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
Hi,
On 04-06-18 15:51, Daniel Drake wrote:
On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
Is this really a case of the hardware itself processing the
keypress and then changing
Hi,
On 05-06-18 05:18, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart wrote:
On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
Hi,
On 04-06-18 15:51, Daniel Drake wrote:
On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
Is this really a case of the
Hi,
On 05-06-18 11:58, Bastien Nocera wrote:
On Tue, 2018-06-05 at 09:37 +0200, Hans de Goede wrote:
Hi,
On 05-06-18 05:18, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart
wrote:
On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
Hi,
On 04-06-18 15:51, Daniel
Hi,
On 05-06-18 12:14, Bastien Nocera wrote:
On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
Hi,
On 05-06-18 11:58, Bastien Nocera wrote:
On Tue, 2018-06-05 at 09:37 +0200, Hans de Goede wrote:
Hi,
On 05-06-18 05:18, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart
Hi,
On 05-06-18 12:46, Benjamin Berg wrote:
Hey,
On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
On 05-06-18 12:14, Bastien Nocera wrote:
On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
On 05-06-18 11:58, Bastien Nocera wrote:
[SNIP]
Ok, so what are you suggestion, do you
Hi,
On 06-06-18 16:27, Benjamin Berg wrote:
Hi,
On Wed, 2018-06-06 at 10:50 +0800, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 7:06 PM, Hans de Goede
wrote:
Hi,
On 05-06-18 12:46, Benjamin Berg wrote:
Hey,
On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
On 05-06-18 12:14
Hi,
On 24-04-18 18:07, Mimi Zohar wrote:
On Tue, 2018-04-24 at 17:09 +0200, Hans de Goede wrote:
Hi,
On 23-04-18 23:11, Luis R. Rodriguez wrote:
Hans, please see use of READING_FIRMWARE_PREALLOC_BUFFER, we'll need a new ID
and security for this type of request so IMA can reject it i
Hi,
On 24-04-18 19:18, Johan Hovold wrote:
[ Adding some more people on CC. ]
On Tue, Apr 24, 2018 at 04:29:53PM +0800, Shrirang Bagul wrote:
On systems using Intel Atom (Baytrail-I) SoC's, slave devices connected on
HSUART1/2 ports are described by the ACPI BIOS as virtual hardware using
HID'
Hi All,
Here is v4 of my patch-set to add support for EFI embedded fw to the kernel.
Changes since v3:
-Drop note in docs about EFI_FIRMWARE_VOLUME_PROTOCOL, it is not part of
UEFI proper, so the EFI maintainers don't want us referring people to it
-Use new EFI_BOOT_SERVICES flag
-Put the new fw
Shevchenko
Signed-off-by: Hans de Goede
---
MAINTAINERS | 2 +-
drivers/platform/x86/Kconfig | 16 ++---
drivers/platform/x86/Makefile | 2 +-
.../x86/{silead_dmi.c => touchscreen_dmi.c} | 66 +--
4 fi
: Greg Kroah-Hartman
Signed-off-by: Hans de Goede
---
Changes in v4:
-Add new EFI_BOOT_SERVICES flag and use it to determine if the boot-services
memory segments are available (and thus if it makes sense to register the
debugfs bits for them)
Changes in v2:
-Do not call pr_err on debugfs call
Add touchscreen info for the Chuwi Vi8 Plus tablet. This tablet uses a
Chipone ICN8505 touchscreen controller, with the firmware used by the
touchscreen embedded in the EFI firmware.
Acked-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
drivers/platform/x86/touchscreen_dmi.c | 25
necessary info for the new EFI embedded-firmware code
to extract these firmwares, making the touchscreen work OOTB without the
user needing to manually add the firmware.
Acked-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
drivers/firmware/efi/embedded-firmware.c | 3 +++
drivers/platform
Signed-off-by: Hans de Goede
---
Changes in v4:
-Drop note in docs about EFI_FIRMWARE_VOLUME_PROTOCOL, it is not part of
UEFI proper, so the EFI maintainers don't want us referring people to it
-Use new EFI_BOOT_SERVICES flag
-Put the new fw_get_efi_embedded_fw() function in it
Hi,
On 01-03-19 17:40, m...@myself5.de wrote:
From: Christian Oder
Add touchscreen info for the CHUWUI Hi10 Air tablet.
Signed-off-by: Christian Oder
Thank you for the patch, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/platform/x86
Hi,
On 21-02-19 13:30, Hans de Goede wrote:
Hi,
On 19-02-19 22:47, Lendacky, Thomas wrote:
On 2/19/19 3:01 PM, Thomas Gleixner wrote:
Hans,
On Tue, 19 Feb 2019, Hans de Goede wrote:
Cc+: ACPI/AMD folks
Various people are reporting false positive "do_IRQ: #.55 No irq handler for
v
Hi Christian,
On 03-03-19 14:47, Christian Oder wrote:
Add touchscreen info for the CHUWUI Hi10 Air tablet.
Signed-off-by: Christian Oder
Reviewed-by: Hans de Goede
---
Changes in v2:
- added review tag
A quick note for any patches you may submit in the future, there
is no need to send a
Hi,
On 12-04-19 15:41, Heikki Krogerus wrote:
Now that the software nodes support references, and the
device connection API support parsing fwnode references,
replacing the old connection descriptions with software node
references. Relying on device names when matching the
connection would not h
Hi,
On 17-04-19 08:39, Heikki Krogerus wrote:
On Tue, Apr 16, 2019 at 11:35:36PM +0200, Hans de Goede wrote:
Hi,
On 12-04-19 15:41, Heikki Krogerus wrote:
Now that the software nodes support references, and the
device connection API support parsing fwnode references,
replacing the old
Hi,
On 12-04-19 15:41, Heikki Krogerus wrote:
In ACPI, and now also in DT, the USB connectors usually have
their own device nodes. In case of USB Type-C, those
connector (port) nodes are child nodes of the controller or
PHY device, in our case the fusb302. The software fwnodes
allow us to create
Hi,
On 17-04-19 11:32, Heikki Krogerus wrote:
On Wed, Apr 17, 2019 at 11:19:28AM +0200, Hans de Goede wrote:
Hi,
On 17-04-19 08:39, Heikki Krogerus wrote:
On Tue, Apr 16, 2019 at 11:35:36PM +0200, Hans de Goede wrote:
Hi,
On 12-04-19 15:41, Heikki Krogerus wrote:
Now that the software
Hi,
On 17-04-19 11:32, Heikki Krogerus wrote:
On Wed, Apr 17, 2019 at 11:19:28AM +0200, Hans de Goede wrote:
That is not going to work since the (virtual) mux / orientation-switch
devices are only registered once the driver binds to the piusb30532 i2c
device, so when creating the nodes we
Hi,
On 17-04-19 13:04, Heikki Krogerus wrote:
On Wed, Apr 17, 2019 at 11:52:15AM +0200, Hans de Goede wrote:
Hi,
On 17-04-19 11:32, Heikki Krogerus wrote:
On Wed, Apr 17, 2019 at 11:19:28AM +0200, Hans de Goede wrote:
Hi,
On 17-04-19 08:39, Heikki Krogerus wrote:
On Tue, Apr 16, 2019 at
Hi,
On 15-04-19 17:40, l...@aurorafoss.org wrote:
April 6, 2019 10:36 AM, "Hans de Goede" wrote:
Hi,
Yes that seems the best way forward with this.
Note I think "base" is better then "keyboard" for the sensor which
is in the base/keyboard. But neither is per
Hi,
On 17-04-19 12:44, Heikki Krogerus wrote:
On Wed, Apr 17, 2019 at 12:15:18PM +0200, Hans de Goede wrote:
Hi,
On 17-04-19 11:32, Heikki Krogerus wrote:
On Wed, Apr 17, 2019 at 11:19:28AM +0200, Hans de Goede wrote:
That is not going to work since the (virtual) mux / orientation
Hi,
On 17-04-19 11:19, Hans de Goede wrote:
Note that another problem with this series which I noticed while testing
is that the usb-role-switch is not being found at all anymore after
this ("Replacing the old connections with references") patch. I still need
start debugging that.
Hi,
On 18-04-19 11:34, Benjamin Tissoires wrote:
On Mon, Apr 15, 2019 at 6:11 PM Jeffrey Hugo wrote:
Following up on commit 2bafa1e96254 ("HID: quirks: Fix keyboard + touchpad
on Lenovo Miix 630"), the devicetree (DT) identifier for the combo keyboard
+ touchpad device is "elan,combo400-i2c",
Hello Robert,
On 11-04-19 21:50, Robert R. Howell wrote:
On 4/8/19 2:16 AM, Hans de Goede wrote:>
Hmm, interesting so you have hibernation working on a T100TA
(with 5.0 + 02e45646d53b reverted), right ?
Hi Hans and Kai-Heng
First, apologies for how long it took me to reply to both y
Hi,
On 11-03-19 13:52, Andy Shevchenko wrote:
On Mon, Mar 11, 2019 at 12:22:15PM +0100, Hans de Goede wrote:
Before this commit the i2c-designware-platdrv assumes that if the pdev
has an apci-companion it should use a dynamic adapter-nr and otherwise
it will use pdev->id as adapter-nr.
Hi,
On 12-03-19 15:47, Jarkko Nikula wrote:
Hi
On 3/11/19 1:22 PM, Hans de Goede wrote:
Before this commit the i2c-designware-platdrv assumes that if the pdev
has an apci-companion it should use a dynamic adapter-nr and otherwise
it will use pdev->id as adapter-nr.
On some devices e.g.
Hi,
On 3/15/19 6:33 PM, Andy Shevchenko wrote:
On Fri, Mar 15, 2019 at 3:31 PM Gabriel Lazar
wrote:
Add touchscreen platform data for the Myrya MY8307 2-in-1 laptop.
You sent one patch twice or two patches?
Please, clarify this by sending v2 with correct subject line(s) and
amount of patche
tle, I find it hard to read.
Signed-off-by: Daniel Vetter
Cc: Greg Kroah-Hartman
Cc: Fabio Rafael da Rosa
Cc: Nicholas Mc Guire
Cc: Daniel Vetter
Cc: Hans de Goede
---
drivers/staging/vboxvideo/TODO | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/vboxvideo/TOD
Hi,
On 28-01-19 10:45, Andy Shevchenko wrote:
On Fri, Jan 25, 2019 at 3:17 PM Heikki Krogerus
wrote:
Driver for fusb302 does not support alternate modes, so the
connection is not really needed for now. Removing that
connection description allows us to improve the USB Type-C
mux API.
Acked-
Hi,
On 28-03-19 11:34, Chen, Hu wrote:
I run Android on x86 PC (it's a NUC). Everytime I press the power button
to wake the system, it suspends right away. After some debug, I find
that Android wants to see KEY_POWER at resume. Otherwise, its
opportunistic suspend will kick in shortly.
However,
Hi,
On 02-04-19 15:44, Benjamin Tissoires wrote:
Hi Dmitry,
On Fri, Mar 29, 2019 at 11:26 PM Dmitry Torokhov
wrote:
Hi Benjamin,
On Thu, Mar 28, 2019 at 8:52 AM Benjamin Tissoires
wrote:
Or when the probe failed.
This is a common pattern in the HID drivers to reset the drvdata. Some
do
Hi,
On 02-04-19 16:00, Benjamin Tissoires wrote:
On Tue, Apr 2, 2019 at 3:52 PM Hans de Goede wrote:
Hi,
On 02-04-19 15:44, Benjamin Tissoires wrote:
Hi Dmitry,
On Fri, Mar 29, 2019 at 11:26 PM Dmitry Torokhov
wrote:
Hi Benjamin,
On Thu, Mar 28, 2019 at 8:52 AM Benjamin Tissoires
Hi,
On 03-04-19 07:43, Kai-Heng Feng wrote:
i2c-designware-platdrv fails to work after the system restored from
hibernation:
[ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component type:
0x
Commit 48402cee6889 ("ACPI / LPSS: Resume BYT/CHT I2C controllers from
resume_noirq
Hi,
On 02-04-19 18:04, Luís Ferreira wrote:
Some ultrabooks, like Teclast F6 Pro, use KIOX010A sensor on display
and KIOX020A sensor on keyboard base, to detect tablet mode or screen
orientation.
I deliberately left out the KIOX020A id for now, because currently
userspace cannot really deal wi
Hi,
On 31-03-19 11:50, hotwater...@tutanota.com wrote:
Hi. I've done everything you said, here are results:
Vladislav can you check the output of /cat/interrupts on a kernel
without the patch and while *not* using the touchpad; and check
if the amount of touchpads-interrupts still k
Hi,
On 07-04-19 22:58, Robert R. Howell wrote:
On 4/3/19 2:54 AM, Hans de Goede wrote:
Hi,
On 03-04-19 07:43, Kai-Heng Feng wrote:
i2c-designware-platdrv fails to work after the system restored from
hibernation:
[ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component type
Hi,
On 25-02-19 16:48, Heikki Krogerus wrote:
On Fri, Feb 22, 2019 at 05:31:32PM +0100, Hans de Goede wrote:
Hi,
On 2/19/19 12:59 PM, Heikki Krogerus wrote:
Hi guys,
The software nodes support node hierarchy. By using them with fusb302
we can add a separate fwnode also for the USB connector
this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva
Thank you the patch, patch looks good to me:
Reviewed-by: Hans de Goede
Regards
al9555a.c
>> delete mode 100644
>> arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c
>> delete mode 100644
>> arch/x86/platform/intel-mid/device_libs/platform_tca6416.c
>> delete mode 100644 arch/x86/platform/intel-mid/sfi.c
>> delete mode 100644 arch/x86/platform/sfi/Makefile
>> delete mode 100644 arch/x86/platform/sfi/sfi.c
>> delete mode 100644 drivers/cpufreq/sfi-cpufreq.c
>> delete mode 100644 drivers/sfi/Kconfig
>> delete mode 100644 drivers/sfi/Makefile
>> delete mode 100644 drivers/sfi/sfi_acpi.c
>> delete mode 100644 drivers/sfi/sfi_core.c
>> delete mode 100644 drivers/sfi/sfi_core.h
>> delete mode 100644 include/linux/sfi.h
>> delete mode 100644 include/linux/sfi_acpi.h
>>
>> --
>
> All of this looks good to me, so I'm going to queue it up for 5.12
> unless there are objections against doing that.
That is fine by me (for the drivers/platform/x86 bits) :
Acked-by: Hans de Goede
Regards,
Hans
Hi,
On 2/11/21 1:41 PM, Maximilian Luz wrote:
> The raw message frame length is unaligned and explicitly marked as
> little endian. It should not be accessed without the appropriate
> accessor functions. Fix this.
>
> Note that payload.len already contains the correct length after parsing
> via s
Hi,
On 2/10/21 8:20 PM, Casey Bowman wrote:
> Increasing the virtual timeout time to account for scenarios
> that may require more time, like DisplayPort Multi-Stream Transport
> (DP MST), where the disconnect time can be extended longer than
> usual.
>
> The recommended timeout range is 5-10 sec
Hi,
On 2/8/21 10:38 PM, Maximilian Luz wrote:
>
>
> On 2/8/21 9:27 PM, Hans de Goede wrote:
>>> +static int convert_ssam_to_profile(struct ssam_device *sdev, enum
>>> ssam_tmp_profile p)
>>> +{
>>> + switch (p) {
>>>
Hi,
On 2/11/21 5:17 PM, Maximilian Luz wrote:
>
>
> On 2/11/21 4:56 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 2/8/21 10:38 PM, Maximilian Luz wrote:
>>>
>>>
>>> On 2/8/21 9:27 PM, Hans de Goede wrote:
>>
>>
>>
Hi,
On 2/11/21 5:34 PM, Maximilian Luz wrote:
>
>
> On 2/11/21 5:31 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 2/11/21 5:17 PM, Maximilian Luz wrote:
>>>
>>>
>>> On 2/11/21 4:56 PM, Hans de Goede wrote:
>>>> Hi,
>>>>
&
Hi,
On 2/13/21 1:16 PM, Greg Kroah-Hartman wrote:
> On Sat, Feb 13, 2021 at 01:58:44PM +0200, Matti Vaittinen wrote:
>> A few drivers which need a delayed work-queue must cancel work at exit.
>> Some of those implement remove solely for this purpose. Help drivers
>> to avoid unnecessary remove and
Hi,
On 2/13/21 2:33 PM, Greg Kroah-Hartman wrote:
> On Sat, Feb 13, 2021 at 02:18:06PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 2/13/21 1:16 PM, Greg Kroah-Hartman wrote:
>>> On Sat, Feb 13, 2021 at 01:58:44PM +0200, Matti Vaittinen wrote:
>>>> A f
Hi,
On 2/13/21 3:38 PM, Hans de Goede wrote:
> Hi,
>
> On 2/13/21 2:33 PM, Greg Kroah-Hartman wrote:
> Having this new devm_delayed_work_autocancel() helper will allow a
> bunch of drivers to move away from mixing the 2, which is a good thing
> in my book.
>
> As I s
Hi,
On 2/13/21 12:58 PM, Matti Vaittinen wrote:
> A few drivers which need a delayed work-queue must cancel work at exit.
> Some of those implement remove solely for this purpose. Help drivers
> to avoid unnecessary remove and error-branch implementation by adding
> managed verision of delayed wor
Hi,
On 2/13/21 4:27 PM, Guenter Roeck wrote:
> On 2/13/21 7:03 AM, Hans de Goede wrote:
> [ ... ]
>>
>> I think something like this should work:
>>
>> static int devm_delayed_work_autocancel(struct device *dev, struct
>> delayed_work *w,
>>
Hi,
On 2/23/21 6:22 PM, Andy Shevchenko wrote:
> It's better to describe the I²C controller and associated IRQ domain with
> fwnode, so they will find their place in the hierarchy in sysfs and also
> make easier to debug.
>
> Signed-off-by: Andy Shevchenko
> ---
>
> Hans, unfortunately I have n
fixed the acer-wmi.c case
a couple of weeks ago, and that fiox was merged into Linus' tree already:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ef14f0e82c9b225ae19476fa5bed89d55b2a96d5
I can drop the acer-wmi.c chunks when I merge this, so there is no
need to
Hi,
On 2/24/21 1:51 PM, Andy Shevchenko wrote:
> On Tue, Feb 23, 2021 at 08:25:35PM +0100, Hans de Goede wrote:
>> On 2/23/21 6:22 PM, Andy Shevchenko wrote:
>>> It's better to describe the I²C controller and associated IRQ domain with
>>> fwnode, so they will find
led by quirk to
> prevent them from keeping the driver loaded if only disabled capabilities
> are found.
>
> Fixes: 4f8217d5b0ca ("mfd: Intel Platform Monitoring Technology support")
> Signed-off-by: David E. Box
> Reviewed-by: Hans de Goede
> ---
> For merge in platfo
t
> Signed-off-by: Wei Yongjun
Thank you for catching this.
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/mfd/arizona-spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/arizona-spi.c b/drivers/
Logging an error when kmalloc fails is not necessary (and in general
should be avoided) because the malloc failure will already complain
loudly itself.
Signed-off-by: Hans de Goede
---
drivers/misc/lis3lv02d/lis3lv02d.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a
bug.cgi?id=1817027
BugLink: https://bugs.centos.org/view.php?id=10720
Fixes: 1510dd5954be ("lis3lv02d: avoid divide by zero due to unchecked")
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede
---
drivers/misc/lis3lv02d/lis3lv02d.c | 21 -
1 file changed, 16
handling the
device and it silences the pr_warn printing the third message.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199715
Signed-off-by: Hans de Goede
---
Note this does not resolve the bko 199715 bug, it merely silences the
message which was used in the Summary when the bug was first
Hi,
On 2/19/21 12:26 AM, Limonciello, Mario wrote:
>
>
>> -Original Message-
>> From: mark gross
>> Sent: Thursday, February 18, 2021 16:49
>> To: Limonciello, Mario
>> Cc: Hans De Goede; Mark Gross; LKML; platform-driver-...@vger.kernel.org;
&
Hi,
On 1/29/21 5:08 AM, Lukas Bulwahn wrote:
> Commit d7cbe2773aed ("platform/x86: thinkpad_acpi: set keyboard language")
> adds information on keyboard setting to the thinkpad documentation, but
> made the subsection title underline too short.
>
> Hence, make htmldocs warns:
>
> Documentation
Hi,
On 1/5/21 2:14 PM, Jiaxun Yang wrote:
> Add support to ideapad-laptop for Lenovo platforms that have DYTC
> version 5 support or newer to use the platform profile feature.
>
> Mostly based on Mark Pearson 's thinkpad-acpi
> work but massaged to fit ideapad driver.
>
> Note that different fro
Hi,
On 1/21/21 5:50 AM, Pan Bian wrote:
> Put the PCI device rdev on error paths to fix potential reference count
> leaks.
>
> Signed-off-by: Pan Bian
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-driv
tied to the
> lifetime of device itself.
>
> Signed-off-by: Heikki Krogerus
> Cc: Hans de Goede
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/usb/host/xhci-ext-caps.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
hi,
On 1/26/21 8:37 AM, Lubomir Rintel wrote:
> Hi,
>
> chained to this message is a couple of fixes related to OLPC EC platform
> code. Please take a look and consider applying to platform-drivers-x86.
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://gi
-sysman:
- fix a NULL pointer dereference
hp-wmi:
- Disable tablet-mode reporting by default
Hans de Goede (1):
platform/x86: hp-wmi: Disable tablet-mode reporting by default
Mario Limonciello (1):
platform/x86: dell-wmi
501 - 600 of 2701 matches
Mail list logo
