Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices

2021-02-15 Thread Hans de Goede
Hi, On 2/15/21 3:54 PM, Rafael J. Wysocki wrote: > On Mon, Feb 15, 2021 at 3:36 PM Hans de Goede wrote: >> >> Hi, >> >> On 2/11/21 9:16 PM, Maximilian Luz wrote: >>> This series adds a driver to provide platform profile support on 5th- >>> and late

Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices

2021-02-15 Thread Hans de Goede
Hi, On 2/15/21 3:54 PM, Rafael J. Wysocki wrote: > On Mon, Feb 15, 2021 at 3:36 PM Hans de Goede wrote: >> >> Hi, >> >> On 2/11/21 9:16 PM, Maximilian Luz wrote: >>> This series adds a driver to provide platform profile support on 5th- >>> and late

Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices

2021-02-15 Thread Hans de Goede
Hi, On 2/15/21 4:29 PM, Rafael J. Wysocki wrote: > On Mon, Feb 15, 2021 at 4:22 PM Hans de Goede wrote: >> >> Hi, >> >> On 2/15/21 3:54 PM, Rafael J. Wysocki wrote: >>> On Mon, Feb 15, 2021 at 3:36 PM Hans de Goede wrote: >>>> >>>

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-07 Thread Hans de Goede
Hi Thomas, Thank you for your new driver and thank you for the quick respin addressing Barnabás' request to make it a WMI driver. The code looks good, so merging this should be a no-brainer, yet I'm not sure if I should merge this driver as-is, let me explain. The problem is that I assume that t

Re: [PATCH] platform/surface: aggregator_registry: Give devices time to set up when connecting

2021-04-07 Thread Hans de Goede
Hi, On 4/6/21 1:12 AM, Maximilian Luz wrote: > Sometimes, the "base connected" event that we rely on to (re-)attach the > device connected to the base is sent a bit too early. When this happens, > some devices may not be completely ready yet. > > Specifically, the battery has been observed to rep

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

2021-04-08 Thread Hans de Goede
Hi, On 4/7/21 11:15 AM, Zhen Lei wrote: > Fixes the following W=1 kernel build warning: > > drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined > but not used [-Wunused-const-variable=] > > The reference to the variable 'tcpm_altmode_ops' is deleted by the > commit a07997

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Hans de Goede
Hi, On 4/7/21 9:43 PM, Thomas Weißschuh wrote: > Hi Hans, > > On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: >> Thank you for your new driver and thank you for the quick respin >> addressing Barnabás' request to make it a WMI driver. >> >> The code look

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

2021-04-08 Thread Hans de Goede
Hi, On 4/8/21 11:25 AM, Heikki Krogerus wrote: > On Thu, Apr 08, 2021 at 11:10:38AM +0200, Hans de Goede wrote: >> Hi, >> >> On 4/7/21 11:15 AM, Zhen Lei wrote: >>> Fixes the following W=1 kernel build warning: >>> >>> drivers/usb/typec/tcpm/tcp

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2021-04-08 Thread Hans de Goede
Hi all, On 4/8/21 2:13 PM, Stephen Rothwell wrote: > Hi all, > > Commit > > 11cccec79c60 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()") > > is missing a Signed-off-by from its committer. Ugh, thanks for letting me know, this was supposed to come from a merge from an immutable branch fr

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Hans de Goede
Hi Guenter, On 4/8/21 5:08 PM, Guenter Roeck wrote: > On Mon, Apr 05, 2021 at 10:48:10PM +0200, Thomas Weißschuh wrote: >> Changes since v1: >> * Incorporate feedback from Barnabás Pőcze >> * Use a WMI driver instead of a platform driver >> * Let the kernel manage the driver lifecycle >> * F

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

2021-04-08 Thread Hans de Goede
Hi, On 4/8/21 3:55 PM, Guenter Roeck wrote: > On 4/8/21 1:28 AM, Heikki Krogerus wrote: >> On Wed, Apr 07, 2021 at 05:15:40PM +0800, Zhen Lei wrote: >>> Fixes the following W=1 kernel build warning: >>> >>> drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined >>> but not use

Re: USB autosuspend and turning of usb pendrive leds

2007-09-24 Thread Hans de Goede
Oliver Neukum wrote: Am Freitag 21 September 2007 schrieb Jiri Kosina: On Fri, 21 Sep 2007, Hans de Goede wrote: Thats not what I had in mind, autosuspend doesn't work (presumably because hal keeps polling for media change) maybe I should fix hal to not keep polling for devices which

Re: [GIT PATCH] USB autosuspend fixes for 2.6.23-rc6

2007-09-18 Thread Hans de Goede
Hi all, Please keep me CC-ed I'm not on the list. I just found out about this thread while ivnestegating some autosuspend problems, which I will describe in another list. stern at rowland wrote: > Linus Torvalds wrote: > > - US_FL_FIX_CAPACITY: > > This is a generic SCSI issue, not a USB one

USB autosuspend and turning of usb pendrive leds

2007-09-21 Thread Hans de Goede
Hi All, Please keep me CC-ed as I'm not subscribed. Some time ago a mail about turning of the leds on usb pendrives once unmounted by hal was send to the fedora-devel list: https://www.redhat.com/archives/fedora-devel-list/2007-August/msg01807.html This mail talked about echo 2 > power/state

Re: USB autosuspend and turning of usb pendrive leds

2007-09-21 Thread Hans de Goede
Jiri Kosina wrote: On Fri, 21 Sep 2007, Hans de Goede wrote: 1) Would it be possible to funtionality to the kernel to suspend a device in such a way that it will automatically unsuspend when used again? It is possible - USB now supports autosuspend. After a long debate, it was however

Re: [linux-usb-devel] USB autosuspend and turning of usb pendrive leds

2007-09-22 Thread Hans de Goede
Alan Stern wrote: The correct answer is that HAL should top polling while the device is suspended. In kernels starting with 2.6.23-rc6, the correct way to enable autosuspend for a USB device is basically like this: echo D >/sys/bus/usb/devices/.../power/autosuspend echo auto

Re: [linux-usb-devel] USB autosuspend and turning of usb pendrive leds

2007-09-22 Thread Hans de Goede
Alan Stern wrote: On Sat, 22 Sep 2007, Hans de Goede wrote: I'm afraid that that doesn't work for usb mass-storage devices. Here is what I did: 1) kill hal 2) insert usb stick -> led lights 3): echo -n 1 >/sys/bus/usb/devices/.../power/autosuspend echo -n auto > /

Re: [PATCH] [media] gspca_touptek: Add support for ToupTek UCMOS series USB cameras

2015-01-05 Thread Hans de Goede
Hi John, On 01-12-14 03:27, John McMaster wrote: Adds support for AmScope MU800 / ToupTek UCMOS08000KPB USB microscope camera. Signed-off-by: John McMaster Thanks, I've added this driver to my gspca tree, and asked Mauro to queue it up for 3.20. Regards, Hans --- drivers/media/usb/gspc

Re: [PATCH 3/3] ata: libahci: Allow to use multiple regulators

2014-12-27 Thread Hans de Goede
Hi Gregory, Thanks for working on this. Overall the patch-set / concept looks good, you can add "Acked-by: Hans de Goede " to the first 2 patches. I've some comments on this patch, see below. On 27-12-14 11:34, Gregory CLEMENT wrote: The current implementation of the libah

Re: [PATCH 3/3] ata: libahci: Allow to use multiple regulators

2014-12-27 Thread Hans de Goede
Hi, On 27-12-14 13:58, Hans de Goede wrote: Hi Gregory, Thanks for working on this. Overall the patch-set / concept looks good, you can add "Acked-by: Hans de Goede " to the first 2 patches. I've some comments on this patch, see below. On 27-12-14 11:34, Gregory CLEMENT wrot

Re: [PATCH] nouveau: fix ambiguous backlight controls

2014-12-27 Thread Hans de Goede
Hi, On 27-12-14 00:51, Jeremiah Mahler wrote: Ilia, On Fri, Dec 26, 2014 at 04:39:08PM -0500, Ilia Mirkin wrote: On Fri, Dec 26, 2014 at 4:26 PM, Jeremiah Mahler wrote: If a display supports backlight control using the nouveau driver, and also supports standard ACPI backlight control, there

Re: [PATCH] nouveau: fix ambiguous backlight controls

2014-12-28 Thread Hans de Goede
Hi, On 28-12-14 15:30, Jeremiah Mahler wrote: Hans, On Sat, Dec 27, 2014 at 02:39:42PM +0100, Hans de Goede wrote: Hi, On 27-12-14 00:51, Jeremiah Mahler wrote: Ilia, On Fri, Dec 26, 2014 at 04:39:08PM -0500, Ilia Mirkin wrote: On Fri, Dec 26, 2014 at 4:26 PM, Jeremiah Mahler wrote: If

Re: sunxi-project-meetup@31c3

2014-12-29 Thread Hans de Goede
Hi, On 28-12-14 20:32, David Lanzendörfer wrote: Hello folks Is anyone of you at the Chaos Communication Congress? I'd like to organize a table for sunxi-linux-project I'm not attending 31c3, so count me out. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH] Input: synaptics - switch ForcePad detection to PNP IDs

2014-12-30 Thread Hans de Goede
Hi, Looks good to me: Acked-by: Hans de Goede Regards, Hans On 29-12-14 23:51, Dmitry Torokhov wrote: According to Synaptics devices with ForcePads use SYN300D and SYN3014 as PNP IDs, so let's switch from DMI-bases detection scheme to PNP-based one, which should be more rel

Re: [PATCH] Input: psmouse - use IS_ENABLED instead of homegrown code

2014-12-30 Thread Hans de Goede
Hi, Looks good to me: Acked-by: Hans de Goede Regards, Hans On 29-12-14 21:11, Dmitry Torokhov wrote: Instead of having various protocols provide _supported() functions, let's use IS_ENABLED() macro that works well in "if" statements. Signed-off-by: Dmitry Torokhov ---

Re: [PATCH] Revert "usb: Reset USB-3 devices on USB-3 link bounce"

2015-01-26 Thread Hans de Goede
Hi, On 26-01-15 16:30, Zhuang Jin Can wrote: This revert a82b76f7fa6154e8ab2d8071842a3e38b9c0d0ff. The commit causes an extra reset in remote wakeup as described in: http://www.spinics.net/lists/linux-usb/msg119080.html Signed-off-by: Zhuang Jin Can No objection from me (*) against revertin

Re: [PATCH v3 3/4] ata: libahci: Allow using multiple regulators

2015-01-15 Thread Hans de Goede
Hi, On 13-01-15 15:22, Gregory CLEMENT wrote: The current implementation of the libahci allows using multiple PHYs but not multiple regulators. This patch adds the support of multiple regulators. Until now it was mandatory to have a PHY under a subnode, now a port subnode can contain either a re

Re: [3/5, media] pwc-if: fix build warning when !CONFIG_USB_PWC_INPUT_EVDEV

2015-01-15 Thread Hans de Goede
Hi, On 02-10-14 01:10, Luis Henriques wrote: Label err_video_unreg in function usb_pwc_probe() is only used when CONFIG_USB_PWC_INPUT_EVDEV is defined. drivers/media/usb/pwc/pwc-if.c:1104:1: warning: label 'err_video_unreg' defined but not used [-Wunused-label] Signed-off-by: Luis Henriques

Re: [PATCH 1/1] gspca: Add high-speed modes for PS3 Eye camera

2015-01-15 Thread Hans de Goede
Hi, On 04-01-15 16:29, Antonio Ospite wrote: On Mon, 29 Dec 2014 11:00:03 -0400 Joe Howse wrote: Add support in the PS3 Eye driver for QVGA capture at higher frame rates: 187, 150, and 137 FPS. This functionality is valuable because the PS3 Eye is popular for computer vision projects and no o

Re: [PATCH v2 2/4] Documentation: bindings: Add the regulator property to the sub-nodes AHCI bindings

2015-01-09 Thread Hans de Goede
Hi, On 09-01-15 11:39, Gregory CLEMENT wrote: It is now possible to use a regulator property for each port of the AHCI controller. Signed-off-by: Gregory CLEMENT --- Documentation/devicetree/bindings/ata/ahci-platform.txt | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff

Re: [PATCH v2 2/4] Documentation: bindings: Add the regulator property to the sub-nodes AHCI bindings

2015-01-10 Thread Hans de Goede
Hi, On 09-01-15 18:11, Mark Brown wrote: On Sat, Jan 10, 2015 at 12:29:32AM +0800, Chen-Yu Tsai wrote: Since the AHCI library code already supports the generic phy subsystem, with one phy possible for each port node, you could possibly add a generic phy that just takes a regulator, and hook it

Re: [PATCH v2 2/4] Documentation: bindings: Add the regulator property to the sub-nodes AHCI bindings

2015-01-10 Thread Hans de Goede
Hi, On 10-01-15 12:17, Mark Brown wrote: On Sat, Jan 10, 2015 at 11:20:13AM +0100, Hans de Goede wrote: On 09-01-15 18:11, Mark Brown wrote: Or if the supply is for the device at the other end of the link (which is what it sounded like) then use that. This just sounds like the same problem

Re: [PATCH v4 0/4] ata: libahci: Allow using a regulator for each port

2015-01-16 Thread Hans de Goede
of this version is the use of ahci_platform_put_resources to put the reference to the regulators. Thanks, Grégory Thanks, patches 1 - 3 look good and are: Acked-by: Hans de Goede Tejun, can you please queue up 1 - 3 ? I still have some remarks wrt patch 4 (*), and it should probably go

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Hans de Goede
Hi, On 15-01-15 15:09, Gregory CLEMENT wrote: Add the regulators to each SATA port. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-388-gp.dts | 126 1 file changed, 126 insertions(+) diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Hans de Goede
Hi, On 16-01-15 10:27, Gregory CLEMENT wrote: Hi Hans, On 16/01/2015 09:17, Hans de Goede wrote: Hi, On 15-01-15 15:09, Gregory CLEMENT wrote: Add the regulators to each SATA port. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-388-gp.dts | 126

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Hans de Goede
Hi, On 16-01-15 13:37, Mark Brown wrote: On Fri, Jan 16, 2015 at 11:10:18AM +0100, Hans de Goede wrote: On 16-01-15 10:27, Gregory CLEMENT wrote: + reg_sata0: pwr-sata0 { + compatible = "regulator-fixed"; + regulator-name = &qu

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Hans de Goede
Hi, On 16-01-15 16:34, Mark Brown wrote: On Fri, Jan 16, 2015 at 03:27:00PM +0100, Gregory CLEMENT wrote: On 16/01/2015 13:37, Mark Brown wrote: regulator-always-on is a bit fuzzy for suspend, if the regulator has suspend control it'll kick in - it's really about the Linux refcounting while

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-17 Thread Hans de Goede
Hi, On 16-01-15 21:25, Mark Brown wrote: On Fri, Jan 16, 2015 at 08:12:28PM +0100, Hans de Goede wrote: On 16-01-15 13:37, Mark Brown wrote: It is probably a good idea to use regulator-boot-on and then test things this way, and if that works use regulator-boot-on. No, it's unlikely

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-17 Thread Hans de Goede
Hi, On 17-01-15 14:14, Mark Brown wrote: On Sat, Jan 17, 2015 at 09:48:57AM +0100, Hans de Goede wrote: and leave these regulators on, rather then turn them of $random time, because as I've advocated before (see the simplefb thread) there is no simple magic moment when it is right to

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-18 Thread Hans de Goede
Hi, On 18-01-15 13:35, Mark Brown wrote: On Sat, Jan 17, 2015 at 03:28:39PM +0100, Hans de Goede wrote: On 17-01-15 14:14, Mark Brown wrote: Following your argument to the logical conclusion means we can never turn any regualtor off - we always have the risk that there's another shared

Re: [linux-sunxi] Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

2015-01-27 Thread Hans de Goede
Hi, On 27-01-15 10:49, Priit Laes wrote: On Tue, 2015-01-27 at 10:18 +0100, Maxime Ripard wrote: Hi, On Mon, Jan 26, 2015 at 06:58:32PM +0200, Priit Laes wrote: --- Like Hans was pointing out, commit log and signed-off-by please .../ABI/testing/sysfs-driver-input-sun4i-lradc | 4 +

Re: [PATCH 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY

2015-03-19 Thread Hans de Goede
Hi, On 19-03-15 16:53, Brian Norris wrote: Hi Hans, Thanks for the review. On Thu, Mar 19, 2015 at 12:10:25PM +0100, Hans de Goede wrote: On 19-03-15 02:23, Brian Norris wrote: Signed-off-by: Brian Norris --- Light dependency on: http://lists.infradead.org/pipermail/linux-arm-kernel

Re: [PATCH 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY

2015-03-20 Thread Hans de Goede
Hi, On 19-03-15 20:11, Brian Norris wrote: Replying to myself, because I may or may not like having conversations with myself :) On Thu, Mar 19, 2015 at 10:36:40AM -0700, Brian Norris wrote: On Thu, Mar 19, 2015 at 06:02:16PM +0100, Hans de Goede wrote: On 19-03-15 16:53, Brian Norris wrote

Re: [PATCH 4/5] phy: add Broadcom SATA3 PHY driver for Broadcom STB SoCs

2015-03-21 Thread Hans de Goede
Hi, On 21-03-15 00:02, Florian Fainelli wrote: On 18/03/15 18:23, Brian Norris wrote: Supports up to two ports which can each be powered on/off and configured independently. Signed-off-by: Brian Norris --- [snip] + +static const struct of_device_id brcmstb_sata_phy_of_match[] = { +

Re: [PATCH v3 0/5] clocksource: sun5i: Support parent clock rate changes

2015-03-21 Thread Hans de Goede
Hi, On 20-03-15 21:56, Maxime Ripard wrote: Hi, On Fri, Mar 20, 2015 at 03:04:28PM +0100, Daniel Lezcano wrote: On 03/19/2015 11:53 PM, Maxime Ripard wrote: Hi Daniel, On Thu, Mar 05, 2015 at 11:20:51AM +0100, Maxime Ripard wrote: Hi, The Allwinner HS timers have the AHB clock as their par

Re: [PATCH] Input: ALPS - fix max coordinates for v5 and v7 protocols

2015-03-22 Thread Hans de Goede
lues for X and Y axes which resulted in crash in Synaptics X driver. Reported-by: Santiago Gala Reported-by: Pali Rohár Signed-off-by: Dmitry Torokhov Fix looks good to me: Acked-by: Hans de Goede Regards, Hans --- drivers/input/mouse/alps.c | 11 ++- 1 file changed, 6 insert

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-23 Thread Hans de Goede
Hi, On 22-03-15 14:46, Pali Rohár wrote: This patch adds detection of trackstick for v7 protocol devices. Code in this patch is used in official Dell touchpad linux drivers for Dell models: Dell Latitude E5250/5250, E5450/5450, E5550/5550 Detection code and base reg for alps v3 rushmore and v7

Re: [PATCH] Input: ALPS - Report v3 pinnacle trackstick device only if is present

2015-03-23 Thread Hans de Goede
de Goede Regards, Hans --- drivers/input/mouse/alps.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index c9cd27a..d24e98d 100644 --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c

Re: [PATCHv3 0/4] add devm_of_phy_get_by_index and update platform drivers

2015-04-23 Thread Hans de Goede
tions(+), 98 deletions(-) Patch set looks good to me: Acked-by: Hans de Goede Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: [PATCH 0/3] Balanced slots, attempt #2

2015-03-31 Thread Hans de Goede
third finger. Cheers, Benjamin The entire set looks good to me: Acked-by: Hans de Goede Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [linux-sunxi] Re: [PATCH 2/3] spidev: Add DT binding example.

2015-04-26 Thread Hans de Goede
Hi, On 26-04-15 13:01, Mark Brown wrote: On Sun, Apr 26, 2015 at 12:54:36PM +0200, Michal Suchanek wrote: On 26 April 2015 at 12:32, Mark Brown wrote: No, this is broken - nothing should ever bind to spidev as spidev. The fact that we have a binding document at all is a bug. And how do

Re: [linux-sunxi] [PATCH 2/3] spidev: Add DT binding example.

2015-04-26 Thread Hans de Goede
Hi, I've a feeling everyone in this thread is ignoring the raspberry pi use-case. Where the board is specifically designed for educational purposes and used with lots of peripherals which are usually programmed from userspace using e.g. python bindings for i2c-dev or spidev, for such a setup we r

Re: [linux-sunxi] [PATCH 2/3] spidev: Add DT binding example.

2015-04-27 Thread Hans de Goede
Hi Mark, On 27-04-15 11:36, Mark Brown wrote: On Sun, Apr 26, 2015 at 04:14:33PM +0200, Michal Suchanek wrote: On 26 April 2015 at 14:51, Maxime Ripard No, you add a compatible for the device that is connected to the bus through that slot. There is no device connected in the slot by desig

Re: [linux-sunxi] [PATCH 2/3] spidev: Add DT binding example.

2015-04-27 Thread Hans de Goede
Hi, On 27-04-15 12:04, Hans de Goede wrote: Hi Mark, On 27-04-15 11:36, Mark Brown wrote: On Sun, Apr 26, 2015 at 04:14:33PM +0200, Michal Suchanek wrote: On 26 April 2015 at 14:51, Maxime Ripard No, you add a compatible for the device that is connected to the bus through that slot

Re: 4.0.0-rc mouse/keyboard events get stuck

2015-04-08 Thread Hans de Goede
Hi, On 08-04-15 12:59, Hans de Bruin wrote: On 04/06/2015 11:23 PM, Dmitry Torokhov wrote: Hi Hans, On Mon, Apr 6, 2015 at 11:39 AM, Hans de Bruin wrote: Since 4.0.0-rc something mu laptop has some mouse /keyboard problems. When I play KDE kpatience, a card game, card stick to my mousepointe

Re: 4.0.0-rc mouse/keyboard events get stuck

2015-04-08 Thread Hans de Goede
ip up a patch and submit it when it is ready. Regards, Hans >From 45442ba53c07570a4a9fce730b731449dc90ee87 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Wed, 8 Apr 2015 16:21:40 +0200 Subject: [PATCH] alps: Fix left touchpad button getting stuck when using it with trackpoint When the

[PATCH 4.0 REGRESSION FIX] alps: Fix left touchpad button getting stuck when using it with trackpoint

2015-04-08 Thread Hans de Goede
s, so that alps_report_buttons correctly detect that we're already reporting the button as pressed via the touchpad evdev node, and will also send the release event there. Reported-by: Hans de Bruin Signed-off-by: Hans de Goede --- drivers/input/mouse/alps.c | 5 +++-- 1 file changed, 3 i

[PATCH 4.0 REGRESSION FIX 0/1] alps: Fix left touchpad button getting stuck

2015-04-08 Thread Hans de Goede
Hi Linus, Dmitry, Sorry for the last minute regression fix, but the existence of this regression was not entirely clear until Hans de Bruin send a very clear reproducer this morning. I'm not sure if this is 4.0 material, it does fix a real regression, the fix is pretty simple and safe (*), and wh

Re: 4.0.0-rc mouse/keyboard events get stuck

2015-04-08 Thread Hans de Goede
and ts-l, It does not work. Al other combinations do. Attached is a patch which fixes this for me on my d620, please test both patches. Thanks & Regards, Hans >From b4039f30e8a5b7b2f0002d137265a869cdb95403 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Wed, 8 Apr 2015 17:52:36

Re: [PATCH next] Input: alps_get_pkt_id_ss4_v2() can be static

2015-04-10 Thread Hans de Goede
Hi, On 04/11/2015 03:21 AM, kbuild test robot wrote: Signed-off-by: Fengguang Wu Ack, these should all be static: Acked-by: Hans de Goede Dmitry, can you please merge this one ? Regards, Hans --- alps.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH] drivers/usb/core: devio.c: Removed various errors and warnings generated by checkpatch.pl

2015-04-11 Thread Hans de Goede
to me: Acked-by: Hans de Goede Regards, Hans --- drivers/usb/core/devio.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 1163553..62c0be6 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb

Re: [PATCH 2/2] mmc: sunxi: Also set SDXC_LOW_POWER_ON

2015-05-28 Thread Hans de Goede
Hi, On 28-05-15 10:02, Ulf Hansson wrote: On 25 May 2015 at 09:02, Hans de Goede wrote: Hi, On 24-05-15 20:04, Michal Suchanek wrote: The function sunxi_mmc_oclk_onoff filters out the SDXC_LOW_POWER_ON flag but never sets it. Set SDXC_LOW_POWER_ON when oclk is disabled. Nack, looking

Re: [PATCH] [media] gscpa_m5602: use msecs_to_jiffies for conversions

2015-06-23 Thread Hans de Goede
Hi, On 07-06-15 16:34, Nicholas Mc Guire wrote: API compliance scanning with coccinelle flagged: ./drivers/media/usb/gspca/m5602/m5602_s5k83a.c:180:9-25: WARNING: timeout (100) seems HZ dependent Numeric constants passed to schedule_timeout() make the effective timeout HZ dependent whi

Re:

2015-05-31 Thread Hans de Goede
Hi Roman, On 31-05-15 17:37, Roman Volkov wrote: В Sat, 14 Mar 2015 20:20:38 -0700 Dmitry Torokhov wrote: Hi Roman, On Mon, Feb 16, 2015 at 12:11:43AM +0300, Roman Volkov wrote: Documentation for 'intel,8042' DT compatible node. Signed-off-by: Tony Prisk Signed-off-by: Roman Volkov ---

Re: [PATCH v2 2/2] drivers: ata: add support for Ceva sata host controller

2015-06-09 Thread Hans de Goede
Hi, On 09-06-15 07:27, Tejun Heo wrote: cc'ing Hans and quoting whole message. Hans, can you please review this one? Done. I've one remark ceva_ahci_probe() is not calling ahci_platform_enable_resources() (and disable_resources again if the ahci_platform_init_host() fails). I guess that cu

Re: [PATCH v3 2/2] drivers: ata: add support for Ceva sata host controller

2015-06-09 Thread Hans de Goede
Hi, On 06/09/2015 10:57 AM, Tejun Heo wrote: cc'ing Hans again. Please always cc Hans for platform ahci drivers. Hans, does this look ready now? Yes looks good to me: Acked-by: Hans de Goede Regards, Hans Thanks. On Tue, Jun 09, 2015 at 02:23:50PM +0530, Suneel Garapati wrote:

Re: [PATCH v2 1/3] usb: roles: intel_xhci: Always allow user control

2018-05-23 Thread Hans de Goede
b_get_role, + .allow_userspace_control = true, }; static int intel_xhci_usb_probe(struct platform_device *pdev) I hate to be pedantic here, but the sw_desc can and should be made const now, with that fixed the entire series is: Reviewed-by: Hans de Goede Regards, Hans @@ -146,7 +133,6 @@

Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-28 Thread Hans de Goede
Hi, On 27-02-18 15:07, Hans de Goede wrote: Hi, On 27-02-18 03:29, Brian Norris wrote: On Thu, Feb 22, 2018 at 11:14 PM, Hans de Goede wrote: On 23-02-18 04:12, Brian Norris wrote: Hmm? I'm not sure I completely follow here when you say "he was not hitting the firmware loading

Re: [PATCH v1] extcon: int3496: Ignore incorrect IoRestriction for ID pin

2018-02-28 Thread Hans de Goede
PI library does it in generic way, just set I recommend that you specify clearly which patch you mention about GPIO ACPI library. Do you mean list all of them? It's a bit hard to choose one. an appropriate quirk flag instead. Cc: Hans de Goede Signed-off-by: Andy Shevchenko --- driv

Re: [PATCH v1] extcon: int3496: Ignore incorrect IoRestriction for ID pin

2018-02-28 Thread Hans de Goede
Hi, On 26-02-18 20:34, Andy Shevchenko wrote: The commit 70216fd937fe introduced a workaround for incorrect IoRestriction mode in ACPI table. Now, when GPIO ACPI library does it in generic way, just set an appropriate quirk flag instead. Cc: Hans de Goede Signed-off-by: Andy Shevchenko

[PATCH v5 11/12] platform/x86: intel_cht_int33fe: Add device connections for the Type-C port

2018-02-28 Thread Hans de Goede
We need to add device-connections for the Type-C mux/switch and usb-role code to be able to find the PI3USB30532 Type-C cross-switch and the device/host role-switch integrated in the CHT SoC. Reviewed-by: Heikki Krogerus Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in

[PATCH v5 09/12] usb: roles: Add Intel xHCI USB role switch driver

2018-02-28 Thread Hans de Goede
/modify of cfg0 may race with the AML code doing the same to avoid this we take the global ACPI lock while doing the read/write/modify. Reviewed-by: Andy Shevchenko Reviewed-by: Heikki Krogerus Signed-off-by: Hans de Goede --- Changes in v4: -Add Andy's Reviewed-by -Add Heikki's Reviewed-b

[PATCH v5 04/12] usb: common: Small class for USB role switches

2018-02-28 Thread Hans de Goede
simple API for the USB Type-C drivers for the control. For other types of USB connectors (mainly microAB) the class provides user space control via sysfs attribute file that can be used to request role swapping from the switch. Signed-off-by: Heikki Krogerus Reviewed-by: Hans de Goede Reviewed-by

[PATCH v5 05/12] usb: typec: tcpm: Set USB role switch to device mode when configured as such

2018-02-28 Thread Hans de Goede
mode after a detach. Reviewed-by: Heikki Krogerus Reviewed-by: Guenter Roeck Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v4: -Add Andy's Reviewed-by Changes in v3: -Add Guenter's Reviewed-by Changes in v2: -Added Heikki's Reviewed-by --- drivers/u

[PATCH v5 12/12] extcon: axp288: Set USB role where necessary

2018-02-28 Thread Hans de Goede
INT3496 ACPI device -Charger-type misdetection (always SDP) on devices with an INT3496 when the USB role (always) gets initialized as host Reviewed-by: Heikki Krogerus Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v4: -Add Andy's Reviewed-by Changes in v2: -Add de

[PATCH v5 08/12] xhci: Add Intel extended cap / otg phy mux handling

2018-02-28 Thread Hans de Goede
Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v4: -Add Andy's Reviewed-by Changes in v2: -Use SPDX license header -Various small style cleanups / changes -Add Heikki's Reviewed-by Changes from some time ago when this patch was part of another patch-set: -

[PATCH v5 03/12] usb: typec: API for controlling USB Type-C Multiplexers

2018-02-28 Thread Hans de Goede
Krogerus Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v4: -Add Andy's Reviewed-by Changes in v3: -Add #include-s for a few missing headers to drivers/usb/typec/mux.c -Various spelling and gramar fixes in the docs pointed out by Randy D

[PATCH v5 07/12] xhci: Add option to get next extended capability in list by passing id = 0

2018-02-28 Thread Hans de Goede
when we want to loop through all capabilities. Signed-off-by: Mathias Nyman Reviewed-by: Heikki Krogerus Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v4: -Add Andy's Reviewed-by Changes in v2: -Added Heikki's Reviewed-by --- drivers/usb/host/xhci-ext-

[PATCH v5 10/12] usb: typec: driver for Pericom PI3USB30532 Type-C cross switch

2018-02-28 Thread Hans de Goede
Add a driver for the Pericom PI3USB30532 Type-C cross switch / mux chip found on some devices with a Type-C port. Reviewed-by: Heikki Krogerus Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v4: -Add Andy's Reviewed-by Changes in v2: -Cleanup pi3usb30532_set

[PATCH v5 06/12] usb: typec: tcpm: Use new Type-C switch/mux and usb-role-switch functions

2018-02-28 Thread Hans de Goede
Remove the unused (not implemented anywhere) tcpc_mux_dev abstraction and replace it with calling the new typec_set_orientation, usb_role_switch_set and typec_set_mode functions. Reviewed-by: Heikki Krogerus Reviewed-by: Guenter Roeck Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede

[PATCH v5 02/12] usb: typec: Start using ERR_PTR

2018-02-28 Thread Hans de Goede
example is because handling them in the port drivers would be just boilerplate. Signed-off-by: Heikki Krogerus Reviewed-by: Hans de Goede Reviewed-by: Guenter Roeck Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v4: -Add Andy's Reviewed-by Changes in v3: -Add Guen

[PATCH v5 00/12] USB Type-C device-connection, mux and switch support

2018-02-28 Thread Hans de Goede
Hi All, Here is version 5 of Heikki's and my USB Type-C device-connection, mux and switch support series. Versions 2 - 5 bring various small code and style fixes based on review (no major changes). Here is the original cover-letter of v1: Some devices with an USB Type-C connector have a bunch of

[PATCH v5 01/12] drivers: base: Unified device connection lookup

2018-02-28 Thread Hans de Goede
connection lookup, but the goal is to ultimately extract the connection descriptions also from firmware by using the fwnode_graph_* functions and other mechanisms that are available. Signed-off-by: Heikki Krogerus Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede

Re: [PATCH v4 01/12] drivers: base: Unified device connection lookup

2018-02-28 Thread Hans de Goede
Hi, On 26-02-18 20:34, Randy Dunlap wrote: On 02/26/2018 10:39 AM, Hans de Goede wrote: diff --git a/include/linux/connection.h b/include/linux/connection.h new file mode 100644 index ..0b4430eae53a --- /dev/null +++ b/include/linux/connection.h @@ -0,0 +1,33 @@ +// SPDX-License

Re: [PATCH v5 08/12] xhci: Add Intel extended cap / otg phy mux handling

2018-02-28 Thread Hans de Goede
Hi, On 28-02-18 16:15, Heikki Krogerus wrote: On Wed, Feb 28, 2018 at 04:07:45PM +0100, Hans de Goede wrote: diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h index 96099a245c69..5917e3095e2a 100644 --- a/drivers/usb/host/xhci.h +++ b/drivers/usb/host/xhci.h @@ -1825,6 +1825,7

Re: [PATCH v5 01/12] drivers: base: Unified device connection lookup

2018-03-01 Thread Hans de Goede
Hi, On 01-03-18 10:32, Andy Shevchenko wrote: On Thu, Mar 1, 2018 at 9:28 AM, Heikki Krogerus wrote: Hi, On Thu, Mar 01, 2018 at 12:56:57AM +, Jun Li wrote: +struct device *device_find_connection(struct device *dev, const char +*con_id) { + return __device_find_connection(dev, con_id,

Re: [PATCH 8/9] ASoC: Intel: bytcr_rt5640: Drop unwanted ignore_suspend settings

2018-03-01 Thread Hans de Goede
Hi, On 01-03-18 17:22, Mark Brown wrote: On Sun, Feb 18, 2018 at 11:01:45PM +0100, Hans de Goede wrote: The ignore_suspend settings were added in an attempt to try and fix suspend / resume issues. But they never fully fixed these and now we've a proper fix, so lets remove these. Do

Re: [PATCH 8/9] ASoC: Intel: bytcr_rt5640: Drop unwanted ignore_suspend settings

2018-03-01 Thread Hans de Goede
Hi, On 01-03-18 17:48, Mark Brown wrote: On Thu, Mar 01, 2018 at 05:26:06PM +0100, Hans de Goede wrote: On 01-03-18 17:22, Mark Brown wrote: On Sun, Feb 18, 2018 at 11:01:45PM +0100, Hans de Goede wrote: The ignore_suspend settings were added in an attempt to try and fix suspend / resume

Re: [PATCH 2/2] efi: Add embedded peripheral firmware support

2018-04-03 Thread Hans de Goede
Hi Luis, Thank you for the review. On 03-04-18 01:23, Luis R. Rodriguez wrote: On Sat, Mar 31, 2018 at 02:19:44PM +0200, Hans de Goede wrote: Just like with PCI options ROMs, which we save in the setup_efi_pci* functions from arch/x86/boot/compressed/eboot.c, the EFI code / ROM itself

Re: [PATCH 2/3] virt: vbox: Use __get_free_pages instead of kmalloc for DMA32 memory

2018-04-03 Thread Hans de Goede
Hi, On 29-03-18 18:39, Greg Kroah-Hartman wrote: On Thu, Mar 29, 2018 at 03:42:59PM +0200, Hans de Goede wrote: Hi, On 29-03-18 13:58, Greg Kroah-Hartman wrote: On Thu, Mar 29, 2018 at 01:21:15PM +0200, Hans de Goede wrote: It is not possible to get DMA32 zone memory through kmalloc, Why

Re: [PATCH] usb: select USB_COMMON for usb role switch config

2018-04-04 Thread Hans de Goede
this is the right way to fix this (matches the other drivers/usb/Kconfig bits): Reviewed-by: Hans de Goede Regards, Hans --- drivers/usb/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index 75f7fb151f71..987fc5ba6321 100644 --- a/dr

Re: [PATCH 2/2] efi: Add embedded peripheral firmware support

2018-04-04 Thread Hans de Goede
HI, On 04-04-18 19:18, Peter Jones wrote: On Tue, Apr 03, 2018 at 06:58:48PM +, Luis R. Rodriguez wrote: On Tue, Apr 03, 2018 at 08:07:11PM +0200, Lukas Wunner wrote: On Tue, Apr 03, 2018 at 10:33:25AM +0200, Hans de Goede wrote: I asked Peter Jones for suggestions how to extract this

Re: [PATCH] ata: ahci-platform: add reset control support

2018-04-05 Thread Hans de Goede
Hi, On 05-04-18 13:23, Kunihiko Hayashi wrote: Hi Thierry, On Thu, 5 Apr 2018 11:54:29 +0200 Thierry Reding wrote: On Fri, Mar 23, 2018 at 10:30:53AM +0900, Kunihiko Hayashi wrote: Add support to get and control a list of resets for the device as optional and shared. These resets must be ke

Re: [PATCH 2/2] efi: Add embedded peripheral firmware support

2018-04-05 Thread Hans de Goede
Hi, On 03-04-18 21:53, Peter Jones wrote: On Sat, Mar 31, 2018 at 02:19:44PM +0200, Hans de Goede wrote: diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index fddc5f706fd2..1a5ea950f58f 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -455,6

Re: [PATCH] ata: ahci-platform: add reset control support

2018-04-05 Thread Hans de Goede
Hi, On 05-04-18 15:17, Patrice CHOTARD wrote: Hi Thierry On 04/05/2018 11:54 AM, Thierry Reding wrote: On Fri, Mar 23, 2018 at 10:30:53AM +0900, Kunihiko Hayashi wrote: Add support to get and control a list of resets for the device as optional and shared. These resets must be kept de-asserted

Re: [PATCH] ata: ahci-platform: add reset control support

2018-04-05 Thread Hans de Goede
Hi, On 05-04-18 15:54, Thierry Reding wrote: On Thu, Apr 05, 2018 at 03:27:03PM +0200, Hans de Goede wrote: Hi, On 05-04-18 15:17, Patrice CHOTARD wrote: Hi Thierry On 04/05/2018 11:54 AM, Thierry Reding wrote: On Fri, Mar 23, 2018 at 10:30:53AM +0900, Kunihiko Hayashi wrote: Add support

Re: [PATCH] ata: ahci-platform: add reset control support

2018-04-05 Thread Hans de Goede
Hi, On 05-04-18 16:00, Hans de Goede wrote: Hi, On 05-04-18 15:54, Thierry Reding wrote: On Thu, Apr 05, 2018 at 03:27:03PM +0200, Hans de Goede wrote: Hi, On 05-04-18 15:17, Patrice CHOTARD wrote: Hi Thierry On 04/05/2018 11:54 AM, Thierry Reding wrote: On Fri, Mar 23, 2018 at 10:30

Re: [PATCH 2/2] efi: Add embedded peripheral firmware support

2018-04-05 Thread Hans de Goede
pr 03, 2018 at 10:33:25AM +0200, Hans de Goede wrote: This is not part of the standard. There has been a long(ish) standing issue with us not being able to get re-distribute permission for the firmware for some touchscreen controllers found on cheap x86 devices. Which means that we cannot put

[PATCH 2/3] virt: vbox: Use __get_free_pages instead of kmalloc for DMA32 memory

2018-03-29 Thread Hans de Goede
x86_64 guests with more then 4G RAM. Cc: sta...@vger.kernel.org Reported-by: Eloy Coto Pereiro Signed-off-by: Hans de Goede --- drivers/virt/vboxguest/vboxguest_linux.c | 19 --- drivers/virt/vboxguest/vboxguest_utils.c | 5 +++-- 2 files changed, 19 insertions(+), 5 deletions

[PATCH 3/3] virt: vbox: Log an error whenwe fail to get the host version

2018-03-29 Thread Hans de Goede
This was the only error path during probe without a message being logged about what went wrong, this fixes this. Signed-off-by: Hans de Goede --- drivers/virt/vboxguest/vboxguest_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/virt/vboxguest

<    1   2   3   4   5   6   7   8   9   10   >