Re: [PATCH v4] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet

2018-06-18 Thread Hans de Goede
Hi, On 18-06-18 10:43, Hans de Goede wrote: Hi, On 18-06-18 01:58, youling257 wrote: Add touchscreen info for the ONDA V891W Dual OS tablet Nitpick: still missing a period '.' at the end, this should be: Add touchscreen info for the ONDA V891W Dual OS tablet. Reviewed-by: Han

[PATCH v5] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet

2018-06-18 Thread Hans de Goede
From: youling257 Add touchscreen info for hardware revision "v3" of the ONDA V891W Dual OS tablet. Reported-and-tested-by: youling257 Signed-off-by: Hans de Goede --- Changes in v5: -Replaced youlin's S-o-b with mine since youlin does not want to use his real name and I cert

[PATCH] printk: Make CONSOLE_LOGLEVEL_QUIET configurable

2018-06-19 Thread Hans de Goede
less error messages. Signed-off-by: Hans de Goede --- include/linux/printk.h | 6 +++--- lib/Kconfig.debug | 11 +++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/include/linux/printk.h b/include/linux/printk.h index 6d7e800affd8..18602bb3eca8 100644 --- a/inc

Re: [GIT PULL] HID fixes

2018-06-20 Thread Hans de Goede
Hi all, On 20-06-18 06:19, Jiri Kosina wrote: On Wed, 20 Jun 2018, Linus Torvalds wrote: What is that odd binary blob i2c_hid_desc_override, and where does the data come from? Not explained anywhere. Fair enough; it's a pretty standard HID descriptor override, but you're right that we're usu

Re: [PATCH 3/3] platform/x86: silead_dmi: Add touchscreen info for the Onda V891w tablet

2018-05-30 Thread Hans de Goede
Hi, On 29-05-18 13:50, Hans de Goede wrote: Add touchscreen info for the Onda V891w 8.9" windows tablet. Signed-off-by: Hans de Goede Self-NACK I just learned there are 2 hardware revisions with different digitizers which need different firmware, so this needs a more narrow DMI matc

[PATCH v2 1/3] platform/x86: silead_dmi: Add touchscreen info for the Jumper EZpad 6 Pro

2018-05-30 Thread Hans de Goede
Add touchscreen info for the Jumper EZpad 6 Pro. Cc: zy <574249...@qq.com> Reported-and-tested-by: zy <574249...@qq.com> Signed-off-by: Hans de Goede --- drivers/platform/x86/silead_dmi.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/

[PATCH v2 2/3] platform/x86: silead_dmi: Add info for the PoV mobii TAB-P800W (v2.0)

2018-05-30 Thread Hans de Goede
its own entry. Signed-off-by: Hans de Goede --- drivers/platform/x86/silead_dmi.c | 39 +++ 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c index d7a67a53195f..ca49deaa2336 100644

[PATCH v2 3/3] platform/x86: silead_dmi: Add touchscreen info for the Onda V891w tablet

2018-05-30 Thread Hans de Goede
Add touchscreen info for the Onda V891w 8.9" windows tablet. Signed-off-by: Hans de Goede --- Changes in v2: -Match on exact BIOS version there are a v1 and v3 of the hardware which use different digitizers which need different firmware / settings --- drivers/platform/x86/silead_dmi.c

[PATCH] libata: Drop SanDisk SD7UB3Q*G1001 NOLPM quirk

2018-05-31 Thread Hans de Goede
rs problem were triggered by LPM but not an LPM issue, so drop the quirk for the SSD in question. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1583207 Cc: sta...@vger.kernel.org Cc: Richard W.M. Jones Cc: Lorenzo Dalrio Reported-by: Lorenzo Dalrio Signed-off-by: Hans de Goede --- drivers/

Re: [PATCH] libata: Drop SanDisk SD7UB3Q*G1001 NOLPM quirk

2018-05-31 Thread Hans de Goede
HI, On 31-05-18 13:16, Hans de Goede wrote: Commit 184add2ca23c ("libata: Apply NOLPM quirk for SanDisk SD7UB3Q*G1001 SSDs") disabled LPM for SanDisk SD7UB3Q*G1001 SSDs. This has lead to several reports of users of that SSD where LPM was working fine and who know have a significantly

[PATCH v2] libata: Drop SanDisk SD7UB3Q*G1001 NOLPM quirk

2018-05-31 Thread Hans de Goede
rs problem were triggered by LPM but not an LPM issue, so drop the quirk for the SSD in question. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1583207 Cc: sta...@vger.kernel.org Cc: Richard W.M. Jones Cc: Lorenzo Dalrio Reported-by: Lorenzo Dalrio Signed-off-by: Hans de Goede --- Cha

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Hans de Goede
Hi Jarkko, et.al., On 17-05-18 09:48, Jarkko Nikula wrote: Hi On 05/15/2018 01:20 PM, Jarkko Nikula wrote: On 05/15/2018 06:22 AM, Chris Chiu wrote: What if I change the 120MHz to 180MHz and then make sure that the I2C operates in target FS mode frequency 400kHz via scope? Would there be any

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Hans de Goede
Hi, On 18-05-18 12:58, Jarkko Nikula wrote: On 05/18/2018 01:20 PM, Andy Shevchenko wrote: On Fri, 2018-05-18 at 11:37 +0300, Andy Shevchenko wrote: On Fri, 2018-05-18 at 09:48 +0200, Hans de Goede wrote: Could it be the i2c input clock definition in drivers/mfd/intel- lpss- pci.c is also

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Hans de Goede
Hi, On 18-05-18 15:15, Jarkko Nikula wrote: On 05/18/2018 10:48 AM, Hans de Goede wrote: Could it be the i2c input clock definition in drivers/mfd/intel-lpss-pci.c is also wrong for Apollo Lake (N3450) ?  There are lots of people having various issues with i2c attached touchpads on Apollo Lake

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2018-08-19 Thread Hans de Goede
Hi, On 18-08-18 16:35, Stephen Rothwell wrote: Hi all, Commit cda5915d15d3 ("platform/x86: touchscreen_dmi: Add info for the Cube KNote i1101 tablet") For reasons which I do not know youling does not wish to use his real name. So as with the "platform/x86: touchscreen_dmi: Add info for

Re: [RFC/RFT 00/10] i2c: move handling of suspended adapters to the core

2018-12-12 Thread Hans de Goede
Hi, On 12-12-18 00:41, Wolfram Sang wrote: Hi Hans, thanks for testing this series! Note that the i2c-sprd driver changes in your patchset also get close to triggering this problem, but they dodge the bullet because there are separate system-wide and runtime suspend handlers and only the syst

Re: [RFC/RFT 00/10] i2c: move handling of suspended adapters to the core

2018-12-18 Thread Hans de Goede
Hi, On 18-12-18 21:17, Wolfram Sang wrote: Hans, all, ... this. I don't know what these flags do (and reading SMART in there gives me more a 'uh-oh' feeling) On x86 the lines between runtime suspend and system-suspend are blurring with technologies like "connected standby" and in general dev

Re: [PATCH 01/10] i2c: add suspended flag and accessors for i2c adapters

2018-12-19 Thread Hans de Goede
Hi, On 19-12-18 18:22, Lukas Wunner wrote: On Wed, Dec 19, 2018 at 05:48:17PM +0100, Wolfram Sang wrote: +static inline void i2c_mark_adapter_suspended(struct i2c_adapter *adap) +{ + i2c_lock_bus(adap, I2C_LOCK_ROOT_ADAPTER); + set_bit(I2C_ALF_IS_SUSPENDED, &adap->locked_flags); +

Re: [PATCH 1/2] staging: rtl8723bs: remove dead code, rtw_port_switch_chk()

2018-12-10 Thread Hans de Goede
Hi, Thank you for the patches. On 10-12-18 10:52, Michael Straube wrote: The function rtw_port_switch_chk() returns always false. Remove the function and related dead code. Signed-off-by: Michael Straube Both patches look good to me: Acked-by: Hans de Goede Regards, Hans

Re: [PATCH 1/3] staging: rtl8723bs: change semaphores to completions

2018-12-11 Thread Hans de Goede
equivalent, so the behavior should not change. Signed-off-by: Arnd Bergmann The entire series looks good to me and I've also given it a quick test run on a tablet with a rtl8723bs wifi chip: Reviewed-by: Hans de Goede Regards, Hans --- drivers/staging/rtl8723bs/core/rtw_cmd.c

Re: [PATCH] brcmfmac: fix false-positive -Wmaybe-unintialized warning

2018-12-11 Thread Hans de Goede
ed] Mark it 'inline' to force gcc to understand this. Fixes: ce2e6db554fa ("brcmfmac: Add support for getting nvram contents from EFI variables") Signed-off-by: Arnd Bergmann Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- drivers/net/w

Re: [RFC/RFT 00/10] i2c: move handling of suspended adapters to the core

2018-12-11 Thread Hans de Goede
drivers/i2c/i2c-core-base.c| 3 +++ include/linux/i2c.h| 9 + 9 files changed, 57 insertions(+), 59 deletions(-) >From 7781ff0b5033436c1d2740570364b1739017e03d Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Tue, 11 Dec 2018 19:19:17 +0100 Subjec

Re: [PATCH 01/10] i2c: add suspended flag and accessors for i2c adapters

2018-12-20 Thread Hans de Goede
Hi, On 19-12-18 23:33, Wolfram Sang wrote: Hi Lukas, Hans, On Wed, Dec 19, 2018 at 07:36:54PM +0100, Hans de Goede wrote: Hi, On 19-12-18 18:22, Lukas Wunner wrote: On Wed, Dec 19, 2018 at 05:48:17PM +0100, Wolfram Sang wrote: +static inline void i2c_mark_adapter_suspended(struct

[PATCH] ACPI / scan: Create platform device for BSG2150 ACPI nodes

2018-12-20 Thread Hans de Goede
lients) { dev_err(dev, "Error finding driver, idx %d\n", i); Error this commit lists the 3th device in the i2c_inst_data with a type of "bsg2150_dummy_dev". Signed-off-by: Hans de Goede --- drivers/acpi/scan.c | 1 + drivers/platform/x86/i2c-multi-instantiat

[PATCH 0/1] ACPI / scan: Create platform device for BSG2150 ACPI nodes

2018-12-20 Thread Hans de Goede
Hi All, This patch adds support for another ACPI HID which describes multiple i2c-clients in a single node. As such this applies on top of the recent patch from Andy making a similar change for INT3515 nodes: Commit a3dd034a1707 ("ACPI / scan: Create platform device for INT3515 ACPI nodes"), whic

[PATCH] platform/x86: touchscreen_dmi: Add info for the PoV Wintab P1006w (v1.0) tablet

2018-12-20 Thread Hans de Goede
Add touchscreen info for the Point of View Wintab P1006w (v1.0) tablet. Signed-off-by: Hans de Goede --- drivers/platform/x86/touchscreen_dmi.c | 29 ++ 1 file changed, 29 insertions(+) diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86

Re: [PATCH 01/10] i2c: add suspended flag and accessors for i2c adapters

2018-12-21 Thread Hans de Goede
Hi, On 20-12-18 22:09, Rafael J. Wysocki wrote: On Thursday, December 20, 2018 11:00:29 AM CET Hans de Goede wrote: Hi, On 19-12-18 23:33, Wolfram Sang wrote: Hi Lukas, Hans, On Wed, Dec 19, 2018 at 07:36:54PM +0100, Hans de Goede wrote: Hi, On 19-12-18 18:22, Lukas Wunner wrote: On Wed

Re: [GIT PULL] sound updates for 4.21

2018-12-31 Thread Hans de Goede
Hi, On 12/31/18 9:10 PM, Pierre-Louis Bossart wrote: On 12/31/18 12:15 PM, Takashi Iwai wrote: On Mon, 31 Dec 2018 11:24:41 +0100, Pierre-Louis Bossart wrote: On 12/31/18 2:11 AM, Takashi Iwai wrote: On Mon, 31 Dec 2018 00:17:58 +0100, Pierre-Louis Bossart wrote: BTW, one thing I'd really

Re: [PATCH v2 2/9] i2c: reject new transfers when adapters are suspended

2019-01-03 Thread Hans de Goede
Hi, On 03-01-19 19:59, Wolfram Sang wrote: I share your desire to have the check for this shared in core code, but I'm afraid that just is not going to work. Okay, so this series is definately not it. Probably the previous one which exposes helpers is not a bad idea after all. Because it is

Re: [PATCH v2 0/9] i2c: move handling of suspended adapters to the core

2018-12-24 Thread Hans de Goede
e to pick. Let me know if this works for you. And thanks to Renesas for funding this work! Series looks good to me: Reviewed-by: Hans de Goede Regards, Hans Thanks and kind regards, Wolfram Wolfram Sang (9): PM / core: add helper to return suspend status of a device i2c:

Re: [PATCH v2 2/9] i2c: reject new transfers when adapters are suspended

2018-12-24 Thread Hans de Goede
l. */ >From 0ff431b48f7f2d08bbf299265c67589a598ec5d4 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Mon, 24 Dec 2018 22:00:31 +0100 Subject: [PATCH] FIXUP: i2c: reject new transfers when adapters are suspended Signed-off-by: Hans de Goede --- drivers/i2c/i2c-core-base.c | 2

Re: [PATCH v2 0/9] i2c: move handling of suspended adapters to the core

2018-12-26 Thread Hans de Goede
Hi, On 26-12-18 12:01, Geert Uytterhoeven wrote: Hi Wolfram, On Sat, Dec 22, 2018 at 9:26 PM Wolfram Sang wrote: Here is the new version without specific I2C helpers but using the 'is_suspended' flag from the PM core. I didn't like messing with the flag directly, so I did a helper in patch 1.

[PATCH] x86/cpu/intel: Lower "ENERGY_PERF_BIAS: Set to normal" message log priority

2018-12-30 Thread Hans de Goede
message clearly does not match those criteria, so lower its log priority from warning to info. Signed-off-by: Hans de Goede --- arch/x86/kernel/cpu/intel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c index fc3

[PATCH 1/2] LICENSES: Add note to CDDL-1.0 license that it should not be used

2018-10-10 Thread Hans de Goede
The only reason we have the CDDL-1.0 license text around is for some dual-licensed files from virtualbox. New code should not use this license. Add a note about this and change the example tag to be dual-licensed. Signed-off-by: Hans de Goede --- LICENSES/other/CDDL-1.0 | 4 +++- 1 file

[PATCH 2/2] LICENSES: Add ISC license text

2018-10-10 Thread Hans de Goede
drivers. Cc: Kalle Valo Signed-off-by: Hans de Goede --- LICENSES/other/ISC | 24 1 file changed, 24 insertions(+) create mode 100644 LICENSES/other/ISC diff --git a/LICENSES/other/ISC b/LICENSES/other/ISC new file mode 100644 index ..8953c3142079 --- /dev

[PATCH] platform/x86: touchscreen_dmi: Add info for the Onda V80 Plus v3 tablet

2018-10-10 Thread Hans de Goede
Add touchscreen platform data for the Onda V80 Plus v3 tablet. Signed-off-by: Hans de Goede --- drivers/platform/x86/touchscreen_dmi.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c

[PATCH v2 1/2] LICENSES: Add note to CDDL-1.0 license that it should not be used

2018-10-10 Thread Hans de Goede
The only reason we have the CDDL-1.0 license text around is for some dual-licensed files from virtualbox. New code should not use this license. Add a note about this and change the example tag to be dual-licensed. Signed-off-by: Hans de Goede --- Changes in v2: -Add text specifying that CDDL

[PATCH v2 2/2] LICENSES: Add ISC license text

2018-10-10 Thread Hans de Goede
drivers. Cc: Kalle Valo Signed-off-by: Hans de Goede --- LICENSES/other/ISC | 24 1 file changed, 24 insertions(+) create mode 100644 LICENSES/other/ISC diff --git a/LICENSES/other/ISC b/LICENSES/other/ISC new file mode 100644 index ..8953c3142079 --- /dev

Re: Oops in current tree in i2c

2018-10-28 Thread Hans de Goede
Hi Linus, On 27-10-18 18:08, Linus Torvalds wrote: Julian, Jiri, On my laptop I'm getting a kernel page fault with the current git tree, and I'm tentatively blaming commit 9ee3e06610fd ("HID: i2c-hid: override HID descriptors for certain devices") but that's simply because it's the only t

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

2018-10-28 Thread Hans de Goede
Hi, On 28-10-18 05:13, Diego Viola wrote: On Fri, Oct 26, 2018 at 5:36 PM Diego Viola wrote: On Fri, Oct 26, 2018 at 11:21 AM Jens Axboe wrote: On 10/26/18 7:45 AM, Diego Viola wrote: med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Re: [RESEND PATCH 1/2] staging: vboxvideo: Change uint32_t to u32

2018-10-28 Thread Hans de Goede
Hi, On 26-10-18 21:04, Shayenne da Luz Moura wrote: This change was suggested by checkpath.pl. CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Shayenne da Luz Moura So as already mentioned in response to the coverletter of the first posting of this series. The drm headers us

Re: [PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD

2018-10-28 Thread Hans de Goede
Hi, On 28-10-18 15:34, Diego Viola wrote: med_power_with_dipm still causes freezes after updating the firmware to the latest version (DXT04L5Q). Set model_rev to NULL and blacklist the device. Signed-off-by: Diego Viola Thank you for the patch. Reviewed-by: Hans de Goede Regards, Hans

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi Pierre-Louis, On 29-10-18 23:03, Pierre-Louis Bossart wrote: On 10/29/18 2:08 PM, Dean Wallace wrote: On 29-10-18, Andy Shevchenko wrote: On Mon, Oct 29, 2018 at 7:52 PM Andy Shevchenko wrote: Cc: Pierre as well. On Mon, Oct 29, 2018 at 7:48 PM Stephen Boyd wrote: Quoting Dean Wallace

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 11:17, Hans de Goede wrote: Hi Pierre-Louis, On 29-10-18 23:03, Pierre-Louis Bossart wrote: On 10/29/18 2:08 PM, Dean Wallace wrote: On 29-10-18, Andy Shevchenko wrote: On Mon, Oct 29, 2018 at 7:52 PM Andy Shevchenko wrote: Cc: Pierre as well. On Mon, Oct 29, 2018 at 7

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
driver. I've some ideas how to fix this and I will prepare some patches to test. Regards, Hans >From 52e56378721f2e0ffde337f38db96a92d1870dc7 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Tue, 30 Oct 2018 12:14:27 +0100 Subject: [PATCH] ASoC: intel: cht_bsw_max98090_ti: Also enable

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 15:38, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the revert of the "Stop-marking-clocks-as-CLK_IS_CRITICAL" commit. Please first try the 0001-

Re: [RFC][PATCH v1] ACPI / scan: Create platform device for BOSC0200 ACPI nodes

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 15:47, Andy Shevchenko wrote: On some laptops the ACPI device with BOSC0200 _HID is representing two accelerometers under one node. We add an ID to the I2C multi instantiate list to enumerate all I2C slaves correctly. I believe that overall the approach here is correct, but I'

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the revert of the "Stop-marking-cloc

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: In addition I am not aware of any baytrail device using plt_clk_0, so moving a common machine driver such a cht_bsw_max98090_ti to use plt_clk0 only would break other devices (e.g. Rambi/Orco

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi Pierre-Louis, On 30-10-18 17:27, Pierre-Louis Bossart wrote: On 10/30/18 11:02 AM, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean

Re: [RFC][PATCH v1] ACPI / scan: Create platform device for BOSC0200 ACPI nodes

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 16:27, Hans de Goede wrote: Hi, On 30-10-18 15:47, Andy Shevchenko wrote: On some laptops the ACPI device with BOSC0200 _HID is representing two accelerometers under one node. We add an ID to the I2C multi instantiate list to enumerate all I2C slaves correctly. I believe

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 19:56, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Tuesday, October 30, 2018 4:04 PM, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: In addition I am not aware of any baytrail device using

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Hans de Goede
Hi, On 31-10-18 07:02, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Tuesday, October 30, 2018 7:10 PM, Hans de Goede wrote: Hi, On 30-10-18 19:56, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Tuesday, October 30, 2018 4:04 PM, Hans de Goede hdego...@redhat.com

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Hans de Goede
Hi, On 30-10-18 17:15, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: In addition I am not aware of any baytrail device using plt_clk_0, so moving a common machine driver such a

Re: [PATCH v3] staging: vboxvideo: Remove unnecessary parentheses

2018-10-31 Thread Hans de Goede
; Signed-off-by: Shayenne da Luz Moura Thank you. Still looks good to me: Acked-by: Hans de Goede Regards, Hans --- Changes in v2: - Make the commit message more clearer. Changes in v3: - Update to apply patch to the latest kernel tree drivers/staging/vboxvideo/vbox_main.c | 8 +

Re: linux-next: Tree for Oct 31 (vboxguest)

2018-10-31 Thread Hans de Goede
Hi, On 31-10-18 16:51, Randy Dunlap wrote: On 10/30/18 8:59 PM, Stephen Rothwell wrote: Hi all, Please do not add any v4.21/v5.1 code to your linux-next included trees until after the merge window closes. Changes since 20181030: on i386: ld: drivers/virt/vboxguest/vboxguest_core.o: in fu

[PATCH 0/1] ACPI / scan: Create platform device for INT33FE ACPI nodes

2018-10-17 Thread Hans de Goede
Hi Rafael, Andy, For the why and what of this patch see the (somewhat long) commit message. The single patch in this set both touches drivers/acpi/scan.c and drivers/platform/x86/intel_cht_int33fe.c, this is done this way to avoid regressions when bisecting. The main change here really is to ACP

[PATCH] ACPI / scan: Create platform device for INT33FE ACPI nodes

2018-10-17 Thread Hans de Goede
i-instantiate.c code. Reported-and-tested-by: Alexander Meiler Signed-off-by: Hans de Goede --- drivers/acpi/scan.c | 1 + drivers/platform/x86/intel_cht_int33fe.c | 24 +--- 2 files changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/acpi/s

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-07 Thread Hans de Goede
Hi, On 07-11-18 13:22, Rafael J. Wysocki wrote: On Fri, Nov 2, 2018 at 12:07 PM Arnd Bergmann wrote: We still get a link failure with IOSF_MBI=m when the xpower driver is built-in: drivers/acpi/pmic/intel_pmic_xpower.o: In function `intel_xpower_pmic_update_power': intel_pmic_xpower.c:(.tex

Re: [PATCH] staging: vboxvideo: make a couple of funcs static

2018-10-11 Thread Hans de Goede
isable' was not declared. Should it be static? Signed-off-by: Craig Kewley Thanks. Reviewed-by: Hans de Goede Regards, Hans --- drivers/staging/vboxvideo/vbox_mode.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vboxvideo/vbox_mode.

Re: [PATCH 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-11 Thread Hans de Goede
Hi, On 24-09-18 11:48, Andy Shevchenko wrote: On Sun, Sep 23, 2018 at 04:45:08PM +0200, Hans de Goede wrote: On some BYT/CHT systems the SoC's P-Unit shares the I2C bus with the kernel. The P-Unit has a semaphore for the PMIC bus which we can take to block it from accessing the share

[PATCH v2 0/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC semaphore handling

2018-10-11 Thread Hans de Goede
Hi All, New in v2 are some minor tweaks to the first patch based on Andy's review. See the commit message of the first patch for the why and what of this series. Also the whole purpose of posting this series for now is just to get the first patch reviewed and merged, the others are more of a RFC

[PATCH v2 3/3] i2c: designware: Cleanup bus lock handling

2018-10-11 Thread Hans de Goede
Now that most of the special Bay- / Cherry-Trail bus lock handling has been moved to the iosf_mbi code we can simplify the remaining code a bit. Signed-off-by: Hans de Goede --- drivers/i2c/busses/i2c-designware-baytrail.c | 18 ++ drivers/i2c/busses/i2c-designware-common.c

[PATCH v2 2/3] ACPI / PMIC: xpower: Block P-Unit I2C access during read-modify-write

2018-10-11 Thread Hans de Goede
could make changes to the register which we then end up overwriting. This commit makes intel_xpower_pmic_update_power() take the semaphore itself so that it is held over the entire read-modify-write, avoiding this race. Signed-off-by: Hans de Goede --- drivers/acpi/pmic/intel_pmic_xpower.c

[PATCH v2 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-11 Thread Hans de Goede
her code to deal with the shared bus so that it can be accessed outside of the I2C bus driver. 2) Rework the code so that it can be called multiple times nested, while still blocking I2C accesses while e.g. the GPU driver has indicated the P-Unit needs the bus through a iosf_mbi_punit_acquire() call

Re: [PATCH v2 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-11 Thread Hans de Goede
Hi, On 11-10-18 12:41, Ingo Molnar wrote: * Hans de Goede wrote: +int iosf_mbi_block_punit_i2c_access(void) +{ + unsigned long start, end; + int ret = 0; + u32 sem; + + if (WARN_ON(!mbi_pdev || !iosf_mbi_sem_address)) + return -ENXIO

[PATCH v3 0/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC semaphore handling

2018-10-11 Thread Hans de Goede
Hi All, Changes in v3: -Fix iosf_mbi_punit_mutex not being unlocked in error exit path -Add a big comment describing the what-and-why of iosf_mbi_block_punit_i2c_access() Changes in v2: -Move mutex_unlock(&iosf_mbi_punit_mutex); to the callers of iosf_mbi_reset_semaphore() -Use PCI_DEVICE_DATA(

[PATCH v3 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-11 Thread Hans de Goede
her code to deal with the shared bus so that it can be accessed outside of the I2C bus driver. 2) Rework the code so that it can be called multiple times nested, while still blocking I2C accesses while e.g. the GPU driver has indicated the P-Unit needs the bus through a iosf_mbi_punit_acquire() call

[PATCH v3 2/3] ACPI / PMIC: xpower: Block P-Unit I2C access during read-modify-write

2018-10-11 Thread Hans de Goede
could make changes to the register which we then end up overwriting. This commit makes intel_xpower_pmic_update_power() take the semaphore itself so that it is held over the entire read-modify-write, avoiding this race. Signed-off-by: Hans de Goede --- drivers/acpi/pmic/intel_pmic_xpower.c

[PATCH v3 3/3] i2c: designware: Cleanup bus lock handling

2018-10-11 Thread Hans de Goede
Now that most of the special Bay- / Cherry-Trail bus lock handling has been moved to the iosf_mbi code we can simplify the remaining code a bit. Signed-off-by: Hans de Goede --- drivers/i2c/busses/i2c-designware-baytrail.c | 18 ++ drivers/i2c/busses/i2c-designware-common.c

Re: [PATCH v3 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-12 Thread Hans de Goede
Hi, On 11-10-18 22:35, Alan Cox wrote: 1) PMIC accesses often come in the form of a read-modify-write on one of the PMIC registers, we currently release the P-Unit's PMIC bus semaphore between the read and the write. If the P-Unit modifies the register during this window?, then we end up overwri

Re: [PATCH v2 2/3] ACPI / PMIC: xpower: Block P-Unit I2C access during read-modify-write

2018-10-14 Thread Hans de Goede
help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/x86-baytrail-cherrytrail-Rework-and-move-P-Unit-PMIC-semaphore-handling/20181013-230503 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: ia64-allyesconfig (attached

Re: [PATCH] platform/x86: Add Intel ISP dummy driver

2018-10-14 Thread Hans de Goede
Hi, On 29-08-18 20:20, Andy Shevchenko wrote: On Wed, Aug 29, 2018 at 03:57:44PM +0200, Hans de Goede wrote: The Image Signal Processor found on Cherry Trail devices is brought up in D0 state on devices which have camera sensors attached to it. The ISP will not enter D3 state again without

[PATCH v2] platform/x86: Add Intel AtomISP2 dummy / power-management driver

2018-10-14 Thread Hans de Goede
=196915 Signed-off-by: Hans de Goede --- Changes in v2: -Rename the driver and Kconfig option from intel-isp-dummy to intel-atomisp2-pm --- MAINTAINERS | 6 ++ drivers/platform/x86/Kconfig | 12 +++ drivers/platform/x86/Makefile| 1

[PATCH] platform/x86: touchscreen_dmi: Add info for the Trekstor Primebook C11 convertible

2018-10-04 Thread Hans de Goede
Add touchscreen info for the Trekstor Primebook C11 convertible. Cc: Alicia Hormann Suggested-by: Alicia Hormann Signed-off-by: Hans de Goede --- drivers/platform/x86/touchscreen_dmi.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/platform/x86

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-01 Thread Hans de Goede
Hi, On 31-10-18 23:27, Pierre-Louis Bossart wrote: Just thought it worth mentioning, this new patch that fixes sound again, seems to have ressurected an old issue with PLL unlock.  I'm seeing journal entries after fresh boot .. ``` picard kernel: max98090 i2c-193C9890:00: PLL unlocked pic

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-01 Thread Hans de Goede
Hi, On 01-11-18 11:37, Dean Wallace wrote: On 31-10-18, Pierre-Louis Bossart wrote: Just thought it worth mentioning, this new patch that fixes sound again, seems to have ressurected an old issue with PLL unlock. I'm seeing journal entries after fresh boot .. ``` picard kernel: max98090

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-01 Thread Hans de Goede
Hi, On 01-11-18 15:28, Dean Wallace wrote: On 01-11-18, Hans de Goede wrote: Hi, On 01-11-18 11:37, Dean Wallace wrote: On 31-10-18, Pierre-Louis Bossart wrote: Just thought it worth mentioning, this new patch that fixes sound again, seems to have ressurected an old issue with PLL unlock

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-02 Thread Hans de Goede
Hi, On 01-11-18 16:50, Dean Wallace wrote: On 01-11-18, Hans de Goede wrote: Hi, On 01-11-18 15:28, Dean Wallace wrote: On 01-11-18, Hans de Goede wrote: Hi, On 01-11-18 11:37, Dean Wallace wrote: On 31-10-18, Pierre-Louis Bossart wrote: Just thought it worth mentioning, this new patch

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-02 Thread Hans de Goede
Hi, On 02-11-18 12:06, Arnd Bergmann wrote: We still get a link failure with IOSF_MBI=m when the xpower driver is built-in: drivers/acpi/pmic/intel_pmic_xpower.o: In function `intel_xpower_pmic_update_power': intel_pmic_xpower.c:(.text+0x4f2): undefined reference to `iosf_mbi_block_punit_i2c_

Re: [PATCH] vbox: fix link error with 'gcc -Og'

2018-11-02 Thread Hans de Goede
': vboxguest_core.c:(.text+0x1f6e): undefined reference to `vbg_hgcm_call32' Another compile-time check documents better what we want and avoids the error. Acked-by: Randy Dunlap Tested-by: Randy Dunlap Signed-off-by: Arnd Bergmann Thank you, looks good to me: Reviewed-by: Hans de Goede Rega

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-03 Thread Hans de Goede
Hi, On 03-11-18 07:57, João Paulo Rechi Vita wrote: Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting "Discharging" on some machines when AC was connected but the battery was not charging. But now on these machines the battery status is reported as "Not charging" even when the batt

Re: [PATCH 0/2] staging: vboxvideo: Remove chekpatch issues

2018-10-26 Thread Hans de Goede
Hi, On 25-10-18 21:40, Shayenne da Luz Moura wrote: This series cleans the following checkpatch.pl issues: CHECK: Prefer kernel type 'u32' over 'uint32_t' CHECK: Avoid using bool structure members because of possible alignment issues Shayenne da Luz Moura (2): staging: vboxvideo: Change uin

Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses

2018-10-26 Thread Hans de Goede
; Signed-off-by: Shayenne da Luz Moura Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- Changes in v2: - Make the commit message more clearer. drivers/staging/vboxvideo/vbox_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

Re: [PATCH v2] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

2018-10-26 Thread Hans de Goede
Hi, On 26-10-18 03:58, Diego Viola wrote: med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q). Switching the LPM to max_performance fixes this issue. Signed-off-by: Diego Viola Thank you for the patch, have you updated the firmware and conf

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

2018-10-26 Thread Hans de Goede
Hi, On 26-10-18 15:45, Diego Viola wrote: med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q). Switching the LPM to max_performance fixes this issue. Signed-off-by: Diego Viola Thanks, looks good to me: Acked-by: Hans de Goede Regards

Re: [PATCH 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-18 Thread Hans de Goede
Hi, On 18-10-18 09:29, Rafael J. Wysocki wrote: On Sun, Sep 23, 2018 at 4:45 PM Hans de Goede wrote: On some BYT/CHT systems the SoC's P-Unit shares the I2C bus with the kernel. The P-Unit has a semaphore for the PMIC bus which we can take to block it from accessing the shared bus whil

Re: [PATCH 3/5] dt-bindings: add more optional properties for elan_i2c touchpads

2018-10-18 Thread Hans de Goede
Hi, On 18-10-18 10:10, Benjamin Tissoires wrote: On Wed, Oct 17, 2018 at 10:15 PM Rob Herring wrote: On Fri, Oct 12, 2018 at 04:24:11PM +0200, Benjamin Tissoires wrote: Some new touchpads IC are connected through PS/2 and I2C. On some of these new IC, the I2C part doesn't have all of the inf

Re: [PATCH 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-18 Thread Hans de Goede
HI, On 18-10-18 10:38, Rafael J. Wysocki wrote: On Thursday, October 18, 2018 10:34:57 AM CEST Hans de Goede wrote: Hi, On 18-10-18 09:29, Rafael J. Wysocki wrote: On Sun, Sep 23, 2018 at 4:45 PM Hans de Goede wrote: On some BYT/CHT systems the SoC's P-Unit shares the I2C bus wit

Re: [PATCH 3/5] dt-bindings: add more optional properties for elan_i2c touchpads

2018-10-18 Thread Hans de Goede
Hi, On 18-10-18 10:44, Benjamin Tissoires wrote: On Thu, Oct 18, 2018 at 10:39 AM Hans de Goede wrote: Hi, On 18-10-18 10:10, Benjamin Tissoires wrote: On Wed, Oct 17, 2018 at 10:15 PM Rob Herring wrote: On Fri, Oct 12, 2018 at 04:24:11PM +0200, Benjamin Tissoires wrote: Some new

[PATCH] platform/x86: touchscreen_dmi: Add min-x and min-y settings for various models

2018-10-20 Thread Hans de Goede
e the touchpad can handle 10 fingers (rather then the default 5) and that was missing. Signed-off-by: Hans de Goede --- drivers/platform/x86/touchscreen_dmi.c | 33 +++--- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/drivers/platform/x86/touchscreen_dmi

Re: [PATCH v4 0/4] Add SBAF test to IFS

2024-08-12 Thread Hans de Goede
Hi, On 8/1/24 7:18 AM, Kuppuswamy Sathyanarayanan wrote: > This patch series adds support for Structural Based Functional Test at > Field (SBAF) in the IFS driver. SBAF is a new type of testing that > provides comprehensive core test coverage, complementing existing IFS > tests like Scan at Field

Re: [PATCH][next] platform/x86: intel_pmc_core: fix unsigned variable compared to less than zero

2021-04-20 Thread Hans de Goede
Hi Colin, On 4/20/21 2:10 PM, Colin King wrote: > From: Colin Ian King > > The check for ret < 0 is always false because ret is a (unsigned) size_t > and not a (signed) ssize_t, hence simple_write_to_buffer failures are > never detected. Fix this by making ret a ssize_t > > Addresses-Coverity:

Re: [PATCH] platform/surface: aggregator: fix a bit test

2021-04-20 Thread Hans de Goede
Hi, On 4/20/21 10:44 AM, Dan Carpenter wrote: > The "funcs" variable is a u64. If "func" is more than 31 then the > BIT() shift will wrap instead of testing the high bits. > > Fixes: c167b9c7e3d6 ("platform/surface: Add Surface Aggregator subsystem") > Reported-by: kernel test robot > Signed-of

Re: [PATCH v3] x86/platform/uv: refactor deprecated strcpy and strncpy

2023-09-13 Thread Hans de Goede
Hi, On 9/6/23 16:09, Ingo Molnar wrote: > > * Hans de Goede wrote: > >> Hi Ingo, >> >> On 9/6/23 14:10, Ingo Molnar wrote: >>> >>> * Justin Stitt wrote: >>> >>>> Both `strncpy` and `strcpy` are deprecated for use on NUL-termi

Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init

2021-02-15 Thread Hans de Goede
Hi, On 2/15/21 8:22 AM, Vaittinen, Matti wrote: > > On Sat, 2021-02-13 at 16:59 +0100, Hans de Goede wrote: >> Hi, >> >> On 2/13/21 4:27 PM, Guenter Roeck wrote: >>> On 2/13/21 7:03 AM, Hans de Goede wrote: >>> [ ... ] >>>> I think

Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init

2021-02-15 Thread Hans de Goede
Hi, On 2/15/21 12:31 PM, gre...@linuxfoundation.org wrote: > On Mon, Feb 15, 2021 at 11:37:26AM +0100, Hans de Goede wrote: >> Hi, >> >> On 2/15/21 8:22 AM, Vaittinen, Matti wrote: >>> >>> On Sat, 2021-02-13 at 16:59 +0100, Hans de Goede wrote: >>>&

[GIT PULL] platform-drivers-x86 for 5.12-1

2021-02-15 Thread Hans de Goede
ual timeout from 3 to 5 seconds Colin Ian King (1): platform/surface: fix potential integer overflow on shift of a int David E. Box (3): platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable platform/x86: intel_pmt_telemetry: Add dependency on MFD_INTEL_PMT platform/x86: intel

Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices

2021-02-15 Thread Hans de Goede
> Changes in v2: > - Introduce new 'balanced-performance' platform profile and change >profile mapping in driver. > - Perform some fix-ups for the ACPI platform profile implementation: >- Fix some references to documentation in a comment. >- Hide CONFIG_ACPI

<    1   2   3   4   5   6   7   8   9   10   >