Hi,
On 28-01-15 16:17, Arnd Bergmann wrote:
The sun4i-ts driver has had a dependency on the thermal code
since it was first merged,
The "since it was first merged bit" is not true, this is caused
by recent changes by ChenYu.
Other then that no objections from me against the proposed fix.
Reg
od to me and is:
Acked-by: Hans de Goede
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
vers/ata/libahci_platform.ko]
> undefined!
>
> Fixes: c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators")
> Cc: Gregory CLEMENT
> Signed-off-by: Guenter Roeck
Looks good, Acked-by: Hans de Goede
Regards,
Hans
> ---
> Applies to -next.
>
> drive
Hi,
On 15-12-14 15:13, Vishnu Patekar wrote:
Hi,
On Sun, Dec 14, 2014 at 2:31 PM, Hans de Goede wrote:
Hi,
On 13-12-14 21:01, Vishnu Patekar wrote:
Hello Hans,
Please find my comments inlined.
On 12/13/14, Hans de Goede wrote:
Hi VishnuPatekar,
The patch mangling for this set seems
Hi,
On 16-12-14 01:37, David Lanzendörfer wrote:
When there is only one DES available the DMA performs a FIFO reset and waits
until the reinitialization has been completed.
Disabling the SDXC_IDMAC_DES0_DIC bit prevents the DMA from sending an
interrupt after it has finished this reinitializat
roper documentation about
the timing of the module.
Looking forward to your feedback
Cheers David
Thanks.
Series looks good and is:
Acked-by: Hans de Goede
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.
ta/Kconfig.
Signed-off-by: Suravee Suthikulpanit
The ahci_platform changes done here look good to me:
Acked-by: Hans de Goede
Regards,
Hans
---
drivers/ata/Kconfig | 2 +-
drivers/ata/ahci_platform.c | 10 ++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/d
Hi,
On 28-02-15 01:18, Dmitry Torokhov wrote:
PNP IDs are supposed to be case-insensitive and so we should compare
them as such.
Signed-off-by: Dmitry Torokhov
Looks good:
Acked-by: Hans de Goede
Regards,
Hans
---
drivers/input/mouse/psmouse-base.c | 39
Hi,
On 15-02-15 17:38, Pali Rohár wrote:
On Wednesday 11 February 2015 08:38:58 Hans de Goede wrote:
Thanks for this and the other related mail. I also have an
alps.c directly from alps themselves which adds support for
v8 and v9 protocols. The problem is that like with v7 the
code is not
79e00a0a6c38ac34e9 Mon Sep 17 00:00:00 2001
From: Hans de Goede
Date: Fri, 12 Dec 2014 14:05:56 +0100
Subject: [PATCH v2 1/4] FIXUP: "sunxi:dts-bindings:input:ps2 bindings for
A10/A20 ps2."
2 fixups for: "sunxi:dts-bindings:input:ps2 bindings for A10/A20 ps2."
1) dt bindings sho
Hi VishnuPatekar,
The patch mangling for this set seems to have gone a bit wrong I'm afraid,
a lot of the patches have my fixup commit messages (which should have
disappeared when squashing in the patches), please replace those by proper
commit messages describing what the patch actually does.
A
Hi,
On 13-12-14 21:01, Vishnu Patekar wrote:
Hello Hans,
Please find my comments inlined.
On 12/13/14, Hans de Goede wrote:
Hi VishnuPatekar,
The patch mangling for this set seems to have gone a bit wrong I'm afraid
No, this time I've corrected it. Infact, last version of pat
Hi Linus,
On 15-12-14 00:06, Linus Torvalds wrote:
On Sun, Dec 14, 2014 at 2:35 PM, Greg KH wrote:
Hans de Goede (1):
uas: Make uas work with blk-mq
So I got some fairly trivial conflicts on this one (conflicting with
the scsi cleanups mainly by Christoph Hellwig.
I resolved the
Hi,
On 09-03-16 11:50, Maxime Ripard wrote:
Hi,
The axp209 PMIC used in combination to some Allwinner SoCs has a bunch
of GPIOs accessible. Some boards use these to control their backlight
or a few LEDs.
Thanks for working on this, but IMHO this cannot go upstream like this,
the gpio pins on
Hi,
On 09-03-16 16:28, Maxime Ripard wrote:
Hi,
On Wed, Mar 09, 2016 at 01:17:50PM +0100, Hans de Goede wrote:
Hi,
On 09-03-16 11:50, Maxime Ripard wrote:
Hi,
The axp209 PMIC used in combination to some Allwinner SoCs has a bunch
of GPIOs accessible. Some boards use these to control their
: Chen-Yu Tsai
Cc: Hans de Goede
Cc: Zhang Rui
Cc: Lukasz Majewski
Cc: Heiko Stuebner
Cc: Sascha Hauer
Cc: Jens Thiele
Cc: linux-in...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Eduardo Valentin
---
drivers/input/touchscreen/sun4i
Hi,
On 16-03-16 11:10, Linus Walleij wrote:
On Wed, Mar 9, 2016 at 4:44 PM, Hans de Goede wrote:
On Wed, Mar 09, 2016 at 01:17:50PM +0100, Hans de Goede wrote:
Eventually, yes, it needs both. But they don't even have to be the
same driver, since they provide two different features
Hi,
On 19-04-16 11:42, Olliver Schinagl wrote:
Hi Ulf,
On 19-04-16 11:29, Ulf Hansson wrote:
On 19 April 2016 at 09:12, Olliver Schinagl wrote:
In patch 81f8a7be66 Hans de Goede added a patch to allow marking an mmc
device as to having an broken HPI implementation. After talking some
with
Hi,
On 23-04-16 23:10, Johannes Stezenbach wrote:
Hi,
I bought a new backup disk which turned out to be UAS capable,
but when I plugged it in I got an order 7 page allocation failure.
My hunch is that the .can_queue = 65536 in drivers/usb/storage/uas.c
is much too large. Maybe 256 would be a p
Hi,
On 30-10-15 17:01, Chen-Yu Tsai wrote:
On Fri, Oct 30, 2015 at 10:20 PM, Maxime Ripard
wrote:
The R8 has yet another array of gates for AHB. Let's add it to the list of
compatibles we can deal with.
Signed-off-by: Maxime Ripard
---
drivers/clk/sunxi/clk-simple-gates.c | 2 ++
1 file c
HI,
On 23-11-15 09:57, Maxime Ripard wrote:
Hi,
On Sun, Nov 01, 2015 at 02:33:23PM +0100, Jens Kuske wrote:
+ bus_gates: clk@01c20060 {
+ #clock-cells = <1>;
+ compatible = "allwinner,sun8i-h3-bus-gates-clk";
+ reg
Hi,
On 01-07-15 18:13, Greg KH wrote:
On Wed, Jul 01, 2015 at 10:55:49AM -0500, Jeremy White wrote:
On 07/01/2015 12:44 AM, Greg KH wrote:
On Tue, Jun 30, 2015 at 10:34:25PM -0500, Jeremy White wrote:
1. Is the basic premise reasonable? Is Hans correct in asserting that an
alternate USB
Hi,
On 01-07-15 20:31, Jeremy White wrote:
Assuming that's correct, then this seems to imply that the socket has raw
plain text data being sent/received, and thus precludes the possibility
of running any security protocol like TLS unless the kernel wants to have
an impl of the TLS protocol.
Go
Hi,
On 02-07-15 10:45, Oliver Neukum wrote:
On Wed, 2015-07-01 at 10:06 +0100, Daniel P. Berrange wrote:
I don't really think it is sensible to be defining & implementing new
network services which can't support strong encryption and authentication.
Rather than passing the file descriptor to t
Hi,
On 09/28/2015 09:42 AM, Maxime Ripard wrote:
Hi Priit,
On Tue, Sep 22, 2015 at 04:26:57PM +0300, Priit Laes wrote:
On Sat, 2015-09-12 at 15:26 +0200, Maxime Ripard wrote:
Hi everyone,
This patch set adds the support for what Allwinner calls the codec on
their SoCs.
This codec is actuall
Hi,
On 11-02-19 11:30, Mika Westerberg wrote:
Hi,
On Thu, Feb 07, 2019 at 12:29:17PM -0800, Dmitry Torokhov wrote:
Do you have a suggestion as to how to write ACPI tables to avoid the issue?
1. Allocate new ID and use it (perhaps not the best path).
2. Use GPE(s).
Or just solve the issu
pport for parsing a GpioInt resource in order
to fulfill a request for the index 0 IRQ for a platform device.
Signed-off-by: Enrico Granata
Looks good to me:
Acked-by: Hans de Goede
Regards,
Hans
---
Changes in v2:
- only support IRQ index 0
drivers/base/platform.c | 15 ++
Hi,
On 3/15/19 2:31 PM, Gabriel Lazar wrote:
Add touchscreen platform data for the Myrya MY8307 2-in-1 laptop.
Signed-off-by: Gabriel Lazar
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/platform/x86/touchscreen_dmi.c | 25
) {
if (val & BIT(i)) {
dev_dbg(info->dev, "%s\n", *rsi);
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
amp;pdev->dev, "Failed to get IRQ: %d\n", pirq);
+ return pirq;
+ }
info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq);
if (info->irq[i] < 0) {
dev_warn(&info->pdev->d
denied
with a VERR_VERSION_MISMATCH error, breaking vboxservice.service and
the mounting of shared folders marked to be auto-mounted.
This commit implements passing the requestor info to the host, fixing this.
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest
Hi,
On 20-03-19 10:46, Greg Kroah-Hartman wrote:
On Wed, Mar 20, 2019 at 10:35:19AM +0100, Hans de Goede wrote:
VirtualBox 6.0.x has a new feature where the guest kernel driver passes
info about the origin of the request (e.g. userspace or kernelspace) to
the hypervisor.
If we do not pass
H,
On 3/20/19 3:37 PM, Benjamin Tissoires wrote:
The reason why i2c_hid_init_irq was moved is told by Hans De Goede
:
i2c_hid_init_irq now checks for a quirk, so we must setup the quirks before we
init the irq, and we cannot setup the quirk earlier, so we must init the irq
later.
I am
Hi All,
On 19-08-19 13:31, Hans de Goede wrote:
Also I might be able to get my hands on a Minix Neo Z83-4 myself
in a couple of days and then I can try to reproduce this, so lets
wait a bit for that and see how that goes.
So I've access to a Minix Neo z83-4 myself now. The problem is
the
:
Acked-by: Hans de Goede
Regards,
Hans
Build tested only, buildbot is happy, too.
Please apply to your tree.
drivers/i2c/busses/i2c-cht-wc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
index
Hi Nishka,
On 15-08-19 08:00, Nishka Dasgupta wrote:
Each iteration of for_each_child_of_node puts the previous node, but
in the case of a goto from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before three such goto
statements.
Issue found with Coccine
.
Signed-off-by: Nishka Dasgupta
I really believe the for_each_child_of_node semantics are broken, see my
other reply. But that is no reason not to fix this, so this is:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/ata/libahci_platform.c | 9 +++--
1 file changed, 7 insertions
uirk for boards using pmc_plt_clk_0").
Signed-off-by: Daniel Stuart
Thank you for catching this, this patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
sound/soc/intel/boards/cht_bsw_max98090_ti.c | 98
1 file changed, 98 insertions(+)
di
_int33fe driver
for its TypeC connector:
Reviewed-by: Hans de Goede
Tested-by: Hans de Goede
Regards,
Hans
Hi,
On 8/16/19 3:52 PM, Heikki Krogerus wrote:
On Fri, Aug 16, 2019 at 04:45:50PM +0300, Andy Shevchenko wrote:
On Fri, Aug 16, 2019 at 1:45 PM Heikki Krogerus
wrote:
The primary purpose for this node will be to allow linking
the users of the switch to it. The users will be for example
USB T
Add touchscreen info for the Trekstor Primebook C11B 2-in-1, note the C11B
used the same touchscreen as the regular C11, so we only add a new DMI
match.
Cc: Thomas Hiller
Reported-and-tested-by: Thomas Hiller
Signed-off-by: Hans de Goede
---
drivers/platform/x86/touchscreen_dmi.c | 8
Hi Ian, et. al.,
On 23-03-19 04:39, Ian W MORRISON wrote:
Hi Hans,
IMHO we need to root-cause this problem a bit more before applying this
kludge.
Can you provide an ACPI dump of one of the affected machines ?
Attached is an ACPI dump.
First of all sorry for taking way too long to get ba
Hi Andy,
On 26-08-19 11:11, Andy Shevchenko wrote:
On Fri, Aug 23, 2019 at 11:52:55PM +0200, Hans de Goede wrote:
Another day; another DSDT bug we need to workaround...
Since commit ca876c7483b6 ("gpiolib-acpi: make sure we trigger edge events
at least once on boot") we call
Use device_init_wakeup and pm_wakeup_hard_event instead of directly
calling pm_system_wakeup(). This is the preferred way to do this and
this will allow the user to disable wakeup through INT0002 events
through sysfs.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/intel_int0002_vgpio.c
set_wake on Bay Trail")
Signed-off-by: Hans de Goede
---
drivers/platform/x86/intel_int0002_vgpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/intel_int0002_vgpio.c
b/drivers/platform/x86/intel_int0002_vgpio.c
index d9542c661ddc..9ea1a2a19f86 100644
--- a/
ge events at least
once on boot")
Signed-off-by: Hans de Goede
---
drivers/gpio/gpiolib-acpi.c | 52 ++---
1 file changed, 48 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 39f2f9035c11..546dc2c1f
the UCM file: alsa-lib/src/conf/ucm/codecs/es8316/EnableSeq.conf :
# Set HP mixer vol to -6 dB (4/7) louder does not work
cset "name='Headphone Mixer Volume' 4"
Limiting this to the actual working range at the kernel level seems
sensible:
Reviewed-by: Hans de Go
lib/crypto/sha256.c / lib/crypto/libsha256.o may end up being a module,
so it needs a MODULE_LICENSE() line, add this.
Signed-off-by: Hans de Goede
---
lib/crypto/sha256.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/crypto/sha256.c b/lib/crypto/sha256.c
index 45ad87520769
Hi,
On 26-08-19 04:53, Daniel Drake wrote:
On Mon, Aug 26, 2019 at 1:38 AM Hans de Goede wrote:
On 24-08-19 23:04, Katsuhiro Suzuki wrote:
This patch limits Headphone mixer volume to 4 from 7.
Because output sound suddenly becomes very loudly with many noise if
set volume over 4.
That
, this makes system unusable.
Check if USB ID pin is floating and re-route data lines in this case
only, don't touch otherwise.
Signed-off-by: Yauhen Kharuzhy
---
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
drivers/extcon/extcon-intel-cht-wc.c
Hi,
On 17-09-2019 21:45, Yauhen Kharuzhy wrote:
Existing intel_cht_int33fe ACPI pseudo-device driver assumes that
hardware has TypeC connector and register related devices described as
I2C connections in the _CRS resource.
There is at least one hardware (Lenovo Yoga Book YB1-91L/F) with micro
U
users of this new API show up ?
Regards,
Hans
Cc: Greg Kroah-Hartman
Cc: Rob Herring
Cc: Mark Rutland
Cc: Heikki Krogerus
Cc: Suzuki K Poulose
Cc: Chunfeng Yun
Cc: Yu Chen
Cc: Felipe Balbi
Cc: Hans de Goede
Cc: Andy Shevchenko
Cc: Jun Li
Cc: Valentin Schneider
Cc: linux
Hi Kyle,
On 20-09-2019 05:24, Kyle Tso wrote:
*** BLURB HERE ***
Kyle Tso (2):
usb: typec: tcpm: AMS and Collision Avoidance
usb: typec: tcpm: AMS for PD2.0
I've finally gotten a chance to test this on one of my own devices
which uses the tcpm framework for its Type-c port.
I am afraid
Hans
On Thu, Oct 3, 2019 at 5:47 PM Hans de Goede wrote:
Hi Kyle,
On 20-09-2019 05:24, Kyle Tso wrote:
*** BLURB HERE ***
Kyle Tso (2):
usb: typec: tcpm: AMS and Collision Avoidance
usb: typec: tcpm: AMS for PD2.0
I've finally gotten a chance to test this on one of my o
Hi all,
I've been debugging a new error printed with 5.4-rc1:
[ 25.570893] dwc3 dwc3.0.auto: IRQ peripheral not found
This is caused by the "driver core: platform: Add an error message to
platform_get_irq*()"
commit.
The dwc3 driver first tries to get the IRQ by 2 different names before fal
Hi,
On 03-10-2019 22:37, John Stultz wrote:
On Thu, Oct 3, 2019 at 2:25 AM Hans de Goede wrote:
On 03-10-2019 01:16, John Stultz wrote:
From: Yu Chen
This patch adds notifier for drivers want to be informed of the usb role
switch.
I do not see any patches in this series actually using
Hi,
On 03-10-2019 22:45, John Stultz wrote:
On Thu, Oct 3, 2019 at 4:26 AM Greg Kroah-Hartman
wrote:
On Wed, Oct 02, 2019 at 11:16:16PM +, John Stultz wrote:
From: Yu Chen
This patch adds notifier for drivers want to be informed of the usb role
switch.
Ick, I hate notifiers, they alw
Hi Stephen, Jiri,
On 10/4/19 2:28 AM, Stephen Rothwell wrote:
Hi all,
After merging the hid tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
ld: drivers/hid/hid-lg-g15.o: in function `.lg_g15_probe':
hid-lg-g15.c:(.text+0x1a1c): undefined reference to
`.devm_led_clas
Hi,
On 28-09-2019 01:04, Navid Emamdoost wrote:
In hgcm_call_preprocess_linaddr memory is allocated for bounce_buf but
is not released if copy_form_user fails. The release is added.
Fixes: 579db9d45cb4 ("virt: Add vboxguest VMMDEV communication code")
Signed-off-by: Navid Emamdoost
Thank yo
Hi,
On 30-09-2019 04:22, Navid Emamdoost wrote:
It is a neat fix now, thank you.
Can you submit a new version of your patch with the fix I proposed please ?
Regards,
Hans
On Sat, Sep 28, 2019 at 4:54 AM Hans de Goede wrote:
Hi,
On 28-09-2019 01:04, Navid Emamdoost wrote:
In
allocated bounce_buf will be released by the
caller.
Fixes: 579db9d45cb4 ("virt: Add vboxguest VMMDEV communication code")
Signed-off-by: Navid Emamdoost
Thank you.
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/virt/vboxguest/vboxguest_utils.c |
2
This will help us catch missing symbols in the purgatory sooner.
Note this commit also removes --no-undefined from LDFLAGS_purgatory.ro
as that has no effect.
Signed-off-by: Hans de Goede
---
arch/x86/purgatory/Makefile | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
p us catch missing symbols in the purgatory sooner.
Note this commit also removes --no-undefined from LDFLAGS_purgatory.ro
as that has no effect.
Signed-off-by: Hans de Goede
---
arch/s390/purgatory/Makefile | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/s390/purgator
Hi s390 maintainers,
This patch mirrors a similar patch for x86, but it has been untested
because I do not have a mainframe to compile on :)
In 5.4-rc1 the 2 different sha256 implementations for the purgatory resp.
for crypto/sha256_generic.c have been consolidated into 1 single shared
implementa
HI,
On 07-10-2019 22:05, Nathan Chancellor wrote:
On Mon, Oct 07, 2019 at 07:55:46PM +0200, Hans de Goede wrote:
Since we link purgatory.ro with -r aka we enable "incremental linking"
no checks for unresolved symbols is done while linking purgatory.ro.
Changes to the sha256 code
HI,
On 07-10-2019 23:52, Arvind Sankar wrote:
On Mon, Oct 07, 2019 at 10:31:49PM +0200, Hans de Goede wrote:
HI,
On 07-10-2019 22:05, Nathan Chancellor wrote:
On Mon, Oct 07, 2019 at 07:55:46PM +0200, Hans de Goede wrote:
Since we link purgatory.ro with -r aka we enable "incremental li
Hi s390 maintainers,
Here is a second RFC version of my patch for $subject, mirroring the
changes in v2 of the x86 patch.
As last time this patch is completely UNTESTED.
Changes in v2:
- Using 2 if_changed lines under a single rule does not work, then
1 of the 2 will always execute each build.
p us catch missing symbols in the purgatory sooner.
Note this commit also removes --no-undefined from LDFLAGS_purgatory
as that has no effect.
Signed-off-by: Hans de Goede
---
Changes in v2:
- Using 2 if_changed lines under a single rule does not work, then
1 of the 2 will always execute each build.
egister it.
Signed-off-by: Dmitry Torokhov
Patch looks good to me and I've also given this a test-run on the
hw which uses this driver:
Reviewed-by: Hans de Goede
Tested-by: Hans de Goede
Regards,
Hans
---
v2: include input.h instead of input-polldev.h
drivers/platform/x86/
Reviewed-by: Hans de Goede
Tested-by: Hans de Goede
Regards,
Hans
p.s.
I guess this means we can remove the build-in connection (
device_connection_add / remove) stuff now?
et's remove runtime power management since there is no actual
benefit.
Signed-off-by: Kai-Heng Feng
Given all the problems we've been seeing related to runtime pm I agree
that this is probably the best approach:
Acked-by: Hans de Goede
Regards,
Hans
---
drive
; !pBuf"
is constantly false because it is a nested if in the else brach, i.e.,
"if (cond) { ... } else { if (cond) {...} }". This patch alters the
if condition to check "pBufLen && pBuf" pointers are not NULL.
Cc: Greg Kroah-Hartman
Cc: Hans de Goede
Cc: Bastie
: Christian Kellner
Ah, yes lets please lower the log-prio of these messages:
Reviewed-by: Hans de Goede
Regards,
Hans
---
arch/x86/kernel/cpu/mce/therm_throt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mce/therm_throt.c
b/arch/x86/kernel/cpu
Hi Thomas,
This is something which I have been wondering for ever since there are
several places in the kernel where IRQ number 0 is treated as not being
valid (as no IRQ found mostly I guess). Where as other places do treat
IRQ number 0 as valid... ?
Some examples which treat IRQ 0 special:
dr
ton_array - add support for newer surface
devices")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205031
Cc: Maximilian Luz
Signed-off-by: Hans de Goede
---
drivers/input/misc/soc_button_array.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git
Hi,
On 05-10-2019 14:17, Maximilian Luz wrote:
Hi,
sorry for the inconvenience this change has caused.
On 10/5/19 12:55 PM, Hans de Goede wrote:
Note ideally this seamingly unrelated change would have been made in a
separate commit, with a message explaining the what and why of this
change
Hi,
On 05-10-2019 17:01, Maximilian Luz wrote:
Hi, again
On 10/5/19 3:20 PM, Hans de Goede wrote:
Ok, on x86 the GPIO drivers really should all be builtin because
various ACPI methods including device D0 / D3 (power-on/off) methods
may depend on them. So normally this should never happen.
If
improve the kdoc text for platform_get_irq_byname() a bit.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205037
Signed-off-by: Hans de Goede
---
drivers/base/platform.c | 46 -
include/linux/platform_device.h | 2 ++
2 files changed, 41 insertions(+), 7
error
on failure, so switch to platform_get_irq_byname_optional() instead which
does not print an error.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205037
Signed-off-by: Hans de Goede
---
drivers/usb/dwc3/drd.c| 4 ++--
drivers/usb/dwc3/gadget.c | 4 ++--
drivers/usb/dwc3/host.c | 4 ++--
3 files changed
Hi All,
Here is a fix for the false-positive dev_err in platform_get_irq_byname()
discussed recently and reported here:
https://bugzilla.kernel.org/show_bug.cgi?id=205037
Since patch 2 depends on patch 1, I think it might be best to merge
all three patches through the same tree ...
Regards,
Han
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to
platform_get_irq*()"), platform_get_irq() will call dev_err() itself on
failure, so there is no need for the driver to also do this.
Signed-off-by: Hans de Goede
---
drivers/usb/dwc3/drd.c| 3 ---
driver
55241d7c9 drivers/hwmon/abituguru.o
After:
text data bss dec hex filename
41315 13512 320 55147d76b drivers/hwmon/abituguru.o
(gcc version 9.2.1, amd64)
Signed-off-by: Colin Ian King
Looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hi,
On 10/3/19 11:33 PM, John Stultz wrote:
On Thu, Oct 3, 2019 at 1:56 PM Hans de Goede wrote:
On 03-10-2019 22:45, John Stultz wrote:
The HiKey960 has only one USB controller, but in order to support both
USB-C gadget/OTG and USB-A (host only) ports. When the USB-C
connection is attached
Hi,
On 01-10-2019 12:51, Heikki Krogerus wrote:
Hi Hans,
That AXP288 extcon driver is the last that uses build-in connection
description. I'm replacing it with a code that finds the role mux
software node instead.
I'm proposing also here a little helper
usb_role_switch_find_by_fwnode() that us
up.
Can you please give this a try and let us know if it fixes things for you?
Regards,
Hans
>From d371dbdef635b57d993bda428a9eb6b929f4472d Mon Sep 17 00:00:00 2001
From: Hans de Goede
Date: Mon, 7 Oct 2019 10:43:00 +0200
Subject: [PATCH] x86/boot: Provide memzero_explicit
The purgatory c
The purgatory code now uses the shared lib/crypto/sha256.c sha256
implementation. This needs memzero_explicit, implement this.
Reported-by: Arvind Sankar
Fixes: 906a4bb97f5d ("crypto: sha256 - Use get/put_unaligned_be32 to get input,
memzero_explicit")
Signed-off-by: Hans de Goede
Hi,
On 07-10-2019 10:50, Hans de Goede wrote:
Hi,
On 07-10-2019 05:09, Arvind Sankar wrote:
Hi, arch/x86/purgatory/purgatory.ro has an undefined symbol
memzero_explicit. This has come from commit 906a4bb97f5d ("crypto:
sha256 - Use get/put_unaligned_be32 to get input, memzero_exp
Hi,
On 07-10-2019 15:09, Ingo Molnar wrote:
* Hans de Goede wrote:
Hi,
On 07-10-2019 10:50, Hans de Goede wrote:
Hi,
On 07-10-2019 05:09, Arvind Sankar wrote:
Hi, arch/x86/purgatory/purgatory.ro has an undefined symbol
memzero_explicit. This has come from commit 906a4bb97f5d ("c
Hi,
On 07-10-2019 15:09, Ingo Molnar wrote:
* Hans de Goede wrote:
Hi,
On 07-10-2019 10:50, Hans de Goede wrote:
Hi,
On 07-10-2019 05:09, Arvind Sankar wrote:
Hi, arch/x86/purgatory/purgatory.ro has an undefined symbol
memzero_explicit. This has come from commit 906a4bb97f5d ("c
Hi,
On 07-10-2019 16:00, Ingo Molnar wrote:
* Hans de Goede wrote:
The purgatory code now uses the shared lib/crypto/sha256.c sha256
implementation. This needs memzero_explicit, implement this.
Reported-by: Arvind Sankar
Fixes: 906a4bb97f5d ("crypto: sha256 - Use get/put_unaligned_be
Hi,
On 07-10-2019 16:22, Ingo Molnar wrote:
* Hans de Goede wrote:
Hi,
On 07-10-2019 16:00, Ingo Molnar wrote:
* Hans de Goede wrote:
The purgatory code now uses the shared lib/crypto/sha256.c sha256
implementation. This needs memzero_explicit, implement this.
Reported-by: Arvind
Hi,
On 07-10-2019 15:20, Arvind Sankar wrote:
On Mon, Oct 07, 2019 at 11:10:18AM +0200, Hans de Goede wrote:
Hi,
On 07-10-2019 10:50, Hans de Goede wrote:
Hi,
On 07-10-2019 05:09, Arvind Sankar wrote:
Hi, arch/x86/purgatory/purgatory.ro has an undefined symbol
memzero_explicit. This has
Hi,
On 18-09-2019 13:52, Yauhen Kharuzhy wrote:
On Wed, Sep 18, 2019 at 02:38:35PM +0300, Heikki Krogerus wrote:
On Tue, Sep 17, 2019 at 10:45:07PM +0300, Yauhen Kharuzhy wrote:
Existing intel_cht_int33fe ACPI pseudo-device driver assumes that
hardware has TypeC connector and register related
Hi,
On 18-09-2019 13:42, Yauhen Kharuzhy wrote:
On Wed, Sep 18, 2019 at 11:20:21AM +0200, Hans de Goede wrote:
Hi,
On 17-09-2019 21:45, Yauhen Kharuzhy wrote:
Existing intel_cht_int33fe ACPI pseudo-device driver assumes that
hardware has TypeC connector and register related devices described
intel_cht_int33fe_common.c and
intel_cht_int33fe_{typeb,typec}.c. Compile all this sources to one .ko
module to make user experience easier.
Signed-off-by: Yauhen Kharuzhy
As promised I've given this a test-run on a typec device, this works
for me:
Tested-by: Hans de Goede
Regards,
Hi,
On 20-09-2019 08:08, Greg Kroah-Hartman wrote:
On Thu, Sep 19, 2019 at 08:39:07PM -0400, Ayman Bagabas wrote:
Introduce quirks and module parameters. 3 quirks are added:
1. Fixes reporting brightness keys twice since it's already handled by
acpi-video.
2. Some models need a short delay
Hi,
On 20-09-2019 09:29, Takashi Iwai wrote:
On Fri, 20 Sep 2019 09:24:08 +0200,
Hans de Goede wrote:
Hi,
On 20-09-2019 08:08, Greg Kroah-Hartman wrote:
On Thu, Sep 19, 2019 at 08:39:07PM -0400, Ayman Bagabas wrote:
Introduce quirks and module parameters. 3 quirks are added:
1. Fixes
Hi Kyle,
On 20-09-2019 05:24, Kyle Tso wrote:
*** BLURB HERE ***
Kyle Tso (2):
usb: typec: tcpm: AMS and Collision Avoidance
usb: typec: tcpm: AMS for PD2.0
May I ask how and on which hardware you have tested this?
And specifically if you have tested this in combination with pwr-role s
devices using?
Regards,
Hans
Regards,
Kyle Tso
On Fri, Sep 20, 2019 at 4:02 PM Hans de Goede wrote:
Hi Kyle,
On 20-09-2019 05:24, Kyle Tso wrote:
*** BLURB HERE ***
Kyle Tso (2):
usb: typec: tcpm: AMS and Collision Avoidance
usb: typec: tcpm: AMS for PD2.0
May I ask how and on
Hi Maximilian,
Interesting patch. Some comments about the i2c situation below.
Also I will give this a test-run on some of the existing devices
which rely on the instantiation of serdev devices for ACPI
devices which are childs of the uart device.
On 19-09-2019 21:56, Maximilian Luz wrote:
Whe
1301 - 1400 of 2701 matches
Mail list logo
