Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Hans de Goede
Hi, On 08/11/2014 08:19 PM, Guenter Roeck wrote: > On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote: >> spin_is_locked() always return false in uniprocessor configuration and >> therefore it >> would be advise to repalce with assert_spin_locked(). >> >> Signed-off-by: Sanjeev Sharma

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Hans de Goede
Hi, On 08/11/2014 09:59 AM, Sanjeev Sharma wrote: > spin_is_locked() always return false in uniprocessor configuration and > therefore it > would be advise to repalce with assert_spin_locked(). > > Signed-off-by: Sanjeev Sharma Looks sane / good to me: Acked-by: Hans de

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Hans de Goede
Hi, On 08/11/2014 09:08 PM, Guenter Roeck wrote: > On Mon, Aug 11, 2014 at 08:55:07PM +0200, Hans de Goede wrote: >> Hi, >> >> On 08/11/2014 08:19 PM, Guenter Roeck wrote: >>> On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote: >>>> spin_is_lo

Re: [PATCH v2] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-08-11 Thread Hans de Goede
aced WARN_ON_ONCE() with lockdep_assert_held() to > avoid runtime overhead instead of assert_spin_locked() Thanks! Acked-by: Hans de Goede Regards, Hans > > drivers/usb/storage/uas.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb

Re: [PATCH v3] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-08-11 Thread Hans de Goede
gt; incorporated review comment suggested by Greg Thanks, this is still: Acked-by: Hans de Goede Regards, Hans > > drivers/usb/storage/uas.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storag

Re: [PATCH] ata: remove deprecated struct ahci_platform_data

2014-08-12 Thread Hans de Goede
Hi, On 08/12/2014 06:22 PM, Bartlomiej Zolnierkiewicz wrote: > The last user of the deprecated struct ahci_platform_data has been > cleaned up recently (SPEAr1340 got a proper PHY driver). > > Cc: Hans de Goede > Signed-off-by: Bartlomiej Zolnierkiewicz Many thanks for mak

Re: Kernel 3.16.0 USB crash

2014-08-14 Thread Hans de Goede
Hi, On 08/14/2014 10:39 AM, Claudio Bizzarri wrote: > Ciao, > > thank you very much for replay, you are right: it's UAS module. Now I'm > using Ubuntu 14.04 with kernel 3.16.1 from > http://kernel.ubuntu.com/~kernel-ppa/mainline/, there is no /proc/config.gz, > but but there is a config file in /

Re: checkpatch false positive

2014-10-21 Thread Hans de Goede
Hi, On 10/21/2014 10:28 AM, Joe Perches wrote: > On Tue, 2014-10-21 at 10:14 +0200, Hans de Goede wrote: >> Hi, >> >> Checkpatch gives the following warning: >> >> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? >> #31: >>

Re: [PATCH] [media] gspca_touptek: Add support for ToupTek UCMOS series USB cameras

2014-10-23 Thread Hans de Goede
Hi, On 10/05/2014 08:43 AM, John McMaster wrote: > Adds support for AmScope MU800 / ToupTek UCMOS08000KPB USB microscope camera. First of all many thanks for writing this driver, and also for submitting it upstream. We always appreciate it a lot when people put in the effort to write a driver to

Re: [PATCH v3 0/4] Fixes for ALPS driver

2014-11-02 Thread Hans de Goede
not process data when last packet's > bit7 is set > input: alps: Fix trackstick detection > > drivers/input/mouse/alps.c | 113 > +++- > 1 file changed, 80 insertions(+), 33 deletions(-) Thanks for working on this, patches 1

[PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-12 Thread Hans de Goede
Hi, This one seems to have fallen through the cracks. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://w

[PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-12 Thread Hans de Goede
len(r->s); ^ In file included from scripts/kconfig/zconf.tab.c:2537:0: scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here struct jump_key *jump; Signed-off-by: Hans de Goede --- scripts/kconfig/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: uas: module not loaded automatically

2014-10-05 Thread Hans de Goede
Hi, On 10/04/2014 08:35 PM, Jan Kiszka wrote: > Hi, > > my Delock external USB drive stopped working after updating from a > UAS-disabled distro kernel to latest 3.17-rc7 with UAS on. That UAS was > key became clear to me only after looking at storage_probe(): the device > is ignored by usb-stora

Re: uas: module not loaded automatically

2014-10-05 Thread Hans de Goede
Hi, On 10/05/2014 11:14 AM, Jan Kiszka wrote: > On 2014-10-05 11:08, Hans de Goede wrote: >> Hi, >> >> On 10/04/2014 08:35 PM, Jan Kiszka wrote: >>> Hi, >>> >>> my Delock external USB drive stopped working after updating from a >>> UAS-di

Re: uas: module not loaded automatically

2014-10-05 Thread Hans de Goede
Hi, On 10/05/2014 11:31 AM, Jan Kiszka wrote: > On 2014-10-05 11:23, Hans de Goede wrote: >> Hi, >> >> On 10/05/2014 11:14 AM, Jan Kiszka wrote: >>> On 2014-10-05 11:08, Hans de Goede wrote: >>>> Hi, >>>> >>>> On 10/04/2014 08:35

Re: uas: module not loaded automatically

2014-10-05 Thread Hans de Goede
Hi, On 10/05/2014 11:48 AM, Jan Kiszka wrote: > On 2014-10-05 11:43, Hans de Goede wrote: >> Hi, >> >> On 10/05/2014 11:31 AM, Jan Kiszka wrote: >>> On 2014-10-05 11:23, Hans de Goede wrote: >>>> Hi, >>>> >>>> On 10/05/2014 11

Re: [PATCH 1/3] input: alps: Reset mouse before identifying it

2014-10-03 Thread Hans de Goede
it fixing this problem and both > parts > touchpad and trackstick are detected. > > Signed-off-by: Pali Rohár > Tested-by: Pali Rohár Looks good and seems sensible: Acked-by: Hans de Goede Regards, Hans > --- > drivers/input/mouse/alps.c |2 ++ > 1 file cha

Re: [PATCH 2/3] input: alps: For protocol V3, do not process data when last packet's bit7 is set

2014-10-03 Thread Hans de Goede
Hi, On 10/03/2014 11:43 AM, Pali Rohár wrote: > Sometimes laptops with closed lid receive invalid ALPS protocol V3 packets > with > last bit7 set. > > This happens on Dell Latitude laptops and it looks like it is BIOS bug. > Probably > EC does not correctly split keyboard and touchpad PS/2 data

Re: [PATCH 3/3] input: alps: Reset mouse and ALPS driver immediately after first invalid packet

2014-10-03 Thread Hans de Goede
to the relevant patches for the launchpad issues too. While on the topic of tags, once we've agreed upon the return value to use for the 2nd patch, can you please resend with a "Cc: sta...@vger.kernel.org" added to all 3 patches? > Signed-off-by: Pali Rohár > Tested-by: Pal

Re: [PATCH 2/3] input: alps: For protocol V3, do not process data when last packet's bit7 is set

2014-10-03 Thread Hans de Goede
Hi, On 10/03/2014 11:58 AM, Pali Rohár wrote: > On Friday 03 October 2014 11:51:22 Hans de Goede wrote: >> Hi, >> >> On 10/03/2014 11:43 AM, Pali Rohár wrote: >>> Sometimes laptops with closed lid receive invalid ALPS >>> protocol V3 packets with last

Re: [PATCH 3/3] input: alps: Reset mouse and ALPS driver immediately after first invalid packet

2014-10-03 Thread Hans de Goede
Hi, On 10/03/2014 12:05 PM, Pali Rohár wrote: > On Friday 03 October 2014 11:55:52 Hans de Goede wrote: >> Hi, >> >> On 10/03/2014 11:43 AM, Pali Rohár wrote: >>> For unknown reasons linux psmouse alps driver sometimes >>> receive totally invalid packet

Re: [PATCH 3/3] input: alps: Reset mouse and ALPS driver immediately after first invalid packet

2014-10-03 Thread Hans de Goede
Hi, On 10/03/2014 12:23 PM, Pali Rohár wrote: > On Friday 03 October 2014 12:18:51 Hans de Goede wrote: >>> On my E6440 machine it somehow working. When driver >>> doing ps/2 reset keyboard, touchpad and trackstick not >>> responding. >> >> Right, but

Re: [PATCH 3/3] input: alps: Reset mouse and ALPS driver immediately after first invalid packet

2014-10-03 Thread Hans de Goede
Hi, On 10/03/2014 01:03 PM, Hans de Goede wrote: > Hi, > > On 10/03/2014 12:23 PM, Pali Rohár wrote: >> On Friday 03 October 2014 12:18:51 Hans de Goede wrote: >>>> On my E6440 machine it somehow working. When driver >>>> doing ps/2 reset keyboard, touc

Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-08 Thread Hans de Goede
Hi, On 07-07-15 18:47, Jeremy White wrote: Well, the checkpatch.pl reports were all style (and mostly whitespace); roughly 3000 of them against 3000 lines of code :-/. I did review the code, looking for areas where I thought it would badly cram into the kernel, and I adjusted the few I found

Re: [PATCH 0/2] New NAND chip IDs

2015-07-28 Thread Hans de Goede
Hi, On 07/28/2015 04:29 PM, Michal Suchanek wrote: Hello, the NAND chips on Cubietech boards are not known to Linux. I used Petros Angelatos' patch from sunxi experimental tree for one chip and added another chip. I hope it's ok to send both patches to avoid merge conflict. I do not think t

Re: [PATCH 0/2] New NAND chip IDs

2015-07-28 Thread Hans de Goede
Hi, On 07/28/2015 05:10 PM, Boris Brezillon wrote: Hi Hans, On Tue, 28 Jul 2015 16:49:58 +0200 Hans de Goede wrote: Hi, On 07/28/2015 04:29 PM, Michal Suchanek wrote: Hello, the NAND chips on Cubietech boards are not known to Linux. I used Petros Angelatos' patch from sunxi experim

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-28 Thread Hans de Goede
Hi, On 07/28/2015 05:09 PM, Timo Sigurdsson wrote: Hi, Hans de Goede schrieb am 28.07.2015 16:24: I've no problem with Timo submitting a cleaned up version of his patch and you taking that instead. I just wanted to point out that I do have a similar patch pending. Ok, I will do tha

Re: [PATCH 0/2] New NAND chip IDs

2015-07-28 Thread Hans de Goede
Hi, On 07/28/2015 05:30 PM, Boris Brezillon wrote: On Tue, 28 Jul 2015 17:19:40 +0200 Boris Brezillon wrote: Hi Hans, Here is a more appropriate answer ;-) On Tue, 28 Jul 2015 16:49:58 +0200 Hans de Goede wrote: Hi, On 07/28/2015 04:29 PM, Michal Suchanek wrote: Hello, the NAND chips

Re: [linux-sunxi] [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi

2015-08-08 Thread Hans de Goede
Hi, On 02-08-15 18:18, Timo Sigurdsson wrote: sun7i-a20-bananapi.dts doesn't contain regulator nodes for the AXP209 PMU driver, so add them to allow for voltage-scaling with cpufreq-dt. Signed-off-by: Timo Sigurdsson Thanks for doing this, looks good to me: Acked-by: Hans de

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-27 Thread Hans de Goede
Hi, On 27-07-15 03:28, Timo Sigurdsson wrote: sun7i-a20-bananapi.dts doesn't contain regulator nodes for the AXP209 PMU driver, so add them to allow for voltage-scaling with cpufreq-dt. With the regulators enabled, we can define board-specific operating points. The defined CPU voltages are more

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-27 Thread Hans de Goede
Hi, On 27-07-15 14:09, public_tim...@silentcreek.de wrote: Hi, Hans de Goede schrieb am 27.07.2015 10:07: I've a simular patch here: https://github.com/jwrdegoede/linux-sunxi/commit/6a30b7d5be6012b81e5e1439a444e41c0ac1afc1 I did not submit this upstream yet as it is part of a seri

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-27 Thread Hans de Goede
Hi, On 27-07-15 14:36, public_tim...@silentcreek.de wrote: Hi again, one more thing... Hans de Goede schrieb am 27.07.2015 10:07: IMHO we should just stick with the standard operating points unless we know that there are stability issues with them (such as e.g. on the A10 OlinuxIno Lime

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-28 Thread Hans de Goede
Hi, On 07/28/2015 02:49 PM, Maxime Ripard wrote: Hi, On Mon, Jul 27, 2015 at 02:43:20PM +0200, Hans de Goede wrote: Hi, On 27-07-15 14:09, public_tim...@silentcreek.de wrote: Hi, Hans de Goede schrieb am 27.07.2015 10:07: I've a simular patch here: https://github.com/jwrdegoede/

Re: [Intel-gfx] [4.2-rc4] acpi|drm|i915: circular locking dependency: acpi_video_get_backlight_type

2015-08-13 Thread Hans de Goede
ted commit 93a291dfaf9c328ca5a9cea1733af1a128efe890 Author: Hans de Goede Date: Tue Jun 16 16:27:52 2015 +0200 ACPI / video: Move backlight notifier to video_detect.c and the problem seems to be gone. Hans, any thoughts? Looking into this atm, lockdep clearly is right. Sorry about this I have put a lot of thinking in

Re: [Intel-gfx] [4.2-rc4] acpi|drm|i915: circular locking dependency: acpi_video_get_backlight_type

2015-08-14 Thread Hans de Goede
Hi, On 13-08-15 16:33, Hans de Goede wrote: Hi, On 12-08-15 21:26, Ville Syrjälä wrote: On Mon, Aug 10, 2015 at 08:29:00PM +0200, Sedat Dilek wrote: On Sat, Aug 1, 2015 at 2:23 PM, Sedat Dilek wrote: On Mon, Jul 27, 2015 at 12:33 AM, Sedat Dilek wrote: Hi, this my first build of a 4.2

Re: [linux-sunxi] [RFC PATCH 0/6] mtd: nand: per-partition ECC config

2015-08-14 Thread Hans de Goede
Hi all, On 30-07-15 15:50, Boris Brezillon wrote: Hello, It's been a year and a half since I posted my first series proposing an approach to support per-partition ECC config [1]. First of all, before describing what's done in this patch series, I'd like to sum-up why this is needed, and why a

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-05 Thread Hans de Goede
Hi, On 05-05-16 18:00, Stephen Warren wrote: On 05/05/2016 02:05 AM, Hans de Goede wrote: Hi, On 04-05-16 22:25, Thierry Reding wrote: On Wed, May 04, 2016 at 11:23:20AM -0600, Stephen Warren wrote: On 05/04/2016 08:40 AM, Thierry Reding wrote: From: Thierry Reding Starting with commit

Re: [PATCH RFC 1/5] net: phy: sun8i-h3-ephy: Add bindings for Allwinner H3 Ethernet PHY

2016-05-07 Thread Hans de Goede
Hi, On 07-05-16 07:30, Chen-Yu Tsai wrote: Hi, On Tue, Apr 12, 2016 at 9:38 AM, Chen-Yu Tsai wrote: On Tue, Apr 12, 2016 at 3:23 AM, Florian Fainelli wrote: On 04/04/16 09:22, Chen-Yu Tsai wrote: The Allwinner H3 SoC incorporates an Ethernet PHY. This is enabled and configured through a me

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-05 Thread Hans de Goede
Hi, On 04-05-16 22:25, Thierry Reding wrote: On Wed, May 04, 2016 at 11:23:20AM -0600, Stephen Warren wrote: On 05/04/2016 08:40 AM, Thierry Reding wrote: From: Thierry Reding Starting with commit 0b52297f2288 ("reset: Add support for shared reset controls") there is a reference count for re

Re: [PATCH 0/6] ARM: dts: sun5i: q8-common: Enable various peripherals

2016-05-18 Thread Hans de Goede
Hi Chen-Yu, On 17-05-16 17:56, Chen-Yu Tsai wrote: Hi everyone, This series enables more peripherals for Allwinner A13-based Q8 devices. The peripherals include the WiFi, the PMIC's micro-usb power supply (driver), audio codec (headphone and speaker), and full display support with the new DRM K

Re: [linux-sunxi] Re: [PATCH] regulator: axp20x: Add support for the (external) drivebus regulator

2016-05-28 Thread Hans de Goede
Hi, On 16-05-16 19:06, Chen-Yu Tsai wrote: Hi, On Sun, May 15, 2016 at 1:55 AM, Hans de Goede wrote: The axp20x pmics have 2 power inputs, one called ACIN which is intended for to be supplied via a powerbarrel on the board and one called VBUS which is intended to be supplied via an otg

Re: [PATCH] regulator: axp20x: Fix LDO4 linear voltage range

2016-04-27 Thread Hans de Goede
Hi, On 26-04-16 16:57, Mark Brown wrote: On Tue, Apr 26, 2016 at 10:18:04PM +0800, Chen-Yu Tsai wrote: Hans sent an identical patch (plus another fix) a month ago though. I have no record of any such patch, I don't know where it might've been sent. It is here: https://groups.google.com/fo

[PATCH v2 2/3] regulator: axp20x: Fix axp22x ldo_io voltage ranges

2016-04-27 Thread Hans de Goede
The minium voltage of 1800mV is a copy and paste error from the axp20x regulator info. The correct minimum voltage for the ldo_io regulators on the axp22x is 700mV. Fixes: 1b82b4e4f954 ("regulator: axp20x: Add support for AXP22X regulators") Signed-off-by: Hans de Goede Acked-by: Ch

[PATCH v2 1/3] regulator: axp20x: Fix axp209 ldo4 ranges

2016-04-27 Thread Hans de Goede
The axp209 ldo4 regulator has a hole at (skips) 2600 mV and 2900 mV, fix its range table to match. Fixes: 13d57e64352a ("regulator: axp20x: Use linear voltage ranges for AXP20X LDO4") Signed-off-by: Hans de Goede Acked-by: Chen-Yu Tsai --- Changes in v2: -Add Fixes, Acked-by Ch

[PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes

2016-04-27 Thread Hans de Goede
ned-off-by: Hans de Goede --- drivers/regulator/core.c | 6 ++ drivers/regulator/of_regulator.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index e0b7642..8062c83 100644 --- a/drivers/regulator/core.c +++

[PATCH 2/2] regulator: axp20x: Handle regulator_register returning ENODEV

2016-04-27 Thread Hans de Goede
Handle regulator_register returning ENODEV, this may happen when the dts node for the regulator contains "status = disabled" which is useful for the ldo_io regulators, to avoid the regulator code getting in the way of gpio use of these pins. Signed-off-by: Hans de Goede --- drivers

[PATCH resend 0/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes

2016-04-27 Thread Hans de Goede
Hi Mark, And here is a resend of a non bug-fix core patch + a follow-up patch for the axp20x regulator driver. See the commit message of the first patch for the why and how of this patch-set. Regards, Hans

[PATCH v2 resend 0/3] regulator: axp20x: 3 bugfixes

2016-04-27 Thread Hans de Goede
Hi Mark, et al, Here are 3 bugfixes for the axp20x regulator driver, sorry for not sending these to the right email address before. Regards, Hans

[PATCH v2 3/3] regulator: axp20x: Fix axp22x ldo_io registration error on cold boot

2016-04-27 Thread Hans de Goede
errors. Signed-off-by: Hans de Goede --- drivers/regulator/axp20x-regulator.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c index 89f6842..5ddaa82 100644 --- a/drivers/regulator/axp20x

Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes

2016-04-27 Thread Hans de Goede
Hi, On 27-04-16 16:24, Mark Brown wrote: On Wed, Apr 27, 2016 at 04:03:44PM +0200, Hans de Goede wrote: So if we want to use these pins as gpio pins we must not register a regulator for these pins at all, otherwise any gpio use (switching to input, or writing a value) gets undone when the

Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes

2016-04-27 Thread Hans de Goede
Hi, On 27-04-16 16:37, Mark Brown wrote: On Wed, Apr 27, 2016 at 04:31:02PM +0200, Hans de Goede wrote: On 27-04-16 16:24, Mark Brown wrote: The regulator API should not touch any regulators that it doesn't have permission to change the state for. All other regulators are strictly

Re: [PATCH v2 3/3] regulator: axp20x: Fix axp22x ldo_io registration error on cold boot

2016-04-27 Thread Hans de Goede
Hi, On 27-04-16 17:12, Mark Brown wrote: On Wed, Apr 27, 2016 at 03:59:28PM +0200, Hans de Goede wrote: The maximum supported voltage for ldo_io# is 3.3V, but on cold boot the selector comes up at 0x1f, which maps to 3.8V. Why not just implement that? I guess I was not clear in my commit

Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes

2016-04-27 Thread Hans de Goede
Hi, On 27-04-16 17:50, Maxime Ripard wrote: Hi Mark, On Wed, Apr 27, 2016 at 04:01:08PM +0100, Mark Brown wrote: On Wed, Apr 27, 2016 at 04:40:05PM +0200, Hans de Goede wrote: Or, since regulator_of_get_init_data uses for_each_available_child_of_node which checks the "status" va

Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes

2016-04-27 Thread Hans de Goede
Hi, On 27-04-16 17:52, Hans de Goede wrote: Hi, On 27-04-16 17:50, Maxime Ripard wrote: Hi Mark, On Wed, Apr 27, 2016 at 04:01:08PM +0100, Mark Brown wrote: On Wed, Apr 27, 2016 at 04:40:05PM +0200, Hans de Goede wrote: Or, since regulator_of_get_init_data uses

Re: [PATCH v2 3/3] regulator: axp20x: Fix axp22x ldo_io registration error on cold boot

2016-04-27 Thread Hans de Goede
Hi, On 27-04-16 17:48, Mark Brown wrote: On Wed, Apr 27, 2016 at 05:35:31PM +0200, Hans de Goede wrote: On 27-04-16 17:12, Mark Brown wrote: Why not just implement that? Given the formula in the datasheet to calculate the ldo_io regulator voltage 0x1f maps to 3.8V, but according to the

Re: [PATCH v2 3/3] regulator: axp20x: Fix axp22x ldo_io registration error on cold boot

2016-04-27 Thread Hans de Goede
Hi, On 27-04-16 18:30, Mark Brown wrote: On Wed, Apr 27, 2016 at 06:04:53PM +0200, Hans de Goede wrote: On 27-04-16 17:48, Mark Brown wrote: Well, I guess someone can just measure what happens? What happens will likely depend on the pmic input voltage, which can be either 5V from a

[PATCH v3] regulator: axp20x: Fix axp22x ldo_io registration error on cold boot

2016-04-27 Thread Hans de Goede
guarantee reliable operation above 3.3V, so on boards where this regulator is used the regulator-max-microvolt setting must be 3.3V or less. Signed-off-by: Hans de Goede --- Changes in v2: -No changes (resend) Changes in v3: -Instead of overwriting the 0x1f register value even when the regulator is

[PATCH] regulator: axp20x: Add support for the (external) drivebus regulator

2016-05-14 Thread Hans de Goede
is added. When this is present the misc-control register is written to change the N_VBUSEN input pin to DRIVEBUS output pin mode and the extra drivebus regulator is registered with the regulator subsystem. Signed-off-by: Hans de Goede --- Documentation/devicetree/bindings/mfd/axp20x.txt | 5

Re: [PATCH] Input: psmouse - clean up Cypress probe

2015-12-03 Thread Hans de Goede
nue trying IntelliMouse [Explorer]. Given that Cypress devices only have issue with Sentelic probes probing Imtellimouse should be safe. Signed-off-by: Dmitry Torokhov Thanks, looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- drivers/input/mouse/psmouse-base.c | 20 --

Re: [PATCH 5/6] Input: psmouse - factor out common protocol probing code

2015-12-02 Thread Hans de Goede
Hi, Thanks for splitting out the series, patches 1 - 4 look good to me and are: Reviewed-by: Hans de Goede I've some comments inline for this one. On 29-11-15 06:13, Dmitry Torokhov wrote: In preparation of limiting protocols that we try on pass-through ports, let's rework init

Re: [PATCH 6/6] Input: psmouse - limit protocols that we try on passthrough ports

2015-12-02 Thread Hans de Goede
ed-by: Hans de Goede Regards, Hans --- drivers/input/mouse/psmouse-base.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c index ee59b0e..e909c6e 100644 --- a/drivers/input/mouse/psmouse-base.c +++ b/dr

Re: [PATCH 5/6] Input: psmouse - factor out common protocol probing code

2015-12-03 Thread Hans de Goede
Hi, On 02-12-15 20:18, Dmitry Torokhov wrote: Hi Hans, On Wed, Dec 02, 2015 at 04:20:48PM +0100, Hans de Goede wrote: Hi, Thanks for splitting out the series, patches 1 - 4 look good to me and are: Reviewed-by: Hans de Goede I've some comments inline for this one. Thanks for spe

Re: [PATCH v2] Input: psmouse - rename ps2pp_init() to ps2pp_detect()

2015-12-03 Thread Hans de Goede
Hi, On 02-12-15 20:25, Dmitry Torokhov wrote: This makes Logitech PS2++ protocol implementation consistent with the naming in other protocols. Also mark the stub as "static inline" Signed-off-by: Dmitry Torokhov Much better / less confusing then the old code :) Reviewed-by: Han

Re: [linux-sunxi] [PATCH 0/4] ARM: sun9i: Support Allwinner A80 NMI controller

2015-12-03 Thread Hans de Goede
to me and is: Reviewed-by: Hans de Goede Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Input: psmouse - limit protocols that we try on passthrough ports

2015-11-25 Thread Hans de Goede
Hi Dmitry, On 25-11-15 03:16, Dmitry Torokhov wrote: PS/2 protocol is slow, and using it with pass-through port (where we encapsulate PS/2 into PS/2) is slower yet so it takes quite a bit of time to do full protocol discovery for device attached to a pass-through port. However, so far we have no

Re: [PATCH 0/4] pinctrl: sunxi: Implement proper irq DT parsing

2015-07-20 Thread Hans de Goede
ntroducing some custom DT parsing code to have a consistant binding with the GPIO one, which will also fix the multiple banks issues, and document it. Let me know what you think, Maxime Series looks good to me: Reviewed-by: Hans de Goede Regards, Hans Maxime Ripard (4): pinctrl: sunxi

Re: [PATCH RFC 05/15] mmc: sunxi: Support MMC_DDR52 timing modes

2016-01-21 Thread Hans de Goede
Hi, On 21-01-16 06:26, Chen-Yu Tsai wrote: DDR transfer modes include UHS-1 DDR50 and MMC HS-DDR (or MMC_DDR52). Consider MMC_DDR52 when setting clock delays. Signed-off-by: Chen-Yu Tsai --- drivers/mmc/host/sunxi-mmc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH RFC 09/15] ARM: dts: sun6i: sina31s: Switch to mmc3 for onboard eMMC

2016-01-21 Thread Hans de Goede
Hi, On 21-01-16 06:26, Chen-Yu Tsai wrote: According to Allwinner, only mmc3 supports 8 bit DDR transfers for eMMC. Switch to mmc3 for the onboard eMMC, and also assign vqmmc for signal voltage sensing/switching, and "cap-mmc-hw-reset" to denote this instance can use eMMC hardware reset. This

Re: [PATCH RFC 00/15] mmc: sunxi: Support vqmmc regulator and eMMC DDR modes

2016-01-21 Thread Hans de Goede
Hi, On 21-01-16 06:26, Chen-Yu Tsai wrote: Hi everyone, This series adds support for vqmmc regulator and eMMC DDR modes for sunxi-mmc. Allwinner's MMC controller supports eMMC 4.41 on earlier SoCs, and up to 5.0 on latest ones. UHS-1 modes are also supported by the hardware, but these are not c

Re: [PATCH RFC 09/15] ARM: dts: sun6i: sina31s: Switch to mmc3 for onboard eMMC

2016-01-21 Thread Hans de Goede
Hi, On 21-01-16 13:23, Chen-Yu Tsai wrote: On Thu, Jan 21, 2016 at 7:16 PM, Hans de Goede wrote: Hi, On 21-01-16 06:26, Chen-Yu Tsai wrote: According to Allwinner, only mmc3 supports 8 bit DDR transfers for eMMC. Switch to mmc3 for the onboard eMMC, and also assign vqmmc for signal voltage

Re: [PATCH RFC 05/15] mmc: sunxi: Support MMC_DDR52 timing modes

2016-01-21 Thread Hans de Goede
Hi, On 21-01-16 12:55, Chen-Yu Tsai wrote: On Thu, Jan 21, 2016 at 7:14 PM, Hans de Goede wrote: Hi, On 21-01-16 06:26, Chen-Yu Tsai wrote: DDR transfer modes include UHS-1 DDR50 and MMC HS-DDR (or MMC_DDR52). Consider MMC_DDR52 when setting clock delays. Signed-off-by: Chen-Yu Tsai

Re: [PATCH RFC 09/15] ARM: dts: sun6i: sina31s: Switch to mmc3 for onboard eMMC

2016-01-21 Thread Hans de Goede
Hi, On 21-01-16 13:28, Chen-Yu Tsai wrote: On Thu, Jan 21, 2016 at 8:25 PM, Hans de Goede wrote: Hi, On 21-01-16 13:23, Chen-Yu Tsai wrote: On Thu, Jan 21, 2016 at 7:16 PM, Hans de Goede wrote: Hi, On 21-01-16 06:26, Chen-Yu Tsai wrote: According to Allwinner, only mmc3 supports 8

Re: [PATCH] ACPI / video: driver must be registered before checking for keypresses

2016-01-05 Thread Hans de Goede
eed the correct way to fix this: Reviewed-by: Hans de Goede Rafael, can you please add this fix to acpi-next ? Regards, Hans --- drivers/acpi/acpi_video.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/acpi/acpi_video.c b/drivers/a

Re: thinkpad_acpi: BUG: unable to handle kernel NULL pointer dereference

2016-01-05 Thread Hans de Goede
Hi all, On 05-01-16 09:17, Pali Rohár wrote: Hello, looks like this fault is in acpi video module, not in thinkpad. CCing Hans who introduced this acpi video brightness key change. Hans, can you look at this bug? Pali thanks for bringing this to my attention. Adrien Schildknecht has already

simplefb device tree bindings enumeration and handover

2014-11-12 Thread Hans de Goede
Hi all, Today I've had a long discussion with Grant Likely on irc, in the #devicetree channel, on the devicetree bindings for simplefb. The 2 topics discussed were enumeration of simplefb nodes, and the handover to a hw specific driver later in the boot process. We've come to the following concl

Re: [linux-sunxi] [PATCH v2 0/5] ARM: sunxi: Add support for USB OTG PHY

2014-11-11 Thread Hans de Goede
Hi, On 11/10/2014 07:55 PM, Roman Byshko wrote: > Hi, > > There is already support for two USB phys, which are used for > USB host controllers on Allwinner SoC aka sunxi. > > This patch series add support for the USB OTG phy (aka phy0). > > The code has been tested on Allwinner A20 aka sun7i (C

Re: linux-next: build failure after merge of the omap_dss2 tree

2014-11-25 Thread Hans de Goede
: #ifdef CONFIG_OF ... int of_clk_get_parent_count(struct device_node *np); ... #endif So we need both CONFIG_OF and CONFIG_COMMON_CLK, the attached patch should fix this. Regards, Hans >From 8ba38cd5ab635b67a50f8051ce2bdbcfa79253a2 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Tue, 25 Nov 2014

Re: [PATCH] Input: i8042 - disable active multiplexing by default

2014-10-11 Thread Hans de Goede
reboot. >> > + * Some laptops do increment active multiplexing mode correctly; >> > + * unfortunately they are in minority. >> > */ >> >> s/increment/implement/ ? > > Thanks Dave, I'll fix it up. The patch looks good to me, and with the above fixup is: Ack

Re: [PATCH 1/2] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-05-24 Thread Hans de Goede
-by: Hans de Goede Regards, Hans --- drivers/mmc/host/sunxi-mmc.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c index 4d3e1ff..7cdeecd 100644 --- a/drivers/mmc/host/sunxi-mmc.c +++ b

Re: [PATCH 2/2] mmc: sunxi: Also set SDXC_LOW_POWER_ON

2015-05-25 Thread Hans de Goede
Hi, On 24-05-15 20:04, Michal Suchanek wrote: The function sunxi_mmc_oclk_onoff filters out the SDXC_LOW_POWER_ON flag but never sets it. Set SDXC_LOW_POWER_ON when oclk is disabled. Nack, looking at the datasheet I do not thing this patch actually does anything, according to the datasheet se

Re: [linux-sunxi] [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support

2015-05-09 Thread Hans de Goede
Hi, On 06-05-15 11:31, Jens Kuske wrote: Hi everyone, This patch series introduces basic kernel support for Allwinner's H3 SoC, mainly basic clocks and pinctrl. It also adds interrupts, timers, watchdog, RTC, dmaengine, MMC and UARTs, which are mostly compatible to those in earlier SoCs like A2

Re: [PATCH 1/6] ARM: sunxi: Add Machine support for A33

2015-05-10 Thread Hans de Goede
Hi, On 10-05-15 08:46, Vishnu Patekar wrote: Allwinnner A33 quad core cortex-a7 based SOC. It is similar to A23. Renamed cpu method to "allwinner,sun8i" for common sun8i smp. smp code is generic for A23, A33 and hopefully H3. Signed-off-by: Vishnu Patekar --- Documentation/devicetree/bindin

Re: [PATCH 2/6] pinctrl: sunxi: add allwinner A33 PIO controller support

2015-05-10 Thread Hans de Goede
Hi, On 10-05-15 08:46, Vishnu Patekar wrote: A33 PIO has 7 ports which starts from PB and has two interrupt ports. Signed-off-by: Vishnu Patekar Is this patch really necessary at all? The A33 is a pin compatible drop in for the A23, I would expect things to work just fine using the A23 pinmu

Re: [PATCH 4/6] ARM: dts: sunxi: add common sun8i dtsi

2015-05-10 Thread Hans de Goede
Hi, On 10-05-15 08:46, Vishnu Patekar wrote: added the common sun8i.dtsi and "allwinner,sun8i" compatible for common sun8i features, I've referred the h3 dtsi by Jens Kuske. accordingly modified the sun8i-a23.dtsi and a23 dts. I don't have a23 device, however, dts got compiled. Signed-off-by:

Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner A33 DTSI

2015-05-10 Thread Hans de Goede
Hi, On 10-05-15 08:46, Vishnu Patekar wrote: this is based on common sun8i.dtsi patch. sun8i-a23.dtsi and sun8i-a33.dtsi are same, A33 specific features e.g. clocks can be added in future. Signed-off-by: VishnuPatekar This seems to only contain stuff which can be shared with the a23 dts, why

Re: [PATCH 6/6] ARM: dts: sun8i: Add ET-Q8 A33 support

2015-05-10 Thread Hans de Goede
Hi, On 10-05-15 08:46, Vishnu Patekar wrote: ET-Q8_A33 is A33 based cheap tablet in common Q8 format. It has 512MB RAM, 4GB Nand, 7" Display, RDA5900P wifi, GSL1680 touch, etc. Where does the ET prefix come from ? The ippo boards have an ippo prefix as that is written on the pcb ... Regards

Re: [PATCH 2/6] pinctrl: sunxi: add allwinner A33 PIO controller support

2015-05-10 Thread Hans de Goede
Hi, On 10-05-15 11:00, Chen-Yu Tsai wrote: Hi, On Sun, May 10, 2015 at 4:50 PM, Hans de Goede wrote: Hi, On 10-05-15 08:46, Vishnu Patekar wrote: A33 PIO has 7 ports which starts from PB and has two interrupt ports. Signed-off-by: Vishnu Patekar Is this patch really necessary at all

Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner A33 DTSI

2015-05-10 Thread Hans de Goede
Hi, On 10-05-15 11:33, Vishnu Patekar wrote: Hi, On Sun, May 10, 2015 at 2:23 PM, Hans de Goede wrote: Hi, On 10-05-15 08:46, Vishnu Patekar wrote: this is based on common sun8i.dtsi patch. sun8i-a23.dtsi and sun8i-a33.dtsi are same, A33 specific features e.g. clocks can be added in

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-02-25 Thread Hans de Goede
ries? Ah, sorry I missed you did a v2 (I did review v1). Series looks good to me and is: Acked-by: Hans de Goede Regards, Hans Sorry for pushing, but I am running out of time and I'd like to be able to include the fixes in RHEL/Fedora too. Cheers, Benjamin Benjamin Tissoires (7): I

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-03-09 Thread Hans de Goede
Hi, On 09-03-15 07:46, Dmitry Torokhov wrote: On Wed, Feb 25, 2015 at 03:58:20PM +0100, Hans de Goede wrote: Hi, On 25-02-15 15:36, Benjamin Tissoires wrote: On Mon, Feb 16, 2015 at 10:23 PM, Benjamin Tissoires wrote: On Fri, Feb 6, 2015 at 3:04 PM, Benjamin Tissoires wrote: Hi, This is

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-03-10 Thread Hans de Goede
x this ootb. If you can let me know what seems to be a good sensitivity that would be useful. Regards, Hans - Steven On Mon, Mar 9, 2015 at 12:36 PM, Benjamin Tissoires wrote: On Mon, Mar 9, 2015 at 4:24 AM, Hans de Goede wrote: Hi, On 09-03-15 07:46, Dmitry Torokhov wrote: On Wed, Fe

Re: [PATCH v2 14/17] ata: ahci_tegra: remove power sequence from driver

2015-03-12 Thread Hans de Goede
e Hsu Can you please repost this patch w/ Hans de Goede cc'd? Just reposting the patch as a reply to itself w/ the cc added should do. Thanks. Patch looks good to me: Acked-by: Hans de Goede Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-24 Thread Hans de Goede
Hi, On 23-03-15 18:02, Pali Rohár wrote: On Monday 23 March 2015 12:39:48 Hans de Goede wrote: Hi, On 22-03-15 14:46, Pali Rohár wrote: This patch adds detection of trackstick for v7 protocol devices. Code in this patch is used in official Dell touchpad linux drivers for Dell models: Dell

Re: [PATCH v3] SATA: OCTEON: support SATA on OCTEON platform

2015-03-06 Thread Hans de Goede
Hi, On 05-03-15 15:58, Aleksey Makarov wrote: The OCTEON SATA controller is currently found on cn71XX devices. Signed-off-by: David Daney Signed-off-by: Vinita Gupta Signed-off-by: Aleksey Makarov --- Version 2: https://lkml.kernel.org/g/<1422038495-5204-1-git-send-email-aleksey.maka...@aur

Re: [PATCH v3] SATA: OCTEON: support SATA on OCTEON platform

2015-03-07 Thread Hans de Goede
Hi, On 06-03-15 17:25, David Daney wrote: On 03/06/2015 02:06 AM, Hans de Goede wrote: Hi, On 05-03-15 15:58, Aleksey Makarov wrote: The OCTEON SATA controller is currently found on cn71XX devices. Signed-off-by: David Daney Signed-off-by: Vinita Gupta Signed-off-by: Aleksey Makarov

Re: [PATCH 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY

2015-03-19 Thread Hans de Goede
Hi, On 19-03-15 02:23, Brian Norris wrote: Signed-off-by: Brian Norris --- Light dependency on: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/331921.html for the surrounding text. arch/arm/boot/dts/bcm7445.dtsi | 36 1 file changed,

Re: [PATCH v4 3/6] Input: synaptics - Query min dimensions for fw v8.1

2015-02-07 Thread Hans de Goede
* https://bugzilla.kernel.org/show_bug.cgi?id=91541 */ >> + (SYN_ID_MAJOR(priv->identity) == 8 && >> + SYN_ID_MINOR(priv->identity) == 1))) { > > Hmm... this can be actually read as: > + SYN_ID_FULL(priv->identity) =

Re: [PATCH] Input: ALPS: Move v7 packet info to Documentation and v6 packet info

2015-02-10 Thread Hans de Goede
Hi, On 10-02-15 13:43, Pali Rohár wrote: This patch move all packet info from driver source code to documentation and adds info about v6 packet format (from driver source code). Signed-off-by: Pali Rohár Thanks for doing this: Acked-by: Hans de Goede Regards, Hans --- Documentation

Re: Dell ALPS patches for Dell Latitude 7250 & 7450

2015-02-10 Thread Hans de Goede
Hi, On 10-02-15 14:19, Pali Rohár wrote: Hello, now I found on Dell support website, that they also provide psmouse/alps.c driver for new Dell Latitude 7250 & 7450 machines: http://www.dell.com/support/home/gh/en/ghdhs1/Drivers/DriversDetails?driverId=N5V5D It is again in Ubuntu support packag

Re: [PATCH] Input: sun4i-ts: add thermal driver dependency

2015-02-11 Thread Hans de Goede
Hi, On 11-02-15 19:24, Dmitry Torokhov wrote: On Thu, Jan 29, 2015 at 10:51:51AM -0800, Dmitry Torokhov wrote: On Thu, Jan 29, 2015 at 08:50:18AM +0100, Hans de Goede wrote: Hi, On 28-01-15 16:17, Arnd Bergmann wrote: The sun4i-ts driver has had a dependency on the thermal code since it was

<    8   9   10   11   12   13   14   15   16   17   >