Re: [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support

2014-01-20 Thread Hans de Goede
Hi, On 01/20/2014 03:41 PM, Roger Quadros wrote: Hi, Some platforms have a PHY hooked up to the SATA controller. The PHY needs to be initialized and powered up for SATA to work. We do that using the Generic PHY framework in PATCH 3. In order to support SATA on the OMAP platforms we need to run

Re: [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support

2014-01-21 Thread Hans de Goede
Hi, On 01/21/2014 12:59 PM, Roger Quadros wrote: On 01/21/2014 10:34 AM, Roger Quadros wrote: On 01/20/2014 06:48 PM, Hans de Goede wrote: Hi, On 01/20/2014 03:41 PM, Roger Quadros wrote: Hi, Some platforms have a PHY hooked up to the SATA controller. The PHY needs to be initialized and

Re: [PATCH v5 1/2] ahci-platform: Bump max number of clocks to 5

2014-09-23 Thread Hans de Goede
Hi, Thanks, this new set looks good to me, and is: Reviewed-by: Hans de Goede Regards, Hans On 09/22/2014 10:09 PM, Kumar Gala wrote: > Qualcomm IPQ806x SoCs with SATA controllers need 5 clocks to be enabled. > > Signed-off-by: Kumar Gala > --- > v4/v5: > * Updated t

Re: ACPI/i915: Cannot configure display brightness on Dell Latitude E6440

2014-09-23 Thread Hans de Goede
Hi, On 09/23/2014 10:06 PM, Pali Rohár wrote: Hello, after big changes in acpi video/i915 code I cannot change display brightness on my Dell Latitude E6440 with kernel 3.17-rc6. With kernel 3.13 everything worked fine. More information about this problem: For configuring brightness on Dell la

Re: ACPI/i915: Cannot configure display brightness on Dell Latitude E6440

2014-09-24 Thread Hans de Goede
Hi, On 09/23/2014 10:44 PM, Pali Rohár wrote: > On Tuesday 23 September 2014 22:31:31 you wrote: >> Hi, >> >> On 09/23/2014 10:06 PM, Pali Rohár wrote: >>> Hello, >>> >>> after big changes in acpi video/i915 code I cannot change >>> display brightness on my Dell Latitude E6440 with kernel >>> 3.17

Re: ACPI/i915: Cannot configure display brightness on Dell Latitude E6440

2014-09-24 Thread Hans de Goede
Hi, On 09/24/2014 11:14 AM, Pali Rohár wrote: > On Wednesday 24 September 2014 10:59:41 Pali Rohár wrote: >> On Wednesday 24 September 2014 10:19:38 Hans de Goede wrote: >>> Hi, >>> >>> On 09/23/2014 10:44 PM, Pali Rohár wrote: >>>> On Tuesda

Re: ACPI/i915: Cannot configure display brightness on Dell Latitude E6440

2014-09-24 Thread Hans de Goede
Hi, On 09/24/2014 02:53 PM, Pali Rohár wrote: > On Wednesday 24 September 2014 14:04:36 Hans de Goede wrote: >> Hi, >> >> On 09/24/2014 11:14 AM, Pali Rohár wrote: >>> On Wednesday 24 September 2014 10:59:41 Pali Rohár wrote: >>>> On Wednesday 24 S

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-11 Thread Hans de Goede
Hi, On 09/10/2014 05:45 PM, Christoph Hellwig wrote: > On Wed, Sep 10, 2014 at 09:21:24AM +0200, Hans de Goede wrote: >> I've applied the patch, this results in the following new dmesg output >> when using uas: >> >> [ 120.602632] initialized host-wide tag map!

Re: [PATCH] ata: ahci_platform: Add ACPI support for AMD Seattle SATA controller

2014-09-12 Thread Hans de Goede
Hi, On 09/11/2014 10:17 PM, Olof Johansson wrote: > On Tue, Sep 9, 2014 at 1:37 PM, wrote: >> From: Suravee Suthikulpanit >> >> This patch adds ACPI support for non-PCI SATA contoller in ahci_platform >> driver. >> It adds ACPI matching table in ahci_platform to support AMD Seattle SATA >> co

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-12 Thread Hans de Goede
Hi, On 09/11/2014 06:13 PM, Christoph Hellwig wrote: > On Thu, Sep 11, 2014 at 12:01:13PM +0200, Hans de Goede wrote: >>> So we're initializing the tag map, but scsi_activate_tcq doesn't pick it >>> up. I can't really come up with a good explanation for it, b

Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq

2014-09-13 Thread Hans de Goede
ubject: scsi: fix regression that accidentally disabled block-based tcq > > The scsi blk-mq support accidentally flipped a conditional, which lead to > never enabling block based tcq when using the legacy request path. > > Fixes: d285203cf647d7c9 scsi: add support for a blk-mq b

Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq

2014-09-14 Thread Hans de Goede
Hi, On 09/13/2014 07:50 PM, Christoph Hellwig wrote: > On Sat, Sep 13, 2014 at 12:28:41PM +0200, Hans de Goede wrote: >> Yes this one does the trick and fixes things. Note the git tree I used for >> testing also had your previous fix to split up the blk_tcq union in 2 >> se

Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq

2014-09-15 Thread Hans de Goede
csi: add support for a blk-mq based I/O path. > Reported-by: Hans de Goede > Signed-off-by: Christoph Hellwig > --- > include/scsi/scsi_tcq.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h > index

Re: [PATCH v4 1/3] ahci-platform: Bump max number of clocks to 5

2014-09-15 Thread Hans de Goede
Hi, On 09/16/2014 04:09 AM, Kumar Gala wrote: > > On Sep 9, 2014, at 8:36 AM, Kumar Gala wrote: > >> Qualcomm IPQ806x SoCs with SATA controllers need 5 clocks to be enabled. >> >> Signed-off-by: Kumar Gala >> --- >> (reposted with Hans on list) >> >> v4: >> * Updated to upstream changes >> >>

Re: [PATCH v5 6/8] ARM: dts: sun4i: Add support for mmc

2014-03-11 Thread Hans de Goede
Hi, Oh, good catch, thanks! Fixed in the sunxi-devel branch in my *personal* git repo. I'll also push this to the official linux-sunxi sunxi-devel branch later today. Regards, Hans On 03/10/2014 10:49 PM, mr.nuke...@gmail.com wrote: > On Tuesday, February 11, 2014 1:34:25 PM UTC-6, David Lanz

Re: [PATCH v6 0/3] ahci: add support for hisilicon sata

2014-04-25 Thread Hans de Goede
append new hflag AHCI_HFLAG_NO_FBS > libahci_platform: add host_flags parameter in > ahci_platform_init_host() > ahci: add support for Hisilicon sata Thanks, looks good: Reviewed-by: Hans de Goede Regards, Hans > > .../devicetree/bindings/ata/ahci-platform.txt |

Re: [RFC PATCH] mba6x_bl: Backlight driver for mid 2013 MacBook Air

2014-04-29 Thread Hans de Goede
Hi, Why is this patch an RFC? If it is ready for upstreaming please drop the RFC prefix when you post the next version. On 04/27/2014 10:56 PM, Patrik Jakobsson wrote: > This driver takes control over the LP8550 backlight driver chip found > in the mid 2013 and newer MacBook Air (6,1 and 6,2). Th

[PATCH 2/3] regulator/axp20x: Call mfd_register_supply_aliases

2014-05-18 Thread Hans de Goede
The mfd-core no longer registers the supply aliases, instead the platform driver probe method must now call mfd_register_supply_aliases(). Signed-off-by: Hans de Goede --- drivers/regulator/axp20x-regulator.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/regulator/axp20x

[PATCH 3/3] arizona-mfd-codecs: Add mfd_register_supply_aliases() calls

2014-05-18 Thread Hans de Goede
The mfd-core no longer registers the supply aliases, instead the platform driver probe method must now call mfd_register_supply_aliases(). Signed-off-by: Hans de Goede --- sound/soc/codecs/wm5102.c | 5 + sound/soc/codecs/wm5110.c | 5 + sound/soc/codecs/wm8997.c | 7 ++- 3 files

[PATCH 0/3] Fix WARN_ON caused by "mfd: Allow mapping regulator supplies to MFD device from children"

2014-05-18 Thread Hans de Goede
Hi all, I hit this WARN_ON: WARNING: CPU: 0 PID: 1 at drivers/base/dd.c:286 driver_probe_device... Which points to this line: WARN_ON(!list_empty(&dev->devres_head)); While testing Carlo Caione's axp20x regulator patches on top of 3.15-rc5. The problem is that mfd_add_device() from driv

[PATCH 1/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases()

2014-05-18 Thread Hans de Goede
from platform_add_device. So stop registering supply aliases from mfd_add_device, and add a mfd_register_supply_aliases helper functions for the cell's plaform driver probe method to use. Signed-off-by: Hans de Goede --- drivers/mfd/mfd-core.c | 37 + include/linux/

Re: [PATCH 1/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases()

2014-05-19 Thread Hans de Goede
a >>> mfd_register_supply_aliases helper functions for the cell's plaform driver >>> probe method to use. >>> >>> Signed-off-by: Hans de Goede >>> --- >>> drivers/mfd/mfd-core.c | 37 + >>> include

Re: [RFC PATCH 1/3] mfd: AXP22x: add support for APX221 PMIC

2014-05-20 Thread Hans de Goede
Hi, On 05/19/2014 07:45 PM, Boris BREZILLON wrote: > Hello Lee, > > On 19/05/2014 19:28, Lee Jones wrote: >>> This patch introduces preliminary support for the X-Powers AXP221 PMIC. >>> The AXP221 is typically used on boards using Allwinner's A31 SoC. >>> >>> At the moment, this driver only expos

Re: [PATCH v7 5/8] ARM: dts: sun7i: Add support for mmc

2014-02-18 Thread Hans de Goede
Hi, On 02/18/2014 03:22 PM, Maxime Ripard wrote: On Mon, Feb 17, 2014 at 11:02:41AM +0100, David Lanzendörfer wrote: Signed-off-by: David Lanzendörfer Signed-off-by: Hans de Goede --- arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |8 +++ arch/arm/boot/dts/sun7i-a20-cubietruck.dts

Re: [PATCH v2] mba6x_bl: Backlight driver for mid 2013 MacBook Air

2014-04-30 Thread Hans de Goede
ting brightness > - Change %Ld to standard C %lld > - Constify the backlight_ops struct > > Signed-off-by: Patrik Jakobsson Thanks for working on this, looks good: Reviewed-by: Hans de Goede Regards, Hans > --- > MAINTAINERS | 6 + > driver

Re: Possible regression: sluggish inputs

2014-05-03 Thread Hans de Goede
Hi, On 05/02/2014 07:03 PM, Tibor Billes wrote: > Hi, > > I've upgraded my 3.13.5 kernel to 3.14.2 and I noticed that sometimes my > mouse is slow to react. > By slow I mean the pointer on the screen doesn't follow its path smoothly, > instead it jumps from one > position to the next at only a

Re: Possible regression: sluggish inputs

2014-05-03 Thread Hans de Goede
Hi, On 05/03/2014 07:38 PM, tbil...@gmx.com wrote: > Hi, > > On Saturday, 03 May 2014 at 10:00:38, Hans de Goede wrote: > >> On 05/02/2014 07:03 PM, Tibor Billes wrote: >> >>> Hi, >>> >>> I've upgraded my 3.13.5 kernel to 3.14.2 and I

Re: [PATCH v3 3/8] phy: sunxi: Rework phy initialization

2014-05-12 Thread Hans de Goede
> - pmu = devm_ioremap_resource(dev, res); > - if (IS_ERR(pmu)) > - return PTR_ERR(pmu); > + phy->pmu = devm_ioremap_resource(dev, res); > + if (IS_ERR(phy->pmu)) > +

Re: [PATCH v6 3/3] ARM: sunxi: Add IR controller support in DT on A20

2014-05-14 Thread Hans de Goede
Hi, On 05/13/2014 08:39 PM, Alexander Bersenev wrote: > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi > b/arch/arm/boot/dts/sun7i-a20.dtsi > index 0ae2b77..40ded74 100644 > --- a/arch/arm/boot/dts/sun7i-a20.dtsi > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi > @@ -724,6 +724,19 @@ >

Re: [PATCH v5 0/3] ARM: sunxi: Add support for consumer infrared devices

2014-05-08 Thread Hans de Goede
Hi, On 04/30/2014 05:16 PM, Alexander Bersenev wrote: > This patch introduces Consumer IR(CIR) support for sunxi boards. > > This is based on Alexsey Shestacov's work based on the original driver > supplied by Allwinner. > > Signed-off-by: Alexander Bersenev > Signed-off-by: Alexsey Shestacov

Re: [PATCH v2 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit

2014-05-09 Thread Hans de Goede
Hi, On 05/09/2014 09:12 AM, Lee Jones wrote: +static struct platform_driver sun6i_prcm_driver = { + .driver = { + .name = "sun6i-prcm", + .owner = THIS_MODULE, + .of_match_table = sun6i_prcm_dt_ids, + }, + .probe = sun6i_prcm_probe,

Re: [PATCH v2 2/2] i2c: sunxi: add P2WI (Push/Pull 2 Wire Interface) controller support

2014-05-09 Thread Hans de Goede
Hi, On 05/09/2014 04:50 PM, Boris BREZILLON wrote: > > On 09/05/2014 16:31, Maxime Ripard wrote: >> Hi Boris, >> >> On Wed, May 07, 2014 at 07:58:35PM +0200, Boris BREZILLON wrote: >> > [...] >> + >> +r = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> +p2wi->regs = devm_ioremap_resour

Re: [linux-sunxi] [PATCH v2 3/7] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support

2014-05-12 Thread Hans de Goede
e >> having >> a single clock for all the phys. >> >> Signed-off-by: Maxime Ripard >> Reviewed-by: Hans de Goede >> --- >> drivers/phy/phy-sun4i-usb.c | 35 ++- >> 1 file changed, 26 insertions(+), 9 deletions(-) >

Re: [linux-sunxi] [PATCH v2 3/7] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support

2014-05-12 Thread Hans de Goede
Hi, On 05/12/2014 02:24 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 12 May 2014 05:29 PM, Hans de Goede wrote: >> Hi, >> >> On 05/12/2014 11:14 AM, Chen-Yu Tsai wrote: >>> Hi, >>> >>> On Sat, May 10, 2014 at 8:56 PM, Maxime Rip

Re: [PATCH 2/2] ahci: add support for Hisilicon sata

2014-04-09 Thread Hans de Goede
Hi, On 04/09/2014 12:30 PM, Kefeng Wang wrote: > From: Kefeng Wang > > The hip04 SoC of hisilicon has an AHCI compliant SATA controller, > and it is compliant with the ahci 1.3 and sata 3.0 specification. > > There is a wrong bit in HOST_CAP of hip04 sata controller, which > enable unsupported

Re: [PATCH] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

2014-04-15 Thread Hans de Goede
Hi, On 04/15/2014 09:42 PM, Julius Werner wrote: +hdegoede I tried to apply this patch on top of 3.15-rc1, but it fails because of the streams support added to xhci_find_new_dequeue_state() After some manual editing the interesting parts of xhci_find_new_dequeue_state() looks like this: @@ -

Re: [linux-sunxi] Re: [PATCH 7/7] ARM: sun7i: cubietruck: enable bluetooth module

2014-04-16 Thread Hans de Goede
Hi, On 04/16/2014 11:44 AM, Maxime Ripard wrote: > Hi, > > Please try to keep me in CC, even though the ML doesn't make it easy.. > > On Wed, Apr 16, 2014 at 12:06:59AM +0800, Chen-Yu Tsai wrote: @@ -139,4 +152,16 @@ reg_usb2_vbus: usb2-vbus { status = "okay";

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-19 Thread Hans de Goede
Hi, Overall I like the idea, I've some comments on the implementation inline. On 06/19/2014 03:04 PM, Ulf Hansson wrote: > The pwrseq subsystem handles complex power sequences, typically useful > for subsystems that makes use of discoverable buses, like for example > MMC and I2C. I2C is not disc

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-19 Thread Hans de Goede
Hi, On 06/19/2014 04:03 PM, Hans de Goede wrote: > Hi, > > Also I'm not sold on how you're making this a devm only thing, and > are using devres_alloc to not only allocate memory for resource tracking, > but also the actual backing struct, that is not how devres_alloc

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-20 Thread Hans de Goede
Hi, On 06/19/2014 07:18 PM, Olof Johansson wrote: > Hi, > > > > On Thu, Jun 19, 2014 at 6:04 AM, Ulf Hansson wrote: >> The pwrseq subsystem handles complex power sequences, typically useful >> for subsystems that makes use of discoverable buses, like for example >> MMC and I2C. >> >> The pwrse

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-06-20 Thread Hans de Goede
Hi, On 06/20/2014 10:02 AM, Olof Johansson wrote: > On Fri, Jun 20, 2014 at 12:27 AM, Hans de Goede wrote: >> Hi, >> >> On 06/19/2014 07:18 PM, Olof Johansson wrote: >>> Hi, >>> >>> >>> >>> On Thu, Jun 19, 2014 at 6:04 AM, U

Re: [PATCH] Input: wacom_serial4 - prepare for wacom USB moving to HID

2014-07-25 Thread Hans de Goede
Hi, On 07/24/2014 10:31 PM, Dmitry Torokhov wrote: > wacom_wac.h will be moving to drivers/hid. Since we only need 3 definitions > from it let's simply copy them over. > > Signed-off-by: Dmitry Torokhov Ack, but you will want to drop the #include of wacom_wac.h yoo. Regards, Hans > --- > dr

Re: [PATCH v11 4/8] ata: libahci: allow to use multiple PHYs

2014-07-28 Thread Hans de Goede
} > > - default: > - dev_err(dev, "couldn't get sata-phy\n"); > - goto err_out; > + mask_port_map |= BIT(port); > + > + hpriv->phys[port] =

Re: [PATCH v12 4/8] ata: libahci: allow to use multiple PHYs

2014-07-29 Thread Hans de Goede
gt; Signed-off-by: Antoine Ténart > Acked-by: Hans de Goede > --- > > Updated with the latest comment from Hans. Looks 100% good now. Regards, Hans > > drivers/ata/ahci.h | 7 +- > drivers/ata/libahci_platform.c | 189 > ++

Re: [PATCH v2 6/7] ata: Add support for the Tegra124 SATA controller

2014-07-13 Thread Hans de Goede
Hi Miko, On 07/14/2014 08:21 AM, Mikko Perttunen wrote: > Hi Hans, have you been able to take a look at this? Not yet, it is on my todo list I hope to get around to it today or tomorrow. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

Re: [BISECTED 3.16-rc REGREGRESSION] backlight control stopped working

2014-07-14 Thread Hans de Goede
Hi, On 07/14/2014 02:59 PM, Bjørn Mork wrote: > Yes, I actually bisected this just to get > > 886129a8eebebec260165741fe31421482371006 is the first bad commit > commit 886129a8eebebec260165741fe31421482371006 > Author: Hans de Goede > Date: Tue May 6 14:46:23 2014 +0200 >

Re: [PATCH v2 6/7] ata: Add support for the Tegra124 SATA controller

2014-07-14 Thread Hans de Goede
Hi, On 07/08/2014 03:22 PM, Tejun Heo wrote: > (cc'ing Hans) > > Hans, can you please review this patch? Done. Mikko, it looks like you are doing a lot of stuff the DIY way. I can see there are good reasons for that though. Still it would be nice if you could use a little bit more of the helpe

Re: [BISECTED 3.16-rc REGREGRESSION] backlight control stopped working

2014-07-15 Thread Hans de Goede
Hi, On 07/14/2014 06:24 PM, Linus Torvalds wrote: > On Mon, Jul 14, 2014 at 6:14 AM, Hans de Goede wrote: >> >> This *not* a regression, it is an intended behavior change [..] > > That counts as a regression. > > If things used to work, and they don't wo

Re: [PATCH v2 6/7] ata: Add support for the Tegra124 SATA controller

2014-07-15 Thread Hans de Goede
st do, but I have a strong preference for you taking a shot at doing this. So can you please give this a try, and if it turns out to become ugly, just say so (with some explanation), and then you can keep things as is. Does that work for you? Regards, Hans > > Thanks, > Mikko > >

Re: [PATCH resend v2 0/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases()

2014-07-01 Thread Hans de Goede
Hi, On 07/01/2014 11:05 AM, Lee Jones wrote: >> I already send this series before (in time for 3.16) and AFAIK we agreed >> on going with this series instead of the incomplete fix for the related oops >> which now has been merged as commit d137be00ee017bc40e6027cb66d667a2e0b450fd >> >> I still bel

Re: [PATCH resend v2 1/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases()

2014-07-01 Thread Hans de Goede
Hi, On 07/01/2014 11:22 AM, Lee Jones wrote: > On Mon, 30 Jun 2014, Hans de Goede wrote: > >> We cannot register supply alias in mfd_add_device before calling >> platform_add_device because platform-dev's name must be set before >> registering >

[PATCH resend v2 1/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases()

2014-06-30 Thread Hans de Goede
elper functions for the cell's plaform driver probe method to use. Signed-off-by: Hans de Goede --- drivers/mfd/mfd-core.c | 37 + include/linux/mfd/core.h | 6 +- 2 files changed, 26 insertions(+), 17 deletions(-) diff --git a/drivers/mfd/mf

[PATCH resend v2 2/3] regulator/axp20x: Call mfd_register_supply_aliases

2014-06-30 Thread Hans de Goede
The mfd-core no longer registers the supply aliases, instead the platform driver probe method must now call mfd_register_supply_aliases(). Signed-off-by: Hans de Goede --- drivers/regulator/axp20x-regulator.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/regulator/axp20x

[PATCH resend v2 3/3] arizona-mfd-codecs: Add mfd_register_supply_aliases() calls

2014-06-30 Thread Hans de Goede
The mfd-core no longer registers the supply aliases, instead the platform driver probe method must now call mfd_register_supply_aliases(). Signed-off-by: Hans de Goede --- sound/soc/codecs/wm5102.c | 5 + sound/soc/codecs/wm5110.c | 5 + sound/soc/codecs/wm8997.c | 7 ++- 3 files

[PATCH resend v2 0/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases()

2014-06-30 Thread Hans de Goede
Hi all, I already send this series before (in time for 3.16) and AFAIK we agreed on going with this series instead of the incomplete fix for the related oops which now has been merged as commit d137be00ee017bc40e6027cb66d667a2e0b450fd I still believe that this series is the more correct fix, as p

Re: [PATCH v9 3/7] ata: libahci: allow to use multiple PHYs

2014-07-09 Thread Hans de Goede
Hi, On 07/08/2014 03:40 PM, Tejun Heo wrote: > (Cc'ing Hans.) Thanks for adding me to the loop. I've been reading the entire thread sofar, and here are my 2 cents: 1) I think overall this is a good idea, and I like the suggested dt representation 2) I agree with Tejun that it would be better t

Re: [PATCH v9 3/7] ata: libahci: allow to use multiple PHYs

2014-07-09 Thread Hans de Goede
Hi, On 07/09/2014 03:59 PM, Tejun Heo wrote: > Hello, > > On Wed, Jul 09, 2014 at 10:23:31AM +0200, Antoine Ténart wrote: >>> It is confusing. If you wanna pass around available ports in hpriv, >>> please add a separate field and replace the arguments to >>> save_initial_config(). >> >> I don't

Re: [BISECTED 3.16-rc REGREGRESSION] backlight control stopped working

2014-07-15 Thread Hans de Goede
is not mainstream. I've butted head with those kind of developers several times and I really don't want to become like one of them. So you two are right, and I apologize for my behavior. So now lets go and fix this in way so that we can both have our cake and eat it :) On 07/15/2014 0

Re: [PATCH v3 7/8] ata: Add support for the Tegra124 SATA controller

2014-07-16 Thread Hans de Goede
Hi, Thanks for making the changes to use more libahci_platform functionality. Overall this looks good, I've a few small remarks inline. On 07/16/2014 10:54 AM, Mikko Perttunen wrote: > This adds support for the integrated AHCI-compliant Serial ATA > controller present on the NVIDIA Tegra124 syste

Re: [PATCH v4 1/8] of: Add NVIDIA Tegra SATA controller binding

2014-07-16 Thread Hans de Goede
ta: Add support for the Tegra124 SATA controller" both look good to me. So these 2 + v3 for the rest of the series are: Acked-by: Hans de Goede Regards, Hans > > .../devicetree/bindings/ata/tegra-sata.txt | 31 > ++ > 1 file changed, 31 insertion

Re: [PATCH v4 1/8] of: Add NVIDIA Tegra SATA controller binding

2014-07-16 Thread Hans de Goede
Hi, On 07/16/2014 03:13 PM, Thierry Reding wrote: > On Wed, Jul 16, 2014 at 01:49:57PM +0200, Hans de Goede wrote: >> Hi, >> >> On 07/16/2014 01:40 PM, Mikko Perttunen wrote: >>> This patch adds device tree binding documentation for the SATA >>>

Re: [PATCH v4 1/8] of: Add NVIDIA Tegra SATA controller binding

2014-07-16 Thread Hans de Goede
Hi, On 07/16/2014 09:51 PM, Thierry Reding wrote: > On Wed, Jul 16, 2014 at 04:47:38PM +0200, Hans de Goede wrote: >> Hi, >> >> On 07/16/2014 03:13 PM, Thierry Reding wrote: >>> On Wed, Jul 16, 2014 at 01:49:57PM +0200, Hans de Goede wrote: >>>> H

Re: [PATCH v4 1/8] of: Add NVIDIA Tegra SATA controller binding

2014-07-17 Thread Hans de Goede
Hi, On 07/17/2014 09:39 AM, Thierry Reding wrote: > On Thu, Jul 17, 2014 at 08:51:15AM +0200, Hans de Goede wrote: >> Hi, >> >> On 07/16/2014 09:51 PM, Thierry Reding wrote: >>> On Wed, Jul 16, 2014 at 04:47:38PM +0200, Hans de Goede wrote: >>>> Hi,

Re: [PATCH] usb: core: allow zero packet flag for interrupt urbs

2014-07-17 Thread Hans de Goede
erwise, the kernel throws error of BOGUS transfer flags. > > Signed-off-by: Amit Virdi Seems sensible to me: Acked-by: Hans de Goede Regards, Hans > --- > drivers/usb/core/urb.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/core/urb.c b

Re: [PATCH v4 1/8] of: Add NVIDIA Tegra SATA controller binding

2014-07-17 Thread Hans de Goede
Hi, On 07/17/2014 12:52 PM, Thierry Reding wrote: > On Thu, Jul 17, 2014 at 12:23:47PM +0200, Hans de Goede wrote: >> The libahci_platform.c code / ahci_platform.c code is also used for >> devices going way back who may not yet be using the new clk framework, >> so where w

Re: [PATCH v4 1/8] of: Add NVIDIA Tegra SATA controller binding

2014-07-17 Thread Hans de Goede
Hi, On 07/17/2014 01:42 PM, Hans de Goede wrote: > Hi, > > On 07/17/2014 12:52 PM, Thierry Reding wrote: >> On Thu, Jul 17, 2014 at 12:23:47PM +0200, Hans de Goede wrote: > > > >>> The libahci_platform.c code / ahci_platform.c code is also used for >>&

Re: [PATCH V2 2/2] ahci: add support for Hisilicon sata

2014-04-17 Thread Hans de Goede
Hi, On 04/16/2014 10:49 PM, Tejun Heo wrote: > Hello, > > On Thu, Apr 10, 2014 at 01:24:28PM +0800, Kefeng Wang wrote: >> From: Kefeng Wang >> >> The hip04 SoC of hisilicon has an AHCI compliant SATA controller, >> and it is compliant with the ahci 1.3 and sata 3.0 specification. >> >> There is

Re: [PATCH v3 2/2] ahci: add support for Hisilicon sata

2014-04-21 Thread Hans de Goede
Hi Kefeng, On 04/21/2014 06:13 AM, kefeng.wang wrote: > Hi Hans, > > A hflags argument is useless in ahci_platform_init_host for another driver's > caller, > use the pointer of ata_port_info in ahci_probe, is this OK? Hmm, this can theoretically break when multiple platform ahci-s are present i

Re: [PATCH] ahci: disable ncq feature for hisilicon sata

2014-06-10 Thread Hans de Goede
Hi Kefeng, On 06/10/2014 12:07 PM, kefeng.wang wrote: > Hi Tejun, > > I have a question, the hip04 and hix5hd2 soc use the old version of IP, but > they > also have a new version of IP which support FBS and NCQ, and now the new one > is > used by a new soc. How can I distinguish them, use "hisi

Re: [Intel-gfx] video: X sets brightness to zero after resume

2014-06-13 Thread Hans de Goede
Hi, On 06/13/2014 03:28 AM, Aaron Lu wrote: > On 06/12/2014 08:42 PM, Kalle Valo wrote: >> Hi Aaron, >> >> after your commit 0e9f81d3b7c ("ACPI / video: Add systems that should >> favour native backlight interface") I have had an regression that every >> time after resume the display brightness ha

Re: [PATCH 1/2] ahci: Check and set 64-bit DMA mask for platform AHCI driver

2014-06-13 Thread Hans de Goede
he dma_mask and coherent_dma_mask accordingly. > > Signed-off-by: Suravee Suthikulpanit > Reviewed-by: Bartlomiej Zolnierkiewicz > Reviewed-by: Hans de Goede I did not review this patch, just because you CC-ed me does not mean I've reviewed it. Please don't add my Reviewed-by unles

Re: [PATCH] phy: sun4i: depend on RESET_CONTROLLER

2014-05-24 Thread Hans de Goede
Hi, On 05/23/2014 08:51 PM, Maxime Ripard wrote: > The driver depend on the reset framework in a mandatory way. Make sure > reset_control_get is defined by adding this dependency in Kconfig > > Signed-off-by: Maxime Ripard > Reported-by: Arnd Bergmann Good catch. Acked-by

Re: [linux-sunxi] [PATCH 7/7] ARM: sunxi: dt: add APP4-EVB1 board support

2014-05-06 Thread Hans de Goede
Hi, On 05/07/2014 07:10 AM, Koen Kooi wrote: > > Op 7 mei 2014, om 05:50 heeft Maxime Ripard > het volgende geschreven: > >> From: Boris BREZILLON >> >> The APP4 EVB1 development boards embeds an A31, together with some NAND, one >> SD >> card slot, and one SDIO + UART WiFi and Bluetooth chi

Re: [PATCH 0/7] Add Allwinner A31 USB support

2014-05-07 Thread Hans de Goede
change, like the fact > that the PHYs now have one clock per phy, while it used to be only one > for all the PHYs. > > Thanks, > Maxime Thanks for working on this. Looks good, the entire series is: Reviewed-by: Hans de Goede Regards, Hans > > Boris BREZILLON (2):

Re: [PATCH v3 00/20] USB support for Armada 38x and Armada 375

2014-05-07 Thread Hans de Goede
Hi Gregory, Gregory CLEMENT free-electrons.com> writes: > This patch set adds the USB support for the Armada 38x Armada > 375. These SoCs use an xHCI but still need specific initialization, > mainly to setup the windows memory on the mbus. They also use the same > controller that the other mvebu

Re: [PATCH v3 00/20] USB support for Armada 38x and Armada 375

2014-05-07 Thread Hans de Goede
Hi, On 05/07/2014 11:21 AM, Sebastian Hesselbarth wrote: > [Adding back the original Cc-List] > > On 05/07/2014 10:33 AM, Hans de Goede wrote: >> Hi Gregory, >> >> Gregory CLEMENT free-electrons.com> writes: >> >>> This patch set adds the USB sup

Re: [PATCH 4/7] usb: ehci-platform: add optional reset controller retrieval

2014-05-08 Thread Hans de Goede
Hi, On 05/08/2014 12:00 AM, Maxime Ripard wrote: > On Wed, May 07, 2014 at 10:25:55AM -0400, Alan Stern wrote: >> On Tue, 6 May 2014, Maxime Ripard wrote: >> >>> From: Boris BREZILLON >>> >>> On the Allwinner's A31 SoC the reset line connected to the EHCI IP has to >>> be deasserted for the EHCI

Re: [PATCH 3/3] phy: sun4i-usb: Use PTR_ERR_OR_ZERO

2014-05-30 Thread Hans de Goede
Hi, On 05/29/2014 08:30 AM, Sachin Kamat wrote: > PTR_ERR_OR_ZERO simplifies the code. > > Signed-off-by: Sachin Kamat > Cc: Hans de Goede > Cc: Maxime Ripard > --- > drivers/phy/phy-sun4i-usb.c |5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >

Re: [PATCH 1/2] ahci: Check and set 64-bit DMA mask for platform AHCI driver

2014-06-13 Thread Hans de Goede
he dma_mask and coherent_dma_mask accordingly. > > Signed-off-by: Suravee Suthikulpanit > Reviewed-by: Bartlomiej Zolnierkiewicz > Reviewed-by: Hans de Goede I see no adverse effects from this on sunxi, please drop the Reviewed-by: Hans tag and replace it with: Tested-by: Han

Re: [PATCH] V4L: uvcvideo: Add support for relative pan/tilt controls

2014-06-16 Thread Hans de Goede
Hi, On 06/17/2014 02:38 AM, Vincent Palatin wrote: > Map V4L2_CID_TILT_RELATIVE and V4L2_CID_PAN_RELATIVE to the standard UVC > CT_PANTILT_ABSOLUTE_CONTROL terminal control request. s/ABSOLUTE/RELATIVE in the commit message here. Otherwise looks good to me. Regards, Hans > > Tested by plugg

Re: [linux-sunxi] Re: [PATCH v4 4/7] regulator: axp20x: reset probe data before each probe

2014-06-18 Thread Hans de Goede
Hi, On 06/18/2014 09:11 AM, Boris BREZILLON wrote: > > On 17/06/2014 22:44, Maxime Ripard wrote: >> On Tue, Jun 17, 2014 at 09:38:40AM +0200, Boris BREZILLON wrote: >>> The init_data and of_node fields of the axp2xx_matches tables are filled >>> at each device probe by the axp20x_regulator_parse_

Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-05 Thread Hans de Goede
Hi David, On 02/05/2014 02:01 PM, David Lanzendörfer wrote: Hi Maxime I have four comments here: - Read Documentation/SubmittingPatches, especially Section 5 and 12 (hints, you forgot the clock maintainers for your clock patches and you didn't put any signed-off-by tags) Oops. I a

Re: [linux-sunxi] Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware

2013-12-09 Thread Hans de Goede
Hi Chen-Yu, It seems this patch is not enough, gmac won't work for me with this patchset (*), unless I boot with an uboot which also has the gmac patches. Regards, Hans *) see my sunxi-test tree where I've dropped your old version and added this version. -- To unsubscribe from this list: send

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Hans de Goede
Hi, On 12/09/2013 12:10 PM, srinivas kandagatla wrote: Hi Chen, Good to know that Allwinner uses gmac. On ST SoC, we have very similar requirements, before we merge any of these changes I think we need to come up with common way to solve both Allwinner and ST SOCs use cases. I have already pos

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Hans de Goede
Hi, On 12/09/2013 06:56 PM, Chen-Yu Tsai wrote: Hi, On Tue, Dec 10, 2013 at 12:16 AM, Hans de Goede wrote: Hi, On 12/09/2013 12:10 PM, srinivas kandagatla wrote: Hi Chen, Good to know that Allwinner uses gmac. On ST SoC, we have very similar requirements, before we merge any of these

Re: [PATCH] [media] radio-shark: Mark shark_resume_leds() inline to kill compiler warning

2013-11-17 Thread Hans de Goede
Hi, On 10/28/2013 01:16 PM, Geert Uytterhoeven wrote: If SHARK_USE_LEDS=1, but CONFIG_PM=n: drivers/media/radio/radio-shark.c:275: warning: ‘shark_resume_leds’ defined but not used Instead of making the #ifdef logic even more complicated (there are already two definitions of shark_resume_leds

Re: [PATCH] Adding basic support for the INet-97F_Rev_02 board

2014-02-07 Thread Hans de Goede
Hi David, Thanks for the patch, I've added it to my sunxi-devel tree. It seems this has been missed by Maxime, because you did not send it directly to him. Can you please rebase it one 3.14-rc1, and then send it directly to Maxime Ripard, with the relevant mailinglists in the CC? Thanks & Regar

Re: [PATCH 2/3] ARM: sunxi: Add an ahci-platform compatible AHCI driver for the Allwinner SUNXi series of SoCs

2013-12-06 Thread Hans de Goede
Hi, On 12/06/2013 10:12 AM, Oliver Schinagl wrote: On 06-12-13 10:01, Thomas Petazzoni wrote: Dear Tejun Heo, On Wed, 4 Dec 2013 08:23:12 -0500, Tejun Heo wrote: But again, point me (for dummies ;) in the right direction and I'll work on it with some help. Richard and Shawn recently worked

Re: Kernel 3.16.0 USB crash

2014-08-22 Thread Hans de Goede
Hi, On 08/15/2014 09:44 AM, Claudio Bizzarri wrote: >> On Thu, Aug 14, 2014 at 11:46:33AM +0200, Hans de Goede wrote: >>> Hi, > ... >>> >>> Can you collect "lsusb -v" output for the drive in question when connected >>> through an usb-3 port

[3.17 REGRESSION FIX] Revert "ideapad-laptop: Disable touchpad interface on Yoga models"

2014-08-25 Thread Hans de Goede
t work, simply revert the patch. This reverts commit f79a901331a823ae370584b15cd39dd110b95a0a. Reported-by: GOESSEL Guillaume Signed-off-by: Hans de Goede --- drivers/platform/x86/ideapad-laptop.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/drivers/platfor

Re: [PATCH] Input: ALPS - suppress message about 'Unknown touchpad'

2014-08-26 Thread Hans de Goede
> that it does not litter users logs and confuse them. > > Reported-by: Paul Menzel > Signed-off-by: Dmitry Torokhov I noticed this too, and I agree that it is a confusing message: Acked-by: Hans de Goede Regards, Hans > --- > drivers/input/mouse/alps.c | 4 ++-- > 1 fi

Re: [PATCH] [media] sn9c20x: refactor initialization functions and fix lint warnings/errors

2014-09-08 Thread Hans de Goede
Hi, On 09/08/2014 04:25 AM, Morgan Phillips wrote: > Centralize redundant print messages and references to sensor names via macros. > > Change msleep time from 10ms to 20ms in order to address checkpatch.pl > warning: > "msleep < 20ms can sleep for up to 20ms." > > Refactor redundant sensor ini

Re: [PATCH] Input: synaptics - add support for ForcePads

2014-09-09 Thread Hans de Goede
Hi, On 09/08/2014 06:55 PM, Dmitry Torokhov wrote: > ForcePads are found on HP EliteBook 1040 laptops. They lack any kind of > physical buttons, instead they generate primary button click when user > presses somewhat hard on the surface of the touchpad. Unfortunately they > also report primary but

Re: [PATCH v4 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver

2014-09-09 Thread Hans de Goede
Hi, On 09/08/2014 06:39 PM, Kumar Gala wrote: > Add support for the Qualcomm AHCI SATA controller that exists on several > SoC and specifically the IPQ806x family of chips. The IPQ806x SATA support > requires the associated IPQ806x SATA PHY Driver to be enabled as well. If I'm reading this drive

[REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-09 Thread Hans de Goede
Hi All, While working on making error handling in the uas driver more robust, I noticed that all the commands being send to a sata ssd hooked up over uas were untagged, where I would expect tcq to be used, as that is the big advantage of uas over usb-storage / bot. Taking the uas.c file from 3.17

Re: [PATCH] Input: synaptics - add support for ForcePads

2014-09-09 Thread Hans de Goede
Hi, On 09/09/2014 07:06 PM, Dmitry Torokhov wrote: On Tue, Sep 09, 2014 at 09:44:17AM +0200, Hans de Goede wrote: Hi, On 09/08/2014 06:55 PM, Dmitry Torokhov wrote: ForcePads are found on HP EliteBook 1040 laptops. They lack any kind of physical buttons, instead they generate primary button

Re: [PATCH] Input: synaptics - add support for ForcePads

2014-09-09 Thread Hans de Goede
Hi, On 09/10/2014 12:57 AM, Dmitry Torokhov wrote: > On Tue, Sep 09, 2014 at 03:07:21PM -0700, Andrew Duggan wrote: >> On 09/09/2014 10:06 AM, Dmitry Torokhov wrote: >>> On Tue, Sep 09, 2014 at 09:44:17AM +0200, Hans de Goede wrote: >>>> Hi, >>>> >>

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-10 Thread Hans de Goede
Hi, On 09/09/2014 05:27 PM, Christoph Hellwig wrote: > On Tue, Sep 09, 2014 at 11:15:24AM +0200, Hans de Goede wrote: >> Taking the uas.c file from 3.17, and building it for 3.16 restores >> the use of tcq (debugged by adding a printk blk_rq_tagged + request->tag). >> &

Re: [PATCH] ata: ahci_platform: Add ACPI support for AMD Seattle SATA controller

2014-09-10 Thread Hans de Goede
: Suravee Suthikulpanit Looks good to me, one small nitpick inline. Acked-by: Hans de Goede > --- > drivers/ata/Kconfig | 2 +- > drivers/ata/ahci_platform.c | 13 + > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/ata/Kconfig

Re: [uas/3.16.1] panic in uas_data_cmplt()

2014-09-01 Thread Hans de Goede
Hi, On 09/02/2014 06:18 AM, Chunwei Chen wrote: > Dear all: > > The kernel version is 3.16.1-1-ARCH > > Today I keep getting this panic when booting up. > http://i.imgur.com/0Rx93Kr.jpg > > It might be that the UAS device was in some strange state, > because that after I unplugged and power-cyc

<    7   8   9   10   11   12   13   14   15   16   >