[PATCH v4 05/13] extcon: arizona: Always use pm_runtime_get_sync() when we need the device to be awake

2021-01-23 Thread Hans de Goede
(). Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v3: - This is a new patch in v3 of this patch-set --- drivers/extcon/extcon-arizona.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c

[PATCH v4 08/13] ASoC: arizona-jack: Use arizona->dev for runtime-pm

2021-01-23 Thread Hans de Goede
ndy Shevchenko Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 42 ++--- sound/soc/codecs/arizona.h | 1 - 2 files changed, 18 insertions(+), 25 deletions(-) diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c index 5b40316d0

[PATCH v4 09/13] ASoC: arizona-jack: convert into a helper library for codec drivers

2021-01-23 Thread Hans de Goede
-drivers for codecs which are converted to use the new helper functions from arizona-jack.c are modified to create a snd_soc_jack through snd_soc_card_jack_new() and register this jack with the codec through snd_soc_component_set_jack(). Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede ---

[PATCH v4 06/13] ASoC/extcon: arizona: Move arizona jack code to sound/soc/codecs/arizona-jack.c

2021-01-23 Thread Hans de Goede
cs/arizona-jack.c . This is a preparation patch for converting the arizona extcon-driver into a helper library for letting the arizona codec-drivers directly report jack state through the standard sound/soc/soc-jack.c functions. Signed-off-by: Hans de Goede --- Changes in v4: - Add sound/so

[PATCH v4 07/13] ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv

2021-01-23 Thread Hans de Goede
. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 97 ++--- sound/soc/codecs/arizona.h | 36 2 files changed, 65 insertions(+), 68 deletions(-) diff --git a/sound/soc/codecs

[PATCH v4 10/13] ASoC: arizona-jack: Use snd_soc_jack to report jack events

2021-01-23 Thread Hans de Goede
d-by: Andy Shevchenko Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 149 +--- sound/soc/codecs/arizona.h | 7 +- 2 files changed, 47 insertions(+), 109 deletions(-) diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-ja

[PATCH v4 12/13] ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use the new jack library

2021-01-23 Thread Hans de Goede
ned-off-by: Hans de Goede --- sound/soc/codecs/wm5102.c | 12 +++- sound/soc/codecs/wm5110.c | 12 +++- sound/soc/codecs/wm8997.c | 14 -- sound/soc/codecs/wm8998.c | 9 + 4 files changed, 43 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm5102.c b

[PATCH v4 13/13] ASoC: Intel: bytcr_wm5102: Add jack detect support

2021-01-23 Thread Hans de Goede
Add jack detect support by creating a jack and calling snd_soc_component_set_jack to register the created jack with the codec. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- sound/soc/intel/boards/bytcr_wm5102.c | 28 ++- 1 file changed, 27 insertions

[PATCH v4 11/13] ASoC: arizona-jack: Cleanup logging

2021-01-23 Thread Hans de Goede
Cleanup the use of dev_foo functions used for logging: 1. Many of these are unnecessarily split over multiple lines 2. Use dev_err_probe() in cases where we might get a -EPROBE_DEFER return value Suggested-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v4: - While at it

Re: [PATCH v4 11/13] ASoC: arizona-jack: Cleanup logging

2021-01-24 Thread Hans de Goede
Hi, On 1/24/21 8:53 PM, Andy Shevchenko wrote: > On Sat, Jan 23, 2021 at 2:17 PM Hans de Goede wrote: >> >> Cleanup the use of dev_foo functions used for logging: >> >> 1. Many of these are unnecessarily split over multiple lines >> 2. Use dev_err_prob

Re: 5.11 new lockdep warning related to led-class code (also may involve ata / piix controller)

2021-01-28 Thread Hans de Goede
Hi, On 1/27/21 11:01 PM, Pavel Machek wrote: > Hi! > > Booting a 5.11-rc2 kernel with lockdep enabled inside a virtualbox vm > (which still > emulates good old piix ATA controllers) I get the below lockdep splat > early on during boot: > > This seems to be led-class rela

Re: [PATCH] thinkpad_acpi: fix: use scnprintf instead of snprintf.

2021-01-06 Thread Hans de Goede
Hi, On 1/6/21 10:01 AM, Joe Perches wrote: > On Wed, 2021-01-06 at 14:36 +0800, YANG LI wrote: >> The snprintf() function returns the number of characters which would >> have been printed if there were enough space, but the scnprintf() >> returns the number of characters which were actually printe

Re: [PATCH 0/2] IdeaPad platform profile support

2021-01-06 Thread Hans de Goede
Hi, On 1/5/21 6:18 PM, Rafael J. Wysocki wrote: > On Mon, Jan 4, 2021 at 9:58 PM Hans de Goede wrote: >> Patch 1/2 does use a slightly different approach then I suggest above, >> thinking more about this it would be cleaner IMHO to just pass the >> cur_profile pointer to

Re: (hid-logitech) Support for non-DJ receivers

2021-01-06 Thread Hans de Goede
Hi Filipe, On 1/6/21 8:07 PM, Filipe Laíns wrote: > Hey, > > Some of the new Logitech receivers do not have the DJ interface, this creates > an > issue userspace applications like libratbag, as seen in [1], because we can't > identify the device based on the hidraw PID. > > There are two soluti

Re: [PATCH v3 0/9] Add support for Microsoft Surface System Aggregator Module

2021-01-06 Thread Hans de Goede
Hi, On 12/21/20 7:39 PM, Maximilian Luz wrote: > Hello, > > Here is version three of the Surface System Aggregator Module (SAM/SSAM) > driver series, adding initial support for the embedded controller on 5th > and later generation Microsoft Surface devices. Initial support includes > the ACPI int

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-06 Thread Hans de Goede
Hi Perry, On 12/28/20 2:28 PM, Perry Yuan wrote: > From: Perry Yuan > > add support for dell privacy driver for the dell units equipped > hardware privacy design, which protect users privacy > of audio and camera from hardware level. once the audio or camera > privacy mode enabled, any applicati

Re: [PATCH v5 2/4] e1000e: bump up timeout to wait when ME un-configures ULP mode

2020-12-15 Thread Hans de Goede
ake more than 1 second > but less than 2.5 seconds and emit a warning on resume for those > scenarios. > > Suggested-by: Aaron Ma > Suggested-by: Sasha Netfin > Suggested-by: Hans de Goede > CC: Mark Pearson > Fixes: f15bb6dde738cc8fa0 ("e1000e: Add support for S0ix&

Re: [PATCH v2 2/9] platform/surface: aggregator: Add control packet allocation caching

2020-12-15 Thread Hans de Goede
nses) that it may > warrant caching their allocations to reduce possible memory > fragmentation. > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/surface/aggregator/core.c| 27 ++-

Re: [PATCH v2 3/9] platform/surface: aggregator: Add event item allocation caching

2020-12-15 Thread Hans de Goede
ost other event types. In case of a larger event payload, event item > allocation will fall back to kzalloc(). > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > .../platform/surface/aggregator/controller.c |

Re: [PATCH v2 4/9] platform/surface: aggregator: Add trace points

2020-12-15 Thread Hans de Goede
th the error injection capabilities introduced in the > subsequent commit. > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): > - add copyright line > - change SPDX id

Re: [PATCH v2 5/9] platform/surface: aggregator: Add error injection capabilities

2020-12-15 Thread Hans de Goede
ebugging of > the Surface Aggregator communication layer. > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): > - remove unnecessary default in Kconfig entry > > Cha

Re: [PATCH v2 6/9] platform/surface: aggregator: Add dedicated bus and device type

2020-12-15 Thread Hans de Goede
to manually establish device links for that purpose > in the client driver (as has to be done with the platform devices). > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): &g

Re: [PATCH v2 6/9] platform/surface: aggregator: Add dedicated bus and device type

2020-12-15 Thread Hans de Goede
to manually establish device links for that purpose > in the client driver (as has to be done with the platform devices). > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): &g

Re: [PATCH v2 7/9] docs: driver-api: Add Surface Aggregator subsystem documentation

2020-12-15 Thread Hans de Goede
> > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): > - change SPDX identifier to GPL-2.0+ (was GPL-2.0-or-later) > - fix typos > > Changes in v2: > - add archit

Re: [PATCH v2 8/9] platform/surface: Add Surface Aggregator user-space interface

2020-12-15 Thread Hans de Goede
Hi, On 12/3/20 10:26 PM, Maximilian Luz wrote: > Add a misc-device providing user-space access to the Surface Aggregator > EC, mainly intended for debugging, testing, and reverse-engineering. > This interface gives user-space applications the ability to send > requests to the EC and receive the co

Re: [PATCH v2 9/9] platform/surface: Add Surface ACPI Notify driver

2020-12-15 Thread Hans de Goede
re required to provide said > functionality on those devices. > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): > - add copyright lines > - change SPDX identifier to GPL-2.0

Re: [GIT PULL] platform-drivers-x86 for 5.11-1

2020-12-16 Thread Hans de Goede
Hi, On 12/16/20 1:17 AM, Linus Torvalds wrote: > On Mon, Dec 14, 2020 at 4:43 AM Hans de Goede wrote: >> >> - New Intel PMT telemetry and crashlog drivers > > These have _very_ annoying Kconfig setups. > > First it asks about INTEL_PMT support. > >

Re: [PATCH] platform/surface: SURFACE_PLATFORMS should depend on ACPI

2020-12-16 Thread Hans de Goede
soft Surface drivers, even though this question is > irrelevant. > > Fix this by moving the dependency on ACPI from the individual driver > symbols to SURFACE_PLATFORMS. > > Signed-off-by: Geert Uytterhoeven Thanks, patch looks good to me: Reviewed-by: Hans de Goede Maximilian, c

[GIT PULL] platform-drivers-x86 for 5.11-1

2020-12-14 Thread Hans de Goede
around for BIOS bug Elia Devito (2): platform/x86: intel-hid: Add support for SW_TABLET_MODE platform/x86: intel-hid: Add alternative method to enable switches Hans de Goede (14): platform/x86: touchscreen_dmi: Add info for the Predia Basic tablet platform/x86: acer-wmi: Drop no-

Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-14 Thread Hans de Goede
Hi All, Sasha (and the other intel-wired-lan folks), thank you for investigating this further and for coming up with a better solution. Mario, thank you for implementing the new scheme. I've tested this patch set on a Lenovo X1C8 with vPRO and AMT enabled in the BIOS (the previous issues were s

Re: [PATCH 4/4] e1000e: Export S0ix flags to ethtool

2020-12-14 Thread Hans de Goede
Hi, On 12/14/20 4:34 PM, Mario Limonciello wrote: > This flag can be used by an end user to disable S0ix flows on a > buggy system or by an OEM for development purposes. > > If you need this flag to be persisted across reboots, it's suggested > to use a udev rule to call adjust it until the kerne

Re: [RFT][PATCH v1 0/3] ACPI: scan: Defer enumeration of devices with significant dependencies

2020-12-15 Thread Hans de Goede
ontrol methods used for device enumeration. Thank you for you work on this! I started with reviewing the series so that I would know what to expect during testing. All 3 patches look good to me: Reviewed-by: Hans de Goede As is the series does not fix the Bluetooth HID misreporting on the s

Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-15 Thread Hans de Goede
Hi, On 12/14/20 8:36 PM, Limonciello, Mario wrote: >> Hi All, >> >> Sasha (and the other intel-wired-lan folks), thank you for investigating this >> further and for coming up with a better solution. >> >> Mario, thank you for implementing the new scheme. >> > > Sure. > >> I've tested this patch

Re: [PATCH v5 0/4] Improve s0ix flows for systems i219LM

2020-12-15 Thread Hans de Goede
r. > - Increase ULP timeout to 2.5 seconds, but show a warning after 1 second. Thank you. I've given v5 a test on a Lenovo X1 Carbon 8th gen (AMT capable) and things work fine there with v5: Tested-by: Hans de Goede Regards, Hans > Changes from v3 to v4: > - Drop patch 1 for p

Re: [PATCH v5 4/4] e1000e: Export S0ix flags to ethtool

2020-12-15 Thread Hans de Goede
adjust it until the kernel could have your > configuration in a disallow list. > > Signed-off-by: Mario Limonciello Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/net/ethernet/intel/e1000e/e1000.h | 1 + > drivers/ne

Re: [PATCH v5 3/4] Revert "e1000e: disable s0ix entry and exit flows for ME systems"

2020-12-15 Thread Hans de Goede
systems") > Reviewed-by: Alexander Duyck > Signed-off-by: Mario Limonciello Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 45 +- > 1 file changed, 2 insertions(+), 43 del

[GIT PULL] platform-drivers-x86 for 5.10-2

2020-11-27 Thread Hans de Goede
: - Add info for the Irbis TW118 tablet - Add info for the Predia Basic tablet Benjamin Berg (1): platform/x86: thinkpad_acpi: Send tablet mode switch at wakeup time Hans de Goede (4): platform/x86: thinkpad_acpi: Do not

Re: 5.10 regression, many XHCI swiotlb buffer is full / DMAR: Device bounce map failed errors on thunderbolt connected XHCI controller

2020-11-27 Thread Hans de Goede
Hi, On 11/24/20 11:27 AM, Christoph Hellwig wrote: > On Mon, Nov 23, 2020 at 03:49:09PM +0100, Hans de Goede wrote: >> Hi, >> >> +Cc Christoph Hellwig >> >> Christoph, this is still an issue, so I've been looking around a bit and >> think this >&g

Re: 5.10 regression caused by: "uas: fix sdev->host->dma_dev": many XHCI swiotlb buffer is full / DMAR: Device bounce map failed errors on thunderbolt connected XHCI controller

2020-11-27 Thread Hans de Goede
Hi, On 11/27/20 12:41 PM, Hans de Goede wrote: > Hi, > > On 11/24/20 11:27 AM, Christoph Hellwig wrote: >> On Mon, Nov 23, 2020 at 03:49:09PM +0100, Hans de Goede wrote: >>> Hi, >>> >>> +Cc Christoph Hellwig >>> >>> Christoph, t

Re: [PATCH 4/5] x86/platform/uv: Add deprecated messages to /proc info leaves

2020-11-27 Thread Hans de Goede
Hi, On 11/27/20 3:58 PM, Mike Travis wrote: > > > On 11/26/2020 2:45 AM, Hans de Goede wrote: >> Hi, >> >> On 11/25/20 6:29 PM, Mike Travis wrote: >>> Add "deprecated" message to any access to old /proc/sgi_uv/* leaves. >>> >

Re: 5.10 regression caused by: "uas: fix sdev->host->dma_dev": many XHCI swiotlb buffer is full / DMAR: Device bounce map failed errors on thunderbolt connected XHCI controller

2020-11-27 Thread Hans de Goede
Hi, On 11/27/20 5:19 PM, Christoph Hellwig wrote: > On Fri, Nov 27, 2020 at 01:32:16PM +0100, Hans de Goede wrote: >> I ran some more tests, I can confirm that reverting: >> >> 5df7ef7d32fe "uas: bump hw_max_sectors to 2048 blocks for SS or faster >> drives"

Re: 5.10 regression caused by: "uas: fix sdev->host->dma_dev": many XHCI swiotlb buffer is full / DMAR: Device bounce map failed errors on thunderbolt connected XHCI controller

2020-11-28 Thread Hans de Goede
i_add_host())? I would expect that to work / avoid the regression, so yes that is a good option. If you can provide me with a patch doing that, then I can test it to make sure it does indeed fix the regression. Regards, Hans > > On Sat, 28 Nov 2020 at 02:12, Hans de Goede wrote:

Re: [PATCH v2 0/5] x86/platform/uv: Move UV procfs leaves to sysfs

2020-11-28 Thread Hans de Goede
previous set). Here is my ack for the drivers/platform/x86 bits being merged through the x86/tip tree: Acked-by: Hans de Goede Regards, Hans > > v2: Updated to apply to v3 of dependency patch set listed above. > > Mike Travis (5): > x86/platform/uv: Add kernel interfa

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-29 Thread Hans de Goede
Hi All, On 11/29/20 4:23 AM, Jarkko Sakkinen wrote: > On Tue, Nov 24, 2020 at 10:45:01PM +0100, Hans de Goede wrote: >> Hi, >> >> On 11/24/20 6:52 PM, Jerry Snitselaar wrote: >>> >>> Jarkko Sakkinen @ 2020-11-23 20:26 MST: >>> >>>> On W

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

2020-11-29 Thread Hans de Goede
Hi Stephen, On 11/29/20 6:43 PM, Stephen Rothwell wrote: > Hi all, > > In commit > > 912b341585e3 ("platform/x86: mlx-platform: Remove PSU EEPROM from MSN274x > platform configuration") > > Fixes tag > > Fixes: ef08e14a3 ("platform/x86: mlx-platform: Add support for new msn274x > system

Re: [PATCH v2] brcmfmac: expose firmware config files through modinfo

2020-11-20 Thread Hans de Goede
Hi, On 11/20/20 12:11 PM, Matthias Brugger wrote: > > > On 20/11/2020 11:05, Dmitry Osipenko wrote: >> 20.11.2020 12:52, matthias@kernel.org пишет: >>> From: Matthias Brugger >>> >>> Apart from a firmware binary the chip needs a config file used by the >>> FW. Add the config files to modinf

Re: [PATCH 1/3] Input: goodix - add option to disable firmware loading

2020-11-23 Thread Hans de Goede
Hi, On 11/23/20 7:53 AM, Dmitry Torokhov wrote: > On Fri, Oct 30, 2020 at 10:56:20AM +0100, Hans de Goede wrote: >> Hi, >> >> On 10/29/20 9:36 PM, Dmitry Torokhov wrote: >>> Hi Andrej, >>> >>> On Thu, Oct 29, 2020 at 06:03:11PM +0100, Andrej V

Re: [PATCH] Input: soc_button_array - add missing include

2020-11-23 Thread Hans de Goede
irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); > ^ > 2 errors generated. > > Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which > modify the irqflags") > Reported-by: kernel test robot > Signed-off-by: Dmitry Torokh

Re: [PATCH v7 4/8] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-22 Thread Hans de Goede
Hi, On 02/22/2014 09:31 AM, Maxime Ripard wrote: This should be before the registration. Otherwise, you're racy. Nope, we only need this to get the data on sunxi_mmc_remove, everywhere else the data is found through the mmc-host struct. Still, if anyone makes a following patch using the p

[PATCH] irq: Add a new IRQF_ACK_BEFORE_UNMASK irq flag

2014-03-11 Thread Hans de Goede
and not on the irqchip. Cc: Carlo Caione Signed-off-by: Hans de Goede --- include/linux/interrupt.h | 2 ++ kernel/irq/chip.c | 4 kernel/irq/internals.h| 2 ++ kernel/irq/manage.c | 5 - 4 files changed, 12 insertions(+), 1 deletion(-) diff --git a/include/linux

Re: [PATCH] irq: Add a new IRQF_ACK_BEFORE_UNMASK irq flag

2014-03-12 Thread Hans de Goede
Hi All, So after sleeping a night on this I'm not so sure anymore this patch is such such a good idea. So self-nack. Still I welcome feedback on this issue... On 03/12/2014 12:13 AM, Hans de Goede wrote: > In some cases we want to do an ack right before the unmask of an irq. >

[PATCH v2 3/4] irqchip: sun4i: Fix a comment about mask register initialization

2014-03-12 Thread Hans de Goede
The comment was claiming that we were masking all irqs, while the code actually *un*masks all of them. Signed-off-by: Hans de Goede Acked-by: Maxime Ripard --- drivers/irqchip/irq-sun4i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-sun4i.c b/drivers

[PATCH v2 4/4] irqchip: sun4i: Use handle_fasteoi_late_irq for the ENMI (irq 0)

2014-03-12 Thread Hans de Goede
The ENMI needs to have the ack done *after* clearing the interrupt source, otherwise we will get a spurious interrupt for each real interrupt. Switch to the new handle_fasteoi_late_irq handler which gives us the desired behavior. Signed-off-by: Hans de Goede --- drivers/irqchip/irq-sun4i.c | 11

Re: [PATCH] irq: Add a new IRQF_ACK_BEFORE_UNMASK irq flag

2014-03-12 Thread Hans de Goede
Hi, On 03/12/2014 11:38 AM, Thomas Gleixner wrote: > On Wed, 12 Mar 2014, Hans de Goede wrote: > And how is that different from the non threaded case? > > mask() > ack() <-- irq line is still active > handle() <-- irq line goes i

[PATCH v2 2/4] irqchip: sun4i: Fix irq 0 not working

2014-03-12 Thread Hans de Goede
after having read the vector-reg once. Signed-off-by: Hans de Goede --- drivers/irqchip/irq-sun4i.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-sun4i.c b/drivers/irqchip/irq-sun4i.c index a5438d8..5c25048 100644 --- a/drivers

[PATCH v2 1/4] irq: Add handle_fasteoi_late_irq irq handler

2014-03-12 Thread Hans de Goede
be issued right before the unmask. Signed-off-by: Hans de Goede > In some cases we want to do an ack right before the unmask of an irq. > > A typical example of such a case is having an i2c device which uses a level > interrupt. Such devices usually have an interrupt status register

[PATCH v2 0/4] irq: sun4i IRQ 0 / ENMI fixes

2014-03-12 Thread Hans de Goede
Hi All, Here is v2 of my sun4i IRQ 0 / ENMI fixes fixes, changelog below: v2: PATCH 1/4 irq: Add handle_fasteoi_late_irq irq handler New patch by Thomas Gleixner, adding a new irq handler with the "call eoi after the irq-handler has run its course" behavior we need to avoid double irqs on the EN

Re: [PATCH v2 1/4] irq: Add handle_fasteoi_late_irq irq handler

2014-03-12 Thread Hans de Goede
Hi, On 03/12/2014 06:17 PM, Hans de Goede wrote: > From: Thomas Gleixner > > Add an irq handler for transparent controllers > > Only a single callback will be issued to the chip: an ->eoi() call when > the interrupt has been serviced. Same as handle_fasteoi_irq, but > w

Re: [PATCH v2 4/4] irqchip: sun4i: Use handle_fasteoi_late_irq for the ENMI (irq 0)

2014-03-13 Thread Hans de Goede
Hi, On 03/13/2014 12:12 PM, Thomas Gleixner wrote: > On Thu, 13 Mar 2014, Maxime Ripard wrote: > >> On Wed, Mar 12, 2014 at 06:17:07PM +0100, Hans de Goede wrote: >>> The ENMI needs to have the ack done *after* clearing the interrupt source, >>> otherwise we wil

Re: [PATCH v2 4/4] irqchip: sun4i: Use handle_fasteoi_late_irq for the ENMI (irq 0)

2014-03-13 Thread Hans de Goede
Hi, On 03/13/2014 03:46 PM, Thomas Gleixner wrote: > On Wed, 12 Mar 2014, Hans de Goede wrote: > >> The ENMI needs to have the ack done *after* clearing the interrupt source, >> otherwise we will get a spurious interrupt for each real interrupt. Switch >> to the new

Re: [PATCH] irq: Add a new IRQF_ACK_BEFORE_UNMASK irq flagq

2014-03-13 Thread Hans de Goede
k conditions were true for the ONESHOT case the code would do: "unmask; eoi", now it does "eoi; unmask" I believe the new behavior is more correct, but, since it is a behavior change I thought I should point this out. I've also given this a test-run on sun4i and it works as

[PATCH v3 3/4] irqchip: sun4i: Fix a comment about mask register initialization

2014-03-13 Thread Hans de Goede
The comment was claiming that we were masking all irqs, while the code actually *un*masks all of them. Signed-off-by: Hans de Goede Acked-by: Maxime Ripard --- drivers/irqchip/irq-sun4i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-sun4i.c b/drivers

[PATCH v3 0/4] irq: sun4i IRQ 0 / ENMI fixes

2014-03-13 Thread Hans de Goede
Hi All, Here is v3 of my sun4i IRQ 0 / ENMI fixes patch-set, changelog below: v2: PATCH 1/4 irq: Add handle_fasteoi_late_irq irq handler New patch by Thomas Gleixner, adding a new irq handler with the "call eoi after the irq-handler has run its course" behavior we need to avoid double irqs on th

[PATCH v3 4/4] irqchip: sun4i: Don't ack IRQs != 0, fix acking of IRQ 0

2014-03-13 Thread Hans de Goede
handle_fasteoi_irq. This uses a separate irq_chip struct for IRQ 0, since we only want this behavior for IRQ 0. Signed-off-by: Hans de Goede --- drivers/irqchip/irq-sun4i.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-sun4i.c b/drivers

[PATCH v3 1/4] irq: Add a new IRQCHIP_EOI_THREADED flag

2014-03-13 Thread Hans de Goede
From: Thomas Gleixner This flag must be used in combination with handle_fasteoi_irq, when set handle_fasteoi_irq will delay the calling of chip->irq_eoi until the threaded handler has run. Reviewed-by: Hans de Goede Tested-by: Hans de Goede Signed-off-by: Hans de Goede --- include/li

[PATCH v3 2/4] irqchip: sun4i: Fix irq 0 not working

2014-03-13 Thread Hans de Goede
after having read the vector-reg once. Signed-off-by: Hans de Goede Acked-by: Maxime Ripard --- drivers/irqchip/irq-sun4i.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-sun4i.c b/drivers/irqchip/irq-sun4i.c index a5438d8..5c25048

Re: [PATCH v3 1/4] irq: Add a new IRQCHIP_EOI_THREADED flag

2014-03-13 Thread Hans de Goede
Hi, On 03/13/2014 07:03 PM, Hans de Goede wrote: > From: Thomas Gleixner > > This flag must be used in combination with handle_fasteoi_irq, when set > handle_fasteoi_irq will delay the calling of chip->irq_eoi until the threaded > handler has run. > > Reviewed-by: Ha

[PATCH 1/3] irqchip: sun4i: Don't mask + unmask for the non oneshot case

2014-03-13 Thread Hans de Goede
Since sun4i and sun5i are single core SOCs there is no need to mask non oneshot IRQs, to achieve this we use handle_fasteoi_irq with a dummy eoi. Signed-off-by: Hans de Goede --- drivers/irqchip/irq-sun4i.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 2/3] irqchip: sun4i: Simplify irq mapping

2014-03-13 Thread Hans de Goede
Now that we're using handle_fasteio_irq for all interrupts, we can get rid of having 2 irq_chip structs by making sun4i_irq_ack a nop for all irqs except irq 0. Signed-off-by: Hans de Goede --- drivers/irqchip/irq-sun4i.c | 27 --- 1 file changed, 4 insertions(+

[PATCH 0/3] irqchip: sun4i: various cleanups

2014-03-13 Thread Hans de Goede
Hi All, So here is a second patchset for irq-sun4i.c I'm not 100% sure about these changes. They all seem the right thing to do, but they definitely need a good review first. I've run various tests with this set and everything works as advertised. Regards, Hans -- To unsubscribe from this list:

[PATCH 3/3] irqchip: sun4i: simplify sun4i_irq_ack

2014-03-13 Thread Hans de Goede
register like this, if the other bits are writeable (and the data sheet says they are not) they should be write 1 to clear, since otherwise a read / modify / write can race with a device raising an interrupt and then clear the pending bit unintentionally Signed-off-by: Hans de Goede

Re: [PATCH 1/3] irqchip: sun4i: Don't mask + unmask for the non oneshot case

2014-03-14 Thread Hans de Goede
Hi, On 03/14/2014 12:35 PM, Thomas Gleixner wrote: > On Thu, 13 Mar 2014, Hans de Goede wrote: > >> Since sun4i and sun5i are single core SOCs there is no need to mask non >> oneshot IRQs, to achieve this we use handle_fasteoi_irq with a dummy eoi. > > This is slightly

[PATCH v2 0/2] irqchip: sun4i: Use handle_fasteoi_irq for all irqs

2014-03-15 Thread Hans de Goede
Hi All, Here is v2 of my patchset for sun4i-irq.c to use handle_fasteoi_irq for all irqs + follow up clean-up patch. Changes since v2: -adjust commit msg based on Thomas' comments, and merge patch 1 and 2 as they make more sense as 1 patch Regards, Hans -- To unsubscribe from this list: send t

[PATCH v2 2/2] irqchip: sun4i: simplify sun4i_irq_ack

2014-03-15 Thread Hans de Goede
register like this, if the other bits are writeable (and the data sheet says they are not) they should be write 1 to clear, since otherwise a read / modify / write can race with a device raising an interrupt and then clear the pending bit unintentionally Signed-off-by: Hans de Goede

[PATCH v2 1/2] irqchip: sun4i: Use handle_fasteoi_irq for all interrupts

2014-03-15 Thread Hans de Goede
EADED | IRQCHIP_EOI_IF_HANDLED will now influence all interrupts rather then just irq 0, but that does not matter as the eoi is now a nop anyways for all interrupts but irq 0. Signed-off-by: Hans de Goede --- drivers/irqchip/irq-sun4i.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --

Re: linux-next: ahci_platform broken build

2014-03-16 Thread Hans de Goede
Hi, On 03/16/2014 03:05 PM, Tim Gardner wrote: > Gents - while reviewing some patches for arm64 in Ubuntu I noticed that > there is at least one patch sequence in linux-next that breaks the build. > > 156c5887948cd191417f18026aab9ce26e5a95da ahci-platform: Add support for > devices with more t

Re: [PATCH] ata: ahci_sunxi: make ahci_sunxi_resume() static

2014-03-17 Thread Hans de Goede
Hi, On 03/17/2014 02:06 PM, Bartlomiej Zolnierkiewicz wrote: > Signed-off-by: Bartlomiej Zolnierkiewicz Thanks for doing these clean-ups. Acked-by: Hans de Goede Regards, Hans > --- > drivers/ata/ahci_sunxi.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &

Re: [PATCH] ata: ahci_sunxi: fix code formatting

2014-03-17 Thread Hans de Goede
Hi, On 03/17/2014 02:08 PM, Bartlomiej Zolnierkiewicz wrote: > Signed-off-by: Bartlomiej Zolnierkiewicz Thanks for doing these clean-ups. Acked-by: Hans de Goede Regards, Hans > --- > drivers/ata/ahci_sunxi.c | 44 ++-- > 1 file

Re: [linux-sunxi] [PATCH v2 2/5] clk: sun6i: Reparent AHB clock on PLL6

2014-03-01 Thread Hans de Goede
Hi, On 02/28/2014 05:37 PM, Maxime Ripard wrote: > In order for the DMA controller to work for SDRAM to devices transfers, the > AHB > clock should be reparented on the PLL6. > > Force that parenting in the clock driver. > > Signed-off-by: Maxime Ripard > --- > drivers/clk/sunxi/clk-sunxi.c |

Re: [PATCH 0/4] ata: add remaining new-style AHCI platform drivers

2014-03-17 Thread Hans de Goede
working on this. Patches 1/2 seem sensible to me, and 3/4 are obviously a good idea. Also all patches look good to me, so this series is: Acked-by: Hans de Goede Regards, Hans > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electr

Re: [PATCH] ARM: dts: OMAP2+: Fix boot with multi_v7_defconfig

2014-02-11 Thread Hans de Goede
Hi, On 02/11/2014 03:17 PM, Nishanth Menon wrote: > On 02/11/2014 07:53 AM, Roger Quadros wrote: >> On 02/10/2014 08:10 PM, Roger Quadros wrote: >>> The OMAP EHCI controller is not compatible with the EHCI >>> platform HCD driver so don't claim that we are. >>> >>> This fixes boot on OMAP platform

Re: [PATCH 3/3] ahci: st: Add support for ST's SATA IP

2014-02-19 Thread Hans de Goede
Hi, On 02/19/2014 12:36 AM, Tejun Heo wrote: > On Mon, Feb 17, 2014 at 12:56:58PM +, Lee Jones wrote: >> Cc: Tejun Heo >> Cc: linux-...@vger.kernel.org >> Signed-off-by: Lee Jones > > Please consider basing it on top of Hans' refactored ahci_platform. > > http://www.spinics.net/lists/linu

Re: [PATCH v7 4/8] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-19 Thread Hans de Goede
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 02/19/2014 10:46 AM, Maxime Ripard wrote: > Hi Hans, > > On Tue, Feb 18, 2014 at 09:49:21PM +0100, Hans de Goede wrote: >> Hi, >> >> On 02/18/2014 04:37 PM, Maxime Ripard wrote: >> >> >> &g

Re: PWC webcam and setpwc tool no longer working with 3.12.11 kernel

2014-02-21 Thread Hans de Goede
Hi, On 02/20/2014 08:30 PM, Chris Rankin wrote: > > > Hi, > > I have an old Logitech webcam, with USB IDs 046d:08b3. When I try to use this > camera now, I see this error in the dmesg log: > > [ 2883.852464] pwc: isoc_init() submit_urb 0 failed with error -28 > > > This error is apparently

Re: [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support

2014-01-22 Thread Hans de Goede
Hi, On 01/22/2014 09:11 AM, Roger Quadros wrote: Hi, On 01/21/2014 03:59 PM, Hans de Goede wrote: Hi, On 01/21/2014 12:59 PM, Roger Quadros wrote: On 01/21/2014 10:34 AM, Roger Quadros wrote: On 01/20/2014 06:48 PM, Hans de Goede wrote: Hi, On 01/20/2014 03:41 PM, Roger Quadros wrote

Re: [PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-08 Thread Hans de Goede
Hi, On 01/08/2014 12:28 PM, Roger Quadros wrote: On 01/08/2014 03:35 PM, Arnd Bergmann wrote: On Wednesday 08 January 2014 15:29:18 Kishon Vijay Abraham I wrote: + hpriv->phy = devm_phy_get(dev, "sata-phy"); + if (IS_ERR(hpriv->phy)) { + dev_dbg(dev, "can't get sata-phy\n")

Re: [PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-08 Thread Hans de Goede
Hi, On 01/08/2014 02:14 PM, Hans de Goede wrote: Hi, On 01/08/2014 12:28 PM, Roger Quadros wrote: On 01/08/2014 03:35 PM, Arnd Bergmann wrote: On Wednesday 08 January 2014 15:29:18 Kishon Vijay Abraham I wrote: + hpriv->phy = devm_phy_get(dev, "sata-phy"); + if (IS_E

Re: [PATCH] xhci: Remove segments from radix tree on failed insert.

2013-10-17 Thread Hans de Goede
all that ugly :) I've also run various tests and it seems to work as advertised (I've not managed to trigger the error path though AFAIK). Acked-by: Hans de Goede Sarah Sharp drivers/usb/host/xhci-mem.c | 106 +--- 1 file changed, 80 insert

Re: [PATCH v2] xhci: fix usb3 streams

2013-10-14 Thread Hans de Goede
e the code cleaner, and those functions are moved to make them static.] Signed-off-by: Gerd Hoffmann Signed-off-by: Hans de Goede Signed-off-by: Sarah Sharp --- drivers/usb/host/xhci-mem.c | 132 +--- drivers/usb/host/xhci.h | 1 + 2 files changed, 9

Re: [PATCH 2/3] ARM: sunxi: Add an ahci-platform compatible AHCI driver for the Allwinner SUNXi series of SoCs

2013-12-15 Thread Hans de Goede
Hi Tejun, I think it would be a good idea to merge ahci upstream using the ahci_imx.c method for now. You already indicated that you were not against doing that for now. Oliver is working on getting a cleaner solution for this, but doing this properly takes tinme, and we would like to move forwa

Re: [PATCH v5 1/8] of: Add NVIDIA Tegra SATA controller binding

2014-07-18 Thread Hans de Goede
Hi, On 07/18/2014 09:11 AM, Mikko Perttunen wrote: > This patch adds device tree binding documentation for the SATA > controller found on NVIDIA Tegra SoCs. > > Signed-off-by: Mikko Perttunen > --- > v5: remove ordering requirement again Acked-by: Hans de Goed

Re: [PATCH v5 7/8] ata: Add support for the Tegra124 SATA controller

2014-07-18 Thread Hans de Goede
andle it ourselves. > this allows use of ahci_platform while having a special sequence > for the clock. Thanks, I like this one, much better then what we had before. Acked-by: Hans de Goede Regards, Hans > > drivers/ata/Kconfig | 9 ++ > drivers/ata/Makefile | 1 +

Re: [PATCH v5 1/8] of: Add NVIDIA Tegra SATA controller binding

2014-07-18 Thread Hans de Goede
Hi, On 07/18/2014 09:16 AM, Mikko Perttunen wrote: > So here's v5: this time, as suggested, I handle the sata clock myself and let > ahci_platform handle it too, leading it to be prepared+enabled twice. This > works fine, and allows us to remove the DT ordering requirement. > > I also have in t

Re: [PATCH v10 5/8] ata: ahci_platform: add a generic AHCI compatible

2014-07-18 Thread Hans de Goede
Hi, On 07/18/2014 02:30 PM, Antoine Ténart wrote: > The ahci_platform driver is a generic driver using the libahci_platform > functions. Add a generic compatible to avoid having an endless list of > compatibles with no differences for the same driver. > > Signed-off-by: Antoine Ténart > --- > d

Re: [PATCH v10 0/8] ARM: berlin: add AHCI support

2014-07-19 Thread Hans de Goede
Hi, On 07/18/2014 03:57 PM, Tejun Heo wrote: (cc'ing Hans who's now maintaining libahci-platform.) Note I was already following this thread as I'm subscribed to linux-ide now. On Fri, Jul 18, 2014 at 02:29:59PM +0200, Antoine Ténart wrote: Tejun, Kishon, Sebastian, I looked into the AHCI

Re: [PATCH v10 0/8] ARM: berlin: add AHCI support

2014-07-19 Thread Hans de Goede
Hi, On 07/19/2014 12:18 PM, Hans de Goede wrote: The problem is that: 1) We need to enable resources before we can do ahci_save_initial_config() 2) We must do ahci_save_initial_config() before we can do ata_host_alloc_pinfo() 3) Therefor we don't have port_info at enable_resources

Re: [PATCH v4 2/3] libahci_platform: add host_flags parameter in ahci_platform_init_host()

2014-04-23 Thread Hans de Goede
Hi, On 04/23/2014 01:36 PM, Kefeng Wang wrote: > Add a dynamic host flags argument to make ahci_platform_init_host more > flexible, > then remove the AHCI_HFLAGS(...) argument from some driver's ata_port_info, > and pass that in as the new arguments. > > Cc: Hans de Geode > Signed-off-by: Kefen

Re: [PATCH v5 0/3] ahci: add support for hisilicon sata

2014-04-23 Thread Hans de Goede
Hi, On 04/23/2014 02:36 PM, Kefeng Wang wrote: > channge in v5: > > 1) drop AHCI_HFLAGS(...) from ahci_xgene.c and do use host_flags >in ahci_platform_init_host, it's my carelessness. > Thanks, looks good now, this series is: Reviewed-by: Hans de Goede Regards, Ha

[PATCH] kconfig: Fix compiler warning in menu.c

2014-07-31 Thread Hans de Goede
len(r->s); ^ In file included from scripts/kconfig/zconf.tab.c:2537:0: scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here struct jump_key *jump; Signed-off-by: Hans de Goede --- scripts/kconfig/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [U-Boot] [PATCH] kconfig: Fix compiler warning in menu.c

2014-07-31 Thread Hans de Goede
Hi, On 07/31/2014 10:10 PM, Jeroen Hofstee wrote: > Hello Hans, > > On 31-07-14 16:21, Hans de Goede wrote: >> This fixes the following compiler warning: >> >> In file included from scripts/kconfig/zconf.tab.c:2537:0: >> scripts/kconfig/menu.c: In function ‘ge

<    6   7   8   9   10   11   12   13   14   15   >