Re: [PATCH resend v5 3/3] platform/x86: intel_cht_int33fe: Update fusb302 type string, add properties

2017-10-27 Thread Hans de Goede
Hi, On 27-10-17 12:13, Hans de Goede wrote: Hi, On 26-10-17 22:33, Wolfram Sang wrote: On Wed, Oct 11, 2017 at 11:41:21AM +0200, Hans de Goede wrote: The fusb302 driver as merged in staging uses "typec_fusb302" as i2c-id rather then just "fusb302" and needs us to se

Re: [PATCH resend v5 3/3] platform/x86: intel_cht_int33fe: Update fusb302 type string, add properties

2017-10-27 Thread Hans de Goede
Hi, On 27-10-17 12:41, Wolfram Sang wrote: On Fri, Oct 27, 2017 at 12:31:01PM +0200, Hans de Goede wrote: Hi, On 27-10-17 12:13, Hans de Goede wrote: Hi, On 26-10-17 22:33, Wolfram Sang wrote: On Wed, Oct 11, 2017 at 11:41:21AM +0200, Hans de Goede wrote: The fusb302 driver as merged in

[PATCH 2/2] platform/x86: peaq-wmi: Remove unnecessary checks from peaq_wmi_exit

2017-10-30 Thread Hans de Goede
peaq_wmi_exit will only ever get called if peaq_wmi_init succeeds, so there is no need to repeat the checks from peaq_wmi_init. Suggested-by: Andy Shevchenko Signed-off-by: Hans de Goede --- drivers/platform/x86/peaq-wmi.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff

[PATCH 1/2] platform/x86: peaq_wmi: Fix missing terminating entry for peaq_dmi_table

2017-10-30 Thread Hans de Goede
Add missing terminating entry to peaq_dmi_table. Fixes: 3b95206110a2 ("platform/x86: peaq-wmi: Add DMI check before ...") Cc: sta...@vger.kernel.org Reported-by: Fengguang Wu Signed-off-by: Hans de Goede --- drivers/platform/x86/peaq-wmi.c | 1 + 1 file changed, 1 insertion(+) di

Re: [PATCH v5 1/2] x86 / i915 iosf_mbi / PMIC bus access fixes

2017-10-30 Thread Hans de Goede
Thomas, Ingo, Ping? Can we please get an ack for taking this upstream through the drm subsys tree ? Regards, Hans On 19-10-17 13:16, Hans de Goede wrote: Hi All, Here is a split-up version of my "drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()" patch, t

Re: [PATCH v5 2/2] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

2017-10-31 Thread Hans de Goede
Hi, On 31-10-17 10:50, Ingo Molnar wrote: * Hans de Goede wrote: intel_uncore_forcewake_reset() does forcewake puts and gets as such we need to make sure that no-one tries to access the PUNIT->PMIC bus (on systems where this bus is shared) while it runs, otherwise bad things hap

Re: [linux-sunxi] Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi

2015-10-08 Thread Hans de Goede
Hi, On 10/07/2015 05:01 PM, Stefan Monnier wrote: @Maxime: How should we handle this? In its current form, the patch applies only to the BananaPi dts by overriding the inherited opp from the SoC dtsi. In an earlier discussion, it was said that this can be done, even though it might not be the mo

Re: [PATCH RFC 1/2] dt-bindings: simplefb: Support a list of regulator supply properties

2015-10-13 Thread Hans de Goede
Hi, On 13-10-15 04:22, Chen-Yu Tsai wrote: On Tue, Oct 13, 2015 at 1:10 AM, Mark Rutland wrote: On Tue, Oct 13, 2015 at 01:04:17AM +0800, Chen-Yu Tsai wrote: The physical display tied to the framebuffer may have regulators providing power to it, such as power for LCDs or interface conversion

Re: [PATCH RFC 0/2] simplefb: Add regulator handling support

2015-10-13 Thread Hans de Goede
Hi, On 12-10-15 19:04, Chen-Yu Tsai wrote: Hi everyone, This series adds regulator claiming and enabling support for simplefb. Sometimes the simplefb display output path consits of external conversion chips and/or LCD drivers and backlights. These devices normally have GPIOs to turn them on an

Re: [PATCH RFC 0/2] simplefb: Add regulator handling support

2015-10-14 Thread Hans de Goede
Hi, On 14-10-15 12:55, Mark Brown wrote: On Tue, Oct 13, 2015 at 09:16:56AM +0200, Hans de Goede wrote: On 12-10-15 19:04, Chen-Yu Tsai wrote: Now the DT bindings don't support a list of regulators directly, so I'm working around it by having a "num-supplies" property t

Re: [PATCH] ahci: added a new driver for supporting Freescale AHCI sata

2015-09-07 Thread Hans de Goede
Hi, On 06-09-15 07:39, Yuantian Tang wrote: Hi, -Original Message- From: Hans de Goede [mailto:hdego...@redhat.com] Sent: Wednesday, September 02, 2015 4:32 PM To: Tang Yuantian-B29983 Cc: t...@kernel.org; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH

Re: [PATCH 1/3] Revert "ahci: added support for Freescale AHCI sata"

2015-09-07 Thread Hans de Goede
f-by: Tang Yuantian The entire series looks good to me and is: Reviewed-by: Hans de Goede Regards, Hans --- Documentation/devicetree/bindings/ata/ahci-platform.txt | 2 -- drivers/ata/ahci_platform.c | 1 - 2 files changed, 3 deletions(-) diff --git a/Doc

Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-09 Thread Hans de Goede
patch fixed it by assigning 0 to px_is and px_cmd variables. This patch also remove line 'struct ccsr_ahci *reg_base' which is not referred by any other codes and thus a dead one. Signed-off-by: Tang Yuantian LGTM: Acked-by: Hans de Goede Regards, Hans --- drivers/ata/ahci_q

Re: Almost certainly confirmed, sun7i-a20 does not support 8 bit mmc.

2015-09-09 Thread Hans de Goede
Hi, On 09-09-15 16:30, Maxime Ripard wrote: On Wed, Sep 09, 2015 at 03:04:11PM +0200, Olliver Schinagl wrote: Hey all, After experimenting with a Micron eMMC chip, I made some interesting finds I wanted to share with you all. For a while now, some had hopes or guessed that the A20 could have

Re: linux-next: build failure after merge of the input tree

2015-10-16 Thread Hans de Goede
s added need to also be added to the Kbuild file, the attached patch should fix this. Dmitry, feel free to squash this into the original patch. Regards, Hans >From 0dd5544b6ca0cddfe25976b46ef9ba5c4adbc791 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Fri, 16 Oct 2015 09:33:45 +0200 Subj

Re: [PATCH RFC v2 1/2] dt-bindings: simplefb: Support a list of regulator supply properties

2015-10-21 Thread Hans de Goede
this by adding a "num-supplies" property to communicate the number of supplies, and a list of 0 ~ N "vinN-supply" properties for the actual regulator supply. This bit of the commit message is no longer accurate. Other then that this patch looks good to me: Reviewed-by: Hans de Go

Re: [PATCH RFC v2 2/2] simplefb: Claim and enable regulators

2015-10-21 Thread Hans de Goede
} + } + } + + return 0; +} + +static void simplefb_regulators_destroy(struct simplefb_par *par) +{ + int i; + + if (!par->regulators) + return; + + for (i = 0; i < par->regulator_count; i++) + if (par->regulato

Re: [PATCH RFC v2 2/2] simplefb: Claim and enable regulators

2015-10-21 Thread Hans de Goede
Hi, On 21-10-15 10:04, Chen-Yu Tsai wrote: Hi, On Wed, Oct 21, 2015 at 3:54 PM, Hans de Goede wrote: Hi, On 21-10-15 07:59, Chen-Yu Tsai wrote: This claims and enables regulators listed in the simple framebuffer dt node. This is needed so that regulators powering the display pipeline and

Re: Regression since commit 92bac83

2015-10-21 Thread Hans de Goede
Hi, On 21-10-15 10:19, Pali Rohár wrote: On Tuesday 20 October 2015 13:39:05 Hans de Goede wrote: From 5d21a8004260c3e6287bde81c2a9e8f80144e77c Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Tue, 20 Oct 2015 11:12:07 +0200 Subject: [PATCH] alps: Only the Dell Latitude D420/430/620/630

Re: [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support

2015-10-21 Thread Hans de Goede
Hi Jens, On 21-10-15 18:13, Jens Kuske wrote: Hi everyone, This is v3 of my patch series introducing basic kernel support for Allwinner's H3 SoC. It mainly adds basic clocks and pinctrl. It also adds interrupts, timers, watchdog, RTC, dmaengine, MMC and UARTs, which are mostly compatible to tho

Re: [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support

2015-10-21 Thread Hans de Goede
Hi, On 21-10-15 18:13, Jens Kuske wrote: Hi everyone, This is v3 of my patch series introducing basic kernel support for Allwinner's H3 SoC. It mainly adds basic clocks and pinctrl. It also adds interrupts, timers, watchdog, RTC, dmaengine, MMC and UARTs, which are mostly compatible to those in

Re: [linux-sunxi] Re: [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support

2015-10-22 Thread Hans de Goede
Hi, On 22-10-15 09:49, Jens Kuske wrote: Hi, On 21/10/15 21:18, Hans de Goede wrote: Great to see that you've started working on this again. Last weekend I ended up working on this too together with Reinder E.N. de Haan (added to the Cc). We took a slightly different approach fo

Re: [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support

2015-10-22 Thread Hans de Goede
Hi, On 22-10-15 09:58, Jean-Francois Moine wrote: On Wed, 21 Oct 2015 21:18:45 +0200 Hans de Goede wrote: Great to see that you've started working on this again. Last weekend I ended up working on this too together with Reinder E.N. de Haan (added to the Cc). We took a slightly diff

Re: [PATCH] ahci: added a new driver for supporting Freescale AHCI sata

2015-09-02 Thread Hans de Goede
Hi, On 02-09-15 04:25, yuantian.t...@freescale.com wrote: From: Tang Yuantian Currently Freescale QorIQ series SATA is supported by ahci_platform driver. Some SoC specific settings have been put in uboot. So whether SATA works or not heavily depends on uboot. This patch will add a new driver t

Re: [PATCH RFC 0/2] simplefb: Add regulator handling support

2015-10-19 Thread Hans de Goede
Hi, On 18-10-15 21:57, Mark Brown wrote: On Wed, Oct 14, 2015 at 01:31:52PM +0200, Hans de Goede wrote: I like your idea in your other mail where you suggest to actually use foo-supply and bar-supply names in the simplefb node, and then have some code simple iterate over all the properties

Re: Regression since commit 92bac83

2015-10-19 Thread Hans de Goede
Hi, On 19-10-15 01:59, Larry Finger wrote: Hi, I recently upgraded the kernel in a Dell Latitude D600 and found that the touchpad clicks failed. The problem was bisected to commit 92bac83dd79e60e65c475222e41a992a70434beb ("Input: alps - non interleaved V2 dualpoint has separate stick button b

Re: Regression since commit 92bac83

2015-10-19 Thread Hans de Goede
Hi, On 19-10-15 18:51, Dmitry Torokhov wrote: On Mon, Oct 19, 2015 at 10:55:20AM -0500, Larry Finger wrote: On 10/19/2015 03:08 AM, Hans de Goede wrote: Hi, On 19-10-15 01:59, Larry Finger wrote: Hi, I recently upgraded the kernel in a Dell Latitude D600 and found that the touchpad clicks

Re: [PATCH] m5602: correctly check failed thread creation

2015-10-20 Thread Hans de Goede
Hi, On 19-10-15 17:24, Insu Yun wrote: Since thread creation can be failed, check return value of kthread_create and handle an error. Signed-off-by: Insu Yun --- drivers/media/usb/gspca/m5602/m5602_s5k83a.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/m

Re: [PATCH] gspca: correctly checked failed allocation

2015-10-20 Thread Hans de Goede
Hi, On 19-10-15 18:43, Insu Yun wrote: create_singlethread_workqueue can be failed in memory pressue. So, check return value and return -ENOMEM Signed-off-by: Insu Yun --- drivers/media/usb/gspca/sq905.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/gspca/sq905.c b

Re: Regression since commit 92bac83

2015-10-20 Thread Hans de Goede
Hi, On 19-10-15 17:55, Larry Finger wrote: On 10/19/2015 03:08 AM, Hans de Goede wrote: Hi, On 19-10-15 01:59, Larry Finger wrote: Hi, I recently upgraded the kernel in a Dell Latitude D600 and found that the touchpad clicks failed. The problem was bisected to commit

Re: [PATCH v4 0/4] simplefb: Add regulator handling support

2015-10-23 Thread Hans de Goede
Hi, Patches 1/2 look good and are: Reviewed-by: Hans de Goede And the approach used for the regulators in them is also: Acked-by: Mark Brown So patches 1/2 are ready for merging. Jean-Christophe or Tomi, can you pick up patch 1 & 2 please ? Regards, Hans On 10/23/2015 05:50 AM,

Re: [linux-sunxi] Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI

2015-10-24 Thread Hans de Goede
Hi, On 10/23/2015 08:14 PM, Maxime Ripard wrote: On Wed, Oct 21, 2015 at 06:20:27PM +0200, Jens Kuske wrote: + bus_gates: clk@01c20060 { + #clock-cells = <1>; + compatible = "allwinner,sun8i-h3-bus-gates-clk"; + reg

Re: [linux-sunxi] Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI

2015-10-27 Thread Hans de Goede
Hi, On 26-10-15 22:06, Maxime Ripard wrote: On Sat, Oct 24, 2015 at 10:47:49AM +0200, Jean-Francois Moine wrote: On Sat, 24 Oct 2015 09:13:28 +0200 Maxime Ripard wrote: Or simply bus_gates { clocks = <&ahb1>, <&ahb2>; clock-indices = <5>, <6>, <8>, ... clock-output-n

[PATCH v3 0/4] ACPI bugfix + i2c-multi-instantiate pseudo driver

2018-08-07 Thread Hans de Goede
Hi All, So here is my third attempt at dealing with multiple i2c devices being described in a single ACPI fwnode. Like the second attemp This is still based on having a special driver for these corner cases which can be a module and only loaded when on hardware which needs this. New this time ar

[PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-07 Thread Hans de Goede
fwnode, see the i2c_multi_instantiate_ids list of ACPI device-ids in drivers/acpi/scan.c: acpi_device_enumeration_by_parent(). Signed-off-by: Hans de Goede --- MAINTAINERS | 6 + drivers/platform/x86/Kconfig | 11 ++ drivers/platform/x86

[PATCH v3 1/4] ACPI / scan: Fix acpi_is_indirect_io_slave() always returning false

2018-08-07 Thread Hans de Goede
ct() calls acpi_bus_get_status() Fixes: dfda4492322e ("ACPI / scan: Do not enumerate Indirect IO host children") Cc: sta...@vger.kernel.org Cc: John Garry Cc: Bjorn Helgaas Cc: Dann Frazier Signed-off-by: Hans de Goede --- drivers/acpi/scan.c | 5 +++-- 1 file changed, 3 insert

[PATCH v3 2/4] ACPI / scan: Create platform device for fwnodes with multiple i2c devices

2018-08-07 Thread Hans de Goede
which i2c_device_id to use for each resource, to bind to the fwnode and initiate an i2c-client for each resource. Signed-off-by: Hans de Goede --- drivers/acpi/scan.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index

[PATCH v3 3/4] ACPI / x86-utils: Remove status workaround from acpi_device_always_present()

2018-08-07 Thread Hans de Goede
Now that we init the status field to ACPI_STA_DEFAULT rather then to 0, the workaround for acpi_match_device_ids() always returning -ENOENT when status is 0 is no longer needed. Signed-off-by: Hans de Goede --- drivers/acpi/x86/utils.c | 10 -- 1 file changed, 10 deletions(-) diff

Re: [PATCH v3 1/4] ACPI / scan: Fix acpi_is_indirect_io_slave() always returning false

2018-08-07 Thread Hans de Goede
Hi, On 07-08-18 12:05, John Garry wrote: On 07/08/2018 09:05, Hans de Goede wrote: Since commit 63347db0affa ("ACPI / scan: Use acpi_bus_get_status() to initialize ACPI_TYPE_DEVICE devs") the status field of normal acpi_devices gets set to 0 by acpi_bus_type_and_status() and fille

Re: [PATCH v3 2/4] ACPI / scan: Create platform device for fwnodes with multiple i2c devices

2018-08-07 Thread Hans de Goede
Hi, On 07-08-18 13:19, Andy Shevchenko wrote: On Tue, 2018-08-07 at 10:05 +0200, Hans de Goede wrote: Some devices have multiple I2cSerialBus resources and for things to work an i2c-client must be instantiated for each, each with its own i2c_device_id. Normally we only instantiate an i2c

Re: [PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-07 Thread Hans de Goede
Hi, On 07-08-18 13:27, Wolfram Sang wrote: Hi Hans, +I2C MULTI INSTANTIATE DRIVER +M: Hans de Goede +L: linux-...@vger.kernel.org Since this driver is about FW bugs, I wonder if platform-driver-...@vger.kernel.org isn't the better list here? Ok, fixed for v4. +S: Maint

Re: [PATCH] printk: Make CONSOLE_LOGLEVEL_QUIET configurable

2018-06-20 Thread Hans de Goede
Hi, On 20-06-18 13:03, Petr Mladek wrote: On Tue 2018-06-19 13:57:26, Hans de Goede wrote: The goal of passing the "quiet" option to the kernel is for the kernel to be quiet unless something really is wrong. Sofar passing quiet has been (mostly) equivalent to passing loglevel=4 on

Re: [PATCH] printk: Make CONSOLE_LOGLEVEL_QUIET configurable

2018-06-20 Thread Hans de Goede
Hi, On 20-06-18 13:24, Sergey Senozhatsky wrote: On (06/20/18 13:03), Petr Mladek wrote: This commit makes CONSOLE_LOGLEVEL_QUIET configurable. This for example will allow distros which want quiet to really mean quiet to set CONSOLE_LOGLEVEL_QUIET so that only messages with a higher severity t

Re: [PATCH v3 1/2] HID: i2c-hid: Use devm to allocate i2c_hid struct

2018-06-22 Thread Hans de Goede
o put regulator pointers from freed memory. Cc: Benjamin Tissoires Cc: Hans de Goede Cc: Andy Shevchenko Cc: Dmitry Torokhov Cc: Doug Anderson Signed-off-by: Stephen Boyd --- drivers/hid/i2c-hid/i2c-hid.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/hi

Re: [PATCH] ata: Disable AHCI ALPM feature for Ampere Computing eMAG SATA

2018-08-27 Thread Hans de Goede
Hi, On 27-08-18 20:47, Suman Tripathi wrote: Due to hardware errata, Ampere Computing eMAG SATA can't support AHCI ALPM feature. This patch disables the AHCI ALPM feature for eMAG SATA. Signed-off-by: Suman Tripathi Signed-off-by: Rameshwar Prasad Sahu Thank you for the patch. 2 remarks: 1

Re: [PATCH V4 4/4] video: simplefb: switch to use clk_bulk API to simplify clock operations

2018-08-29 Thread Hans de Goede
Hi, On 29-08-18 14:51, Dong Aisheng wrote: Switching to use clk_bulk API to simplify clock operations. Cc: Hans de Goede Cc: Bartlomiej Zolnierkiewicz Cc: linux-fb...@vger.kernel.org Cc: Masahiro Yamada Cc: Stephen Boyd Tested-by: Thor Thayer Signed-off-by: Dong Aisheng --- v3->

[PATCH] platform/x86: Add Intel ISP dummy driver

2018-08-29 Thread Hans de Goede
=196915 Signed-off-by: Hans de Goede --- MAINTAINERS| 6 ++ drivers/platform/x86/Kconfig | 12 +++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/intel_isp_dummy.c | 119 + 4 files changed, 138 insertions

Re: [PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-08 Thread Hans de Goede
Hi, On 07-08-18 13:45, Andy Shevchenko wrote: On Tue, 2018-08-07 at 13:33 +0200, Hans de Goede wrote: Hi, On 07-08-18 13:27, Wolfram Sang wrote: Hi Hans, +I2C MULTI INSTANTIATE DRIVER In the case below, I think it would be slightly better to mention ACPI here, something like ACPI I2C

Re: [PATCH v3 2/4] ACPI / scan: Create platform device for fwnodes with multiple i2c devices

2018-08-08 Thread Hans de Goede
Hi, On 07-08-18 13:49, Andy Shevchenko wrote: On Tue, 2018-08-07 at 13:29 +0200, Hans de Goede wrote: Hi, On 07-08-18 13:19, Andy Shevchenko wrote: On Tue, 2018-08-07 at 10:05 +0200, Hans de Goede wrote: + /* +* These devices have multiple I2cSerialBus resources and an i2c

Re: [PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-08 Thread Hans de Goede
Hi, On 07-08-18 14:46, John Garry wrote: On 07/08/2018 09:05, Hans de Goede wrote: On systems with ACPI instantiated i2c-clients, normally there is 1 fw_node per i2c-device and that fw-node contains 1 I2cSerialBus resource for that 1 i2c-device. But in some rare cases the manufacturer has

[PATCH v4 1/4] ACPI / scan: Initialize status to ACPI_STA_DEFAULT

2018-08-08 Thread Hans de Goede
on and the acpi_bus_get_status() call is those acpi_match_device_ids() calls. Note this does mean that we need to (re)set status to 0 in case the acpi_bus_get_status() call fails. Signed-off-by: Hans de Goede --- Changes in v3: -New patch in v3 of this patch-set Changes in v4: -This is not

[PATCH v4 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-08 Thread Hans de Goede
fwnode, see the i2c_multi_instantiate_ids list of ACPI device-ids in drivers/acpi/scan.c: acpi_device_enumeration_by_parent(). Signed-off-by: Hans de Goede --- Changes in v2: -Rebase on top of 4.18-rc2 Changes in v3: -Change from an i2c-driver using a hack to allow having multiple i2c clients

[PATCH v4 0/4] i2c-multi-instantiate pseudo driver

2018-08-08 Thread Hans de Goede
Hi All, Here is v4 of my patch-series for dealing with multiple independent i2c devices being described in a single ACPI fwnode. Changes in v4: -Rewrite commit message of first patch as this is NOT a bug fix for acpi_is_indirect_io_slave() as I thought at first, it is still necessary as a prepe

[PATCH v4 3/4] ACPI / x86-utils: Remove status workaround from acpi_device_always_present()

2018-08-08 Thread Hans de Goede
Now that we init the status field to ACPI_STA_DEFAULT rather then to 0, the workaround for acpi_match_device_ids() always returning -ENOENT when status is 0 is no longer needed. Signed-off-by: Hans de Goede --- Changes in v3: -New patch in v3 of this patch-set --- drivers/acpi/x86/utils.c | 10

[PATCH v4 2/4] ACPI / scan: Create platform device for fwnodes with multiple i2c devices

2018-08-08 Thread Hans de Goede
which i2c_device_id to use for each resource, to bind to the fwnode and initiate an i2c-client for each resource. Signed-off-by: Hans de Goede --- Changes in v3: -New patch in v3 of this patch-set Changes in v4: -Some small code-style fixes --- drivers/acpi/scan.c | 16 1 file

Re: [PATCH v4 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-08 Thread Hans de Goede
Hi, On 08/08/2018 11:08 AM, Andy Shevchenko wrote: On Wed, Aug 8, 2018 at 11:30 AM, Hans de Goede wrote: On systems with ACPI instantiated i2c-clients, normally there is 1 fw_node per i2c-device and that fw-node contains 1 I2cSerialBus resource for that 1 i2c-device. But in some rare cases

Re: [PATCH v4 4/4] i2c: Add multi-instantiate pseudo driver

2018-08-09 Thread Hans de Goede
Hi, On 08-08-18 19:00, Wolfram Sang wrote: $subject still says "i2c:" Ah, good point I will send a v5 with this fixed, I will also do s/no_clients/num_clients/ for v5 as Andy requested. Regards, Hans

[PATCH v5 0/4] i2c-multi-instantiate pseudo driver

2018-08-09 Thread Hans de Goede
Hi All, Here is v5 of my patch-series for dealing with multiple independent i2c devices being described in a single ACPI fwnode. Changes in v5: -s/no_clients/num_clients/ -Change patch 4 Subject prefix to platform/x86 Changes in v4: -Rewrite commit message of first patch as this is NOT a bug fix

[PATCH v5 3/4] ACPI / x86-utils: Remove status workaround from acpi_device_always_present()

2018-08-09 Thread Hans de Goede
Now that we init the status field to ACPI_STA_DEFAULT rather then to 0, the workaround for acpi_match_device_ids() always returning -ENOENT when status is 0 is no longer needed. Signed-off-by: Hans de Goede --- Changes in v3: -New patch in v3 of this patch-set --- drivers/acpi/x86/utils.c | 10

[PATCH v5 4/4] platform/x86: Add ACPI i2c-multi-instantiate pseudo driver

2018-08-09 Thread Hans de Goede
fwnode, see the i2c_multi_instantiate_ids list of ACPI device-ids in drivers/acpi/scan.c: acpi_device_enumeration_by_parent(). Signed-off-by: Hans de Goede --- Changes in v2: -Rebase on top of 4.18-rc2 Changes in v3: -Change from an i2c-driver using a hack to allow having multiple i2c clients

[PATCH v5 1/4] ACPI / scan: Initialize status to ACPI_STA_DEFAULT

2018-08-09 Thread Hans de Goede
on and the acpi_bus_get_status() call is those acpi_match_device_ids() calls. Note this does mean that we need to (re)set status to 0 in case the acpi_bus_get_status() call fails. Signed-off-by: Hans de Goede --- Changes in v3: -New patch in v3 of this patch-set Changes in v4: -This is not

[PATCH v5 2/4] ACPI / scan: Create platform device for fwnodes with multiple i2c devices

2018-08-09 Thread Hans de Goede
which i2c_device_id to use for each resource, to bind to the fwnode and initiate an i2c-client for each resource. Signed-off-by: Hans de Goede --- Changes in v3: -New patch in v3 of this patch-set Changes in v4: -Some small code-style fixes --- drivers/acpi/scan.c | 16 1 file

Re: [PATCH v5 1/4] ACPI / scan: Initialize status to ACPI_STA_DEFAULT

2018-08-09 Thread Hans de Goede
Hi, On 09-08-18 11:35, Rafael J. Wysocki wrote: On Thu, Aug 9, 2018 at 11:15 AM, Hans de Goede wrote: Since commit 63347db0affa ("ACPI / scan: Use acpi_bus_get_status() to initialize ACPI_TYPE_DEVICE devs") the status field of normal acpi_devices gets set to 0 by acpi_bus_type_

Re: [PATCH v5 1/4] ACPI / scan: Initialize status to ACPI_STA_DEFAULT

2018-08-09 Thread Hans de Goede
Hi, On 09-08-18 11:51, Andy Shevchenko wrote: On Thu, Aug 9, 2018 at 12:39 PM, Hans de Goede wrote: On 09-08-18 11:35, Rafael J. Wysocki wrote: On Thu, Aug 9, 2018 at 11:15 AM, Hans de Goede wrote: I've applied the v4 of this patch and I don't think there are any changes fr

Re: [PATCH v5 4/4] platform/x86: Add ACPI i2c-multi-instantiate pseudo driver

2018-08-09 Thread Hans de Goede
Hi, On 09-08-18 13:09, Heikki Krogerus wrote: On Thu, Aug 09, 2018 at 11:15:58AM +0200, Hans de Goede wrote: On systems with ACPI instantiated i2c-clients, normally there is 1 fw_node per i2c-device and that fw-node contains 1 I2cSerialBus resource for that 1 i2c-device. But in some rare

Re: [PATCH v5 1/4] ACPI / scan: Initialize status to ACPI_STA_DEFAULT

2018-08-09 Thread Hans de Goede
Hi, On 09-08-18 11:59, Rafael J. Wysocki wrote: On Thu, Aug 9, 2018 at 11:58 AM, Hans de Goede wrote: Hi, On 09-08-18 11:51, Andy Shevchenko wrote: On Thu, Aug 9, 2018 at 12:39 PM, Hans de Goede wrote: On 09-08-18 11:35, Rafael J. Wysocki wrote: On Thu, Aug 9, 2018 at 11:15 AM, Hans

[PATCH v6 2/4] ACPI / scan: Create platform device for fwnodes with multiple i2c devices

2018-08-09 Thread Hans de Goede
which i2c_device_id to use for each resource, to bind to the fwnode and initiate an i2c-client for each resource. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v3: -New patch in v3 of this patch-set Changes in v4: -Some small code-style fixes --- drivers/acpi/scan.c

[PATCH v6 1/4] ACPI / scan: Initialize status to ACPI_STA_DEFAULT

2018-08-09 Thread Hans de Goede
on and the acpi_bus_get_status() call is those acpi_match_device_ids() calls. Note this does mean that we need to (re)set status to 0 in case the acpi_bus_get_status() call fails. Signed-off-by: Hans de Goede --- Changes in v3: -New patch in v3 of this patch-set Changes in v4: -This is not

[PATCH v6 0/4] i2c-multi-instantiate pseudo driver

2018-08-09 Thread Hans de Goede
Hi All, Here is v6 of my patch-series for dealing with multiple independent i2c devices being described in a single ACPI fwnode. Changes in v6: -Added some Reviewed-by and Acked-by-s to patches 2-4 -4th patch "platform/x86: Add ACPI i2c-multi-instantiate pseudo driver": -s/irq_idx/gpio_irq_idx/

[PATCH v6 4/4] platform/x86: Add ACPI i2c-multi-instantiate pseudo driver

2018-08-09 Thread Hans de Goede
fwnode, see the i2c_multi_instantiate_ids list of ACPI device-ids in drivers/acpi/scan.c: acpi_device_enumeration_by_parent(). Acked-by: Andy Shevchenko Acked-by: Wolfram Sang Signed-off-by: Hans de Goede --- Changes in v2: -Rebase on top of 4.18-rc2 Changes in v3: -Change from an i2c-driver

[PATCH v6 3/4] ACPI / x86-utils: Remove status workaround from acpi_device_always_present()

2018-08-09 Thread Hans de Goede
Now that we init the status field to ACPI_STA_DEFAULT rather then to 0, the workaround for acpi_match_device_ids() always returning -ENOENT when status is 0 is no longer needed. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v3: -New patch in v3 of this patch-set

Re: [PATCH v6 4/4] platform/x86: Add ACPI i2c-multi-instantiate pseudo driver

2018-08-09 Thread Hans de Goede
Hi, On 09-08-18 13:55, Rafael J. Wysocki wrote: On Thu, Aug 9, 2018 at 1:40 PM, Hans de Goede wrote: On systems with ACPI instantiated i2c-clients, normally there is 1 fw_node per i2c-device and that fw-node contains 1 I2cSerialBus resource for that 1 i2c-device. But in some rare cases the

Re: [PATCH] bluetooth: hci_h5: avoid unused variable warnings

2018-08-14 Thread Hans de Goede
Hi Arnd, On 14-08-18 00:04, Arnd Bergmann wrote: When CONFIG_BT_HCIUART_RTL is disabled, the hci_h5 driver produces a build warning because of an incorrect set of #ifdef guards: drivers/bluetooth/hci_h5.c:920:22: error: 'rtl_vnd' defined but not used [-Werror=unused-variable] Replacing the #i

Re: [PATCH] Use default .cfg file name for RTL8723BS devices with id of OBDA8723

2018-08-14 Thread Hans de Goede
Hi, On 14-08-18 08:47, Ian W MORRISON wrote: For RTL8723BS devices the current config file name is a composite of both the config name (rtl8723bs) and a postfix of the device-id. Given the majority of RTL8723BS devices use a device-id of OBDA8723 this simplifies the config file name to use "rtl

Re: [PATCH 00/14] ata: ahci-platform: add reset control support except for existing drivers

2018-08-22 Thread Hans de Goede
Hi, On 22-08-18 09:36, Kunihiko Hayashi wrote: Add support to get and control a list of resets for the device, and add the flag indicating whether to use the reset. Existing drivers set 0 to this flags. This series solves the issue of the previous patch [1] that was already reverted [2]. [1] ht

Re: [PATCH v2 0/3] ata: ahci-platform: add reset control support except for existing drivers

2018-08-22 Thread Hans de Goede
: Hans de Goede Regards, Hans Kunihiko Hayashi (3): ata: add an extra argument to ahci_platform_get_resources() ata: libahci_platform: add reset control support ata: ahci_platform: enable to get and control reset .../devicetree/bindings/ata/ahci-platform.txt | 1 + drivers/ata

Re: [PATCH] i2c: enable async suspend/resume on i2c devices

2018-07-27 Thread Hans de Goede
Hi, On 07/27/2018 12:44 PM, Andy Shevchenko wrote: On Fri, Jul 27, 2018 at 1:55 AM, Derek Basehore wrote: This enables the async suspend property for i2c devices. This reduces the suspend/resume time considerably on platforms with multiple i2c devices (such as a trackpad or touchscreen). How

Re: [PATCH 2/2] ata: ahci: Enable DEVSLP by default on x86 with SLP_S0

2018-07-27 Thread Hans de Goede
Hi, On 07/20/2018 02:01 AM, Srinivas Pandruvada wrote: One of the requirement for modern x86 system to enter lowest power mode (SLP_S0) is SATA IP block to be off. This is true even during when platform is suspended to idle and not only in opportunistic (runtime) suspend. Several of these syste

Re: [PATCH v2 0/2] ata: ahci: Enable DEVSLP by default on SLP_S0 support

2018-07-29 Thread Hans de Goede
DEVSLP by default. v2: As suggested by Hans, take care of the module param is same as default LPM policy Thanks. Series looks good to me: Reviewed-by: Hans de Goede Note we need to keep an eye out for this causing regressions with some disks / firmware-versions. Regards, Hans

Re: [PATCH 0/2] ata: libahci: devslp fixes

2018-07-30 Thread Hans de Goede
about devslp, both patches seem sensible to me, so both are: Reviewed-by: Hans de Goede Regards, Hans

Re: [RFC PATCH v2 1/2] ata: ahci: Support state with min power and Partial low power state

2018-07-19 Thread Hans de Goede
Hi, On 13-07-18 17:06, Srinivas Pandruvada wrote: Hi Hans, On Fri, 2018-07-13 at 11:08 +0200, Hans de Goede wrote: Hi, On 13-07-18 00:27, Srinivas Pandruvada wrote: Currently when min_power policy is selected, the partial low power state is not entered and link will try aggressively enter to

Re: [PATCH] platform/x86: touchscreen_dmi: Add info for the Cube KNote i1101 tablet

2018-07-31 Thread Hans de Goede
Yes you can add my: Signed-off-by: Hans de Goede Like last time, or do you want me to resend this with it added? Regards, Hans Reported-and-tested-by: lkongl --- drivers/platform/x86/touchscreen_dmi.c | 26 ++ 1 file changed, 26 insertions(+) diff --git

Re: [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED()

2018-07-11 Thread Hans de Goede
ed on the fbdev discussion this seems a good idea to me and codewise this looks good to: Reviewed-by: Hans de Goede Regards, Hans --- diff --git a/include/linux/console.h b/include/linux/console.h index dfd6b0e97855..9d4a6b985154 100644 --- a/include/linux/console.h +++ b/include/linux/console.h @@

Re: [PATCH 0/3] ata: ahci_platform: minor fixes

2018-07-12 Thread Hans de Goede
Hi, On 12-07-18 13:41, Corentin Labbe wrote: Hello This patchset fixes some minor problem found when working on supporting allwinner R40 AHCI. Regards Thanks. The entire series looks good to me: Reviewed-by: Hans de Goede Regards, Hans

Re: [RFC PATCH v2 1/2] ata: ahci: Support state with min power and Partial low power state

2018-07-13 Thread Hans de Goede
. Devslp – PHY logic is powered down. The link PM exit latency from this state to active state maximum is 20 ms, unless otherwise specified by DETO. Suggested-by: Hans de Goede Signed-off-by: Srinivas Pandruvada You got this the wrong way around, when ALP is not set you only get partial, the ALP

Re: [RFC PATCH v2 2/2] ata: ahci: Enable DEVSLP by default on x86 with SLP_S0

2018-07-13 Thread Hans de Goede
Hi, On 13-07-18 00:27, Srinivas Pandruvada wrote: From: Srinivas One of the requirement for modern x86 system to enter lowest power mode (SLP_S0) is SATA IP block to be off. This is true even during when platform is suspended to idle and not only in opportunistic (runtime) suspend. Several of

Re: [PATCH] fbdev: simplefb: add support for 'memory-region' property on DT node

2018-01-23 Thread Hans de Goede
size written in the memory description on the reserved-memory node can be used for the framebuffer. Furthermore, the reserved-memory node needs to have "no-map" attributes because simplefb driver maps the region by ioremap_wc(). Signed-off-by: Kunihiko Hayashi Seems reasonable t

Re: [PATCH] Add touchscreen platform data for the Teclast X3 Plus tablet.

2018-01-23 Thread Hans de Goede
looks good to me, so with the subject fixed this is: Reviewed-by: Hans de Goede But you should rebase this on top of: http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git/shortlog/refs/heads/testing So that it can be applied cleanly by the platform/x86 maintainers. Please

Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module

2018-01-24 Thread Hans de Goede
Hi, On 24-01-18 15:44, Andy Shevchenko wrote: On Wed, Jan 24, 2018 at 3:29 PM, Sinan Kaya wrote: +linux-acpi +Cc: Hans Thank you. On 1/24/2018 1:27 AM, Mika Westerberg wrote: On Wed, Jan 24, 2018 at 06:56:16AM +0100, Wolfram Sang wrote: On Wed, Jan 03, 2018 at 03:02:31PM +0100, Eric Au

Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module

2018-01-24 Thread Hans de Goede
Hi, On 24-01-18 16:12, Sinan Kaya wrote: On 1/24/2018 9:59 AM, Hans de Goede wrote: TL;DR: I have to NAK this, I'm sorry but with the current state of ACPI we must simply have some stuff builtin to help with probe-ordering issues. Now if the ACPI code where ever to honor the _DEP m

Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module

2018-01-24 Thread Hans de Goede
Hi, On 24-01-18 16:37, Sinan Kaya wrote: On 1/24/2018 10:23 AM, Hans de Goede wrote: There must be a middle ground somewhere. One thing which comes to mind is to simply not allow building i2c as a module when ACPI is selected, something like this should work I think:  config I2C

[PATCH v3 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support

2018-01-24 Thread Hans de Goede
Hi All, As mentioned in the v2 cover letter, now that the vboxguest driver which the vboxsf (guest shared folder) fs driver depends on is queued for merging into 4.16 in char-misc-next, all the dependencies for the vboxsf are in place. So now its time to work towards also getting vboxsf merged.

[PATCH v3] fs: Add VirtualBox guest shared folder (vboxsf) support

2018-01-24 Thread Hans de Goede
s.h F: include/uapi/linux/vbox*.h F: drivers/virt/vboxguest/ +VIRTUAL BOX SHARED FOLDER VFS DRIVER: +M: Hans de Goede +L: linux-fsde...@vger.kernel.org +S: Maintained +F: fs/vboxsf/* + VIRTUAL SERIO DEVICE DRIVER M: Stephen Chandler Paul S: Maintained diff --git a/fs/Kco

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

2018-01-25 Thread Hans de Goede
Hi, On 17-01-18 02:04, Chanwoo Choi wrote: On 2018년 01월 16일 18:33, Hans de Goede wrote: Hi, On 16-01-18 00:43, Chanwoo Choi wrote: On 2018년 01월 15일 20:32, Hans de Goede wrote: HI, On 15-01-18 10:08, Chanwoo Choi wrote: On 2018년 01월 15일 17:36, Hans de Goede wrote: Hi, On 15-01-18 06:22

[PATCH] Revert "extcon: axp288: Redo charger type detection a couple of seconds after probe()"

2018-01-25 Thread Hans de Goede
ng as doing a retry after 2 seconds is. This reverts commit 50082c17bb1455acacd376ae30dff92f2e1addbd. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-axp288.c | 32 ++-- 1 file changed, 2 insertions(+), 30 deletions(-) diff --git a/drivers/extcon/extcon-axp28

Re: [PATCH v3] ACPI: Force I2C to be selected as a built-in module

2018-01-25 Thread Hans de Goede
Hi, On 25-01-18 18:07, Sinan Kaya wrote: On 1/25/2018 11:57 AM, Rafael J. Wysocki wrote: That was the original patch. Folks are saying that it breaks some systems. Conversation is here: https://patchwork.kernel.org/patch/10142425/ Couldn't that be addressed by preventing the I2C module from

[PATCH v4 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support

2018-01-25 Thread Hans de Goede
Hi All, As mentioned in the v2 cover letter, now that the vboxguest driver which the vboxsf (guest shared folder) fs driver depends on is queued for merging into 4.16 in char-misc-next, all the dependencies for the vboxsf are in place. So now its time to work towards also getting vboxsf merged.

[PATCH v4 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support

2018-01-25 Thread Hans de Goede
Hi All, As mentioned in the v2 cover letter, now that the vboxguest driver which the vboxsf (guest shared folder) fs driver depends on is queued for merging into 4.16 in char-misc-next, all the dependencies for the vboxsf are in place. So now its time to work towards also getting vboxsf merged.

[PATCH v4] fs: Add VirtualBox guest shared folder (vboxsf) support

2018-01-25 Thread Hans de Goede
s.h F: include/uapi/linux/vbox*.h F: drivers/virt/vboxguest/ +VIRTUAL BOX SHARED FOLDER VFS DRIVER: +M: Hans de Goede +L: linux-fsde...@vger.kernel.org +S: Maintained +F: fs/vboxsf/* + VIRTUAL SERIO DEVICE DRIVER M: Stephen Chandler Paul S: Maintained diff --git a/fs/Kco

[PATCH] extcon: int3496: process id-pin first so that we start with the right status

2018-01-25 Thread Hans de Goede
extcon, so that other drivers see the correct state right away. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-intel-int3496.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c index

<    1   2   3   4   5   6   7   8   9   10   >