On Wed 28 November 2012 12:45:37 Dan Carpenter wrote:
> I wish people wouldn't submit big patches right before the merge
> window opens... :/ It's better to let it sit in linux-next for a
> couple weeks so people can mess with it a bit.
It's been under review for quite some time now, and the main
On Wed November 28 2012 18:22:48 Greg Kroah-Hartman wrote:
> On Wed, Nov 28, 2012 at 10:18:02AM -0200, Mauro Carvalho Chehab wrote:
> > Em Wed, 28 Nov 2012 12:56:10 +0100
> > Hans Verkuil escreveu:
> >
> > > On Wed 28 November 2012 12:45:37 Dan Carpenter wrote:
On Thu November 29 2012 00:47:41 Sylwester Nawrocki wrote:
> On 11/28/2012 10:29 PM, Dan Carpenter wrote:
> > On Wed, Nov 28, 2012 at 08:30:04PM +0100, Sylwester Nawrocki wrote:
> >> On 11/28/2012 01:22 PM, Dan Carpenter wrote:
> >>> In the end this is just a driver, and I don't especially care. B
On Wed November 28 2012 20:30:21 Greg Kroah-Hartman wrote:
> On Wed, Nov 28, 2012 at 08:18:20PM +0100, Hans Verkuil wrote:
> > On Wed November 28 2012 18:22:48 Greg Kroah-Hartman wrote:
> > > On Wed, Nov 28, 2012 at 10:18:02AM -0200, Mauro Carvalho Chehab wrote:
> > >
dds media controller based capture driver for
> > DM365.
>
> For the whole set --- granted that the TODO item to "add support for regular
> V4L2 applications through user space libraries" is added:
>
> Acked-by: Sakari Ailus
>
>
Ditto for the TODO item.
On Thu March 14 2013 15:06:59 Jon Arne Jørgensen wrote:
> This file is responsible for registering the device
> with the kernel i2c subsystem.
> v4l2 talks to the saa7113 chip of the device via i2c.
>
> Signed-off-by: Jon Arne Jørgensen
> ---
> drivers/media/usb/smi2021/smi2021_i2c.c | 160
> ++
Hi Jon Arne,
Here is my review of this driver.
Regards,
Hans
On Thu March 14 2013 15:06:58 Jon Arne Jørgensen wrote:
> This is the core of the smi2021 module.
> It will register the module with the kernel, and register the
> usb probe function.
>
> Signed-off-by: Jon Arne Jørgensen
>
On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote:
> This file is responsible for registering the device with the v4l2 subsystem,
> and the communication with v4l2.
> Most of the v4l2 ioctls are just passed on to vidbuf2.
>
> Signed-off-by: Jon Arne Jørgensen
> ---
> drivers/media/usb/smi20
On Thu March 14 2013 15:07:01 Jon Arne Jørgensen wrote:
> This file is responsible for all communication with the video hardware
> and also starting and stopping the capture.
>
> It also contains the setup and handling of the usb ISOCHRONOUS transfers.
>
> Signed-off-by: Jon Arne Jørgensen
> ---
On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote:
> This file is responsible for registering the device with the v4l2 subsystem,
> and the communication with v4l2.
> Most of the v4l2 ioctls are just passed on to vidbuf2.
>
> Signed-off-by: Jon Arne Jørgensen
> ---
> drivers/media/usb/smi20
On Thu March 14 2013 15:06:58 Jon Arne Jørgensen wrote:
> This is the core of the smi2021 module.
> It will register the module with the kernel, and register the
> usb probe function.
>
> Signed-off-by: Jon Arne Jørgensen
> ---
> drivers/media/usb/smi2021/smi2021_main.c | 339
>
On Wed 20 March 2013 10:48:42 Jon Arne Jørgensen wrote:
> On Mon, Mar 18, 2013 at 09:29:07AM +0100, Hans Verkuil wrote:
> > On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote:
> > > This file is responsible for registering the device with the v4l2
> > > subsystem,
On Wed 20 March 2013 10:43:26 Jon Arne Jørgensen wrote:
> On Mon, Mar 18, 2013 at 09:12:31AM +0100, Hans Verkuil wrote:
> > On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote:
> > > This file is responsible for registering the device with the v4l2
> > > subsystem,
On Wed 20 March 2013 11:06:36 Jon Arne Jørgensen wrote:
> On Mon, Mar 18, 2013 at 09:58:32AM +0100, Bjørn Mork wrote:
> > Hans Verkuil writes:
> >
> > >> +/*
> > >> + *
> > >> + * The device delivers data in chunks of 0x400 bytes.
> > >
On Wed 20 March 2013 11:16:26 Jon Arne Jørgensen wrote:
> On Wed, Mar 20, 2013 at 11:10:57AM +0100, Hans Verkuil wrote:
> > On Wed 20 March 2013 10:48:42 Jon Arne Jørgensen wrote:
> > > On Mon, Mar 18, 2013 at 09:29:07AM +0100, Hans Verkuil wrote:
> > > > On Thu M
On Wed January 23 2013 15:07:06 Federico Vaga wrote:
> This patch re-write the driver and use the videobuf2
> interface instead of the old videobuf. Moreover, it uses also
> the control framework which allows the driver to inherit
> controls from its subdevice (ADV7180). Finally the driver does not
gt; Signed-off-by: Lad, Prabhakar
> Signed-off-by: Hans Verkuil
> Signed-off-by: Martin Bugge
> Cc: Chaithrika U S
> ---
> Changes for v2:
> 1: Merged the driver in existing ths7303 driver.
> 2: Merged the patch which adds the chip indent in same patch.
>
> dr
I reviewed the code (as well as I could) and didn't see any problems, I'm
giving my ack anyway:
Acked-by: Hans Verkuil
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kern
On Sun February 10 2013 11:34:11 Knut Petersen wrote:
> Maybe somebody could have at that old locking warning:
It's a false warning. If someone can point me to some documentation on how to
tell lockdep that it isn't a deadlock, then that would be appreciated.
Regards,
Hans
>
> [9.7
On Mon 1 April 2013 08:36:50 Prabhakar lad wrote:
> From: Lad, Prabhakar
>
> Add pm_runtime support to the TI Davinci VPIF driver.
>
> Signed-off-by: Lad, Prabhakar
> Cc: Mauro Carvalho Chehab
> Cc: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Sakari Ailus
> Cc:
On Tue 2 April 2013 15:41:30 Prabhakar lad wrote:
> From: Lad, Prabhakar
>
> Add pm_runtime support to the TI Davinci VPIF driver.
>
> Signed-off-by: Lad, Prabhakar
> Cc: Mauro Carvalho Chehab
> Cc: Hans Verkuil
Acked-by: Hans Verkuil
Regards,
Hans
> Cc
Hi Prabhakar,
Some comments below:
On Fri January 25 2013 11:36:07 Prabhakar Lad wrote:
> From: Manjunath Hadli
>
> The patch adds support for THS7353 video amplifier. Enable
> dv_preset support for THS7353 so that setting a HD mode on the
> host device makes sure appropriate mode in the amplif
On Tue February 26 2013 07:38:51 Andrey Smirnov wrote:
> This commit introduces new class of standard controls
> V4L2_CTRL_CLASS_FM_RX. This class is intended to all controls
> pertaining to FM receiver chips. Also, two controls belonging to said
> class are added as a part of this commit: V4L2_CID
On Tue February 26 2013 07:38:52 Andrey Smirnov wrote:
> Add appropriate documentation for all the newly added standard
> controls.
Give credit to Manjunatha Halli.
> Signed-off-by: Andrey Smirnov
> ---
> Documentation/DocBook/media/v4l/compat.xml |3 +
> Documentation/DocBook/media
On Tue February 26 2013 07:38:53 Andrey Smirnov wrote:
> Add a base to be used for allocation of all the SI476X specific
> controls in the corresponding driver.
>
> Signed-off-by: Andrey Smirnov
> ---
> include/uapi/linux/v4l2-controls.h |4
> 1 file changed, 4 insertions(+)
>
> diff -
On Tue February 26 2013 07:38:54 Andrey Smirnov wrote:
> From: Andrey Smirnov
>
> This commit adds a driver that exposes all the radio related
> functionality of the Si476x series of chips via the V4L2 subsystem.
>
> Signed-off-by: Andrey Smirnov
> ---
> Documentation/video4linux/si476x.txt |
On Tue February 26 2013 07:38:46 Andrey Smirnov wrote:
> This is a fourth version of the patchset originaly posted here:
> https://lkml.org/lkml/2012/9/13/590
>
> Second version of the patch was posted here:
> https://lkml.org/lkml/2012/10/5/598
>
> Third version of the patch was posted here:
> h
ic
> functionality and locking scheme.
> 2. Radio device that translates between V4L2 subsystem requests into
> Core device commands.
> 3. Codec device that does similar to the earlier described task, but
> for ALSA SoC subsystem.
>
> v6 of this driver has following changes:
>
On Monday, February 18, 2013 19:59:28 Andrey Smirnov wrote:
> This is a fourth version of the patchset originaly posted here:
> https://lkml.org/lkml/2012/9/13/590
>
> Second version of the patch was posted here:
> https://lkml.org/lkml/2012/10/5/598
>
> Third version of the patch was posted here
; simple or advanced.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Sakari Ailus
> Cc: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc: Sylwester Nawrocki
> Cc: Hans de Goede
> Cc: Kyungmin Park
> ---
> This patches
y: Manjunath Hadli
> Cc: Sakari Ailus
> Cc: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc: Sylwester Nawrocki
> Cc: Hans de Goede
> Cc: Kyungmin Park
> Cc: Rob Landley
> Cc: HeungJun Kim
> ---
> This patches has one checkpatch warning
On Mon September 3 2012 11:16:17 Prabhakar Lad wrote:
> From: Lad, Prabhakar
>
> add V4L2_CID_TEST_PATTERN of type menu, which determines
> the internal test pattern selected by the device.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc:
-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> Cc: Sakari Ailus
> Cc: Sylwester Nawrocki
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc: Hans de Goede
> Cc: Kyungmin Park
> Cc: Guennadi Liakhovetski
> Cc: Rob Landley
> --
On Tue 11 September 2012 16:23:38 Prabhakar Lad wrote:
> From: Lad, Prabhakar
>
> Add a helper function to modify the menu, max and default value
> to set.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> Cc: Sakari Ailus
>
19:53:38 Prabhakar Lad wrote:
> >> From: Lad, Prabhakar
> >>
> >> Add a helper function to modify the menu, max and default value
> >> to set.
> >>
> >> Signed-off-by: Lad, Prabhakar
> >> Signed-off-by: Manjunath Hadli
> >
On Thu 13 September 2012 15:52:47 Federico Vaga wrote:
> Signed-off-by: Federico Vaga
> ---
> drivers/media/v4l2-core/Kconfig | 5 +
> drivers/media/v4l2-core/Makefile | 1 +
> drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205
> ++
Hi Andrey!
Thanks for posting this driver. One request for the future: please split this
patch up in smaller pieces: one for each c source for example. That makes it
easier to review.
On Fri September 14 2012 00:40:11 Andrey Smirnov wrote:
> This patch adds a core driver for Silicon Laboratories
Hi Andrey!
Some generic comments:
sound/i2c/other/tea575x-tuner.c is a good example of how to make an AM/FM tuner
driver. It's used by e.g. drivers/media/radio/radio-shark.c. This went in just
yesterday, so you need to look at the latest staging/for_v3.7 branch of the
media_tree.git repo.
Some m
2_rect *' but argument is of
> type 'const struct v4l2_rect *'
> make[4]: *** [drivers/media/platform/davinci/vpfe_capture.o] Error 1
Acked-by: Hans Verkuil
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> ---
> dr
':
> vpbe_display.c:640: warning: initialization discards qualifiers from pointer
> target type
>
> This patch fixes the above build warning.
Acked-by: Hans Verkuil
Prabhaker, can you make a pull request for this patch, the "CUSTOM_TIMINGS"
rename patch and the earlier
gt;
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> ---
> drivers/media/platform/davinci/vpif_capture.c |8 ++--
> drivers/media/platform/davinci/vpif_display.c |8 ++--
> 2 files changed, 12 insertions(+), 4 deletions(-)
On Tue 25 September 2012 16:21:55 Prabhakar wrote:
> From: Lad, Prabhakar
>
> set device_caps and also change the driver and
> bus_info to proper values as per standard.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
>
On Thu 4 October 2012 11:29:57 Prabhakar wrote:
> From: Lad, Prabhakar
>
> from commit with id 896f38f582730a19eb49677105b4fe4c0270b82e
> it's mandatory to check the return code of vb2_queue_init().
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
On Thu 4 October 2012 11:29:58 Prabhakar wrote:
> From: Lad, Prabhakar
>
> set device_caps and also change the driver and
> bus_info to proper values as per standard.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
Acked-by
On Fri September 21 2012 03:05:41 andrey.smir...@convergeddevices.net wrote:
> On 09/13/2012 11:44 PM, Hans Verkuil wrote:
> > Hi Andrey!
> >
> > Thanks for posting this driver. One request for the future: please split
> > this
> > patch up in smaller pieces:
On Fri September 21 2012 11:21:35 Federico Vaga wrote:
> This patch adds support for prepare/finish callbacks in VB2 allocators.
> These callback are used for buffer flushing.
>
> Signed-off-by: Marek Szyprowski
> Acked-by: Laurent Pinchart
> Acked-by: Federico Vaga
> ---
> drivers/media/v4l2-
On Fri September 21 2012 11:21:37 Federico Vaga wrote:
> This patch re-write the driver and use the videobuf2
> interface instead of the old videobuf. Moreover, it uses also
> the control framework which allows the driver to inherit
> controls from its subdevice (ADV7180)
Some more comments below,
On Fri September 21 2012 18:33:45 andrey.smir...@convergeddevices.net wrote:
> On 09/21/2012 12:31 AM, Hans Verkuil wrote:
> > On Fri September 21 2012 03:05:41 andrey.smir...@convergeddevices.net wrote:
> >> On 09/13/2012 11:44 PM, Hans Verkuil wrote:
> >>> Hi
and has routing
> information. An output does not have to have a subdev.
>
> The initial output for each channel is set to the fist output.
>
> Currently missing is support for associating multiple subdevs with
> an output.
>
> Signed-off-by: Lad, Prabhakar
> Signed-o
and has routing
> information. An output does not have to have a subdev.
>
> The initial output for each channel is set to the fist output.
>
> Currently missing is support for associating multiple subdevs with
> an output.
>
> Signed-off-by: Lad, Prabhakar
> Signed-o
On Mon September 24 2012 12:59:11 Hans Verkuil wrote:
> On Mon September 24 2012 12:44:11 Prabhakar wrote:
> > From: Lad, Prabhakar
> >
> > vpif_display relied on a 1-1 mapping of output and subdev. This is not
> > necessarily the case. Separate the two. So there is
On Mon September 24 2012 13:50:00 Hans Verkuil wrote:
> On Mon September 24 2012 12:59:11 Hans Verkuil wrote:
> > On Mon September 24 2012 12:44:11 Prabhakar wrote:
> > > From: Lad, Prabhakar
> > >
> > > vpif_display relied on a 1-1 mapping of output and subde
On Mon September 24 2012 14:53:40 Prabhakar wrote:
> From: Lad, Prabhakar
>
> Add helper function v4l2_ctrl_new_std_menu_items(), which adds
> a standard menu control, with driver specific menu.
Acked-by: Hans Verkuil
Regards,
Hans
>
> Signed-off-by: Lad, Prabhaka
On Mon September 24 2012 15:21:44 Prabhakar Lad wrote:
> Hi Hans,
>
> On Mon, Sep 24, 2012 at 5:20 PM, Hans Verkuil wrote:
> > On Mon September 24 2012 12:59:11 Hans Verkuil wrote:
> >> On Mon September 24 2012 12:44:11 Prabhakar wrote:
> >> > From: Lad, P
On Mon September 24 2012 14:53:41 Prabhakar wrote:
> From: Lad, Prabhakar
>
> add V4L2_CID_TEST_PATTERN of type menu, which determines
> the internal test pattern selected by the device.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Acked-by:
On Tue September 25 2012 07:38:12 Prabhakar Lad wrote:
> Hi Hans,
>
> On Mon, Sep 24, 2012 at 7:02 PM, Hans Verkuil wrote:
> > On Mon September 24 2012 15:21:44 Prabhakar Lad wrote:
> >> Hi Hans,
> >>
> >> On Mon, Sep 24, 2012 at 5:20 PM, Hans Verkuil
On Tue September 25 2012 08:09:05 Prabhakar wrote:
> From: Lad, Prabhakar
>
> add V4L2_CID_TEST_PATTERN of type menu, which determines
> the internal test pattern selected by the device.
Acked-by: Hans Verkuil
Regards,
Hans
>
> Signed-off-by: Lad, Prabhaka
and has routing
> information. An output does not have to have a subdev.
>
> The initial output for each channel is set to the fist output.
>
> Currently missing is support for associating multiple subdevs with
> an output.
>
Acked-by: Hans Verkuil
Looks good!
Regards,
On Tue 25 September 2012 13:16:24 Prabhakar wrote:
> From: Lad, Prabhakar
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> ---
> drivers/media/platform/davinci/vpif_capture.c |4 +++-
> drivers/media/platform/davinci/vpif_di
On Tue 25 September 2012 13:49:16 Laurent Pinchart wrote:
> Hi Hans,
>
> On Tuesday 25 September 2012 13:43:36 Hans Verkuil wrote:
> > On Tue 25 September 2012 13:16:24 Prabhakar wrote:
> > > From: Lad, Prabhakar
> > >
> > > Signed-off-by: Lad, Prabh
On Tue 25 September 2012 15:26:11 Prabhakar Lad wrote:
> Hi Hans/Laurent
>
> On Tue, Sep 25, 2012 at 5:24 PM, Hans Verkuil wrote:
> > On Tue 25 September 2012 13:49:16 Laurent Pinchart wrote:
> >> Hi Hans,
> >>
> >> On Tuesday 25 September 2012 13:
On 08/25/2013 05:45 PM, Knut Petersen wrote:
> Booting current git kernel dmesg shows a set of new warnings:
>
> "wm8775 9-001b: I2C: cannot write ??? to register R??"
>
> Nevertheless, the hardware seems to work fine.
>
> This is a new problem, introduced after kernel 3.10.
> If necessary
On 08/27/2013 11:35 AM, Knut Petersen wrote:
> On 27.08.2013 09:26, Hans Verkuil wrote:
>> On 08/25/2013 05:45 PM, Knut Petersen wrote:
>>> Booting current git kernel dmesg shows a set of new warnings:
>>>
>>> "wm8775 9-001b: I2C: cannot write ??? t
Hi Ricardo,
On 10/04/2013 03:49 PM, Ricardo Ribalda Delgado wrote:
> A video device opened and streaming in io emulator mode can only stop
> streamming if its file descriptor is closed.
>
> There are some parameters that can only be changed if the device is not
> streaming. Also, the power consum
al, so replace all occurrences of the
> former with the later.
>
> Signed-off-by: Lars-Peter Clausen
Acked-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/v4l2-core/tuner-core.c | 6 +++---
> drivers/media/v4l2-core/v4l2-common.c | 10 +-
> includ
the device.
> >
> > Signed-off-by: Lad, Prabhakar
> > Signed-off-by: Manjunath Hadli
> > Cc: Sakari Ailus
> > Cc: Hans Verkuil
> > Cc: Laurent Pinchart
> > Cc: Mauro Carvalho Chehab
> > Cc: Sylwester Nawrocki
> > Cc: Hans de Goede
> > C
On Mon September 10 2012 13:57:36 Prabhakar Lad wrote:
> From: Lad, Prabhakar
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> Cc: Sakari Ailus
> Cc: Sylwester Nawrocki
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
On Sat October 6 2012 03:54:57 Andrey Smirnov wrote:
> This patch adds all necessary header files and Kbuild plumbing for the
> core driver for Silicon Laboratories Si476x series of AM/FM tuner
> chips.
>
> The driver as a whole is implemented as an MFD device and this patch
> adds a core portion
On Sat October 6 2012 03:54:59 Andrey Smirnov wrote:
> This patch adds all the functions used for exchanging commands with
> the chip.
>
> Signed-off-by: Andrey Smirnov
> ---
> drivers/mfd/si476x-cmd.c | 1493
> ++
> 1 file changed, 1493 insertions(+)
Hi Manjunatha,
Can you make a v8? The tuner band issues have been settled and are now merged,
so it would be good to finalize this.
On Mon May 21 2012 19:12:01 manjunatha_ha...@ti.com wrote:
> From: Manjunatha Halli
>
> Mauro and the list,
>
> This version 7 of patchset resolves the comments r
On Sat October 6 2012 03:55:01 Andrey Smirnov wrote:
> This commit adds a driver that exposes all the radio related
> functionality of the Si476x series of chips via the V4L2 subsystem.
>
> Signed-off-by: Andrey Smirnov
> ---
> drivers/media/radio/Kconfig| 17 +
> drivers/media/radio/M
Hi Andrey!
On Sat October 6 2012 03:54:56 Andrey Smirnov wrote:
> This is a second version of the patchset originaly posted here:
> https://lkml.org/lkml/2012/9/13/590
>
> To save everyone's time I'll repost the original description of it:
>
>
> This patchset contains a driver for a Silicon Lab
Note: I'm CC-ing Halli. Halli, can you take a look at the proposed controls?
On Mon 8 October 2012 19:57:17 Andrey Smirnov wrote:
> On 10/08/2012 02:30 AM, Hans Verkuil wrote:
> > On Sat October 6 2012 03:55:01 Andrey Smirnov wrote:
> >> This commit adds a driver tha
On Mon 8 October 2012 22:06:29 Andrey Smirnov wrote:
> On 10/08/2012 01:56 AM, Hans Verkuil wrote:
> > On Sat October 6 2012 03:54:59 Andrey Smirnov wrote:
> >> This patch adds all the functions used for exchanging commands with
> >> the chip.
> >>
On Mon 8 October 2012 20:38:01 Andrey Smirnov wrote:
> On 10/08/2012 01:43 AM, Hans Verkuil wrote:
> > On Sat October 6 2012 03:54:57 Andrey Smirnov wrote:
> >> This patch adds all necessary header files and Kbuild plumbing for the
> >> core driver for Silicon Laborato
d, Prabhakar
> Cc: Sakari Ailus
> Cc: Laurent Pinchart
> Cc: Kyungmin Park
> Cc: Guennadi Liakhovetski
> Cc: Sylwester Nawrocki
> Cc: Hans Verkuil
> Cc: Hans de Goede
> Cc: Chris MacGregor
> Cc: Rob Landley
> Cc: Jeongtae Park
> Cc: Mauro Carvalho Chehab
&
se driver
> resources not to be released.
Acked-by: Hans Verkuil
Thanks!
Hans
> This was found using the following semantic patch
> (http://coccinelle.lip6.fr/):
>
>
> @r@
> identifier fops;
> identifier release_func;
> @@
> static const struct v4l2_file_operat
On Thu 6 December 2012 10:54:32 Sakari Ailus wrote:
> Hi Prabhakar and Hans,
>
> On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote:
> > Hi Hans,
> >
> > On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil wrote:
> > > (resend without HTML formatting)
&
On Tue 11 December 2012 09:56:42 Hans Verkuil wrote:
> On Thu 6 December 2012 10:54:32 Sakari Ailus wrote:
> > Hi Prabhakar and Hans,
> >
> > On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote:
> > > Hi Hans,
> > >
> > > On
On Wed December 26 2012 16:29:43 Kirill Smelkov wrote:
> Most of *_ops and other structures in vivi.c were already declared const
> but some have not. Constify and code/data will take less space:
>
> $ size drivers/media/platform/vivi.o
> textdata bss dec hex file
On Fri December 28 2012 14:12:56 Kirill Smelkov wrote:
> On Thu, Dec 27, 2012 at 12:55:11PM +0100, Hans Verkuil wrote:
> > On Wed December 26 2012 16:29:43 Kirill Smelkov wrote:
> > > Most of *_ops and other structures in vivi.c were already declared const
> > > but
Hi Andrey,
I'm really sorry for the long delay, but I finally have time to review v4 of
this
code.
On Tue October 23 2012 20:44:28 Andrey Smirnov wrote:
> This patch adds main part(out of three) of the I2C driver for the
> "core" of MFD device.
>
> Signed-off-by: Andrey Smirnov
> ---
> driver
Hi Andrey,
Some more comments...
On Tue October 23 2012 20:44:31 Andrey Smirnov wrote:
> This commit adds a driver that exposes all the radio related
> functionality of the Si476x series of chips via the V4L2 subsystem.
>
> Signed-off-by: Andrey Smirnov
> ---
> drivers/media/radio/Kconfig
On Wed 17 April 2013 14:22:15 Mauro Carvalho Chehab wrote:
> videobuf_queue_dma_contig_init_cached() is not used anywhere.
> Drop support for it, cleaning up the code a little bit.
>
> Signed-off-by: Mauro Carvalho Chehab
Nice!
Acked-by: Hans Verkuil
> ---
> drivers/media/
hree and
> don't
> support the audio device.
Looks great. I've got two remaining issues: replace strncpy with the safer
strlcpy
and a small problem in usbtv_queue_setup.
After fixing that you can add my
Acked-by: Hans Verkuil
to the patch.
Regards,
Hans
>
&
On Thu June 6 2013 12:05:38 Prabhakar Lad wrote:
> Hi Hans,
>
> On Sun, May 26, 2013 at 6:50 AM, Laurent Pinchart
> wrote:
> > On Saturday 25 May 2013 23:09:32 Prabhakar Lad wrote:
> >> From: Lad, Prabhakar
> >>
> >> Trivial cleanup of the driver.
> >>
> >> Changes for v2:
> >> 1: Dropped the as
On Fri May 31 2013 13:40:26 Jon Arne Jørgensen wrote:
> On video std change, the driver would disable the automatic field
> detection on the gm7113c chip, and force either 50Hz or 60Hz.
> Don't do this any more.
Sorry, I'm not entirely sure what is happening here. Why would the gm7113c
behave diff
On Fri May 31 2013 13:40:25 Jon Arne Jørgensen wrote:
> Implement i2c_board_info.platform_data handling in the driver so we can
> make device specific changes to the chips we support.
>
> Signed-off-by: Jon Arne Jørgensen
> ---
> drivers/media/i2c/saa7115.c | 101
>
t; >>
> >> Both synchronous and asynchronous tvp514x subdevice probing is supported by
> >> this patch.
> >>
> >> Signed-off-by: Prabhakar Lad
> >> Cc: Guennadi Liakhovetski
> >> Cc: Laurent Pinchart
> >> C
ies have been approved?
Hans
>
> Signed-off-by: Lad, Prabhakar
> Cc: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc: Guennadi Liakhovetski
> Cc: Sylwester Nawrocki
> Cc: Sakari Ailus
> Cc: linux-kernel@vger.kernel.org
> Cc: davinci-lin
Hi Prabhakar,
On Sat June 22 2013 17:03:03 Prabhakar Lad wrote:
> From: "Lad, Prabhakar"
>
> This patch adds video sync properties as part of endpoint
> properties and also support to parse them in the parser.
>
> Signed-off-by: Lad, Prabhakar
> Cc: Hans Verkui
On Mon June 24 2013 10:24:02 Prabhakar Lad wrote:
> Hi Hans,
>
> On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote:
> > On Sun June 23 2013 17:48:20 Prabhakar Lad wrote:
> >> Hi Guennadi,
> >>
> >> Thanks for the review.
> >>
> >
On Mon June 24 2013 10:53:37 Prabhakar Lad wrote:
> Hi Hans,
>
> On Mon, Jun 24, 2013 at 2:09 PM, Hans Verkuil wrote:
> > On Mon June 24 2013 10:24:02 Prabhakar Lad wrote:
> >> Hi Hans,
> >>
> >> On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote:
>
On Sat June 8 2013 19:29:41 Jon Arne Jørgensen wrote:
> On Fri, Jun 07, 2013 at 11:12:47AM +0200, Hans Verkuil wrote:
> > On Fri May 31 2013 13:40:25 Jon Arne Jørgensen wrote:
> > > Implement i2c_board_info.platform_data handling in the driver so we can
> > > make dev
Hi Lubomir!
Thanks for working on this.
I've got some review comments below...
On Mon June 10 2013 11:52:11 Lubomir Rintel wrote:
> Reverse-engineered driver for cheapo video digitizer, made from observations
> of
> Windows XP driver. The protocol is not yet completely understood, so far we
> d
Just as I sent my reply I realized that my notes w.r.t. field handling
were incomplete. So I'll try to clarify it below.
On Mon June 10 2013 13:05:04 Hans Verkuil wrote:
> Hi Lubomir!
>
> Thanks for working on this.
>
> I've got some review comments below...
>
&g
On Mon 10 June 2013 19:38:54 Lubomir Rintel wrote:
> On Mon, 2013-06-10 at 13:05 +0200, Hans Verkuil wrote:
> > > Also, I the hardware uses V4L2_FIELD_ALTERNATE interlacing, but I
> > > couldn't make
> > > it work,
> >
> > What didn't work exac
On Mon 10 June 2013 19:43:31 Lubomir Rintel wrote:
> Reverse-engineered driver for cheapo video digitizer, made from observations
> of
> Windows XP driver. The protocol is not yet completely understood, so far we
> don't provide any controls, only support a single format out of three and
> don't
> Signed-off-by: Prabhakar Lad
> Cc: Guennadi Liakhovetski
> Cc: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Sakari Ailus
> Cc: Mauro Carvalho Chehab
> ---
> drivers/media/platform/davinci/vpif_capture.c | 151
> +
> drivers/media/platfor
On Thu June 27 2013 08:13:40 Prabhakar Lad wrote:
> Hi Hans,
>
> Thanks for the review.
>
> On Thu, Jun 27, 2013 at 11:27 AM, Hans Verkuil wrote:
> > On Tue June 25 2013 17:17:34 Prabhakar Lad wrote:
> >> From: "Lad, Prabhakar"
> >>
> >
1 - 100 of 2036 matches
Mail list logo
