Re: [-mm patch] drivers/infiniband/hw/mthca/mthca_main.c: remove an unused label

2005-04-05 Thread Hal Rosenstock
On Tue, 2005-04-05 at 10:24, Adrian Bunk wrote: > On Tue, Apr 05, 2005 at 12:05:24AM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.12-rc1-mm4: > >... > > +ib-mthca-add-support-for-new-mt25204-hca.patch > > > > Infiniband update > >... > > > This patch causes the following compile war

[PATCH 0/27] InfiniBand core update

2005-07-11 Thread Hal Rosenstock
This patch series gets the Infiniband core up to date. Aside from bug fixes, the following new functionality is also introduced: MAD (Management Datagram) support for RMPP (Reliable MultiPacket Protocol) CM (Communications Manager) support User CM sup

[PATCH 1/27] Update FMR functions

2005-07-11 Thread Hal Rosenstock
Change some functions to return void rather than an int since they are always returning 0, thus making checking return values rather pointless. Signed-off-by: Tom Duffy <[EMAIL PROTECTED]> Signed-off-by: Libor Michalek <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[

[PATCH 2/27] Update MAD client API

2005-07-11 Thread Hal Rosenstock
Automatically allocate a MR when registering a MAD agent. MAD clients are modified to use this updated API. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> --- core/agent.c | 16 +-- core/agent_priv.h |3 +-- core/mad.c

[PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Hal Rosenstock
Add new helper routines for allocating MADs for sending and formatting a send WR. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 2/27. -- core/mad.c

[PATCH 5/27] Change saving of user's send wr_id in MAD

2005-07-11 Thread Hal Rosenstock
Move saving of user's send wr_id to better match layering of received response handling. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 4/27. -- mad.c |4 ++-- 1 files changed, 2 insertion

PATCH [7/27] Fix timeout/cancelled MAD handling

2005-07-11 Thread Hal Rosenstock
-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 6/27. -- mad.c | 14 -- mad_priv.h |1 + 2 files changed, 13 insertions(+), 2 deletions(-) diff -uprN linux-2.6.13-rc2-mm1/drivers/infiniband

[PATCH 9/27] Add ib_coalesce_recv_mad to MAD

2005-07-11 Thread Hal Rosenstock
Add implementation for ib_coalesce_recv_mad. Also, clear allocated MAD data buffer in ib_create_send_mad. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 8/27. -- core/mad.c |9 +-- include/ib_

[PATCH 11/27] Simplify calling of list_del in MAD

2005-07-11 Thread Hal Rosenstock
Simplify calling of list_del. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 10/27. -- mad.c |3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff -uprN linux-2.6.13-rc2-mm1/drivers/infiniband1

[PATCH 12/27] Eliminate MAD cache leak associated with local completions

2005-07-11 Thread Hal Rosenstock
Eliminate MAD cache leak associated with local completions. Also, when canceling MAD, empty local completion list as well. Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 11/27. -- mad.c |7 ++- 1 files changed, 6 insertions(+), 1 deletion(-) diff

[PATCH 13/27] Add ib_modify_mad API to MAD

2005-07-11 Thread Hal Rosenstock
Add new MAD layer call to modify (ib_modify_mad) the timeout of a sent MAD, and simplify cancel code. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 12/27. -- core/mad.c | 83 ++

[PATCH 14/27] Optimize canceling a MAD

2005-07-11 Thread Hal Rosenstock
Optimize canceling a MAD. - Eliminate searching timeout list in cancel case. - Remove duplicate calls to queue work item. - Eliminate resending a MAD before MAD is completed. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patc

[PATCH 17/27] A couple of IB core bug fixes

2005-07-11 Thread Hal Rosenstock
Replace be32_to_cpup with be32_to_cpu and fix bug referencing pointer rather than value in ib_create_ah_from_wc(). Signed-off-by: Tom Duffy <[EMAIL PROTECTED]> Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depe

[PATCH 18/27] Introduce RMPP APIs

2005-07-11 Thread Hal Rosenstock
Introduce RMPP APIs Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 17/27. -- core/mad.c |4 + core/sa_query.c | 20 -- include/ib_

[PATCH 19/27] Add RMPP implementation

2005-07-11 Thread Hal Rosenstock
Add RMPP implementation Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 18/27. -- Makefile |2 mad.c | 167 +-- mad_priv.h | 28 +- mad_r

[PATCH 20/27] Add Service Record support to SA client

2005-07-11 Thread Hal Rosenstock
Add Service Record support to SA client Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 19/27. -- core/sa_query.c | 166 +++- include/ib_sa.h | 75 - 2 files changed, 236 inse

[PATCH 21/27] Add the header file for kernel CM (Communications Manager)

2005-07-11 Thread Hal Rosenstock
Add the header file for kernel CM (Communications Manager) Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> -- ib_cm.h | 568 1 files changed, 568 insertions(+) diff

[PATCH 23/27] User MAD ABI changes to support RMPP

2005-07-11 Thread Hal Rosenstock
User MAD ABI changes to support RMPP Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 22/27. -- ib_user_mad.h | 28 ++-- 1 files changed, 22 insertions(+), 6 deletions(-) user_mad.txt | 51 +++-- 1

[PATCH 24/27] Implementation for RMPP support in user MAD

2005-07-11 Thread Hal Rosenstock
Implementation for RMPP support in user MAD Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 23/27. -- user_mad.c | 300 +++-- 1 files changed, 194 insertions(+), 106 deletions(-) diff -uprN linux-2.6.13-rc2-mm1/d

[PATCH 26/27] Add kernel portion of user CM implementation

2005-07-11 Thread Hal Rosenstock
Add kernel portion of user CM implementation Signed-off-by: Libor Michalek <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 25/27. -- ucm.c | 1396 ++ ucm.h | 89 +

[PATCH 27/27] Hook up userspace CM to the make system

2005-07-11 Thread Hal Rosenstock
Hook up userspace CM to the make system Signed-off-by: Libor Michalek <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 26/27. -- Makefile |4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) diff -uprN linux-2.6.13-rc2

Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Hal Rosenstock
On Mon, 2005-07-11 at 12:05, Nishanth Aravamudan wrote: > On 11.07.2005 [11:30:23 -0400], Hal Rosenstock wrote: > > On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: > > > On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > > > > -- linux-2.6.13-rc2-mm1/

Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Hal Rosenstock
On Mon, 2005-07-11 at 12:29, Alexey Dobriyan wrote: > On Monday 11 July 2005 19:30, Hal Rosenstock wrote: > > On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: > > > On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > > > > Add new helper routines for allocating M

Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Hal Rosenstock
On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: > On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > > Add new helper routines for allocating MADs for sending and formatting > > a send WR. > > > -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c > > ++

[PATCH 25/27] Add the header file for user space CM

2005-07-11 Thread Hal Rosenstock
Add the header file for user space CM. This file defines the ABI used by the CM for kernel/user communication. Signed-off-by: Libor Michalek <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> -- ib_user

[PATCH 0/29v2] InfiniBand core update

2005-07-11 Thread Hal Rosenstock
This is version 2 of a patch series to get the Infiniband core up to date. Aside from bug fixes, the following new functionality is also introduced: MAD (Management Datagram) support for RMPP (Reliable MultiPacket Protocol) CM (Communications Manager) suppo

[PATCH 1/29v2] Update FMR functions

2005-07-11 Thread Hal Rosenstock
Change some functions to return void rather than an int since they are always returning 0, thus making checking return values rather pointless. Signed-off-by: Tom Duffy <[EMAIL PROTECTED]> Signed-off-by: Libor Michalek <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[

[PATCH 2/29v2] Update MAD client API

2005-07-11 Thread Hal Rosenstock
Automatically allocate a MR when registering a MAD agent. MAD clients are modified to use this updated API. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> -- core/agent.c | 16 +-- core/agent_priv.h |3 +-- core/mad.c

[PATCH 3/29v2] Add MAD helper functions

2005-07-11 Thread Hal Rosenstock
Add new helper routines for allocating MADs for sending and formatting a send WR. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 2/29. -- core/mad.c

[PATCH 5/29v2] Change saving of user's send wr_id in MAD

2005-07-11 Thread Hal Rosenstock
Move saving of user's send wr_id to better match layering of received response handling. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 4/29. -- mad.c |4 ++-- 1 files changed, 2 insertion

[PATCH 4/29v2] Combine some MAD routines

2005-07-11 Thread Hal Rosenstock
Combine response_mad() and solicited_mad() routines into a single function and simplify/encapsulate its usage. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 3/29. -- mad.c | 105 -- 1 f

[PATCH 7/29v2] Fix timeout/cancelled MAD handling

2005-07-11 Thread Hal Rosenstock
-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 6/29. -- mad.c | 14 -- mad_priv.h |1 + 2 files changed, 13 insertions(+), 2 deletions(-) diff -uprN linux-2.6.13-rc2-mm1-6/drivers/infiniban

[PATCH 8/29v2] Minor cleanup during MAD startup and shutdown

2005-07-11 Thread Hal Rosenstock
Minor cleanup during startup and shutdown Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 7/29. -- mad.c | 44 +-- 1 files changed, 9 insertions(+), 35 deletions(-) diff -uprN linux-2.6.13-rc2-mm1-7/drivers/infiniband/core/mad.c linux-2.6.13-rc2

PATCH 9/29v2] Add ib_coalesce_recv_mad to MAD

2005-07-11 Thread Hal Rosenstock
Add implementation for ib_coalesce_recv_mad. Also, clear allocated MAD data buffer in ib_create_send_mad. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 8/29. -- core/mad.c |9 +-- include/ib_

[PATCH 12/29v2] Eliminate MAD cache leak associated with local completions

2005-07-11 Thread Hal Rosenstock
Eliminate MAD cache leak associated with local completions. Also, when canceling MAD, empty local completion list as well. Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 11/29. -- mad.c |7 ++- 1 files changed, 6 insertions(+), 1 deletion(-) diff

[PATCH 13/29v2] Add ib_modify_mad API to MAD

2005-07-11 Thread Hal Rosenstock
Add new MAD layer call to modify (ib_modify_mad) the timeout of a sent MAD, and simplify cancel code. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 12/29. -- core/mad.c | 83 ++

[PATCH 15/29v2] Fix a couple of MAD code paths

2005-07-11 Thread Hal Rosenstock
Fixed locking to handle error posting MAD send work requests. Fixed handling canceling a MAD with an active work request. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 14/29. -- mad.c | 28 +++

[PATCH 16/29v2] Add ib_create_ah_from_wc to IB verbs

2005-07-11 Thread Hal Rosenstock
Added new call: ib_create_ah_from_wc. Call will allocate an address handle given work completion information, including any received GRH. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 15/29. --

[PATCH 17/29v2] A couple of IB core bug fixes

2005-07-11 Thread Hal Rosenstock
Replace be32_to_cpup with be32_to_cpu and fix bug referencing pointer rather than value in ib_create_ah_from_wc(). Signed-off-by: Tom Duffy <[EMAIL PROTECTED]> Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depe

[PATCH 18/29v2] Introduce RMPP APIs

2005-07-11 Thread Hal Rosenstock
Introduce RMPP APIs Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 17/29. -- core/mad.c |4 + core/sa_query.c | 20 -- include/ib_

[PATCH 19/29v2] Add RMPP implementation

2005-07-11 Thread Hal Rosenstock
Add RMPP implementation Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 18/29. -- Makefile |2 mad.c | 167 +-- mad_priv.h | 28 +- mad_r

[PATCH 21/29v2] Add the header file for kernel CM (Communications Manager)

2005-07-11 Thread Hal Rosenstock
Add the header file for kernel CM (Communications Manager) Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 20/29. -- ib_cm.h | 568 1 files

[PATCH 23/29v2] User MAD ABI changes to support RMPP

2005-07-11 Thread Hal Rosenstock
User MAD ABI changes to support RMPP Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 22/29. -- Documentation/infiniband/user_mad.txt| 51 +++-- drivers/infiniband/include/ib_user_mad.h | 28 +-- 2 files chang

[PATCH 24/29v2] Implementation for RMPP support in user MAD

2005-07-11 Thread Hal Rosenstock
Implementation for RMPP support in user MAD Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 23/29. -- user_mad.c | 300 +++-- 1 files changed, 194 insertions(+), 106 deletions(-) diff -uprN linux-2.6.13-rc2-mm1-23/d

[PATCH 25/29v2] Add the header file for user space CM

2005-07-11 Thread Hal Rosenstock
Add the header file for user space CM. This file defines the ABI used by the CM for kernel/user communication. Signed-off-by: Libor Michalek <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> -- ib_user

[PATCH 26/29v2] Add kernel portion of user CM implementation

2005-07-11 Thread Hal Rosenstock
Add kernel portion of user CM implementation Signed-off-by: Libor Michalek <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 25/29. -- ucm.c | 1396 ++ ucm.h | 89 +

[PATCH 27/29v2] Hook up userspace CM to the make system

2005-07-11 Thread Hal Rosenstock
Hook up userspace CM to the make system Signed-off-by: Libor Michalek <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 26/29. -- Makefile |4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) diff -uprN linux-2.6.13-rc2-mm

[PATCH 29/29v2] Add core locking documentation to Infiniband

2005-07-11 Thread Hal Rosenstock
Add core locking documentation to Infiniband Signed-off-by: Roland Dreier <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> -- core_locking.txt | 114 +++ 1 files changed, 114 insertions(+) diff -uprN linux-2.

[PATCH 28/29v2] Eliminate sparse warnings in SA client

2005-07-11 Thread Hal Rosenstock
Eliminate sparse warnings in SA client Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 20/29. -- core/sa_query.c |6 +++-- include/ib_sa.h | 10 +-- 2 files changed, 8 insertions(+), 8 deletions(-) diff -uprN linux-2.6.13-rc2-mm1-27/drivers/infi

[PATCH 20/29v2] Add Service Record support to SA client

2005-07-11 Thread Hal Rosenstock
Add Service Record support to SA client Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 19/29. -- core/sa_query.c | 166 +++- include/ib_sa.h | 75 - 2 files changed, 236 inse

Re: [openib-general] [PATCH 26/29v2] Add kernel portion of user CM implementation

2005-07-11 Thread Hal Rosenstock
On Mon, 2005-07-11 at 17:19, Tom Duffy wrote: > On Mon, 2005-07-11 at 16:59 -0400, Hal Rosenstock wrote: > > Add kernel portion of user CM implementation > > Hal, does this compile? As it doesn't seem to include the patch I sent > to openib-general changing class_simple

[PATCH 14/29v2] Optimize canceling a MAD

2005-07-11 Thread Hal Rosenstock
Optimize canceling a MAD. - Eliminate searching timeout list in cancel case. - Remove duplicate calls to queue work item. - Eliminate resending a MAD before MAD is completed. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patc

[PATCH 10/29v2] Add automatic retries to MAD layer

2005-07-11 Thread Hal Rosenstock
Add automatic retries to MAD layer. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 9/29. -- core/mad.c | 26 +- core/mad_priv.h|2 ++ core/sa_query.c|

[PATCH 11/29v2] Simplify calling of list_del in MAD

2005-07-11 Thread Hal Rosenstock
Simplify calling of list_del. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 10/29. -- mad.c |3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff -uprN linux-2.6.13-rc2-mm1-10/drivers/inf

[PATCH 6/29v2] Change ib_mad_send_wr_private struct

2005-07-11 Thread Hal Rosenstock
Have ib_mad_send_wr_private reference the private agent structure directly, rather than the exposed agent definition. Remove unneeded parameters to functions and simplify code were possible from this change. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock &

[PATCH 16/27] Add ib_create_ah_from_wc to IB verbs

2005-07-11 Thread Hal Rosenstock
Added new call: ib_create_ah_from_wc. Call will allocate an address handle given work completion information, including any received GRH. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 15/27. --

[PATCH 15/27] Fix a couple of MAD code paths

2005-07-11 Thread Hal Rosenstock
Fixed locking to handle error posting MAD send work requests. Fixed handling canceling a MAD with an active work request. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 14/27. -- mad.c | 28 +++

[PATCH 10/27] Add automatic retries to MAD layer

2005-07-11 Thread Hal Rosenstock
Add automatic retries to MAD layer. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 9/27. -- core/mad.c | 26 +- core/mad_priv.h|2 ++ core/sa_query.c|

[PATCH 8/27] Minor cleanup during MAD startup and shutdown

2005-07-11 Thread Hal Rosenstock
Minor cleanup during startup and shutdown Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 7/27. -- mad.c | 44 +-- 1 files changed, 9 insertions(+), 35 deletions(-) diff -uprN linux-2.6.13-rc2-mm1/drivers/infiniband7/core/mad.c linux-2.6.13-r

PATCH [6/27] Change ib_mad_send_wr_private struct

2005-07-11 Thread Hal Rosenstock
Have ib_mad_send_wr_private reference the private agent structure directly, rather than the exposed agent definition. Remove unneeded parameters to functions and simplify code were possible from this change. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock &

[PATCH 4/27] Combine some MAD routines

2005-07-11 Thread Hal Rosenstock
Combine response_mad() and solicited_mad() routines into a single function and simplify/encapsulate its usage. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 3/27. -- mad.c | 105 -- 1 f

Re: [PATCH 0/29v2] InfiniBand core update

2005-07-11 Thread Hal Rosenstock
On Mon, 2005-07-11 at 20:05, Andrew Morton wrote: > Hal Rosenstock <[EMAIL PROTECTED]> wrote: > > > > This is version 2 of a patch series to get the Infiniband core up to > > date. > > Well that was interesting. > > - All the patches had mangled h

Re: [PATCH 0/29v2] InfiniBand core update

2005-07-12 Thread Hal Rosenstock
On Mon, 2005-07-11 at 23:12, David S. Miller wrote: > Please acknowledge that you understand how inappropriate > and problem causing your huge patch bomb was today to this > mailing list. > > It is nearly 8 hours later, and vger.kernel.org is still > trying mightily to spit out all of your patches

Re: [PATCH 0/29v2] InfiniBand core update

2005-07-12 Thread Hal Rosenstock
On Mon, 2005-07-11 at 23:11, Andrew Morton wrote: > Well I was asking. Do you guys think that this material is appropriate to > and safe enough for 2.6.13? We think so. > What are "user CM" and "kernel CM"? CM is the InfiniBand Communications Manager. It is (primarily) responsible for setting u

Re: [PATCH 0/29v2] InfiniBand core update

2005-07-12 Thread Hal Rosenstock
On Mon, 2005-07-11 at 23:11, Andrew Morton wrote: > Well I was asking. Do you guys think that this material is appropriate to > and safe enough for 2.6.13? I used your versions of the patches (Tom's ucm one is needed and you added that). I also back ported the trailing whitespace elimination chan

Re: [PATCH 0/29v2] InfiniBand core update

2005-07-12 Thread Hal Rosenstock
On Tue, 2005-07-12 at 18:38, Andrew Morton wrote: > OK, well the timing of a merge is mainly up to you guys, especially as the > subsystem is pretty raw and you're the only people who use it ;) > > Two things from a quick scan: > > a) In many places the patch does > > if (p) >

RE: [ofa-general] InfiniBand/RDMA merge plans for 2.6.25

2008-01-18 Thread Hal Rosenstock
On Fri, 2008-01-18 at 09:42 -0800, Sean Hefty wrote: > >> Sean Hefty (6): > >> IB/mad: Fix incorrect access to items on local_list > > > >It wasn't clear to me that this issue was ever really nailed. Was the > >loop on this closed ? > > The error that this patches addresses is fairly obvious

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.25

2008-01-18 Thread Hal Rosenstock
On Thu, 2008-01-17 at 16:11 -0800, Roland Dreier wrote: > Here all the patches I already have in my for-2.6.25 branch: > Sean Hefty (6): > IB/mad: Fix incorrect access to items on local_list It wasn't clear to me that this issue was ever really nailed. Was the loop on this closed ? -- Hal

Re: [ofa-general] Further 2.6.23 merge plans...

2007-07-12 Thread Hal Rosenstock
On Thu, 2007-07-12 at 19:15, Roland Dreier wrote: > As you can see, I just sent my first 2.6.23 pull request for Linus. > There are still a few more things I plan to do in before the merge > window closes (in ~10 days): > > - Write a patch to add P_Key handling to user_mad in the way we >disc

Re: [ofa-general] [PATCH] eHCA: Add "Modify Port" verb

2007-04-23 Thread Hal Rosenstock
Hi Joachim, On Mon, 2007-04-23 at 12:23, Joachim Fenkes wrote: > Add "Modify Port" verb support to eHCA driver. > ib_cm needs this to initialize properly. > > > Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> > --- > > ehca_hca.c | 48 ++-- > hcp

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

2017-10-27 Thread Hal Rosenstock
On 10/27/2017 2:32 PM, Parav Pandit wrote: > However I believe that ibstat tool should be enhanced to report unknown port > speed instead of expecting drivers to supply some random number like this. ibstat gets the rate from libibumad via /sys/class/infiniband//ports//rate file which is supposed

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

2017-10-27 Thread Hal Rosenstock
On 10/27/2017 4:33 PM, Parav Pandit wrote: > > >> -Original Message----- >> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] >> Sent: Friday, October 27, 2017 3:19 PM >> To: Parav Pandit ; Thomas Bogendoerfer >> ; Matan Barak ; Leon >&

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

2017-10-27 Thread Hal Rosenstock
On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote: > When running ibstat (if transceiver is not connected in adapter): > > ibpanic: [7851] main: stat of IB device 'mlx5_1' failed: Invalid argument Any output before that ? I'm trying to understand how far it gets. It looks to me that empty rate fi

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

2017-10-27 Thread Hal Rosenstock
On 10/27/2017 7:04 PM, Ghazale Hosseinabadi wrote: > > > On 10/27/2017 03:52 PM, Hal Rosenstock wrote: >> On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote: >>> When running ibstat (if transceiver is not connected in adapter): >>> >>> ibpanic: [785

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

2017-10-27 Thread Hal Rosenstock
On 10/27/2017 7:19 PM, Hal Rosenstock wrote: > On 10/27/2017 7:04 PM, Ghazale Hosseinabadi wrote: >> >> >> On 10/27/2017 03:52 PM, Hal Rosenstock wrote: >>> On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote: >>>> When running ibstat (if transceiver is no

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

2017-10-28 Thread Hal Rosenstock
On 10/28/2017 6:42 AM, Thomas Bogendoerfer wrote: >> I must be missing something as to what is going on in this scenario. I think I see what's going on now. The -EINVAL in kernel sysfs/rate_show causes error to either open or read of file. I had checked that an empty file is parsed correctly but d

Re: [PATCH] Documentation/ABI: update infiniband sysfs interfaces

2018-02-01 Thread Hal Rosenstock
On 2/1/2018 8:32 AM, Aishwarya Pant wrote: > Add documentation for core and hardware specific infiniband interfaces. > The descriptions have been collected from git commit logs, reading > through code and data sheets. Some drivers have incomplete doc and are > annotated with the comment '[to be doc

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

2018-05-11 Thread Hal Rosenstock
On 5/11/2018 6:55 AM, Håkon Bugge wrote: > > >> On 10 May 2018, at 18:54, Hal Rosenstock wrote: >> >> On 5/10/2018 11:16 AM, Håkon Bugge wrote: >>> >>> >>>> On 10 May 2018, at 16:01, Hal Rosenstock wrote: >>>> >>>>

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-15 Thread Hal Rosenstock
On 4/13/2015 8:22 AM, Michael Wang wrote: > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index 65994a1..d54f91e 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -75,10 +75,13 @@ enum rdma_node_type { > }; > > enum rdma_transport_type { > + /* l

Re: [PATCH v3 10/28] IB/Verbs: Reform cm related part in IB-core cma

2015-04-15 Thread Hal Rosenstock
On 4/13/2015 3:50 PM, Jason Gunthorpe wrote: > Less clear is how rocee vs ib work within a device... Can you APM > between those two kinds of ports? The specs allow this to work but AFAIK it's not implemented. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body o

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-16 Thread Hal Rosenstock
On 4/15/2015 4:33 PM, ira.weiny wrote: > On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote: >> On 4/13/2015 8:22 AM, Michael Wang wrote: >>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h >>> index 65994a1..d54f91e 100644 >>> ---

Re: [PATCH v4 04/27] IB/Verbs: Reform IB-core cm

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 4:05 AM, Michael Wang wrote: > > Use raw management helpers to reform IB-core cm. > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang > --- > drivers/infiniband/core/cm.c | 22

Re: [PATCH v4 03/27] IB/Verbs: Reform IB-core mad/agent/user_mad

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 4:05 AM, Michael Wang wrote: > > Use raw management helpers to reform IB-core mad/agent/user_mad. > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang > --- > drivers/infiniband/core/agent.

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 4:08 AM, Michael Wang wrote: > > Use raw management helpers to reform cm related part in IB-core cma/ucm. > > These checks focus on the device cm type rather than the port capability, > directly pass port 1 works currently, but can't support mixing cm type > device in future. This i

Re: [PATCH v4 14/27] IB/Verbs: Reform cma_acquire_dev()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 4:09 AM, Michael Wang wrote: > > Reform cma_acquire_dev() with management helpers, introduce > cma_validate_port() to make the code more clean. > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 4:15 AM, Michael Wang wrote: > > We have get rid of all the scene using legacy rdma_node_get_transport(), > now clean it up. > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang > --- > dri

Re: [PATCH v4 20/27] IB/Verbs: Use management helper cap_ib_sa()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 4:12 AM, Michael Wang wrote: > > Introduce helper cap_ib_sa() to help us check if the port of an > IB device support Infiniband Subnet Administrator. Nit: Administrator -> Administration > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Wein

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 9:41 AM, Michael Wang wrote: > > > On 04/16/2015 03:36 PM, Hal Rosenstock wrote: > [snip] >>> -EXPORT_SYMBOL(rdma_node_get_transport); >>> - >>> enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *device, u8 >>> por

Re: [PATCH v4 14/27] IB/Verbs: Reform cma_acquire_dev()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 9:35 AM, Michael Wang wrote: > > > On 04/16/2015 03:19 PM, Hal Rosenstock wrote: > [snip] >>> >>> +static inline int cma_validate_port(struct ib_device *device, u8 port, >>> + union ib_gid *gid, int

Re: [PATCH v3 25/28] IB/Verbs: Use management helper cap_af_ib()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 9:57 AM, Or Gerlitz wrote: > On Mon, Apr 13, 2015 at 3:35 PM, Michael Wang > wrote: >> >> Introduce helper cap_af_ib() to help us check if the port of an >> IB device support Native Infiniband Address. >> >> Cc: Steve Wise >> Cc: Tom Talpey >> Cc: Jason Gunthorpe >> Cc: Doug Ledfo

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 11:58 AM, Jason Gunthorpe wrote: > It also looks like hardwired 1 won't work on switch ports, so it is no-go. AFAIK enhanced switch port 0 is not supported by CM/RDMA CM in the current code. There is no need for CM/RDMA CM on base switch port 0. -- To unsubscribe from this list: send

Re: [PATCH v5 04/27] IB/Verbs: Reform IB-core cm

2015-04-20 Thread Hal Rosenstock
On 4/20/2015 4:33 AM, Michael Wang wrote: > > Use raw management helpers to reform IB-core cm. > > Cc: Hal Rosenstock > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

2018-05-14 Thread Hal Rosenstock
On 5/14/2018 5:02 PM, Jason Gunthorpe wrote: > On Thu, May 10, 2018 at 05:16:28PM +0200, Håkon Bugge wrote: > >> We are talking about two things here. The PKey in the BTH and the >> PKey in the CM REQ payload. They differ. >> >> I am out of office, but if my memory serves me correct, the PKey in >

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

2018-05-16 Thread Hal Rosenstock
On 5/16/2018 11:12 AM, Jason Gunthorpe wrote: > On Wed, May 16, 2018 at 08:47:21AM +0200, Håkon Bugge wrote: > >>> This is not a difficult issue. >>> >>> If the GMP is properly tagged with the right PKey then it will never >>> be delivered to the VM if the VM does not have the PKey in the >>> tabl

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

2018-05-16 Thread Hal Rosenstock
On 5/16/2018 3:22 PM, Håkon Bugge wrote: > But, do we need an update to IBTA (that the BTH.PKey shall be that of the > VM's Port)? Nothing in spec mentions shared (port) virtualization so that is an exercise completely left to the reader... Annex A19 is silent on this specific point but the virt

Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

2015-09-30 Thread Hal Rosenstock
On 9/30/2015 2:01 AM, ira.we...@intel.com wrote: > From: Ira Weiny > > This interface has no current users and is obsolete. There are no in tree users of this but there is Sean's madeye tool (which is out of tree). This is still a useful debug tool for MADs. > Signed-off-by: Ira Weiny > --- >

Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

2015-09-30 Thread Hal Rosenstock
On 9/30/2015 12:32 PM, Weiny, Ira wrote: >> >> On 9/30/2015 2:01 AM, ira.we...@intel.com wrote: >>> From: Ira Weiny >>> >>> This interface has no current users and is obsolete. >> >> There are no in tree users of this but there is Sean's madeye tool (which is >> out >> of tree). This is still a u

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

2018-05-09 Thread Hal Rosenstock
On 5/9/2018 5:30 AM, Håkon Bugge wrote: > There is no point in using RDMA CM to establish a connection between > two QPs that cannot possible communicate. Particularly, if both the > active and passive side use limited pkeys, they are not able to > communicate. > > In order to detect this situatio

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

2018-05-10 Thread Hal Rosenstock
On 5/10/2018 5:16 AM, Håkon Bugge wrote: > > >> On 9 May 2018, at 13:28, Hal Rosenstock wrote: >> >> On 5/9/2018 5:30 AM, Håkon Bugge wrote: >>> There is no point in using RDMA CM to establish a connection between >>> two QPs that cannot possi

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

2018-05-10 Thread Hal Rosenstock
On 5/10/2018 11:16 AM, Håkon Bugge wrote: > > >> On 10 May 2018, at 16:01, Hal Rosenstock wrote: >> >> On 5/10/2018 5:16 AM, Håkon Bugge wrote: >>> >>> >>>> On 9 May 2018, at 13:28, Hal Rosenstock wrote: >>>> >>>> On

  1   2   >