Hello all,
I was just trying a allyesconfig build of next-20121126 and got this:
CC fs/cifs/cifs_debug.o
In function 'copy_from_user',
inlined from 'cifs_security_flags_proc_write' at fs/cifs/cifs_debug.c:593:
/home/bigguiness/src/git/linux-next/arch/x86/include/asm/uaccess_32.h:211:
Hello all,
Another build failure with next-20121126:
CC security/integrity/evm/evm_secfs.o
In function 'copy_from_user',
inlined from 'evm_write_key' at security/integrity/evm/evm_secfs.c:71:
/home/bigguiness/src/git/linux-next/arch/x86/include/asm/uaccess_32.h:211:
error: call to 'co
On Friday, March 15, 2013 7:20 PM, Ryan Mallon wrote:
> On 16/03/13 12:03, H Hartley Sweeten wrote:
>
>> Remove the __init tag from ep93xxbl_probe() to fix the section
>> mismatch warning.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: Ryan Mallon
>>
On Wednesday, March 20, 2013 9:04 AM, Joe Perches wrote:
> On Wed, 2013-03-20 at 15:29 +, Al Viro wrote:
>> On Wed, Mar 20, 2013 at 03:47:53PM +0300, Dan Carpenter wrote:
>>
>>> The original code here needs to broken up into functions so it isn't
>>> squashed up against the 80 character limit.
On Monday, February 04, 2013 5:59 AM, Dan Carpenter wrote:
> On Sun, Feb 03, 2013 at 10:54:37PM +0100, Peter Huewe wrote:
>> Since data can only be 0x, 0x0035 or 0x0048 we can simply skip the
>> bit shifting and masking as data & 0xFF is always equal to data and
>> data & 0xFF00 is always 0.
>>
Introduce the module_pcmcia_driver() macro which is a convenience macro
for pcmcia driver modules. It is intended to be used by pcmcia drivers
with init/exit sections that do nothing but register/unregister the
pcmcia driver.
Signed-off-by: H Hartley Sweeten
---
include/pcmcia/ds.h | 12
Introduce a new helper macro to remove the module boilerplate code
in pcmcia drivers.
Use the new macro throughout the tree where possible.
H Hartley Sweeten (11):
pcmcia/ds.h: introduce helper for pcmcia_driver module boilerplate
drivers/ata: use module_pcmcia_driver() in pcmcia drivers
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
drivers/bluetooth/bluecard_cs.c | 15 +--
drivers/bluetooth/bt3c_cs.c | 15 +--
drivers/bluetooth/btuart_cs.c | 15
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
drivers/ata/pata_pcmcia.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/ata/pata_pcmcia.c b/drivers
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
drivers/isdn/hardware/avm/avm_cs.c | 14 +-
drivers/isdn/hisax/avma1_cs.c | 14 +-
drivers/isdn/hisax/elsa_cs.c
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
drivers/parport/parport_cs.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/parport/parport_cs.c b
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
Cc: "Juergen E. Fischer"
Cc: "James E.J. Bottomley"
Cc: YOKOTA Hiroshi
Cc: linux-s...@vger.kernel.org
---
drivers/scsi/pcmcia
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
sound/pcmcia/pdaudiocf/pdaudiocf.c | 15 +--
sound/pcmcia/vx/vxpocket.c | 14 +-
2 files changed, 2 insertions
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Add a comment in drivers/net/wireless/b43/pcmcia.c about why that
driver does not use the new macro.
Signed-off-by: H Hartley Sweeten
---
drivers/net/arcnet/com20020_cs.c
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
drivers/mmc/host/sdricoh_cs.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/mmc/host
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-ser...@vger.kernel.org
---
drivers/tty/serial/8250/serial_cs.c | 14 +-
1 file changed
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
Cc: Greg Kroah-Hartman
Cc: linux-...@vger.kernel.org
---
drivers/usb/host/sl811_cs.c | 15 +--
1 file changed, 1 insertion(+), 14
On Tuesday, January 29, 2013 4:42 PM, Peter Hüwe wrote:
> Hi,
>
> while analyzing the comedi drivers, I noticed that quite a lot of them use a
> more or less similar find_boardinfo function.
> The names and the exact implementation differ slightly, but in most cases it
> boils down to:
>
27;s patch to enable comedi for
all architectures... :-)
Reviewed-by: H Hartley Sweeten
On Wednesday, January 30, 2013 4:04 AM, Ian Abbott wrote:
> One way is to enumerate the possible indices of the custom board array
> as a set of enum constants, initialize the custom board array using
> designated element initializers (indexed by the enum constants) and
> include the same enum c
On Thursday, March 14, 2013 12:33 PM, Geert Uytterhoeven wrote:
> On Tue, Mar 12, 2013 at 11:21 PM, Greg Kroah-Hartman
> wrote:
>> On Tue, Mar 12, 2013 at 11:13:50PM +0100, Geert Uytterhoeven wrote:
>>> m68k/allmodconfig:
>>>
>>> drivers/staging/comedi/drivers/ni_atmio.c: In function
>>> ‘ni_isa
On Friday, March 15, 2013 2:41 AM, Ian Abbott wrote:
> On 2013-03-15 08:14, Kumar Amit Mehta wrote:
>> fix a missing end-of-statement by adding a semicolon.
>>
>> Signed-off-by: Kumar Amit Mehta
>> ---
>> drivers/staging/comedi/drivers/ni_atmio.c |2 +-
>> 1 file changed, 1 insertion(+), 1
On Thursday, March 14, 2013 6:58 AM, Arnd Bergmann wrote:
> On Thursday 14 March 2013, Fabio Porcedda wrote:
>> This patch converts the drivers to use the
>> module_platform_driver_probe() macro which makes the code smaller and
>> a bit simpler.
>>
>> Signed-off-by: Fabio Porcedda
>> Cc: Greg Kro
533: warning: assignment makes pointer from integer
without a cast
Include to pickup the declaration of 'devm_ioremap'.
Signed-off-by: H Hartley Sweeten
Cc:
Cc: Florian Tobias Schandinat
Cc: Ryan Mallon
Cc: Damien Cassou
---
drivers/video/ep93xx-fb.c | 1 +
1 file changed, 1 inserti
Remove the __init tag from ep93xxbl_probe() to fix the section
mismatch warning.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Richard Purdie
Cc: Florian Tobias Schandinat
---
drivers/video/backlight/ep93xx_bl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a
Remove the __init tags from the ep93xx_pwm_probe() and
ep93xx_pwm_remove() functions to fix the section mismatch
warnings.
Use module_platform_driver() to remove the init/exit boilerplate.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
---
drivers
Fix a couple section mismatch warnings and convert two of the ep93xx
drivers to use module_platform_driver.
H Hartley Sweeten (3):
backlight: ep93xx_bl: fix section mismatch
video: ep93xx-fb.c: fix section mismatch and use module_platform_driver
misc: ep93xx_pwm.c: fix section mismatch and
Remove the __init tags from the ep93xxfb_calc_fbsize() and
ep93xxfb_alloc_videomem() functions to fix the section mismatch
warnings.
Use module_platform_driver() to remove the init/exit boilerplate.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Florian Tobias Schandinat
---
drivers
On Tuesday, September 04, 2012 11:34 AM, Greg KH wrote:
> On Mon, Aug 20, 2012 at 04:59:16PM -0700, H Hartley Sweeten wrote:
>> Convert all the comedi_subdevice pointer access from pointer
>> math to array access.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc:
Remove a couple of the addi-data files that are either not built under any
configuration or are unnecessary due to code duplication in another file.
H Hartley Sweeten (3):
staging: comedi: addi_apci_all.c: remove unused file
staging: comedi: amcc_s5933_58.h: remove unused file
staging
The Makefile for the comedi subsystem does not compile this file
for any .config selection. This file would allow building one big
driver to support all the addi-data cards.
The addi-data drivers are a big enough mess as-is. Just remove this
file.
Signed-off-by: H Hartley Sweeten
Cc: Iam Abbott
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/addi_amcc_S5920.c | 195 -
.../comedi/drivers/addi-data/addi_amcc_S5920.h | 27 ---
.../comedi/drivers/addi-data/hwdrv_apci3200.c | 12 +-
3 files
Nothing in the comedi subsystem references this header file. It's
actually almost a straight copy of the addi_amcc_s5933.h file anyway.
Just remove the file.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/amcc_s5933_58.h
nclude/linux/platform_data/dma-ep93xx.h (100%)
> rename arch/arm/mach-ep93xx/include/mach/ep93xx_keypad.h =>
> include/linux/platform_data/keypad-ep93xx.h (100%)
> rename arch/arm/mach-ep93xx/include/mach/ep93xx_spi.h =>
> include/linux/platform_data/spi-ep93xx.h (100%)
> renam
On Wednesday, September 26, 2012 10:57 AM, Greg Kroah-Hartman wrote:
> On Wed, Sep 26, 2012 at 10:56:06AM -0700, Greg Kroah-Hartman wrote:
>>
>> With 3.6 about to be released, I've now closed the 3.7 staging-next tree
>> for new features / cleanups. It's bug-fixes only now until 3.7-rc1 is
>> out
The SPI core provides infrastructure for standard message queueing. Use
that instead of handling it in the driver.
Signed-off-by: H Hartley Sweeten
Acked-by: Mika Westerberg
Cc: Ryan Mallon
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 165
On Monday, July 08, 2013 5:10 AM, Mark Brown wrote:
> On Tue, Jul 02, 2013 at 10:10:29AM -0700, H Hartley Sweeten wrote:
>> The divider values stored in the per chip data are only used to set the
>> registers in the hardware to generate the desired SPI clock. Since these
>&g
Instead of carrying the in-flight message in the driver private
data, use the cur_msg pointer that is already setup by the core.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 88
Hello all,
Does anyone know what the Kconfig option VIRT_TO_BUS does?
There are a number of "depends on" that option but it does not
seem to directly enable any code in the kernel.
Thanks for any reply.
Regards,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
On Monday, November 12, 2012 11:41 AM, Bjorn Helgaas wrote:
> On Mon, Nov 12, 2012 at 9:18 AM, H Hartley Sweeten wrote:
>> Does anyone know what the Kconfig option VIRT_TO_BUS does?
>> There are a number of "depends on" that option but it does not
>> seem to directl
Introduce, and use, the helper macro module_hid_driver to allow removing
the init/exit boilerplate code from the HID drivers.
H Hartley Sweeten (3):
HID: introduce helper for hid_driver boilerplate
HID: hid.h: remove unused hid_generic_{init,exit} prototypes
HID: Use module_hid_driver macro
Introduce the module_hid_driver macro which is a convenience macro
for HID driver modules similar to module_usb_driver. It is intended
to be used by drivers with init/exit sections that do nothing but
register/unregister the HID driver.
Signed-off-by: H Hartley Sweeten
Cc: Jiri Kosina
These functions are not defined. Remove the extern declarations.
Signed-off-by: H Hartley Sweeten
Cc: Jiri Kosina
---
include/linux/hid.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index d6c71a6..828726c 100644
--- a/include/linux/hid.h
: H Hartley Sweeten
Cc: Jiri Kosina
---
drivers/hid/hid-a4tech.c | 13 +
drivers/hid/hid-apple.c| 19 +--
drivers/hid/hid-aureal.c | 13 +
drivers/hid/hid-axff.c | 14 +-
drivers/hid/hid-belkin.c | 13
On Thursday, November 15, 2012 9:28 AM, Arpith Easow Alexander wrote:
> On Tue, Nov 13, 2012 at 11:52:52AM -0800, Greg KH wrote:
>> So a macro called dbgcm tests a variable called dbgcm? Gotta love c at
>> times...
>>
>> Just delete the macro, and the variable, and call dev_dbg() directly
>> plea
On Tuesday, June 11, 2013 12:48 PM, Thierry Reding wrote:
>
> I'm tempted to take your v5 patch and make a note to clean that up
> separately at some point (along with similar changes for the DEBUG_FS
> support).
Thierry,
So you want a v6 of this patch or are you ok with v5?
Thanks,
Hartley
--
| |-- duty_ns(r/w) duty cycle (in nanoseconds)
| |-- enable (r/w) enable/disable PWM
| |-- period_ns (r/w) period (in nanoseconds)
| `-- polarity (r/w) polarity of PWM
`-- unexport (w/o) return a PWM to the kernel
Signed-off-by: H Hartley Sweeten
Cc
On Tuesday, May 28, 2013 4:42 AM, Lars Poeschel wrote:
> On Tuesday 28 May 2013 at 13:00:12, Thierry Reding wrote:
>> I've added Lars Poeschel on Cc, who's done some work on a sysfs
>> interface for the PWM subsystem already. It's undergone some review
>> already[0] and I think he's working on a v2
On Wednesday, May 29, 2013 7:02 PM, Ryan Mallon wrote:
> On 30/05/13 07:08, H Hartley Sweeten wrote:
>> Add a simple sysfs interface to the PWM framework.
>>
>> /sys/class/pwm/
>> `-- pwmchipN/ for each PWM chip
>> |-- export (w/o)
the kernel
Signed-off-by: H Hartley Sweeten
Cc: Thierry Reding
Cc: Lars Poeschel
Cc: Ryan Mallon
Cc: Rob Landley
---
v2: * add API documentation and update Documentation/pwm.txt
* fix some issues pointed out by Ryan Mallon
* add the pwm attributes to dev.groups so they are created
On Thursday, May 30, 2013 12:30 PM, H Hartley Sweeten wrote:
> Add a simple sysfs interface to the generic PWM framework.
>
> /sys/class/pwm/
> `-- pwmchipN/ for each PWM chip
> |-- export (w/o) ask the kernel to export a PWM channel
> |-- n
Signed-off-by: H Hartley Sweeten
Cc: Thierry Reding
Cc: Lars Poeschel
Cc: Ryan Mallon
Cc: Rob Landley
---
v3: * fix an issue with the export/unexport of the PWM chip
v2: * add API documentation and update Documentation/pwm.txt
* fix some issues pointed out by Ryan Mallon
* add the pwm
Ping?
-Original Message-
From: H Hartley Sweeten
Sent: Thursday, May 30, 2013 2:31 PM
To: Linux Kernel
Cc: linux-...@vger.kernel.org; linux-...@vger.kernel.org;
thierry.red...@gmail.com; poesc...@lemonage.de; Ryan Mallon; r...@landley.net;
H Hartley Sweeten
Subject: [PATCH v3] pwm: add
On Monday, June 10, 2013 12:00 PM, Thierry Reding wrote:
> On Thu, May 30, 2013 at 02:30:39PM -0700, H Hartley Sweeten wrote:
>> Add a simple sysfs interface to the generic PWM framework.
>
> Sorry for taking so long to review this.
Not a problem. Thanks for the review.
>
to the kernel
Signed-off-by: H Hartley Sweeten
Cc: Thierry Reding
Cc: Lars Poeschel
Cc: Ryan Mallon
Cc: Rob Landley
---
v4: * address a number of issues pointed out by Thierry Reding
- fix some typos and wording issues in the Documentation
- rename the new source file to sysfs.c
On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote:
> On 11/06/13 20:14, Thierry Reding wrote:
>> On Mon, Jun 10, 2013 at 04:12:07PM -0700, H Hartley Sweeten wrote:
>> [...]
>>> +What: /sys/class/pwm/pwmchipN/pwmX/duty
>>> +Date: May
On Tuesday, June 11, 2013 9:09 AM, H Hartley Sweeten wrote:
> On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote:
>> On 11/06/13 20:14, Thierry Reding wrote:
>>> On Mon, Jun 10, 2013 at 04:12:07PM -0700, H Hartley Sweeten wrote:
>>>> +config PWM_SYSFS
>>&
channel to the kernel
Signed-off-by: H Hartley Sweeten
Cc: Thierry Reding
Cc: Lars Poeschel
Cc: Ryan Mallon
Cc: Rob Landley
---
v5: * rename the 'duty' attribute to 'duty_cycle'
* make the Kconfig option hidden and enabled when CONFIG_SYSFS
is enabled
*
On Tuesday, June 11, 2013 11:35 AM, Thierry Reding wrote:
> On Tue, Jun 11, 2013 at 11:47:23AM -0500, H Hartley Sweeten wrote:
>> On Tuesday, June 11, 2013 9:09 AM, H Hartley Sweeten wrote:
>>> On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote:
>>>> On 11/06/
On Monday, July 01, 2013 3:28 AM, Mark Brown wrote:
> On Fri, Jun 28, 2013 at 11:43:34AM -0700, H Hartley Sweeten wrote:
>> __spi_async(), which starts every SPI message transfer, initializes
>> the bits_per_word and max speed for every transfer in the message.
>> Since th
On Monday, July 01, 2013 3:58 AM, Mark Brown wrote:
> On Sat, Jun 29, 2013 at 09:15:09AM +1000, Ryan Mallon wrote:
>> On 29/06/13 04:42, H Hartley Sweeten wrote:
>
>>> -static inline u8
>>> -ep93xx_spi_read_u8(const struct ep93xx_spi *spi, u16 reg)
>>> -{
&g
On Sunday, June 30, 2013 9:14 AM, Mika Westerberg wrote:
> On Fri, Jun 28, 2013 at 11:43:07AM -0700, H Hartley Sweeten wrote:
>> This driver supports 16 to 4 bits per work. Set the bits_per_word_mask
>> to allows the spi core to handle validation.
>>
>> Signed-off-b
On Monday, July 01, 2013 11:23 AM, H Hartley Sweeten wrote:
> On Sunday, June 30, 2013 9:14 AM, Mika Westerberg wrote:
>> Please use SPI_BPW_RANGE_MASK(4, 16) here.
>
> I thought there was a macro for this, just couldn't find it. I'll fix this.
Doh... This patch is alr
Tidy up this driver a bit.
v2: redo patch 4 based on suggestions from Alan Stern
H Hartley Sweeten (4):
usb: ohci-ep93xx: use devm_ioremap_resource()
usb: ohci-ep93xx: use platform_get_irq()
usb: ohci-ep93xx: use devm_clk_get()
usb: ohci-ep93xx: tidy up driver (*probe) and (*remove
Use devm_ioremap_resource() to make the code a bit cleaner and
simpler.
Signed-off-by: H Hartley Sweeten
Acked-by: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 35 ++-
1 file changed, 14 insertions(+), 21
and simply call clk_enable() and clk_disable()
directly. The extra level of redirection does not add any clarity.
Signed-off-by: H Hartley Sweeten
Cc: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 128 +
1
Use platform_get_irq() instead of accessing the platform_device
resources directly.
Signed-off-by: H Hartley Sweeten
Acked-by: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
Use devm_clk_get() to make the code a bit cleaner and simpler.
This also fixes a bug where a clk_put() is not done if usb_add_hcd()
fails.
Signed-off-by: H Hartley Sweeten
Acked-by: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 4 +---
1 file
here only for
completeness.
H Hartley Sweeten (11):
spi: spi-ep93xx: always handle transfer specific settings
spi: spi-ep93xx: use read,write instead of __raw_* variants
spi: spi-ep93xx: remove bits_per_word() helper
spi: spi-ep93xx: get platform resources early in (*probe)
spi: spi
for each transfer in the message.
Remove the redundant ep93xx_spi_chp_setup() in ep93xx_spi_process_transfer()
which just initializes the hardware to the "default" based on the SPI
device.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Gr
The memory resource used by this driver is ioremap()'d and the normal
read,write calls can be used instead of the __raw_* variants.
Also, remove the inline tag on the helper functions and let the compiler
decide if they are inlined.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc:
Check t->bits_per_word directly and remove the inline helper function.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --gi
Use devm_clk_get() so that the clk_put() happens automatically when
the last reference to this driver is dropped.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 9 +++--
1 file changed, 3 insertions
Get the platform resources early in the (*probe) to minimize the number
of goto's in the error path.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 26 --
1 file change
in
ep93xx_spi_process_transfer() and remove 'dss' from the per chip private
data.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git
The divisors needed to generate the SPI clock are calculated per
transfer based on the t->speed_hz. There is no reason to calculate
them in ep93xx_spi_setup().
Signed-off-by: H Hartley Sweeten
Acked-by: Mika Westerberg
Cc: Ryan Mallon
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/
nto ep93xx_spi_chip_setup()
and return the dividers thru pointers. Remove the divider values from
the per chip data structure.
Signed-off-by: H Hartley Sweeten
Acked-by: Mika Westerberg
Cc: Ryan Mallon
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c |
The kzalloc() failure will have already output a message.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/spi/spi-ep93xx.c b
On Wednesday, July 03, 2013 11:21 AM, Mark Brown wrote:
> On Tue, Jul 02, 2013 at 10:08:21AM -0700, H Hartley Sweeten wrote:
>> Use devm_clk_get() so that the clk_put() happens automatically when
>> the last reference to this driver is dropped.
>
> This doesn't apply aga
On Wednesday, July 03, 2013 11:21 AM, Mark Brown wrote:
> On Tue, Jul 02, 2013 at 10:08:21AM -0700, H Hartley Sweeten wrote:
>> Use devm_clk_get() so that the clk_put() happens automatically when
>> the last reference to this driver is dropped.
>
> This doesn't apply aga
Do a bit of housecleaning in this driver and convert it to use the
SPI queued driver infrastructure.
H Hartley Sweeten (8):
spi: spi-ep93xx: use read,write instead of __raw_* variants
spi: spi-ep93xx: use bits_per_word_mask
spi: spi-ep93xx: always handle transfer specific settings
spi
The memory resource used by this driver is ioremap()'d and the normal
read,write calls can be used instead of the __raw_* variants.
Remove the inline read,write helpers and just do the read,write
directly in the callers.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerber
This driver supports 16 to 4 bits per work. Set the bits_per_word_mask
to allows the spi core to handle validation.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 11 +--
1 file changed, 1 insertion
for each transfer in the message.
Remove the redundant ep93xx_spi_chp_setup() in ep93xx_spi_process_transfer()
which just initializes the hardware to the "default" based on the SPI
device.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Gr
This inline helper function is only used to determine the bus width
of the current transfer (8 or 16 bit). Add a bool flag to the private
structure and set it appropriately for each transfer.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
in
ep93xx_spi_process_transfer() and remove 'dss' from the per chip private
data.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --
The divisors needed to generate the SPI clock are calculated per
transfer based on the t->speed_hz. There is no reason to calculate
them in ep93xx_spi_setup().
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93x
nto ep93xx_spi_chip_setup()
and return the dividers thru pointers. Remove the divider values from
the per chip data structure.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c |
The SPI core provides infrastructure for standard message queueing. Use
that instead of handling it in the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 164
Hello Chris,
I have a question concerning the "au" size of a SD Card.
I have an old Kingston 64MB SD-Card and lately I have noticed this
kernel message when I use the card:
mmc0: SD Status: Invalid Allocation Unit size.
This is due to the following commit:
commit b63b5e819d5b21ae493c17c356018f
On Friday, June 28, 2013 4:18 PM, Ryan Mallon wrote:
> On 29/06/13 04:43, H Hartley Sweeten wrote:
>> __spi_async(), which starts every SPI message transfer, initializes
>> the bits_per_word and max speed for every transfer in the message.
>> Since th
Hello all,
I have a question concerning the "au" size of a SD Card.
I have an old Kingston 64MB SD-Card and lately I have noticed this
kernel message when I use the card:
mmc0: SD Status: Invalid Allocation Unit size.
This is due to the following commit:
commit b63b5e819d5b21ae493c17c356018ffa
Tidy up this driver a bit.
H Hartley Sweeten (4):
usb: ohci-ep93xx: use devm_ioremap_resource()
usb: ohci-ep93xx: use platform_get_irq()
usb: ohci-ep93xx: use devm_clk_get()
usb: ohci-ep93xx: tidy up ohci_hcd_ep93xx_drv_probe()
drivers/usb/host/ohci-ep93xx.c | 60
Use devm_ioremap_resource() to make the code a bit cleaner and
simpler.
Signed-off-by: H Hartley Sweeten
Cc: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 35 ++-
1 file changed, 14 insertions(+), 21 deletions
Use platform_get_irq() instead of accessing the platform_device
resources directly.
Signed-off-by: H Hartley Sweeten
Cc: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a
Use devm_clk_get() to make the code a bit cleaner and simpler.
This also fixes a bug where a clk_put() is not done if usb_add_hcd()
fails.
Signed-off-by: H Hartley Sweeten
Cc: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 4 +---
1 file changed
Refactor the function a bit to remove the need for the local variable.
The extern prototype of usb_disabled() is not needed.
Signed-off-by: H Hartley Sweeten
Cc: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 11 +++
1 file changed, 3
On Friday, August 16, 2013 8:02 AM, Vivien Didelot wrote:
> Hi Linus,
>
> You wrote:
> > But:
>>
>>> drivers/gpio/gpio-pca953x.c | 2 +-
>> (...)
>>> diff --git a/drivers/gpio/gpio-pca953x.c
>>> b/drivers/gpio/gpio-pca953x.c
>>> index 426c51d..8804aec 100644
>>> --- a/drivers/gpio/
9307.c| 2 +-
For the ep93xx change:
Acked-by: H Hartley Sweeten
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read th
a uses the member
'port'.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Lars-Peter Clausen
Cc: Mark Brown
Cc: Liam Girdwood
Cc: Jaroslav Kysela
Cc: Takashi Iwai
---
sound/soc/cirrus/ep93xx-ac97.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/so
1 - 100 of 498 matches
Mail list logo
