Re: [PATCH v10 3/6] devicetree: mfd: Add new SKY81452 mfd binding

2015-01-08 Thread Gyungoh Yoo
DT Ack please. On Wed, Jan 07, 2015 at 11:19:24AM +0900, gyun...@gmail.com wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo > Acked-by: Lee Jones > --- > Changes v10: > Nothing > > Changes v9: > Nothing > > Changes v8: > Made up the e

Re: [PATCH v10 4/6] devicetree: backlight: Add new SKY81452 backlight binding

2015-01-08 Thread Gyungoh Yoo
DT Ack please. On Wed, Jan 07, 2015 at 11:19:25AM +0900, gyun...@gmail.com wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo > Acked-by: Bryan Wu > --- > Changes v10: > Nothing > > Changes v9: > Nothing > > Changes v8: > Renamed property

Re: [PATCH v10 0/6] Add Skyworks SKY81452 device drivers

2015-01-18 Thread Gyungoh Yoo
On Sun, Jan 18, 2015 at 05:40:37PM +, Lee Jones wrote: > > From: Gyungoh Yoo > > > > This patch set includes regulator and backlight driver for SKY81452. > > Also it includes documents for device tree and module. > > sky81452-regulator was already applied. So t

Re: [PATCH v10 4/6] devicetree: Add new SKY81452 backlight binding

2015-01-26 Thread Gyungoh Yoo
On Fri, Jan 23, 2015 at 03:28:33PM +0900, gyun...@gmail.com wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo > Acked-by: Bryan Wu The existing Ack is only for backlight driver. DT Ack please. > --- > Changes v10: > Nothing > > Changes v9: > Noth

Re: [PATCH v2.2 2/2] dt-bindings: Adding compatible attribute for SKY81452 regulator

2014-09-18 Thread Gyungoh Yoo
On Mon, Sep 15, 2014 at 03:35:54PM -0700, Mark Brown wrote: > On Thu, Sep 11, 2014 at 02:22:30PM +0900, Gyungoh Yoo wrote: > > > By the way, > > I knew that compatible string is used for binding a driver. > > http://devicetree.org/Device_Tree_Usage#Understanding_the_compat

Re: [PATCH v2.2 2/2] dt-bindings: Adding compatible attribute for SKY81452 regulator

2014-09-10 Thread Gyungoh Yoo
On Sat, Sep 06, 2014 at 03:38:28PM +0100, Mark Brown wrote: > On Fri, Sep 05, 2014 at 10:55:07AM +0900, Gyungoh Yoo wrote: > > On Mon, Sep 01, 2014 at 11:31:58AM +0100, Mark Brown wrote: > > > > Why is this a good idea - can this driver be used for anything other > > &g

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-25 Thread Gyungoh Yoo
e the man page for `git > send-email` for details. > > > > > Signed-off-by: Gyungoh Yoo > > --- > > Documentation/devicetree/bindings/mfd/sky81452.txt | 24 + > > Binding documents should be sent separately: > > See: Documentation/devicetre

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-26 Thread Gyungoh Yoo
On Tue, Aug 26, 2014 at 09:22:58AM +0100, Lee Jones wrote: > On Mon, 25 Aug 2014, Gyungoh Yoo wrote: > > On Thu, Aug 21, 2014 at 10:45:02AM +0100, Lee Jones wrote: > > > When you send patch-sets, you should send them connected to one > > > another AKA threaded. That w

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-27 Thread Gyungoh Yoo
On Wed, Aug 27, 2014 at 09:39:21AM +0100, Lee Jones wrote: > On Wed, 27 Aug 2014, Gyungoh Yoo wrote: > > On Tue, Aug 26, 2014 at 09:22:58AM +0100, Lee Jones wrote: > > > On Mon, 25 Aug 2014, Gyungoh Yoo wrote: > > > > On Thu, Aug 21, 2014 at 10:45:02AM +0100, Lee J

[PATCH v2 0/7] Adding Skyworks SKY81452 device drivers

2014-08-28 Thread Gyungoh Yoo
hild drivers Renamed CONFIG_SKY81452 to CONFIG_MFD_SKY81452 Changed the dependency from I2C=y to I2C, for CONFIG_MFD_SKY81452 Added message for exception or errors. Gyungoh Yoo (7): Adding Skyworks SKY81452 MFD driver Adding Skyworks SKY81452 regulator driver Adding Skyworks SKY81452 backlight driver

[PATCH v2 1/7] Adding Skyworks SKY81452 MFD driver

2014-08-28 Thread Gyungoh Yoo
ntel-soc-pmic.o diff --git a/drivers/mfd/sky81452.c b/drivers/mfd/sky81452.c new file mode 100644 index 000..c0ca812 --- /dev/null +++ b/drivers/mfd/sky81452.c @@ -0,0 +1,108 @@ +/* + * sky81452.c SKY81452 MFD driver + * + * Copyright 2014 Skyworks Solutions Inc. + * Author : Gyungoh Yoo + * + *

[PATCH v2 2/7] Adding Skyworks SKY81452 regulator driver

2014-08-28 Thread Gyungoh Yoo
@ +/* + * sky81452-regulator.cSKY81452 regulator driver + * + * Copyright 2014 Skyworks Solutions Inc. + * Author : Gyungoh Yoo + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Softw

[PATCH v2 3/7] Adding Skyworks SKY81452 backlight driver

2014-08-28 Thread Gyungoh Yoo
ight/sky81452-backlight.c new file mode 100644 index 000..d292026 --- /dev/null +++ b/drivers/video/backlight/sky81452-backlight.c @@ -0,0 +1,347 @@ +/* + * sky81452-backlight.cSKY81452 backlight driver + * + * Copyright 2014 Skyworks Solutions Inc. + * Author : Gyungoh Yoo + * + * This

[PATCH v2 4/7] Adding SKY81452 MFD device tree bindings document

2014-08-28 Thread Gyungoh Yoo
v2: Added 'reg' attribute for I2C address in device tree documents --- .../devicetree/bindings/i2c/trivial-devices.txt| 1 + Documentation/devicetree/bindings/mfd/sky81452.txt | 32 ++ .../devicetree/bindings/vendor-prefixes.txt| 1 + 3 files changed, 34 insertio

[PATCH v2 5/7] Adding SKY81452 regulator device tree bindings document

2014-08-28 Thread Gyungoh Yoo
v2: Added 'compatible' attribute in child drivers --- .../bindings/regulator/sky81452-regulator.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/sky81452-regulator.txt diff --git a/Documentation/devicetree/bin

[PATCH v2 6/7] Adding SKY81452 backlight device tree bindings document

2014-08-28 Thread Gyungoh Yoo
v2: Added 'compatible' attribute in child drivers --- .../video/backlight/sky81452-backlight.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt diff --git a/Documentation/devicet

[PATCH v2 7/7] Adding SKY81452 backlight document

2014-08-28 Thread Gyungoh Yoo
v2: split the patches --- Documentation/backlight/sky81452-backlight.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/backlight/sky81452-backlight.txt diff --git a/Documentation/backlight/sky81452-backlight.txt b/Documentation/backlight/sky

[PATCH v2.1 1/7] Adding Skyworks SKY81452 MFD driver

2014-08-28 Thread Gyungoh Yoo
new file mode 100644 index 000..e91b928 --- /dev/null +++ b/drivers/mfd/sky81452.c @@ -0,0 +1,111 @@ +/* + * sky81452.c SKY81452 MFD driver + * + * Copyright 2014 Skyworks Solutions Inc. + * Author : Gyungoh Yoo + * + * This program is free software; you can redistribute it and/or modify it +

Re: [PATCH v2 2/7] Adding Skyworks SKY81452 regulator driver

2014-08-28 Thread Gyungoh Yoo
On Thu, Aug 28, 2014 at 12:02:54PM +0100, Mark Brown wrote: > On Thu, Aug 28, 2014 at 07:46:37PM +0900, Gyungoh Yoo wrote: > > v2: > > Added 'compatible' attribute in the driver > > Added message for exception or errors. > > This driver has already bee

Re: [PATCH v2.2 2/2] dt-bindings: Adding compatible attribute for SKY81452 regulator

2014-09-04 Thread Gyungoh Yoo
On Mon, Sep 01, 2014 at 11:31:58AM +0100, Mark Brown wrote: > On Mon, Sep 01, 2014 at 11:40:18AM +0900, Gyungoh Yoo wrote: > > Adding compatible attribute for SKY81452 regulator driver. > > > Required properties: > > +- compatible : Must be "skyworks,sky81452-

[PATCH v2.2 1/7] regulator: sky81452: Adding Skyworks SKY81452 MFD driver

2014-09-04 Thread Gyungoh Yoo
This patch adds SKY81452 MFD driver. SKY81452 has 2 functions : backlight LED driver and boost converter. The MFD driver registers I2C regmap and registers the child drivers. Signed-off-by: Gyungoh Yoo --- drivers/mfd/Kconfig | 12 + drivers/mfd/Makefile | 1 + drivers

[PATCH v2.2 0/2] regulator: sky81452: Adding compatible attribute in DT document

2014-08-31 Thread Gyungoh Yoo
Adding comptiable attribute in DT document. Splitted the patches for each subsystem. Fixed typo in DT document. Gyungoh Yoo (2): regulator: sky81452: Adding compatible attribute in DT dt-bindings: Adding compatible attribute for SKY81452 regulator .../bindings/regulator/sky81452

[PATCH v2.2 2/2] dt-bindings: Adding compatible attribute for SKY81452 regulator

2014-08-31 Thread Gyungoh Yoo
Adding compatible attribute for SKY81452 regulator driver. --- Documentation/devicetree/bindings/regulator/sky81452-regulator.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/regulator/sky81452-regulator.txt b/Documentation/devicetree/b

[PATCH v2.2 1/2] regulator: sky81452: Adding compatible attribute in DT

2014-08-31 Thread Gyungoh Yoo
.driver = { .name = "sky81452-regulator", + .of_match_table = of_match_ptr(sky81452_reg_of_match), }, .probe = sky81452_reg_probe, }; @@ -127,4 +137,4 @@ module_platform_driver(sky81452_reg_driver); MODULE_DESCRIPTION("Skyworks SKY814

Re: [PATCH v2 5/7] Adding SKY81452 regulator device tree bindings document

2014-08-31 Thread Gyungoh Yoo
or confusiong. Thank you. On Thu, Aug 28, 2014 at 07:58:38PM +0900, Gyungoh Yoo wrote: > v2: > Added 'compatible' attribute in child drivers > > --- > .../bindings/regulator/sky81452-regulator.txt | 18 > ++ > 1 file changed, 18 insertions(+

[PATCH] Adding a support for Skyworks SKY81452

2014-08-07 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Documentation/backlight/sky81452.txt | 25 ++ Documentation/devicetree/bindings/mfd/sky81452.txt | 24 ++ .../bindings/regulator/sky81452-regulator.txt | 16 + .../devicetree/bindings/vendor-prefixes.txt| 1 + .../video/backlight

Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-07 Thread Gyungoh Yoo
On Thu, Aug 07, 2014 at 11:09:52AM +0100, Lee Jones wrote: > On Thu, 07 Aug 2014, Gyungoh Yoo wrote: > > > Signed-off-by: Gyungoh Yoo > > --- > > Documentation/backlight/sky81452.txt | 25 ++ > > Documentation/devicetree/bindings/mfd/sky81452.

Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-07 Thread Gyungoh Yoo
Thank you for your comments. I will fix them and resubmit. On Thu, Aug 07, 2014 at 02:34:39PM +0200, Tobias Klauser wrote: > On 2014-08-07 at 10:05:38 +0200, Gyungoh Yoo wrote: > > Signed-off-by: Gyungoh Yoo > > --- > > Documentation/backlight/sky81452.tx

[PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-08 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Documentation/devicetree/bindings/mfd/sky81452.txt | 24 + .../devicetree/bindings/vendor-prefixes.txt| 1 + drivers/mfd/Kconfig| 12 +++ drivers/mfd/Makefile | 1 + drivers/mfd

[PATCH 2/3] Adding Skyworks SKY81452 regulator driver

2014-08-08 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- .../bindings/regulator/sky81452-regulator.txt | 16 +++ drivers/regulator/Kconfig | 11 ++ drivers/regulator/Makefile | 1 + drivers/regulator/sky81452-regulator.c | 130 + 4

[PATCH 3/3] Adding Skyworks SKY81452 backlight driver

2014-08-08 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Documentation/backlight/sky81452-backlight.txt | 26 ++ .../video/backlight/sky81452-backlight.txt | 20 ++ drivers/video/backlight/Kconfig| 10 + drivers/video/backlight/Makefile | 1 + drivers/video/backlight

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-11 Thread Gyungoh Yoo
Hello, Can somebody please review if the code has anything to improve? Thanks. On Fri, Aug 08, 2014 at 06:08:19PM +0900, Gyungoh Yoo wrote: > Signed-off-by: Gyungoh Yoo > --- > Documentation/devicetree/bindings/mfd/sky81452.txt | 24 + > .../devicetree/bindings/vendor-

Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-22 Thread Gyungoh Yoo
On Wed, Oct 22, 2014 at 11:27:23AM +0100, Mark Brown wrote: > On Mon, Oct 20, 2014 at 03:10:24PM +0900, Gyungoh Yoo wrote: > > On Fri, Oct 17, 2014 at 04:26:05PM +0200, Mark Brown wrote: > > > > The thing I'm seeing is that the binding for your device with the > >

Re: [RESUBMIT PATCH v4 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-10-22 Thread Gyungoh Yoo
On Tue, Oct 21, 2014 at 01:30:01PM +0100, Lee Jones wrote: > On Mon, 13 Oct 2014, Gyungoh Yoo wrote: > > > Signed-off-by: Gyungoh Yoo > > --- > > Changes v4: > > Removed MODULE_VERSION() > > Modified license to GPLv2 > > > > Changes v3: &g

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-05 Thread Gyungoh Yoo
On Tue, Nov 04, 2014 at 11:41:20AM +, Mark Brown wrote: > On Tue, Nov 04, 2014 at 02:45:34PM +0900, Gyungoh Yoo wrote: > > On Tue, Nov 04, 2014 at 12:53:29AM +, Mark Brown wrote: > > > > I'm having a hard time understanding why it is difficult to split the >

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-05 Thread Gyungoh Yoo
On Mon, Nov 03, 2014 at 10:45:39PM +0100, Paul Bolle wrote: > On Fri, 2014-10-31 at 16:44 +, Mark Brown wrote: > > On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: > > > From: Gyungoh Yoo > > > > > > Signed-off-by: Gyungoh Yoo > &g

[RESUBMIT PATCH v4 3/8] devicetree: mfd: Add new SKY81452 mfd binding

2014-10-12 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Changes v4: Nothing Changes v3: Nothing Changes v2: Added reg attribute for I2C slave address Documentation/devicetree/bindings/mfd/sky81452.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings

[RESUBMIT PATCH v4 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-10-12 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Changes v4: Removed MODULE_VERSION() Modified license to GPLv2 Changes v3: Fixed the backlight name from 'sky81452-bl' to 'sky81452-backlight' Assigned mfd_cell.of_compatible for binding device node Modified error messages Changes v2: Rename

[RESUBMIT PATCH v4 4/8] devicetree: backlight: Add new SKY81452 backlight binding

2014-10-12 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Changes v4: Nothing Changes v3: Nothing Changes v2: Added reg attribute for I2C slave address .../video/backlight/sky81452-backlight.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings

[RESUBMIT PATCH v4 0/8] Add Skyworks SKY81452 device drivers

2014-10-12 Thread Gyungoh Yoo
or CONFIG_MFD_SKY81452 Added message for exception or errors. Added vendor prefix for Skyworks Solutions, Inc. Add SKY81452 to the Trivial Devices list Gyungoh Yoo (8): mfd: Add support for Skyworks SKY81452 driver backlight: Add support Skyworks SKY81452 backlight driver devicetree: mfd: Add new SKY8

[RESUBMIT PATCH v4 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-10-12 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Changes v4: Reordering header files for readability Removed calling to backlight_device_unregister() - because devm_backlight_device_register() was used Removed MODULE_VERSION() Modified license to GPLv2 Changes v3: Modified DBG messages Changes v2: Added

[RESUBMIT PATCH v4 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc.

2014-10-12 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Changes v4: Nothing Changes v3: Nothing Changes v2: Added vendor prefix for Skyworks Solutions, Inc. Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt

[RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-12 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Changes v4: Removed MODULE_VERSION() Modified license to GPLv2 Changes v3: Modified to return ENODATA when of_node is NULL Modified the messages in error cases Changes v2: Added 'compatible' attribute in the driver Added message for exception or errors.

[RESUBMIT PATCH v4 8/8] devicetree: regulator: sky81452: Add compatible string for device binding

2014-10-12 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Changes v4: Nothing Changes v3: Nothing Changes v2: Added 'compatible' attribute in the driver Documentation/devicetree/bindings/regulator/sky81452-regulator.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings

[RESUBMIT PATCH v4 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list

2014-10-12 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Changes v4: Nothing Changes v3: Nothing Changes v2: Add SKY81452 to the Trivial Devices list Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt

Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-13 Thread Gyungoh Yoo
On Mon, Oct 13, 2014 at 12:35:12PM +0200, Mark Brown wrote: > On Mon, Oct 13, 2014 at 02:47:41PM +0900, Gyungoh Yoo wrote: > > > - np = of_get_child_by_name(dev->parent->of_node, "regulator"); > > - if (unlikely(!np)) { > > + if (!np) { > >

[RESUBMIT PATCH v3 0/8] Adding Skyworks SKY81452 device drivers

2014-10-06 Thread Gyungoh Yoo
#x27;compatible' attribute in child drivers Renamed CONFIG_SKY81452 to CONFIG_MFD_SKY81452 Changed the dependency from I2C=y to I2C, for CONFIG_MFD_SKY81452 Added message for exception or errors. Gyungoh Yoo (8): mfd: Add support for Skyworks SKY81452 driver backlight: Add support Skywork

[RESUBMIT PATCH v3 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-10-06 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- drivers/mfd/Kconfig | 12 + drivers/mfd/Makefile | 1 + drivers/mfd/sky81452.c | 111 +++ include/linux/mfd/sky81452.h | 32 + 4 files changed, 156 insertions(+) create mode 100644

[RESUBMIT PATCH v3 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-10-06 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- drivers/video/backlight/Kconfig | 10 + drivers/video/backlight/Makefile | 1 + drivers/video/backlight/sky81452-backlight.c | 347 +++ 3 files changed, 358 insertions(+) create mode 100644 drivers/video

[RESUBMIT PATCH v3 3/8] devicetree: mfd: Add new SKY81452 mfd binding

2014-10-06 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Documentation/devicetree/bindings/mfd/sky81452.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/sky81452.txt diff --git a/Documentation/devicetree/bindings/mfd/sky81452.txt b/Documentation

[RESUBMIT PATCH v3 4/8] devicetree: backlight: add new SKY81452 backlight binding

2014-10-06 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- .../video/backlight/sky81452-backlight.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt diff --git a/Documentation/devicetree/bindings/video

[RESUBMIT PATCH v3 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc.

2014-10-06 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index ac7269f..c755978 100644 --- a

[RESUBMIT PATCH v3 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list

2014-10-06 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt index 6af570e..ff77879 100644 --- a

[RESUBMIT PATCH v3 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-06 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- drivers/regulator/sky81452-regulator.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/sky81452-regulator.c b/drivers/regulator/sky81452-regulator.c index 97aff0c..f895d1b 100644 --- a/drivers/regulator

[RESUBMIT PATCH v3 8/8] devicetree: regulator: sky81452: Add compatible string for device binding

2014-10-06 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Documentation/devicetree/bindings/regulator/sky81452-regulator.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/sky81452-regulator.txt b/Documentation/devicetree/bindings/regulator/sky81452-regulator.txt index

Re: [RESUBMIT PATCH v3 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-10-07 Thread Gyungoh Yoo
view the patches? Thank you. > > > Signed-off-by: Gyungoh Yoo > > --- > > drivers/mfd/Kconfig | 12 + > > drivers/mfd/Makefile | 1 + > > drivers/mfd/sky81452.c | 111 > > +++ > >

Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-24 Thread Gyungoh Yoo
On Thu, Oct 23, 2014 at 02:01:03PM +0100, Mark Brown wrote: > On Thu, Oct 23, 2014 at 12:14:43PM +0900, Gyungoh Yoo wrote: > > > So, what do you think about DT like below? > > > sky81452@2c { > > compatible = "skyworks,sky81452"; > &g

Re: [RESUBMIT PATCH v5 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-10-27 Thread Gyungoh Yoo
On Mon, Oct 27, 2014 at 12:35:36PM +0530, Varka Bhadram wrote: > On 10/27/2014 12:32 PM, gyun...@gmail.com wrote: > >From: Gyungoh Yoo > > > >Signed-off-by: Gyungoh Yoo > >--- > >Changes v5: > >Move sky81452-backlight.h to include/linux/platform_data > &

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Gyungoh Yoo
On Fri, Oct 31, 2014 at 04:44:18PM +, Mark Brown wrote: > On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyun...@gmail.com wrote: > > From: Gyungoh Yoo > > > > Signed-off-by: Gyungoh Yoo > > This doesn't apply against current code and depends on the MFD symbol

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

2014-11-03 Thread Gyungoh Yoo
On Tue, Nov 04, 2014 at 12:53:29AM +, Mark Brown wrote: > On Tue, Nov 04, 2014 at 09:43:34AM +0900, Gyungoh Yoo wrote: > > On Fri, Oct 31, 2014 at 04:44:18PM +, Mark Brown wrote: > > > > This doesn't apply against current code and depends on the MFD symbol >

Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure

2014-11-18 Thread Gyungoh Yoo
On Tue, Nov 18, 2014 at 11:20:56AM +, Mark Brown wrote: > On Tue, Nov 18, 2014 at 05:04:51PM +0900, Gyungoh Yoo wrote: > > On Mon, Nov 17, 2014 at 02:18:36PM +, Mark Brown wrote: > > > > Don't open code this, use regulators_node and of_match as previously >

Re: [RESUBMIT PATCH v6 0/8] Add Skyworks SKY81452 device drivers

2014-11-13 Thread Gyungoh Yoo
; sending out the set again in reply-to a previous version, as things > get confusing real quick. I see. I didn't know that reply-to makes a confusing. I will resubmit the patch series. Thank you > > > From: Gyungoh Yoo > > > > This patch set includes regulator and b

Re: [PATCH v8 7/8] regulator: sky81452: Modify Device Tree structure

2014-12-01 Thread Gyungoh Yoo
On Wed, Nov 26, 2014 at 04:37:02PM +, Mark Brown wrote: > On Wed, Nov 26, 2014 at 10:40:07AM +0900, Gyungoh Yoo wrote: > > On Tue, Nov 25, 2014 at 12:19:16PM +, Mark Brown wrote: > > > On Tue, Nov 25, 2014 at 04:03:05PM +0900, gyun...@gmail.com wrote: > &g

Re: [RESUBMIT PATCH v7 4/9] devicetree: backlight: Add new SKY81452 backlight binding

2014-11-24 Thread Gyungoh Yoo
On Mon, Nov 17, 2014 at 12:23:33PM +, Lee Jones wrote: > On Mon, 17 Nov 2014, gyun...@gmail.com wrote: > > > From: Gyungoh Yoo > > > > Signed-off-by: Gyungoh Yoo > > --- > > Changes v7: > > Nothing > > > > Changes v6: > >

Re: [PATCH v8 7/8] regulator: sky81452: Modify Device Tree structure

2014-11-25 Thread Gyungoh Yoo
On Tue, Nov 25, 2014 at 12:19:16PM +, Mark Brown wrote: > On Tue, Nov 25, 2014 at 04:03:05PM +0900, gyun...@gmail.com wrote: > > From: Gyungoh Yoo > > This doesn't apply, please check and resend. Could you please explain why this doesn't? -- To unsubscribe from

Re: [PATCH v9 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-12-02 Thread Gyungoh Yoo
On Wed, Dec 03, 2014 at 11:19:06AM +0900, Jingoo Han wrote: > On Tuesday, December 02, 2014 5:05 PM, Gyungoh Yoo wrote: > > > > From: Gyungoh Yoo > > > > Signed-off-by: Gyungoh Yoo > > --- > > Changes v9: > > Nothing > > > > Changes

Re: [PATCH v9 3/8] devicetree: mfd: Add new SKY81452 mfd binding

2014-12-02 Thread Gyungoh Yoo
On Tue, Dec 02, 2014 at 02:07:27PM +, Lee Jones wrote: > This requires a DT Ack. I think I need to double-check the recipients. Thank you for the comment. > > > From: Gyungoh Yoo > > > > Signed-off-by: Gyungoh Yoo > > --- > > Changes v9: > > No

Re: [PATCH v10 2/6] backlight: Add support Skyworks SKY81452 backlight driver

2014-12-03 Thread Gyungoh Yoo
On Wed, Dec 03, 2014 at 11:02:29AM +0100, Oliver Neukum wrote: > On Wed, 2014-12-03 at 16:05 +0900, gyun...@gmail.com wrote: > > +static ssize_t sky81452_bl_store_enable(struct device *dev, > > + struct device_attribute *attr, const char *buf, size_t > > count) > > +{ > > + stru

Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure

2014-11-18 Thread Gyungoh Yoo
On Mon, Nov 17, 2014 at 02:18:36PM +, Mark Brown wrote: > On Mon, Nov 17, 2014 at 05:33:08PM +0900, gyun...@gmail.com wrote: > > > np = of_get_child_by_name(dev->parent->of_node, "regulator"); > > > + ret = of_regulator_match(dev, np, &sky81452_match, 1); > > Don't open code this, use

Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-17 Thread Gyungoh Yoo
On Tue, Oct 14, 2014 at 09:56:06AM +0200, Mark Brown wrote: > On Tue, Oct 14, 2014 at 10:11:12AM +0900, Gyungoh Yoo wrote: > > On Mon, Oct 13, 2014 at 12:35:12PM +0200, Mark Brown wrote: > > > > If you're doing anything here you should convert the code to use the >

Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-17 Thread Gyungoh Yoo
On Fri, Oct 17, 2014 at 12:17:34PM +0200, Mark Brown wrote: > On Fri, Oct 17, 2014 at 06:19:50PM +0900, Gyungoh Yoo wrote: > > > Wow. I understand. > > I missed .supply_name. I think I need something like > > below, before devm_regulator_register(). > > >

Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-19 Thread Gyungoh Yoo
On Fri, Oct 17, 2014 at 04:26:05PM +0200, Mark Brown wrote: > On Fri, Oct 17, 2014 at 07:43:09PM +0900, Gyungoh Yoo wrote: > > > Are you talking about simplification using of_regulator_match()? > > This driver has only one regulator. > > Is the API also useful for this dr

Re: [RESUBMIT PATCH v3 7/8] regulator: sky81452: Add compatible string for device binding

2014-10-08 Thread Gyungoh Yoo
On Tue, Oct 07, 2014 at 01:52:21PM +0100, Mark Brown wrote: > On Tue, Oct 07, 2014 at 02:11:07PM +0900, Gyungoh Yoo wrote: > > Signed-off-by: Gyungoh Yoo > > Several problems here: > > - I don't have patches 1-6 or the cover letter for this series - what >are t

Re: [PATCH] regulator: sky81452: Remove module version

2014-10-08 Thread Gyungoh Yoo
> MODULE_DESCRIPTION("Skyworks SKY81452 Regulator driver"); > MODULE_AUTHOR("Gyungoh Yoo "); > MODULE_LICENSE("GPL"); > -MODULE_VERSION("1.0"); > -- > 1.9.1 > > > -- To unsubscribe from this list: send the line "unsubsc

Re: [RESUBMIT PATCH v3 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-10-08 Thread Gyungoh Yoo
On Wed, Oct 08, 2014 at 10:03:57AM +0900, Jingoo Han wrote: > On Tuesday, October 07, 2014 2:01 PM, Gyungoh Yoo wrote: > > > > If possible, please add more detailed commit message for this patch. > > > Signed-off-by: Gyungoh Yoo > > --- > > drivers/video/

Re: [PATCH v10 4/6] devicetree: Add new SKY81452 backlight binding

2015-02-04 Thread Gyungoh Yoo
On Wed, Feb 04, 2015 at 09:11:22AM -0600, Rob Herring wrote: > On Fri, Jan 23, 2015 at 12:28 AM, wrote: > > From: Gyungoh Yoo > > > > Signed-off-by: Gyungoh Yoo > > Acked-by: Bryan Wu > > --- > > Changes v10: > > Nothing > > > > Changes

Re: [PATCH v10 0/6] Add Skyworks SKY81452 device drivers

2015-02-04 Thread Gyungoh Yoo
On Thu, Feb 05, 2015 at 03:29:40PM +0900, gyun...@gmail.com wrote: Please ignore this patch serial v10. Sorry for my mistake > From: Gyungoh Yoo > > This patch set includes regulator and backlight driver for SKY81452. > Also it includes documents for device tree and module

Re: [PATCH v11 0/6] Add Skyworks SKY81452 device drivers

2015-03-02 Thread Gyungoh Yoo
On Fri, Feb 27, 2015 at 08:39:38PM +, Lee Jones wrote: > On Fri, 27 Feb 2015, gyun...@gmail.com wrote: > > > From: Gyungoh Yoo > > > > This patch set includes regulator and backlight driver for SKY81452. > > Also it includes documents for device tree and modu

Re: [PATCH v10 2/6] backlight: Add support Skyworks SKY81452 backlight driver

2014-12-17 Thread Gyungoh Yoo
On Thu, Dec 18, 2014 at 03:09:21PM +0900, Jingoo Han wrote: > On Thursday, December 18, 2014 2:48 PM, Gyungoh Yoo wrote: > > > > From: Gyungoh Yoo > > > > Signed-off-by: Gyungoh Yoo > > Please add the following 'Acked-by's when you send this p

Re: [PATCH v11 2/6] backlight: Add support Skyworks SKY81452 backlight driver

2015-02-27 Thread Gyungoh Yoo
On Fri, Feb 27, 2015 at 09:58:38AM +0100, Oliver Neukum wrote: > On Fri, 2015-02-27 at 15:42 +0900, gyun...@gmail.com wrote: > > +static ssize_t sky81452_bl_store_enable(struct device *dev, > > + struct device_attribute *attr, const char *buf, size_t > > count) > > +{ > > + stru