[PATCH v2 06/15] dmaengine: dw-edma: Add device_prep_interleave_dma() support

2021-02-02 Thread Gustavo Pimentel
Add device_prep_interleave_dma() support to Synopsys DMA driver. This feature implements a similar data transfer mechanism to the scatter-gather implementation. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 85 ++ drivers/dma/dw

[PATCH v2 07/15] dmaengine: dw-edma: Improve number of channels check

2021-02-02 Thread Gustavo Pimentel
It was added some extra checks to ensure that the driver doesn't try to use more DMA channels than actually are available in hardware. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 21 + drivers/dma/dw-edma/dw-edma-core.h | 2 ++ 2 files ch

[PATCH v2 08/15] dmaengine: dw-edma: Reorder variables to keep consistency

2021-02-02 Thread Gustavo Pimentel
functional changes are expected. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 7077d79..9e79eb5 100644 --- a/drivers/dma

[PATCH v2 09/15] dmaengine: dw-edma: Improve the linked list and data blocks definition

2021-02-02 Thread Gustavo Pimentel
own linked list and data space well defined, which allows different sizes and locations. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 51 +- drivers/dma/dw-edma/dw-edma-core.h | 9 +- drivers/dma/dw-edma/dw-edma-pcie.c | 185

[PATCH v2 03/15] dmaengine: dw-edma: Add support for the HDMA feature

2021-02-02 Thread Gustavo Pimentel
Add support for the HDMA feature. This new feature enables the current eDMA IP to use a deeper prefetch of the linked list, which reduces the algorithm execution latency observed when loading the elements of the list, causing more stable and higher data transfer. Signed-off-by: Gustavo Pimentel

[PATCH v2 01/15] dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures

2021-02-02 Thread Gustavo Pimentel
generate a 64 bits message instead of two messages of 32 bits. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-core.c| 254 +++ drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 48 +++--- drivers/dma/dw-edma/dw-edma-v0-regs.h| 149 +- 3

RE: [RESEND v4 1/6] misc: Add Synopsys DesignWare xData IP driver

2021-02-09 Thread Gustavo Pimentel
On Mon, Feb 8, 2021 at 22:53:54, Krzysztof Wilczyński wrote: > [+cc Bjorn] > > Hi Gustavo, > > [...] > > Thanks for your review. I will wait for a couple of days, before sending > > a new version of this patch series based on your feedback. > > Thank you! > > There might be one more change,

RE: [PATCH v4 15/15] dmaengine: dw-edma: Add pcim_iomap_table return checker

2021-02-09 Thread Gustavo Pimentel
will rework the subject. > > On Wed, Feb 03, 2021 at 10:58:06PM +0100, Gustavo Pimentel wrote: > > Detected by CoverityScan CID 16555 ("Dereference null return") > > > > Signed-off-by: Gustavo Pimentel > > --- > > drivers/dma/dw-edma/dw-edma-pcie.c | 15

RE: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-19 Thread Gustavo Pimentel
On Tue, May 19, 2020 at 15:58:16, Lorenzo Pieralisi wrote: > On Tue, May 19, 2020 at 07:25:02PM +0530, Vidya Sagar wrote: > > > > > > On 18-May-20 9:24 PM, Lorenzo Pieralisi wrote: > > > External email: Use caution opening links or attachments > > > > > > > > > On Wed, May 13, 2020 at 05:35:

RE: [PATCH v6 1/5] misc: Add Synopsys DesignWare xData IP driver

2021-03-24 Thread Gustavo Pimentel
Hi Greg, On Tue, Mar 23, 2021 at 13:0:4, Greg Kroah-Hartman wrote: > On Fri, Feb 12, 2021 at 06:28:03PM +0100, Gustavo Pimentel wrote: > > +static const struct attribute_group xdata_attr_group = { > > + .attrs = default_attrs, > > + .name =

[PATCH v8 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2021-03-29 Thread Gustavo Pimentel
ann Cc: Andrew Morton Cc: Greg Kroah-Hartman Cc: Jonathan Corbet Cc: Bjorn Helgaas Cc: Krzysztof Wilczy??ski Gustavo Pimentel (5): misc: Add Synopsys DesignWare xData IP driver Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver MAINTAINERS: Add Synopsys xData IP driv

[PATCH v8 1/5] misc: Add Synopsys DesignWare xData IP driver

2021-03-29 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver. This driver enables/disables the PCI traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Kconfig | 10 ++ drivers/misc/Makefile| 1 + drivers/misc/dw-xdata-pcie.c

[PATCH v8 3/5] MAINTAINERS: Add Synopsys xData IP driver maintainer

2021-03-29 Thread Gustavo Pimentel
Add Synopsys xData IP driver maintainer. This driver aims to support Synopsys xData IP and is normally distributed along with Synopsys PCIe EndPoint IP as a PCIe traffic generator (depends of the use and licensing agreement). Signed-off-by: Gustavo Pimentel --- MAINTAINERS | 7 +++ 1 file

[PATCH v8 4/5] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

2021-03-29 Thread Gustavo Pimentel
This patch describes the sysfs interface implemented on the dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/ABI/testing/sysfs-driver-xdata | 46 1 file changed, 46 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-xdata

[PATCH v8 2/5] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

2021-03-29 Thread Gustavo Pimentel
Add Documentation for dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdata-pcie.rst | 40 1 file changed, 40 insertions(+) create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst diff --git a/Documentation/misc

[PATCH v8 5/5] FIX driver

2021-03-29 Thread Gustavo Pimentel
Signed-off-by: Gustavo Pimentel --- drivers/misc/dw-xdata-pcie.c | 99 +--- 1 file changed, 57 insertions(+), 42 deletions(-) diff --git a/drivers/misc/dw-xdata-pcie.c b/drivers/misc/dw-xdata-pcie.c index 43fdd35..011516b 100644 --- a/drivers/misc/dw

[PATCH v9 2/4] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

2021-03-29 Thread Gustavo Pimentel
Add Documentation for dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdata-pcie.rst | 40 1 file changed, 40 insertions(+) create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst diff --git a/Documentation/misc

[PATCH v9 3/4] MAINTAINERS: Add Synopsys xData IP driver maintainer

2021-03-29 Thread Gustavo Pimentel
Add Synopsys xData IP driver maintainer. This driver aims to support Synopsys xData IP and is normally distributed along with Synopsys PCIe EndPoint IP as a PCIe traffic generator (depends of the use and licensing agreement). Signed-off-by: Gustavo Pimentel --- MAINTAINERS | 7 +++ 1 file

[PATCH v9 1/4] misc: Add Synopsys DesignWare xData IP driver

2021-03-29 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver. This driver enables/disables the PCI traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Kconfig | 10 ++ drivers/misc/Makefile| 1 + drivers/misc/dw-xdata-pcie.c

[PATCH v9 0/4] misc: Add Add Synopsys DesignWare xData IP driver

2021-03-29 Thread Gustavo Pimentel
er.kernel.org Cc: Derek Kiernan Cc: Dragan Cvetic Cc: Arnd Bergmann Cc: Andrew Morton Cc: Greg Kroah-Hartman Cc: Jonathan Corbet Cc: Bjorn Helgaas Cc: Krzysztof Wilczy??ski Gustavo Pimentel (4): misc: Add Synopsys DesignWare xData IP driver Documentation: misc-devices: Add Documentat

[PATCH v9 4/4] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

2021-03-29 Thread Gustavo Pimentel
This patch describes the sysfs interface implemented on the dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/ABI/testing/sysfs-driver-xdata | 46 1 file changed, 46 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-xdata

RE: [PATCH v8 5/5] FIX driver

2021-03-29 Thread Gustavo Pimentel
On Mon, Mar 29, 2021 at 11:3:3, Willy Tarreau wrote: > On Mon, Mar 29, 2021 at 11:51:38AM +0200, Gustavo Pimentel wrote: > > Signed-off-by: Gustavo Pimentel > > Please make an effort, this is in no way an acceptable commit description > for a patch. The subject is already ex

RE: [PATCH v9 4/4] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

2021-03-29 Thread Gustavo Pimentel
On Mon, Mar 29, 2021 at 11:8:11, Greg Kroah-Hartman wrote: > On Mon, Mar 29, 2021 at 11:59:40AM +0200, Gustavo Pimentel wrote: > > This patch describes the sysfs interface implemented on the dw-xdata-pcie > > driver. > > > > Signed-off-by: Gustavo Pimentel >

RE: [PATCH v9 4/4] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

2021-03-29 Thread Gustavo Pimentel
On Mon, Mar 29, 2021 at 11:40:28, Greg Kroah-Hartman wrote: > On Mon, Mar 29, 2021 at 10:25:25AM +0000, Gustavo Pimentel wrote: > > On Mon, Mar 29, 2021 at 11:8:11, Greg Kroah-Hartman > > wrote: > > > > > On Mon, Mar 29, 2021 at 11:59:40AM +0200, Gustavo Pime

[PATCH v10 1/4] misc: Add Synopsys DesignWare xData IP driver

2021-03-29 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver. This driver enables/disables the PCI traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Kconfig | 10 ++ drivers/misc/Makefile| 1 + drivers/misc/dw-xdata-pcie.c

[PATCH v10 0/4] misc: Add Synopsys DesignWare xData IP driver

2021-03-29 Thread Gustavo Pimentel
sing kstrtobool() Removed stop_store() Update ABI documentation accordingly Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Derek Kiernan Cc: Dragan Cvetic Cc: Arnd Bergmann Cc: Andrew Morton Cc: Greg Kroah-Hartman Cc: Jonathan Corbet Cc:

[PATCH v10 4/4] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

2021-03-29 Thread Gustavo Pimentel
This patch describes the sysfs interface implemented on the dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/ABI/testing/sysfs-driver-xdata | 49 1 file changed, 49 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-xdata

[PATCH v10 2/4] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

2021-03-29 Thread Gustavo Pimentel
Add Documentation for dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdata-pcie.rst | 40 1 file changed, 40 insertions(+) create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst diff --git a/Documentation/misc

[PATCH v10 3/4] MAINTAINERS: Add Synopsys xData IP driver maintainer

2021-03-29 Thread Gustavo Pimentel
Add Synopsys xData IP driver maintainer. This driver aims to support Synopsys xData IP and is normally distributed along with Synopsys PCIe EndPoint IP as a PCIe traffic generator (depends of the use and licensing agreement). Signed-off-by: Gustavo Pimentel --- MAINTAINERS | 7 +++ 1 file

[PATCH v7 2/5] misc: Add Synopsys DesignWare xData IP driver to Makefile and Kconfig

2021-03-26 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver to Makefile and Kconfig. This driver enables/disables the PCIe traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Kconfig | 10 ++ drivers/misc/Makefile | 1 + 2 files changed

[PATCH v7 3/5] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

2021-03-26 Thread Gustavo Pimentel
Add Documentation for dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdata-pcie.rst | 40 1 file changed, 40 insertions(+) create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst diff --git a/Documentation/misc

[PATCH v7 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2021-03-26 Thread Gustavo Pimentel
el@vger.kernel.org Cc: Derek Kiernan Cc: Dragan Cvetic Cc: Arnd Bergmann Cc: Andrew Morton Cc: Greg Kroah-Hartman Cc: Jonathan Corbet Cc: Bjorn Helgaas Cc: Krzysztof Wilczy??ski Gustavo Pimentel (5): misc: Add Synopsys DesignWare xData IP driver misc: Add Synopsys DesignWare xData IP driver

[PATCH v7 5/5] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

2021-03-26 Thread Gustavo Pimentel
This patch describes the sysfs interface implemented on the dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/ABI/testing/sysfs-driver-xdata | 46 1 file changed, 46 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-xdata

[PATCH v7 4/5] MAINTAINERS: Add Synopsys xData IP driver maintainer

2021-03-26 Thread Gustavo Pimentel
Add Synopsys xData IP driver maintainer. This driver aims to support Synopsys xData IP and is normally distributed along with Synopsys PCIe EndPoint IP as a PCIe traffic generator (depends of the use and licensing agreement). Signed-off-by: Gustavo Pimentel --- MAINTAINERS | 7 +++ 1 file

[PATCH v7 1/5] misc: Add Synopsys DesignWare xData IP driver

2021-03-26 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver. This driver enables/disables the PCI traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/dw-xdata-pcie.c | 401 +++ 1 file changed, 401 insertions

RE: [PATCH v7 1/5] misc: Add Synopsys DesignWare xData IP driver

2021-03-28 Thread Gustavo Pimentel
On Sun, Mar 28, 2021 at 13:49:13, Greg Kroah-Hartman wrote: > On Sat, Mar 27, 2021 at 04:06:51AM +0100, Gustavo Pimentel wrote: > > Add Synopsys DesignWare xData IP driver. This driver enables/disables > > the PCI traffic generator module pertain to the Synopsys DesignWar

RE: linux-next: build warning after merge of the char-misc tree

2021-04-06 Thread Gustavo Pimentel
On Tue, Apr 6, 2021 at 15:7:23, Greg KH wrote: > On Tue, Apr 06, 2021 at 09:44:41PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > After merging the char-misc tree, today's linux-next build (htmldocs) > > produced this warning: > > > > Documentation/misc-devices/dw-xdata-pcie.rst:20: WARNIN

[PATCH v11 0/4] misc: Add Synopsys DesignWare xData IP driver

2021-04-06 Thread Gustavo Pimentel
Arnd Bergmann Cc: Andrew Morton Cc: Greg Kroah-Hartman Cc: Jonathan Corbet Cc: Bjorn Helgaas Cc: Krzysztof Wilczy??ski Cc: Stephen Rothwell Gustavo Pimentel (4): misc: Add Synopsys DesignWare xData IP driver Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver MAIN

[PATCH v11 1/4] misc: Add Synopsys DesignWare xData IP driver

2021-04-06 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver. This driver enables/disables the PCI traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Kconfig | 10 ++ drivers/misc/Makefile| 1 + drivers/misc/dw-xdata-pcie.c

[PATCH v11 4/4] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

2021-04-06 Thread Gustavo Pimentel
This patch describes the sysfs interface implemented on the dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/ABI/testing/sysfs-driver-xdata | 49 1 file changed, 49 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-xdata

[PATCH v11 3/4] MAINTAINERS: Add Synopsys xData IP driver maintainer

2021-04-06 Thread Gustavo Pimentel
Add Synopsys xData IP driver maintainer. This driver aims to support Synopsys xData IP and is normally distributed along with Synopsys PCIe EndPoint IP as a PCIe traffic generator (depends of the use and licensing agreement). Signed-off-by: Gustavo Pimentel --- MAINTAINERS | 7 +++ 1 file

[PATCH v11 2/4] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

2021-04-06 Thread Gustavo Pimentel
Add Documentation for dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdata-pcie.rst | 64 Documentation/misc-devices/index.rst | 1 + 2 files changed, 65 insertions(+) create mode 100644 Documentation/misc-devices

RE: linux-next: build warning after merge of the char-misc tree

2021-04-06 Thread Gustavo Pimentel
On Tue, Apr 6, 2021 at 15:15:40, Greg KH wrote: > On Tue, Apr 06, 2021 at 02:13:53PM +0000, Gustavo Pimentel wrote: > > On Tue, Apr 6, 2021 at 15:7:23, Greg KH wrote: > > > > > On Tue, Apr 06, 2021 at 09:44:41PM +1000, Stephen Rothwell wrote: > > > > Hi all

[PATCH] Documentation: misc-devices: Fix indentation, formatting, and update outdated info

2021-04-06 Thread Gustavo Pimentel
Fixes indentation issues reported by doing *make htmldocs* as well some text formatting. Besides these fixes, there was some outdated information related to stop file interface in sysfs. Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdata-pcie.rst | 62

[PATCH] Documentation: misc-devices: Add missing entry on the table of content related to dw-xdata-pcie

2021-04-06 Thread Gustavo Pimentel
Add missing entry on the table of content related to dw-xdata-pcie misc driver reported in a warning by doing *make htmldocs*. Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/misc-devices/index.rst b

[PATCH v2 0/2] Documentation: misc-devices: Fix documentation issues (indentation, text format, toc) and outdated information

2021-04-06 Thread Gustavo Pimentel
: Jonathan Corbet Cc: Bjorn Helgaas Cc: Krzysztof Wilczy??ski Cc: Stephen Rothwell Gustavo Pimentel (2): Documentation: misc-devices: Fix indentation, formatting, and update outdated info Documentation: misc-devices: Add missing entry on the table of content related to dw-xdata-pcie

[PATCH v2 1/2] Documentation: misc-devices: Fix indentation, formatting, and update outdated info

2021-04-06 Thread Gustavo Pimentel
nk: https://lore.kernel.org/linux-next/20210406214615.40cf3...@canb.auug.org.au/ Reported-by: Stephen Rothwell Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdata-pcie.rst | 62 +++- 1 file changed, 43 insertions(+), 19 deletions(-) diff --git a/Doc

[PATCH v2 2/2] Documentation: misc-devices: Add missing entry on the table of content related to dw-xdata-pcie

2021-04-06 Thread Gustavo Pimentel
4615.40cf3...@canb.auug.org.au/ Reported-by: Stephen Rothwell Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/misc-devices/index.rst b/Documentation/misc-devices/index.rst index 64420b331..30ac58f 100644 --- a/Doc

[PATCH v4 1/2] dw-xdata-pcie: Fix documentation build warns

2021-04-10 Thread Gustavo Pimentel
ctree Fixes: e1181b5bbc3c ("Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver") Link: https://lore.kernel.org/linux-next/20210406214615.40cf3...@canb.auug.org.au/ Reported-by: Stephen Rothwell Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdat

[PATCH v4 2/2] dw-xdata-pcie: Update outdated info and improve text format

2021-04-10 Thread Gustavo Pimentel
Removes old information related to the stop file interface in sysfs left by mistake during patch revision. Improves the document text format to be more user-friendly and adds basic driver related information, such as support, datasheet, and author. Signed-off-by: Gustavo Pimentel

[PATCH v4 0/2] dw-xdata-pcie: Fix documentation build warns

2021-04-10 Thread Gustavo Pimentel
orn Helgaas Cc: Krzysztof Wilczy??ski Cc: Stephen Rothwell Gustavo Pimentel (2): dw-xdata-pcie: Fix documentation build warns dw-xdata-pcie: Update outdated info and improve text format Documentation/misc-devices/dw-xdata-pcie.rst | 76 ++-- Documentation/misc-de

RE: [PATCH v2 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2020-11-17 Thread Gustavo Pimentel
On Tue, Nov 17, 2020 at 14:4:49, Arnd Bergmann wrote: > On Fri, Nov 13, 2020 at 11:37 PM Gustavo Pimentel > wrote: > > > > This patch series adds a new driver called xData-pcie for the Synopsys > > DesignWare PCIe prototype. > > > > The driver configures and

[PATCH] PCI: Decode PCIe 64 GT/s link speed

2020-11-18 Thread Gustavo Pimentel
decoding of this new speed, previously, reading the speed of a link operating at this speed showed "Unknown speed" instead of "64.0 GT/s". Signed-off-by: Gustavo Pimentel --- drivers/pci/pci.h | 6 -- drivers/pci/probe.c | 3 ++- include/linux/pci.h

[PATCH] dt-bindings: Fix typo on the DesignWare IP reset bindings documentation

2020-11-18 Thread Gustavo Pimentel
This patch removes a loose "i" character is present on the current documentation. Signed-off-by: Gustavo Pimentel --- Documentation/devicetree/bindings/reset/snps,dw-reset.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/res

[PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2020-11-19 Thread Gustavo Pimentel
: V2: Rework driver according to Greg Kroah-Hartman feedback V3: Fixed issues detected while running on 64 bits platforms Gustavo Pimentel (5): misc: Add Synopsys DesignWare xData IP driver misc: Add Synopsys DesignWare xData IP driver to Makefile misc: Add Synopsys DesignWare xData IP

[PATCH v3 1/5] misc: Add Synopsys DesignWare xData IP driver

2020-11-19 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver. This driver enables/disables the PCI traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/dw-xdata-pcie.c | 379 +++ 1 file changed, 379 insertions

[PATCH v3 2/5] misc: Add Synopsys DesignWare xData IP driver to Makefile

2020-11-19 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver to Makefile. This driver enables/disables the PCIe traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/Makefile

[PATCH v3 3/5] misc: Add Synopsys DesignWare xData IP driver to Kconfig

2020-11-19 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver to Kconfig. This driver enables/disables the PCIe traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Kconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers

[PATCH v3 5/5] MAINTAINERS: Add Synopsys xData IP driver maintainer

2020-11-19 Thread Gustavo Pimentel
Add Synopsys xData IP driver maintainer. This driver aims to support Synopsys xData IP and is normally distributed along with Synopsys PCIe EndPoint IP as a PCIe traffic generator (depends of the use and licensing agreement). Signed-off-by: Gustavo Pimentel --- MAINTAINERS | 7 +++ 1 file

[PATCH v3 4/5] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

2020-11-19 Thread Gustavo Pimentel
Add Documentation for dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdata-pcie.rst | 40 1 file changed, 40 insertions(+) create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst diff --git a/Documentation/misc

RE: [RESEND PATCH v3 3/5] misc: Add Synopsys DesignWare xData IP driver to Kconfig

2021-02-08 Thread Gustavo Pimentel
On Mon, Feb 8, 2021 at 7:34:8, Leon Romanovsky wrote: > On Tue, Feb 02, 2021 at 05:56:36PM +0100, Gustavo Pimentel wrote: > > Add Synopsys DesignWare xData IP driver to Kconfig. > > > > This driver enables/disables the PCIe traffic generator module > > pertain

RE: [RESEND v4 4/6] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

2021-02-08 Thread Gustavo Pimentel
Hi Krzysztof, On Sat, Feb 6, 2021 at 23:31:14, Krzysztof Wilczyński wrote: > Hi Gustavo, > > [...] > > +The interaction with this driver is done through the module parameter and > > +can be changed in runtime. The driver outputs the requested command state > > +information to /var/log/kern.log

RE: [RESEND v4 1/6] misc: Add Synopsys DesignWare xData IP driver

2021-02-08 Thread Gustavo Pimentel
On Sun, Feb 7, 2021 at 1:36:15, Krzysztof Wilczyński wrote: > Hi Gustavo, > > Thank you for all the work here! > > A few suggestions. > > [...] > > +static void dw_xdata_stop(struct dw_xdata *dw) > > +{ > > + u32 burst = readl(&(__dw_xdara_regs(dw)->burst_cnt)); > > + > > + if (burst & BI

[PATCH 00/15] dmaengine: dw-edma: HDMA support

2020-12-15 Thread Gustavo Pimentel
ss calculation on 32 bits platforms - minor comment and variable reordering Cc: Vinod Koul Cc: Dan Williams Cc: Bjorn Helgaas Cc: dmaeng...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-...@vger.kernel.org Gustavo Pimentel (15): dmaengine: dw-edma: Add writeq() and readq()

[PATCH 03/15] dmaengine: dw-edma: Add support for the HDMA feature

2020-12-15 Thread Gustavo Pimentel
Add support for the HDMA feature. This new feature enables the current eDMA IP to use a deeper prefetch of the linked list, which reduces the algorithm execution latency observed when loading the elements of the list, causing more stable and higher data transfer. Signed-off-by: Gustavo Pimentel

[PATCH 05/15] dmaengine: dw-edma: Add PCIe VSEC data retrieval support

2020-12-15 Thread Gustavo Pimentel
The latest eDMA IP development implements a Vendor-Specific Extended Capability that contains the eDMA BAR, offset, map format, and the number of read/write channels available. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 20 --- drivers/dma/dw-edma/dw-edma

[PATCH 06/15] dmaengine: dw-edma: Add device_prep_interleave_dma() support

2020-12-15 Thread Gustavo Pimentel
Add device_prep_interleave_dma() support to Synopsys DMA driver. This feature implements a similar data transfer mechanism to the scatter-gather implementation. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 85 ++ drivers/dma/dw

[PATCH 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2020-12-15 Thread Gustavo Pimentel
create their own and specific capability in the device config space. Signed-off-by: Gustavo Pimentel --- drivers/pci/pci.c | 29 + include/linux/pci.h | 1 + include/uapi/linux/pci_regs.h | 5 + 3 files changed, 35 insertions(+) diff --git a

[PATCH 11/15] dmaengine: dw-edma: Move struct dentry variable from static definition into dw_edma struct

2020-12-15 Thread Gustavo Pimentel
Move struct dentry variable from static definition (dw-edma-v0-debugfs.c) into dw_edma struct (dw-edma-core.h) Also the variable was renamed from base_dir to debugfs. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 2 +- drivers/dma/dw-edma/dw-edma-core.h

[PATCH 15/15] dmaengine: dw-edma: Add pcim_iomap_table return checker

2020-12-15 Thread Gustavo Pimentel
Detected by CoverityScan CID 16555 ("Dereference null return") Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c ind

[PATCH 14/15] dmaengine: dw-edma: Revert fix scatter-gather address calculation

2020-12-15 Thread Gustavo Pimentel
Reverting the applied patch because it caused a regression on ARC700 platform (32 bits). Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma

[PATCH 13/15] dmaengine: dw-edma: Change DMA abreviation from lower into upper case

2020-12-15 Thread Gustavo Pimentel
To keep code consistent, some comments with dma keyword written in lower case are now in upper case. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma

[PATCH 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver

2020-12-15 Thread Gustavo Pimentel
When the driver is compiled as a module and loaded if we try to unload it, the Kernel shows a crash log. This Kernel crash is due to the dma_async_device_unregister() call done after deleting the channels, this patch fixes this issue. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw

[PATCH 10/15] dmaengine: dw-edma: Change linked list and data blocks offset and sizes

2020-12-15 Thread Gustavo Pimentel
this solution is based on FPGA and might be subjected to timmings constrains. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers

[PATCH 01/15] dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures

2020-12-15 Thread Gustavo Pimentel
generate a 64 bits message instead of two messages of 32 bits. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-core.c| 254 +++ drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 48 +++--- drivers/dma/dw-edma/dw-edma-v0-regs.h| 149 +- 3

[PATCH 09/15] dmaengine: dw-edma: Improve the linked list and data blocks definition

2020-12-15 Thread Gustavo Pimentel
own linked list and data space well defined, which allows different sizes and locations. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 51 +- drivers/dma/dw-edma/dw-edma-core.h | 9 +- drivers/dma/dw-edma/dw-edma-pcie.c | 185

[PATCH 02/15] dmaengine: dw-edma: Fix comments offset characters' alignment

2020-12-15 Thread Gustavo Pimentel
Fix comments offset characters' alignment to follow the same structure of similar comments. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-regs.h | 214 +- 1 file changed, 107 insertions(+), 107 deletions(-) diff --git a/drivers/dma/dw

[PATCH 07/15] dmaengine: dw-edma: Improve number of channels check

2020-12-15 Thread Gustavo Pimentel
It was added some extra checks to ensure that the driver doesn't try to use more DMA channels than actually are available in hardware. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 21 + drivers/dma/dw-edma/dw-edma-core.h | 2 ++ 2 files ch

[PATCH 08/15] dmaengine: dw-edma: Reorder variables to keep consistency

2020-12-15 Thread Gustavo Pimentel
functional changes are expected. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 2bd31b0..ebb2605 100644 --- a/drivers/dma

Re: [PATCH v2] PCI: endpoint: functions: Use kmemdup instead of duplicating its function

2019-02-11 Thread Gustavo Pimentel
o kmemdup rather than code opened implementation. >>> >>> This issue was detected with the help of coccinelle. >>> >>> Signed-off-by: Wen Yang >>> CC: Kishon Vijay Abraham I >>> CC: Lorenzo Pieralisi >>> CC: Bjorn Helgaas >>>

Re: [PATCH v2 00/15] PCI: endpoint: Cleanup EPC features

2019-02-11 Thread Gustavo Pimentel
.c | 53 +++ > drivers/pci/endpoint/pci-epf-core.c | 4 +- > include/linux/pci-epc.h | 31 +-- > 10 files changed, 201 insertions(+), 64 deletions(-) > Sorry for the delay, I had a problem with my setup. Tested-by: Gustavo Pimentel

Re: [PATCH v3 2/5] PCI: dwc: Free the page for MSI IRQ in dw_pcie_free_msi()

2019-03-18 Thread Gustavo Pimentel
dwc/pcie-designware.h > @@ -179,6 +179,7 @@ struct pcie_port { > struct irq_domain *irq_domain; > struct irq_domain *msi_domain; > dma_addr_t msi_data; > + struct page *msi_page; > u32 num_vectors; > u32 irq_mask[MAX_MSI_CTRLS]; > raw_spinlock_t lock; > Acked-by: Gustavo Pimentel

Re: [PATCH v3 5/5] PCI: dwc: Save root bus for driver remove

2019-03-18 Thread Gustavo Pimentel
ge; > u32 num_vectors; > u32 irq_mask[MAX_MSI_CTRLS]; > + struct pci_bus *root_bus; > raw_spinlock_t lock; > DECLARE_BITMAP(msi_irq_in_use, MAX_MSI_IRQS); > }; > Acked-by: Gustavo Pimentel

RE: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-12 Thread Gustavo Pimentel
On Thu, Sep 12, 2019 at 10:23:31, Dilip Kota wrote: > Quoting Andrew Murray: > Quoting Gustavo Pimentel: > > On 9/12/2019 4:25 PM, Andrew Murray wrote: > > [...] > >>>>>>>>>> +static void intel_pcie_max_link_wi

RE: [PATCH v3 08/11] PCI: layerscape: Modify the MSIX to the doorbell mode

2019-09-12 Thread Gustavo Pimentel
Hi, Sorry for the delay I was in parental leave and I'm still trying not to drown in the mailing list emails... 😊 On Mon, Sep 2, 2019 at 13:1:47, Andrew Murray wrote: > On Mon, Sep 02, 2019 at 11:17:13AM +0800, Xiaowei Bao wrote: > > dw_pcie_ep_raise_msix_irq was never called in the exisitng

RE: [PATCH] PCI: dwc: fix find_next_bit() usage

2019-09-12 Thread Gustavo Pimentel
QS_PER_CTRL, > + while ((pos = find_next_bit(&val, MAX_MSI_IRQS_PER_CTRL, > pos)) != MAX_MSI_IRQS_PER_CTRL) { > irq = irq_find_mapping(pp->irq_domain, > (i * MAX_MSI_IRQS_PER_CTRL) + > -- > 2.21.0 Hi Niklas! The patch looks nice! Thanks! Acked-by: Gustavo Pimentel

RE: [PATCH 1/2] PCI: dwc: Add support to disable GEN3 equalization

2019-09-12 Thread Gustavo Pimentel
Hi, On Tue, Sep 10, 2019 at 13:25:1, Pankaj Dubey wrote: > From: Anvesh Salveru > > In some platforms, PCIe PHY may have issues which will prevent linkup > to happen in GEN3 or high speed. In case equalization fails, link will > fallback to GEN1. > > Designware controller has support for dis

RE: [PATCH v3 08/11] PCI: layerscape: Modify the MSIX to the doorbell mode

2019-09-16 Thread Gustavo Pimentel
On Sat, Sep 14, 2019 at 7:37:54, Xiaowei Bao wrote: > > > > -Original Message- > > From: Gustavo Pimentel > > Sent: 2019年9月12日 19:24 > > To: Andrew Murray ; Xiaowei Bao > > > > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn

RE: [PATCH v2] PCI: dwc: Add support to add GEN3 related equalization quirks

2019-09-16 Thread Gustavo Pimentel
Q_DISABLE BIT(16) > + > #define PCIE_ATU_VIEWPORT0x900 > #define PCIE_ATU_REGION_INBOUND BIT(31) > #define PCIE_ATU_REGION_OUTBOUND 0 > @@ -244,6 +252,7 @@ struct dw_pcie { > struct dw_pcie_ep ep; > const struct dw_pcie_ops *ops; > unsigned intversion; > + unsigned intquirk; > }; > > #define to_dw_pcie_from_pp(port) container_of((port), struct dw_pcie, pp) > -- > 2.7.4 Acked-by: Gustavo Pimentel

RE: [PATCH v2] PCI: dwc: Add support to add GEN3 related equalization quirks

2019-09-16 Thread Gustavo Pimentel
On Mon, Sep 16, 2019 at 13:24:1, Andrew Murray wrote: > On Mon, Sep 16, 2019 at 04:36:33PM +0530, Pankaj Dubey wrote: > > > > > > > -Original Message- > > > From: Andrew Murray > > > Sent: Monday, September 16, 2019 3:46 PM > > > To: Pankaj Dubey > > > Cc: linux-...@vger.kernel.org;

RE: [PATCH v3 03/26] PCI: dwc: Use PCI_STD_NUM_BARS

2019-09-17 Thread Gustavo Pimentel
c C style and allows to avoid > the fencepost error. Array definitions changed to PCI_STD_NUM_BARS where > appropriate. > > Cc: Kishon Vijay Abraham I > Cc: Lorenzo Pieralisi > Cc: Gustavo Pimentel > Signed-off-by: Denis Efremov > --- > drivers/pci/controller/dwc/p

RE: [PATCH v4 01/11] PCI: designware-ep: Add multiple PFs support for DWC

2019-09-26 Thread Gustavo Pimentel
_ENABLE BIT(31) > #define PCIE_ATU_BAR_MODE_ENABLE BIT(30) > +#define PCIE_ATU_FUNC_NUM_MATCH_EN BIT(19) > #define PCIE_ATU_LOWER_BASE 0x90C > #define PCIE_ATU_UPPER_BASE 0x910 > #define PCIE_ATU_LIMIT 0x914 > @@ -206,6 +208,14 @@ struct dw_pcie_ep_ops { > int (*raise_irq)(struct dw_pcie_ep *ep, u8 func_no, >enum pci_epc_irq_type type, u16 interrupt_num); > const struct pci_epc_features* (*get_features)(struct dw_pcie_ep *ep); > + /* > + * Provide a method to implement the different func config space > + * access for different platform, if different func have different > + * offset, return the offset of func. if use write a register way > + * return a 0, and implement code in callback function of platform > + * driver. > + */ > + unsigned int (*func_conf_select)(struct dw_pcie_ep *ep, u8 func_no); > }; > > struct dw_pcie_ep { > @@ -277,8 +287,12 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci); > void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, > int type, u64 cpu_addr, u64 pci_addr, > u32 size); > -int dw_pcie_prog_inbound_atu(struct dw_pcie *pci, int index, int bar, > - u64 cpu_addr, enum dw_pcie_as_type as_type); > +void dw_pcie_prog_ep_outbound_atu(struct dw_pcie *pci, u8 func_no, int index, > + int type, u64 cpu_addr, u64 pci_addr, > + u32 size); > +int dw_pcie_prog_inbound_atu(struct dw_pcie *pci, u8 func_no, int index, > + int bar, u64 cpu_addr, > + enum dw_pcie_as_type as_type); > void dw_pcie_disable_atu(struct dw_pcie *pci, int index, >enum dw_pcie_region_type type); > void dw_pcie_setup(struct dw_pcie *pci); > -- > 2.9.5 Acked-by: Gustavo Pimentel

RE: [PATCH v3 01/11] PCI: designware-ep: Add multiple PFs support for DWC

2019-09-26 Thread Gustavo Pimentel
On Thu, Sep 26, 2019 at 11:29:46, Andrew Murray wrote: > On Tue, Sep 03, 2019 at 03:43:15AM +, Xiaowei Bao wrote: > > > > > > > -Original Message- > > > From: Andrew Murray > > > Sent: 2019年9月3日 0:26 > > > To: Xiaowei Bao > > > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn.

RE: [PATCH v4 0/3] PCI: Add Intel PCIe Driver and respective dt-binding yaml file

2019-10-21 Thread Gustavo Pimentel
Hi, On Mon, Oct 21, 2019 at 7:39:17, Dilip Kota wrote: > Intel PCIe is synopsys based controller utilizes the Designware Please do this general replacement in all your patches. s/synopsys/Synopsys and s/Designware/DesignWare > framework for host initialization and intel application > spec

RE: [PATCH v4 2/3] dwc: PCI: intel: PCIe RC controller driver

2019-10-21 Thread Gustavo Pimentel
Hi On Mon, Oct 21, 2019 at 7:39:19, Dilip Kota wrote: > Add support to PCIe RC controller on Intel Gateway SoCs. > PCIe controller is based of Synopsys DesignWare pci core. > > Intel PCIe driver requires Upconfig support, fast training > sequence configuration and link speed change. So adding

RE: [PATCH v4 3/3] pci: intel: Add sysfs attributes to configure pcie link

2019-10-21 Thread Gustavo Pimentel
On Mon, Oct 21, 2019 at 7:39:20, Dilip Kota wrote: > PCIe RC driver on Intel Gateway SoCs have a requirement > of changing link width and speed on the fly. > So add the sysfs attributes to show and store the link > properties. > Add the respective link resize function in pcie DesignWare > framew

RE: [PATCH 1/2] dt-bindings: PCI: designware: Add binding for ZRX-DC PHY property

2019-10-21 Thread Gustavo Pimentel
; +- snps,phy-zrxdc-compliant: This property is needed if phy complies with the > + ZRX-DC specification. > RC mode: > - num-viewport: number of view ports configured in hardware. If a platform > does not specify it, the driver assumes 2. > -- > 2.17.1 Reviewed-by: Gustavo Pimentel

RE: [PATCH 2/2] PCI: dwc: Add support to handle ZRX-DC Compliant PHYs

2019-10-21 Thread Gustavo Pimentel
/controller/dwc/pcie-designware.h > @@ -60,6 +60,9 @@ > #define PCIE_MSI_INTR0_MASK 0x82C > #define PCIE_MSI_INTR0_STATUS0x830 > > +#define PCIE_PORT_GEN3_RELATED 0x890 > +#define PORT_LOGIC_GEN3_ZRXDC_NONCOMPL BIT(0) > + >

Re: [PATCH 1/2] Acked-by: Gustavo Pimentel

2019-02-07 Thread Gustavo Pimentel
> struct device *dev; > void __iomem*dbi_base; > + int dbi_length; > void __iomem*dbi_base2; > /* Used when iatu_unroll_enabled is true */ > void __iomem*atu_base; > Acked-by: Gustavo Pimentel

Re: [PATCH 18/24] PCI: dwc: Fix dw_pcie_ep_find_capability to return correct capability offset

2019-01-29 Thread Gustavo Pimentel
Hi Kishon, On 14/01/2019 13:24, Kishon Vijay Abraham I wrote: > commit beb4641a787df79a ("PCI: dwc: Add MSI-X callbacks handler") while > adding MSI-X callback handler, introduced dw_pcie_ep_find_capability and > __dw_pcie_ep_find_next_cap for finding the MSI and MSIX capability. > > However if M

<    1   2   3   4   5   6   >