[PATCH v5 05/15] dmaengine: dw-edma: Add PCIe VSEC data retrieval support

2021-02-11 Thread Gustavo Pimentel
The latest eDMA IP development implements a Vendor-Specific Extended Capability that contains the eDMA BAR, offset, map format, and the number of read/write channels available. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 20 --- drivers/dma/dw-edma/dw-edma

[PATCH v5 09/15] dmaengine: dw-edma: Improve the linked list and data blocks definition

2021-02-11 Thread Gustavo Pimentel
own linked list and data space well defined, which allows different sizes and locations. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 51 +- drivers/dma/dw-edma/dw-edma-core.h | 9 +- drivers/dma/dw-edma/dw-edma-pcie.c | 185

[PATCH v5 02/15] dmaengine: dw-edma: Fix comments offset characters' alignment

2021-02-11 Thread Gustavo Pimentel
Fix comments offset characters' alignment to follow the same structure of similar comments. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-regs.h | 214 +- 1 file changed, 107 insertions(+), 107 deletions(-) diff --git a/drivers/dma/dw

[PATCH v5 00/15] dmaengine: dw-edma: HDMA support

2021-02-11 Thread Gustavo Pimentel
Rework driver accordingly to Bjorn Helgaas's feedback Gustavo Pimentel (15): dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures dmaengine: dw-edma: Fix comments offset characters' alignment dmaengine: dw-edma: Add support for the HDMA feature PCI: Add pci_f

[PATCH v5 08/15] dmaengine: dw-edma: Reorder variables to keep consistency

2021-02-11 Thread Gustavo Pimentel
functional changes are expected. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 7077d79..9e79eb5 100644 --- a/drivers/dma

[PATCH v5 01/15] dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures

2021-02-11 Thread Gustavo Pimentel
generate a 64 bits message instead of two messages of 32 bits. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-core.c| 254 +++ drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 48 +++--- drivers/dma/dw-edma/dw-edma-v0-regs.h| 149 +- 3

RE: [PATCH v5 2/6] misc: Add Synopsys DesignWare xData IP driver to Makefile

2021-02-11 Thread Gustavo Pimentel
On Thu, Feb 11, 2021 at 9:28:9, Greg Kroah-Hartman wrote: > On Thu, Feb 11, 2021 at 10:08:39AM +0100, Gustavo Pimentel wrote: > > Add Synopsys DesignWare xData IP driver to Makefile. > > > > This driver enables/disables the PCIe traffic generator module > > pertain

RE: [PATCH v5 1/6] misc: Add Synopsys DesignWare xData IP driver

2021-02-11 Thread Gustavo Pimentel
On Thu, Feb 11, 2021 at 9:30:16, Greg Kroah-Hartman wrote: > On Thu, Feb 11, 2021 at 10:08:38AM +0100, Gustavo Pimentel wrote: > > +static ssize_t write_show(struct device *dev, struct device_attribute > > *attr, > > + char *buf) > > +{ &

RE: [PATCH v5 1/6] misc: Add Synopsys DesignWare xData IP driver

2021-02-11 Thread Gustavo Pimentel
On Thu, Feb 11, 2021 at 9:59:26, Greg Kroah-Hartman wrote: > On Thu, Feb 11, 2021 at 09:50:33AM +0000, Gustavo Pimentel wrote: > > On Thu, Feb 11, 2021 at 9:30:16, Greg Kroah-Hartman > > wrote: > > > > > On Thu, Feb 11, 2021 at 10:08:38AM +0100, Gustavo P

RE: [PATCH v5 1/6] misc: Add Synopsys DesignWare xData IP driver

2021-02-11 Thread Gustavo Pimentel
On Thu, Feb 11, 2021 at 10:33:25, Greg Kroah-Hartman wrote: > On Thu, Feb 11, 2021 at 10:21:07AM +0000, Gustavo Pimentel wrote: > > On Thu, Feb 11, 2021 at 9:59:26, Greg Kroah-Hartman > > wrote: > > > > > On Thu, Feb 11, 2021 at 09:50:33AM +, Gustavo Pimen

RE: [PATCH v5 3/6] misc: Add Synopsys DesignWare xData IP driver to Kconfig

2021-02-11 Thread Gustavo Pimentel
On Thu, Feb 11, 2021 at 11:29:43, Krzysztof Wilczyński wrote: > Hi Gustavo, > > [...] > > +config DW_XDATA_PCIE > > + depends on PCI > > + tristate "Synopsys DesignWare xData PCIe driver" > > + help > > + This driver allows controlling Synopsys DesignWare PCIe traffic > > + genera

RE: [PATCH v5 05/15] dmaengine: dw-edma: Add PCIe VSEC data retrieval support

2021-02-11 Thread Gustavo Pimentel
On Thu, Feb 11, 2021 at 12:59:48, Krzysztof Wilczyński wrote: > Hi Gustavo, > > > + /* > > +* Tries to find if exists a PCIe Vendor-Specific Extended Capability > > +* for the DMA, if exists one, then reconfigures with the new data > [...] > > What about "if one exists" and "then rec

RE: [PATCH v6 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2021-02-18 Thread Gustavo Pimentel
es it easier to read the caller.] > > When you post new versions of a series, please cc people who commented > on previous versions. Noted. > > On Fri, Feb 12, 2021 at 06:37:39PM +0100, Gustavo Pimentel wrote: > > Adds another helper to ones that already exist called &

[PATCH v7 15/15] dmaengine: dw-edma: Add pcim_iomap_table return check

2021-02-18 Thread Gustavo Pimentel
Currently, is missing a null check on a pcim_iomap_table() return value and this can lead to a null pointer dereference if the desired BAR wasn't mapped previously. Fix this by adding a null check and returning -ENOMEM. Addresses-Coverity: ("Dereference null return") Signed-

[PATCH v7 08/15] dmaengine: dw-edma: Reorder variables to keep consistency

2021-02-18 Thread Gustavo Pimentel
functional changes are expected. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index eb6f8b3..63c62e1 100644 --- a/drivers/dma

[PATCH v7 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver

2021-02-18 Thread Gustavo Pimentel
When the driver is compiled as a module and loaded if we try to unload it, the Kernel shows a crash log. This Kernel crash is due to the dma_async_device_unregister() call done after deleting the channels, this patch fixes this issue. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw

[PATCH v7 13/15] dmaengine: dw-edma: Change DMA abreviation from lower into upper case

2021-02-18 Thread Gustavo Pimentel
To keep code consistent, some comments with dma keyword written in lower case are now in upper case. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma

[PATCH v7 14/15] dmaengine: dw-edma: Revert fix scatter-gather address calculation

2021-02-18 Thread Gustavo Pimentel
Reverting the applied patch because it caused a regression on ARC700 platform (32 bits). Fixes: 05655541c950 ("dmaengine: dw-edma: Fix scatter-gather address calculation") Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 8 1 file changed, 4 insert

[PATCH v7 01/15] dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures

2021-02-18 Thread Gustavo Pimentel
generate a 64 bits message instead of two messages of 32 bits. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-core.c| 254 +++ drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 48 +++--- drivers/dma/dw-edma/dw-edma-v0-regs.h| 149 +- 3

[PATCH v7 10/15] dmaengine: dw-edma: Change linked list and data blocks offset and sizes

2021-02-18 Thread Gustavo Pimentel
this solution is based on FPGA and might be subjected to timmings constrains. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers

[PATCH v7 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2021-02-18 Thread Gustavo Pimentel
Add pci_find_vsec_capability() to locate a Vendor-Specific Extended Capability with the specified VSEC ID. The Vendor-Specific Extended Capability (VSEC) allows one or more proprietary capabilities defined by the vendor which aren't standard or shared between vendors. Signed-off-by: Gu

[PATCH v7 09/15] dmaengine: dw-edma: Improve the linked list and data blocks definition

2021-02-18 Thread Gustavo Pimentel
its own linked list and data space well defined, which allows different sizes and locations. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 51 +- drivers/dma/dw-edma/dw-edma-core.h | 9 +- drivers/dma/dw-edma/dw-edma-pcie.c | 185

[PATCH v7 06/15] dmaengine: dw-edma: Add device_prep_interleave_dma() support

2021-02-18 Thread Gustavo Pimentel
Add device_prep_interleave_dma() support to Synopsys DMA driver. This feature implements a similar data transfer mechanism to the scatter-gather implementation. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 85 ++ drivers/dma/dw

[PATCH v7 05/15] dmaengine: dw-edma: Add PCIe VSEC data retrieval support

2021-02-18 Thread Gustavo Pimentel
The latest eDMA IP development implements a Vendor-Specific Extended Capability that contains the eDMA BAR, offset, map format, and the number of read/write channels available. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 20 --- drivers/dma/dw-edma/dw-edma

[PATCH v7 11/15] dmaengine: dw-edma: Move struct dentry variable from static definition into dw_edma struct

2021-02-18 Thread Gustavo Pimentel
Move struct dentry variable from static definition (dw-edma-v0-debugfs.c) into dw_edma struct (dw-edma-core.h) Also the variable was renamed from base_dir to debugfs. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 2 +- drivers/dma/dw-edma/dw-edma-core.h

[PATCH v7 00/15] dmaengine: dw-edma: HDMA support

2021-02-18 Thread Gustavo Pimentel
* defines Cc: dmaeng...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Vinod Koul Cc: Dan Williams Cc: Bjorn Helgaas Cc: Krzysztof Wilczy??ski Cc: Lukas Wunner Gustavo Pimentel (15): dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures dmaengine:

[PATCH v7 03/15] dmaengine: dw-edma: Add support for the HDMA feature

2021-02-18 Thread Gustavo Pimentel
Add support for the HDMA feature. This new feature enables the current eDMA IP to use a deeper prefetch of the linked list, which reduces the algorithm execution latency observed when loading the elements of the list, causing more stable and higher data transfer. Signed-off-by: Gustavo Pimentel

[PATCH v7 02/15] dmaengine: dw-edma: Fix comments offset characters' alignment

2021-02-18 Thread Gustavo Pimentel
Fix comments offset characters' alignment to follow the same structure of similar comments. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-regs.h | 214 +- 1 file changed, 107 insertions(+), 107 deletions(-) diff --git a/drivers/dma/dw

[PATCH v7 07/15] dmaengine: dw-edma: Improve number of channels check

2021-02-18 Thread Gustavo Pimentel
It was added some extra checks to ensure that the driver doesn't try to use more DMA channels than actually are available in hardware. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 21 + drivers/dma/dw-edma/dw-edma-core.h | 2 ++ 2 files ch

RE: [PATCH v7 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2021-02-18 Thread Gustavo Pimentel
On Thu, Feb 18, 2021 at 19:27:30, Bjorn Helgaas wrote: > On Thu, Feb 18, 2021 at 08:03:58PM +0100, Gustavo Pimentel wrote: > > Add pci_find_vsec_capability() to locate a Vendor-Specific Extended > > Capability with the specified VSEC ID. > > > > The Vendor-Specifi

[RESEND PATCH v3 1/5] misc: Add Synopsys DesignWare xData IP driver

2021-02-02 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver. This driver enables/disables the PCI traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/dw-xdata-pcie.c | 379 +++ 1 file changed, 379 insertions

[RESEND PATCH v3 5/5] MAINTAINERS: Add Synopsys xData IP driver maintainer

2021-02-02 Thread Gustavo Pimentel
Add Synopsys xData IP driver maintainer. This driver aims to support Synopsys xData IP and is normally distributed along with Synopsys PCIe EndPoint IP as a PCIe traffic generator (depends of the use and licensing agreement). Signed-off-by: Gustavo Pimentel --- MAINTAINERS | 7 +++ 1 file

RE: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2021-02-02 Thread Gustavo Pimentel
On Tue, Feb 2, 2021 at 10:43:3, Greg Kroah-Hartman wrote: > On Tue, Feb 02, 2021 at 10:38:29AM +0000, Gustavo Pimentel wrote: > > On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman > > wrote: > > > > > On Tue, Feb 02, 2021 at 08:51:10AM +, Gustavo Pimente

[RESEND PATCH v3 2/5] misc: Add Synopsys DesignWare xData IP driver to Makefile

2021-02-02 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver to Makefile. This driver enables/disables the PCIe traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/Makefile

[RESEND PATCH v3 4/5] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

2021-02-02 Thread Gustavo Pimentel
Add Documentation for dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdata-pcie.rst | 40 1 file changed, 40 insertions(+) create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst diff --git a/Documentation/misc

[RESEND PATCH v3 3/5] misc: Add Synopsys DesignWare xData IP driver to Kconfig

2021-02-02 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver to Kconfig. This driver enables/disables the PCIe traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Kconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers

[RESEND PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2021-02-02 Thread Gustavo Pimentel
: Dragan Cvetic Cc: Arnd Bergmann Cc: Andrew Morton Cc: Greg Kroah-Hartman Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Gustavo Pimentel (5): misc: Add Synopsys DesignWare xData IP driver misc: Add Synopsys DesignWare xData

RE: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2021-02-02 Thread Gustavo Pimentel
On Tue, Feb 2, 2021 at 17:8:21, Greg Kroah-Hartman wrote: > On Tue, Feb 02, 2021 at 04:58:50PM +0000, Gustavo Pimentel wrote: > > On Tue, Feb 2, 2021 at 10:43:3, Greg Kroah-Hartman > > wrote: > > > > > On Tue, Feb 02, 2021 at 10:38:29AM +, Gustavo Pimente

RE: [PATCH v2 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2021-02-02 Thread Gustavo Pimentel
Hi Lukas, On Tue, Feb 2, 2021 at 18:8:55, Lukas Wunner wrote: > On Tue, Feb 02, 2021 at 01:40:18PM +0100, Gustavo Pimentel wrote: > > /** > > + * pci_find_vsec_capability - Find a vendor-specific extended capability > > + * @dev: PCI device to query > > + * @cap: ve

RE: [PATCH v2 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2021-02-03 Thread Gustavo Pimentel
On Wed, Feb 3, 2021 at 7:51:3, Lukas Wunner wrote: > On Wed, Feb 03, 2021 at 01:54:49AM +0000, Gustavo Pimentel wrote: > > On Tue, Feb 2, 2021 at 18:8:55, Lukas Wunner wrote: > > > As the name implies, the capability is "vendor-specific", so it is > > > pe

RE: [PATCH v2 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2021-02-03 Thread Gustavo Pimentel
On Wed, Feb 3, 2021 at 9:36:54, Lukas Wunner wrote: > On Wed, Feb 03, 2021 at 09:11:03AM +0000, Gustavo Pimentel wrote: > > On Wed, Feb 3, 2021 at 7:51:3, Lukas Wunner wrote: > > > On Wed, Feb 03, 2021 at 01:54:49AM +, Gustavo Pimentel wrote: > > > > On Tue,

[PATCH v3 00/15] dmaengine: dw-edma: HDMA support

2021-02-03 Thread Gustavo Pimentel
s Cc: dmaeng...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-...@vger.kernel.org Gustavo Pimentel (15): dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures dmaengine: dw-edma: Fix comments offset characters' alignment dmaengine: dw-edma: Add

[PATCH v3 07/15] dmaengine: dw-edma: Improve number of channels check

2021-02-03 Thread Gustavo Pimentel
It was added some extra checks to ensure that the driver doesn't try to use more DMA channels than actually are available in hardware. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 21 + drivers/dma/dw-edma/dw-edma-core.h | 2 ++ 2 files ch

[PATCH v3 10/15] dmaengine: dw-edma: Change linked list and data blocks offset and sizes

2021-02-03 Thread Gustavo Pimentel
this solution is based on FPGA and might be subjected to timmings constrains. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers

[PATCH v3 06/15] dmaengine: dw-edma: Add device_prep_interleave_dma() support

2021-02-03 Thread Gustavo Pimentel
Add device_prep_interleave_dma() support to Synopsys DMA driver. This feature implements a similar data transfer mechanism to the scatter-gather implementation. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 85 ++ drivers/dma/dw

[PATCH v3 13/15] dmaengine: dw-edma: Change DMA abreviation from lower into upper case

2021-02-03 Thread Gustavo Pimentel
To keep code consistent, some comments with dma keyword written in lower case are now in upper case. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma

[PATCH v3 09/15] dmaengine: dw-edma: Improve the linked list and data blocks definition

2021-02-03 Thread Gustavo Pimentel
own linked list and data space well defined, which allows different sizes and locations. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 51 +- drivers/dma/dw-edma/dw-edma-core.h | 9 +- drivers/dma/dw-edma/dw-edma-pcie.c | 185

[PATCH v3 14/15] dmaengine: dw-edma: Revert fix scatter-gather address calculation

2021-02-03 Thread Gustavo Pimentel
Reverting the applied patch because it caused a regression on ARC700 platform (32 bits). Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma

[PATCH v3 15/15] dmaengine: dw-edma: Add pcim_iomap_table return checker

2021-02-03 Thread Gustavo Pimentel
Detected by CoverityScan CID 16555 ("Dereference null return") Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c ind

[PATCH v3 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver

2021-02-03 Thread Gustavo Pimentel
When the driver is compiled as a module and loaded if we try to unload it, the Kernel shows a crash log. This Kernel crash is due to the dma_async_device_unregister() call done after deleting the channels, this patch fixes this issue. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw

[PATCH v3 11/15] dmaengine: dw-edma: Move struct dentry variable from static definition into dw_edma struct

2021-02-03 Thread Gustavo Pimentel
Move struct dentry variable from static definition (dw-edma-v0-debugfs.c) into dw_edma struct (dw-edma-core.h) Also the variable was renamed from base_dir to debugfs. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 2 +- drivers/dma/dw-edma/dw-edma-core.h

[PATCH v3 03/15] dmaengine: dw-edma: Add support for the HDMA feature

2021-02-03 Thread Gustavo Pimentel
Add support for the HDMA feature. This new feature enables the current eDMA IP to use a deeper prefetch of the linked list, which reduces the algorithm execution latency observed when loading the elements of the list, causing more stable and higher data transfer. Signed-off-by: Gustavo Pimentel

[PATCH v3 02/15] dmaengine: dw-edma: Fix comments offset characters' alignment

2021-02-03 Thread Gustavo Pimentel
Fix comments offset characters' alignment to follow the same structure of similar comments. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-regs.h | 214 +- 1 file changed, 107 insertions(+), 107 deletions(-) diff --git a/drivers/dma/dw

[PATCH v3 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2021-02-03 Thread Gustavo Pimentel
create their own and specific capability in the device config space. Signed-off-by: Gustavo Pimentel --- drivers/pci/pci.c | 34 ++ include/linux/pci.h | 2 ++ include/uapi/linux/pci_regs.h | 6 ++ 3 files changed, 42 insertions(+) diff

[PATCH v3 08/15] dmaengine: dw-edma: Reorder variables to keep consistency

2021-02-03 Thread Gustavo Pimentel
functional changes are expected. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 7077d79..9e79eb5 100644 --- a/drivers/dma

[PATCH v3 05/15] dmaengine: dw-edma: Add PCIe VSEC data retrieval support

2021-02-03 Thread Gustavo Pimentel
The latest eDMA IP development implements a Vendor-Specific Extended Capability that contains the eDMA BAR, offset, map format, and the number of read/write channels available. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 20 --- drivers/dma/dw-edma/dw-edma

[PATCH v3 01/15] dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures

2021-02-03 Thread Gustavo Pimentel
generate a 64 bits message instead of two messages of 32 bits. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-core.c| 254 +++ drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 48 +++--- drivers/dma/dw-edma/dw-edma-v0-regs.h| 149 +- 3

[PATCH v4 11/15] dmaengine: dw-edma: Move struct dentry variable from static definition into dw_edma struct

2021-02-03 Thread Gustavo Pimentel
Move struct dentry variable from static definition (dw-edma-v0-debugfs.c) into dw_edma struct (dw-edma-core.h) Also the variable was renamed from base_dir to debugfs. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 2 +- drivers/dma/dw-edma/dw-edma-core.h

[PATCH v4 15/15] dmaengine: dw-edma: Add pcim_iomap_table return checker

2021-02-03 Thread Gustavo Pimentel
Detected by CoverityScan CID 16555 ("Dereference null return") Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c ind

[PATCH v4 01/15] dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures

2021-02-03 Thread Gustavo Pimentel
generate a 64 bits message instead of two messages of 32 bits. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-core.c| 254 +++ drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 48 +++--- drivers/dma/dw-edma/dw-edma-v0-regs.h| 149 +- 3

[PATCH v4 00/15] dmaengine: dw-edma: HDMA support

2021-02-03 Thread Gustavo Pimentel
d Koul Cc: Dan Williams Cc: Bjorn Helgaas Cc: dmaeng...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-...@vger.kernel.org Gustavo Pimentel (15): dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures dmaengine: dw-edma: Fix comments offset characters' alignme

[PATCH v4 13/15] dmaengine: dw-edma: Change DMA abreviation from lower into upper case

2021-02-03 Thread Gustavo Pimentel
To keep code consistent, some comments with dma keyword written in lower case are now in upper case. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma

[PATCH v4 14/15] dmaengine: dw-edma: Revert fix scatter-gather address calculation

2021-02-03 Thread Gustavo Pimentel
Reverting the applied patch because it caused a regression on ARC700 platform (32 bits). Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma

[PATCH v4 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver

2021-02-03 Thread Gustavo Pimentel
When the driver is compiled as a module and loaded if we try to unload it, the Kernel shows a crash log. This Kernel crash is due to the dma_async_device_unregister() call done after deleting the channels, this patch fixes this issue. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw

[PATCH v4 07/15] dmaengine: dw-edma: Improve number of channels check

2021-02-03 Thread Gustavo Pimentel
It was added some extra checks to ensure that the driver doesn't try to use more DMA channels than actually are available in hardware. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 21 + drivers/dma/dw-edma/dw-edma-core.h | 2 ++ 2 files ch

[PATCH v4 10/15] dmaengine: dw-edma: Change linked list and data blocks offset and sizes

2021-02-03 Thread Gustavo Pimentel
this solution is based on FPGA and might be subjected to timmings constrains. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers

[PATCH v4 09/15] dmaengine: dw-edma: Improve the linked list and data blocks definition

2021-02-03 Thread Gustavo Pimentel
own linked list and data space well defined, which allows different sizes and locations. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 51 +- drivers/dma/dw-edma/dw-edma-core.h | 9 +- drivers/dma/dw-edma/dw-edma-pcie.c | 185

[PATCH v4 08/15] dmaengine: dw-edma: Reorder variables to keep consistency

2021-02-03 Thread Gustavo Pimentel
functional changes are expected. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 7077d79..9e79eb5 100644 --- a/drivers/dma

[PATCH v4 4/6] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

2021-02-03 Thread Gustavo Pimentel
Add Documentation for dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdata-pcie.rst | 40 1 file changed, 40 insertions(+) create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst diff --git a/Documentation/misc

[PATCH v4 0/6] misc: Add Add Synopsys DesignWare xData IP driver

2021-02-03 Thread Gustavo Pimentel
Cc: linux-kernel@vger.kernel.org Gustavo Pimentel (6): misc: Add Synopsys DesignWare xData IP driver misc: Add Synopsys DesignWare xData IP driver to Makefile misc: Add Synopsys DesignWare xData IP driver to Kconfig Documentation: misc-devices: Add Documentation for dw-xdata-pcie

[PATCH v4 6/6] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

2021-02-03 Thread Gustavo Pimentel
This patch describes the sysfs interface implemented on the dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/ABI/testing/sysfs-driver-xdata | 46 1 file changed, 46 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-xdata

[PATCH v4 2/6] misc: Add Synopsys DesignWare xData IP driver to Makefile

2021-02-03 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver to Makefile. This driver enables/disables the PCIe traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/Makefile

[PATCH v4 1/6] misc: Add Synopsys DesignWare xData IP driver

2021-02-03 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver. This driver enables/disables the PCI traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/dw-xdata-pcie.c | 378 +++ 1 file changed, 378 insertions

[PATCH v4 3/6] misc: Add Synopsys DesignWare xData IP driver to Kconfig

2021-02-03 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver to Kconfig. This driver enables/disables the PCIe traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Kconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers

[PATCH v4 5/6] MAINTAINERS: Add Synopsys xData IP driver maintainer

2021-02-03 Thread Gustavo Pimentel
Add Synopsys xData IP driver maintainer. This driver aims to support Synopsys xData IP and is normally distributed along with Synopsys PCIe EndPoint IP as a PCIe traffic generator (depends of the use and licensing agreement). Signed-off-by: Gustavo Pimentel --- MAINTAINERS | 7 +++ 1 file

[PATCH v4 05/15] dmaengine: dw-edma: Add PCIe VSEC data retrieval support

2021-02-03 Thread Gustavo Pimentel
The latest eDMA IP development implements a Vendor-Specific Extended Capability that contains the eDMA BAR, offset, map format, and the number of read/write channels available. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 20 --- drivers/dma/dw-edma/dw-edma

[PATCH v4 06/15] dmaengine: dw-edma: Add device_prep_interleave_dma() support

2021-02-03 Thread Gustavo Pimentel
Add device_prep_interleave_dma() support to Synopsys DMA driver. This feature implements a similar data transfer mechanism to the scatter-gather implementation. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 85 ++ drivers/dma/dw

[PATCH v4 02/15] dmaengine: dw-edma: Fix comments offset characters' alignment

2021-02-03 Thread Gustavo Pimentel
Fix comments offset characters' alignment to follow the same structure of similar comments. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-regs.h | 214 +- 1 file changed, 107 insertions(+), 107 deletions(-) diff --git a/drivers/dma/dw

[PATCH v4 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2021-02-03 Thread Gustavo Pimentel
create their own and specific capability in the device config space. Signed-off-by: Gustavo Pimentel --- drivers/pci/pci.c | 34 ++ include/linux/pci.h | 2 ++ include/uapi/linux/pci_regs.h | 6 ++ 3 files changed, 42 insertions(+) diff

[PATCH v4 03/15] dmaengine: dw-edma: Add support for the HDMA feature

2021-02-03 Thread Gustavo Pimentel
Add support for the HDMA feature. This new feature enables the current eDMA IP to use a deeper prefetch of the linked list, which reduces the algorithm execution latency observed when loading the elements of the list, causing more stable and higher data transfer. Signed-off-by: Gustavo Pimentel

[RESEND v4 1/6] misc: Add Synopsys DesignWare xData IP driver

2021-02-03 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver. This driver enables/disables the PCI traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/dw-xdata-pcie.c | 378 +++ 1 file changed, 378 insertions

[RESEND v4 5/6] MAINTAINERS: Add Synopsys xData IP driver maintainer

2021-02-03 Thread Gustavo Pimentel
Add Synopsys xData IP driver maintainer. This driver aims to support Synopsys xData IP and is normally distributed along with Synopsys PCIe EndPoint IP as a PCIe traffic generator (depends of the use and licensing agreement). Signed-off-by: Gustavo Pimentel --- MAINTAINERS | 7 +++ 1 file

[RESEND v4 0/6] misc: Add Add Synopsys DesignWare xData IP driver

2021-02-03 Thread Gustavo Pimentel
Cc: linux-kernel@vger.kernel.org Gustavo Pimentel (6): misc: Add Synopsys DesignWare xData IP driver misc: Add Synopsys DesignWare xData IP driver to Makefile misc: Add Synopsys DesignWare xData IP driver to Kconfig Documentation: misc-devices: Add Documentation for dw-xdata-pcie

[RESEND v4 4/6] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

2021-02-03 Thread Gustavo Pimentel
Add Documentation for dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/misc-devices/dw-xdata-pcie.rst | 40 1 file changed, 40 insertions(+) create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst diff --git a/Documentation/misc

[RESEND v4 6/6] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

2021-02-03 Thread Gustavo Pimentel
This patch describes the sysfs interface implemented on the dw-xdata-pcie driver. Signed-off-by: Gustavo Pimentel --- Documentation/ABI/testing/sysfs-driver-xdata | 46 1 file changed, 46 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-xdata

[RESEND v4 3/6] misc: Add Synopsys DesignWare xData IP driver to Kconfig

2021-02-03 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver to Kconfig. This driver enables/disables the PCIe traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Kconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers

[RESEND v4 2/6] misc: Add Synopsys DesignWare xData IP driver to Makefile

2021-02-03 Thread Gustavo Pimentel
Add Synopsys DesignWare xData IP driver to Makefile. This driver enables/disables the PCIe traffic generator module pertain to the Synopsys DesignWare prototype. Signed-off-by: Gustavo Pimentel --- drivers/misc/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/Makefile

RE: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2021-02-02 Thread Gustavo Pimentel
Just a kindly reminder. On Thu, Nov 19, 2020 at 9:19:37, Gustavo Pimentel wrote: > This patch series adds a new driver called xData-pcie for the Synopsys > DesignWare PCIe prototype. > > The driver configures and enables the Synopsys DesignWare PCIe traffic > generator IP insi

RE: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2021-02-02 Thread Gustavo Pimentel
On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman wrote: > On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote: > > Just a kindly reminder. > > reminder of what? To review the patch set. I've done the requested modifications, but I didn't get any feed

RE: [PATCH 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2021-02-02 Thread Gustavo Pimentel
On Mon, Feb 1, 2021 at 22:39:20, Bjorn Helgaas wrote: Hi Bjorn, > > +/** > > + * pci_find_vsec_capability - Find a vendor-specific extended capability > > + * @dev: PCI device to query > > + * @cap: vendor-specific capability id code > > s/id/ID/ I will do it for all the requested changes. >

[PATCH v2 00/15] dmaengine: dw-edma: HDMA support

2021-02-02 Thread Gustavo Pimentel
-kernel@vger.kernel.org Cc: linux-...@vger.kernel.org Gustavo Pimentel (15): dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures dmaengine: dw-edma: Fix comments offset characters' alignment dmaengine: dw-edma: Add support for the HDMA feature PCI: Add pci_find_vse

[PATCH v2 05/15] dmaengine: dw-edma: Add PCIe VSEC data retrieval support

2021-02-02 Thread Gustavo Pimentel
The latest eDMA IP development implements a Vendor-Specific Extended Capability that contains the eDMA BAR, offset, map format, and the number of read/write channels available. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 20 --- drivers/dma/dw-edma/dw-edma

[PATCH v2 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

2021-02-02 Thread Gustavo Pimentel
create their own and specific capability in the device config space. Signed-off-by: Gustavo Pimentel --- drivers/pci/pci.c | 29 + include/linux/pci.h | 2 ++ include/uapi/linux/pci_regs.h | 6 ++ 3 files changed, 37 insertions(+) diff --git

[PATCH v2 02/15] dmaengine: dw-edma: Fix comments offset characters' alignment

2021-02-02 Thread Gustavo Pimentel
Fix comments offset characters' alignment to follow the same structure of similar comments. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-v0-regs.h | 214 +- 1 file changed, 107 insertions(+), 107 deletions(-) diff --git a/drivers/dma/dw

[PATCH v2 15/15] dmaengine: dw-edma: Add pcim_iomap_table return checker

2021-02-02 Thread Gustavo Pimentel
Detected by CoverityScan CID 16555 ("Dereference null return") Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c ind

[PATCH v2 13/15] dmaengine: dw-edma: Change DMA abreviation from lower into upper case

2021-02-02 Thread Gustavo Pimentel
To keep code consistent, some comments with dma keyword written in lower case are now in upper case. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma

[PATCH v2 14/15] dmaengine: dw-edma: Revert fix scatter-gather address calculation

2021-02-02 Thread Gustavo Pimentel
Reverting the applied patch because it caused a regression on ARC700 platform (32 bits). Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma

[PATCH v2 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver

2021-02-02 Thread Gustavo Pimentel
When the driver is compiled as a module and loaded if we try to unload it, the Kernel shows a crash log. This Kernel crash is due to the dma_async_device_unregister() call done after deleting the channels, this patch fixes this issue. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw

[PATCH v2 10/15] dmaengine: dw-edma: Change linked list and data blocks offset and sizes

2021-02-02 Thread Gustavo Pimentel
this solution is based on FPGA and might be subjected to timmings constrains. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers

[PATCH v2 11/15] dmaengine: dw-edma: Move struct dentry variable from static definition into dw_edma struct

2021-02-02 Thread Gustavo Pimentel
Move struct dentry variable from static definition (dw-edma-v0-debugfs.c) into dw_edma struct (dw-edma-core.h) Also the variable was renamed from base_dir to debugfs. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 2 +- drivers/dma/dw-edma/dw-edma-core.h

<    1   2   3   4   5   6   >