Re: [PATCH 2/5] riscv: Add QUEUED_SPINLOCKS & QUEUED_RWLOCKS supported

2020-11-25 Thread Guo Ren
== 8 */ > > If nothing else needs xchg() on a 16-bit value, maybe > changing the #ifdef in the qspinlock code is enough. > > Only around half the architectures actually implement 8-bit > and 16-bit cmpxchg() and xchg(), it might even be worth trying > to eventually change the interface to not do it at all, but > instead have explicit cmpxchg8() and cmpxchg16() helpers > for the few files that do use them. > > Arnd -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/

Re: [PATCH 1/5] riscv: Coding convention for xchg

2020-11-25 Thread Guo Ren
On Tue, Nov 24, 2020 at 10:29 PM Peter Zijlstra wrote: > > On Tue, Nov 24, 2020 at 01:43:53PM +, guo...@kernel.org wrote: > > From: Guo Ren > > > > This is prepare for QUEUED_SPINLOCKS which need xchg support short > > type value. > > - Remove unu

Re: [PATCH 2/5] riscv: Add QUEUED_SPINLOCKS & QUEUED_RWLOCKS supported

2020-11-25 Thread Guo Ren
qspinlock benefits riscv. On arm64, there's nothing in > it over tickets for <= 16 CPUs. NUMA is on the way: https://lore.kernel.org/linux-riscv/20201119003829.1282810-1-atish.pa...@wdc.com/ With your advice, I think we could using tickets lock when <= 16 CPUs and using qspinlock when > 16 CPUs. Is that right? The next patchset plan is: - Using tickets & qspinlock together in riscv. Abandon 16bits xchg/cmpxchg implementation. - Abanden qspinlock in csky, because it only could 4 CPUs' SMP. > > Will -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/

Re: [PATCH 1/2] futex: mark futex_detect_cmpxchg() as 'noinline'

2020-12-20 Thread Guo Ren
Hi Arnd, On Tue, Dec 15, 2020 at 7:26 PM Arnd Bergmann wrote: > > On Tue, Dec 15, 2020 at 7:09 AM Guo Ren wrote: > > On Mon, Dec 14, 2020 at 9:15 PM Arnd Bergmann wrote: > > > I had a look at what other architectures always implement > > > futex_atomic_cmpxchg

Re: [PATCH 1/2] futex: mark futex_detect_cmpxchg() as 'noinline'

2020-12-20 Thread Guo Ren
Hi Arnd, On Mon, Dec 21, 2020 at 1:49 AM Arnd Bergmann wrote: > > On Sun, Dec 20, 2020 at 4:46 PM Guo Ren wrote: > > On Tue, Dec 15, 2020 at 7:26 PM Arnd Bergmann wrote: > > > > > > On Tue, Dec 15, 2020 at 7:09 AM Guo Ren wrote: > > > > On Mon, De

Re: [GIT PULL] csky changes for v5.12-rc1

2021-03-01 Thread Guo Ren
db8..5abcfda 100644 --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -134,7 +134,6 @@ enum cpuhp_state { CPUHP_AP_ARC_TIMER_STARTING, CPUHP_AP_RISCV_TIMER_STARTING, CPUHP_AP_CLINT_TIMER_STARTING, - CPUHP_AP_CSKY_TIMER_STARTING, CPUHP_AP_HYPERV_TIMER_STARTING, CPUHP_AP_KVM_STARTING, CPUHP_AP_KVM_ARM_VGIC_INIT_STARTING, @@ -186,7 +185,6 @@ enum cpuhp_state { CPUHP_AP_PERF_POWERPC_TRACE_IMC_ONLINE, CPUHP_AP_PERF_POWERPC_HV_24x7_ONLINE, CPUHP_AP_PERF_POWERPC_HV_GPCI_ONLINE, - CPUHP_AP_PERF_CSKY_ONLINE, CPUHP_AP_WATCHDOG_ONLINE, CPUHP_AP_WORKQUEUE_ONLINE, CPUHP_AP_RCUTREE_ONLINE, -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/

Re: [PATCH v2 4/5] csky: Fixup asm/cmpxchg.h with correct ordering barrier

2021-01-20 Thread Guo Ren
ore the instruction. arw means after read and write would happen after the instruction So it also could be bar.brarw / bar.arw / bar.brw / bar.braw sync means we need to wait until all instructions complete in the CPU pipeline and then issue the next instructions. -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/

Re: [PATCH v2 1/5] csky: Remove custom asm/atomic.h implementation

2021-01-20 Thread Guo Ren
Hi Peter, On Thu, Jan 7, 2021 at 7:19 PM Peter Zijlstra wrote: > > On Sun, Dec 20, 2020 at 03:39:19PM +, guo...@kernel.org wrote: > > From: Guo Ren > > > > Use generic atomic implementation based on cmpxchg. So remove csky > > asm/atomic.h. > > Clarificat

Re: [PATCH] csky: fix typos

2021-03-05 Thread Guo Ren
suggests those low addresses would not > - * otherwise be availiable. > + * otherwise be available. > */ > #define VDSO_SYMBOL(base, name) > \ > ({ > \ > -- > 1.9.1 > > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/

Re: [PATCH v2 2/2] drivers/clocksource: Fixup csky,mptimer compile error with CPU_CK610

2021-02-06 Thread Guo Ren
Hi Daniel, On Thu, Feb 4, 2021 at 4:48 PM Daniel Lezcano wrote: > > On 04/02/2021 08:46, guo...@kernel.org wrote: > > From: Guo Ren > > > > The timer-mp-csky.c only could support CPU_CK860 and it will > > compile error with CPU_CK610. > > > > It has

Re: [PATCH v2 2/2] drivers/clocksource: Fixup csky,mptimer compile error with CPU_CK610

2021-02-06 Thread Guo Ren
The same way in IRQ chip: Link: https://lore.kernel.org/lkml/161245410060.1472442.13488057609914274236.b4...@kernel.org/ On Sun, Feb 7, 2021 at 11:31 AM Guo Ren wrote: > > Hi Daniel, > > On Thu, Feb 4, 2021 at 4:48 PM Daniel Lezcano > wrote: > > > > On 04/02/20

Re: [PATCH v1] csky: use free_initmem_default() in free_initmem()

2021-01-27 Thread Guo Ren
Hildenbrand wrote: > > The existing code is essentially > > free_initmem_default()->free_reserved_area() without poisoning. > > > > Note that existing code missed to update the managed page count of the > > zone. > > > > Cc: Andrew Morton > > Cc:

Re: [PATCH] RISC-V: probes: Treat the instruction stream as host-endian

2021-01-22 Thread Guo Ren
Acked-by: Guo Ren On 2021/1/23 上午11:34, Palmer Dabbelt wrote: From: Palmer Dabbelt Neither of these are actually correct: the instruction stream is defined (for versions of the ISA manual newer than 2.2) as a stream of 16-bit little-endian parcels, which is different than just being little

Re: [PATCH v1] csky: use free_initmem_default() in free_initmem()

2021-01-27 Thread Guo Ren
Hi David, > 在 2021年1月27日,下午4:49,David Hildenbrand 写道: > > On 27.01.21 08:52, Guo Ren wrote: >> Thx Mike, > > Thanks for triggering a build/test! I'd be curious if there is an easy way to > trigger this myself (I assume, fork csky buildroot on gitlab, rerout

Re: [PATCH 1/2] futex: mark futex_detect_cmpxchg() as 'noinline'

2020-12-14 Thread Guo Ren
include +#include + +static inline int +arch_futex_atomic_op_inuser(int op, int oparg, int *oval, u32 __user *uaddr) +{ + int oldval = 0, ret = 0; + + if (!access_ok(uaddr, sizeof(u32))) + return -EFAULT; + + <...> + + return ret; +} + +static inline int +futex_atomic_c

Re: [GIT PULL] csky fixes for v5.0-rc6

2019-02-11 Thread Guo Ren
at post-rc6 time. Ok, I'll remove: irqchip/csky: Support csky,dh7k SOC intc driver dt-bindings: csky,apb-intc: Add dh7k SOC support Best Regards Guo Ren

Re: [PATCH 3/3] csky: Support kernel non-aligned access

2019-08-20 Thread Guo Ren
Thx Christoph On Wed, Aug 21, 2019 at 10:17 AM Christoph Hellwig wrote: > > On Tue, Aug 20, 2019 at 08:34:29PM +0800, guo...@kernel.org wrote: > > From: Guo Ren > > > > We prohibit non-aligned access in kernel mode, but some special NIC > > driver needs to support

Re: [PATCH 1/3] csky: Fixup arch_get_unmapped_area() implementation

2019-08-20 Thread Guo Ren
invalidate_kernel_vmap_range functions to avoid data corruption when > doing I/O on vmalloc/vmap ranges. I'll give another patch for this issue -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/

Re: [PATCH] csky: Move static keyword to the front of declaration

2019-09-03 Thread Guo Ren
Thx, Acked by: Guo Ren You may also modify others' ➜ linux-next git:(linux-next-for-v5.4) ✗ grep "const static" * -r arch/csky/kernel/perf_event.c:const static struct of_device_id csky_pmu_of_device_ids[] = { arch/nds32/kernel/perf_event_cpu.c:const static stru

Re: [PATCH] csky: Fixup ioremap function losing

2019-08-17 Thread Guo Ren
Thx Christoph, On Fri, Aug 16, 2019 at 3:03 PM Christoph Hellwig wrote: > > On Thu, Aug 15, 2019 at 07:28:57PM +0800, guo...@kernel.org wrote: > > From: Guo Ren > > > > Implement the following apis to meet usage in different scenarios. > > > > - iore

Re: [PATCH V5 1/3] riscv: Add perf callchain support

2019-08-26 Thread Guo Ren
27; value } On Mon, Aug 26, 2019 at 4:03 PM Greentime Hu wrote: > > Hi Guo, > > Guo Ren 於 2019年8月24日 週六 上午8:54寫道: > > > > Please check CONFIG_FRAME_POINTER > > > > 1 *frame = *((struct stackframe *)frame->fp - 1); > > This code is origionally from riscv

Re: [PATCH] csky: use generic free_initrd_mem()

2019-08-28 Thread Guo Ren
Acked-by: Guo Ren On Wed, Aug 28, 2019 at 9:35 PM Mike Rapoport wrote: > > The csky implementation of free_initrd_mem() is an open-coded version of > free_reserved_area() without poisoning. > > Remove it and make csky use the generic version of free_initrd_mem(). > >

Re: [PATCH] csky: use generic free_initrd_mem()

2019-08-28 Thread Guo Ren
Sure, no problem. On Wed, Aug 28, 2019 at 10:39 PM Mike Rapoport wrote: > > Hi, > > On Wed, Aug 28, 2019 at 10:12:52PM +0800, Guo Ren wrote: > > Acked-by: Guo Ren > > Do you mind taking it via csky tree? > > > On Wed, Aug 28, 2019 at 9:35 PM Mike Rapo

Re: [PATCH V5 1/3] riscv: Add perf callchain support

2019-08-23 Thread Guo Ren
rf callchain sampling on riscv platform. > > The return address of leaf function is retrieved from pt_regs as > > it is not saved in the outmost frame. > > > > Signed-off-by: Mao Han > > Cc: Paul Walmsley > > Cc: Greentime Hu > > Cc: Palmer Dabbelt > &g

Re: [PATCH V2] csky: Fixup 610 vipt cache flush mechanism

2019-08-25 Thread Guo Ren
Thx Christoph, On Mon, Aug 26, 2019 at 2:38 PM Christoph Hellwig wrote: > > On Thu, Aug 22, 2019 at 11:05:22AM +0800, guo...@kernel.org wrote: > > From: Guo Ren > > > > 610 has vipt aliasing issue, so we need to finish the cache flush > > apis mentioned in cachetl

Re: [PATCH V6 0/3] riscv: Add perf callchain support

2019-09-04 Thread Guo Ren
force to build kernel with -fno-omit-frame-pointer if perf > > event is enabled > > > > Changes since v1: > > - simplify implementation and code convention > > > > Cc: Paul Walmsley > > Cc: Greentime Hu > > Cc: Palmer Dabbelt > > Cc: linux-r

Re: [GIT PULL] csky changes for v5.3-rc1

2019-09-30 Thread Guo Ren
ernel/process.c | 2 +- > arch/csky/mm/cachev1.c | 7 +++- > arch/csky/mm/cachev2.c | 11 +- > arch/csky/mm/dma-mapping.c | 76 > +--- > arch/csky/mm/init.c | 16 > arch/csky/mm/ioremap.c | 27 - > 17 files changed, 291 insertions(+), 212 deletions(-) -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/

Re: [PATCH v2 3/9] csky: entry: Remove unneeded need_resched() loop

2019-09-23 Thread Guo Ren
Ok, I'll put in my tree :) On Mon, Sep 23, 2019 at 10:36 PM Valentin Schneider wrote: > > Since the enabling and disabling of IRQs within preempt_schedule_irq() > is contained in a need_resched() loop, we don't need the outer arch > code loop. > > Acked-by: Guo Re

Re: [PATCH] csky: Fixup ioremap function losing

2019-08-20 Thread Guo Ren
On Mon, Aug 19, 2019 at 2:21 AM Christoph Hellwig wrote: > > On Sun, Aug 18, 2019 at 10:20:18AM +0800, Guo Ren wrote: > > > > Also change flag VM_ALLOC to VM_IOREMAP in get_vm_area_caller. > > > > > > Looks generally fine, but two comments: > > > >

Re: [PATCH] csky: Initial stack protector support

2019-10-11 Thread Guo Ren
overflow in kill system call. > > Signed-off-by: Mao Han > Cc: Guo Ren > --- > arch/csky/Kconfig | 1 + > arch/csky/include/asm/stackprotector.h | 29 + > arch/csky/kernel/process.c | 6 ++ > 3 files changed, 36

Re: [PATCH 06/34] csky: Use CONFIG_PREEMPTION

2019-10-15 Thread Guo Ren
equire the same functionality which today > depends on CONFIG_PREEMPT. > > Switch the entry code over to use CONFIG_PREEMPTION. > > Cc: Guo Ren > Signed-off-by: Thomas Gleixner > Signed-off-by: Sebastian Andrzej Siewior > --- > arch/csky/kernel/entry.S | 4 ++-- >

Re: [PATCH 06/34] csky: Use CONFIG_PREEMPTION

2019-10-16 Thread Guo Ren
Thx for explanation. Acked-by: Guo Ren On Wed, Oct 16, 2019 at 3:39 PM Sebastian Andrzej Siewior wrote: > > On 2019-10-16 07:29:34 [+0800], Guo Ren wrote: > > Could CONFIG_PREEMPT_RT be supported in csky ? Any arch backend porting ? > > It could. HIGH_RES_TI

Re: [PATCH 01/10] irqchip/csky: Support csky,dh7k SOC intc driver

2019-02-14 Thread Guo Ren
On Thu, Feb 14, 2019 at 02:03:52PM +, Marc Zyngier wrote: > On Tue, 29 Jan 2019 12:24:20 +, > guo...@kernel.org wrote: > > > > From: Guo Ren > > > > C-SKY dh7k SOC use simple APB interrupt controller and most of driver's > > implementation cod

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-15 Thread Guo Ren
Hi Christoph, I use PFN_DOWN() every where as possible and seems it's a habit problem. So let risc-v maintainer to choose "PFN_DOW()" or ">> PAGE_SHIFT". Also the same with "end_of_DRAM & max_low_pfn". Best Regards Guo Ren On Tue, Jan 15, 2019

Re: [PATCH 19/21] treewide: add checks for the return value of memblock_alloc*()

2019-01-16 Thread Guo Ren
__func__, PAGE_SIZE, > + PAGE_SIZE); > + > set_pmd(pmd, __pmd(__pa(pte))); > BUG_ON(pte != pte_offset_kernel(pmd, > 0)); > } Looks good for me and panic is ok. Reviewed-by: Guo Ren

Re: [PATCH] irqchip/irq-csky-mpintc: Add triger type and priority setting

2019-01-17 Thread Guo Ren
Thx Marc, On Thu, Jan 17, 2019 at 05:17:45PM +, Marc Zyngier wrote: > Hi Guo, > > On 15/01/2019 16:36, guo...@kernel.org wrote: > > From: Guo Ren > > > > Support 4 triger types: > > - IRQ_TYPE_LEVEL_HIGH > > - IRQ_TYPE_LEVEL_LOW > > - IRQ_

Re: [PATCH] csky/kernel/entry: Remove duplicate heade

2019-01-17 Thread Guo Ren
Thx Brajeswar, Tested-by: Guo Ren Acked-by: Guo Ren On Thu, Jan 17, 2019 at 08:00:04PM +0530, Brajeswar Ghosh wrote: > Remove duplicate headers which are included more than once > > Signed-off-by: Brajeswar Ghosh > --- > arch/csky/kernel/entry.S | 1 - > 1 file c

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-15 Thread Guo Ren
On Tue, Jan 15, 2019 at 07:36:13AM -0800, Christoph Hellwig wrote: > On Sat, Jan 12, 2019 at 04:16:27PM +0800, guo...@kernel.org wrote: > > From: Guo Ren > > > > max_low_pfn should be pfn_size not byte_size. > > > > Signed-off-by: Guo Ren > > Signed-

Re: [PATCH] arch/csky/mm/fault.c: Remove duplicate header

2019-01-18 Thread Guo Ren
Thx Brajeswar, Reviewed-by: Guo Ren Acked-by: Guo Ren On Fri, Jan 18, 2019 at 03:21:52PM +0530, Brajeswar Ghosh wrote: > Remove linux/kernel.h which is included more than once > > Signed-off-by: Brajeswar Ghosh > --- > arch/csky/mm/fault.c | 1 - > 1 file changed, 1 del

Re: [PATCH] irqchip/irq-csky-mpintc: Add triger type and priority setting

2019-01-18 Thread Guo Ren
On Fri, Jan 18, 2019 at 09:32:03AM +, Marc Zyngier wrote: > On 18/01/2019 06:28, Guo Ren wrote: > > Thx Marc, > > > > On Thu, Jan 17, 2019 at 05:17:45PM +, Marc Zyngier wrote: > >> Hi Guo, > >> > >> On 15/01/2019 16:36, guo...@kernel.org w

Re: [PATCH V2 2/2] dt-bindings: interrupt-controller: Update csky mpintc

2019-01-21 Thread Guo Ren
On Mon, Jan 21, 2019 at 08:12:15AM -0600, Rob Herring wrote: > On Fri, Jan 18, 2019 at 10:53 AM wrote: > > > > From: Guo Ren > > > > Add trigger type and priority setting for csky,mpintc. > > > > Signed-off-by: Guo Ren > > --- > > .../

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-23 Thread Guo Ren
ntainer to choose "PFN_DOW()" or > >">> PAGE_SHIFT". > > > >Also the same with "end_of_DRAM & max_low_pfn". > > PFN_DOWN makes sense to me, as that's what we're trying to do here (round a > physical address down to page frame number). Am a I misunderstanding > something? > No, you got it :) Best Regards Guo Ren

Re: [PATCH V2 4/7] irqchip/irq-csky-mpintc: Add triger type and priority

2019-05-10 Thread Guo Ren
Thx Marc, Sorry for late reply: On Mon, Feb 18, 2019 at 02:38:23PM +, Marc Zyngier wrote: > On Mon, 18 Feb 2019 10:04:40 +0800 > guo...@kernel.org wrote: > > > From: Guo Ren > > > > Support 4 triger types: > > - IRQ_TYPE_LEVEL_HIGH > > - IRQ_TYP

Re: [PATCH V2 5/7] dt-bindings: interrupt-controller: Update csky mpintc

2019-05-10 Thread Guo Ren
Thx Marc, On Mon, Feb 18, 2019 at 02:28:45PM +, Marc Zyngier wrote: > On Mon, 18 Feb 2019 10:04:41 +0800 > guo...@kernel.org wrote: > > > From: Guo Ren > > > > Add trigger type and priority setting for csky,mpintc. > > > > Changelog: > > - c

Re: [PATCH V2 4/7] irqchip/irq-csky-mpintc: Add triger type and priority

2019-05-10 Thread Guo Ren
Thx Marc, On Fri, May 10, 2019 at 07:12:18PM +0100, Marc Zyngier wrote: > On Fri, 10 May 2019 09:25:10 +0100, > Guo Ren wrote: > > > > Thx Marc, > > > > Sorry for late reply: > > > > On Mon, Feb 18, 2019 at 02:38:23PM +, Marc Zyngier wrote

Re: [PATCH V3 2/2] irqchip/irq-csky-mpintc: Add triger type and priority

2019-05-21 Thread Guo Ren
Hi Marc, ping ... Any problem ? Thx Guo Ren 于2019年5月13日周一 下午5:55写道: > > From: Guo Ren > > Support 4 triger types: > - IRQ_TYPE_LEVEL_HIGH > - IRQ_TYPE_LEVEL_LOW > - IRQ_TYPE_EDGE_RISING > - IRQ_TYPE_EDGE_FALLING > > Support 0-255 priority setting for each

Re: [PATCH V3 2/2] irqchip/irq-csky-mpintc: Add triger type and priority

2019-05-21 Thread Guo Ren
Thx Marc, On Tue, May 21, 2019 at 09:54:18AM +0100, Marc Zyngier wrote: > On 21/05/2019 08:22, Guo Ren wrote: > > Hi Marc, > > ping ... Any problem ? > > Pinging me twice in four days for a patch posted in the middle of the > merge window is a problem, yes. In general,

Re: [PATCH] riscv: fix syscall_get_arguments() and syscall_set_arguments()

2019-03-29 Thread Guo Ren
oo. > > Yes of course. I mentioned both of these fixes in my reply to Linus. The BUG is from this commit before upstream: https://github.com/c-sky/csky-linux/commit/b167422869e6a76b31bda639413efa2ba7e60432#diff-cdc97efef2ab02d6828fa545698f9311 I reference the riscv code without my mind, thx for all. Best Regards Guo Ren

Re: [PATCH] csky: fix syscall_get_arguments() and syscall_set_arguments()

2019-03-29 Thread Guo Ren
Thx Dmitry, It works for me. Tested-by: Guo Ren Acked-by: Guo Ren On Fri, Mar 29, 2019 at 08:12:30PM +0300, Dmitry V. Levin wrote: > C-SKY syscall arguments are located in orig_a0,a1,a2,a3,regs[0],regs[1] > fields of struct pt_regs. > > Due to an off-by-one bug and a bu

Re: [PATCH 1/1] csky: add page fault perf event support

2019-04-19 Thread Guo Ren
Looks good, nice Job, Maomao On Thu, Apr 18, 2019 at 02:20:40PM +0800, Mao Han wrote: > This patch add support for page fault count, major fault count > and minorfault count. Without this patch page faults are not > sampled for perf event. > > Performance counter stats for '/usr/lib/perf-test/ca

Re: [PATCH V5 0/2] csky: perf callchain dwarf support

2019-04-19 Thread Guo Ren
Nice Job, Maomao Signed-off: Guo Ren On Mon, Apr 15, 2019 at 05:17:28PM +0800, Mao Han wrote: > This patch set add perf DWARF unwinding support for C-SKY. > Including user registers/stack dump API, and libdw support. > > CC: Guo Ren > > Changes since v4: > - remove s

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-22 Thread Guo Ren
73,7 +73,7 @@ static void __iomem *__ioremap_caller(phys_addr_t addr, > > size_t size, > > */ > > void __iomem *ioremap(phys_addr_t offset, unsigned long size) > > { > > - return __ioremap_caller(offset, size, PAGE_KERNEL, > > + return __ioremap_caller(offset, size, PAGE_KERNEL_COHERENCY, > > __builtin_return_address(0)); > > } > > EXPORT_SYMBOL(ioremap); > > I think ioremap is a different story, and should be a separate patch. Ok Best Regards Guo Ren

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-23 Thread Guo Ren
On Tue, Apr 23, 2019 at 07:55:48AM +0200, Christoph Hellwig wrote: > On Tue, Apr 23, 2019 at 08:13:48AM +0800, Guo Ren wrote: > > > We should probably start a working group for this ASAP unless we can > > > get another working group to help taking care of it. > >

Re: [GIT PULL] csky fixes for v5.1-rc7

2019-04-26 Thread Guo Ren
e window. > Re-send when the merge window opens. Ok. Best Regards Guo Ren

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-26 Thread Guo Ren
e buffers etc that need write-combining to get > acceptable performance I agree dma_alloc_wc is necessary, and we need add another more attribute bit in PTE: _PAGE_BUF. Perhaps using _PAGE_BUF + _PAGE_CACHE are better then _PAGE_CONHENCY. > - you need to decide what is supposed to happen when there are > multiple conflicting mappings for the same physical address. ^ What's the mulitple confilcing mappings ? Best Regards Guo Ren

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-29 Thread Guo Ren
On Mon, Apr 29, 2019 at 01:11:43PM -0700, Palmer Dabbelt wrote: > On Mon, 22 Apr 2019 08:44:30 PDT (-0700), guo...@kernel.org wrote: > >From: Guo Ren > > > >The current riscv linux implementation requires SOC system to support > >memory coherence between all I/O dev

Re: [PATCH 3/4] csky/dma: Fixup cache_op failed when cross memory ZONEs

2019-08-06 Thread Guo Ren
ase keep the postcore_initcall next to the function it calls. Ok. Change arch_initcall back to postcore_initcall. :) -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/

Re: [PATCH 4/4] csky: Add dma_inv_range for DMA_FROM_DEVICE

2019-07-30 Thread Guo Ren
Thx Arnd, On Tue, Jul 30, 2019 at 9:43 PM Arnd Bergmann wrote: > > On Tue, Jul 30, 2019 at 2:16 PM wrote: > > From: Guo Ren > > > diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c > > index 3f1ff9d..d8f0f81 100644 > > --- a/arch/csky/mm/dma

Re: [PATCH 1/4] csky: Fixup dma_rmb/wmb synchronization problem

2019-07-30 Thread Guo Ren
On Tue, Jul 30, 2019 at 9:29 PM Arnd Bergmann wrote: > > On Tue, Jul 30, 2019 at 2:15 PM wrote: > > > > From: Guo Ren > > > > If arch didn't define dma_r/wmb(), linux will use w/rmb instead. Csky > > use bar.xxx to implement mb() and that will cause p

Re: [PATCH 1/4] csky: Fixup dma_rmb/wmb synchronization problem

2019-07-30 Thread Guo Ren
Thx Arnd, On Tue, Jul 30, 2019 at 9:29 PM Arnd Bergmann wrote: > > On Tue, Jul 30, 2019 at 2:15 PM wrote: > > > > From: Guo Ren > > > > If arch didn't define dma_r/wmb(), linux will use w/rmb instead. Csky > > use bar.xxx to implement mb() and that w

Re: [PATCH 4/4] csky: Add dma_inv_range for DMA_FROM_DEVICE

2019-07-30 Thread Guo Ren
Thx Arnd, On Tue, Jul 30, 2019 at 11:22 PM Arnd Bergmann wrote: > > On Tue, Jul 30, 2019 at 5:11 PM Guo Ren wrote: > > > > diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c > > > > cache_op(paddr, size, dma_wb_range);

Re: [PATCH] arm64: asid: Optimize cache_flush for SMT

2019-06-24 Thread Guo Ren
#u Our talk is on this thread: https://lore.kernel.org/linux-arm-kernel/20190624102209.ngwtosgr5fvp3ler@willie-the-truck/T/#m92396a2f238c9eece660cdc0f275e787531d4ec1 > > On Mon, Jun 24, 2019 at 12:04:29AM +0800, guo...@kernel.org wrote: > > From: Guo Ren > > > > The hardware thread

Re: [PATCH] csky: dts: Add NationalChip GX6605S

2019-06-24 Thread Guo Ren
cells = <2>; > + }; > + > + uart: serial@403000 { > + compatible = "ns16550a"; > + reg = <0x00403000 0x400>; > + interrupts = <15>; > + clock-fr

Re: [PATCH] csky: dts: Add NationalChip GX6605S

2019-06-24 Thread Guo Ren
Hi Andreas, On Tue, Jun 25, 2019 at 9:25 AM Andreas Färber wrote: > > Am 25.06.19 um 02:45 schrieb Guo Ren: > > Thx for the patch. No need seperate part into dtsi, > > Sorry, I know from many arm contributions that using a .dtsi is the > right thing here. It logically separa

Re: [PATCH 1/1] perf annotate csky: Add perf annotate support

2019-06-25 Thread Guo Ren
Thx Mao, Approved! Best Regards Guo Ren On Wed, Jun 26, 2019 at 2:53 PM Mao Han wrote: > > This patch add basic arch initialization and instruction associate support > for csky. > > perf annotate --stdio2 > Samples: 161 of event 'cpu-clock:pppH', 4000 Hz, Event

Re: [PATCH 1/1] perf annotate csky: Add perf annotate support

2019-06-26 Thread Guo Ren
On Thu, Jun 27, 2019 at 2:52 AM Arnaldo Carvalho de Melo wrote: > > Em Wed, Jun 26, 2019 at 02:56:55PM +0800, Guo Ren escreveu: > > Thx Mao, > > > > Approved! > > I guess I can take this as a: > > Acked-by: Guo Ren > > Or would this better be: > >

Re: [PATCH] csky: Improve abiv1 mem ops performance with glibc codes

2019-07-01 Thread Guo Ren
Hi Arnd, On Mon, Jul 1, 2019 at 10:52 PM Arnd Bergmann wrote: > > On Sat, Jun 29, 2019 at 7:36 AM wrote: > > > > From: Guo Ren > > > > These codes are copied from glibc/string directory, they are the generic > > implementation for string operation

Re: Linux 5.0-rc1 (test results)

2019-01-08 Thread Guo Ren
Thx Michal, On Tue, Jan 08, 2019 at 04:40:31PM +0100, Michal Hocko wrote: > On Tue 08-01-19 17:51:07, Guo Ren wrote: > [...] > > static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) > > { > > pte_t *pte; > > unsigned long i; > > >

Re: [GIT PULL] csky fixup for linux-5.0-rc1

2019-01-10 Thread Guo Ren
Can I take back this pull request and send a new pull request with https:// URLs ? On Wed, Jan 09, 2019 at 01:29:55PM -0500, Konstantin Ryabitsev wrote: > On Wed, Jan 09, 2019 at 06:05:01PM +, pr-tracker-...@kernel.org wrote: > > The pull request you sent on Wed, 9 Jan 2019 22:49:57 +0800: >

Re: [GIT PULL] csky fixup for linux-5.0-rc1

2019-01-10 Thread Guo Ren
; Please drop it if possible and I'll send another [GIT PULL]. Best Regards Guo Ren On Wed, Jan 09, 2019 at 10:49:57PM +0800, guo...@kernel.org wrote: > The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: > > Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) &

Re: [GIT PULL] csky fixes for v5.0-rc6

2019-02-12 Thread Guo Ren
ngs: interrupt-controller: Update csky mpintc I just send these patches to the mail-list before, but not get Ack. I'll add Cc in these patches and resend them to the mail list. > > Generally, those should get merged through the respective subsystem > trees as listed in the linux/MAINTAINERS file. Ok, I'll remove them in this pull request. Best Regards Guo Ren

Re: [PATCH] csky: remove redundant generic-y

2019-03-22 Thread Guo Ren
Thx Masahiro, Approved and I'll add it into my tree. Best Regards Guo Ren On Fri, Mar 22, 2019 at 08:19:14PM +0900, Masahiro Yamada wrote: > Since commit 7c8bc297 ("kbuild: warn redundant generic-y"), > redundant generic-y is reported. I missed to delete this one. >

Re: [PATCH 7/8] csky: Use latest system call ABI

2019-02-18 Thread Guo Ren
td.h > @@ -2,8 +2,6 @@ > // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. > > #define __ARCH_WANT_SYS_CLONE > -#define __ARCH_WANT_SET_GET_RLIMIT Seems it's not related to y2038 issue. Is __ARCH_WANT_SET_GET_RLIMIT no use ? > -#define __ARCH_WANT_TIME32_SYSCALLS Best Regards Guo Ren

Re: [PATCH] arch:csky:mm/fault.c : Remove duplicate header

2019-03-23 Thread Guo Ren
Approved, thx. On Sat, Mar 23, 2019 at 05:25:17PM +0530, jagdsh.li...@gmail.com wrote: > From: Jagadeesh Pagadala > > Remove duplicate header which is included twice. > > Signed-off-by: Jagadeesh Pagadala > --- > arch/csky/mm/fault.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ar

Re: [PATCH] csky: Update syscall_trace_enter/exit implementation

2019-03-25 Thread Guo Ren
ifdef __KERNEL__ code in the uapi namespace, > it defeats the idea of uapi. Doesn't it belong to non-uapi > include/asm/ptrace.h namespace? Yes, I should move __KERNEL__ codes into arch/csky/include/asm/ptrace.h. But it'll be another patch for the modification. Any other problems? Best Regards Guo Ren

Re: [PATCH] csky: Update syscall_trace_enter/exit implementation

2019-03-25 Thread Guo Ren
On Mon, Mar 25, 2019 at 08:03:39PM +0800, guo...@kernel.org wrote: > From: Guo Ren > > Previous syscall_trace implementation couldn't support AUDITSYSCALL and > SYSCALL_TRACEPOINTS. Now we redesign it to support audit_syscall > and syscall_tracepoints just like other archs&

Re: [GIT PULL] csky fixup for linux-5.0-rc1

2019-01-10 Thread Guo Ren
On Thu, Jan 10, 2019 at 12:22:46PM +0100, Arnd Bergmann wrote: > On Thu, Jan 10, 2019 at 9:11 AM Guo Ren wrote: > > > > Sorry Linus, > > > > This pull-request is wrong on the patch: > > "csky: fixup module relocation error with 807 & 860". > &g

Re: [GIT PULL] csky fixup for linux-5.0-rc1

2019-01-10 Thread Guo Ren
On Thu, Jan 10, 2019 at 03:59:22AM -0800, Linus Torvalds wrote: > On Thu, Jan 10, 2019 at 12:11 AM Guo Ren wrote: > > > > This pull-request is wrong on the patch: > > "csky: fixup module relocation error with 807 & 860". > > diff --git a/arch/csky/ke

Re: [GIT PULL] csky fixup for linux-5.0-rc1

2019-01-10 Thread Guo Ren
On Thu, Jan 10, 2019 at 08:26:13AM -0500, Konstantin Ryabitsev wrote: > On Thu, Jan 10, 2019 at 04:02:03PM +0800, Guo Ren wrote: > > Can I take back this pull request and send a new pull request with > > https:// URLs ? > > It's not necessary at this point, as the pul

[PATCH V3 13/27] csky: Library functions

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/abiv1/bswapdi.c| 18 ++ arch/csky/abiv1/bswapsi.c| 14 ++ arch/csky/abiv1/inc/abi/string.h | 13 ++ arch/csky/abiv1/memcpy.S | 344 +++ arch/csky/abiv1/memset.c | 37 + arch/csky

[PATCH V4 00/27] C-SKY(csky) Linux Kernel Port

2018-09-12 Thread Guo Ren
ith CONFIG_AUDIT 1989292 csky: revert some back with cleanup unistd.h f1454fe csky: cleanup unistd.h 5d2985f csky: cleanup Kconfig and Makefile. 423d97e csky: cancel subdirectories cae2af4 csky: use asm-generic/fcntl.h Guo Ren (27): csky: Build infrastructure csky: defconfig csky: Kernel boo

[PATCH V3 02/27] csky: defconfig

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/configs/defconfig | 61 + 1 file changed, 61 insertions(+) create mode 100644 arch/csky/configs/defconfig diff --git a/arch/csky/configs/defconfig b/arch/csky/configs/defconfig new file mode 100644 index 000

[PATCH V3 18/27] dt-bindings: csky CPU Bindings

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- Documentation/devicetree/bindings/csky/cpus.txt | 70 + 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/csky/cpus.txt diff --git a/Documentation/devicetree/bindings/csky/cpus.txt b/Documentation

[PATCH V3 03/27] csky: Kernel booting

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/kernel/head.S| 78 + arch/csky/kernel/setup.c | 150 + arch/csky/kernel/vmlinux.lds.S | 64 ++ 3 files changed, 292 insertions(+) create mode 100644 arch/csky/kernel

[PATCH V3 04/27] csky: Exception handling

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/abiv1/alignment.c | 331 + arch/csky/abiv1/inc/abi/entry.h | 159 arch/csky/abiv2/inc/abi/entry.h | 157 arch/csky/include/asm/traps.h | 39 arch/csky/include/asm/unistd.h | 3

[PATCH V3 01/27] csky: Build infrastructure

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/Kconfig | 231 + arch/csky/Kconfig.debug| 14 ++ arch/csky/Makefile | 93 + arch/csky/abiv1/Makefile | 8 ++ arch/csky/abiv2/Makefile

[PATCH V3 07/27] csky: MMU and page table management

2018-09-12 Thread Guo Ren
alloc : 0xf020 – 0xff00 (238 MB) Lowmem : 0x8000 – 0xc000 (1GB) Lowmem is directly mapped by msa0 & msa1 reg, and we needn't setup page-table for it. Signed-off-by: Guo Ren --- arch/csky/abiv1/inc/abi/ckmmu.h| 74 arch/csky/abiv1/

[PATCH V3 23/27] clocksource: add gx6605s SOC system timer

2018-09-12 Thread Guo Ren
Changelog: - Add License and Copyright - Use timer-of framework - Change name with upstream feedback - Use clksource_mmio framework Signed-off-by: Guo Ren --- drivers/clocksource/timer-gx6605s.c | 150 1 file changed, 150 insertions(+) create mode

[PATCH V3 22/27] dt-bindings: interrupt-controller: C-SKY SMP intc

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- .../bindings/interrupt-controller/csky,mpintc.txt | 40 ++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt diff --git a/Documentation/devicetree/bindings/interrupt

[PATCH V3 06/27] csky: Cache and TLB routines

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/abiv1/cacheflush.c | 50 arch/csky/abiv1/inc/abi/cacheflush.h | 41 +++ arch/csky/abiv1/inc/abi/tlb.h | 11 ++ arch/csky/abiv2/cacheflush.c | 54 + arch/csky/abiv2/inc/abi/cacheflush.h | 38 ++ arch

[PATCH V3 20/27] dt-bindings: timer: C-SKY Multi-processor timer

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- .../devicetree/bindings/timer/csky,mptimer.txt | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/csky,mptimer.txt diff --git a/Documentation/devicetree/bindings/timer/csky,mptimer.txt b

[PATCH V3 19/27] dt-bindings: timer: gx6605s SOC timer

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- .../bindings/timer/csky,gx6605s-timer.txt | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/csky,gx6605s-timer.txt diff --git a/Documentation/devicetree/bindings/timer/csky,gx6605s

[PATCH V3 14/27] csky: User access

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/include/asm/uaccess.h | 398 arch/csky/lib/usercopy.c| 271 +++ 2 files changed, 669 insertions(+) create mode 100644 arch/csky/include/asm/uaccess.h create mode 100644 arch/csky/lib

[PATCH V3 12/27] csky: ELF and module probe

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/include/asm/elf.h | 149 arch/csky/kernel/module.c | 82 2 files changed, 231 insertions(+) create mode 100644 arch/csky/include/asm/elf.h create mode 100644 arch/csky/kernel/module.c

[PATCH V3 05/27] csky: System Call

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/include/asm/syscall.h | 69 + arch/csky/include/asm/syscalls.h| 14 arch/csky/include/uapi/asm/unistd.h | 10 ++ arch/csky/kernel/syscall.c | 42 ++ arch/csky/kernel

[PATCH V3 15/27] csky: Debug and Ptrace GDB

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/include/asm/bug.h | 26 +++ arch/csky/include/uapi/asm/ptrace.h | 103 arch/csky/kernel/dumpstack.c| 64 arch/csky/kernel/ptrace.c | 317 4 files changed, 510 insertions

[PATCH V3 16/27] csky: SMP support

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/include/asm/smp.h | 26 + arch/csky/kernel/smp.c | 234 2 files changed, 260 insertions(+) create mode 100644 arch/csky/include/asm/smp.h create mode 100644 arch/csky/kernel/smp.c diff --git a/arch

[PATCH V3 10/27] csky: IRQ handling

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/include/asm/irq.h | 8 +++ arch/csky/include/asm/irqflags.h | 49 arch/csky/kernel/irq.c | 21 + 3 files changed, 78 insertions(+) create mode 100644 arch/csky/include/asm/irq.h

[PATCH V3 08/27] csky: Process management and Signal

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/abiv2/fpu.c | 281 + arch/csky/abiv2/inc/abi/fpu.h | 66 ++ arch/csky/include/asm/mmu_context.h | 148 ++ arch/csky/include/asm/processor.h | 120 +++ arch/csky/include/asm

[PATCH V3 09/27] csky: VDSO and rt_sigreturn

2018-09-12 Thread Guo Ren
Signed-off-by: Guo Ren --- arch/csky/abiv1/inc/abi/vdso.h | 17 + arch/csky/abiv2/inc/abi/vdso.h | 24 arch/csky/include/asm/vdso.h | 12 ++ arch/csky/kernel/vdso.c| 85 ++ 4 files changed, 138 insertions(+) create mode

<    1   2   3   4   5   6   7   8   >