Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-18 Thread Gregory Farnum
Maybe we resolved this conversation; I can't quite tell... On Fri, May 15, 2020 at 12:16 PM Jeff Layton wrote: > > On Fri, 2020-05-15 at 19:56 +0300, Amir Goldstein wrote: > > On Fri, May 15, 2020 at 2:38 PM Jeff Layton wrote: > > > On Fri, 2020-05-15 at 12:15 +0100, Luis Henriques wrote: > > >

Re: [PATCH] locks: ensure that fl_owner is always initialized properly in flock and lease codepaths

2014-05-06 Thread Gregory Farnum
The Ceph bit is fine. Acked-by: Greg Farnum On Mon, Apr 28, 2014 at 10:50 AM, Jeff Layton wrote: > Currently, the fl_owner isn't set for flock locks. Some filesystems use > byte-range locks to simulate flock locks and there is a common idiom in > those that does: > > fl->fl_owner = (fl_owne

Re: [PATCH 2/2] block: create ioctl to discard-or-zeroout a range of blocks

2016-03-09 Thread Gregory Farnum
On Thu, Mar 3, 2016 at 3:10 PM, Dave Chinner wrote: > On Thu, Mar 03, 2016 at 05:39:52PM -0500, Theodore Ts'o wrote: >> On Thu, Mar 03, 2016 at 01:54:54PM -0500, Martin K. Petersen wrote: >> > > "Christoph" == Christoph Hellwig writes: >> > >> > Christoph> - FALLOC_FL_PUNCH_HOLE assures zero

Re: [PATCH 2/2] block: create ioctl to discard-or-zeroout a range of blocks

2016-03-18 Thread Gregory Farnum
On Thu, Mar 17, 2016 at 10:47 AM, Linus Torvalds wrote: > On Wed, Mar 16, 2016 at 10:18 PM, Gregory Farnum wrote: >> >> So we've not asked for NO_HIDE_STALE on the mailing lists, but I think >> it was one of the problems Sage had using xfs in his BlueStore >> impl

Re: [GIT PULL] Ceph fixes for -rc7

2016-03-30 Thread Gregory Farnum
On Wed, Mar 30, 2016 at 1:04 AM, Ilya Dryomov wrote: > On Wed, Mar 30, 2016 at 4:40 AM, NeilBrown wrote: >> On Wed, Mar 30 2016, Yan, Zheng wrote: >> >>> On Wed, Mar 30, 2016 at 8:24 AM, NeilBrown wrote: On Fri, Mar 25 2016, Ilya Dryomov wrote: > On Fri, Mar 25, 2016 at 5:02 AM, Ne

Re: [PATCH v2 2/2] ceph: quota: fix quota subdir mounts

2019-03-18 Thread Gregory Farnum
On Mon, Mar 18, 2019 at 2:32 PM Yan, Zheng wrote: > After reading the code carefully. I feel a little uncomfortable with > the "lookup_ino" in get_quota_realm. how about populating directories > above the 'mount subdir' during mounting (similar to cifs_get_root ). Isn't that going to be a proble

Re: [PATCH v2 2/2] ceph: quota: fix quota subdir mounts

2019-03-18 Thread Gregory Farnum
On Mon, Mar 18, 2019 at 4:25 PM Luis Henriques wrote: > > "Yan, Zheng" writes: > > > On Mon, Mar 18, 2019 at 5:06 PM Gregory Farnum wrote: > >> > >> On Mon, Mar 18, 2019 at 2:32 PM Yan, Zheng wrote: > >> > After reading the code c

Re: [PATCH v2] ceph: allow object copies across different filesystems in the same cluster

2019-09-09 Thread Gregory Farnum
On Mon, Sep 9, 2019 at 4:15 AM Luis Henriques wrote: > > "Jeff Layton" writes: > > > On Mon, 2019-09-09 at 11:28 +0100, Luis Henriques wrote: > >> OSDs are able to perform object copies across different pools. Thus, > >> there's no need to prevent copy_file_range from doing remote copies if the

Re: [PATCH 2/2] block: create ioctl to discard-or-zeroout a range of blocks

2016-03-19 Thread Gregory Farnum
On Wed, Mar 16, 2016 at 5:33 PM, Eric Sandeen wrote: > I may have lost the thread at this point, with poor Darrick's original > patch submission devolving into a long thread about a NO_HIDE_STALE patch > used at Google, but I don't *think* Ceph ever asked for NO_HIDE_STALE. > > At least I can't fi

Re: [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by ktime_get_real_ts()

2016-02-04 Thread Gregory Farnum
On Thu, Feb 4, 2016 at 5:31 AM, Arnd Bergmann wrote: > On Thursday 04 February 2016 10:01:31 Ilya Dryomov wrote: >> On Thu, Feb 4, 2016 at 9:30 AM, Arnd Bergmann wrote: >> > On Thursday 04 February 2016 10:00:19 Yan, Zheng wrote: >> >> > On Feb 4, 2016, at 05:27, Arnd Bergmann wrote: >> > >> > s

Re: [PATCH] ceph: Delete unused variables in mds_client

2017-10-12 Thread Gregory Farnum
On Thu, Oct 12, 2017 at 2:55 PM, Christos Gkekas wrote: > Remove variables in mds_client that are set but never used. Hmm, it looks like all the values removed here (except err) *are* used and this patch would break the world. Specifically... > > Signed-off-by: Christos Gkekas > --- > fs/ceph/