to bring it up in case
its actually affecting other people.
I'm not subscribed to the list so if you reply please CC to my address.
Regards,
George McCollister
This message is for the designated recipient only and may contain
privileged, proprietary, or otherwise private information. If you have
Sven Van Asbroeck
> ---
>
> To: Bryan Whitehead
> To: "David S. Miller"
> To: Jakub Kicinski
> To: George McCollister
> Cc: unglinuxdri...@microchip.com
> Cc: net...@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
>
> drivers/net/ethernet/microchip/la
On Thu, Apr 8, 2021 at 12:46 PM Sven Van Asbroeck wrote:
>
> Hi George,
>
> On Thu, Apr 8, 2021 at 1:36 PM George McCollister
> wrote:
> >
> > Can you explain the difference in behavior with what I was observing
> > on the LAN7431?
>
> I'm not usin
On Thu, Apr 8, 2021 at 1:35 PM Sven Van Asbroeck wrote:
>
> Hi George,
>
> On Thu, Apr 8, 2021 at 2:26 PM Sven Van Asbroeck wrote:
> >
> > George, I will send a patch for you to try shortly. Except if you're
> > already ahead :)
>
> Would this work for you? It does for me.
Works for me too.
>
>
This driver is for the NovaTech 124 4x serial expansion board for the
NovaTech OrionLXm.
Firmware source code can be found here:
https://github.com/novatechweb/nt124
Signed-off-by: George McCollister
---
drivers/usb/serial/Kconfig | 9 +
drivers/usb/serial/Makefile | 1 +
drivers/usb
:17PM -0600, George McCollister wrote:
>> This driver is for the NovaTech 124 4x serial expansion board for the
>> NovaTech OrionLXm.
>>
>> Firmware source code can be found here:
>> https://github.com/novatechweb/nt124
>>
>> Signed-off-by: George McCollister
&
mmunication problem?
> --
> 2.30.0
>
scripts/checkpatch.pl gives errors about DOS line endings but once
that is resolved this looks good. I tested it on an HSR network with
the software implementation and the xrs700x which uses offloading and
everything still works. I don't have a way to force anything on the
HSR network to reuse sequence numbers after 400ms.
Reviewed-by: George McCollister
On Fri, Feb 19, 2021 at 2:27 AM Wenzel, Marco wrote:
>
> On Thu, Feb 18, 2021 at 6:06 PM : George McCollister
> wrote:
> >
> > On Thu, Feb 18, 2021 at 9:01 AM Marco Wenzel > eberle.de> wrote:
> > >
> > > In IEC 62439-3 EntryForgetTime is defined w
I don't see the second patch.
Regards,
George McCollister
On Fri, Dec 4, 2020 at 8:59 AM Oleksij Rempel wrote:
>
> Allow DSA drivers to export stats64
>
> Signed-off-by: Oleksij Rempel
> Reviewed-by: Vladimir Oltean
Reviewed-by: George McCollister
I've already updated my xrs700x dsa driver for v3 to use this. I'm
blocked on
Trim all 4 bytes of the received FCS; not just 2 of them. Leaving 2
bytes of the FCS on the frame breaks DSA tailing tag drivers.
Fixes: a8db76d40e4d ("lan743x: boost performance on cpu archs w/o dma cache
snooping")
Signed-off-by: George McCollister
---
drivers/net/ethernet
keep a copy of the tagging protocol in the DSA
switch tree")
Signed-off-by: George McCollister
---
net/dsa/dsa2.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index eb709d988c54..8f9e35e1aa89 100644
--- a/net/dsa/dsa2.c
+++
On Mon, Mar 22, 2021 at 3:46 PM Vladimir Oltean wrote:
>
> On Mon, Mar 22, 2021 at 03:26:50PM -0500, George McCollister wrote:
> > Use a temporary variable to hold the return value from
> > dsa_tag_driver_get() instead of assigning it to dst->tag_ops. Leaving
> > an
4 bytes of the FCS; not just 2")
> Link: https://lore.kernel.org/lkml/20210408172353.21143-1-thesve...@gmail.com/
> Signed-off-by: Sven Van Asbroeck
I'm glad everyone was able to work together to get this fixed properly
without any figure pointing or mud slinging! Kudos everyone.
still fail to
> link because it calls hsr_get_version() and for that one there is no
> easy solution.
Thanks for looking into this. It's not something I've run into before.
It didn't occur to me what would happen if HSR was a module. I'll look
out for this in the future.
Sorry for the inconvenience.
Reviewed-by: George McCollister
-George
> --
> Florian
On Mon, Feb 22, 2021 at 7:38 AM Wenzel, Marco wrote:
>
> On Fri, Feb 19, 2021 at 2:14 PM : George McCollister
> wrote:
> >
> > On Fri, Feb 19, 2021 at 2:27 AM Wenzel, Marco > eberle.de> wrote:
> > >
> > > On Thu, Feb 18, 2021 at 6:06 PM : George M
On Fri, Dec 4, 2020 at 8:59 AM Oleksij Rempel wrote:
>
> Add stats support for the ar9331 switch.
>
> Signed-off-by: Oleksij Rempel
> ---
> drivers/net/dsa/qca/ar9331.c | 247 ++-
> 1 file changed, 246 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/
On Fri, Dec 4, 2020 at 8:59 AM Oleksij Rempel wrote:
>
> Add stats support for the ar9331 switch.
>
> Signed-off-by: Oleksij Rempel
> ---
> drivers/net/dsa/qca/ar9331.c | 247 ++-
> 1 file changed, 246 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/
idn't work depending on the order the ports were added to the
hsr device.
Fixes: bd62e6f5e6a9 ("net: dsa: xrs700x: add HSR offloading support")
Signed-off-by: George McCollister
---
drivers/net/dsa/xrs700x/xrs700x.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
On Wed, Feb 26, 2014 at 7:28 AM, Peter Zijlstra wrote:
> On Tue, Feb 18, 2014 at 05:56:51PM -0600, George McCollister wrote:
>> dequeue_entity() is called when p->on_rq and sets se->on_rq = 0
>> which appears to guarentee that the !se->on_rq condition is met.
dequeue_entity() is called when p->on_rq and sets se->on_rq = 0
which appears to guarentee that the !se->on_rq condition is met.
If the task has done set_current_state(TASK_INTERRUPTIBLE) without
schedule() the second condition will be met and vruntime will be
incorrectly adjusted twice.
In certai
For company details see:
http://www.novatechweb.com
Signed-off-by: George McCollister
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor
: George McCollister
---
.../devicetree/bindings/arm/omap/omap.txt | 3 +
arch/arm/boot/dts/Makefile | 3 +-
arch/arm/boot/dts/am335x-lxm.dts | 354 +
3 files changed, 359 insertions(+), 1 deletion(-)
create mode 100644 arch
Felipe,
Thank you for your reply.
>> + vbat: fixedregulator@0 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "vbat";
>> + regulator-min-microvolt = <500>;
>> + regulator-max-microvolt = <500>;
>> + regulator-boo
The NovaTech 133 I/O board is an expansion card for the NovaTech
OrionLXm with 16 digital input channels and 4 digital output channels.
Signed-off-by: George McCollister
---
drivers/iio/Kconfig | 1 +
drivers/iio/Makefile | 1 +
drivers/iio/waveform/Kconfig | 14
Output can be held high or low for a specified period of time.
Support for waveform capture could be added in the future.
Signed-off-by: George McCollister
---
Documentation/ABI/testing/sysfs-bus-iio | 7 +++
drivers/iio/industrialio-core.c | 3
For company details see:
http://www.novatechweb.com
Signed-off-by: George McCollister
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor
: George McCollister
---
.../devicetree/bindings/arm/omap/omap.txt | 3 +
arch/arm/boot/dts/Makefile | 3 +-
arch/arm/boot/dts/am335x-lxm.dts | 362 +
3 files changed, 367 insertions(+), 1 deletion(-)
create mode 100644 arch
This driver is for the NovaTech 124 4x serial expansion board for the
NovaTech OrionLXm.
Firmware source code can be found here:
https://github.com/novatechweb/nt124
Signed-off-by: George McCollister
---
Changes to v1:
- Added description after nt124.c on line 2.
- Removed DRIVER_AUTHOR and
On Mon, Dec 15, 2014 at 3:52 AM, Johan Hovold wrote:
> On Sun, Dec 14, 2014 at 11:51:11AM -0600, George McCollister wrote:
>> Johan,
>>
>> While working on the tx_empty changes you suggested it occurred to me
>> that it might not be obvious to others that the firmwa
Use external clock for RMII since the internal clock doesn't meet the
jitter requirements.
Signed-off-by: George McCollister
---
arch/arm/boot/dts/am335x-lxm.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-lxm.dts b/arch/arm/boot/dts/am335x-lxm.dts
Johan,
Thanks for the thorough review.
On Wed, Dec 10, 2014 at 7:04 AM, Johan Hovold wrote:
> On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote:
>> This driver is for the NovaTech 124 4x serial expansion board for the
>> NovaTech OrionLXm.
>>
>>
Johan,
While working on the tx_empty changes you suggested it occurred to me
that it might not be obvious to others that the firmware doesn't send
a packet with the NT124_CTRL_TXEMPTY flag cleared when it begins
transmitting. The practical implication is that if the driver sets
tx_empty = true whe
Add support for the KSZ9567 7-Port Gigabit Ethernet Switch to the
ksz9477 driver. The KSZ9567 supports both SPI and I2C. Oddly the
ksz9567 is already in the device tree binding documentation.
Signed-off-by: George McCollister
---
drivers/net/dsa/microchip/ksz9477.c | 9 +
drivers
connected via I2C).
Remove NET_DSA_TAG_KSZ_COMMON since it's not needed.
George McCollister (2):
net: dsa: microchip: add ksz9567 to ksz9477 driver
net: dsa: microchip: remove NET_DSA_TAG_KSZ_COMMON
Tristram Ha (1):
net: dsa: microchip: add KSZ9477 I2C driver
drivers/net/dsa/microchip/Kc
From: Tristram Ha
Add KSZ9477 I2C driver support. The code ksz9477.c and ksz_common.c are
used together to generate the I2C driver.
Signed-off-by: Tristram Ha
[george.mccollis...@gmail.com: bring up to date, use ksz_common regmap macros]
Signed-off-by: George McCollister
---
drivers/net/dsa
Remove the superfluous NET_DSA_TAG_KSZ_COMMON and just use the existing
NET_DSA_TAG_KSZ. Update the description to mention the three switch
families it supports. No functional change.
Signed-off-by: George McCollister
---
net/dsa/Kconfig | 9 ++---
net/dsa/Makefile | 2 +-
2 files changed
On Fri, Sep 6, 2019 at 4:42 PM Marek Vasut wrote:
>
> On 9/6/19 11:30 PM, George McCollister wrote:
>
> [...]
>
> > --- /dev/null
> > +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c
> > @@ -0,0 +1,100 @@
> > +// SPDX-License-Identifier: GPL-2.0
> >
On Fri, Sep 6, 2019 at 4:42 PM Marek Vasut wrote:
>
> On 9/6/19 11:30 PM, George McCollister wrote:
> > Add support for the KSZ9567 7-Port Gigabit Ethernet Switch to the
> > ksz9477 driver. The KSZ9567 supports both SPI and I2C. Oddly the
> > ksz9567 is already in
From: Tristram Ha
Add KSZ9477 I2C driver support. The code ksz9477.c and ksz_common.c are
used together to generate the I2C driver.
Signed-off-by: Tristram Ha
[george.mccollis...@gmail.com: bring up to date, use ksz_common regmap macros]
Signed-off-by: George McCollister
---
Changes since
connected via I2C).
Remove NET_DSA_TAG_KSZ_COMMON since it's not needed.
Changes since v1:
Put ksz9477_i2c.c includes in alphabetical order.
Added Reviewed-Bys.
George McCollister (2):
net: dsa: microchip: add ksz9567 to ksz9477 driver
net: dsa: microchip: remove NET_DSA_TAG_KSZ_COMMON
Tristr
Add support for the KSZ9567 7-Port Gigabit Ethernet Switch to the
ksz9477 driver. The KSZ9567 supports both SPI and I2C. Oddly the
ksz9567 is already in the device tree binding documentation.
Signed-off-by: George McCollister
Reviewed-by: Marek Vasut
---
Changes since v1:
- Added
Remove the superfluous NET_DSA_TAG_KSZ_COMMON and just use the existing
NET_DSA_TAG_KSZ. Update the description to mention the three switch
families it supports. No functional change.
Signed-off-by: George McCollister
Reviewed-by: Marek Vasut
---
Changes since v1:
- Added Reviewed-by
Andrew,
On Tue, Sep 10, 2019 at 9:03 AM Andrew Lunn wrote:
>
> Hi George
>
> > +KSZ_REGMAP_TABLE(ksz9477, not_used, 16, 0, 0);
> > +
> > @@ -294,6 +294,8 @@ static inline void ksz_pwrite32(struct ksz_device *dev,
> > int port, int offset,
> > #define KSZ_SPI_OP_RD3
> > #define
Use the register value width as the regmap_config name to prevent the
following error when the second and third regmap_configs are
initialized.
"debugfs: Directory '${bus-id}' with parent 'regmap' already present!"
Signed-off-by: George McCollister
---
drivers/
Add PIDs for the NovaTech OrionLX+ and Orion I/O so they can be
automatically detected.
Signed-off-by: George McCollister
---
drivers/usb/serial/ftdi_sio.c | 2 ++
drivers/usb/serial/ftdi_sio_ids.h | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial
SoC.
Signed-off-by: George McCollister
---
.../devicetree/bindings/regulator/pfuze100.txt | 8 +++-
drivers/regulator/pfuze100-regulator.c | 24 ++
include/linux/regulator/pfuze100.h | 1 +
3 files changed, 32 insertions(+), 1 deletion
ilding with this commit reversed
(which solves the problem) until I have a chance to look into this
further.
Regards,
George McCollister
On Fri, Jul 3, 2015 at 8:09 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> This effectively reverts the following three commits:
>
> 7bc1
Commit-ID: 791c9e0292671a3bfa95286bb5c08129d8605618
Gitweb: http://git.kernel.org/tip/791c9e0292671a3bfa95286bb5c08129d8605618
Author: George McCollister
AuthorDate: Tue, 18 Feb 2014 17:56:51 -0600
Committer: Ingo Molnar
CommitDate: Thu, 27 Feb 2014 12:29:38 +0100
sched: Fix double
49 matches
Mail list logo
