[PATCH] gpio: pcf857x: cleanup irq_demux_work and use threaded irq

2013-08-27 Thread George Cherian
This patch - removes the irq_demux_work - Uses devm_request_threaded_irq - Call the user handler iff gpio_to_irq is done. Signed-off-by: George Cherian --- drivers/gpio/gpio-pcf857x.c | 52 +++-- 1 file changed, 27 insertions

[PATCH v2 0/3] Add Generic USB VBUS/ID detection via GPIO using extcon

2013-08-28 Thread George Cherian
OF support https://lkml.org/lkml/2013/8/27/70 [5] - [PATCH] gpio: pcf857x: cleanup irq_demux_work and use threaded irq https://lkml.org/lkml/2013/8/27/207 George Cherian (3): extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO drivers: Makefile: Extcon is a framework so

[PATCH v2 2/3] drivers: Makefile: Extcon is a framework so bump it up

2013-08-28 Thread George Cherian
Bump up the order, since extcon is a framework and needed by other drivers. With the previous order it failed to detect extcon device in DWC3 when both were compiled built-in. Signed-off-by: George Cherian --- drivers/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v2 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection

2013-08-28 Thread George Cherian
Add -extcon nodes for USB ID pin detection. -i2c nodes. -pcf nodes to which USB ID pin is connected. Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 52 +- 1 file changed, 51 insertions(+), 1 deletion(-) diff

[PATCH v2 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-28 Thread George Cherian
Add a generic USB VBUS/ID detection EXTCON driver. This driver expects the ID/VBUS pin are connected via GPIOs. This driver is tested on DRA7x board were the ID pin is routed via GPIOs. The driver supports both VBUS and ID pin configuration and ID pin only configuration. Signed-off-by: George

[PATCH v3 2/3] drivers: Makefile: Extcon is a framework so bump it up

2013-08-28 Thread George Cherian
Bump up the order, since extcon is a framework and needed by other drivers. With the previous order it failed to detect extcon device in DWC3 when both were compiled built-in. Signed-off-by: George Cherian --- drivers/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v3 0/3] Add Generic USB VBUS/ID detection via GPIO using extcon

2013-08-28 Thread George Cherian
https://lkml.org/lkml/2013/8/27/70 [5] - [PATCH] gpio: pcf857x: cleanup irq_demux_work and use threaded irq https://lkml.org/lkml/2013/8/27/207 George Cherian (3): extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO drivers: Makefile: Extcon is a framework so bump i

[PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-28 Thread George Cherian
2 of the License, or + * (at your option) any later version. + * + * Author: George Cherian + * + * Based on extcon-palmas.c + * + * Author: Kishon Vijay Abraham I + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * M

Re: [PATCH v2 0/3] Add Generic USB VBUS/ID detection via GPIO using extcon

2013-08-28 Thread George Cherian
On 8/28/2013 7:29 PM, George Cherian wrote: Hi, These patches add generic support for USB VBUS/ID pin detection using extcon framework. The USB ID pin on DRA7xx is connected via the gpio expander pcf8575. The interrupt line of the same is connected to the gpio 11 of bank 6. The following

[PATCH v3 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection

2013-08-28 Thread George Cherian
Add -extcon nodes for USB ID pin detection. -i2c nodes. -pcf nodes to which USB ID pin is connected. Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-28 Thread George Cherian
Hi Chanwoo, Thanks for the review and sorry for all the trivial mistakes. On 8/29/2013 7:05 AM, Chanwoo Choi wrote: Hi George, You didn't modify this patchset about my comment on v1 patchset. Please pay attention to comment. On 08/29/2013 02:33 AM, George Cherian wrote: Add a generi

Re: [PATCH v3 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection

2013-08-28 Thread George Cherian
On 8/28/2013 11:24 PM, Sergei Shtylyov wrote: On 08/28/2013 09:33 PM, George Cherian wrote: Add -extcon nodes for USB ID pin detection. -i2c nodes. -pcf nodes to which USB ID pin is connected. Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 50

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread George Cherian
according to each gpio state at same time. Also, It include critical problem. see above You should move gpio_usbvid_request_irq() call before extcon_dev_register(). +if (ret) +goto err0; ? As following previous comment about v1 patchset: I need correct meaning name as err_thread or etc ... okay +

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread George Cherian
On 8/29/2013 4:07 PM, Chanwoo Choi wrote: On 08/29/2013 04:30 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 11:53 AM, Chanwoo Choi wrote: [snip] You should keep following naming stlye. extcon-gpio-usbvid.c is wrong naming style. - extcon-[device name].c - extcon-gpio-usbvid.c -> ext

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread George Cherian
Hi Chanwoo, On 8/29/2013 5:42 PM, Chanwoo Choi wrote: [big snip ] I tested various development board based on Samsung Exynos series SoC. Although some gpio of Exynos series SoC set high state(non zero, 1) as default value, this gpio state could mean off state, disconnected or un-powered state

Re: [PATCH] gpio: pcf857x: cleanup irq_demux_work and use threaded irq

2013-08-29 Thread George Cherian
Hi Linus, Thanks for the review. I will split it and send v2. On 8/29/2013 6:27 PM, Linus Walleij wrote: On Tue, Aug 27, 2013 at 12:30 PM, George Cherian wrote: This patch - removes the irq_demux_work - Uses devm_request_threaded_irq - Call the user handler iff

[PATCH 5/5] usb: musb: dsps: Remove the phy control from glue and add phy driver APIs

2013-07-08 Thread George Cherian
Remove usb phy control module access from platform glue. The same is now done using am phy driver and phy-omap-control. Signed-off-by: George Cherian --- drivers/usb/musb/musb_dsps.c | 105 +++ 1 file changed, 36 insertions(+), 69 deletions(-) diff

[PATCH 3/5] phy: phy-amxxxx-usb: Add PHY driver for amxxxx platform

2013-07-08 Thread George Cherian
Adds phy driver support for am33xx platform, the host/device peripheral controller shall get this phy object to control the phy operations. Signed-off-by: George Cherian --- drivers/phy/Kconfig | 12 +++ drivers/phy/Makefile | 1 + drivers/phy/phy-am-usb.c | 201

[PATCH 4/5] arm: dts: Add USB phy nodes for AM33XX

2013-07-08 Thread George Cherian
Add DT bindings of phy nodes for AM33XX platform. Signed-off-by: George Cherian --- arch/arm/boot/dts/am33xx.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 8e1248f..4f3cca0 100644 --- a/arch

[PATCH 2/5] usb: phy: phy-omap-control: Add API to power on/off USB PHY for AM335X

2013-07-08 Thread George Cherian
Add API to power on/off USB PHY for AM335X. This API will be called from phy-am-usb driver. Signed-off-by: George Cherian --- drivers/usb/phy/phy-omap-control.c | 32 include/linux/usb/omap_control_usb.h | 11 +++ 2 files changed, 43 insertions

[PATCH 1/5] usb: musb: dsps: enable dual instance support for am33xx platform

2013-07-08 Thread George Cherian
From: Ravi Babu The dsps am33xx platform has two instances of musb controller, enable the support for dual musb instances Signed-off-by: Ravi Babu --- drivers/usb/musb/musb_dsps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/mus

[PATCH 0/5] Add phy support for AM335X platform using Generic PHy framework

2013-07-08 Thread George Cherian
tree.git am335x-phy-driver George Cherian (4): usb: phy: phy-omap-control: Add API to power on/off USB PHY for AM335X phy: phy-am-usb: Add PHY driver for am platform arm: dts: Add USB phy nodes for AM33XX usb: musb: dsps: Remove the phy control from glue and add phy driver AP

Re: [PATCH 0/5] Add phy support for AM335X platform using Generic PHy framework

2013-07-08 Thread George Cherian
On 7/9/2013 1:14 AM, Sebastian Andrzej Siewior wrote: On 07/08/2013 12:43 PM, George Cherian wrote: This patch series adds phy support for AM335X platform. This patch series is based on Generic PHY framework [1]. This series has - adds dual musb instances support for am335x platform

[PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread George Cherian
Adds device node for HS USB Host module for AM437x changes from v1 renamed synopsis to snps removed flag tx-fifo-resize Signed-off-by: George Cherian --- arch/arm/boot/dts/am4372.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch

Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread George Cherian
On 7/9/2013 3:50 PM, Felipe Balbi wrote: On Tue, Jul 09, 2013 at 02:47:26PM +0530, George Cherian wrote: Adds device node for HS USB Host module for AM437x changes from v1 renamed synopsis to snps removed flag tx-fifo-resize the patch revision changes don't need to go to the commit log,

Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread George Cherian
On 7/9/2013 4:57 PM, Felipe Balbi wrote: Hi, On Tue, Jul 09, 2013 at 04:51:35PM +0530, George Cherian wrote: + compatible = "snps,dwc3"; + reg = <0x4839 0xcfff>; weird size, shouldn't this be 0xd000 then the

Re: [PATCH 0/5] Add phy support for AM335X platform using Generic PHy framework

2013-07-09 Thread George Cherian
On 7/9/2013 5:05 PM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 09 July 2013 11:10 AM, George Cherian wrote: On 7/9/2013 1:14 AM, Sebastian Andrzej Siewior wrote: On 07/08/2013 12:43 PM, George Cherian wrote: This patch series adds phy support for AM335X platform. This patch series is

Re: [PATCH 0/5] Add phy support for AM335X platform using Generic PHy framework

2013-07-09 Thread George Cherian
On 7/10/2013 10:53 AM, Felipe Balbi wrote: On Wed, Jul 10, 2013 at 10:26:25AM +0530, George Cherian wrote: On 7/9/2013 5:05 PM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 09 July 2013 11:10 AM, George Cherian wrote: On 7/9/2013 1:14 AM, Sebastian Andrzej Siewior wrote: On 07/08/2013 12:43

[PATCH v3] arm: dts: AM43x: Add usb DT nodes for AM4372

2013-07-10 Thread George Cherian
This patch adds - HS USB nodes - phy nodes - usb control module nodes. Signed-off-by: George Cherian --- changes from v2 change synopsis to snps use simple node names add both USB and PHY instances add usbctrl node changes from v1 renamed synopsis to snps removed flag

Re: PCF857x and 16-bit GPIO expanders

2013-09-19 Thread George Cherian
On 9/18/2013 11:06 PM, Felipe Balbi wrote: Hi, On Wed, Sep 18, 2013 at 07:18:04PM +0200, Laurent Pinchart wrote: On Wednesday 18 September 2013 13:16:27 Linus Walleij wrote: On Tue, Sep 17, 2013 at 9:07 PM, Felipe Balbi wrote: has anyone ever successfully using gpio-pcf857x.c driver with 16-

Re: PCF857x and 16-bit GPIO expanders

2013-09-19 Thread George Cherian
On 9/19/2013 5:37 PM, Nishanth Menon wrote: On 09/19/2013 03:13 AM, George Cherian wrote: On 9/18/2013 11:06 PM, Felipe Balbi wrote: Hi, On Wed, Sep 18, 2013 at 07:18:04PM +0200, Laurent Pinchart wrote: On Wednesday 18 September 2013 13:16:27 Linus Walleij wrote: On Tue, Sep 17, 2013 at 9

[PATCH v3 1/3] gpio: pcf857x: change to devm_request_threaded_irq

2013-09-04 Thread George Cherian
Remove the request_irq and use devm_request_threaded_irq also cleanup free_irq. devm_* takes care of that. Signed-off-by: George Cherian --- drivers/gpio/gpio-pcf857x.c | 28 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-pcf857x.c

[PATCH v3 2/3] gpio: pcf857x: remove the irq_demux_work and gpio->irq

2013-09-04 Thread George Cherian
Now that we are using devm_request_threaded_irq no need for irq_demux_work and gpio->irq. Remove all its references. Signed-off-by: George Cherian --- drivers/gpio/gpio-pcf857x.c | 37 - 1 file changed, 37 deletions(-) diff --git a/drivers/gpio/g

[PATCH v4 0/3] cleanup of gpio_pcf857x.c

2013-09-04 Thread George Cherian
(in patch 2) Note: these patches were made after applying [1]. [1] - [PATCH v5] gpio: pcf857x: Add OF support - https://lkml.org/lkml/2013/8/27/70 George Cherian (3): gpio: pcf857x: change to devm_request_threaded_irq gpio: pcf857x: remove the irq_demux_work and gpio->irq gpio: pcf857x: cal

[PATCH v3 3/3] gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done

2013-09-04 Thread George Cherian
Q_NOPROBE set [ 41.009465] IRQ_NOREQUEST set Signed-off-by: George Cherian --- drivers/gpio/gpio-pcf857x.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c index ef52ee3..4887b8c 100644 --- a/dri

Re: [PATCH] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black

2013-09-05 Thread George Cherian
On 9/6/2013 12:03 PM, Koen Kooi wrote: The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use. MMC support for AM335x still isn't in, so only the LDO change has been added. Signed-off-by: Koen Kooi --- .../{am335x-bone.dts => am33

Re: [PATCH] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black

2013-09-06 Thread George Cherian
On 9/6/2013 12:40 PM, Koen Kooi wrote: Op 6 sep. 2013, om 08:57 heeft George Cherian het volgende geschreven: On 9/6/2013 12:03 PM, Koen Kooi wrote: The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use. MMC support for AM335x

[PATCH] arm: dts: am33xx: Add mmc nodes for am33xx platform

2013-09-06 Thread George Cherian
Add mmc nodes for am33xx platforms Signed-off-by: George Cherian --- Verified after applying [1] and [2] [1] - [PATCH v4 0/6] dma: edma: Support scatter-lists of any length - https://lkml.org/lkml/2013/8/29/466 [2] - [PATCH v2] ARM: dts: add AM33XX EDMA support - https://lkml.org/lkml/2013/8

[PATCH] extcon: palmas: Dont set USB state if ID pin is grounded

2013-09-10 Thread George Cherian
In OMAP5 when USB-HOST is set true, the VBUS regulator is turned ON. This causes a VBUS interrupt, ignore the same if we are already in USB-HOST. Signed-off-by: George Cherian --- drivers/extcon/extcon-palmas.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/extcon/extcon

Re: [PATCH] extcon: palmas: Dont set USB state if ID pin is grounded

2013-09-10 Thread George Cherian
On 9/10/2013 1:54 PM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 10 September 2013 01:19 PM, George Cherian wrote: In OMAP5 when USB-HOST is set true, the VBUS regulator is turned ON. This causes a VBUS interrupt, ignore the same if we are already in USB-HOST. You'll get VBUS inte

Re: [PATCH] extcon: palmas: Dont set USB state if ID pin is grounded

2013-09-10 Thread George Cherian
On 9/10/2013 2:47 PM, Laxman Dewangan wrote: On Tuesday 10 September 2013 01:19 PM, George Cherian wrote: In OMAP5 when USB-HOST is set true, the VBUS regulator is turned ON. This causes a VBUS interrupt, ignore the same if we are already in USB-HOST. Signed-off-by: George Cherian

[PATCH] extcon: palmas: Handle ID interrupt properly using USB_ID_INT_SRC

2013-10-10 Thread George Cherian
Always cross check with the ID state and the source of interrupt. Also add a case in which ID Source is ID_GND but LATCH state is set wrongly. This uses the previous Link stat to determine the new state. Signed-off-by: George Cherian --- drivers/extcon/extcon-palmas.c | 15 --- 1

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread George Cherian
Hi Chanwoo, On 8/30/2013 5:41 AM, Chanwoo Choi wrote: Hi George, On 08/29/2013 10:45 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 5:42 PM, Chanwoo Choi wrote: [big snip ] I tested various development board based on Samsung Exynos series SoC. Although some gpio of Exynos series SoC

[PATCH v2 0/3] cleanup of gpio_pcf857x.c

2013-08-30 Thread George Cherian
This patch series - removes the irq_demux_work - Uses devm_request_threaded_irq - Call the user handler iff gpio_to_irq is done. v1 --> v2 Split v1 to 3 patches George Cherian (3): gpio: pcf857x: change to devm_request_threaded_irq gpio: pcf857x: remove

[PATCH v2 2/3] gpio: pcf857x: remove the irq_demux_work

2013-08-30 Thread George Cherian
Now that we are using devm_request_threaded_irq no need for irq_demux_work. Remove all its references. Signed-off-by: George Cherian --- drivers/gpio/gpio-pcf857x.c | 35 --- 1 file changed, 35 deletions(-) diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio

[PATCH v2 1/3] gpio: pcf857x: change to devm_request_threaded_irq

2013-08-30 Thread George Cherian
Remove the request_irq and use devm_request_threaded_irq also cleanup free_irq. devm_* takes care of that. Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 2 +- drivers/gpio/gpio-pcf857x.c| 28 2 files changed, 25 insertions(+), 5 deletions

[PATCH v2 3/3] gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done

2013-08-30 Thread George Cherian
Q_NOPROBE set [ 41.009465] IRQ_NOREQUEST set Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 4 ++-- drivers/gpio/gpio-pcf857x.c| 22 +++--- 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-09-01 Thread George Cherian
On 8/30/2013 12:23 PM, Chanwoo Choi wrote: Hi George, On 08/30/2013 03:15 PM, George Cherian wrote: Hi Chanwoo, On 8/30/2013 5:41 AM, Chanwoo Choi wrote: Hi George, On 08/29/2013 10:45 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 5:42 PM, Chanwoo Choi wrote: [big snip ] I tested

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-09-01 Thread George Cherian
On 8/30/2013 12:44 PM, Chanwoo Choi wrote: Hi George, In addition, I add answer about that device driver control gpio pin directly. On 08/30/2013 03:15 PM, George Cherian wrote: Hi Chanwoo, On 8/30/2013 5:41 AM, Chanwoo Choi wrote: Hi George, On 08/29/2013 10:45 PM, George Cherian wrote

Re: [PATCH v2 1/3] gpio: pcf857x: change to devm_request_threaded_irq

2013-09-01 Thread George Cherian
On 9/2/2013 6:50 AM, Kuninori Morimoto wrote: Hi Remove the request_irq and use devm_request_threaded_irq also cleanup free_irq. devm_* takes care of that. Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 2 +- drivers/gpio/gpio-pcf857x.c| 28

[PATCH v3 2/3] gpio: pcf857x: remove the irq_demux_work

2013-09-01 Thread George Cherian
Now that we are using devm_request_threaded_irq no need for irq_demux_work. Remove all its references. Signed-off-by: George Cherian --- drivers/gpio/gpio-pcf857x.c | 35 --- 1 file changed, 35 deletions(-) diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio

[PATCH v3 1/3] gpio: pcf857x: change to devm_request_threaded_irq

2013-09-01 Thread George Cherian
Remove the request_irq and use devm_request_threaded_irq also cleanup free_irq. devm_* takes care of that. Signed-off-by: George Cherian --- drivers/gpio/gpio-pcf857x.c | 28 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-pcf857x.c

[PATCH v3 3/3] gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done

2013-09-01 Thread George Cherian
Q_NOPROBE set [ 41.009465] IRQ_NOREQUEST set Signed-off-by: George Cherian --- drivers/gpio/gpio-pcf857x.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c index 4890e97..578d93f 100644 --- a/dri

[PATCH v3 0/3] cleanup of gpio_pcf857x.c

2013-09-01 Thread George Cherian
This patch series - removes the irq_demux_work - Uses devm_request_threaded_irq - Call the user handler iff gpio_to_irq is done. v1 --> v2 Split v1 to 3 patches v2 --> v3 Remove the unnecessary dts patches. George Cherian (3): gpio: pcf857x: cha

Re: [PATCH v3 0/3] cleanup of gpio_pcf857x.c

2013-09-02 Thread George Cherian
v2 Split v1 to 3 patches v2 --> v3 Remove the unnecessary dts patches. George Cherian (3): gpio: pcf857x: change to devm_request_threaded_irq gpio: pcf857x: remove the irq_demux_work gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done drivers/gpio/gpio-pcf857x.

Re: [RFC v2] gpio/omap: auto-setup a GPIO when used as an IRQ

2013-09-27 Thread George Cherian
PATCH 2/2] gpio/omap: auto-setup a GPIO when used as an IRQ [2] Linus, Could you please add Stephen Acked-by when taking the patches and also George Cherian Tested-by that sent for this RFC. George it would be great if you can also comment on which OMAP platform you had tested. Tested on dra7x

[PATCH] usb: host: xhci-plat: release mem region while removing module

2013-06-21 Thread George Cherian
Do a release_mem_region of the hcd resource. Without this the subsequent insertion of module fails in request_mem_region. Signed-off-by: George Cherian --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci

[PATCH] usb: host: xhci-plat: Enable XHCI_SPURIOUS_SUCCESS quirk for xhci-plat

2013-06-26 Thread George Cherian
Signed-off-by: George Cherian --- drivers/usb/host/xhci-plat.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 93ad67e..e63c6d3 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -25,6 +25

[PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread George Cherian
There can be configurations in which DWC3 is hoooked up only to USB2 PHY. In such cases we should not return -EPROBE_DEFER, rather continue probe even if there is no USB3 PHY. Signed-off-by: George Cherian --- drivers/usb/dwc3/core.c | 31 --- 1 file changed, 24

[PATCH v2 0/3] Adding AM437x support to dwc3-omap glue

2013-06-12 Thread George Cherian
for both OMAP5 and AM437x, by using the x_major in revision register and adjusting the offsets. changes from v1: - Added compatible for AM437X since x_major is same for OMAP5 and AM437x - Added proper wrappers to dwc3_omap_readl/writel George Cherian (3): usb: dwc3: omap

[PATCH v2 3/3] usb: dwc3: omap: Adds dwc3_omap_readl/writel wrappers

2013-06-12 Thread George Cherian
This patch adds wrappers to dwc3_omap_readl/writel calls to accomodate both OMAP5 and AM437x reg maps (It uses the cached register offsets). Also renames OMAP5 IRQ1 as IRQMISC and IRQ1 bits as IRQMISC bits. Signed-off-by: George Cherian --- drivers/usb/dwc3/dwc3-omap.c | 173

[PATCH v2 1/3] usb: dwc3: omap: Adding am437x specific register map changes

2013-06-12 Thread George Cherian
struct dwc3_omap to cache the offsets Signed-off-by: George Cherian --- drivers/usb/dwc3/dwc3-omap.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c index 34638b9..a354b4c 100644 --- a/drivers/usb/dwc3/dwc3-omap.c +++ b/drivers/usb

[PATCH v2 2/3] usb: dwc3: omap: Intialize the register offset values for OMAP5 and AM437x

2013-06-12 Thread George Cherian
compatible. Register offsets are cached in dwc3_omap struct for reg reads and writes. Signed-off-by: George Cherian --- drivers/usb/dwc3/dwc3-omap.c | 57 1 file changed, 57 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c

Re: [PATCH] arm: dts: AM43x: Add usb_otg_hs node

2013-07-07 Thread George Cherian
On 7/7/2013 2:05 PM, Felipe Balbi wrote: Hi, On Fri, Jun 28, 2013 at 12:14:47PM +0530, George Cherian wrote: diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index ddc1df7..e4f5eb8 100644 --- a/arch/arm/boot/dts/am4372.dtsi +++ b/arch/arm/boot/dts/am4372.dtsi @@ -64,5

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread George Cherian
On 6/26/2013 3:46 PM, Felipe Balbi wrote: Hi, On Wed, Jun 26, 2013 at 02:59:14PM +0530, George Cherian wrote: There can be configurations in which DWC3 is hoooked up only to USB2 PHY. In such cases we should not return -EPROBE_DEFER, rather continue probe even if there is no USB3 PHY. Signed

Re: [PATCH] usb: host: xhci-plat: Enable XHCI_SPURIOUS_SUCCESS quirk for xhci-plat

2013-06-26 Thread George Cherian
On 6/26/2013 2:32 PM, Felipe Balbi wrote: Hi, On Wed, Jun 26, 2013 at 02:28:57PM +0530, George Cherian wrote: Synopsis xhci controllers with hci_version > 0.96 gives spurious success events on short packet completion. During webcam capture the "ERROR Transfer event TRB DMA ptr not

[PATCH] arm: dts: AM43x: Add usb_otg_hs node

2013-06-27 Thread George Cherian
Adds device node for HS USB Host module for AM437x Signed-off-by: George Cherian --- This patch is on top of git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git for_3.11/dts arch/arm/boot/dts/am4372.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff

[PATCH v2] usb: host: xhci: Enable XHCI_SPURIOUS_SUCCESS for all controllers with xhci 1.0

2013-06-30 Thread George Cherian
Issue is seen with Intel Pantherpoint xhci controller. So enabling this quirk in xhci_gen_setup if controller verion is greater than 0.96. For xhci-pci move the quirk to much generic place xhci_gen_setup. Signed-off-by: George Cherian --- drivers/usb/host/xhci-pci.c | 1 - drivers/usb/host/x

Re: [PATCH v3] arm: dts: AM43x: Add usb DT nodes for AM4372

2013-08-14 Thread George Cherian
+Benoit If you dont have any comments, can you take this for 3.12? Regards -George On 7/10/2013 1:44 PM, George Cherian wrote: This patch adds - HS USB nodes - phy nodes - usb control module nodes. Signed-off-by: George Cherian --- changes from v2 change synopsis

Re: [PATCH v3] arm: dts: AM43x: Add usb DT nodes for AM4372

2013-08-15 Thread George Cherian
Hi Benoit , Thanks for your review. On 8/14/2013 8:04 PM, Benoit Cousson wrote: + Roger Hi George, Yes, I had some comment about the "ti'type" in Roger's series that will be applicable here as well. On 14/08/2013 16:16, George Cherian wrote: +Benoit If you do

[PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-16 Thread George Cherian
Adding extcon driver for USB ID detection to dynamically configure USB Host/Peripheral mode. Signed-off-by: George Cherian --- .../devicetree/bindings/extcon/extcon-dra7xx.txt | 19 ++ drivers/extcon/Kconfig | 7 + drivers/extcon/Makefile

[PATCH 0/2] Enable USB ID pin detection using extcon for DRA7xx

2013-08-16 Thread George Cherian
ATCH] gpio: Enable pcf857x GPIO expander for Device Tree https://lkml.org/lkml/2013/6/6/333 George Cherian (2): extcon: extcon-dra7xx: Add extcon driver for USB ID detection arm: dts: dra7-evm: Add extcon dt nodes for USB ID detection .../devicetree/bindings/extcon/extcon-dra7xx.t

[PATCH 2/2] arm: dts: dra7-evm: Add extcon dt nodes for USB ID detection

2013-08-16 Thread George Cherian
Adding extcon dt nodes for USB ID detection. ID pin is routed via the gpio expander , so adding pcf8575 nodes. Changing otg mode to peripheral mode for usb1 Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 42 +- 1 file changed, 41

Re: [PATCH v3] arm: dts: AM43x: Add usb DT nodes for AM4372

2013-08-16 Thread George Cherian
On 8/16/2013 2:38 PM, Benoit Cousson wrote: That's fine, but that was not my question. Is there any already bindings that defined phys and phy-names in the kernel? No I couldn't find them in 3.11-rc5. I will drop the phy reference and send an updated patch adding dwc nodes. And anyway the

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-19 Thread George Cherian
Hi Stephen, Thanks for your review. On 8/20/2013 1:01 AM, Stephen Warren wrote: On 08/16/2013 04:13 AM, George Cherian wrote: Adding extcon driver for USB ID detection to dynamically configure USB Host/Peripheral mode. diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt

Re: [PATCH v2 1/4] usb: phy: phy-omap-control: Add API to power and wakeup

2013-07-29 Thread George Cherian
On 7/29/2013 7:55 PM, Sebastian Andrzej Siewior wrote: * George Cherian | 2013-07-19 18:04:34 [+0530]: diff --git a/drivers/usb/phy/phy-omap-control.c b/drivers/usb/phy/phy-omap-control.c index 1419ced..4f2502c 100644 --- a/drivers/usb/phy/phy-omap-control.c +++ b/drivers/usb/phy/phy-omap

Re: [PATCH v2 2/4] phy: phy-amxxxx-usb: Add PHY driver for amxxxx platform

2013-07-29 Thread George Cherian
On 7/29/2013 8:47 PM, Sebastian Andrzej Siewior wrote: * George Cherian | 2013-07-19 18:04:35 [+0530]: Adds phy driver support for am33xx platform, the host/device peripheral controller shall get this phy object to control the phy operations. If you rebase this on-top of the two instances

Re: [PATCH v2 2/4] phy: phy-amxxxx-usb: Add PHY driver for amxxxx platform

2013-07-30 Thread George Cherian
On 7/30/2013 2:23 PM, Sebastian Andrzej Siewior wrote: On 07/30/2013 07:19 AM, George Cherian wrote: So from what I see now, it is most likely the easiest thing to just add that wakeup to the phy driver I posted. Do you agree? The whole idea of writing a seperate phy driver was to use the

Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes

2013-07-31 Thread George Cherian
On 7/31/2013 1:46 AM, Sebastian Andrzej Siewior wrote: This moves the two instances from the big node into two child nodes. The glue layer ontop does almost nothing. There is one devices containing the control module for USB (2) phy, (2) usb and later the dma engine. The usb device is the "glue d

Re: [PATCH 3/5] usb: phy: Add AM335x PHY driver

2013-07-31 Thread George Cherian
On 7/31/2013 1:46 AM, Sebastian Andrzej Siewior wrote: This driver is a redo of my earlier attempt. It uses parts of the generic PHY driver and uses the new control driver for the register the phy needs to power on/off the phy. It also enables easy access for the wakeup register which is not yet

Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes

2013-08-02 Thread George Cherian
On 8/2/2013 3:59 PM, Sebastian Andrzej Siewior wrote: On 08/01/2013 01:30 PM, Sebastian Andrzej Siewior wrote: On 08/01/2013 12:52 PM, Sebastian Andrzej Siewior wrote: On 08/01/2013 07:24 AM, George Cherian wrote: b/arch/arm/boot/dts/am33xx.dtsi index 38b446b..0f756ca 100644 --- a/arch/arm

Re: [PATCH 2/4] ARM: dts: dra7: Add USB related nodes

2013-08-02 Thread George Cherian
On 8/1/2013 8:28 PM, Roger Quadros wrote: Add nodes for the Super Speed USB controllers, omap-control-usb, USB2 PHY and USB3 PHY devices. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/dra7.dtsi | 136 +++ 1 files changed, 136 insertions(+), 0 del

Re: [PATCH 3/4] dts: dra7-evm: add USB support

2013-08-02 Thread George Cherian
On 8/1/2013 8:28 PM, Roger Quadros wrote: Add USB drv_vbus pinctrl information and USB mode for the USB controller. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/dra7-evm.dts | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts

Re: [PATCH 3/4] dts: dra7-evm: add USB support

2013-08-05 Thread George Cherian
On 8/5/2013 1:25 PM, Roger Quadros wrote: On 08/02/2013 06:04 PM, George Cherian wrote: On 8/1/2013 8:28 PM, Roger Quadros wrote: Add USB drv_vbus pinctrl information and USB mode for the USB controller. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/dra7-evm.dts | 22

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread George Cherian
Hi Chanwoo, Thanks for your review. On 8/20/2013 5:54 AM, Chanwoo Choi wrote: Hi George, On 08/16/2013 07:13 PM, George Cherian wrote: Adding extcon driver for USB ID detection to dynamically configure USB Host/Peripheral mode. Signed-off-by: George Cherian --- .../devicetree/bindings

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread George Cherian
On 8/20/2013 3:59 PM, Chanwoo Choi wrote: Hi George, diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt new file mode 100644 index 000..37e4c22 --- /dev/null +++ b/Documentation/devicetree/bindings/extcon/ext

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-21 Thread George Cherian
Hi Stephen, On 8/20/2013 10:23 PM, Stephen Warren wrote: >ID pins are connected to pcf8575, and the pcf8575's interrupt line is >inturn connected to >gpio bank6 pin 11, we use this gpio interrupt to detect the ID pin change. In that case, the PCF8575 node needs to be a GPIO controller and an IR

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-21 Thread George Cherian
On 8/21/2013 11:05 PM, Stephen Warren wrote: On 08/21/2013 07:06 AM, George Cherian wrote: Hi Stephen, On 8/20/2013 10:23 PM, Stephen Warren wrote: ID pins are connected to pcf8575, and the pcf8575's interrupt line is inturn connected to gpio bank6 pin 11, we use this gpio interrupt to d

[PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread George Cherian
Add phy nodes for AM33XX platform and split the musb nodes per instance. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: George Cherian --- arch/arm/boot/dts/am33xx.dtsi | 68 +-- 1 file changed, 53 insertions(+), 15 deletions(-) diff --git a

[PATCH v2 4/4] usb: musb: dsps: Remove the phy control from glue and add phy driver APIs

2013-07-19 Thread George Cherian
Remove usb phy control module access from platform glue. The same is now done using am phy driver and phy-omap-control. Adapt the driver to the split dt nodes. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: George Cherian --- drivers/usb/musb/musb_dsps.c | 150

[PATCH v2 2/4] phy: phy-amxxxx-usb: Add PHY driver for amxxxx platform

2013-07-19 Thread George Cherian
Adds phy driver support for am33xx platform, the host/device peripheral controller shall get this phy object to control the phy operations. Signed-off-by: George Cherian --- drivers/phy/Kconfig | 12 +++ drivers/phy/Makefile | 1 + drivers/phy/phy-am-usb.c | 222

[PATCH v2 0/4] Add phy support for AM335X platform using Generic PHy framework

2013-07-19 Thread George Cherian
x-kernel/georgec-connectivity-linux-feature-tree.git am335x-phy-driver-v2 George Cherian (4): usb: phy: phy-omap-control: Add API to power and wakeup phy: phy-am-usb: Add PHY driver for am platform arm: dts: Add USB phy nodes for AM33XX usb: musb: dsps: Remove the phy control f

[PATCH v2 1/4] usb: phy: phy-omap-control: Add API to power and wakeup

2013-07-19 Thread George Cherian
on/off USB PHY for AM335X Add APIs to -power on/off USB PHY for AM335X -enable/disable PHY wakeup. This API will be called from phy-am-usb driver. Signed-off-by: George Cherian --- drivers/usb/phy/phy-omap-control.c | 67 include

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread George Cherian
On 7/20/2013 12:03 AM, Sergei Shtylyov wrote: Hello. On 07/19/2013 06:20 PM, Sebastian Andrzej Siewior wrote: diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 8e1248f..e3890c4 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -326

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread George Cherian
On 7/20/2013 12:12 AM, Sebastian Andrzej Siewior wrote: On 07/19/2013 08:33 PM, Sergei Shtylyov wrote: Hello. Hello, usb: usb@4740 { compatible = "ti,am33xx-usb"; usb0_phy: phy@47401300 { compatible = "ti,am335x-usb-phy"; } usb0: usb@47401000 {

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-21 Thread George Cherian
On 7/20/2013 9:11 AM, George Cherian wrote: On 7/20/2013 12:12 AM, Sebastian Andrzej Siewior wrote: On 07/19/2013 08:33 PM, Sergei Shtylyov wrote: Hello. Hello, usb: usb@4740 { compatible = "ti,am33xx-usb"; usb0_phy: phy@47401300 { compatible = "ti

Re: [PATCH v2] usb: host: xhci: Enable XHCI_SPURIOUS_SUCCESS for all controllers with xhci 1.0

2013-07-22 Thread George Cherian
ks George, this looks fine. I will munge the description a bit when I commit it, and mark it for stable as well. Unfortunately, due to the timing of the merge window, this patch will have to wait for 2-3 weeks until 3.11-rc1 is out. Sarah Sharp On Mon, Jul 01, 2013 at 10:59:12AM +0530, George Ch

Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-22 Thread George Cherian
Hi Sebastian, On 7/22/2013 11:39 PM, Sebastian Andrzej Siewior wrote: This patch renames the type struct from ti81xx_driver_data to am33xx_driver_data since it is not used for ti81xx anymore. The EOI member is also removed since the am33xx SoC does not have such register. The interrupt is ac

Re: [PATCH 05/16] usb: musb: dsps: use proper child nodes

2013-07-22 Thread George Cherian
On 7/22/2013 11:39 PM, Sebastian Andrzej Siewior wrote: This moves the two instances from the big node into two child nodes. The glue layer ontop does almost nothing. There is one devices containing the (2) phy, (2) usb and later the dma engine. The usb device is the "glue device" which contains

Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-23 Thread George Cherian
On 7/23/2013 2:39 PM, Sebastian Andrzej Siewior wrote: On 07/23/2013 08:04 AM, George Cherian wrote: Hi Sebastian, On 7/22/2013 11:39 PM, Sebastian Andrzej Siewior wrote: This patch renames the type struct from ti81xx_driver_data to am33xx_driver_data since it is not used for ti81xx

  1   2   3   4   5   6   >