From: amd
The extent of pages specified when applying a reserved region should
include up to the last page of the range, but not the page following
the range.
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
as
v3")
Signed-off-by: Colin Ian King
Acked-by: Gary R Hook
---
drivers/crypto/ccp/ccp-dev-v5.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp/ccp-dev-v5.c
index 65604fc65e8f..44a4d2779b15 100644
--- a/drivers/c
linux-cry...@vger.kernel.org
Cc: k...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Improvements-by: Borislav Petkov
Signed-off-by: Brijesh Singh
Reviewed-by: Borislav Petkov
Acked-by: Gary R Hook
---
include/uapi/linux/psp-sev.h | 113 +++
1 file ch
Radim Krčmář"
Cc: Borislav Petkov
Cc: Herbert Xu
Cc: Gary Hook
Cc: Tom Lendacky
Cc: linux-cry...@vger.kernel.org
Cc: k...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Improvements-by: Borislav Petkov
Signed-off-by: Brijesh Singh
Reviewed-by: Borislav Petkov
Acked-by: G
rčmář"
Cc: Borislav Petkov
Cc: Herbert Xu
Cc: Gary Hook
Cc: Tom Lendacky
Cc: linux-cry...@vger.kernel.org
Cc: k...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Improvements-by: Borislav Petkov
Signed-off-by: Brijesh Singh
Reviewed-by: Borislav Petkov
Acked-by: Gary R Hook
---
dri
y Hook
Cc: Tom Lendacky
Cc: linux-cry...@vger.kernel.org
Cc: k...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Improvements-by: Borislav Petkov
Signed-off-by: Brijesh Singh
Acked-by: Gary R Hook
---
drivers/crypto/ccp/psp-dev.c | 24
1 file changed, 24
ndacky
Cc: linux-cry...@vger.kernel.org
Cc: k...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Brijesh Singh
Acked-by: Gary R Hook
---
drivers/crypto/ccp/psp-dev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-d
y Hook
Cc: Tom Lendacky
Cc: linux-cry...@vger.kernel.org
Cc: k...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Improvements-by: Borislav Petkov
Signed-off-by: Brijesh Singh
Acked-by: Gary R Hook
---
drivers/crypto/ccp/psp-dev.c | 28 +++-
1 file changed, 27
ndacky
Cc: linux-cry...@vger.kernel.org
Cc: k...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Brijesh Singh
Acked-by: Gary R Hook
---
Changes since v6:
* when sev_do_cmd() and sev_platform_shutdown() fails then propogate
the error status code from sev_do_cmd() beca
Cc: linux-cry...@vger.kernel.org
Cc: k...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Brijesh Singh
Acked-by: Gary R Hook
---
Changes since v6:
* when sev_do_cmd() and sev_platform_shutdown() fails then propogate
the error status code from sev_do_cmd() because it c
Cc: linux-cry...@vger.kernel.org
Cc: k...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Brijesh Singh
---
Acked-by: Gary R Hook
Changes since v6:
* when sev_do_cmd() and sev_platform_shutdown() fails then propogate
the error status code from sev_do_cmd() because i
Cc: linux-cry...@vger.kernel.org
Cc: k...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Brijesh Singh
Acked-by: Gary R Hook
---
Changes since v6:
* when sev_do_cmd() and sev_platform_shutdown() fails then propogate
the error status code from sev_do_cmd() because it c
On 10/26/2017 03:32 AM, Alex Williamson wrote:
On Tue, 17 Oct 2017 16:22:01 -0500
Gary R Hook wrote:
From: amd
The extent of pages specified when applying a reserved region should
include up to the last page of the range, but not the page following
the range.
Signed-off-by: Gary R Hook
On 01/09/2018 09:48 PM, Sohil Mehta wrote:
From: Gayatri Kammela
IOMMU internals states such as root and context can be exported to the
userspace.
Example of such dump in Kabylake:
root@OTC-KBLH-01:~# cat
/sys/kernel/debug/intel_iommu/dmar_translation_struct
IOMMU dmar0: Extended Root Table
Remove printk and use a more preferable error logging function.
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu.c | 56 +++--
1 file changed, 29 insertions(+), 27 deletions(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
On 01/04/2018 06:25 AM, Sinan Kaya wrote:
On 12/19/2017 12:37 AM, Sinan Kaya wrote:
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
where a PCI device is present. This restricts the device drivers to be
reused for other domain numbers.
Getting ready to remove pci_get_bus_
On 01/04/2018 10:32 AM, Sinan Kaya wrote:
On 1/4/2018 11:28 AM, Gary R Hook wrote:
On 01/04/2018 06:25 AM, Sinan Kaya wrote:
On 12/19/2017 12:37 AM, Sinan Kaya wrote:
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
where a PCI device is present. This restricts the
three patch series that will expose a number
of IOMMU registers.
---
Gary R Hook (5):
iommu/amd - Add debugfs support
iommu/amd - Add a 'verbose' switch for IOMMU debugfs
iommu/amd - Add a README variable for the IOMMU debugfs
iommu/amd - Expose the active IOMMU de
Create the basic debugfs functions. Expose a count of IOMMU device
table entries that appear to be in use.
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig |9 +++
drivers/iommu/Makefile|2 -
drivers/iommu/amd_iommu_debugfs.c | 112
at boot.
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu_debugfs.c | 127 -
1 file changed, 109 insertions(+), 18 deletions(-)
diff --git a/drivers/iommu/amd_iommu_debugfs.c
b/drivers/iommu/amd_iommu_debugfs.c
index 87840ae9889d..efb666873daa 100644
Enable more descriptive debugfs output via a 'verbose' variable.
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu_debugfs.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu_debugfs.c
b/drivers/iommu/amd_iommu_debug
Provide help text via a filesystem entry
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu_debugfs.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/iommu/amd_iommu_debugfs.c
b/drivers/iommu/amd_iommu_debugfs.c
index c449f3a7452c
e DTE bit field definitions for debugfs printing
in verbose mode
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu_debugfs.c | 182 +
1 file changed, 182 insertions(+)
diff --git a/drivers/iommu/amd_iommu_debugfs.c
b/drivers/iommu/amd_iommu_debugfs.c
ind
On 01/26/2018 06:00 PM, Borislav Petkov wrote:
On Fri, Jan 26, 2018 at 05:52:15PM -0600, Gary R Hook wrote:
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -135,6 +135,15 @@ config AMD_IOMMU_V2
hardware. Select this option if you want to use devices that support
Acked-by: Gary R Hook
---
drivers/crypto/ccp/psp-dev.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
index fcfa5b1eae61..8255258cd040 100644
--- a/drivers/crypto/ccp/psp-dev.c
+++ b/drivers/crypto/ccp
Add another example of required braces when using a compound statement in
a loop.
Signed-off-by: Gary R Hook
---
Changes since v2:
- Modified the example code fragment
Changes since v1:
- Move the new example up, and make it more generic
Documentation/process/coding-style.rst |9
On 03/22/2018 04:12 AM, Jani Nikula wrote:
On Wed, 21 Mar 2018, Jonathan Corbet wrote:
To head that off, I think I'll apply your first version instead, sorry
Jani.
No worries.
Submitting a v3 because the example could better illuminate the options
by using loop construct inside of an if,
On 03/26/2018 11:32 AM, Jonathan Corbet wrote:
On Mon, 26 Mar 2018 11:28:03 -0500
Gary R Hook wrote:
Submitting a v3 because the example could better illuminate the options
by using loop construct inside of an if, addressing Jani's point but
without opening the door to later criticis
On 03/15/2018 08:58 AM, Joerg Roedel wrote:
On Wed, Mar 14, 2018 at 06:04:44PM -0500, Gary R Hook wrote:
Gary R Hook (5):
iommu/amd - Add debugfs support
iommu/amd - Add a 'verbose' switch for IOMMU debugfs
iommu/amd - Add a README variable for the IOM
("vendor", d_top);
}
Since the IOMMU driver can not be removed from the running system, this
patch only provides an "on" function.
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig | 11
drivers/iommu/Makefile|1 +
drivers/iommu/io
- Coding style fixes
- Add a comment to document the framework
---
Gary R Hook (2):
iommu - Enable debugfs exposure of the IOMMU
iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
drivers/iommu/Kconfig | 11 +++
drivers/iommu/Makefile|2 +
drivers
Implement a skeleton framework for debugfs support in the
AMD IOMMU.
Signed-off-by: Gary R Hook
---
drivers/iommu/Makefile|1 +
drivers/iommu/amd_iommu_debugfs.c | 45 +
drivers/iommu/amd_iommu_init.c|6 +++--
drivers/iommu
Remove printk and use a more preferable error logging function.
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu.c | 55 +++--
1 file changed, 28 insertions(+), 27 deletions(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
three patch series that will expose a number
of IOMMU registers.
Changes since v1:
- Correctly use CONFIG_AMD_IOMMU_DEBUG in Makefile and header file
---
Gary R Hook (5):
iommu/amd - Add debugfs support
iommu/amd - Add a 'verbose' switch for IOMMU debugfs
iommu/amd - Ad
Expose the IOMMU MMIO registers and device table
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig |8 +++
drivers/iommu/Makefile|1
drivers/iommu/amd_iommu_debugfs.c | 112 +
drivers/iommu/amd_iommu_init.c|7
Add a debugfs entry to dump the active device table entries from
the IOMMU's table. Active is determined by non-default values
in the first and second long words of the DTE. Aside from IOMMU
devices, this output should list every device reported by lspci.
Signed-off-by: Gary R Hook
---
dr
Enable more descriptive debugfs output via a 'verbose' variable.
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu_debugfs.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu_debugfs.c
b/drivers/iommu/amd_iommu_debug
Provide help text via a filesystem entry
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu_debugfs.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/iommu/amd_iommu_debugfs.c
b/drivers/iommu/amd_iommu_debugfs.c
index 481f4d86f8f8
at boot.
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu_debugfs.c | 109 ++---
1 file changed, 100 insertions(+), 9 deletions(-)
diff --git a/drivers/iommu/amd_iommu_debugfs.c
b/drivers/iommu/amd_iommu_debugfs.c
index c4e071f7a5b9..aa6935340163 100644
On 03/13/2018 12:16 PM, Andy Shevchenko wrote:
On Fri, Mar 9, 2018 at 2:50 AM, Gary R Hook wrote:
+ default n
Redundant
Roger that.
+#include
+#include
+#include
Keep in order?
What order would that be? These few needed files are listed in the same
order as which they
On 03/13/2018 12:20 PM, Andy Shevchenko wrote:
+ oboff += OSCNPRINTF("%02x:%02x:%x (%u / %04x)\n",
+ PCI_BUS_NUM(amd_iommu_devid),
+ PCI_SLOT(amd_iommu_devid),
+ PCI_FUNC(amd_iomm
On 03/13/2018 03:56 PM, Andy Shevchenko wrote:
On Tue, Mar 13, 2018 at 8:54 PM, Gary R Hook wrote:
On 03/13/2018 12:20 PM, Andy Shevchenko wrote:
+ } else if (obuf[0] == '0' && obuf[1] == 'x') {
+ n = sscanf(obuf, "%x&qu
On 03/13/2018 03:23 PM, Andy Shevchenko wrote:
On Tue, Mar 13, 2018 at 8:54 PM, Gary R Hook wrote:
On 03/13/2018 12:16 PM, Andy Shevchenko wrote:
On Fri, Mar 9, 2018 at 2:50 AM, Gary R Hook wrote:
+#include
+#include
+#include
Keep in order?
What order would that be? These few
On 05/18/2018 04:02 PM, Gary R Hook wrote:
On 05/18/2018 11:49 AM, Randy Dunlap wrote:
I think the Kconfig option would have been the correct choice.
"Preferred", perhaps. Neither is incorrect. And really, the
Makefile/Kconfig choice is somewhat separate from the organization i
cruft produced by design change
- Change the lock to a mutex
- Coding style fixes
- Add a comment to document the framework
---
Gary R Hook (2):
iommu - Enable debugfs exposure of IOMMU driver internals
iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
drivers/iommu
Implement a skeleton framework for debugfs support in the
AMD IOMMU.
Signed-off-by: Gary R Hook
---
drivers/iommu/Makefile|5 +
drivers/iommu/amd_iommu_debugfs.c | 39 +
drivers/iommu/amd_iommu_init.c|6 --
drivers/iommu
from the running system, there
is no need for an "off" function.
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig | 11 ++
drivers/iommu/Makefile|1 +
drivers/iommu/iommu-debugfs.c | 70 +
drivers/iommu/iommu.c
On 05/11/2018 10:22 AM, Robin Murphy wrote:
Hi Gary,
Just a few trivial nitpicks below, otherwise:
Reviewed-by: Robin Murphy
On 11/05/18 15:34, Gary R Hook wrote:
Provide base enablement for using debugfs to expose internal data of an
IOMMU driver. When called, create the /sys/kernel/debug
Implement a skeleton framework for debugfs support in the
AMD IOMMU.
Signed-off-by: Gary R Hook
---
drivers/iommu/Makefile|5 +
drivers/iommu/amd_iommu_debugfs.c | 39 +
drivers/iommu/amd_iommu_init.c|6 --
drivers/iommu
Changes since v2:
- Move a declaration to outside an ifdef
- Remove a spurious blank line
Changes since v1:
- Remove debug cruft
- Remove cruft produced by design change
- Change the lock to a mutex
- Coding style fixes
- Add a comment to document the framework
---
Gary R Hook (2
from the running system, there
is no need for an "off" function.
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig | 10 ++
drivers/iommu/Makefile|1 +
drivers/iommu/iommu-debugfs.c | 72 +
drivers/iommu/iommu.c
On 05/14/2018 12:50 PM, Randy Dunlap wrote:
On 05/14/2018 10:20 AM, Gary R Hook wrote:
Implement a skeleton framework for debugfs support in the
AMD IOMMU.
Signed-off-by: Gary R Hook
---
drivers/iommu/Makefile|5 +
drivers/iommu/amd_iommu_debugfs.c | 39
Implement a skeleton framework for debugfs support in the AMD
IOMMU. Add an AMD-specific Kconfig boolean that depends upon
general enablement of DebugFS in the IOMMU.
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig | 12
drivers/iommu/Makefile|1
On 05/15/2018 08:46 AM, Joerg Roedel wrote:
On Mon, May 14, 2018 at 03:00:50PM -0500, Gary R Hook wrote:
This was brought up a few weeks ago in, I believe, version 3 of this patch.
That question was discussed (because that's what I did the first time out),
and _someone_ _else_ asked about
On 05/18/2018 11:49 AM, Randy Dunlap wrote:
On 05/18/2018 08:20 AM, Gary R Hook wrote:
On 05/15/2018 08:46 AM, Joerg Roedel wrote:
On Mon, May 14, 2018 at 03:00:50PM -0500, Gary R Hook wrote:
This was brought up a few weeks ago in, I believe, version 3 of this patch.
That question was
often, to inform the IOMMU
that space is available in the log.
Finally, since a single pass may leave logged events unread, use
an outer loop to repeat until head has caught up to tail.
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu.c |
in this huge buffer being passed by rsa-pkcs1pad to CCP even
for smaller key sizes and then in a buffer overflow when ccp_run_rsa_cmd()
tried to copy this large input buffer into a RSA key length-sized hardware
input buffer.
Signed-off-by: Maciej S. Szmigiero
Acked-by: Gary R Hook
Fixes
On 02/24/2018 10:03 AM, Maciej S. Szmigiero wrote:
CCP RSA implementation uses a hardware input buffer which size depends only
on the current RSA key length. Key modulus and a message to be processed
is then copied to this buffer based on their own lengths.
Since the price for providing too long
Kconfig parameter IOMMU_DEBUG to globally allow or
disallow debugfs code to be built.
Changes since v1:
- Remove debug cruft
- Remove cruft produced by design change
- Change the lock to a mutex
- Coding style fixes
- Add a comment to document the framework
---
Gary R Hook (2):
iommu
("vendor", d_top);
}
Since the IOMMU driver can not be removed from the running system, this
patch only provides an "on" function.
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig | 11
drivers/iommu/Makefile|1 +
drivers/iommu/io
Implement a skeleton framework for debugfs support in the
AMD IOMMU.
Signed-off-by: Gary R Hook
---
drivers/iommu/Makefile|1 +
drivers/iommu/amd_iommu_debugfs.c | 45 +
drivers/iommu/amd_iommu_init.c|7 --
drivers/iommu
On 03/29/2018 03:48 AM, Joerg Roedel wrote:
[ Adding Gary from AMD to Cc ]
On Mon, Mar 19, 2018 at 09:37:14AM -0700, Jacob Pan wrote:
On Thu, 15 Mar 2018 14:18:54 +0100
Joerg Roedel wrote:
On Thu, Feb 15, 2018 at 08:38:11AM -0800, Jacob Pan wrote:
Just wondering if your concern is on the im
On 04/17/2018 12:38 PM, Hook, Gary wrote:
On 4/13/2018 8:08 PM, Mehta, Sohil wrote:
On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
+
+
+ mutex_lock(&amd_iommu_debugfs_lock);
+ if (!amd_iommu_debugfs) {
+ d_top = iommu_debugfs_setup();
+ if (d
:
- Move a declaration to outside an ifdef
- Remove a spurious blank line
Changes since v1:
- Remove debug cruft
- Remove cruft produced by design change
- Change the lock to a mutex
- Coding style fixes
- Add a comment to document the framework
---
Gary R Hook (2):
iommu - Enable
("vendor", d_top);
}
Since the IOMMU driver can not be removed from the running system, this
patch only provides an "on" function.
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig | 11
drivers/iommu/Makefile|1 +
drivers/iommu/io
Implement a skeleton framework for debugfs support in the
AMD IOMMU.
Signed-off-by: Gary R Hook
---
drivers/iommu/Makefile|5
drivers/iommu/amd_iommu_debugfs.c | 42 +
drivers/iommu/amd_iommu_init.c|6 -
drivers/iommu
A new events have been defined in the AMD IOMMU spec:
0x09 - "invalid PPR request"
Add support for logging this type of event.
Signed-off-by: Gary R Hook
~
~
~
---
drivers/iommu/amd_iommu.c | 10 +-
drivers/iommu/amd_iommu_types.h |1 +
2 files changed, 10 insert
Update the AMD IOMMU log messages to be more precise, and
add a log message for a new event type.
---
Gary R Hook (2):
iommu/amd - Update the PASID information printed to the system log
iommu/amd - Update logging information for new event type
drivers/iommu/amd_iommu.c
Provide detailed data for each event, as appropriate.
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 8c469b51185f
On 05/24/2018 04:18 AM, Greg KH wrote:
On Mon, May 14, 2018 at 12:20:20PM -0500, Gary R Hook wrote:
Provide base enablement for using debugfs to expose internal data of an
IOMMU driver. When called, create the /sys/kernel/debug/iommu directory.
Emit a strong warning at boot time to indicate
On 4/4/19 3:42 PM, Thomas Gleixner wrote:
> On Thu, 4 Apr 2019, Hook, Gary wrote:
>
>> Enablement of AMD's Secure Memory Encryption feature is determined
>> very early in the boot cycle. Part of this procedure involves scanning
>> the command line for the paramater 'mem_encrypt'.
>>
>> To determin
On 4/8/19 11:58 AM, Borislav Petkov wrote:
> On Mon, Apr 08, 2019 at 04:46:31PM +0000, Gary R Hook wrote:
>> My reasoning (not arguing): the file has been touched exactly one time
>> in 4 years, by Thomas. Doesn't appear to be a candidate for constant
>> modification, so
On 05/01/2016 06:52 AM, Julia Lawall wrote:
The ccp_actions structure is never modified, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
Acked-by: Gary Hook
---
drivers/crypto/ccp/ccp-dev-v3.c |2 +-
drivers/crypto/ccp/ccp-dev.h|2 +-
this and move to a static inline function for appropriate type
>> checking.
>>
>> Fixes: edd303ff0e9e ("crypto: ccp - Add DOWNLOAD_FIRMWARE SEV command")
>> Reported-by: Cfir Cohen
>> Signed-off-by: David Rientjes
>
> Acked-by: Tom Lendacky
Acked-by: Ga
en
of a mind to kick out and not try to do any further work. But debugfs is
to be treated as an exception to that paradigm? Carry on, ignore errors,
don't worry about it?
That said,
Acked-by: Gary R Hook
>
> Cc: Tom Lendacky
> Cc: Gary Hook
> Cc: Herbert Xu
> Cc: &quo
On 4/8/19 2:08 PM, Borislav Petkov wrote:On 5/8/19 2:08 PM, Borislav
Petkov wrote:> On Mon, Apr 08, 2019 at 06:41:30PM +0000, Gary R Hook
wrote:
>> Again, not arguing. I completely understand. However, to be fair,
this
>> isn't about SME having trouble with those facil
On 4/26/19 11:24 AM, Borislav Petkov wrote:
> On Fri, Apr 26, 2019 at 03:11:17PM +0000, Gary R Hook wrote:
>> 2) Turn off instrumentation for lib/cmdline.c. The risk is that any
>> changes to its code would not enjoy the benefits of KASAN/etc testing
>> (if enabled
On 4/29/19 3:51 PM, Borislav Petkov wrote:
> [CAUTION: External Email]
>
> On Mon, Apr 29, 2019 at 08:16:07PM +0000, Gary R Hook wrote:
>> Yes, option 4 would be a combination of using a local copy of strncmp()
>
> Why the local copy?
Seemed suitable, since it's tiny.
nd the patch description.
>
> Fix this by exporting iommu_debugfs_dir, and removing the reference to
> and implementation of iommu_debugfs_new_driver_dir().
>
> Fixes: bad614b24293ae46 ("iommu: Enable debugfs exposure of IOMMU driver
> internals")
> Signed-off-by:
On 09/24/2018 04:44 PM, Nick Desaulniers wrote:
> On Mon, Sep 24, 2018 at 2:27 PM Gary R Hook wrote:
>>
>> On 09/24/2018 03:24 PM, Nick Desaulniers wrote:
>>> On Mon, Sep 24, 2018 at 12:18 PM Gary R Hook wrote:
>>>>
>>>> On 09/24/2018 12:26
Kconfig parameter IOMMU_DEBUG to globally allow or
disallow debugfs code to be built.
---
Gary R Hook (2):
iommu - Enable debugfs exposure of the IOMMU
iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
drivers/iommu/Kconfig |9 +++
drivers/iommu/Makefile
Provide base enablement for using debugfs to expose internal data of
an IOMMU driver. When enabled, create the /sys/kernel/debug/iommu
directory. Emit a strong warning at boot time to indicate that this
feature is enabled.
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig | 11
Implement a skeleton framework for debugfs support in the
AMD IOMMU.
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig |6 ++---
drivers/iommu/Makefile|2 +-
drivers/iommu/amd_iommu_debugfs.c | 47 +
drivers/iommu
On 03/29/2018 10:57 PM, Tom Lendacky wrote:
On 3/29/2018 5:54 PM, Gary R Hook wrote:
Provide base enablement for using debugfs to expose internal data of
an IOMMU driver. When enabled, create the /sys/kernel/debug/iommu
So this can't actually create anything yet since nothing invoke
On 03/29/2018 11:16 PM, Tom Lendacky wrote:
On 3/29/2018 5:54 PM, Gary R Hook wrote:
Implement a skeleton framework for debugfs support in the
AMD IOMMU.
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig |6 ++---
drivers/iommu/Makefile|2 +-
drivers
On 03/02/2018 05:58 PM, Maciej S. Szmigiero wrote:
On 03.03.2018 00:49, Hook, Gary wrote:
On 3/2/2018 5:15 PM, Maciej S. Szmigiero wrote:
Thanks.
However, what about the first patch from this series?
Without it, while it no longer should cause a buffer overflow, in-kernel
X.509 certificate ve
On 05/03/2018 08:57 AM, Joerg Roedel wrote:
On Tue, May 01, 2018 at 02:52:52PM -0500, Gary R Hook wrote:
@@ -567,7 +567,7 @@ static void iommu_print_event(struct amd_iommu *iommu, void
*__evt)
}
if (type == EVENT_TYPE_IO_FAULT) {
- amd_iommu_report_page_fault(devid
Add another example of required braces when using a compound statement in
a loop.
Signed-off-by: Gary R Hook
---
Documentation/process/coding-style.rst |9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation/process/coding-style.rst
b/Documentation/process/coding
On 03/14/2018 10:29 AM, Andy Shevchenko wrote:
On Wed, Mar 14, 2018 at 5:24 PM, Gary R Hook wrote:
On 03/13/2018 03:23 PM, Andy Shevchenko wrote:
+#include
+#include
+#include
Keep in order?
What order would that be? These few needed files are listed in the same
order as which they
Enable more descriptive debugfs output via a 'verbose' variable.
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu_debugfs.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu_debugfs.c
b/drivers/iommu/amd_iommu_debug
Expose the IOMMU MMIO registers and device table
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig |7 ++
drivers/iommu/Makefile|1
drivers/iommu/amd_iommu_debugfs.c | 122 +
drivers/iommu/amd_iommu_init.c|6
since v1:
- Correctly use CONFIG_AMD_IOMMU_DEBUG in Makefile and header file
---
Gary R Hook (5):
iommu/amd - Add debugfs support
iommu/amd - Add a 'verbose' switch for IOMMU debugfs
iommu/amd - Add a README variable for the IOMMU debugfs
iommu/amd - Expose the ac
Provide help text via a filesystem entry
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu_debugfs.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/iommu/amd_iommu_debugfs.c
b/drivers/iommu/amd_iommu_debugfs.c
index 170863e5e86b
at boot.
Signed-off-by: Gary R Hook
---
drivers/iommu/amd_iommu_debugfs.c | 121 -
1 file changed, 106 insertions(+), 15 deletions(-)
diff --git a/drivers/iommu/amd_iommu_debugfs.c
b/drivers/iommu/amd_iommu_debugfs.c
index 1d941c5329be..47bf718f6178 100644
Add a debugfs entry to dump the active device table entries from
the IOMMU's table. Active is determined by non-default values
in the first and second long words of the DTE. Aside from IOMMU
devices, this output should list every device reported by lspci.
Signed-off-by: Gary R Hook
---
dr
On 03/15/2018 05:26 AM, Jani Nikula wrote:
On Wed, 14 Mar 2018, Gary R Hook wrote:
Add another example of required braces when using a compound statement in
a loop.
Signed-off-by: Gary R Hook
---
Documentation/process/coding-style.rst |9 +
1 file changed, 9 insertions
Add another example of required braces when using a compound statements.
Signed-off-by: Gary R Hook
---
Changes since v1:
- Move the new example up, and make it more generic
Documentation/process/coding-style.rst |9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation
document the framework
---
Gary R Hook (2):
iommu - Enable debugfs exposure of IOMMU driver internals
iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
drivers/iommu/Kconfig | 11 ++
drivers/iommu/Makefile|6 +++
drivers/iommu/amd_iommu_debugfs.c
from the running system, there
is no need for an "off" function.
Signed-off-by: Gary R Hook
---
drivers/iommu/Kconfig | 11 +++
drivers/iommu/Makefile|1 +
drivers/iommu/iommu-debugfs.c | 64 +
drivers/iommu/iommu.c
Implement a skeleton framework for debugfs support in the
AMD IOMMU.
Signed-off-by: Gary R Hook
---
drivers/iommu/Makefile|5 +
drivers/iommu/amd_iommu_debugfs.c | 41 +
drivers/iommu/amd_iommu_init.c|6 -
drivers/iommu
1 - 100 of 133 matches
Mail list logo
