Fault injection stacktrace filter for x86-64?

2018-07-23 Thread Gal Pressman
According to commit [1], dwarf2 unwinder had some issues that prevented the fault injection stacktrace filter from working on x86-64. Does anyone know whether this issue still exists 11 years later? Are there any objections to revert this patch? Gal [1] 6d690dcac92a ("fault injection: disable st

Re: rfc: bool structure members (was Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent)

2018-12-23 Thread Gal Pressman
On 22-Dec-18 01:52, Jason Gunthorpe wrote: > On Thu, Dec 20, 2018 at 09:12:43PM -0800, Joe Perches wrote: >> Care to submit a coding_style.rst patch or >> improve the one below this? > > I took yours and revised it a little bit. I spent some time looking at > assembly and decided to drop the perfo

Re: [PATCH] [v2]RDMA: add checks for the status of nla_put in ib_nl_send_msg

2019-01-08 Thread Gal Pressman
On 05-Jan-19 19:09, Aditya Pakki wrote: > > static int ib_nl_get_path_rec_attrs_len(ib_sa_comp_mask comp_mask) > @@ -856,7 +873,10 @@ static int ib_nl_send_msg(struct ib_sa_query *query, > gfp_t gfp_mask) > } > > /* Add attributes */ > - ib_nl_set_path_rec_attrs(skb, query); >

Re: rfc: bool structure members (was Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent)

2018-12-25 Thread Gal Pressman
On 25-Dec-18 01:12, Jason Gunthorpe wrote: > On Sun, Dec 23, 2018 at 06:42:20PM +0200, Gal Pressman wrote: >> On 22-Dec-18 01:52, Jason Gunthorpe wrote: >>> On Thu, Dec 20, 2018 at 09:12:43PM -0800, Joe Perches wrote: >>>> Care to submit a coding_style.rst patch or &

Re: [PATCH 1/4] mm: Trial do_wp_page() simplification

2021-02-03 Thread Gal Pressman
> On Tue, Feb 02, 2021 at 12:05:36PM -0500, Peter Xu wrote: > >> > Gal, you could also MADV_DONTFORK this range if you are explicitly >> > allocating them via special mmap. >> >> Yeah I wanted to mention this one too but I just forgot when reply: the issue >> thread previously pasted smells like

Re: [PATCH 1/4] mm: Trial do_wp_page() simplification

2021-02-03 Thread Gal Pressman
On 03/02/2021 16:00, Jason Gunthorpe wrote: > On Wed, Feb 03, 2021 at 02:43:58PM +0200, Gal Pressman wrote: >>> On Tue, Feb 02, 2021 at 12:05:36PM -0500, Peter Xu wrote: >>> >>>>> Gal, you could also MADV_DONTFORK this range if you are explicitly &g

Re: [PATCH 1/4] mm: Trial do_wp_page() simplification

2021-02-02 Thread Gal Pressman
> On Thu, Sep 17, 2020 at 03:03:32PM -0400, Peter Xu wrote: > >> Another side effect I can think of is that we'll bring some uncertainty to >> fork() starting from when page_maybe_dma_pinned() is used, since it's >> sometimes >> bogus (hpage_pincount_available()==false) so some COWs might be trig

Re: [PATCH 0/4] mm/hugetlb: Early cow on fork, and a few cleanups

2021-02-04 Thread Gal Pressman
On 03/02/2021 23:08, Peter Xu wrote: > As reported by Gal [1], we still miss the code clip to handle early cow for > > hugetlb case, which is true. Again, it still feels odd to fork() after using > a > > few huge pages, especially if they're privately mapped to me.. However I do > > agree wit

Re: [PATCH 0/4] Infiniband Subsystem: Remove pci-dma-compat wrapper APIs.

2020-08-09 Thread Gal Pressman
On 09/08/2020 10:24, Suraj Upadhyay wrote: > Hii Developers, > > This patch series will replace all the legacy pci-dma-compat wrappers > with the dma-mapping APIs directly in the INFINIBAND Subsystem. > > This task is done through a coccinelle script which is described in each > commit > m

Re: [PATCH rdma-next 1/8] RDMA/core: Check if client supports IB device or not

2021-04-04 Thread Gal Pressman
On 05/04/2021 8:49, Leon Romanovsky wrote: > From: Parav Pandit > > RDMA devices are of different transport(iWarp, IB, RoCE) and have > different attributes. > Not all clients are interested in all type of devices. > > Implement a generic callback that each IB client can implement to decide > if

Re: [PATCH 03/30] RDMA/hw/efa/efa_com: Stop using param description notation for non-params

2021-01-21 Thread Gal Pressman
On 21/01/2021 11:44, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/infiniband/hw/efa/efa_com.c:801: warning: Excess function parameter > 'note' description in 'efa_com_admin_q_comp_intr_handler' > > Cc: Gal Pressman >

Re: [PATCH v2 4/4] hugetlb: Do early cow when page pinned on src mm

2021-02-07 Thread Gal Pressman
On 05/02/2021 17:51, Peter Xu wrote: > On Fri, Feb 05, 2021 at 02:58:33PM +, Zhang, Wei wrote: >> Hi Peter, > > Hi, Wei, > >> >> Gal and I worked together. We tested the patch v2 and can confirm it is >> working as intended. >> >> Thank you very much for your quick response! > > My thanks t

[PATCH] lib/scatterlist: Remove leftover from sg_page_iter comment

2019-03-28 Thread Gal Pressman
Commit d901b2760dc6 ("lib/scatterlist: Provide a DMA page iterator") added the sg DMA iterator but a leftover remained in the sg_page_iter documentation, remove it. Cc: Jason Gunthorpe Signed-off-by: Gal Pressman --- include/linux/scatterlist.h | 10 +- 1 file changed, 5

Re: [PATCH] lib/scatterlist: Remove leftover from sg_page_iter comment

2019-03-29 Thread Gal Pressman
On 29-Mar-19 11:36, Mukesh Ojha wrote: > > On 3/29/2019 12:44 AM, Gal Pressman wrote: >> Commit d901b2760dc6 ("lib/scatterlist: Provide a DMA page iterator") >> added the sg DMA iterator but a leftover remained in the sg_page_iter >> documentation, remove it. &g

[PATCH v2] lib/scatterlist: Remove leftover from sg_page_iter comment

2019-04-21 Thread Gal Pressman
Commit d901b2760dc6 ("lib/scatterlist: Provide a DMA page iterator") added the sg DMA iterator but a leftover remained in the sg_page_iter documentation as you cannot get the page dma address (only the page itself), fix it. Cc: Jason Gunthorpe Signed-off-by: Gal Pressman Reviewed-

[RESEND PATCH v2] lib/scatterlist: Remove leftover from sg_page_iter comment

2019-04-27 Thread Gal Pressman
Commit d901b2760dc6 ("lib/scatterlist: Provide a DMA page iterator") added the sg DMA iterator but a leftover remained in the sg_page_iter documentation as you cannot get the page dma address (only the page itself), fix it. Cc: Jason Gunthorpe Signed-off-by: Gal Pressman Reviewed-

Re: [PATCH AUTOSEL 5.8 55/62] RDMA/efa: Add EFA 0xefa1 PCI ID

2020-08-22 Thread Gal Pressman
020 at 12:14:16PM -0400, Sasha Levin wrote: >>> > > From: Gal Pressman >>> > > >>> > > [ Upstream commit d4f9cb5c5b224dca3ff752c1bb854250bf114944 ] >>> > > >>> > > Add support for 0xefa1 devices. >>> > > >&

Re: [PATCH 05/14] RDMA/efa: drop double zeroing

2020-09-21 Thread Gal Pressman
lags; > @@ > > x = > - kcalloc > + kmalloc_array > (n,sizeof(*x),flags) > ... > sg_init_table(x,n) > // > > Signed-off-by: Julia Lawall Thanks Julia, Acked-by: Gal Pressman

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-21 Thread Gal Pressman
On 18/09/2020 18:28, Jason Gunthorpe wrote: > On Fri, Sep 18, 2020 at 06:15:52PM +0300, Oded Gabbay wrote: > >> I'm sorry, but you won't be able to convince me here that I need to >> "enslave" my entire code to RDMA, just because my ASIC "also" has some >> RDMA ports. > > You can't recreate commo

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Gal Pressman
On 17/09/2020 20:18, Jason Gunthorpe wrote: > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: >> infrastructure for communication between multiple accelerators. Same >> as Nvidia uses NVlink, we use RDMA that we have inside our ASIC. >> The RDMA implementation we did does NOT support s

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-22 Thread Gal Pressman
On 22/09/2020 14:41, Jason Gunthorpe wrote: > On Mon, Sep 21, 2020 at 02:22:02PM +0300, Gal Pressman wrote: > >> What is considered a RoCE port in this case if it's not compliant with RoCE? >> Sounds like it's an implementation of RDMA over ethernet, not RoCE. >&g

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-22 Thread Gal Pressman
On 22/09/2020 19:14, Jason Gunthorpe wrote: > On Tue, Sep 22, 2020 at 03:46:29PM +0300, Gal Pressman wrote: > >> I agree, that makes sense. >> But assuming Oded actually goes and implements all the needed verbs to get a >> basic functional libibverbs provider (assuming th

Re: [PATCH 1/1] RDMA/core: Don't copy uninitialized stack memory to userspace

2020-06-09 Thread Gal Pressman
On 09/06/2020 11:40, Xidong Wang wrote: > From: xidongwang > > ib_uverbs_create_ah() may copy stack allocated > structs to userspace without initializing all members of these > structs. Clear out this memory to prevent information leaks. Which members are not initialized?