Re: [PATCH 2/6] brcmfmac: Handling the interrupt in ISR directly for non-OOB

2012-08-28 Thread Franky Lin
On 08/28/2012 04:13 AM, Wei Ni wrote: On Tue, 2012-08-28 at 04:06 +0800, Stephen Warren wrote: On 08/27/2012 09:24 AM, Arend van Spriel wrote: On 08/27/2012 12:25 PM, Wei Ni wrote: In case of inband interrupts, if we handle the interrupt in dpc thread, two level of thread switching takes place

Re: [PATCH 2/6] brcmfmac: Handling the interrupt in ISR directly for non-OOB

2012-08-28 Thread Franky Lin
On 08/28/2012 03:39 PM, Stephen Warren wrote: On 08/28/2012 09:45 AM, Franky Lin wrote: On 08/28/2012 04:13 AM, Wei Ni wrote: On Tue, 2012-08-28 at 04:06 +0800, Stephen Warren wrote: On 08/27/2012 09:24 AM, Arend van Spriel wrote: On 08/27/2012 12:25 PM, Wei Ni wrote: In case of inband

Re: [PATCH 2/6] brcmfmac: Handling the interrupt in ISR directly for non-OOB

2012-08-28 Thread Franky Lin
On 08/28/2012 04:04 PM, Stephen Warren wrote: On 08/28/2012 04:01 PM, Franky Lin wrote: On 08/28/2012 03:39 PM, Stephen Warren wrote: On 08/28/2012 09:45 AM, Franky Lin wrote: On 08/28/2012 04:13 AM, Wei Ni wrote: On Tue, 2012-08-28 at 04:06 +0800, Stephen Warren wrote: On 08/27/2012 09:24

Re: [PATCH] brcmfmac: BRCMFMAC should depend on HAS_DMA

2014-08-29 Thread Franky Lin
Hi Geert, On 8/29/2014 9:24 AM, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `brcmf_msgbuf_release_array': msgbuf.c:(.text+0x34dbbe): undefined reference to `dma_unmap_single' drivers/built-in.o: In function `brcmf_proto_msgbuf_detach': (.text+0x34dca4): undefined refe

Re: [PATCH] brcmfmac: Fix kernel oops on resume when request firmware fails.

2017-05-23 Thread Franky Lin
Hi Enric, On Tue, May 23, 2017 at 11:07 AM, Enric Balletbo i Serra wrote: > When request firmware fails, brcmf_ops_sdio_remove is being called and > brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle > the kernel hangs on resume due a NULL pointer dereference in resume > fun

Re: [PATCH] brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain

2017-06-02 Thread Franky Lin
On Fri, Jun 2, 2017 at 10:22 AM, Peter S. Housel wrote: > An earlier change to this function (3bdae810721b) fixed a leak in the > case of an unsuccessful call to brcmf_sdiod_buffrw(). However, the > glob_skb buffer, used for emulating a scattering read, is never used > or referenced after its cont