Re: [RFC PATCH tip 4/5] use BPF in tracing filters

2013-12-08 Thread Frank Ch. Eigler
masami.hiramatsu.pt wrote: > [...] > Anyway, as far as I can see, there looks be two different models of > tracing in our mind. > > A) Fixed event based tracing: In this model, there are several fixed > "events" which well defined with fixed arguments. tracer handles these > events and only use l

Re: [PATCH -tip v6 00/22] kprobes: introduce NOKPROBE_SYMBOL(), cleanup and fixes crash bugs

2013-12-20 Thread Frank Ch. Eigler
Hi - mingo wrote: > [...] > For example a hash table (hashed by probe address) could be used in > addition to the list, to speed up basic operations. In the past, when this sort of behavior popped up, it was due to machine-wide halt/sync operations being done too eagerly. At one point, the kpro

Re: [PATCH 3.15 33/37] Fix gcc-4.9.0 miscompilation of load_balance() in scheduler

2014-08-05 Thread Frank Ch. Eigler
Hi - > >>. I don't disagree it should be > >> disabled by default, but making it unconditional is going to force the > >> distributions that care about perf, systemtap, and debuggers to > >> manually revert this. > > > > Bah. I bet I use 'perf' more than most, and it doesn't care about > > debug

Re: [PATCH 3.15 33/37] Fix gcc-4.9.0 miscompilation of load_balance() in scheduler

2014-08-05 Thread Frank Ch. Eigler
Hi - On Tue, Aug 05, 2014 at 03:36:39PM -0700, Linus Torvalds wrote: > > Actually, "perf probe" does (via HAVE_DWARF_SUPPORT), to place probes > > and to extract variables at those probes, much as systemtap does. > > Without var-tracking, probes placed at most interior points of > > functions will

systemtap 2.9 release

2015-10-08 Thread Frank Ch. Eigler
http://tinyurl.com/stapdyn-PR-list) if you want all the gory details about the state of the feature. = Contributors for this release Abegail Jakop, David Smith, Felix Lu, Frank Ch. Eigler, Ivan Diorditsa*, Jose Castillo*, Josh Stone, Lukas Berk, Mark Wielaard, Martin Ce

Re: [PATCH 2/3] module: Fix up module_notifier return values.

2019-06-24 Thread Frank Ch. Eigler
Hi - > > While auditing all module notifiers I noticed a whole bunch of fail > > wrt the return value. Notifiers have a 'special' return semantics. >From peterz's comments, the patches, it's not obvious to me how one is to choose between 0 (NOTIFY_DONE) and 1 (NOTIFY_OK) in the case of a routine

Re: Code of Conduct: Let's revamp it.

2018-09-21 Thread Frank Ch. Eigler
Rik van Riel writes: > [...] The goal of the code of conduct is to make the community > welcoming, and to help people with being a part of the Linux > community. [...] That may well be the goal. But the proper way to evaluate policy is not the laudability of its goals but its forseeable and/o

systemtap 3.3 release

2018-06-08 Thread Frank Ch. Eigler
nut butter and chocolate = Contributors for this release Aaron Merey, *Aryeh Weinreb, *Bernhard Wiedemann, David Smith, Frank Ch. Eigler, *Gustavo Moreira, *Igor Gnatenko, *Iryna Shcherbina, *Jafeer Uddin, Jeff Moyer, *Lukas Herbolt, Mark Wielaard, Martin Cermak, *Petr Viktorin, Serhei Makarov,

Re: [RFC][PATCH] x86: Verify access_ok() context

2017-01-19 Thread Frank Ch. Eigler
Hi, Thomas - On Thu, Jan 19, 2017 at 07:12:48PM +0100, Thomas Gleixner wrote: > [...] > It does matter very much, because the fact that the warning triggers tells > me that it's placed in code which is NOT executed in task context. > [...] > We are not papering over problems. Understood. We were

Re: [RFC][PATCH] x86: Verify access_ok() context

2017-01-19 Thread Frank Ch. Eigler
Hi, Thomas - > Well, if you are not in thread context then the check is pointless: > __range_not_ok(addr, size, user_addr_max()) > and: > #define user_addr_max() (current->thread.addr_limit.seg) > > So what guarantees when you are not in context of current, i.e. in thread > context, that th

Re: BPF runtime for systemtap

2016-06-14 Thread Frank Ch. Eigler
brendan.d.gregg wrote: > [...] > Great! Is there a hello world example in there somewhere? I found this: > [...] Yup. Here is a smoke test. (A great many other things are not yet working.) % sudo ./stap -v --runtime=bpf -e 'global foo probe kprobe.function("vfs_read"), kprobe.function("

Re: [RFC][PATCH 00/21] tracing: Inter-event (e.g. latency) support

2017-02-09 Thread Frank Ch. Eigler
Hi, Tom - tom.zanussi wrote: > [...] >> Hmm, this looks a bit hard to understand, I guess that onmatch() means >> "if there is an event which has ts0 variable and the event's key matches >> this key, take some action". > > Yes, that's pretty much it. It's essentially shorthand for this kind of

systemtap 3.0 release

2016-03-27 Thread Frank Ch. Eigler
details about the state of the feature. - An upstream kernel commit #2062afb4f804a put "-fno-var-tracking-assignments" into KCFLAGS, reducing debuginfo quality which can cause debuginfo failures. A proposed workaround to this issue exists in: https://lkml.org/lkml/2014/11/21/

systemtap 4.3 release

2020-06-11 Thread Frank Ch. Eigler
ses a segment register. (PR13429) - The presence of a line such as *CFLAGS += $(call cc-option, -fno-var-tracking-assignments) in the linux kernel Makefile unnecessarily reduces debuginfo quality, consider removing that line if you build kernels. = Contributors for this release Aaron

Re: [PATCH v4 00/10] Function Granular KASLR

2020-08-03 Thread Frank Ch. Eigler
Hi - > > While this does seem to be the right solution for the extant problem, I > > do want to take a moment and ask if the function sections need to be > > exposed at all? What tools use this information, and do they just want > > to see the bounds of the code region? (i.e. the start/end of all

Re: [PATCH v4 00/10] Function Granular KASLR

2020-08-03 Thread Frank Ch. Eigler
Hi - On Mon, Aug 03, 2020 at 01:11:27PM -0700, Kees Cook wrote: > [...] > > Systemtap needs to know base addresses of loaded text & data sections, > > in order to perform relocation of probe point PCs and context data > > addresses. It uses /sys/module/, kind of under protest, because > > the

Re: [PATCH v4 00/10] Function Granular KASLR

2020-08-03 Thread Frank Ch. Eigler
Hi - > > We have relocated based on sections, not some subset of function > > symbols accessible that way, partly because DWARF line- and DIE- based > > probes can map to addresses some way away from function symbols, into > > function interiors, or cloned/moved bits of optimized code. It would >

Re: [PATCH v5 00/21] kprobes: Unify kretprobe trampoline handlers and make kretprobe lockless

2020-09-07 Thread Frank Ch. Eigler
Masami Hiramatsu writes: > Sorry, for noticing this point, I Cc'd to systemtap. Is systemtap taking > care of spinlock too? On PRREMPT_RT configurations, systemtap uses the raw_spinlock_t types/functions, to keep its probe handlers as atomic as we can make them. - FChE

systemtap release 4.4

2020-11-09 Thread Frank Ch. Eigler
s release Aaron Merey, Alice Zhang, Craig Ringer, Frank Ch. Eigler, Martin Cermak, Sagar Patel, Sergei Trofimovich*, Serhei Makarov, Stan Cox, Sultan Alsawaf*, Thorsten Glaser*, William Cohen, Yichun Zhang (agentzh) Special thanks to new contributors, marked with '*' above. Special thanks

Re: [PATCH 0/2] perf probe: Support debuginfod client

2020-09-16 Thread Frank Ch. Eigler
Hi - > > Nice, even uses the source code fetching part of the webapi! > > So, can I take that as an Acked-by or Reviewed-by? Sure. > I need to support this in pahole... pahole/dwarves use elfutils, so it already has automatic support. https://sourceware.org/elfutils/Debuginfod.html - FChE

Re: [PATCH 0/2] perf probe: Support debuginfod client

2020-09-17 Thread Frank Ch. Eigler
Hi - > > > I need to support this in pahole... > > > > pahole/dwarves use elfutils, so it already has automatic support. > > https://sourceware.org/elfutils/Debuginfod.html > > I'm still not sure that which interface of elfutils I should use > for this "automatic" debuginfod support. Are there g

Re: [PATCH 0/2] perf probe: Support debuginfod client

2020-09-16 Thread Frank Ch. Eigler
Hi - Nice, even uses the source code fetching part of the webapi! - FChE

Re: [RFC PATCH tip/master 0/3] kprobes: tracing: kretprobe_instance dynamic allocation

2017-03-29 Thread Frank Ch. Eigler
mhiramat wrote: > Here is a correction of patches to introduce kretprobe_instance > dynamic allocation for avoiding kretprobe silently miss-hits. > [...] Thanks, this looks automatically useful also to systemtap users. - FChE

<    1   2