Re: [PATCH] drm: encoder_slave: respect of_node on i2c encoder init

2013-06-11 Thread Francisco Jerez
Hi, Sebastian Hesselbarth writes: >> - I think we could also drop the call to ->set_config since presumably an >>of-enabled driver grabbed any required info already from the dt. >[...] >> I think this way we could still share encoder slaves across tons of >> platforms, only the init sequence

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-27 Thread Francisco Jerez
Srinivas Pandruvada writes: > Enable HWP boost on Skylake server and workstations. > Please revert this series, it led to significant energy usage and graphics performance regressions [1]. The reasons are roughly the ones we discussed by e-mail off-list last April: This causes the intel_pstate

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-28 Thread Francisco Jerez
Mel Gorman writes: > On Fri, Jul 27, 2018 at 10:34:03PM -0700, Francisco Jerez wrote: >> Srinivas Pandruvada writes: >> >> > Enable HWP boost on Skylake server and workstations. >> > >> >> Please revert this series, it led to significant energy usa

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-28 Thread Francisco Jerez
Srinivas Pandruvada writes: > On Fri, 2018-07-27 at 22:34 -0700, Francisco Jerez wrote: >> Srinivas Pandruvada writes: >> >> > Enable HWP boost on Skylake server and workstations. >> > >> >> Please revert this series, it led to significant energy

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-28 Thread Francisco Jerez
"Pandruvada, Srinivas" writes: > On Sat, 2018-07-28 at 07:14 -0700, Srinivas Pandruvada wrote: >> On Fri, 2018-07-27 at 22:34 -0700, Francisco Jerez wrote: >> > Srinivas Pandruvada writes: >> > >> > > Enable HWP boost on Skylake server and wo

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-30 Thread Francisco Jerez
Mel Gorman writes: > On Sat, Jul 28, 2018 at 01:21:51PM -0700, Francisco Jerez wrote: >> >> Please revert this series, it led to significant energy usage and >> >> graphics performance regressions [1]. The reasons are roughly the ones >> >> we discus

Re: [PATCH] cpufreq: intel_pstate: Limit the scope of HWP dynamic boost platforms

2018-07-30 Thread Francisco Jerez
ants to get benefit of boost, they can still enable boost from > intel_pstate sysfs attribute "hwp_dynamic_boost". > > Fixes: 41ab43c9c89e (cpufreq: intel_pstate: enable boost for Skylake Xeon) > Link: https://bugs.freedesktop.org/show_bug.cgi?id=107410 > Reported-by: Eero T

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-08-01 Thread Francisco Jerez
Giovanni Gherdovich writes: > On Mon, 2018-07-30 at 11:32 -0700, Francisco Jerez wrote: >> Mel Gorman writes: >>  >> > On Sat, Jul 28, 2018 at 01:21:51PM -0700, Francisco Jerez wrote: >> > > > > Please revert this series, it led to significant energy

Re: [PATCH] cpufreq: intel_pstate: Optimize IO boost in non HWP mode

2018-09-17 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Sat, Sep 15, 2018 at 8:53 AM Francisco Jerez wrote: >> >> "Rafael J. Wysocki" writes: >> >> > On Tuesday, September 11, 2018 7:35:15 PM CEST Francisco Jerez wrote: >> >> >> >> "Rafa

Re: [PATCH] OPTIONAL: cpufreq/intel_pstate: fix debugfs_simple_attr.cocci warnings

2018-03-29 Thread Francisco Jerez
mposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Fixes: 9eec7989e762 ("OPTIONAL: cpufreq/intel_pstate: Expose LP controller > parameters via

Re: [kbuild-all] [PATCH] OPTIONAL: cpufreq/intel_pstate: fix debugfs_simple_attr.cocci warnings

2018-03-29 Thread Francisco Jerez
Fabio Estevam writes: > Hi Julia, > > On Thu, Mar 29, 2018 at 4:12 PM, Julia Lawall wrote: >> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE >> for debugfs files. >> >> Semantic patch information: >> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() >> imposes some

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-29 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Wednesday, July 29, 2020 7:46:08 AM CEST Francisco Jerez wrote: >> >> --==-=-= >> Content-Type: multipart/mixed; boundary="=-=-=" >> >> --=-=-= >> Content-Type: text/plain; charset=utf-8 >>

Re: [PATCH v4 1/2] cpufreq: intel_pstate: Rearrange the storing of new EPP values

2020-07-29 Thread Francisco Jerez
caller of that function, > so as to do it before acquiring the mutex, and reduce code duplication > related to the "raw" EPP values processing somewhat. > > No intentional functional impact. > > Signed-off-by: Rafael J. Wysocki Reviewed-by:

Re: [PATCH v7] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-08-10 Thread Francisco Jerez
l happen in the P-state range above the base frequency. Another minor comment below, other than that LGTM: Reviewed-by: Francisco Jerez > [If P-states of the CPUs in the same package are coordinated at the > hardware level, a non-HWP processor may choose a P-state above the >

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-31 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Thursday, July 30, 2020 2:49:34 AM CEST Francisco Jerez wrote: >> > > [cut] > >> >> > >> >> >> >> No, I explicitly dismissed that in my previous reply. >> >> >> > >> &g

Re: [cpufreq] 48fc4efcdd: WARNING:possible_circular_locking_dependency_detected

2020-07-31 Thread Francisco Jerez
kernel test robot writes: > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: 48fc4efcdd584e8f04da8b195262ec38221bd6db ("[PATCH v2 2/2] cpufreq: > intel_pstate: Implement passive mode with HWP enabled") > url: > https://github.com/0day-ci/linux/commits/Rafael-J-

Re: [PATCH] cpufreq: intel_pstate: Optimize IO boost in non HWP mode

2018-09-14 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Tuesday, September 11, 2018 7:35:15 PM CEST Francisco Jerez wrote: >> >> "Rafael J. Wysocki" writes: >> >> > On Thursday, September 6, 2018 6:20:08 AM CEST Francisco Jerez wrote

Re: [PATCH] cpufreq: intel_pstate: Optimize IO boost in non HWP mode

2018-09-04 Thread Francisco Jerez
Srinivas Pandruvada writes: > On Mon, 2018-09-03 at 23:53 -0700, Francisco Jerez wrote: >> Eero Tamminen writes: >> >> > Hi, >> > >> > On 31.08.2018 20:28, Srinivas Pandruvada wrote: >> > ... >> > > As per testing Eero Tamminen,

Re: [PATCH] cpufreq: intel_pstate: Optimize IO boost in non HWP mode

2018-09-05 Thread Francisco Jerez
Srinivas Pandruvada writes: > [...] > >> > > >> > > This patch causes a number of statistically significant >> > > regressions >> > > (with significance of 1%) on the two systems I've tested it >> > > on. On >> > > my >> > >> > Sure. These patches are targeted to Atom clients where some of >>

Re: [PATCH] cpufreq: intel_pstate: Optimize IO boost in non HWP mode

2018-09-11 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Thursday, September 6, 2018 6:20:08 AM CEST Francisco Jerez wrote: >> >> --==-=-= >> Content-Type: multipart/mixed; boundary="=-=-=" >> >> --=-=-= >> Content-Type: text/plain; charset=utf-8 >>

Re: [PATCH] cpufreq: intel_pstate: Optimize IO boost in non HWP mode

2018-09-04 Thread Francisco Jerez
Eero Tamminen writes: > Hi, > > On 31.08.2018 20:28, Srinivas Pandruvada wrote: > ... >> As per testing Eero Tamminen, the results are comparable to the patchset >> https://patchwork.kernel.org/patch/10312259/ >> But he has to watch results for several days to check trend. > > It's close, but the

Re: [RFC/RFT][PATCH] cpufreq: intel_pstate: Work in passive mode with HWP enabled

2020-05-25 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Mon, May 25, 2020 at 3:39 AM Francisco Jerez > wrote: >> >> "Rafael J. Wysocki" writes: >> >> > From: Rafael J. Wysocki >> > >> > Allow intel_pstate to work in the passive mode with HWP

Re: [RFC/RFT][PATCH] cpufreq: intel_pstate: Work in passive mode with HWP enabled

2020-05-26 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > to On Mon, May 25, 2020 at 10:57 PM Francisco Jerez > wrote: >> >> "Rafael J. Wysocki" writes: >> >> > On Mon, May 25, 2020 at 3:39 AM Francisco Jerez >> > wrote: >> >>

Re: [RFC/RFT][PATCH] cpufreq: intel_pstate: Work in passive mode with HWP enabled

2020-05-24 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > From: Rafael J. Wysocki > > Allow intel_pstate to work in the passive mode with HWP enabled and > make it translate the target frequency supplied by the cpufreq > governor in use into an EPP value to be written to the HWP request > MSR (high frequencies are mapped t

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-20 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Fri, Jul 17, 2020 at 2:21 AM Francisco Jerez wrote: >> >> "Rafael J. Wysocki" writes: >> >> > On Wed, Jul 15, 2020 at 11:35 PM Francisco Jerez >> > wrote: >> >> >> >> "R

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-14 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > From: Rafael J. Wysocki > > Allow intel_pstate to work in the passive mode with HWP enabled and > make it set the HWP minimum performance limit (HWP floor) to the > P-state value given by the target frequency supplied by the cpufreq > governor, so as to prevent the

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-15 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Wed, Jul 15, 2020 at 2:09 AM Francisco Jerez wrote: >> >> "Rafael J. Wysocki" writes: >> >> > From: Rafael J. Wysocki >> > >> > Allow intel_pstate to work in the passive mode with HWP enabl

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-27 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Tuesday, July 21, 2020 1:20:14 AM CEST Francisco Jerez wrote: > > [cut] > >> > >> > However, in the active mode the only updater of hwp_req_cached is >> > intel_pstate_hwp_set() and this patch doesn't i

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-28 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Tuesday, July 28, 2020 4:32:22 AM CEST Francisco Jerez wrote: >> >> "Rafael J. Wysocki" writes: >> >> > On Tuesday, July 21, 2020 1:20:14 AM CEST Francisco Jerez wrote: >> > >> > [cut]

Re: [PATCH] cpufreq: intel_pstate: Fix EPP setting via sysfs in active mode

2020-07-28 Thread Francisco Jerez
HWP boost utility and sched > util hooks") > Reported-by: Francisco Jerez > Signed-off-by: Rafael J. Wysocki Reviewed-by: Francisco Jerez > --- > > This patch is on top of https://patchwork.kernel.org/patch/11689347/ > > --- > drivers/cpufreq/intel_pstate.c |

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-21 Thread Francisco Jerez
Srinivas Pandruvada writes: > On Mon, 2020-07-20 at 16:20 -0700, Francisco Jerez wrote: >> "Rafael J. Wysocki" writes: >> >> > On Fri, Jul 17, 2020 at 2:21 AM Francisco Jerez < >> > curroje...@riseup.net> wrote: >> > > "Rafae

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-16 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Wed, Jul 15, 2020 at 11:35 PM Francisco Jerez > wrote: >> >> "Rafael J. Wysocki" writes: >> >> > On Wed, Jul 15, 2020 at 2:09 AM Francisco Jerez >> > wrote: >> >> >> >> &qu