exec.c because these mappings are per
thread, CPU local, and not globally visible.
Tested with xfstests on a QEMU + KVM 32-bits VM booting a kernel with
HIGHMEM64GB enabled.
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
fs/exec.c | 14 +++---
1 file changed, 7
On giovedì 30 giugno 2022 19:38:08 CEST Eric W. Biederman wrote:
> "Fabio M. De Francesco" writes:
>
> > The use of kmap() and kmap_atomic() are being deprecated in favor of
> > kmap_local_page().
> >
> > With kmap_local_page(), the mappings are per thread
On venerdì 8 luglio 2022 22:18:35 CEST Ira Weiny wrote:
> On Thu, Jun 30, 2022 at 06:35:27PM +0200, Fabio M. De Francesco wrote:
> > The use of kmap() and kmap_atomic() are being deprecated in favor of
> > kmap_local_page().
> >
> > With kmap_local_page(), the mapping
kmap_local_page() in copy_string_kernel() instead of
kmap_atomic().
Tested with xfstests on a QEMU + KVM 32-bits VM booting a kernel with
HIGHMEM64GB enabled.
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
I sent a first patch to fs/exec.c for converting kmap() and kmap_atomic()
to
On venerdì 22 luglio 2022 02:14:20 CEST Ira Weiny wrote:
> On Sun, Jul 10, 2022 at 12:01:36PM +0200, Fabio M. De Francesco wrote:
> > The use of kmap_atomic() is being deprecated in favor of
kmap_local_page().
> >
> > With kmap_local_page(), the mappings are per t
Remove camelcase. Issue detected by checkpatch.pl. For now, change only
names of static functions in order to not break the driver's code.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 44
1 file changed, 22 insertions(+
Remove camelcase. Issue detected by checkpatch.pl. For now, change only
names of static functions in order to not break the driver's code.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: No chenges to the code but only to the subject for the
purpose to differentiate this patch be
On Wednesday, April 7, 2021 7:27:38 PM CEST Greg KH wrote:
> On Wed, Apr 07, 2021 at 06:30:00PM +0200, Fabio M. De Francesco wrote:
> > Remove camelcase. Issue detected by checkpatch.pl. For now, change only
> > names of static functions in order to not break the driver's code.
Changes from v2: Remove unnecessary comment. Shortened a function name.
Changes from v1: No changes to the code but only to the subject for the
purpose to differentiate this patch because other removes of camelcase
have been made in other files of the same directory.
Signed-off-by: Fabio M. De
On Thursday, April 8, 2021 8:24:50 AM CEST Greg KH wrote:
> On Wed, Apr 07, 2021 at 08:19:14PM +0200, Fabio M. De Francesco wrote:
> > Changes from v2: Remove unnecessary comment. Shortened a function name.
> > Changes from v1: No changes to the code but only to the subject for the
Remove camelcase. Issue detected by checkpatch.pl. For now, change only
names of static functions in order to not break the driver's code.
Signed-off-by: Fabio M. De Francesco
---
Changes from v3: fix errors in the format of the patch.
Changes from v2: Remove unnecessary comment. Shorte
Remove camelcase in a symbol that is used by several files.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 +-
drivers
On Thursday, April 8, 2021 10:36:32 AM CEST Greg KH wrote:
> On Thu, Apr 08, 2021 at 10:07:14AM +0200, Fabio M. De Francesco wrote:
> > Remove camelcase in a symbol that is used by several files.
>
> What symbol?
>
I'm not sure I understand what you are asking. You mean
On Thursday, April 8, 2021 10:54:09 AM CEST Julia Lawall wrote:
> On Thu, 8 Apr 2021, Fabio M. De Francesco wrote:
> > On Thursday, April 8, 2021 10:36:32 AM CEST Greg KH wrote:
> > > On Thu, Apr 08, 2021 at 10:07:14AM +0200, Fabio M. De Francesco
wrote:
> > > > Rem
On Thursday, April 8, 2021 10:53:01 AM CEST Julia Lawall wrote:
> On Thu, 8 Apr 2021, Fabio M. De Francesco wrote:
> > Remove camelcase in a symbol that is used by several files.
>
> In addition to Greg's suggestion about dropping the b, there are some
> more things yo
Remove camelcase in bFwCurrentInPSMode, a variable used by code
of several subdirectories/files of the driver. Issue detected by
checkpatch.pl.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: Rewrite comment for the purpose of specifying which
variable changes. Shorten its name by
Change the type of fw_current_in_ps_mode from u8 to bool, because
it is used everywhere as a bool and, accordingly, it should be
declared as a bool. Shorten the controlling
expression of an 'if' statement.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/hal/
On Thursday, April 8, 2021 1:55:29 PM CEST Matthew Wilcox wrote:
> On Thu, Apr 08, 2021 at 12:39:54PM +0200, Fabio M. De Francesco wrote:
> > Remove camelcase in bFwCurrentInPSMode, a variable used by code
> > of several subdirectories/files of the driver. Issue detected by
&g
Remove camelcase in bFwCurrentInPSMode, a variable used by code
of several subdirectories/files of the driver. Issue detected by
checkpatch.pl.
Signed-off-by: Fabio M. De Francesco
---
Changes from v2: Discard v2 because it is a diff against v1 instead of a
replacement for v1.
Changes from v1
Remove camelcase in bFwCurrentInPSMode, a variable used by code
of several subdirectories/files of the driver. Issue detected by
checkpatch.pl.
Signed-off-by: Fabio M. De Francesco
---
Changes from v3: Discard v3 because "b_" is not yet removed.
Changes from v2: Discard v2 because it
Remove camelcase in bFwCurrentInPSMode, a variable used by code
of several subdirectories/files of the driver. Issue detected by
checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from
the beginning of the name.
Signed-off-by: Fabio M. De Francesco
---
Chan
On Friday, April 9, 2021 9:22:54 AM CEST Julia Lawall wrote:
> On Fri, 9 Apr 2021, Fabio M. De Francesco wrote:
> > Remove camelcase in bFwCurrentInPSMode, a variable used by code
> > of several subdirectories/files of the driver. Issue detected by
> > checkpatch.pl. Dele
Remove camelcase in bFwCurrentInPSMode, a variable used by code
of several subdirectories/files of the driver. Issue detected by
checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from
the beginning of the name.
Signed-off-by: Fabio M. De Francesco
---
C
On Monday, April 12, 2021 11:42:51 AM CEST Greg KH wrote:
> On Sun, Apr 11, 2021 at 08:48:13PM +0200, Fabio M. De Francesco wrote:
> > Remove cmpk_handle_query_config_rx() because it just initializes a
> > local
> > variable and then returns "void".
> >
>
On Monday, April 12, 2021 11:31:15 AM CEST Greg KH wrote:
> On Sun, Apr 11, 2021 at 07:41:43PM +0200, Fabio M. De Francesco wrote:
> > Remove variable "int ret" which is instantiated but not used.
> >
> > Signed-off-by: Fabio M. De Francesco
> > -
On Monday, April 12, 2021 12:22:03 PM CEST Greg KH wrote:
> On Mon, Apr 12, 2021 at 12:12:34PM +0200, Fabio M. De Francesco wrote:
> > On Monday, April 12, 2021 11:42:51 AM CEST Greg KH wrote:
> > > On Sun, Apr 11, 2021 at 08:48:13PM +0200, Fabio M. De Francesco
wro
Removed spaces before tabs and multiple blank lines from Hal8723BReg.h
for readability improvement. Issues detected by checkpatch.pl.
Fabio M. De Francesco (2):
staging: rtl8723bs: hal Remove spaces before tabs
staging: rtl8723bs: hal: Remove multiple blank lines
drivers/staging/rtl8723bs
Removed spaces before tabs. Issue detected by checkpatch.pl.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 36 ++---
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
b/drivers
Removed unnecessary multiple blank lines. Issue detected by
checkpatch.pl.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
b/drivers/staging/rtl8723bs/hal
On Tuesday, April 13, 2021 9:39:44 AM CEST Greg Kroah-Hartman wrote:
> On Mon, Apr 12, 2021 at 11:02:58PM +0200, Fabio M. De Francesco wrote:
> > Removed camelcase in (some) symbols. Further work is needed.
>
> What symbols did you do this for? What did you change them from a
efined but not used
[-Wunused-const-variable=]".
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 8
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/r
Replaced strncpy() with strscpy() because of compilation time warnings
about possible truncation of output [-Wstringop-truncation].
Furthermore, according to the Linux official documentation, strscpy() is
preferred to strncpy.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8192u
On Tuesday, April 13, 2021 12:56:36 PM CEST Mitali Borkar wrote:
> On Tue, Apr 13, 2021 at 01:44:32PM +0300, Sakari Ailus wrote:
> > On Tue, Apr 13, 2021 at 04:13:04PM +0530, Mitali Borkar wrote:
> > > On Tue, Apr 13, 2021 at 01:01:34PM +0300, Sakari Ailus wrote:
> > > > Hi Mitali,
> > > >
> > > >
On Tuesday, April 13, 2021 2:59:29 PM CEST Greg Kroah-Hartman wrote:
> On Tue, Apr 13, 2021 at 02:30:41PM +0200, Fabio M. De Francesco wrote:
> > Replaced strncpy() with strscpy() because of compilation time warnings
> > about possible truncation of output [-Wstringop-truncati
On Tuesday, April 13, 2021 3:16:17 PM CEST Greg Kroah-Hartman wrote:
> On Tue, Apr 13, 2021 at 03:12:02PM +0200, Fabio M. De Francesco wrote:
> > On Tuesday, April 13, 2021 2:59:29 PM CEST Greg Kroah-Hartman wrote:
> > > On Tue, Apr 13, 2021 at 02:30:41PM +0200, Fabio M. D
Removed "ledBlink_param" because it was set to the value of "pbuf" but was
never reused. This set was made by direct assignment (no helper had been
called), therefore it had no side effect to the location pointed by "pbuf".
Signed-off-by: Fabio M. De Francesco
---
On Tuesday, April 13, 2021 5:16:17 PM CEST Julia Lawall wrote:
> On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > Removed "ledBlink_param" because it was set to the value of "pbuf" but
> > was never reused. This set was made by direct assignment (no helper
Removed the led_blink_hdl() function (declaration, definition, and
caller code) because it's useless. It only seems to check whether or not a
given pointer is NULL. There are other (simpler) means for that purpose.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs
On Tuesday, April 13, 2021 6:04:16 PM CEST Julia Lawall wrote:
> On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > Removed the led_blink_hdl() function (declaration, definition, and
> > caller code) because it's useless. It only seems to check whether or
> > not a gi
On Tuesday, April 13, 2021 6:27:17 PM CEST Julia Lawall wrote:
> On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > On Tuesday, April 13, 2021 6:04:16 PM CEST Julia Lawall wrote:
> > > On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > > > Removed the led_bli
On Tuesday, April 13, 2021 8:20:50 PM CEST Dan Carpenter wrote:
> On Tue, Apr 13, 2021 at 06:47:06PM +0200, Fabio M. De Francesco wrote:
> > On Tuesday, April 13, 2021 6:27:17 PM CEST Julia Lawall wrote:
> > > On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > > >
Removed four variables that were set but not used.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
b/drivers/staging/rtl8723bs
On Tuesday, April 13, 2021 8:57:20 PM CEST Julia Lawall wrote:
> On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > On Tuesday, April 13, 2021 8:20:50 PM CEST Dan Carpenter wrote:
> > > On Tue, Apr 13, 2021 at 06:47:06PM +0200, Fabio M. De Francesco
wrote:
> > > >
On Tuesday, April 13, 2021 9:25:05 PM CEST Julia Lawall wrote:
> On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > On Tuesday, April 13, 2021 8:57:20 PM CEST Julia Lawall wrote:
> > > On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > > > On Tuesday, Apri
On Tuesday, April 13, 2021 9:48:44 PM CEST Matthew Wilcox wrote:
> On Tue, Apr 13, 2021 at 09:45:03PM +0200, Fabio M. De Francesco wrote:
> > 1) The driver doesn't call that function from anywhere else than the
> > macro. 2) You have explained that the macro add its symbol
Removed four variables that were set but not used.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: deleted one blank line.
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal
On Wednesday, April 14, 2021 7:21:50 AM CEST Dan Carpenter wrote:
> On Tue, Apr 13, 2021 at 10:08:32PM +0200, Fabio M. De Francesco wrote:
> > On Tuesday, April 13, 2021 9:48:44 PM CEST Matthew Wilcox wrote:
> > > On Tue, Apr 13, 2021 at 09:45:03PM +0200, Fabio M. De Francesco
On Wednesday, April 14, 2021 9:00:25 AM CEST Dan Carpenter wrote:
> On Wed, Apr 14, 2021 at 08:33:48AM +0200, Fabio M. De Francesco wrote:
> > On Wednesday, April 14, 2021 7:21:50 AM CEST Dan Carpenter wrote:
> > > On Tue, Apr 13, 2021 at 10:08:32PM +0200, Fabio M. De Francesco
Carpenter
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 +++-
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c| 9 -
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 3 ++-
3 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers
On Wednesday, April 14, 2021 2:18:13 PM CEST Greg Kroah-Hartman wrote:
> On Wed, Apr 14, 2021 at 01:52:43PM +0200, Fabio M. De Francesco wrote:
> > Removed the led_blink_hdl() function (declaration and definition).
> > Declared dummy_function() in include/rtw_mlme_ext.h and defined
On Wednesday, April 14, 2021 3:24:14 PM CEST Dan Carpenter wrote:
> On Wed, Apr 14, 2021 at 01:52:43PM +0200, Fabio M. De Francesco wrote:
> > Removed the led_blink_hdl() function (declaration and definition).
> > Declared dummy_function() in include/rtw_mlme_ext.h and defined
Suggested-by: Dan Carpenter
Signed-off-by: Fabio M. De Francesco
---
Changes since v1: Corrected a bad solution to this issue that made use of
an unnecessary dummy function.
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c| 9
On Wednesday, April 14, 2021 7:57:03 PM CEST Greg Kroah-Hartman wrote:
> On Wed, Apr 14, 2021 at 08:48:09PM +0300, Dan Carpenter wrote:
> > On Wed, Apr 14, 2021 at 07:00:41PM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Apr 14, 2021 at 06:26:14PM +0200, Fabio M. D
On Wednesday, April 14, 2021 8:05:59 PM CEST Fabio M. De Francesco wrote:
> On Wednesday, April 14, 2021 7:57:03 PM CEST Greg Kroah-Hartman wrote:
> > On Wed, Apr 14, 2021 at 08:48:09PM +0300, Dan Carpenter wrote:
> > > On Wed, Apr 14, 2021 at 07:00:41PM +0200, Greg Kroah-Hartman
Suggested-by: Matthew Wilcox
Suggested-by: Dan Carpenter
Signed-off-by: Fabio M. De Francesco
---
Changes from v2: no changes.
Changes from v1: Corrected a bad solution to this issue that made use of
an unnecessary dummy function.
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2
comments for having them in line
with the shift.
Fabio M. De Francesco (2):
staging: rtl8723bs: Remove useless led_blink_hdl()
staging: rtl8723bs: Remove everything related with LedBlink
drivers/staging/rtl8723bs/core/rtw_cmd.c | 27 +--
drivers/staging/rtl8723bs/core
: Fabio Aiuto
Reported-by: Greg Kroah-Hartman
Suggested-by: Dan Carpenter
Signed-off-by: Fabio M. De Francesco
---
Changes from v2: Added this patch as 2/2.
Changes from v1: No changes.
drivers/staging/rtl8723bs/core/rtw_cmd.c| 27 ++---
drivers/staging/rtl8723bs/include
: Julia Lawall
Reported-by: Fabio Aiuto
Reported-by: Greg Kroah-Hartman
Suggested-by: Matthew Wilcox
Suggested-by: Dan Carpenter
Signed-off-by: Fabio M. De Francesco
---
Changes from v3: Merged the series into one single patch for avoiding
unnecessary intermediate stages.
Changes from v2: Made a
On Thursday, April 15, 2021 9:28:46 AM CEST Greg Kroah-Hartman wrote:
> On Thu, Apr 15, 2021 at 09:17:31AM +0200, Fabio M. De Francesco wrote:
> > Removed useless led_blink_hdl() prototype and definition.
> > Removed struct LedBlink_param. Removed LedBlink entries in
> > rtw_
Added spaces around operators in file HalBtc8723b1Ant.c. Issue detected
by checkpatch.pl. Spaces are preferred to improve readibility.
Signed-off-by: Fabio M. De Francesco
---
.../staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 98 +--
1 file changed, 49 insertions(+), 49 deletions
Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols
are not used anywhere else, therefore this patch does not break the driver.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16
1 file changed, 8 insertions(+), 8
Added spaces around operators in file HalBtc8723b1Ant.c. Issue detected
by checkpatch.pl. Spaces are preferred to improve readibility.
Signed-off-by: Fabio M. De Francesco
---
Patch v2 adds spaces around an operator at line 1355. Overlooked in v1.
.../staging/rtl8723bs/hal/HalBtc8723b1Ant.c
Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols
are not used anywhere else, therefore this patch does not break the driver.
Signed-off-by: Fabio M. De Francesco
---
Patch v3 changes nothing with respect to v2 and v1. It exists only to cc some
recipients that were
Added spaces around operators in file HalBtc8723b1Ant.h. Issue detected
by checkpatch.pl. Spaces are preferred to improve readibility.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Tuesday, April 6, 2021 6:44:00 PM CEST Julia Lawall wrote:
>
> On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
>
> > Added spaces around operators in file HalBtc8723b1Ant.h. Issue detected
> > by checkpatch.pl. Spaces are preferred to improve readibility.
> >
>
Added spaces around operators in file HalBtc8723b2Ant.c. Issue detected
by checkpatch.pl. Spaces are preferred to improve readibility.
Signed-off-by: Fabio M. De Francesco
---
.../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 78 +--
1 file changed, 39 insertions(+), 39 deletions
Added spaces around operators. Issue detected by checkpatch.pl.
Spaces around operators are preferred to improve readibility.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff
On Wednesday, April 7, 2021 10:18:13 AM CEST Greg KH wrote:
> On Tue, Apr 06, 2021 at 06:00:37PM +0200, Fabio M. De Francesco wrote:
> > Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols
> > are not used anywhere else, therefore this patch does not b
Remove camelcase. Issue detected by checkpatch.pl. The symbols aren't
used in other files, so this change doesn't break the driver's code.
Signed-off-by: Fabio M. De Francesco
---
This is a necessary v2 patch because v1 cannot anymore apply to the current
staging/testing tree
On Wednesday, April 7, 2021 11:17:52 AM CEST Fabio M. De Francesco wrote:
> Remove camelcase. Issue detected by checkpatch.pl. The symbols aren't
> used in other files, so this change doesn't break the driver's code.
>
> Signed-off-by: Fabio M. De Francesco
> -
Remove camelcase. Issue detected by checkpatch.pl. The symbols aren't
used in other files, so this change doesn't break the driver's code.
Signed-off-by: Fabio M. De Francesco
---
Changes since v3: the previous patch cannot anymore be applied to the current
staging-testing.
C
Remove camelcase in bFwCurrentInPSMode, a variable used by code
of several subdirectories/files of the driver. Issue detected by
checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from
the beginning of the name.
Signed-off-by: Fabio M. De Francesco
---
C
On Friday, April 9, 2021 10:04:08 AM CEST Julia Lawall wrote:
> On Fri, 9 Apr 2021, Fabio M. De Francesco wrote:
> > Remove camelcase in bFwCurrentInPSMode, a variable used by code
> > of several subdirectories/files of the driver. Issue detected by
> > checkpatch.pl. Dele
Correct misspelled words in comments of several files. Issue (largely)
detected by checkpatch.pl.
Signed-off-by: Fabio M. De Francesco
---
.../rtl8723bs/include/Hal8192CPhyReg.h| 8 ++---
.../staging/rtl8723bs/include/basic_types.h | 2 +-
drivers/staging/rtl8723bs/include
Correct misspelled words in comments of several files. Issue (largely)
detected by checkpatch.pl.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: Substitute "mispelled" with "misspelled" in Subject
.../rtl8723bs/include/Hal8192CPhyReg.h| 8 ++---
.
| 2 +-
drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
drivers/staging/rtl8723bs/include/wifi.h | 2 +-
16 files changed, 46 insertions(+), 46 deletions(-)
Fabio M. De Francesco
Remove camelcase in bFwCurrentInPSMode, a variable used by code
of several subdirectories/files of the driver. Issue detected by
checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from
the beginning of the name.
Signed-off-by: Fabio M. De Francesco
---
C
| 2 +-
drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
drivers/staging/rtl8723bs/include/wifi.h | 2 +-
16 files changed, 46 insertions(+), 46 deletions(-)
Fabio M. De Francesco
Change the type of fw_current_in_ps_mode from u8 to bool, because
it is used everywhere as a bool and, accordingly, it should be
declared as a bool. Shorten the controlling
expression of an 'if' statement.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/hal/
Correct misspelled words in comments of several files. Issue (largely)
detected by checkpatch.pl.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: Substitute "mispelled" with "misspelled" in Subject.
.../rtl8723bs/include/Hal8192CPhyReg.h| 8 ++---
.
On Friday, April 9, 2021 4:12:37 PM CEST Greg KH wrote:
> On Thu, Apr 08, 2021 at 01:19:42PM +0200, Fabio M. De Francesco wrote:
> > Change the type of fw_current_in_ps_mode from u8 to bool, because
> > it is used everywhere as a bool and, accordingly, it should be
> > declar
Delete local variable "u8 sec_idx" because is declared and set, but never
used.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee
On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote:
> On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote:
> > This patch series removes camelcases, changes the type and use of a
> > variable, and correct misspelled words.
> >
> > Patch 1/3:
Remove camelcase, correct misspelled words in comments, remove an unused
variable, change type and use of another variable. These changes affect
files in different subdirectories of this driver.
Fabio M. De Francesco (4):
staging: rtl8723bs: Remove camelcase in several files
staging
Remove camelcase in bFwCurrentInPSMode, a variable used by code
of several subdirectories/files of the driver. Issue detected by
checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from
the beginning of the name.
Signed-off-by: Fabio M. De Francesco
---
C
Correct misspelled words in comments of several files. Issue (largely)
detected by checkpatch.pl.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: Substitute "mispelled" with "misspelled" in the Subject.
.../rtl8723bs/include/Hal8192CPhyReg.h| 8 ++---
.
Delete local variable "u8 sec_idx" because it is declared and
initialised, but never used.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw
Change the type of fw_current_in_ps_mode from u8 to bool, because
it is used everywhere as a bool and, accordingly, it should be
declared as a bool. Shorten the controlling
expression of an 'if' statement.
Signed-off-by: Fabio M. De Francesco
---
drivers/staging/rtl8723bs/hal/
On Saturday, April 10, 2021 11:32:00 AM CEST Greg KH wrote:
> On Sat, Apr 10, 2021 at 11:22:29AM +0200, Fabio M. De Francesco wrote:
> > Remove camelcase in bFwCurrentInPSMode, a variable used by code
> > of several subdirectories/files of the driver. Issue detected by
> >
On Saturday, April 10, 2021 11:31:16 AM CEST Greg KH wrote:
> On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote:
> > Change the type of fw_current_in_ps_mode from u8 to bool, because
> > it is used everywhere as a bool and, accordingly, it should be
> &g
On Saturday, April 10, 2021 12:31:27 PM CEST Greg KH wrote:
> On Sat, Apr 10, 2021 at 11:56:48AM +0200, Fabio M. De Francesco wrote:
> > On Saturday, April 10, 2021 11:31:16 AM CEST Greg KH wrote:
> > > On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco
wrote:
>
On Saturday, April 10, 2021 1:03:34 PM CEST Greg KH wrote:
> On Sat, Apr 10, 2021 at 12:58:06PM +0200, Fabio M. De Francesco wrote:
> > On Saturday, April 10, 2021 12:31:27 PM CEST Greg KH wrote:
> > > On Sat, Apr 10, 2021 at 11:56:48AM +0200, Fabio M. De Francesco
wrote:
&
On Saturday, April 10, 2021 1:37:30 PM CEST Julia Lawall wrote:
> > That variable has global scope and is assigned at least in:
> What do you mean by global scope? None of the following look like
> references to global variables.
>
> julia
I just mean that fw_current_in_ps_mode is a field of a st
On Saturday, April 10, 2021 2:12:28 PM CEST Julia Lawall wrote:
> On Sat, 10 Apr 2021, Fabio M. De Francesco wrote:
> > On Saturday, April 10, 2021 1:37:30 PM CEST Julia Lawall wrote:
> > > > That variable has global scope and is assigned at least in:
> > > What do y
On Saturday, April 10, 2021 3:24:43 PM CEST Julia Lawall wrote:
> On Sat, 10 Apr 2021, Fabio M. De Francesco wrote:
> > On Saturday, April 10, 2021 2:12:28 PM CEST Julia Lawall wrote:
> > > On Sat, 10 Apr 2021, Fabio M. De Francesco wrote:
> > > > On Saturday, April
Remove camelcase, correct misspelled words in comments, remove an unused
variable, change the type of a variable and its use, change comparisons
with 'true' in controlling expressions.
Changes from v1: Fix a typo in subject of patch 1/5, add patch 5/5.
Fabio M. De Francesco (5):
Remove camelcase in bFwCurrentInPSMode, a variable used by code
of several subdirectories/files of the driver. Issue detected by
checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from
the beginning of the name.
Signed-off-by: Fabio M. De Francesco
---
Ch
Delete local variable "u8 sec_idx" because is declared and set, but never
used.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: No changes.
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: No changes.
.../rtl8723bs/include/Hal8192CPhyReg.h| 8 ++---
.../staging/rtl8723bs/include/basic_types.h | 2 +-
drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
drivers/staging/rtl8723bs/include/hal_com.h | 2
Change a controlling expression within an 'if' statement: don't compare
with 'true'.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: No changes. This related patch is new to this series.
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
1 file changed, 1
1 - 100 of 125 matches
Mail list logo
