Re: [PATCH 4/6] staging: media: atomisp: reformat code comment blocks

On Tue, Apr 20, 2021 at 12:45:04AM +0530, Deepak R Varma wrote: > Reformat code comment blocks according to the coding style guidelines. > This resolves different checkpatch script WARNINGs around block comments. > > Signed-off-by: Deepak R Varma > --- > .../media/atomisp/i2c/atomisp-gc2235.c

staging: rtl8723bs: remove unused code blocks completed?

Hi, I'm trying to search other unused code blocks: grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_' drivers/staging/rtl8723bs/ drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM) drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM) drivers/staging/rt

staging: rtl8723bs: remove unused code blocks completed?

Hi, I'm trying to search other unused code blocks: grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_' drivers/staging/rtl8723bs/ drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM) drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM) drivers/staging/rt

[PATCH] staging: rtl8723bs: remove unused code blocks completed

all blocks left are checked by existing defines. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/TODO b/drivers/staging/rtl8723bs/TODO index 45065fd3fd5d..afa620ceb2d8 100644 --- a/drivers/staging/rtl8723bs/

staging: rtl8723bs: prefer ftrace

Hi, some suggestions before diving in a new task. The following checkpatch issue: -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace #559: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:559: + DBG_871X("%s\n", __func__); simply says to remove the line, due to the existence of

[PATCH 00/15] remove unnecessary logging

remove unnsecessary loggings warned by checkpatch Fabio Aiuto (15): staging: rtl8723bs: remove unnecessary logging in core/rtw_ap.c staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme.c staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme_ext.c staging: rtl8723bs

[PATCH 02/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme.c

E: drivers/staging/rtl8723bs/core/rtw_mlme.c:1223: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1528: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:1528: + DBG_871X("%s\n", __func__); Signed-off-by: Fabio Aiuto ---

[PATCH 01/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_ap.c

1X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1716: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1716: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1740: FILE: drivers/staging/

[PATCH 03/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme_ext.c

race 5355: FILE: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:5355: + DBG_871X("=>%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 5366: FILE: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:5366: + DBG_871X("%s\n", __func__

[PATCH 04/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_pwrctrl.c

FILE: drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:606: + DBG_871X("%s.\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 753: FILE: drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:753: + /* DBG_871X("%s\n", __func__); */ Signed-off-by:

[PATCH 05/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_wlan_util.c

fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1140: FILE: drivers/staging/rtl8723bs/core/rtw_wlan_util.c:1140: + DBG_871X("%s\n", __func__); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c

[PATCH 06/15] staging: rtl8723bs: remove unnecessary logging in hal/HalBtcOutSrc.h

fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 126: FILE: drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h:126: + DbgPrint("%s(): ", __func__);\ and remove the whole unused containing macro BTC_PRINT_F Signed-off-by: F

[PATCH 11/15] staging: rtl8723bs: remove unnecessary logging in hal/rtl8723b_hal_init.c

E: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:1722: +/* DBG_8192C("%s\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.

[PATCH 08/15] staging: rtl8723bs: remove unnecessary logging in hal/odm.c

fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1109: FILE: drivers/staging/rtl8723bs/hal/odm.c:1109: + /* printk("==> %s\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm.c | 2 -- 1 fi

[PATCH 07/15] staging: rtl8723bs: remove unnecessary logging in hal/hal_com_phycfg.c

FILE: drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:265: + /* DBG_871X("<===%s\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_p

[PATCH 10/15] staging: rtl8723bs: remove unnecessary logging in hal/rtl8723b_cmd.c

1X("%s>\n", __func__); */ -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 965: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c:965: + /* DBG_871X("%s>\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl872

[PATCH 09/15] staging: rtl8723bs: remove unnecessary logging in hal/odm_debug.h

ace 135: FILE: drivers/staging/rtl8723bs/hal/odm_debug.h:135: +#define ODM_dbg_exit() { DbgPrint("<== %s\n", __func__); } and removed containing unused macros Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm_debug.h | 2 -- 1 file changed, 2 deletions(-) di

[PATCH 13/15] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_linux.c

G_871X("%s\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index aac1391bdbf1..590da

[PATCH 15/15] staging: rtl8723bs: remove unnecessary logging in os_dep/wifi_regd.c

fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 153: FILE: drivers/staging/rtl8723bs/os_dep/wifi_regd.c:153: + DBG_8192C("%s\n", __func__); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 2

[PATCH 12/15] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_cfg80211.c

FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2230: + DBG_8192C("%s\n", __func__); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl

[PATCH 14/15] staging: rtl8723bs: remove unnecessary logging in os_dep/os_intfs.c

func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1177: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:1177: + DBG_871X("<=== %s\n", __func__); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 7 --- 1 file c

[PATCH 00/11] staging: rtl8723bs: remove unused variables

se two issues introduced by the patch above. Other patches fix other local issues described in kernel test robot output and other local 'make W=1' compiler warnings. Unnecessary code blocks are removed as well. Fabio Aiuto (11): staging: rtl8723bs: remove unused variable in core/rtw_

[PATCH 01/11] staging: rtl8723bs: remove unused variable in core/rtw_cmd.c

390 | unsigned long cmd_start_time; |^~ Reported-by: kernel test robot Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/stagin

[PATCH 02/11] staging: rtl8723bs: remove unused variable and empty for cycles left unused in os_dep/ioctl_linux.c

for cycle left unused and counter variable. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

[PATCH 04/11] staging: rtl8723bs: remove unused variables and code block left unused in os_dep/ioctl_linux.c

*preorder_ctrl; ^ remove also unnecessary conditional code block. Reported-by: kernel test robot Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging

[PATCH 03/11] staging: rtl8723bs: remove unused code block in os_dep/ioctl_linux.c

remove unused code block which does nothing. A list is parsed but no value is written outside the scope of the function rtw_dbg_port. Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/os_dep/ioctl_linux.c| 20 --- 1 file changed, 20 deletions(-) diff --git a/drivers

[PATCH 05/11] staging: rtl8723bs: remove set but unused psta variable in rtw_dbg_port() in os_dep/ioctl_linux.c

; ^~~~ Remove also the function call that sets this variable. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

[PATCH 06/11] staging: rtl8723bs: remove unused variable pstapriv in rtw_dbg_port() in os_dep/ioctl_linux.c

-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index d4392459082d..ae74623bf1a1 100644 --- a/drivers/staging/rtl8723bs

[PATCH 07/11] staging: rtl8723bs: remove unused cur_network variable in rtw_dbg_port() in os_dep/ioctl_linux.c

priv->cur_network); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index ae74623bf1a1..2f215e5e28b0 100644 --- a/drivers/

[PATCH 08/11] staging: rtl8723bs: remove unused pmlmepriv variable in rtw_dbg_port() in os_dep/ioctl_linux.c

lmepriv); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index 2f215e5e28b0..0ff6fbbb4e4f 100644 --- a/drivers/staging/rt

[PATCH 09/11] staging: rtl8723bs: remove unused variable declaration in include/rtw_security.h

fix following kernel test robot warning: At top level: drivers/staging/rtl8723bs/include/rtw_security.h:336:28: warning: 'K' defined but not used [-Wunused-const-variable=] 336 | static const unsigned long K[64] = { |^ Signed-off-by: F

[PATCH 10/11] staging: rtl8723bs: remove unused variable in os_dep/ioctl_linux.c

: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index 0ff6fbbb4e4f..6f52b8fb0d6e 100644 --- a/drivers/staging/rtl8723bs/os_dep

[PATCH 11/11] staging: rtl8723bs: remove decl of unused static const variable in os_dep/ioctl_linux.c

ation_mode[] = { | ^ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index 6f52b8fb0d6e..e5f0cdc97

Re: [PATCH 02/10] staging: rtl8723bs: remove commented out RT_TRACE logs in hal/ and os_dep/

On Fri, Apr 09, 2021 at 01:12:53PM +0300, Dan Carpenter wrote: > On Mon, Apr 05, 2021 at 06:49:49PM +0200, Fabio Aiuto wrote: > > diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c > > b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c > > index 9b16265b543d..f52cc4e7

[PATCH 0/3] staging: rtl8723bs: remove MGS_8192C trace logs

This patchset removes the tracing private macro MSG_8192C. This macro belongs to a redundant driver specific tracing macro family. Moreover the default behaviour is _do nothing_ as to activate it, it's necessary to hardcode a DEBUG symbol definition. Fabio Aiuto (3): staging: rtl8

[PATCH 1/3] staging: rtl8723bs: remove all MSG_8192C logs

remove all MSG_8192C logs. MSG_8192C is a private trace mechanism macro and is deactivated. (i.e. the default behaviour is _do nothing_) The only way to activate it is to manually define a debug symbol. So just remove it. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal

[PATCH 2/3] staging: rtl8723bs: remove commented out MSG_8192C log

remove commented out MSG_8192C log. MSG_8192C is a private trace mechanism macro and is deactivated. (i.e. the default behaviour is _do nothing_) The only way to activate it is to manually define a debug symbol. So just remove it. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal

[PATCH 3/3] staging: rtl8723bs: remove MSG_8192C macro definitions

remove obsolete MSG_8192C macro definitions. MSG_8192C is a private trace mechanism macro and is deactivated. (i.e. the default behaviour is _do nothing_) The only way to activate it is to manually define a debug symbol. So just remove it. Signed-off-by: Fabio Aiuto --- drivers/staging

[PATCH 00/25] staging: rtl8723bs: remove DBG_8192C tracing macro

subsequent patches do some code cleaning in all places left empty by deleted macro, such as empty #ifdef blocks, conditional code blocks guarded by never defined symbols if-else blocks, for cycles, commented debug symbol definitions, unnecessary parentheses and some other checkpatch issues. Fabio Aiuto (25

[PATCH 02/25] staging: rtl8723bs: remove all commented out DBG_8192C logs

remove all commented out DBG_8192C logs. Macro DBG_8192C belongs to a family of verbose private tracing macros. The default behaviour is _do nothing_, to activate it one should define DEBUG symbol by hand. So just remove it Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core

[PATCH 01/25] staging: rtl8723bs: remove all DBG_8192C logs

); | - DBG_8192C(a, b, c, d, e, f, g, h, i); | - DBG_8192C(a, b, c, d, e, f, g, h, i, j); | - DBG_8192C(a, b, c, d, e, f, g, h, i, j, k); ) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 1 - drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 7 - drivers

[PATCH 04/25] staging: rtl8723bs: remove all if-blocks left empty by DBG_8192C-remove coccinelle script

remove all empty if blocks left empty by coccinelle script for DBG_8192C macro removal. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_ops.c| 17 - .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 15 +-- 2 files changed, 1 insertion

[PATCH 03/25] staging: rtl8723bs: remove DBG_8192C macro definitions

remove all DBG_8192C macro definitions. Macro DBG_8192C belongs to a family of verbose private tracing macros. The default behaviour is _do nothing_, to activate it one should define DEBUG symbol by hand. So just remove it Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include

[PATCH 06/25] staging: rtl8723bs: remove unused code blocks guarded by DEBUG_RTL871X

remove unused code blocks guarded by never set DEBUG_RTL871X Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_debug.c| 35 --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 20 --- 2 files changed, 55 deletions(-) diff --git a/drivers/staging

[PATCH 05/25] staging: rtl8723bs: put spaces around operators

_ielen) CHECK: spaces preferred around that '-' (ctx:VxV) 89: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2431: + rtw_get_wps_ie(pbuf+_FIXED_IE_LENGTH_, len-_FIXED_IE_LENGTH_, ^ NULL, &wps_ielen); Signed-off-by: Fabio

[PATCH 07/25] staging: rtl8723bs: remove commented out DEBUG_RTL871X definition

remove commented out DEBUG_RTL871X definition Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/autoconf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/autoconf.h b/drivers/staging/rtl8723bs/include/autoconf.h index 996198750814

[PATCH 08/25] staging: rtl8723bs: remove code blocks guarded by DEBUG symbol

remove code blocks guarded by DEBUG symbol remove undefinition of DEBUG Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 5 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 25 --- drivers/staging/rtl8723bs/include/autoconf.h | 5 3

[PATCH 09/25] staging: rtl8723bs: remove empty code block guarded by DBG_CCX

remove code block guarded by DBG_CCX symbol, left empty after DBG_8192C removal. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs

[PATCH 10/25] staging: rtl8723bs: remove code block guarded by undefined SDIO_DEBUG_IO

remove code block guarded by SDIO_DEBUG_IO symbol. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index

[PATCH 11/25] staging: rtl8723bs: remove commented out SDIO_DEBUG_IO symbol definition

remove commented out SDIO_DEBUG_IO symbol definition. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index 24e45f734bdd

[PATCH 12/25] staging: rtl8723bs: remove empty ifdef blocks conditioned to DEBUG_CFG80211 definition

remove empty ifdef blocks conditioned to DEBUG_CFG80211 definition. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs

[PATCH 13/25] staging: rtl8723bs: remove commented out DEBUG_CFG80211 symbol definition

remove commented out DEBUG_CFG80211 symbol definition. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/autoconf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/autoconf.h b/drivers/staging/rtl8723bs/include/autoconf.h index 074fee2052c9

[PATCH 14/25] staging: rtl8723bs: remove unnecessary bracks

remove unnecessary bracks in if-else blocks Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +- drivers/staging/rtl8723bs/hal/hal_com.c | 3 +- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 9 +-- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 63

[PATCH 15/25] staging: rtl8723bs: fix comparison to null

Comparison to NULL could be written "!padapter" 481: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:240: + if (padapter == NULL) CHECK: Comparison to NULL could be written "!padapter" 492: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:256: + if (padapter == NULL) Si

[PATCH 16/25] staging: rtl8723bs: put spaces around operators

-- CHECK: spaces preferred around that '|' (ctx:VxV) 392: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2485: + if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) != true) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 +++--- driv

[PATCH 17/25] staging: rtl8723bs: split long line

fix following post-commit hook checkpatch issue: WARNING: line length of 103 exceeds 100 columns 168: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:1086: + if (efuse_OneByteRead(padapter, efuse_addr, &efuse_data, bPseudoTest) == false) Signed-off-by: Fabio A

[PATCH 18/25] staging: rtl8723bs: put constant on the right side of the test

fix following post-commit hook checpatch issues: WARNING: Comparisons should place the constant on the right side of the test 287: FILE: drivers/staging/rtl8723bs/hal/sdio_halinit.c:738: + if (_SUCCESS != ret) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_halinit.c

[PATCH 19/25] staging: rtl8723bs: remove empty if and else blocks

remove if and else blocks after DBG_8192C removal Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 1 - .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 - drivers/staging/rtl8723bs/hal/sdio_ops.c | 1 - .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c

[PATCH 21/25] staging: rtl8723bs: remove unnecessary parentheses in os_dep/ioctl_cfg80211.c

ev->wiphy) { cfg80211_scan_done(pwdev_priv->scan_request, &info); } Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/driver

[PATCH 20/25] staging: rtl8723bs: put constant on the right side of a test in os_dep/ioctl_cfg80211.c

fix following post-commit hook checkpatch issue: CHECK: Comparison to NULL could be written "psta" 72: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:854: + if (psta != NULL) { Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg8

[PATCH 22/25] staging: rtl8723bs: remove empty else block in os_dep/ioctl_cfg80211.c

remove empty else-block Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index 39d0a0d24d2b..9c98820952e4

[PATCH 23/25] staging: rtl8723bs: fix comparison to true issue

fix following post-commit hook checkpatch issue: CHECK: Using comparison to true is error prone 136: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c: 2497: + if (psta->dot8021xalg != 1 || psta->bpairwise_key_installed == true) { Signed-off-by: Fabio

[PATCH 24/25] staging: rtl8723bs: remove more unnecessary parentheses

remove more unnecessary parentheses after DBG_8192C deletion. Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 21 --- .../staging/rtl8723bs/hal/rtl8723bs_recv.c| 4 ++-- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH 25/25] staging: rtl8723bs: remove more empty if blocks after DBG_8192C deletion

remove more empty if-blocks after DBG_8192C deletion. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c index

[PATCH 0/3] staging: rtl8723bs: fix compiler 'W=1' warnings

://lore.kernel.org/linux-staging/202104110133.bi35nins-...@intel.com/ 2. Fixes two long lines checkpatch issues 3. Removes unused variable Fabio Aiuto (3): staging: rtl8723bs: remove unused variable ret in hal/sdio_halinit.c staging rtl8723bs: split long lines staging: rtl8723bs: remove unused

[PATCH 1/3] staging: rtl8723bs: remove unused variable ret in hal/sdio_halinit.c

881 | u8 ret = _FAIL; | ^~~ Reported-by: kernel test robot Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_ha

[PATCH 2/3] staging rtl8723bs: split long lines

of 119 exceeds 100 columns 41: FILE: drivers/staging/rtl8723bs/hal/sdio_halinit.c:912: + HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_card_disable_flow); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 -- 1

[PATCH 3/3] staging: rtl8723bs: remove unused variable 'start' in hal/sdio_halinit.c

unsigned long start; |^~~~~ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c index 552afbaff081..28bb4aaedc5b 100644 -

[PATCH v2 00/30] staging: rtl8723bs: remove RT_TRACE logs in core/*

acing doomed to be removed. --- Changes in v2: - isolate checkpatch fixes in separate patches - removed two if conditions in core/rtw_wlan_util.c Fabio Aiuto (30): staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c staging: rtl8723bs: fix cond

[PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 82 ++- 1 file changed, 7 insertions(+), 75 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index

[PATCH v2 02/30] staging: rtl8723bs: fix condition in if statement

fix condition warned by post-hook checkpatch CHECK: Using comparison to true is error prone 71: FILE: drivers/staging/rtl8723bs/core/rtw_xmit.c:565: + ((padapter->securitypriv.sw_encrypt == true) || (psecuritypriv->hw_decrypted == false))) Signed-off-by:

[PATCH v2 03/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.c

remove all RT_TRACE logs in core/rtw_security.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_security.c | 40 +-- 1 file changed, 1 insertion(+), 39 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core

[PATCH v2 05/30] staging: rtl8723bs: fix spaces around operator issues

x27; (ctx:VxV) 26: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:730: + crc[1] != payload[length-3] || crc[0] != payload[length-4]) ^ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_security.c | 4 ++-- 1 fi

[PATCH v2 04/30] staging: rtl8723bs: fix line exceed warning

] != payload[length-4]) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_security.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c index 689419a76d94..663a8ea199ee

[PATCH v2 06/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_eeprom.c | 56 - 1 file changed, 22 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_eeprom.c b/drivers/staging/rtl8723bs/core/rtw_eeprom.c index

[PATCH v2 07/30] staging: rtl8723bs: fix error prone if conditions

ue is error prone 121: FILE: drivers/staging/rtl8723bs/core/rtw_eeprom.c:149: + if (padapter->bSurpriseRemoved == true) CHECK: Using comparison to true is error prone 130: FILE: drivers/staging/rtl8723bs/core/rtw_eeprom.c:155: + if (padapter->bSurpriseRemoved == true) Signed-off-by:

[PATCH v2 09/30] staging: rtl8723bs: fix logical continuation issue

&& (pslv >= PS_STATE_S2))) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index cc1b0d1a5a7b..fa061

[PATCH v2 08/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_pwrctrl.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 54 ++-- 1 file changed, 4 insertions(+), 50 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index

[PATCH v2 10/30] staging: rtl8723bs: remove unnecessary parentheses in if-condition

mp; (pslv >= PS_STATE_S2))) CHECK: Unnecessary parentheses around 'pslv >= PS_STATE_S2' 26: FILE: drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:269: + if ((pwrpriv->rpwm == pslv) || + ((pwrpriv->rpwm >= PS_STATE_S2) && (pslv &

[PATCH v2 11/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c

remove all RT_TRACE logs removed a variable, left unused after RT_TRACE removal Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 53 +++- 1 file changed, 6 insertions(+), 47 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b

[PATCH v2 12/30] staging: rtl8723bs: fix null check conditions

/core/rtw_cmd.c:2066: + if (psta == NULL) CHECK: Comparison to NULL could be written "!psta" 211: FILE: drivers/staging/rtl8723bs/core/rtw_cmd.c:2081: + if (psta == NULL) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 +++--- 1 file changed, 3 inser

[PATCH v2 13/30] staging: rtl8723bs: remove unnecessary parentheses in if condition

fix post commit hook issue: WARNING: Unnecessary parentheses 166: FILE: drivers/staging/rtl8723bs/core/rtw_cmd.c:2000: + if ((pcmd->res != H2C_SUCCESS)) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH v2 14/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c

remove commented RT_TRACE calls in core/rtw_mlme.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 29d4b7493784

[PATCH v2 15/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 105 -- 1 file changed, 15 insertions(+), 90 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index

[PATCH v2 16/30] staging: rtl8723bs: tidy up some error handling

the RT_TRACE() output is not useful so we want to delete it. In this case there is no cleanup for rtw_cleanbss_cmd() required or even possible. I've deleted the RT_TRACE() output and added a goto unlock to show that we can't continue if rtw_createbss_cmd() fails. Signed-off-by: F

[PATCH v2 17/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 39 +++ 1 file changed, 5 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index

[PATCH v2 19/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_recv.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 134 +- 1 file changed, 6 insertions(+), 128 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index

[PATCH v2 18/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c

remove commented RT_TRACE calls in core/rtw_recv.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index 608a59286505

[PATCH v2 20/30] staging: rtl8723bs: added spaces around operator

fix post-commit hook issue: CHECK: spaces preferred around that '+' (ctx:VxV) 60: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:359: + if (miccode[i] != *(pframemic+i)) ^ Signed-off-by: F

[PATCH v2 24/30] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c

remove commented RT_TRACE call in core/rtw_ioctl_set.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c index

[PATCH v2 22/30] staging: rtl8723bs: remove unnecessary parentheses

_grpkey == false) && + (IS_MCAST(prxattrib->ra) == true)) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rt

[PATCH v2 26/30] staging: rtl8723bs: place constant on the right side of the test

69: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:122: + if (_SUCCESS != ret) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH v2 25/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ioctl_set.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_ioctl_set.c| 76 +-- 1 file changed, 4 insertions(+), 72 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c index

[PATCH v2 21/30] staging: rtl8723bs: split long line

fix post-commit hook checkpatch issue: WARNING: line length of 113 exceeds 100 columns 110: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381: + if ((psecuritypriv->bcheck_grpkey == false) && (IS_MCAST(prxattrib->ra) == true)) Signed-off-b

[PATCH v2 23/30] staging: rtl8723bs: fix comparison in if condition

fix post-commit checkpatch issue: CHECK: Using comparison to false is error prone 27: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381: + if (psecuritypriv-> bcheck_grpkey == false && Signed-off-by: Fabio Aiuto --- driv

[PATCH v2 27/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_wlan_util.c| 24 --- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index

[PATCH v2 28/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 25 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c index f96dd0b40e04

[PATCH v2 30/30] staging: rtl8723bs: add spaces around operators

cnt += in_ie[cnt+1]+2; /* get next */ ^ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c

[PATCH v2 29/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_ieee80211.c| 90 --- 1 file changed, 15 insertions(+), 75 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index

Re: [PATCH 14/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c

On Fri, Apr 02, 2021 at 11:37:17AM -0700, Joe Perches wrote: > On Fri, 2021-04-02 at 19:40 +0200, Fabio Aiuto wrote: > > On Fri, Apr 02, 2021 at 08:20:17AM -0700, Joe Perches wrote: > > > On Fri, 2021-04-02 at 14:51 +0200, Fabio Aiuto wrote: > > > > On Fri, Apr 02,

<    1   2   3   4   5   6   >